From 2d99c57a3b9999f8e0f06dcff60674f18023019f Mon Sep 17 00:00:00 2001 From: Artemy <109195690+stalcker2288969@users.noreply.github.com> Date: Sat, 24 Oct 2026 15:30:32 +0700 Subject: [PATCH] Expand server tests and enforce coverage Consolidate server tests under tests/, upgrade them to .NET 10, and add CI coverage thresholds and reports. Expand API and application boundary coverage while fixing related issues in media handling, friend blocking, session crypto, presence, username validation, and local storage. --- .github/workflows/dotnet.yml | 18 +- .../Controllers/SessionControllerTests.cs | 389 ---------------- Govor.API.Tests/Govor.API.Tests.csproj | 31 -- Govor.API.Tests/Hubs/PresenceHubTests.cs | 197 -------- .../Controllers/AuthControllerTests.cs | 246 ---------- .../Controllers/ChatLoadControllerTests.cs | 267 ----------- .../Controllers/MediaControllerTests.cs | 362 --------------- .../Controllers/RefreshControllerTests.cs | 124 ----- .../IntegrationTests/Hubs/ChatsHubTests.cs | 57 --- .../Validators/ChatGroupValidatorTests.cs | 118 ----- .../Validators/FriendshipValidatorTests.cs | 86 ---- .../Validators/InvitationConstantsTests.cs | 105 ----- .../Validators/MessageValidatorTests.cs | 134 ------ .../Validators/PrivateChatValidatorTests.cs | 77 ---- .../Validators/UserConstantsTests.cs | 170 ------- Govor.API/Controllers/MediaController.cs | 2 +- .../Govor.Application.Tests.csproj | 35 -- .../AdminsStuff/InvitationGeneratorTests.cs | 89 ---- .../Authentication/AuthServiceTests.cs | 102 ----- .../FriendRequestCommandServiceTests.cs | 313 ------------- .../Friends/FriendRequestQueryServiceTests.cs | 131 ------ .../Friends/FriendshipServiceTests.cs | 162 ------- .../AccesserToDownloadMediaServiceTests.cs | 294 ------------ .../Messages/MessageCommandServiceTests.cs | 359 --------------- .../Services/Messages/MessagesLoaderTests.cs | 184 -------- .../Services/PingHandlerServiceTests.cs | 65 --- .../Services/ProfileServiceTests.cs | 143 ------ .../PushNotificationServiceTests.cs | 184 -------- .../Services/UserGroupsGetterServiceTests.cs | 70 --- .../UserOnlineStatus/OnlineUserStoreTests.cs | 83 ---- .../Services/UserPrivateChatsCreatorTests.cs | 108 ----- .../UserSessions/UserSessionOpenerTests.cs | 155 ------- .../UserSessions/UserSessionReaderTests.cs | 75 ---- .../UserSessions/UserSessionRefresherTests.cs | 148 ------ .../UserSessions/UserSessionRevokerTests.cs | 168 ------- .../Services/VerifyFriendshipTests.cs | 95 ---- Govor.Application/E2ee/E2eeProtocol.cs | 143 ++++-- .../Friends/FriendsBlockService.cs | 48 +- .../Validators/UsernameValidator.cs | 2 +- Govor.Application/Medias/MediaService.cs | 27 +- .../Storage/LocalStorageService.cs | 25 +- .../UserOnlineStatus/UserPresenceReader.cs | 10 +- .../Crypto/OneTimePreKeysRotator.cs | 11 +- .../UserSessions/Crypto/SessionKeyAttacher.cs | 3 +- .../UserSessions/Crypto/SessionKeysReader.cs | 1 + .../Users/UserSessions/UserSessionOpener.cs | 17 - .../Requests/MediaUploadRequest.cs | 5 +- Govor.Data.Tests/Govor.Data.Tests.csproj | 26 -- .../Repositories/AdminsRepositoryTests.cs | 176 -------- .../FriendshipsRepositoryTests.cs | 191 -------- .../Repositories/GroupRepositoryTests.cs | 308 ------------- .../Repositories/InvitesRepositoryTests.cs | 249 ---------- .../Repositories/MediaAttachmentsTests.cs | 249 ---------- .../Repositories/MessagesRepositoryTests.cs | 398 ---------------- .../PrivateChatsRepositoryTests.cs | 203 --------- .../Repositories/PushTokenRepository.cs | 233 ---------- .../UserSessionsRepositoryTests.cs | 310 ------------- .../Repositories/UsersRepositoryTests.cs | 425 ------------------ Govor.Server.slnx | 7 +- Govor.sln | 133 ++++-- README.md | 6 + docs/diagnostics.md | 2 +- docs/e2ee.md | 2 +- docs/endpoints/groups.md | 2 +- docs/endpoints/push.md | 2 +- docs/endpoints/reactions.md | 2 +- docs/getting-started.md | 3 +- docs/groups.md | 2 +- docs/server-fixes.md | 4 +- tests/API-COVERAGE.md | 86 ++++ tests/APPLICATION-COVERAGE.md | 90 ++++ .../Directory.Build.props | 20 +- tests/Govor.API.Tests/GlobalUsings.cs | 6 + tests/Govor.API.Tests/Govor.API.Tests.csproj | 6 + .../GroupControllerBoundaryTests.cs | 165 +++++++ .../Filters/HubExceptionFilterTests.cs | 89 ++++ .../Notifications/ChatPushWorkerTests.cs | 35 ++ .../NotificationBoundaryTests.cs | 93 ++++ .../Unit/Common/ConfigurationTests.cs | 38 ++ .../Unit/Common/ErrorAndMappingTests.cs | 65 +++ .../AdministrationControllerTests.cs | 135 ++++++ .../Unit/Controllers/AuthControllerTests.cs | 136 ++++++ .../Controllers/ChatLoadControllerTests.cs | 81 ++++ .../Controllers/ControllerFailureTests.cs | 79 ++++ .../FriendsRequestQueryControllerTests.cs | 37 +- .../Controllers/FriendshipControllerTests.cs | 23 +- .../Unit/Controllers/MediaControllerTests.cs | 112 +++++ .../OnlinePingingControllerTests.cs | 31 +- .../Controllers/PrivateChatControllerTests.cs | 59 +++ .../Controllers/ProfileControllerTests.cs | 22 +- .../ReactionPackControllerTests.cs | 92 ++++ .../Controllers/SessionControllerTests.cs | 93 ++++ .../Controllers/SessionKeysControllerTests.cs | 92 ++++ .../Unit/Hubs/ChatsHubTests.cs | 191 ++++++++ .../Unit/Hubs/FriendsHubBoundaryTests.cs | 40 ++ .../Unit}/Hubs/FriendsHubTests.cs | 6 +- .../Unit/Hubs}/HubUserAccessorTests.cs | 7 +- .../Infrastructure/ConnectionStoreTests.cs | 7 +- .../PrivateChatGroupManagerTests.cs | 15 +- .../Unit/Hubs/ProfileAndPresenceHubTests.cs | 153 +++++++ tests/Govor.Application.Tests/GlobalUsings.cs | 10 + .../Govor.Application.Tests.csproj | 6 + .../Administration/AdministrationTests.cs | 105 +++++ .../Authentication/AuthServiceTests.cs | 102 +++++ .../AuthenticationFailureTests.cs | 49 ++ .../Friends/FriendsBlockServiceTests.cs | 80 ++++ .../Integration/Friends/FriendshipTests.cs | 126 ++++++ .../Groups/GroupAvatarBoundaryTests.cs | 85 ++++ .../Groups/GroupManagementBoundaryTests.cs | 78 ++++ .../Integration/Medias/MediaAccessTests.cs | 70 +++ .../Integration/Medias/MediaServiceTests.cs | 110 +++++ .../Messages/MessageCommandBoundaryTests.cs | 154 +++++++ .../Messages/MessagesLoaderTests.cs | 60 +++ .../Integration/Messages/ReadBoundaryTests.cs | 43 ++ .../UserPrivateChatsCreatorTests.cs | 73 +++ .../Profiles/ProfileServiceTests.cs | 62 +++ .../PushTokenServiceTests.cs | 103 +++++ .../Reactions/ReactionPackBoundaryTests.cs | 158 +++++++ .../Reactions/ReactionPolicyBoundaryTests.cs | 66 +++ .../Users/PingHandlerServiceTests.cs | 28 ++ .../Integration/Users/ReaderTests.cs | 48 ++ .../Integration/Users/SessionCryptoTests.cs | 135 ++++++ .../Users/UserSessionFailureTests.cs | 105 +++++ .../Integration/Users/UserSessionTests.cs | 132 ++++++ .../Support/FailDatabaseCommand.cs | 32 ++ .../Unit}/Authentication/JwtServiceTests.cs | 24 +- .../Authentication/JwtTokenHasherTests.cs | 8 +- .../Authentication}/PasswordHasherTests.cs | 9 +- .../Extensions/CurrentUserServiceTests.cs | 8 +- .../CurrentUserSessionServiceTests.cs | 8 +- .../Validators/UsernameBoundaryTests.cs | 52 +++ .../Validators/UsernameValidatorTests.cs | 43 +- .../PushNotificationServiceTests.cs | 147 ++++++ .../Security/E2eeProtocolBoundaryTests.cs | 187 ++++++++ .../Unit/Storage/LocalStorageBoundaryTests.cs | 78 ++++ .../Unit/Storage}/LocalStorageServiceTests.cs | 12 +- .../Unit/Synching}/SynchingServiceTests.cs | 2 +- .../Unit/Users/OnlineUserStoreTests.cs | 43 ++ .../UserNotificationScopeServiceTests.cs | 20 +- tests/Govor.Domain.Tests/GlobalUsings.cs | 1 + .../Govor.Domain.Tests.csproj | 5 + .../Migrations}/GroupMigrationTests.cs | 2 +- .../Persistence/DatabaseConstraintTests.cs | 89 ++++ .../Api/AdditionalApiTests.cs | 94 ++++ .../Govor.Server.Tests/Api}/ReadApiTests.cs | 42 +- .../Govor.Server.Tests.csproj | 6 + .../Govor.Server.Tests/Groups}/GroupTests.cs | 0 .../Groups}/InvitationClockTests.cs | 0 .../Messages}/MessageAccessTests.cs | 0 .../Messages}/ReadConcurrencyTests.cs | 0 .../FirebasePushProviderTests.cs | 29 ++ .../Notifications}/NotificationTests.cs | 1 - .../Notifications}/PushDeliveryTests.cs | 1 - .../Notifications}/PushReliabilityTests.cs | 12 +- .../Reactions}/ReactionMediaTests.cs | 0 .../Reactions}/ReactionTests.cs | 0 .../Govor.Server.Tests/Security}/E2eeTests.cs | 68 ++- .../Security}/HubSessionTests.cs | 0 tests/Measure-ApplicationCoverage.ps1 | 97 ++++ tests/README.md | 126 ++++++ .../Shared}/TestDatabase.cs | 25 +- 161 files changed, 5515 insertions(+), 8419 deletions(-) delete mode 100644 Govor.API.Tests/Controllers/SessionControllerTests.cs delete mode 100644 Govor.API.Tests/Govor.API.Tests.csproj delete mode 100644 Govor.API.Tests/Hubs/PresenceHubTests.cs delete mode 100644 Govor.API.Tests/IntegrationTests/Controllers/AuthControllerTests.cs delete mode 100644 Govor.API.Tests/IntegrationTests/Controllers/ChatLoadControllerTests.cs delete mode 100644 Govor.API.Tests/IntegrationTests/Controllers/MediaControllerTests.cs delete mode 100644 Govor.API.Tests/IntegrationTests/Controllers/RefreshControllerTests.cs delete mode 100644 Govor.API.Tests/IntegrationTests/Hubs/ChatsHubTests.cs delete mode 100644 Govor.API.Tests/UnitTests/Infrastructure/Validators/ChatGroupValidatorTests.cs delete mode 100644 Govor.API.Tests/UnitTests/Infrastructure/Validators/FriendshipValidatorTests.cs delete mode 100644 Govor.API.Tests/UnitTests/Infrastructure/Validators/InvitationConstantsTests.cs delete mode 100644 Govor.API.Tests/UnitTests/Infrastructure/Validators/MessageValidatorTests.cs delete mode 100644 Govor.API.Tests/UnitTests/Infrastructure/Validators/PrivateChatValidatorTests.cs delete mode 100644 Govor.API.Tests/UnitTests/Infrastructure/Validators/UserConstantsTests.cs delete mode 100644 Govor.Application.Tests/Govor.Application.Tests.csproj delete mode 100644 Govor.Application.Tests/Infrastructure/AdminsStuff/InvitationGeneratorTests.cs delete mode 100644 Govor.Application.Tests/Services/Authentication/AuthServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/Friends/FriendRequestCommandServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/Friends/FriendRequestQueryServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/Friends/FriendshipServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/Medias/AccesserToDownloadMediaServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/Messages/MessageCommandServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/Messages/MessagesLoaderTests.cs delete mode 100644 Govor.Application.Tests/Services/PingHandlerServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/ProfileServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/PushNotifications/PushNotificationServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/UserGroupsGetterServiceTests.cs delete mode 100644 Govor.Application.Tests/Services/UserOnlineStatus/OnlineUserStoreTests.cs delete mode 100644 Govor.Application.Tests/Services/UserPrivateChatsCreatorTests.cs delete mode 100644 Govor.Application.Tests/Services/UserSessions/UserSessionOpenerTests.cs delete mode 100644 Govor.Application.Tests/Services/UserSessions/UserSessionReaderTests.cs delete mode 100644 Govor.Application.Tests/Services/UserSessions/UserSessionRefresherTests.cs delete mode 100644 Govor.Application.Tests/Services/UserSessions/UserSessionRevokerTests.cs delete mode 100644 Govor.Application.Tests/Services/VerifyFriendshipTests.cs delete mode 100644 Govor.Data.Tests/Govor.Data.Tests.csproj delete mode 100644 Govor.Data.Tests/Repositories/AdminsRepositoryTests.cs delete mode 100644 Govor.Data.Tests/Repositories/FriendshipsRepositoryTests.cs delete mode 100644 Govor.Data.Tests/Repositories/GroupRepositoryTests.cs delete mode 100644 Govor.Data.Tests/Repositories/InvitesRepositoryTests.cs delete mode 100644 Govor.Data.Tests/Repositories/MediaAttachmentsTests.cs delete mode 100644 Govor.Data.Tests/Repositories/MessagesRepositoryTests.cs delete mode 100644 Govor.Data.Tests/Repositories/PrivateChatsRepositoryTests.cs delete mode 100644 Govor.Data.Tests/Repositories/PushTokenRepository.cs delete mode 100644 Govor.Data.Tests/Repositories/UserSessionsRepositoryTests.cs delete mode 100644 Govor.Data.Tests/Repositories/UsersRepositoryTests.cs create mode 100644 tests/API-COVERAGE.md create mode 100644 tests/APPLICATION-COVERAGE.md rename Govor.Server.Tests/Govor.Server.Tests.csproj => tests/Directory.Build.props (51%) create mode 100644 tests/Govor.API.Tests/GlobalUsings.cs create mode 100644 tests/Govor.API.Tests/Govor.API.Tests.csproj create mode 100644 tests/Govor.API.Tests/Integration/Controllers/GroupControllerBoundaryTests.cs create mode 100644 tests/Govor.API.Tests/Integration/Filters/HubExceptionFilterTests.cs create mode 100644 tests/Govor.API.Tests/Integration/Notifications/ChatPushWorkerTests.cs create mode 100644 tests/Govor.API.Tests/Integration/Notifications/NotificationBoundaryTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Common/ConfigurationTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Common/ErrorAndMappingTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Controllers/AdministrationControllerTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Controllers/AuthControllerTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Controllers/ChatLoadControllerTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Controllers/ControllerFailureTests.cs rename {Govor.API.Tests/IntegrationTests => tests/Govor.API.Tests/Unit}/Controllers/FriendsRequestQueryControllerTests.cs (84%) rename {Govor.API.Tests/IntegrationTests => tests/Govor.API.Tests/Unit}/Controllers/FriendshipControllerTests.cs (89%) create mode 100644 tests/Govor.API.Tests/Unit/Controllers/MediaControllerTests.cs rename {Govor.API.Tests/IntegrationTests => tests/Govor.API.Tests/Unit}/Controllers/OnlinePingingControllerTests.cs (78%) create mode 100644 tests/Govor.API.Tests/Unit/Controllers/PrivateChatControllerTests.cs rename {Govor.API.Tests/IntegrationTests => tests/Govor.API.Tests/Unit}/Controllers/ProfileControllerTests.cs (93%) create mode 100644 tests/Govor.API.Tests/Unit/Controllers/ReactionPackControllerTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Controllers/SessionControllerTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Controllers/SessionKeysControllerTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Hubs/ChatsHubTests.cs create mode 100644 tests/Govor.API.Tests/Unit/Hubs/FriendsHubBoundaryTests.cs rename {Govor.API.Tests/IntegrationTests => tests/Govor.API.Tests/Unit}/Hubs/FriendsHubTests.cs (98%) rename {Govor.API.Tests/Common/SignalR/Helpers => tests/Govor.API.Tests/Unit/Hubs}/HubUserAccessorTests.cs (96%) rename {Govor.API.Tests/IntegrationTests => tests/Govor.API.Tests/Unit}/Hubs/Infrastructure/ConnectionStoreTests.cs (97%) rename {Govor.API.Tests/IntegrationTests => tests/Govor.API.Tests/Unit}/Hubs/Infrastructure/PrivateChatGroupManagerTests.cs (93%) create mode 100644 tests/Govor.API.Tests/Unit/Hubs/ProfileAndPresenceHubTests.cs create mode 100644 tests/Govor.Application.Tests/GlobalUsings.cs create mode 100644 tests/Govor.Application.Tests/Govor.Application.Tests.csproj create mode 100644 tests/Govor.Application.Tests/Integration/Administration/AdministrationTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Authentication/AuthServiceTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Authentication/AuthenticationFailureTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Friends/FriendsBlockServiceTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Friends/FriendshipTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Groups/GroupAvatarBoundaryTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Groups/GroupManagementBoundaryTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Medias/MediaAccessTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Medias/MediaServiceTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Messages/MessageCommandBoundaryTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Messages/MessagesLoaderTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Messages/ReadBoundaryTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/PrivateUserChats/UserPrivateChatsCreatorTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Profiles/ProfileServiceTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/PushNotifications/PushTokenServiceTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Reactions/ReactionPackBoundaryTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Reactions/ReactionPolicyBoundaryTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Users/PingHandlerServiceTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Users/ReaderTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Users/SessionCryptoTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Users/UserSessionFailureTests.cs create mode 100644 tests/Govor.Application.Tests/Integration/Users/UserSessionTests.cs create mode 100644 tests/Govor.Application.Tests/Support/FailDatabaseCommand.cs rename {Govor.Application.Tests/Services => tests/Govor.Application.Tests/Unit}/Authentication/JwtServiceTests.cs (89%) rename {Govor.Application.Tests/Services => tests/Govor.Application.Tests/Unit}/Authentication/JwtTokenHasherTests.cs (93%) rename {Govor.Application.Tests/Services => tests/Govor.Application.Tests/Unit/Authentication}/PasswordHasherTests.cs (87%) rename {Govor.Application.Tests => tests/Govor.Application.Tests/Unit}/Infrastructure/Extensions/CurrentUserServiceTests.cs (95%) rename {Govor.Application.Tests => tests/Govor.Application.Tests/Unit}/Infrastructure/Extensions/CurrentUserSessionServiceTests.cs (95%) create mode 100644 tests/Govor.Application.Tests/Unit/Infrastructure/Validators/UsernameBoundaryTests.cs rename {Govor.Application.Tests => tests/Govor.Application.Tests/Unit}/Infrastructure/Validators/UsernameValidatorTests.cs (58%) create mode 100644 tests/Govor.Application.Tests/Unit/PushNotifications/PushNotificationServiceTests.cs create mode 100644 tests/Govor.Application.Tests/Unit/Security/E2eeProtocolBoundaryTests.cs create mode 100644 tests/Govor.Application.Tests/Unit/Storage/LocalStorageBoundaryTests.cs rename {Govor.API.Tests => tests/Govor.Application.Tests/Unit/Storage}/LocalStorageServiceTests.cs (95%) rename {Govor.Application.Tests/Services => tests/Govor.Application.Tests/Unit/Synching}/SynchingServiceTests.cs (99%) create mode 100644 tests/Govor.Application.Tests/Unit/Users/OnlineUserStoreTests.cs rename {Govor.Application.Tests/Services/UserOnlineStatus => tests/Govor.Application.Tests/Unit/Users}/UserNotificationScopeServiceTests.cs (75%) create mode 100644 tests/Govor.Domain.Tests/GlobalUsings.cs create mode 100644 tests/Govor.Domain.Tests/Govor.Domain.Tests.csproj rename {Govor.Server.Tests => tests/Govor.Domain.Tests/Migrations}/GroupMigrationTests.cs (98%) create mode 100644 tests/Govor.Domain.Tests/Persistence/DatabaseConstraintTests.cs create mode 100644 tests/Govor.Server.Tests/Api/AdditionalApiTests.cs rename {Govor.Server.Tests => tests/Govor.Server.Tests/Api}/ReadApiTests.cs (93%) create mode 100644 tests/Govor.Server.Tests/Govor.Server.Tests.csproj rename {Govor.Server.Tests => tests/Govor.Server.Tests/Groups}/GroupTests.cs (100%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Groups}/InvitationClockTests.cs (100%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Messages}/MessageAccessTests.cs (100%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Messages}/ReadConcurrencyTests.cs (100%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Notifications}/FirebasePushProviderTests.cs (71%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Notifications}/NotificationTests.cs (99%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Notifications}/PushDeliveryTests.cs (99%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Notifications}/PushReliabilityTests.cs (94%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Reactions}/ReactionMediaTests.cs (100%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Reactions}/ReactionTests.cs (100%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Security}/E2eeTests.cs (74%) rename {Govor.Server.Tests => tests/Govor.Server.Tests/Security}/HubSessionTests.cs (100%) create mode 100644 tests/Measure-ApplicationCoverage.ps1 create mode 100644 tests/README.md rename {Govor.Server.Tests => tests/Shared}/TestDatabase.cs (81%) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index c475af9..bd98cf5 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -52,7 +52,23 @@ jobs: run: dotnet build Govor.Server.slnx --no-restore --configuration Release - name: Run tests - run: dotnet test Govor.Server.Tests/Govor.Server.Tests.csproj --no-build --configuration Release + run: dotnet test Govor.Server.slnx --no-build --no-restore --configuration Release --logger trx --results-directory artifacts/test-results --collect "XPlat Code Coverage;Format=json,cobertura" + + - name: Check application coverage + shell: pwsh + run: ./tests/Measure-ApplicationCoverage.ps1 -ResultsDirectory artifacts/test-results + + - name: Check API source coverage + shell: pwsh + run: ./tests/Measure-ApplicationCoverage.ps1 -ResultsDirectory artifacts/test-results -AssemblyName Govor.API -ExcludeGeneratedSources -MinimumLineCoverage 98 -MinimumBranchCoverage 92 + + - name: Upload test results + if: always() + uses: actions/upload-artifact@v4 + with: + name: test-results-${{ matrix.database }} + path: artifacts/test-results + if-no-files-found: ignore publish: needs: build-and-test diff --git a/Govor.API.Tests/Controllers/SessionControllerTests.cs b/Govor.API.Tests/Controllers/SessionControllerTests.cs deleted file mode 100644 index c7d22d5..0000000 --- a/Govor.API.Tests/Controllers/SessionControllerTests.cs +++ /dev/null @@ -1,389 +0,0 @@ -using AutoMapper; -using Govor.API.Controllers; -using Govor.Application.Interfaces.Infrastructure.Extensions; -using Govor.Application.Interfaces.UserSession; -using Govor.Contracts.DTOs; -using Govor.Domain.Models.Users; -using Govor.Data.Repositories.Exceptions; -using Microsoft.AspNetCore.Mvc; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.API.Tests.Controllers; - -[TestFixture] -[TestOf(typeof(SessionController))] -public class SessionControllerTests -{ - private Mock> _loggerMock; - private Mock _currentUserServiceMock; - private Mock _currentUserSessionServiceMock; - private Mock _userSessionReaderMock; - private Mock _userSessionRevokerMock; - private Mock _mapperMock; - private SessionController _controller; - - [SetUp] - public void SetUp() - { - _loggerMock = new Mock>(); - _currentUserServiceMock = new Mock(); - _currentUserSessionServiceMock = new Mock(); - _userSessionReaderMock = new Mock(); - _userSessionRevokerMock = new Mock(); - _mapperMock = new Mock(); - _controller = new SessionController( - _loggerMock.Object, - _currentUserServiceMock.Object, - _currentUserSessionServiceMock.Object, - _userSessionReaderMock.Object, - _userSessionRevokerMock.Object, - _mapperMock.Object); - } - - #region GetAllSessions - [Test] - public async Task GetAllSessions_Successful_ReturnsOkWithMappedSessions() - { - // Arrange - var userId = Guid.NewGuid(); - var sessions = new List { new UserSession { Id = Guid.NewGuid(), UserId = userId } }; - var sessionDtos = new List { new SessionDto { Id = sessions[0].Id } }; - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _userSessionReaderMock.Setup(r => r.GetAllSessionsAsync(userId)).ReturnsAsync(sessions); - _mapperMock.Setup(m => m.Map>(sessions)).Returns(sessionDtos); - - // Act - var result = await _controller.GetAllSessions(); - - // Assert - Assert.That(result, Is.TypeOf()); - var okResult = result as OkObjectResult; - Assert.That(okResult.Value, Is.EqualTo(sessionDtos)); - _loggerMock.VerifyNoOtherCalls(); - } - - [Test] - public async Task GetAllSessions_UnauthorizedAccess_ReturnsForbid() - { - // Arrange - var userId = Guid.NewGuid(); - var exception = new UnauthorizedAccessException("Unauthorized"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _userSessionReaderMock.Setup(r => r.GetAllSessionsAsync(userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.GetAllSessions(); - - // Assert - Assert.That(result, Is.TypeOf()); - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - - [Test] - public async Task GetAllSessions_UnexpectedError_Returns500() - { - // Arrange - var userId = Guid.NewGuid(); - var exception = new Exception("Unexpected error"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _userSessionReaderMock.Setup(r => r.GetAllSessionsAsync(userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.GetAllSessions(); - - // Assert - Assert.That(result, Is.TypeOf()); - var statusResult = result as ObjectResult; - Assert.That(statusResult.StatusCode, Is.EqualTo(500)); - Assert.That(statusResult.Value, Is.EqualTo("Unexpected Error! Please try again later.")); - _loggerMock.Verify(l => l.Log( - LogLevel.Error, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - #endregion - - #region CloseSession - [Test] - public async Task CloseSession_ValidSessionId_ReturnsOk() - { - // Arrange - var userId = Guid.NewGuid(); - var sessionId = Guid.NewGuid(); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - - // Act - var result = await _controller.CloseSession(sessionId); - - // Assert - Assert.That(result, Is.TypeOf()); - _userSessionRevokerMock.Verify(r => r.CloseSessionByIdAsync(sessionId, userId), Times.Once()); - _loggerMock.VerifyNoOtherCalls(); - } - - [Test] - public async Task CloseSession_EmptySessionId_ReturnsBadRequest() - { - // Arrange - var sessionId = Guid.Empty; - - // Act - var result = await _controller.CloseSession(sessionId); - - // Assert - Assert.That(result, Is.TypeOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult.Value, Is.EqualTo("Invalid sessionId.")); - _userSessionRevokerMock.Verify(r => r.CloseSessionByIdAsync(It.IsAny(), It.IsAny()), Times.Never()); - _loggerMock.VerifyNoOtherCalls(); - } - - [Test] - public async Task CloseSession_UnauthorizedAccess_ReturnsForbid() - { - // Arrange - var userId = Guid.NewGuid(); - var sessionId = Guid.NewGuid(); - var exception = new UnauthorizedAccessException("Unauthorized"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.CloseSession(sessionId); - - // Assert - Assert.That(result, Is.TypeOf()); - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - - [Test] - public async Task CloseSession_NotFound_ReturnsNotFound() - { - // Arrange - var userId = Guid.NewGuid(); - var sessionId = Guid.NewGuid(); - var exception = new NotFoundException("Session not found"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.CloseSession(sessionId); - - // Assert - Assert.That(result, Is.TypeOf()); - var notFoundResult = result as NotFoundObjectResult; - Assert.That(notFoundResult.Value, Is.EqualTo("Session not found")); - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - - [Test] - public async Task CloseSession_InvalidOperation_ReturnsBadRequest() - { - // Arrange - var userId = Guid.NewGuid(); - var sessionId = Guid.NewGuid(); - var exception = new InvalidOperationException("Invalid operation"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.CloseSession(sessionId); - - // Assert - Assert.That(result, Is.TypeOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult.Value, Is.EqualTo("Invalid operation")); - _loggerMock.Verify(l => l.Log( - LogLevel.Error, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - #endregion - - #region CloseCurrentSession - [Test] - public async Task CloseCurrentSession_ValidSessionIdAndUserId_ReturnsOk() - { - // Arrange - var userId = Guid.NewGuid(); - var sessionId = Guid.NewGuid(); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _currentUserSessionServiceMock.Setup(s => s.GetUserSessionId()).Returns(sessionId); - - // Act - var result = await _controller.CloseCurrent(); - - // Assert - Assert.That(result, Is.TypeOf()); - _userSessionRevokerMock.Verify(r => r.CloseSessionByIdAsync(sessionId, userId), Times.Once()); - _loggerMock.VerifyNoOtherCalls(); - } - - [Test] - public async Task CloseCurrentSession_UnauthorizedAccess_ReturnsForbid() - { - // Arrange - var userId = Guid.NewGuid(); - var sessionId = Guid.NewGuid(); - var exception = new UnauthorizedAccessException("Unauthorized"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _currentUserSessionServiceMock.Setup(s => s.GetUserSessionId()).Returns(sessionId); - _userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.CloseCurrent(); - - // Assert - Assert.That(result, Is.TypeOf()); - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - - [Test] - public async Task CloseCurrentSession_NotFound_ReturnsNotFound() - { - // Arrange - var userId = Guid.NewGuid(); - var sessionId = Guid.NewGuid(); - var exception = new NotFoundException("Session not found"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _currentUserSessionServiceMock.Setup(s => s.GetUserSessionId()).Returns(sessionId); - _userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.CloseCurrent(); - - // Assert - Assert.That(result, Is.TypeOf()); - var notFoundResult = result as NotFoundObjectResult; - Assert.That(notFoundResult.Value, Is.EqualTo("Session not found")); - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - - [Test] - public async Task CloseCurrentSession_InvalidOperation_ReturnsBadRequest() - { - // Arrange - var userId = Guid.NewGuid(); - var sessionId = Guid.NewGuid(); - var exception = new InvalidOperationException("Invalid operation"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _currentUserSessionServiceMock.Setup(s => s.GetUserSessionId()).Returns(sessionId); - _userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.CloseCurrent(); - - // Assert - Assert.That(result, Is.TypeOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult.Value, Is.EqualTo("Invalid operation")); - _loggerMock.Verify(l => l.Log( - LogLevel.Error, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - #endregion - - #region CloseAllSessions - [Test] - public async Task CloseAllSessions_Successful_ReturnsOk() - { - // Arrange - var userId = Guid.NewGuid(); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - - // Act - var result = await _controller.CloseAllSessions(); - - // Assert - Assert.That(result, Is.TypeOf()); - _userSessionRevokerMock.Verify(r => r.CloseAllSessionsAsync(userId), Times.Once()); - _loggerMock.VerifyNoOtherCalls(); - } - - [Test] - public async Task CloseAllSessions_UnauthorizedAccess_ReturnsForbid() - { - // Arrange - var userId = Guid.NewGuid(); - var exception = new UnauthorizedAccessException("Unauthorized"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _userSessionRevokerMock.Setup(r => r.CloseAllSessionsAsync(userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.CloseAllSessions(); - - // Assert - Assert.That(result, Is.TypeOf()); - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - - [Test] - public async Task CloseAllSessions_UnexpectedError_Returns500() - { - // Arrange - var userId = Guid.NewGuid(); - var exception = new Exception("Unexpected error"); - _currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId); - _userSessionRevokerMock.Setup(r => r.CloseAllSessionsAsync(userId)).ThrowsAsync(exception); - - // Act - var result = await _controller.CloseAllSessions(); - - // Assert - Assert.That(result, Is.TypeOf()); - var statusResult = result as ObjectResult; - Assert.That(statusResult.StatusCode, Is.EqualTo(500)); - Assert.That(statusResult.Value, Is.EqualTo("Unexpected Error! Please try again later.")); - _loggerMock.Verify(l => l.Log( - LogLevel.Error, - It.IsAny(), - It.IsAny(), - exception, - It.IsAny>()), Times.Once()); - } - #endregion - - [TearDown] - public void TearDown() - { - _controller?.Dispose(); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/Govor.API.Tests.csproj b/Govor.API.Tests/Govor.API.Tests.csproj deleted file mode 100644 index da8779c..0000000 --- a/Govor.API.Tests/Govor.API.Tests.csproj +++ /dev/null @@ -1,31 +0,0 @@ - - - - net8.0 - latest - enable - enable - false - - - - - - - - - - - - - - - - - - - - - - - diff --git a/Govor.API.Tests/Hubs/PresenceHubTests.cs b/Govor.API.Tests/Hubs/PresenceHubTests.cs deleted file mode 100644 index 99ddc91..0000000 --- a/Govor.API.Tests/Hubs/PresenceHubTests.cs +++ /dev/null @@ -1,197 +0,0 @@ -using AutoFixture; -using Govor.API.Common.SignalR.Helpers; -using Govor.API.Hubs; -using Govor.Application.Interfaces.UserOnlineStatus; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.Users; -using Microsoft.AspNetCore.Mvc; -using Microsoft.AspNetCore.SignalR; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.API.Tests.Hubs; - -[TestFixture] -[TestOf(typeof(PresenceHub))] -public class PresenceHubTests -{ - /* - private Mock> _mockLogger; - private Mock _mockUserNotification; - private Mock _mockOnlineUserStore; - private Mock _mockHubUserAccessor; - private Mock _mockUserRepository; - private Mock _clientsMock = null!; - private Mock _clientProxyMock = null!; - private Mock _mockContext = null!; - private Mock _groupManagerMock = null!; - private Fixture _fixture; - private PresenceHub _hub; - private Guid _userId; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors.OfType().ToList().ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _mockLogger = new Mock>(); - _mockUserNotification = new Mock(); - _mockOnlineUserStore = new Mock(); - _mockHubUserAccessor = new Mock(); - _mockUserRepository = new Mock(); - - _clientsMock = new Mock(); - _clientProxyMock = new Mock(); - - _userId = Guid.NewGuid(); - _mockHubUserAccessor.Setup(h => h.GetUserId( - It.IsAny(), - It.IsAny())) - .Returns(_userId); - - - _clientsMock.Setup(c => c.Group(It.IsAny())).Returns(_clientProxyMock.Object); - _mockContext = new Mock(); - _mockContext.Setup(c => c.ConnectionId).Returns("test-connection"); - - _groupManagerMock = new Mock(); - - _groupManagerMock.Setup(g => g.AddToGroupAsync(It.IsAny(), It.IsAny(), default)) - .Returns(Task.CompletedTask); - - _hub = new PresenceHub( - _mockLogger.Object, - _mockUserNotification.Object, - _mockOnlineUserStore.Object, - _mockHubUserAccessor.Object, - _mockUserRepository.Object) - { - Clients = _clientsMock.Object, - Context = _mockContext.Object, - Groups = _groupManagerMock.Object, - }; - } - - // Tests for OnConnectedAsync action - [Test] - public async Task OnConnectedAsync_SetsUserOnlineAndNotifiesFriends() - { - // Arrange - _mockUserRepository.Setup(f => f.ExistsByIdAsync(_userId)) - .ReturnsAsync(true); - - var friendsIds = _fixture.CreateMany().ToList(); - - _mockUserNotification.Setup(n => n.GetNotifiedUsers(_userId)) - .ReturnsAsync(friendsIds); - - // Act - await _hub.OnConnectedAsync(); - - // Assert - _mockOnlineUserStore.Verify(store => store.SetOnlineUser(_userId), Times.Once); - - _clientsMock.Verify(c => c.Group(It.IsAny()), Times.Exactly(friendsIds.Count)); - - foreach (var friendId in friendsIds) - { - _clientProxyMock.Verify(proxy => - proxy.SendCoreAsync("UserOnline", - It.Is(args => args.Length == 1 && (Guid)args[0] == _userId), - It.IsAny()), - Times.Exactly(friendsIds.Count)); - } - } - - [Test] - public async Task OnConnectedAsync_UserIdInvalidOrNotExists_AbortsConnection() - { - // Arrange - _mockHubUserAccessor.Setup(h => h.GetUserId(It.IsAny(), false)) - .Returns(Guid.Empty); - - // Act - await _hub.OnConnectedAsync(); - - // Assert - _mockOnlineUserStore.Verify(store => store.SetOnlineUser(It.IsAny()), Times.Never); - _mockContext.Verify(c => c.Abort(), Times.Once); - } - - [Test] - public async Task OnConnectedAsync_UserNotExists_AbortsConnection() - { - // Arrange - _mockUserRepository.Setup(f => f.ExistsByIdAsync(_userId)) - .ReturnsAsync(false); - - // Act - await _hub.OnConnectedAsync(); - - // Assert - _mockOnlineUserStore.Verify(store => store.SetOnlineUser(It.IsAny()), Times.Never); - _mockContext.Verify(c => c.Abort(), Times.Once); - } - - // Tests for OnDisconnectedAsync action - [Test] - public async Task OnDisconnectedAsync_SetsUserOffline_UpdatesWasOnline_NotifiesFriends() - { - // Arrange - var user = new User { Id = _userId, WasOnline = DateTime.MinValue }; - - var friendsIds = _fixture.CreateMany().ToList(); - _mockUserRepository.Setup(r => r.FindByIdAsync(_userId)) - .ReturnsAsync(user); - - _mockUserNotification.Setup(n => n.GetNotifiedUsers(_userId)) - .ReturnsAsync(friendsIds); - - // Act - await _hub.OnDisconnectedAsync(null!); - - // Assert - _mockOnlineUserStore.Verify(store => store.SetOfflineUser(_userId), Times.Once); - _mockUserRepository.Verify(r => r.UpdateAsync(It.Is(u => u.Id == _userId && u.WasOnline > DateTime.MinValue)), Times.Once); - _clientsMock.Verify(c => c.Group(It.IsAny()), Times.AtLeastOnce); - - foreach (var friendId in friendsIds) - { - _clientProxyMock.Verify(proxy => - proxy.SendCoreAsync("UserOffline", - It.Is(args => args.Length == 1 && (Guid)args[0] == _userId), - It.IsAny()), - Times.Exactly(friendsIds.Count)); - } - } - - [Test] - public async Task OnDisconnectedAsync_UserIdEmpty_LogsAndSkips() - { - // Arrange - _mockHubUserAccessor.Setup(h => h.GetUserId(It.IsAny(), true)) - .Returns(Guid.Empty); - - // Act - await _hub.OnDisconnectedAsync(null!); - - // Assert - _mockOnlineUserStore.Verify(s => s.SetOfflineUser(It.IsAny()), Times.Never); - _mockUserRepository.Verify(r => r.UpdateAsync(It.IsAny()), Times.Never); - - _clientProxyMock.Verify(proxy => - proxy.SendCoreAsync("UserOffline", - It.Is(args => args.Length == 1 && (Guid)args[0] == _userId), - It.IsAny()), - Times.Never); - } - - [TearDown] - public void TearDown() - { - _hub?.Dispose(); - } - */ -} \ No newline at end of file diff --git a/Govor.API.Tests/IntegrationTests/Controllers/AuthControllerTests.cs b/Govor.API.Tests/IntegrationTests/Controllers/AuthControllerTests.cs deleted file mode 100644 index 54f4953..0000000 --- a/Govor.API.Tests/IntegrationTests/Controllers/AuthControllerTests.cs +++ /dev/null @@ -1,246 +0,0 @@ -using AutoFixture; -using Govor.API.Controllers.Authentication; -using Govor.Application.Authentication.Exceptions; -using Govor.Application.Exceptions.InvitesService; -using Govor.Application.Interfaces.Authentication; -using Govor.Application.Interfaces.UserSession; -using Govor.Contracts.Requests; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Microsoft.AspNetCore.Mvc; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.API.Tests.IntegrationTests.Controllers; - -[TestFixture] -public class AuthControllerTests -{ - private Fixture _fixture; - private Mock _accountServiceMock; - private Mock _invitesServiceMock; - private Mock> _loggerMock; - private Mock _userSessionOpenerMock; - private AuthController _controller; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors.OfType().ToList().ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _accountServiceMock = new Mock(); - _invitesServiceMock = new Mock(); - _loggerMock = new Mock>(); - _userSessionOpenerMock = new Mock(); - - _controller = new AuthController( - _accountServiceMock.Object, - _invitesServiceMock.Object, - _userSessionOpenerMock.Object, - _loggerMock.Object - ); - } - - // Tests for Register action - [Test] - public async Task Register_ValidRequest_ReturnsOkWithToken() - { - // Arrange - var request = _fixture.Create(); - var invitation = _fixture.Create(); - var token = _fixture.Create(); - - var user = _fixture.Build() - .With(x => x.Username).Create(); - - _invitesServiceMock.Setup(s => s.ValidateAsync(request.InviteLink)).ReturnsAsync(invitation); - - - _accountServiceMock.Setup(l => l.RegistrationAsync(request.Name, request.Password, invitation)) - .ReturnsAsync(user); - - _userSessionOpenerMock.Setup(f => f.OpenSessionAsync(user, request.DeviceInfo)) - .ReturnsAsync(token); - - // Act - var result = await _controller.Register(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var okResult = result as OkObjectResult; - - var response = okResult?.Value as RefreshResult; - Assert.That(response, Is.Not.Null); - Assert.That(response.accessToken, Is.EqualTo(token.accessToken)); - Assert.That(response.refreshToken, Is.EqualTo(token.refreshToken)); - } - - [Test] - public async Task Register_InvalidModelState_ReturnsBadRequest() - { - // Arrange - var request = _fixture.Create(); - _controller.ModelState.AddModelError("Error", "Sample error"); - - // Act - var result = await _controller.Register(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task Register_InviteLinkInvalid_ReturnsBadRequest() - { - // Arrange - var request = _fixture.Create(); - _invitesServiceMock.Setup(s => s.ValidateAsync(request.InviteLink)).ThrowsAsync(new InviteLinkInvalidException(request.InviteLink)); - - // Act - var result = await _controller.Register(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var notFoundObjectResult = result as BadRequestObjectResult; - Assert.That(notFoundObjectResult.Value, Is.EqualTo("Invite link invalid.")); - } - - [Test] - public async Task Register_UserAlreadyExists_ReturnsBadRequest() - { - // Arrange - var request = _fixture.Create(); - var invitation = _fixture.Create(); - _invitesServiceMock.Setup(s => s.ValidateAsync(request.InviteLink)).ReturnsAsync(invitation); - _accountServiceMock.Setup(s => s.RegistrationAsync(request.Name, request.Password, invitation)) - .ThrowsAsync(new UserAlreadyExistException(request.Name)); - - // Act - var result = await _controller.Register(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult.Value, Is.EqualTo("Registration failed: user already exists.")); - } - - [Test] - public async Task Register_AccountServiceThrowsGenericException_ReturnsStatusCode500() - { - // Arrange - var request = _fixture.Create(); - var invitation = _fixture.Create(); - _invitesServiceMock.Setup(s => s.ValidateAsync(request.InviteLink)).ReturnsAsync(invitation); - _accountServiceMock.Setup(s => s.RegistrationAsync(request.Name, request.Password, invitation)) - .ThrowsAsync(new System.Exception("Generic error")); - - // Act - var result = await _controller.Register(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var objectResult = result as ObjectResult; - Assert.That(objectResult.StatusCode, Is.EqualTo(500)); - Assert.That(objectResult.Value, Is.EqualTo("An unexpected error occurred. Please try again later.")); - } - - // Tests for Login action - [Test] - public async Task Login_ValidCredentials_ReturnsOkWithToken() - { - // Arrange - var loginRequest = _fixture.Create(); - var token = _fixture.Create(); - - var user = _fixture.Build() - .With(x => x.Username).Create(); - - _accountServiceMock.Setup(l => l.LoginAsync(loginRequest.Name, loginRequest.Password)).ReturnsAsync(user); - - _userSessionOpenerMock.Setup(f => f.OpenSessionAsync(user, loginRequest.DeviceInfo)) - .ReturnsAsync(token); - - // Act - var result = await _controller.Login(loginRequest); - // Assert - Assert.That(result, Is.InstanceOf()); - var okResult = result as OkObjectResult; - - var response = okResult?.Value as RefreshResult; - Assert.That(response, Is.Not.Null); - Assert.That(response.accessToken, Is.EqualTo(token.accessToken)); - Assert.That(response.refreshToken, Is.EqualTo(token.refreshToken)); - } - - [Test] - public async Task Login_InvalidModelState_ReturnsBadRequest() - { - // Arrange - var request = _fixture.Create(); - _controller.ModelState.AddModelError("Error", "Sample error"); - - // Act - var result = await _controller.Login(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task Login_UserNotRegistered_ReturnsBadRequest() - { - // Arrange - var request = _fixture.Create(); - _accountServiceMock.Setup(l => l.LoginAsync(request.Name, request.Password)).Throws(new UserNotRegisteredException(request.Name)); - - // Act - var result = await _controller.Login(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult.Value, Is.EqualTo("Login failed: user does not exist.")); - } - - [Test] - public async Task Login_PasswordIsIncorrect_ReturnsBadRequest() - { - // Arrange - var request = _fixture.Create(); - _accountServiceMock.Setup(l => l.LoginAsync(request.Name, request.Password)).Throws(new LoginUserException()); - - // Act - var result = await _controller.Login(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult.Value, Is.EqualTo("Login failed: username or password is incorrect.")); - } - - [Test] - public async Task Login_AccountServiceThrowsGenericException_ReturnsStatusCode500() - { - // Arrange - var request = _fixture.Create(); - _accountServiceMock.Setup(s => s.LoginAsync(request.Name, request.Password)) - .ThrowsAsync(new System.Exception("Generic error")); - - // Act - var result = await _controller.Login(request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var objectResult = result as ObjectResult; - Assert.That(objectResult.StatusCode, Is.EqualTo(500)); - Assert.That(objectResult.Value, Is.EqualTo("An unexpected error occurred. Please try again later.")); - } - - [TearDown] - public void TearDown() - { - (_controller as IDisposable)?.Dispose(); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/IntegrationTests/Controllers/ChatLoadControllerTests.cs b/Govor.API.Tests/IntegrationTests/Controllers/ChatLoadControllerTests.cs deleted file mode 100644 index cfaf2bd..0000000 --- a/Govor.API.Tests/IntegrationTests/Controllers/ChatLoadControllerTests.cs +++ /dev/null @@ -1,267 +0,0 @@ -using AutoFixture; -using AutoMapper; -using Govor.API.Controllers; -using Govor.Application.Interfaces; -using Govor.Application.Interfaces.Infrastructure.Extensions; -using Govor.Application.Messages; -using Govor.Contracts.Requests; -using Govor.Contracts.Responses; -using Govor.Domain.Models.Messages; -using Govor.Data.Repositories.Exceptions; -using Microsoft.AspNetCore.Mvc; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.API.Tests.IntegrationTests.Controllers; - -[TestFixture] -public class ChatLoadControllerTests -{ - private Mock _currentUserServiceMock; - private Mock> _loggerMock; - private Mock _messagesLoaderMock; - private Mock _mapperMock; - private Fixture _fixture; - private ChatLoadController _controller; - - private Guid _userId = Guid.NewGuid(); - private Guid _chatId = Guid.NewGuid(); - private Guid _currentId = Guid.NewGuid(); - - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors.OfType().ToList().ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _currentUserServiceMock = new Mock(); - _loggerMock = new Mock>(); - _messagesLoaderMock = new Mock(); - _mapperMock = new Mock(); - - _currentUserServiceMock.Setup(u => u.GetCurrentUserId()).Returns(_currentId); - - _controller = new ChatLoadController( - _loggerMock.Object, - _messagesLoaderMock.Object, - _currentUserServiceMock.Object, - _mapperMock.Object); - } - - // Tests for GetChatMessages action - [Test] - public async Task GetChatMessages_ValidRequest_ReturnsOkResult() - { - // Arrange - var random = new Random(); - var messages = _fixture.CreateMany(random.Next(3, 10)).ToList(); - var before = random.Next(1, 10); - var after = random.Next(1, 10); - - var query = new MessageQuery() - { - Before = before, - After = after, - StartMessageId = null - }; - - _messagesLoaderMock.Setup(m => - m.LoadMessagesInChatGroup(_chatId, _currentId, null, before, after)) - .ReturnsAsync(messages); - - var messagesResponse = messages.Select(m => new MessageResponse() - { - Id = m.Id, - SenderId = m.SenderId, - RecipientId = m.RecipientId, - RecipientType = m.RecipientType, - }).ToList(); - - _mapperMock.Setup(f => f.Map>(messages)). - Returns(messagesResponse); - - // Act - var result = await _controller.GetGroupMessages(_chatId, query); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.InstanceOf()); - - var okResult = (OkObjectResult)result; - var values = okResult.Value as List; - - Assert.That(values, Is.Not.Null); - - Assert.That(values.Select(v => v.Id), - Is.EquivalentTo(messagesResponse.Select(m => m.Id))); - - Assert.That(values.Select(v => v.SenderId), - Is.EquivalentTo(messagesResponse.Select(m => m.SenderId))); - - Assert.That(values.Select(v => v.RecipientId), - Is.EquivalentTo(messagesResponse.Select(m => m.RecipientId))); - - Assert.That(values.Select(v => v.RecipientType), - Is.EquivalentTo(messagesResponse.Select(m => m.RecipientType))); - } - - [Test] - public async Task GetGroupMessages_InvalidQuery_ReturnsBadRequest() - { - // Arrange - var query = new MessageQuery { Before = -1, After = 10 }; - - // Act - var result = await _controller.GetGroupMessages(_chatId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task GetGroupMessages_UnauthorizedAccess_ReturnsForbid() - { - // Arrange - var query = new MessageQuery { Before = 10, After = 10 }; - _messagesLoaderMock.Setup(m => m.LoadMessagesInChatGroup(It.IsAny(), It.IsAny(), null, It.IsAny(), It.IsAny())) - .ThrowsAsync(new UnauthorizedAccessException()); - - // Act - var result = await _controller.GetGroupMessages(_chatId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task GetGroupMessages_NotFound_ReturnsBadRequest() - { - // Arrange - var query = new MessageQuery { Before = 10, After = 10 }; - _messagesLoaderMock.Setup(m => m.LoadMessagesInChatGroup(It.IsAny(), It.IsAny(), null, It.IsAny(), It.IsAny())) - .ThrowsAsync(new NotFoundException("Chat not found")); - - // Act - var result = await _controller.GetGroupMessages(_chatId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task GetGroupMessages_ArgumentException_ReturnsBadRequest() - { - // Arrange - var query = new MessageQuery { Before = 10, After = 10 }; - _messagesLoaderMock.Setup(m => m.LoadMessagesInChatGroup(It.IsAny(), It.IsAny(), null, It.IsAny(), It.IsAny())) - .ThrowsAsync(new ArgumentException("Invalid argument")); - - // Act - var result = await _controller.GetGroupMessages(_chatId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - // GetUserMessages tests - [Test] - public async Task GetUserMessages_ValidRequest_ReturnsOkResult() - { - // Arrange - var messages = _fixture.CreateMany(5).ToList(); - var query = new MessageQuery { Before = 5, After = 5 }; - _messagesLoaderMock.Setup(m => m.LoadMessagesInUserChat(_userId, _currentId, null, 5, 5)) - .ReturnsAsync(messages); - var messageResponses = _fixture.CreateMany(5).ToList(); - _mapperMock.Setup(m => m.Map>(messages)).Returns(messageResponses); - - // Act - var result = await _controller.GetUserMessages(_userId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - var okResult = result as OkObjectResult; - Assert.That(okResult.Value, Is.EqualTo(messageResponses)); - } - - [Test] - public async Task GetUserMessages_InvalidQuery_ReturnsBadRequest() - { - // Arrange - var query = new MessageQuery { Before = -1, After = 10 }; - - // Act - var result = await _controller.GetUserMessages(_userId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task GetUserMessages_InvalidOperation_ReturnsBadRequest() - { - // Arrange - var query = new MessageQuery { Before = 10, After = 10 }; - _messagesLoaderMock.Setup(m => m.LoadMessagesInUserChat(It.IsAny(), It.IsAny(), null, It.IsAny(), It.IsAny())) - .ThrowsAsync(new InvalidOperationException()); - - // Act - var result = await _controller.GetUserMessages(_userId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task GetUserMessages_UnauthorizedAccess_ReturnsForbid() - { - // Arrange - var query = new MessageQuery { Before = 10, After = 10 }; - _messagesLoaderMock.Setup(m => m.LoadMessagesInUserChat(It.IsAny(), It.IsAny(), null, It.IsAny(), It.IsAny())) - .ThrowsAsync(new UnauthorizedAccessException()); - - // Act - var result = await _controller.GetUserMessages(_userId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task GetUserMessages_NotFound_ReturnsBadRequest() - { - // Arrange - var query = new MessageQuery { Before = 10, After = 10 }; - _messagesLoaderMock.Setup(m => m.LoadMessagesInUserChat(It.IsAny(), It.IsAny(), null, It.IsAny(), It.IsAny())) - .ThrowsAsync(new NotFoundException("User not found")); - - // Act - var result = await _controller.GetUserMessages(_userId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task GetUserMessages_ArgumentException_ReturnsBadRequest() - { - // Arrange - var query = new MessageQuery { Before = 10, After = 10 }; - _messagesLoaderMock.Setup(m => m.LoadMessagesInUserChat(It.IsAny(), It.IsAny(), null, It.IsAny(), It.IsAny())) - .ThrowsAsync(new ArgumentException("Invalid argument")); - - // Act - var result = await _controller.GetUserMessages(_userId, query); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [TearDown] - public void TearDown() - { - _controller?.Dispose(); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/IntegrationTests/Controllers/MediaControllerTests.cs b/Govor.API.Tests/IntegrationTests/Controllers/MediaControllerTests.cs deleted file mode 100644 index 3e74058..0000000 --- a/Govor.API.Tests/IntegrationTests/Controllers/MediaControllerTests.cs +++ /dev/null @@ -1,362 +0,0 @@ -using System.Text; -using AutoFixture; -using Govor.API.Controllers; -using Govor.Application.Interfaces.Infrastructure.Extensions; -using Govor.Application.Interfaces.Medias; -using Govor.Contracts.Requests; -using Govor.Domain.Models.Messages; -using Microsoft.AspNetCore.Http; -using Microsoft.AspNetCore.Mvc; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.API.Tests.IntegrationTests.Controllers; - -[TestFixture] -public class MediaControllerTests -{ - private Fixture _fixture; - private Mock _currentUserMock; - private Mock> _loggerMock; - private Mock _mockMedia; - private Mock _mockAccesser; - private MediaController _controller; - private Guid _userId = Guid.NewGuid(); - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors.OfType().ToList().ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _currentUserMock = new Mock(); - _loggerMock = new Mock>(); - _mockAccesser = new Mock(); - _mockMedia = new Mock(); - - _currentUserMock.Setup(f => f.GetCurrentUserId()).Returns(_userId); - - _controller = new MediaController( - _loggerMock.Object, - _mockMedia.Object, - _mockAccesser.Object, - _currentUserMock.Object); - } - - // Tests for Upload action - [Test] - public async Task Upload_ValidRequest_ReturnsOkResult() - { - // Arrange - var content = "fake file content"; - var fileName = "testfile.txt"; - var fileBytes = System.Text.Encoding.UTF8.GetBytes(content); - var stream = new MemoryStream(fileBytes); - - var formFileMock = new Mock(); - formFileMock.Setup(f => f.Length).Returns(fileBytes.Length); - formFileMock.Setup(f => f.FileName).Returns(fileName); - formFileMock.Setup(f => f.OpenReadStream()).Returns(stream); - formFileMock.Setup(f => f.CopyToAsync(It.IsAny(), default)) - .Returns((target, _) => stream.CopyToAsync(target)); - - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, formFileMock.Object) - .With(r => r.Type, MediaType.Image) - .With(r => r.MimeType, "image/png") - .With(r => r.EncryptedKey, "secret") - .Create(); - - var uploadResult = _fixture.Create(); - - _mockMedia.Setup(f => f.UploadMediaAsync(It.IsAny())) - .ReturnsAsync(uploadResult); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - - var okResult = result as OkObjectResult; - var value = okResult?.Value as MediaUploadResult; - - Assert.That(value, Is.Not.Null); - Assert.That(value!.Url, Is.EqualTo(uploadResult.Url)); - Assert.That(value.MediaId, Is.EqualTo(uploadResult.MediaId)); - } - - [Test] - public async Task Upload_InvalidModelState_ReturnsBadRequest() - { - // Arrange - _controller.ModelState.AddModelError("Error", "Invalid model state"); - var content = "fake file content"; - var fileName = "testfile.txt"; - var fileBytes = System.Text.Encoding.UTF8.GetBytes(content); - var stream = new MemoryStream(fileBytes); - - var formFileMock = new Mock(); - formFileMock.Setup(f => f.Length).Returns(fileBytes.Length); - formFileMock.Setup(f => f.FileName).Returns(fileName); - formFileMock.Setup(f => f.OpenReadStream()).Returns(stream); - formFileMock.Setup(f => f.CopyToAsync(It.IsAny(), default)) - .Returns((target, _) => stream.CopyToAsync(target)); - - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, formFileMock.Object) - .With(r => r.Type, MediaType.Image) - .With(r => r.MimeType, "image/png") - .With(r => r.EncryptedKey, "secret") - .Create(); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task Upload_NoFileUploaded_ReturnsBadRequest() - { - // Arrange - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, (IFormFile)null) - .Create(); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult?.Value, Is.EqualTo("No file uploaded")); - } - - [Test] - public async Task Upload_EmptyFile_ReturnsBadRequest() - { - // Arrange - var formFileMock = new Mock(); - formFileMock.Setup(f => f.Length).Returns(0); - - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, formFileMock.Object) - .Create(); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult?.Value, Is.EqualTo("No file uploaded")); - } - - [Test] - public async Task Upload_FileTooLarge_ReturnsBadRequest() - { - // Arrange - var formFileMock = new Mock(); - formFileMock.Setup(f => f.Length).Returns(20_000_001); // Just over 20MB - - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, formFileMock.Object) - .Create(); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult?.Value, Is.EqualTo("File is too large")); - } - - [Test] - public async Task Upload_MissingMimeType_ReturnsBadRequest() - { - // Arrange - var formFileMock = new Mock(); - formFileMock.Setup(f => f.Length).Returns(1000); - formFileMock.Setup(f => f.FileName).Returns("testfile.txt"); - - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, formFileMock.Object) - .With(r => r.MimeType, string.Empty) - .Create(); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult?.Value, Is.EqualTo("Missing MIME type")); - } - - [Test] - public async Task Upload_UnauthorizedAccess_ReturnsUnauthorized() - { - // Arrange - var formFileMock = new Mock(); - formFileMock.Setup(f => f.Length).Returns(1000); - formFileMock.Setup(f => f.FileName).Returns("testfile.txt"); - formFileMock.Setup(f => f.OpenReadStream()).Returns(new MemoryStream(new byte[1000])); - - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, formFileMock.Object) - .With(r => r.MimeType, "text/plain") - .Create(); - - _mockMedia.Setup(f => f.UploadMediaAsync(It.IsAny())) - .ThrowsAsync(new UnauthorizedAccessException("Access denied")); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - var forbidResult = result as ForbidResult; - Assert.That(forbidResult.AuthenticationSchemes.First(), Is.EqualTo("Access denied")); - } - - [Test] - public async Task Upload_InvalidOperation_ReturnsBadRequest() - { - // Arrange - var formFileMock = new Mock(); - formFileMock.Setup(f => f.Length).Returns(1000); - formFileMock.Setup(f => f.FileName).Returns("testfile.txt"); - formFileMock.Setup(f => f.OpenReadStream()).Returns(new MemoryStream(new byte[1000])); - - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, formFileMock.Object) - .With(r => r.MimeType, "text/plain") - .Create(); - - _mockMedia.Setup(f => f.UploadMediaAsync(It.IsAny())) - .ThrowsAsync(new InvalidOperationException("Invalid operation")); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - Assert.That(badRequestResult?.Value, Is.EqualTo("Invalid operation")); - } - - [Test] - public async Task Upload_GeneralException_ReturnsInternalServerError() - { - // Arrange - var formFileMock = new Mock(); - formFileMock.Setup(f => f.Length).Returns(1000); - formFileMock.Setup(f => f.FileName).Returns("testfile.txt"); - formFileMock.Setup(f => f.OpenReadStream()).Returns(new MemoryStream(new byte[1000])); - - var uploadRequest = _fixture.Build() - .With(r => r.FromFile, formFileMock.Object) - .With(r => r.MimeType, "text/plain") - .Create(); - - _mockMedia.Setup(f => f.UploadMediaAsync(It.IsAny())) - .ThrowsAsync(new Exception("Something went wrong")); - - // Act - var result = await _controller.Upload(uploadRequest); - - // Assert - Assert.That(result, Is.InstanceOf()); - var objectResult = result as ObjectResult; - Assert.That(objectResult.StatusCode, Is.EqualTo(500)); - } - - // Tests for Download action - [Test] - public async Task Download_HasAccessAndMediaExists_ReturnsFile() - { - // Arrange - var mediaId = Guid.NewGuid(); - var media = _fixture.Build() - .With(m => m.Data, Encoding.UTF8.GetBytes("fake file content")) - .With(m => m.MimeType, "application/octet-stream") // Ensure MimeType is set - .With(m => m.FileName, "testfile.txt") - .Create(); - - _mockAccesser.Setup(f => f.HasAccessAsync(mediaId, _userId)).ReturnsAsync(true); - _mockMedia.Setup(f => f.GetMediaByIdAsync(mediaId)).ReturnsAsync(media); - - // Act - var result = await _controller.Download(mediaId); - - // Assert - Assert.That(result, Is.InstanceOf()); - var fileResult = result as FileContentResult; - Assert.That(fileResult?.FileContents, Is.EqualTo(media.Data)); - Assert.That(fileResult?.ContentType, Is.EqualTo(media.MimeType)); // Changed MineType to MimeType - Assert.That(fileResult?.FileDownloadName, Is.EqualTo(Path.GetFileName(media.FileName))); - } - - [Test] - public async Task Download_NoAccess_ReturnsForbid() - { - // Arrange - var mediaId = Guid.NewGuid(); - - _mockAccesser.Setup(f => f.HasAccessAsync(mediaId, _userId)).ReturnsAsync(false); - - // Act - var result = await _controller.Download(mediaId); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task Download_MediaNotFound_ReturnsNotFound() - { - // Arrange - var mediaId = Guid.NewGuid(); - - _mockAccesser.Setup(f => f.HasAccessAsync(mediaId, _userId)).ReturnsAsync(true); - _mockMedia.Setup(f => f.GetMediaByIdAsync(mediaId)) - .ThrowsAsync(new KeyNotFoundException("Media not found")); - - // Act - var result = await _controller.Download(mediaId); - - // Assert - Assert.That(result, Is.InstanceOf()); - var notFoundResult = result as NotFoundObjectResult; - Assert.That(notFoundResult?.Value, Is.EqualTo("Media not found")); - } - - [Test] - public async Task Download_GeneralException_ReturnsInternalServerError() - { - // Arrange - var mediaId = Guid.NewGuid(); - - _mockAccesser.Setup(f => f.HasAccessAsync(mediaId, _userId)).ReturnsAsync(true); - _mockMedia.Setup(f => f.GetMediaByIdAsync(mediaId)) - .ThrowsAsync(new Exception("Something went wrong")); - - // Act - var result = await _controller.Download(mediaId); - - // Assert - Assert.That(result, Is.InstanceOf()); - var objectResult = result as ObjectResult; - Assert.That(objectResult.StatusCode, Is.EqualTo(500)); - } - - [TearDown] - public void TearDown() - { - _controller.Dispose(); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/IntegrationTests/Controllers/RefreshControllerTests.cs b/Govor.API.Tests/IntegrationTests/Controllers/RefreshControllerTests.cs deleted file mode 100644 index 31c41f8..0000000 --- a/Govor.API.Tests/IntegrationTests/Controllers/RefreshControllerTests.cs +++ /dev/null @@ -1,124 +0,0 @@ -using AutoFixture; -using Govor.API.Controllers.Authentication; -using Govor.Application.Interfaces.UserSession; -using Govor.Contracts.Requests; -using Govor.Contracts.Responses; -using Microsoft.AspNetCore.Identity.Data; -using Microsoft.AspNetCore.Mvc; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.API.Tests.IntegrationTests.Controllers; - -[TestFixture] -public class RefreshControllerTests -{ - private Fixture _fixture; - private Mock> _mockLogger; - private Mock _mockSessionRefresher; - private RefreshController _controller; - private RefreshTokenRequest _request; - private RefreshResult _result; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - - _mockLogger = new Mock>(); - _mockSessionRefresher = new Mock(); - - _request = _fixture.Create(); - _result = _fixture.Create(); - - _controller = new RefreshController(_mockLogger.Object, _mockSessionRefresher.Object); - } - - // Tests for Refresh action - [Test] - public async Task Refresh_ValidRequest_ReturnsOkResult() - { - // Arrange - _mockSessionRefresher.Setup(f => f.RefreshTokenAsync(_request.RefreshToken)) - .ReturnsAsync(_result); - - // Act - var result = await _controller.Refresh(_request); - - //Assert - Assert.That(result, Is.InstanceOf()); - var okResult = result as OkObjectResult; - - var response = okResult?.Value as RefreshTokenResponse; - Assert.That(response, Is.Not.Null); - Assert.That(response.AccessToken, Is.EqualTo(_result.accessToken)); - Assert.That(response.RefreshToken, Is.EqualTo(_result.refreshToken)); - } - - [Test] - public async Task Refresh_InvalidModelState_ReturnsBadRequest() - { - // Arrange - _controller.ModelState.AddModelError("Error", "Sample error"); - - // Act - var result = await _controller.Refresh(_request); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - [Test] - public async Task Refresh_InvalidRefreshToken_ReturnsBadRequest() - { - // Arrange - _request.RefreshToken = string.Empty; - - // Act - var result = await _controller.Refresh(_request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = result as BadRequestObjectResult; - var response = badRequestResult?.Value; - Assert.That(response, Is.EqualTo("Refresh token cant be empty.")); - } - - [Test] - public async Task Refresh_UnauthorizedAccessException_ReturnsUnauthorizedRequest() - { - // Arrange - _mockSessionRefresher.Setup(f => f.RefreshTokenAsync(_request.RefreshToken)) - .ThrowsAsync(new UnauthorizedAccessException()); - - // Act - var result = await _controller.Refresh(_request); - - // Assert - Assert.That(result, Is.InstanceOf()); - var unauthorized = result as UnauthorizedObjectResult; - var response = unauthorized?.Value; - Assert.That(response, Is.EqualTo("Invalid refresh token")); - } - - [Test] - public async Task Refresh_InvalidOperationException_ReturnsBadRequest() - { - // Arrange - _mockSessionRefresher.Setup(f => f.RefreshTokenAsync(_request.RefreshToken)) - .ThrowsAsync(new InvalidOperationException()); - - // Act - var result = await _controller.Refresh(_request); - - // Assert - Assert.That(result, Is.InstanceOf()); - } - - - [TearDown] - public void TearDown() - { - _controller?.Dispose(); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/IntegrationTests/Hubs/ChatsHubTests.cs b/Govor.API.Tests/IntegrationTests/Hubs/ChatsHubTests.cs deleted file mode 100644 index 32a809f..0000000 --- a/Govor.API.Tests/IntegrationTests/Hubs/ChatsHubTests.cs +++ /dev/null @@ -1,57 +0,0 @@ -using AutoFixture; -using Govor.API.Common.SignalR.Helpers; -using Govor.API.Hubs; -using Govor.Application.Interfaces; -using Govor.Application.Interfaces.Messages; -using Microsoft.AspNetCore.Mvc; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.API.Tests.IntegrationTests.Hubs; - -[TestFixture] -public class ChatsHubTests -{ - /* - private Mock> _loggerMock; - private Mock _messageServiceMock; - private Mock _userGroupsServiceMock; - private Mock _hubUserAccessorMock; - private Fixture _fixture; - private ChatsHub _chatsHub; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors.OfType().ToList().ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _messageServiceMock = new Mock(); - _userGroupsServiceMock = new Mock(); - _loggerMock = new Mock>(); - _hubUserAccessorMock = new Mock(); - - _chatsHub = new ChatsHub( - _loggerMock.Object, - _messageServiceMock.Object, - _userGroupsServiceMock.Object, - _hubUserAccessorMock.Object - ); - } - - // Test for Send action - [Test] - public void SendMessage_Success() - { - - } - - - [TearDown] - public void TearDown() - { - _chatsHub?.Dispose(); - } - */ -} \ No newline at end of file diff --git a/Govor.API.Tests/UnitTests/Infrastructure/Validators/ChatGroupValidatorTests.cs b/Govor.API.Tests/UnitTests/Infrastructure/Validators/ChatGroupValidatorTests.cs deleted file mode 100644 index 57a0afe..0000000 --- a/Govor.API.Tests/UnitTests/Infrastructure/Validators/ChatGroupValidatorTests.cs +++ /dev/null @@ -1,118 +0,0 @@ -using AutoFixture; -using Govor.Domain.Common.Constants; -using Govor.Domain.Models; - -namespace Govor.API.Tests.UnitTests.Infrastructure.Validators; - -[TestFixture] -public class ChatGroupValidatorTests -{ - private IObjectValidator _validator = new ChatGroupValidator(); - private Fixture _fixture; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - } - - [Test] - public void Validate_ChatGroup_Valid() - { - // Arrange - var chat = _fixture.Create(); - - // Act & Assert - Assert.DoesNotThrow(() => _validator.Validate(chat)); - Assert.That(_validator.TryValidate(chat), Is.True); - } - - - [Test] - public void Validate_ChatGroupIsNull_Invalid() - { - // Act & Assert - Assert.Throws>(() => _validator.Validate(default)); - Assert.That(_validator.TryValidate(default), Is.False); - } - - [Test] - public void Validate_ChatGroupIdIsEmpty_Invalid() - { - // Arrange - var chat = _fixture.Create(); - chat.Id = Guid.Empty; - - // Act & Assert - Assert.Throws>(() => _validator.Validate(chat)); - Assert.That(_validator.TryValidate(chat), Is.False); - } - - [Test] - public void Validate_ChatGroupNameIsEmpty_Invalid() - { - // Arrange - var chat = _fixture.Create(); - chat.Name = ""; - - // Act & Assert - Assert.Throws>(() => _validator.Validate(chat)); - Assert.That(_validator.TryValidate(chat), Is.False); - } - - [Test] - public void Validate_ChatGroupDescriptionIsNull_Invalid() - { - // Arrange - var chat = _fixture.Create(); - chat.Description = default; - - // Act & Assert - Assert.Throws>(() => _validator.Validate(chat)); - Assert.That(_validator.TryValidate(chat), Is.False); - } - - [Test] - public void Validate_ChatGroupImageIdIsEmpty_Invalid() - { - // Arrange - var chat = _fixture.Create(); - chat.ImageId = Guid.Empty; - - // Act & Assert - Assert.Throws>(() => _validator.Validate(chat)); - Assert.That(_validator.TryValidate(chat), Is.False); - } - - [Test] - public void Validate_ChatGroupIsPrivateAndInvitesCodesIsEmpty_Invalid() - { - // Arrange - var chat = _fixture.Create(); - chat.IsPrivate = true; - chat.InviteCodes = new(); - - // Act & Assert - Assert.Throws>(() => _validator.Validate(chat)); - Assert.That(_validator.TryValidate(chat), Is.False); - } - - [Test] - public void Validate_ChatGroupAdminsIsEmpty_Invalid() - { - // Arrange - var chat = _fixture.Create(); - chat.Admins = new(); - - // Act & Assert - Assert.Throws>(() => _validator.Validate(chat)); - Assert.That(_validator.TryValidate(chat), Is.False); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/UnitTests/Infrastructure/Validators/FriendshipValidatorTests.cs b/Govor.API.Tests/UnitTests/Infrastructure/Validators/FriendshipValidatorTests.cs deleted file mode 100644 index 5d8bf0a..0000000 --- a/Govor.API.Tests/UnitTests/Infrastructure/Validators/FriendshipValidatorTests.cs +++ /dev/null @@ -1,86 +0,0 @@ -using AutoFixture; -using Govor.Domain.Common.Constants; -using Govor.Domain.Models; - -namespace Govor.API.Tests.UnitTests.Infrastructure.Validators; - -[TestFixture] -public class FriendshipValidatorTests -{ - private IObjectValidator _friendshipValidator; - private Fixture _fixture; - - public FriendshipValidatorTests() - { - _friendshipValidator = new FriendshipValidator(); - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - } - - - [Test] - public void Given_ValidFriendship_When_Validate_Then_Returns_True() - { - // Arrange - var friendship = _fixture.Create(); - - // Act & Assert - Assert.DoesNotThrow( () => _friendshipValidator.Validate(friendship)); - Assert.That(_friendshipValidator.TryValidate(friendship), Is.True); - } - - [Test] - public void Given_EmptyFriendshipId_When_Validate_Then_Returns_False() - { - // Arrange - var friendship = _fixture.Create(); - friendship.Id = Guid.Empty; - - // Act & Assert - Assert.Throws>( () => _friendshipValidator.Validate(friendship)); - Assert.That(_friendshipValidator.TryValidate(friendship), Is.False); - } - - [Test] - public void Given_EmptyRequesterId_When_Validate_Then_Returns_False() - { - // Arrange - var friendship = _fixture.Create(); - friendship.RequesterId = Guid.Empty; - - // Act & Assert - Assert.Throws>( () => _friendshipValidator.Validate(friendship)); - Assert.That(_friendshipValidator.TryValidate(friendship), Is.False); - } - - [Test] - public void GivenSameRequesterId_When_Validate_Then_Returns_False() - { - // Arrange - var friendship = _fixture.Create(); - friendship.RequesterId = friendship.AddresseeId; - - // Act & Assert - Assert.Throws>( () => _friendshipValidator.Validate(friendship)); - Assert.That(_friendshipValidator.TryValidate(friendship), Is.False); - } - - [Test] - public void Given_AddresseeId_When_Validate_Then_Returns_False() - { - // Arrange - var friendship = _fixture.Create(); - friendship.AddresseeId = Guid.Empty; - - // Act & Assert - Assert.Throws>( () => _friendshipValidator.Validate(friendship)); - Assert.That(_friendshipValidator.TryValidate(friendship), Is.False); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/UnitTests/Infrastructure/Validators/InvitationConstantsTests.cs b/Govor.API.Tests/UnitTests/Infrastructure/Validators/InvitationConstantsTests.cs deleted file mode 100644 index bb787f7..0000000 --- a/Govor.API.Tests/UnitTests/Infrastructure/Validators/InvitationConstantsTests.cs +++ /dev/null @@ -1,105 +0,0 @@ -using AutoFixture; -using Govor.Domain.Common.Constants; -using Govor.Domain.Models; - -namespace Govor.API.Tests.UnitTests.Infrastructure.Validators; - -[TestFixture] -public class InvitationConstantsTests -{ - private IObjectValidator _messageValidator; - private Fixture _fixture; - - public InvitationConstantsTests() - { - _messageValidator = new InvitationConstants(); - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - } - - [Test] - public void Given_ValidInvitation_When_Validate_Then_Returns_True() - { - var invitation = _fixture.Create(); - - // Act & Assert - Assert.DoesNotThrow( () => _messageValidator.Validate(invitation)); - Assert.That(_messageValidator.TryValidate(invitation), Is.True); - } - - [Test] - public void Given_NullInvitation_When_Validate_Then_Returns_False() - { - // Act & Assert - Assert.Throws>( () => _messageValidator.Validate(default)); - Assert.That(_messageValidator.TryValidate(default), Is.False); - } - - [Test] - public void Given_EmptyInvitationId_When_Validate_Then_Returns_False() - { - // Arrange - var invitation = _fixture.Create(); - invitation.Id = Guid.Empty; - - // Act & Assert - Assert.Throws>( () => _messageValidator.Validate(invitation)); - Assert.That(_messageValidator.TryValidate(invitation), Is.False); - } - - [Test] - public void Given_EmptyInvitationCreationDate_When_Validate_Then_Returns_False() - { - // Arrange - var invitation = _fixture.Create(); - invitation.DateCreated = DateTime.MinValue; - - // Act & Assert - Assert.Throws>( () => _messageValidator.Validate(invitation)); - Assert.That(_messageValidator.TryValidate(invitation), Is.False); - } - - [Test] - public void Given_InvalidEndDatesAndIsActive_When_Validate_Then_Returns_False() - { - // Arrange - var invitation = _fixture.Create(); - invitation.EndDate = invitation.DateCreated.AddDays(-1); - invitation.IsActive = true; - // Act & Assert - Assert.Throws>( () => _messageValidator.Validate(invitation)); - Assert.That(_messageValidator.TryValidate(invitation), Is.False); - } - - [Test] - public void Given_InvalidMaxParticipantsAndIsActive_When_Validate_Then_Returns_False() - { - // Arrange - var invitation = _fixture.Create(); - invitation.MaxParticipants = new Random().Next(-5, 0); - invitation.IsActive = true; - - // Act & Assert - Assert.Throws>( () => _messageValidator.Validate(invitation)); - Assert.That(_messageValidator.TryValidate(invitation), Is.False); - } - - [Test] - public void Given_InvalidCode_When_Validate_Then_Returns_False() - { - // Arrange - var invitation = _fixture.Create(); - invitation.Code = string.Empty; - - // Act & Assert - Assert.Throws>( () => _messageValidator.Validate(invitation)); - Assert.That(_messageValidator.TryValidate(invitation), Is.False); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/UnitTests/Infrastructure/Validators/MessageValidatorTests.cs b/Govor.API.Tests/UnitTests/Infrastructure/Validators/MessageValidatorTests.cs deleted file mode 100644 index aa9fb94..0000000 --- a/Govor.API.Tests/UnitTests/Infrastructure/Validators/MessageValidatorTests.cs +++ /dev/null @@ -1,134 +0,0 @@ -using AutoFixture; -using Govor.Domain.Common.Constants; -using Govor.Domain.Models; -using Govor.Domain.Models.Messages; - -namespace Govor.API.Tests.UnitTests.Infrastructure.Validators; - -[TestFixture] -public class MessageValidatorTests -{ - private IObjectValidator _messageValidator; - private Fixture _fixture; - - public MessageValidatorTests() - { - _messageValidator = new MessageValidator(); - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - } - - [Test] - public void Given_NullMessage_When_Validate_Should_Throw_InvalidObjectException() - { - // Act & Assert - Assert.ThrowsAsync>(async () => _messageValidator.Validate(default)); - } - - [Test] - public void Given_NullMessage_When_TryValidate_Then_Returns_False() - { - // Act & Assert - Assert.That(_messageValidator.TryValidate(default), Is.False); - } - - [Test] - public void Given_EmptyIdMessage_When_Validate_Should_Throw_InvalidObjectException() - { - // Arrange - Message message = _fixture.Create(); - message.Id = Guid.Empty; - - // Act & Assert - Assert.ThrowsAsync>(async () => _messageValidator.Validate(message)); - Assert.That(_messageValidator.TryValidate(message), Is.False); - } - - [Test] - public void Given_EmptySenderIdMessage_When_Validate_Should_Throw_InvalidObjectException() - { - // Arrange - Message message = _fixture.Create(); - message.SenderId = Guid.Empty; - - // Act & Assert - Assert.ThrowsAsync>(async () => _messageValidator.Validate(message)); - Assert.That(_messageValidator.TryValidate(message), Is.False); - } - - [Test] - public void Given_EmptyRecipientIdMessage_When_Validate_Should_Throw_InvalidObjectException() - { - // Arrange - Message message = _fixture.Create(); - message.RecipientId = Guid.Empty; - - // Act & Assert - Assert.ThrowsAsync>(async () => _messageValidator.Validate(message)); - Assert.That(_messageValidator.TryValidate(message), Is.False); - } - - [Test] - public void Given_EmptyEncryptedMessageAndNotEmptyMedia_When_Validate_Should_Throw_InvalidObjectException() - { - // Arrange - Message message = _fixture.Create(); - message.EncryptedContent = string.Empty; - - Assert.DoesNotThrowAsync(async () => _messageValidator.Validate(message)); - Assert.That(_messageValidator.TryValidate(message), Is.True); - } - - [Test] - public void Given_EmptyEncryptedMessageAndEmptyMedia_When_Validate_Should_Throw_InvalidObjectException() - { - // Arrange - Message message = _fixture.Create(); - message.EncryptedContent = string.Empty; - message.MediaAttachments = default; - - Assert.ThrowsAsync>(async () => _messageValidator.Validate(message)); - Assert.That(_messageValidator.TryValidate(message), Is.False); - } - - [Test] - public void Given_IsEditAndEmptyEditeTimeMessage_When_Validate_Should_Throw_InvalidObjectException() - { - // Arrange - Message message = _fixture.Create(); - message.IsEdited = true; - message.EditedAt = DateTime.MinValue; - - Assert.ThrowsAsync>(async () => _messageValidator.Validate(message)); - Assert.That(_messageValidator.TryValidate(message), Is.False); - } - - [Test] - public void Given_EmptySentAtMessage_When_Validate_Should_Throw_InvalidObjectException() - { - // Arrange - Message message = _fixture.Create(); - message.SentAt = DateTime.MinValue; - - Assert.ThrowsAsync>(async () => _messageValidator.Validate(message)); - Assert.That(_messageValidator.TryValidate(message), Is.False); - } - - [Test] - public void Given_ValidMessage_When_Validate_Then_Should_NotThrow() - { - // Arrange - Message message = _fixture.Create(); - - // Act & Assert - Assert.DoesNotThrowAsync(async () => _messageValidator.Validate(message)); - Assert.That(_messageValidator.TryValidate(message), Is.True); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/UnitTests/Infrastructure/Validators/PrivateChatValidatorTests.cs b/Govor.API.Tests/UnitTests/Infrastructure/Validators/PrivateChatValidatorTests.cs deleted file mode 100644 index f38c98e..0000000 --- a/Govor.API.Tests/UnitTests/Infrastructure/Validators/PrivateChatValidatorTests.cs +++ /dev/null @@ -1,77 +0,0 @@ -using AutoFixture; -using Govor.Domain.Common.Constants; -using Govor.Domain.Models; - -namespace Govor.API.Tests.UnitTests.Infrastructure.Validators; - -[TestFixture] -public class PrivateChatValidatorTests -{ - private IObjectValidator _validator = new PrivateChatValidator(); - private Fixture _fixture; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - } - - [Test] - public void Validate_PrivateChat_Valid() - { - // Arrange - var privateChat = _fixture.Create(); - - // Act & Assert - Assert.DoesNotThrow(() => _validator.Validate(privateChat)); - Assert.That(_validator.TryValidate(privateChat), Is.True); - } - - [Test] - public void Validate_When_PrivateChatIsNull_Invalid() - { - // Act & Assert - Assert.Throws>(() => _validator.Validate(default)); - Assert.That(_validator.TryValidate(default), Is.False); - } - - [Test] - public void Validate_When_PrivateChatIdIsEmpty_Invalid() - { - // Arrange - var privateChat = _fixture.Create(); - privateChat.Id = Guid.Empty; - // Act & Assert - Assert.Throws>(() => _validator.Validate(privateChat)); - Assert.That(_validator.TryValidate(privateChat), Is.False); - } - - [Test] - public void Validate_When_UserAIdIsEmpty_Invalid() - { - // Arrange - var privateChat = _fixture.Create(); - privateChat.UserAId = Guid.Empty; - // Act & Assert - Assert.Throws>(() => _validator.Validate(privateChat)); - Assert.That(_validator.TryValidate(privateChat), Is.False); - } - - [Test] - public void Validate_When_UserBIdIsEmpty_Invalid() - { - // Arrange - var privateChat = _fixture.Create(); - privateChat.UserBId = Guid.Empty; - // Act & Assert - Assert.Throws>(() => _validator.Validate(privateChat)); - Assert.That(_validator.TryValidate(privateChat), Is.False); - } -} \ No newline at end of file diff --git a/Govor.API.Tests/UnitTests/Infrastructure/Validators/UserConstantsTests.cs b/Govor.API.Tests/UnitTests/Infrastructure/Validators/UserConstantsTests.cs deleted file mode 100644 index 487d1ec..0000000 --- a/Govor.API.Tests/UnitTests/Infrastructure/Validators/UserConstantsTests.cs +++ /dev/null @@ -1,170 +0,0 @@ -using AutoFixture; -using Govor.Domain.Common.Constants; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; - -namespace Govor.API.Tests.UnitTests.Infrastructure.Validators; - -[TestFixture] -public class UserConstantsTests -{ - private IObjectValidator _userValidator; - private Fixture _fixture; - - [SetUp] - public void SetUp() - { - _userValidator = new UserConstants(); - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - } - - [Test] - public void Given_NullUser_ShouldThrow_InvalidObjectException() - { - // Act & Assert - Assert.ThrowsAsync>(async () => _userValidator.Validate(default)); - } - - [Test] - public void Given_NullUser_Then_Returns_False() - { - // Act & Assert - Assert.That(_userValidator.TryValidate(default), Is.False); - } - - [Test] - public void Given_EmptyId_ShouldThrow_InvalidObjectException() - { - // Arrange - User user = new User() - { - PasswordHash = _fixture.Create(), - Username = _fixture.Create(), - Id = Guid.Empty, - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - }; - - // Act & Assert - Assert.ThrowsAsync>(async () => _userValidator.Validate(user)); - } - - [Test] - public void Given_EmptyId_Then_Returns_False() - { - // Arrange - User user = new User() - { - PasswordHash = _fixture.Create(), - Username = _fixture.Create(), - Id = Guid.Empty, - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - }; - - // Act & Assert - Assert.That(_userValidator.TryValidate(user), Is.False); - } - - [Test] - public void Given_EmptyPassword_ShouldThrow_InvalidObjectException() - { - // Arrange - User user = new User() - { - PasswordHash = string.Empty, - Username = _fixture.Create(), - Id = Guid.NewGuid(), - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - }; - - // Act & Assert - Assert.ThrowsAsync>(async () => _userValidator.Validate(user)); - } - - [Test] - public void Given_EmptyPassword_Then_Returns_False() - { - // Arrange - User user = new User() - { - PasswordHash = string.Empty, - Username = _fixture.Create(), - Id = Guid.NewGuid(), - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - }; - - // Act & Assert - Assert.That(_userValidator.TryValidate(user), Is.False); - } - - [Test] - public void Given_EmptyName_ShouldThrow_InvalidObjectException() - { - // Arrange - User user = new User() - { - PasswordHash = _fixture.Create(), - Username = String.Empty, - Id = Guid.NewGuid(), - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - }; - - // Act & Assert - Assert.ThrowsAsync>(async () => _userValidator.Validate(user)); - } - - [Test] - public void Given_EmptyName_Then_Returns_False() - { - // Arrange - User user = new User() - { - PasswordHash = _fixture.Create(), - Username = String.Empty, - Id = Guid.NewGuid(), - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - }; - - // Act & Assert - Assert.That(_userValidator.TryValidate(user), Is.False); - } - - [Test] - public void Given_ValidUser_ShouldNotThrow_InvalidObjectException() - { - // Arrange - User user = new User() - { - PasswordHash = _fixture.Create(), - Username = _fixture.Create(), - Id = Guid.NewGuid(), - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - }; - - // Act & Assert - Assert.DoesNotThrowAsync(async () => _userValidator.Validate(user)); - } - - [Test] - public void Given_ValidUser_Then_Returns_True() - { - // Arrange - User user = new User() - { - PasswordHash = _fixture.Create(), - Username = _fixture.Create(), - Id = Guid.NewGuid(), - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - }; - - // Act & Assert - Assert.That(_userValidator.TryValidate(user), Is.True); - } -} \ No newline at end of file diff --git a/Govor.API/Controllers/MediaController.cs b/Govor.API/Controllers/MediaController.cs index e9be62b..c97550f 100644 --- a/Govor.API/Controllers/MediaController.cs +++ b/Govor.API/Controllers/MediaController.cs @@ -65,7 +65,7 @@ public class MediaController : Controller fileBytes, request.Type, request.MimeType, - request.EncryptedKey, + request.EncryptedKey ?? string.Empty, request.OwnerType, null) { diff --git a/Govor.Application.Tests/Govor.Application.Tests.csproj b/Govor.Application.Tests/Govor.Application.Tests.csproj deleted file mode 100644 index 19dfd3d..0000000 --- a/Govor.Application.Tests/Govor.Application.Tests.csproj +++ /dev/null @@ -1,35 +0,0 @@ - - - - net8.0 - latest - enable - enable - false - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/Govor.Application.Tests/Infrastructure/AdminsStuff/InvitationGeneratorTests.cs b/Govor.Application.Tests/Infrastructure/AdminsStuff/InvitationGeneratorTests.cs deleted file mode 100644 index e295386..0000000 --- a/Govor.Application.Tests/Infrastructure/AdminsStuff/InvitationGeneratorTests.cs +++ /dev/null @@ -1,89 +0,0 @@ -using AutoFixture; -using Govor.Application.Infrastructure.AdminsStuff; -using Govor.Application.Interfaces; -using Govor.Domain.Models; -using Govor.Domain.Repositories.Invaites; -using Moq; - -namespace Govor.Application.Tests.Infrastructure.AdminsStuff; - -[TestFixture] -public class InvitationGeneratorTests -{ - private Fixture _fixture; - private Mock _invitesRepositoryMock; - private IInvitationGenerator _invitationGenerator; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors.OfType().ToList().ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _invitesRepositoryMock = new Mock(); - _invitationGenerator = new InvitationGenerator(_invitesRepositoryMock.Object); - } - - [Test] - public async Task GenerateInvitationCode_ShouldReturnNonEmptyString_WhenCalled() - { - // Arrange - var endDate = _fixture.Create(); - var maxUsers = _fixture.Create(); - var isAdmin = _fixture.Create(); - var description = _fixture.Create(); - - // Act - var code = await _invitationGenerator.GenerateInvitationCode(endDate, maxUsers, isAdmin, description); - - // Assert - Assert.That(code, Is.Not.Null.And.Not.Empty); - } - - - [Test] - public async Task GenerateInvitationCode_ShouldCallAddAsyncOnRepository_WithCorrectInvitation() - { - // Arrange - var endDate = DateTime.UtcNow.AddDays(7); // Specific date for easier assertion if needed - var maxUsers = 10; - var isAdmin = false; - var description = "Test Invitation"; - Invitation capturedInvitation = null; - - _invitesRepositoryMock.Setup(repo => repo.AddAsync(It.IsAny())) - .Callback(inv => capturedInvitation = inv) - .Returns(Task.CompletedTask); - - // Act - var code = await _invitationGenerator.GenerateInvitationCode(endDate, maxUsers, isAdmin, description); - - // Assert - _invitesRepositoryMock.Verify(repo => repo.AddAsync(It.IsAny()), Times.Once); - Assert.That(capturedInvitation, Is.Not.Null); - Assert.That(capturedInvitation.EndDate.ToUniversalTime(), Is.EqualTo(endDate.ToUniversalTime())); - Assert.That(capturedInvitation.MaxParticipants, Is.EqualTo(maxUsers)); - Assert.That(capturedInvitation.IsAdmin, Is.EqualTo(isAdmin)); - Assert.That(capturedInvitation.Description, Is.EqualTo(description)); - Assert.That(capturedInvitation.Code, Is.EqualTo(code)); - Assert.That(capturedInvitation.IsActive, Is.True); // Assuming new invitations are active by default - } - - [Test] - public async Task GenerateInvitationCode_ShouldGenerateUniqueCode_WhenCalled() - { - // Arrange - var endDate = _fixture.Create(); - var maxUsers = _fixture.Create(); - var isAdmin = _fixture.Create(); - var description = _fixture.Create(); - - // Act - var code1 = await _invitationGenerator.GenerateInvitationCode(endDate, maxUsers, isAdmin, description); - var code2 = await _invitationGenerator.GenerateInvitationCode(endDate, maxUsers, isAdmin, description); - - // Assert - Assert.That(code1, Is.Not.EqualTo(code2)); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/Authentication/AuthServiceTests.cs b/Govor.Application.Tests/Services/Authentication/AuthServiceTests.cs deleted file mode 100644 index 71287df..0000000 --- a/Govor.Application.Tests/Services/Authentication/AuthServiceTests.cs +++ /dev/null @@ -1,102 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Extensions; -using Govor.Domain.Models; -using Govor.Domain.Repositories.Users; -using Govor.Application.Authentication.Exceptions; -using Govor.Application.Interfaces.Authentication; -using Govor.Application.Services.Authentication; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.Admins; -using Moq; - -namespace Govor.Application.Tests.Services.Authentication; - -[TestFixture] -public class AuthServiceTests -{ - private Fixture _fixture; - private Mock _passwordHasherMock; - private Mock _jwtServiceMock; - private Mock _usersRepositoryMock; - private Mock _adminsRepositoryMock; - private Mock _usernameValidatorMock; - - private IAccountService _accountService; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _usersRepositoryMock = new Mock(); - _passwordHasherMock = new Mock(); - _jwtServiceMock = new Mock(); - _adminsRepositoryMock = new Mock(); - _usernameValidatorMock = new Mock(); - - _accountService = new AuthService( - _usersRepositoryMock.Object, - _passwordHasherMock.Object, - _adminsRepositoryMock.Object, - _usernameValidatorMock.Object - ); - } - - // Tests for Register action - [Test] - public void Given_ExistUser_When_Register_Should_Throw_UserAlreadyExistsException() - { - // Arrange - _usersRepositoryMock.Setup(r => r.ExistsUsernameAsync(It.IsAny())).ReturnsAsync(true); - - // Act & Assert - Assert.ThrowsAsync(async () => await _accountService.RegistrationAsync( - _fixture.Create(), _fixture.Create(), _fixture.Create())); - } - - [Test] - public void Given_NotExistUser_When_Register_Should_Dont_Throw_UserNotRegisteredException() - { - // Arrange - _usersRepositoryMock.Setup(r => r.ExistsUsernameAsync(It.IsAny())).ReturnsAsync(false); - - // Act & Assert - Assert.DoesNotThrowAsync(async () => await _accountService.RegistrationAsync( - _fixture.Create(), _fixture.Create(), _fixture.Create())); - } - - [Test] - public void Given_WrongPassword_When_Login_Should_Throw_LoginUserException() - { - // Arrange - _usersRepositoryMock.Setup(r => r.ExistsUsernameAsync(It.IsAny())).ReturnsAsync(true); - - _passwordHasherMock.Setup(h => h.Verify(It.IsAny(), - It.IsAny())).Returns(false); - - _usersRepositoryMock.Setup(u => u.FindByUsernameAsync(It.IsAny())) - .ReturnsAsync(() => _fixture.Create()); - - // Act & Assert - Assert.ThrowsAsync(async () => await _accountService.LoginAsync( - _fixture.Create(), _fixture.Create())); - } - - [Test] - public void Given_NotExistUser_When_Login_Should_Throw_UserNotRegisteredException() - { - // Arrange - _usersRepositoryMock.Setup(r => r.ExistsUsernameAsync(It.IsAny())).ReturnsAsync(false); - - // Act & Assert - Assert.ThrowsAsync(async () => await _accountService.LoginAsync( - _fixture.Create(), _fixture.Create())); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/Friends/FriendRequestCommandServiceTests.cs b/Govor.Application.Tests/Services/Friends/FriendRequestCommandServiceTests.cs deleted file mode 100644 index d0fa9d2..0000000 --- a/Govor.Application.Tests/Services/Friends/FriendRequestCommandServiceTests.cs +++ /dev/null @@ -1,313 +0,0 @@ -using AutoFixture; -using Govor.Application.Exceptions.FriendsService; -using Govor.Application.Interfaces; -using Govor.Application.Interfaces.Friends; -using Govor.Application.PrivateUserChats; -using Govor.Application.Services.Friends; -using Govor.Domain.Models; -using Govor.Domain.Repositories.Friendships; -using Govor.Domain.Repositories.Users; -using Govor.Data.Repositories.Exceptions; -using Moq; - -namespace Govor.Application.Tests.Services.Friends; - -[TestFixture] -public class FriendRequestCommandServiceTests -{ - private Fixture _fixture; - private Mock _friendshipsRepositoryMock; - private Mock _privateChatsCreatorMock; - private IFriendRequestCommandService _service; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _friendshipsRepositoryMock = new Mock(); - _privateChatsCreatorMock = new Mock(); - - _service = new FriendRequestCommandService(_friendshipsRepositoryMock.Object, _privateChatsCreatorMock.Object); - } - - // SendFriendRequestAsync - [Test] - public void SendFriendRequestAsync_SendingToSelf_ThrowsInvalidOperationException() - { - // Arrange - var userId = Guid.NewGuid(); - - // Act & Assert - var ex = Assert.ThrowsAsync(() => - _service.SendAsync(userId, userId)); - - Assert.That(ex.Message, Is.EqualTo("Cannot send a request to self user")); - } - - [Test] - public void SendFriendRequestAsync_RequestAlreadyExists_ThrowsRequestAlreadySentException() - { - // Arrange - var fromUserId = Guid.NewGuid(); - var toUserId = Guid.NewGuid(); - - var existingFriendship = new Friendship - { - Id = Guid.NewGuid(), - RequesterId = fromUserId, - AddresseeId = toUserId, - Status = FriendshipStatus.Pending - }; - - _friendshipsRepositoryMock - .Setup(repo => repo.GetFriendshipAsync(fromUserId, toUserId)) - .ReturnsAsync(existingFriendship); - - // Act & Assert - Assert.ThrowsAsync(() => - _service.SendAsync(fromUserId, toUserId)); - } - - [Test] - public async Task SendFriendRequestAsync_ValidRequest_CallsAddAsync() - { - // Arrange - var fromUserId = Guid.NewGuid(); - var toUserId = Guid.NewGuid(); - - _friendshipsRepositoryMock - .Setup(repo => repo.Exist(fromUserId, toUserId)) - .Returns(false); - - // Act - await _service.SendAsync(fromUserId, toUserId); - - // Assert - _friendshipsRepositoryMock.Verify(repo => - repo.AddAsync(It.Is(f => - f.RequesterId == fromUserId && - f.AddresseeId == toUserId && - f.Status == FriendshipStatus.Pending && - f.Id != Guid.Empty - )), - Times.Once); - } - - // AcceptFriendRequestAsync - [Test] - public async Task AcceptFriendRequestAsync_ValidRequest_CallsUpdateAsync_AndCreatesPrivateChat() - { - // Arrange - var friendship = _fixture.Build() - .With(f => f.Status, FriendshipStatus.Pending) - .Create(); - - var privateChat = new PrivateChat - { - Id = Guid.NewGuid(), - UserAId = friendship.AddresseeId, - UserBId = friendship.RequesterId - }; - - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(friendship.Id)) - .ReturnsAsync(friendship); - - _privateChatsCreatorMock - .Setup(p => p.CreateAsync(friendship.AddresseeId, friendship.RequesterId)) - .ReturnsAsync(privateChat); - - // Act - await _service.AcceptAsync(friendship.Id, friendship.AddresseeId); - - // Assert - _friendshipsRepositoryMock.Verify(r => r.UpdateAsync(It.Is(f => - f.Id == friendship.Id && - f.RequesterId == friendship.RequesterId && - f.AddresseeId == friendship.AddresseeId && - f.Status == FriendshipStatus.Accepted - )), Times.Once); - - _privateChatsCreatorMock.Verify(p => p.CreateAsync( - friendship.AddresseeId, - friendship.RequesterId - ), Times.Once); - } - - [Test] - public void AcceptFriendRequestAsync_Throws_InvalidOperationException_IfStatusNotEqualPending() - { - var friendship = _fixture.Build() - .With(f => f.Status, FriendshipStatus.Accepted) - .Create(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(friendship.Id)) - .ReturnsAsync(friendship); - - // Act & Assert - Assert.ThrowsAsync(async () => await _service.AcceptAsync(friendship.Id, friendship.AddresseeId)); - } - [Test] - public void AcceptFriendRequestAsync_Throws_UnauthorizedAccessException_IfCurrentUserIdIsNotAddressee() - { - // Arrange - var friendship = _fixture.Build() - .With(f => f.Status, FriendshipStatus.Pending) - .Create(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(friendship.Id)) - .ReturnsAsync(friendship); - - var wrongUserId = Guid.NewGuid(); // не совпадает с AddresseeId - - // Act & Assert - Assert.ThrowsAsync(async () => - await _service.AcceptAsync(friendship.Id, wrongUserId)); - } - - [Test] - public void AcceptFriendRequestAsync_Throws_InvalidOperationException_IfFriendshipNotFound() - { - // Arrange - var requestId = Guid.NewGuid(); - var userId = Guid.NewGuid(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(requestId)) - .ThrowsAsync(new NotFoundByKeyException(requestId)); - - // Act & Assert - Assert.ThrowsAsync(async () => - await _service.AcceptAsync(requestId, userId)); - } - - [Test] - public async Task AcceptFriendRequestAsync_ChangesStatusToAccepted() - { - var friendship = _fixture.Build() - .With(f => f.Status, FriendshipStatus.Pending) - .Create(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(friendship.Id)) - .ReturnsAsync(friendship); - - Friendship updatedFriendship = null; - - _friendshipsRepositoryMock - .Setup(r => r.UpdateAsync(It.IsAny())) - .Callback(f => updatedFriendship = f) - .Returns(Task.CompletedTask); - - await _service.AcceptAsync(friendship.Id, friendship.AddresseeId); - - Assert.That(updatedFriendship.Status, Is.EqualTo(FriendshipStatus.Accepted)); - } - - // RejectFriend - [Test] - public async Task RejectFriendRequestAsync_ValidRequest_CallsRemoveAsync() - { - var friendship = _fixture.Build() - .With(f => f.Status, FriendshipStatus.Pending) - .Create(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(friendship.Id)) - .ReturnsAsync(friendship); - - await _service.RejectAsync(friendship.Id, friendship.AddresseeId); - - // Assert - _friendshipsRepositoryMock.Verify(r => r.UpdateAsync(It.Is(f => - f.Id == friendship.Id && - f.RequesterId == friendship.RequesterId && - f.AddresseeId == friendship.AddresseeId && - f.Status == FriendshipStatus.Rejected - )), Times.Once); - } - - [Test] - public void RejectFriendRequestAsync_Throws_InvalidOperationException_IfStatusNotEqualPendingOrReject() - { - var friendship = _fixture.Build() - .With(f => f.Status, FriendshipStatus.Accepted) - .Create(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(friendship.Id)) - .ReturnsAsync(friendship); - - // Act & Assert - Assert.ThrowsAsync(async () => await _service.RejectAsync(friendship.Id, friendship.AddresseeId)); - } - - [Test] - public void RejectFriendRequestAsync_Throws_UnauthorizedAccessException_IfCurrentUserIdIsNotAddressee() - { - // Arrange - var friendship = _fixture.Build() - .With(f => f.Status, FriendshipStatus.Pending) - .Create(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(friendship.Id)) - .ReturnsAsync(friendship); - - var wrongUserId = Guid.NewGuid(); // не совпадает с AddresseeId - - // Act & Assert - Assert.ThrowsAsync(async () => - await _service.RejectAsync(friendship.Id, wrongUserId)); - } - - [Test] - public void RejectFriendRequestAsync_Throws_InvalidOperationException_IfFriendshipNotFound() - { - // Arrange - var requestId = Guid.NewGuid(); - var userId = Guid.NewGuid(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(requestId)) - .ThrowsAsync(new NotFoundByKeyException(requestId)); - - // Act & Assert - Assert.ThrowsAsync(async () => - await _service.RejectAsync(requestId, userId)); - } - - [Test] - public async Task RejectFriendRequestAsync_ChangesStatusToAccepted() - { - var friendship = _fixture.Build() - .With(f => f.Status, FriendshipStatus.Pending) - .Create(); - - _friendshipsRepositoryMock - .Setup(r => r.GetByIdAsync(friendship.Id)) - .ReturnsAsync(friendship); - - Friendship updatedFriendship = null; - - _friendshipsRepositoryMock - .Setup(r => r.UpdateAsync(It.IsAny())) - .Callback(f => updatedFriendship = f) - .Returns(Task.CompletedTask); - - await _service.RejectAsync(friendship.Id, friendship.AddresseeId); - - Assert.That(updatedFriendship.Status, Is.EqualTo(FriendshipStatus.Rejected)); - } - - -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/Friends/FriendRequestQueryServiceTests.cs b/Govor.Application.Tests/Services/Friends/FriendRequestQueryServiceTests.cs deleted file mode 100644 index aa627aa..0000000 --- a/Govor.Application.Tests/Services/Friends/FriendRequestQueryServiceTests.cs +++ /dev/null @@ -1,131 +0,0 @@ -using AutoFixture; -using Govor.Application.Interfaces.Friends; -using Govor.Application.Services.Friends; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.Friendships; -using Govor.Domain.Repositories.Users; -using Govor.Data.Repositories.Exceptions; -using Moq; - -namespace Govor.Application.Tests.Services.Friends; - -[TestFixture] -public class FriendRequestQueryServiceTests -{ - private Fixture _fixture; - private Mock _usersRepositoryMock; - private Mock _friendshipsRepositoryMock; - private IFriendRequestQueryService _service; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _usersRepositoryMock = new Mock(); - _friendshipsRepositoryMock = new Mock(); - - _service = new FriendRequestQueryService(_friendshipsRepositoryMock.Object); - } - - // GetIncomingRequestsAsync - [Test] - public async Task GetIncomingRequestsAsync_ReturnsFriendships_IfFriendshipsExists() - { - // Arrange - var userId = Guid.NewGuid(); - - var friendships = _fixture.CreateMany().ToList(); - - var user = _fixture.Build() - .With(u => u.Id, userId) - .With(u => u.ReceivedFriendRequests, friendships) - .Create(); - - friendships.ForEach(f => - { - f.AddresseeId = userId; - f.Addressee = user; - f.Status = FriendshipStatus.Pending; - }); - - _friendshipsRepositoryMock.Setup(f => f.FindByUserIdAsync(userId)) - .ReturnsAsync(friendships); - - // Act - var result = await _service.GetIncomingAsync(userId); - - // Assert - Assert.That(result.Count, Is.EqualTo(friendships.Count)); - Assert.That(result.Select(u => u.Id), Is.EquivalentTo(friendships.Select(f => f.Id))); - } - - [Test] - public void GetIncomingRequestsAsync_ThrowsInvalidOperationException_WhenUserNotFound() - { - // Arrange - var userId = Guid.NewGuid(); - - _friendshipsRepositoryMock - .Setup(r => r.FindByUserIdAsync(userId)) - .ThrowsAsync(new NotFoundByKeyException(userId)); - - // Act & Assert - Assert.ThrowsAsync(async () => - await _service.GetIncomingAsync(userId)); - } - - // GetResponsesAsync - [Test] - public async Task GetResponsesAsync_ReturnsFriendships_IfFriendshipsExists() - { - // Arrange - var userId = Guid.NewGuid(); - - var friendships = _fixture.CreateMany().ToList(); - - var user = _fixture.Build() - .With(u => u.Id, userId) - .With(u => u.ReceivedFriendRequests, friendships) - .Create(); - - friendships.ForEach(f => - { - f.RequesterId = userId; - f.Requester = user; - f.Status = FriendshipStatus.Rejected; - }); - - _friendshipsRepositoryMock.Setup(f => f.FindByUserIdAsync(userId)) - .ReturnsAsync(friendships); - - // Act - var result = await _service.GetResponsesAsync(userId); - - // Assert - Assert.That(result.Count, Is.EqualTo(friendships.Count)); - Assert.That(result.Select(u => u.Id), Is.EquivalentTo(friendships.Select(f => f.Id))); - } - - [Test] - public void GetResponsesAsync_ThrowsInvalidOperationException_WhenUserNotFound() - { - // Arrange - var userId = Guid.NewGuid(); - - _friendshipsRepositoryMock - .Setup(r => r.FindByUserIdAsync(userId)) - .ThrowsAsync(new NotFoundByKeyException(userId)); - - // Act & Assert - Assert.ThrowsAsync(async () => - await _service.GetResponsesAsync(userId)); - } - -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/Friends/FriendshipServiceTests.cs b/Govor.Application.Tests/Services/Friends/FriendshipServiceTests.cs deleted file mode 100644 index 1653ef5..0000000 --- a/Govor.Application.Tests/Services/Friends/FriendshipServiceTests.cs +++ /dev/null @@ -1,162 +0,0 @@ -using AutoFixture; -using Govor.Application.Interfaces.Friends; -using Govor.Application.Services.Friends; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.Friendships; -using Govor.Domain.Repositories.Users; -using Govor.Data.Repositories.Exceptions; -using Moq; - -namespace Govor.Application.Tests.Services.Friends; - -[TestFixture] -public class FriendshipServiceTests -{ - private Fixture _fixture; - private Mock _usersRepositoryMock; - private Mock _friendshipsRepositoryMock; - IFriendshipService _service; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _usersRepositoryMock = new Mock(); - _friendshipsRepositoryMock = new Mock(); - - _service = new FriendshipService(_usersRepositoryMock.Object, _friendshipsRepositoryMock.Object); - } - - // SearchUsersAsync - [Test] - public async Task SearchUsersAsync_ReturnsUsers_IfNotAlreadyFriends() - { - // Arrange - var userId = _fixture.Create(); - var user = _fixture.Create(); - user.Id = Guid.NewGuid(); - - _usersRepositoryMock - .Setup(u => u.SearchPotentialFriendsAsync(userId, It.IsAny())) - .ReturnsAsync(new List { user }); - - _friendshipsRepositoryMock - .Setup(f => f.FindByUserIdAsync(userId)) - .ReturnsAsync(new List()); // No friends - - // Act - var result = await _service.SearchUsersAsync("test", userId); - - // Assert - Assert.That(result, Has.Count.EqualTo(1)); - Assert.That(result[0].Id, Is.EqualTo(user.Id)); - } - - [Test] - public async Task SearchUsersAsync_Returns_EmptyList_IfThrowsNotFoundByKeyException_String_Guid() - { - // Arrange - _usersRepositoryMock - .Setup(u => u.SearchPotentialFriendsAsync(It.IsAny(), It.IsAny())) - .ThrowsAsync(new NotFoundByKeyException<(string,Guid)>(("test",Guid.NewGuid()),"test")); - - // Act - var users = await _service.SearchUsersAsync("test", Guid.NewGuid()); - - // & Assert - Assert.That(users, Is.Empty); - } - - [Test] - public async Task SearchUsersAsync_ReturnsUsersWithoutFriendships_IfThrowsNotFoundByKeyException_Guid() - { - // Arrange - var userId = _fixture.Create(); - var user = _fixture.Create(); - user.Id = Guid.NewGuid(); - - _usersRepositoryMock - .Setup(u => u.SearchPotentialFriendsAsync(userId, It.IsAny())) - .ReturnsAsync(new List { user }); - - _friendshipsRepositoryMock - .Setup(f => f.FindByUserIdAsync(userId)) - .ThrowsAsync(new NotFoundByKeyException(userId, "test")); - - // Act - var result = await _service.SearchUsersAsync("test", userId); - - // Assert - Assert.That(result, Has.Count.EqualTo(1)); - Assert.That(result[0].Id, Is.EqualTo(user.Id)); - } - - [Test] - public void SearchUsersAsync_Throws_UnauthorizedAccessException_IfThrowsSomeExceptionInUsersRepository() - { - // Arrange - _usersRepositoryMock - .Setup(u => u.SearchPotentialFriendsAsync(It.IsAny(), It.IsAny())) - .ThrowsAsync(new Exception("test")); - - // Act & Assert - Assert.ThrowsAsync(async () => await _service.SearchUsersAsync("test", Guid.NewGuid())); - } - - [Test] - public void SearchUsersAsync_Throws_UnauthorizedAccessException_IfThrowsSomeExceptionInFriendshipsRepository() - { - // Arrange - _usersRepositoryMock - .Setup(u => u.SearchPotentialFriendsAsync(It.IsAny(), "test")) - .ThrowsAsync(new Exception("test")); - - // Act & Assert - Assert.ThrowsAsync( - async () => await _service.SearchUsersAsync("test", Guid.NewGuid()) - ); - } - - // GetFriendsAsync - [Test] - public async Task GetFriendsAsync_ReturnsUsers_IfUserExists() - { - // Arrange - var userId = Guid.NewGuid(); - var friendships = _fixture.CreateMany().ToList(); - - friendships.ForEach(f => - { - f.RequesterId = userId; - f.Status = FriendshipStatus.Accepted; - }); - - _friendshipsRepositoryMock.Setup(f => f.FindByUserIdAsync(userId)) - .ReturnsAsync(friendships); - - // Act - var result = await _service.GetFriendsAsync(userId); - - // Assert - Assert.That(result.Count, Is.EqualTo(friendships.Count)); - Assert.That(result, Is.EquivalentTo(friendships.Select(f => f.Addressee))); - } - - [Test] - public void GetFriendsAsync_Throws_InvalidOperationException_IfUserNotExists() - { - // Arrange - _friendshipsRepositoryMock.Setup(f => f.FindByUserIdAsync(It.IsAny())) - .ThrowsAsync(new NotFoundByKeyException(Guid.NewGuid())); - - // Act & Assert - Assert.ThrowsAsync(async () => await _service.GetFriendsAsync(Guid.NewGuid())); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/Medias/AccesserToDownloadMediaServiceTests.cs b/Govor.Application.Tests/Services/Medias/AccesserToDownloadMediaServiceTests.cs deleted file mode 100644 index 3a6054a..0000000 --- a/Govor.Application.Tests/Services/Medias/AccesserToDownloadMediaServiceTests.cs +++ /dev/null @@ -1,294 +0,0 @@ -using Govor.Application.Services.Medias; -using Govor.Domain.Models; -using Govor.Domain.Models.Messages; -using Govor.Data; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Application.Tests.Services.Medias; - -[TestFixture] -public class AccesserToDownloadMediaServiceTests -{ - private GovorDbContext _dbContext = null!; - private AccesserToDownloadMediaService _accesser = null!; - private Guid _userId; - private Guid _otherUserId; - private Guid _groupId; - private Guid _mediaFileId; - - [SetUp] - public async Task SetUp() - { - var options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(Guid.NewGuid().ToString()) - .Options; - - _dbContext = new GovorDbContext(options); - _accesser = new AccesserToDownloadMediaService(_dbContext); - - _userId = Guid.NewGuid(); - _otherUserId = Guid.NewGuid(); - _groupId = Guid.NewGuid(); - _mediaFileId = Guid.NewGuid(); - - // ������� ��������� � ����� - var message = new Message - { - Id = Guid.NewGuid(), - SenderId = _userId, - RecipientId = _otherUserId, - RecipientType = RecipientType.User - }; - - var media = new MediaFile - { - Id = _mediaFileId, - Url = "/media/test.png", - MineType = "image/png", - MediaType = MediaType.Image, - UploaderId = _userId, - DateCreated = DateTime.UtcNow, - OwnerType = MediaOwnerType.Message, - OwnerId = message.Id - }; - - var attachment = new MediaAttachments - { - Id = Guid.NewGuid(), - MediaFileId = _mediaFileId, - MessageId = message.Id, - Message = message, - MediaFile = media - }; - - await _dbContext.Messages.AddAsync(message); - await _dbContext.MediaFiles.AddAsync(media); - await _dbContext.MediaAttachments.AddAsync(attachment); - await _dbContext.SaveChangesAsync(); - } - - [Test] - public async Task HasAccessAsync_ReturnsTrue_ForSender() - { - var result = await _accesser.HasAccessAsync(_mediaFileId, _userId); - Assert.That(result, Is.True); - } - - [Test] - public async Task HasAccessAsync_ReturnsTrue_ForRecipient() - { - var result = await _accesser.HasAccessAsync(_mediaFileId, _otherUserId); - Assert.That(result, Is.True); - } - - [Test] - public async Task HasAccessAsync_ReturnsFalse_ForUnrelatedUser() - { - var unrelatedUserId = Guid.NewGuid(); - var result = await _accesser.HasAccessAsync(_mediaFileId, unrelatedUserId); - Assert.That(result, Is.False); - } - - [Test] - public async Task HasAccessAsync_ReturnsTrue_ForGroupMember() - { - var groupMediaId = Guid.NewGuid(); - - var groupMessage = new Message - { - Id = Guid.NewGuid(), - SenderId = _userId, - RecipientId = _groupId, - RecipientType = RecipientType.Group - }; - - var media = new MediaFile - { - Id = groupMediaId, - Url = "/media/group.png", - MineType = "image/png", - MediaType = MediaType.Image, - UploaderId = _userId, - DateCreated = DateTime.UtcNow, - OwnerType = MediaOwnerType.Message, - OwnerId = groupMessage.Id - }; - - var attachment = new MediaAttachments - { - Id = Guid.NewGuid(), - MediaFileId = groupMediaId, - MessageId = groupMessage.Id, - Message = groupMessage, - MediaFile = media - }; - - var membership = new GroupMembership - { - Id = Guid.NewGuid(), - GroupId = _groupId, - UserId = _otherUserId - }; - - await _dbContext.Messages.AddAsync(groupMessage); - await _dbContext.MediaFiles.AddAsync(media); - await _dbContext.MediaAttachments.AddAsync(attachment); - await _dbContext.GroupMemberships.AddAsync(membership); - await _dbContext.SaveChangesAsync(); - - var result = await _accesser.HasAccessAsync(groupMediaId, _otherUserId); - Assert.That(result, Is.True); - } - - [Test] - public async Task HasAccessAsync_ReturnsFalse_IfMediaNotAttached() - { - var result = await _accesser.HasAccessAsync(Guid.NewGuid(), _userId); - Assert.That(result, Is.False); - } - - [Test] - public async Task HasAccessAsync_ReturnsTrue_ForUserAvatar() - { - var avatarMedia = new MediaFile - { - Id = Guid.NewGuid(), - Url = "/media/avatar.png", - MineType = "image/png", - MediaType = MediaType.Image, - UploaderId = _userId, - OwnerType = MediaOwnerType.Avatar, - OwnerId = _userId, - DateCreated = DateTime.UtcNow - }; - - await _dbContext.MediaFiles.AddAsync(avatarMedia); - await _dbContext.SaveChangesAsync(); - - var result = await _accesser.HasAccessAsync(avatarMedia.Id, _userId); - Assert.That(result, Is.True); - } - - [Test] - public async Task HasAccessAsync_ReturnsTrue_ForOtherUserAvatar() - { - var avatarMedia = new MediaFile - { - Id = Guid.NewGuid(), - Url = "/media/avatar2.png", - MineType = "image/png", - MediaType = MediaType.Image, - UploaderId = _otherUserId, - OwnerType = MediaOwnerType.Avatar, - OwnerId = _otherUserId, - DateCreated = DateTime.UtcNow - }; - - await _dbContext.MediaFiles.AddAsync(avatarMedia); - await _dbContext.SaveChangesAsync(); - - var result = await _accesser.HasAccessAsync(avatarMedia.Id, _userId); - Assert.That(result, Is.True); - } - - [Test] - public async Task HasAccessAsync_ReturnsTrue_ForGroupAvatarMember() - { - var groupAvatar = new MediaFile - { - Id = Guid.NewGuid(), - Url = "/media/group_avatar.png", - MineType = "image/png", - MediaType = MediaType.Image, - UploaderId = _userId, - OwnerType = MediaOwnerType.GroupAvatar, - OwnerId = _groupId, - DateCreated = DateTime.UtcNow - }; - - var membership = new GroupMembership - { - Id = Guid.NewGuid(), - GroupId = _groupId, - UserId = _otherUserId - }; - - await _dbContext.MediaFiles.AddAsync(groupAvatar); - await _dbContext.GroupMemberships.AddAsync(membership); - await _dbContext.SaveChangesAsync(); - - var result = await _accesser.HasAccessAsync(groupAvatar.Id, _otherUserId); - Assert.That(result, Is.True); - } - - [Test] - public async Task HasAccessAsync_ReturnsFalse_ForGroupAvatarNonMember() - { - var groupAvatar = new MediaFile - { - Id = Guid.NewGuid(), - Url = "/media/group_avatar2.png", - MineType = "image/png", - MediaType = MediaType.Image, - UploaderId = _userId, - OwnerType = MediaOwnerType.GroupAvatar, - OwnerId = _groupId, - DateCreated = DateTime.UtcNow - }; - - await _dbContext.MediaFiles.AddAsync(groupAvatar); - await _dbContext.SaveChangesAsync(); - - var unrelatedUserId = Guid.NewGuid(); - var result = await _accesser.HasAccessAsync(groupAvatar.Id, unrelatedUserId); - Assert.That(result, Is.False); - } - - [Test] - public async Task HasAccessAsync_ReturnsTrue_ForSystemMedia() - { - var systemMedia = new MediaFile - { - Id = Guid.NewGuid(), - Url = "/media/system.png", - MineType = "image/png", - MediaType = MediaType.Image, - UploaderId = _userId, - OwnerType = MediaOwnerType.System, - DateCreated = DateTime.UtcNow - }; - - await _dbContext.MediaFiles.AddAsync(systemMedia); - await _dbContext.SaveChangesAsync(); - - var result = await _accesser.HasAccessAsync(systemMedia.Id, Guid.NewGuid()); - Assert.That(result, Is.True); - } - - [Test] - public async Task HasAccessAsync_ReturnsFalse_ForUnknownOwnerType() - { - var unknownMedia = new MediaFile - { - Id = Guid.NewGuid(), - Url = "/media/unknown.png", - MineType = "image/png", - MediaType = MediaType.Image, - UploaderId = _userId, - OwnerType = (MediaOwnerType)999, // ����������� ��� - DateCreated = DateTime.UtcNow - }; - - await _dbContext.MediaFiles.AddAsync(unknownMedia); - await _dbContext.SaveChangesAsync(); - - var result = await _accesser.HasAccessAsync(unknownMedia.Id, _userId); - Assert.That(result, Is.False); - } - - [TearDown] - public void TearDown() - { - _dbContext.Dispose(); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/Messages/MessageCommandServiceTests.cs b/Govor.Application.Tests/Services/Messages/MessageCommandServiceTests.cs deleted file mode 100644 index 5cc7e2d..0000000 --- a/Govor.Application.Tests/Services/Messages/MessageCommandServiceTests.cs +++ /dev/null @@ -1,359 +0,0 @@ -using Govor.Application.Exceptions.VerifyFriendship; -using Govor.Application.Interfaces; -using Govor.Application.Interfaces.Medias; -using Govor.Application.Interfaces.Messages.Parameters; -using Govor.Application.PrivateUserChats; -using Govor.Application.Services.Messages; -using Govor.Domain.Models; -using Govor.Domain.Models.Messages; -using Govor.Domain.Repositories.Groups; -using Govor.Domain.Repositories.Messages; -using Govor.Domain.Repositories.PrivateChats; -using Govor.Domain.Repositories.Users; -using Govor.Data.Repositories.Exceptions; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.Application.Tests.Services.Messages; - -[TestFixture] -public class MessageCommandServiceTests -{ - private Mock _mockMessagesRepo; - private Mock _mockUsersRepo; - private Mock _mockGroupsRepo; - private Mock _mockPrivateChatsRepo; - private Mock _mockVerifyFriendship; - private Mock _mockMediaService; - private Mock _mockUserPrivateChatCreator; - private Mock> _mockLogger; - private MessageCommandService _messageService; - - [SetUp] - public void SetUp() - { - _mockMessagesRepo = new Mock(); - _mockUsersRepo = new Mock(); - _mockGroupsRepo = new Mock(); - _mockPrivateChatsRepo = new Mock(); - _mockVerifyFriendship = new Mock(); - _mockMediaService = new Mock(); - _mockUserPrivateChatCreator = new Mock(); - _mockLogger = new Mock>(); - - _messageService = new MessageCommandService( - _mockMessagesRepo.Object, - _mockUsersRepo.Object, - _mockGroupsRepo.Object, - _mockPrivateChatsRepo.Object, - _mockUserPrivateChatCreator.Object, - _mockVerifyFriendship.Object, - _mockMediaService.Object, - _mockLogger.Object); - } - - - // Test for SendMessageAsync action - [Test] - public async Task SendMessageAsync_ToUser_Success() - { - // Arrange - var senderId = Guid.NewGuid(); - var recipientId = Guid.NewGuid(); - - var privateChat = new PrivateChat - { - Id = recipientId, - UserAId = senderId, - UserBId = Guid.NewGuid() - }; - - var sendParams = new SendMessage( - "Hello", - null, - recipientId, - RecipientType.User, - senderId, - DateTime.UtcNow, - new List()); - - _mockPrivateChatsRepo - .Setup(r => r.GetByIdAsync(recipientId)) - .ReturnsAsync(privateChat); - - _mockMessagesRepo - .Setup(r => r.AddAsync(It.IsAny())) - .Returns(Task.CompletedTask); - - // Act - var result = await _messageService.SendMessageAsync(sendParams); - - // Assert - Assert.That(result.IsSuccess, Is.True); - Assert.That(result.Exception, Is.Null); - - _mockMessagesRepo.Verify(r => r.AddAsync(It.Is(m => - m.SenderId == senderId && - m.RecipientId == recipientId && - m.RecipientType == RecipientType.User && - m.EncryptedContent == "Hello")), Times.Once); - } - - [Test] - public async Task SendMessageAsync_ToUser_When_AttachMediaThrowsException_ReturnsFailure() - { - // Arrange - var senderId = Guid.NewGuid(); - var recipientId = Guid.NewGuid(); - var sendMediaId = Guid.NewGuid(); - - var privateChat = new PrivateChat - { - Id = recipientId, - UserAId = senderId, - UserBId = recipientId - }; - - var sendParams = new SendMessage( - "Hello", - null, - recipientId, - RecipientType.User, - senderId, - DateTime.UtcNow, - new List - { - new SendMedia(sendMediaId, string.Empty) - }); - - _mockPrivateChatsRepo - .Setup(r => r.GetByIdAsync(recipientId)) - .ReturnsAsync(privateChat); - - _mockMediaService - .Setup(m => m.AttachToMessageAsync(sendMediaId, It.IsAny())) - .ThrowsAsync(new Exception("Unexpected DB error")); - - // Act - var result = await _messageService.SendMessageAsync(sendParams); - - // Assert - Assert.That(result.IsSuccess, Is.False); - Assert.That(result.Exception!.Message, Is.EqualTo("Unexpected DB error")); - - _mockMessagesRepo.Verify(r => r.AddAsync(It.IsAny()), Times.Never); - } - - [Test] - public async Task SendMessageAsync_ToGroup_Success() - { - // Arrange - var senderId = Guid.NewGuid(); - var groupId = Guid.NewGuid(); - - var sendMessageParams = new SendMessage("Hello Group", - null, - groupId, - RecipientType.Group, - senderId, - DateTime.UtcNow, - new List()); - - _mockGroupsRepo.Setup(r => r.Exist(groupId)).Returns(true); - _mockGroupsRepo.Setup(r => r.IsUserMemberOfGroupAsync(senderId, groupId)).ReturnsAsync(true); - _mockMessagesRepo.Setup(r => r.AddAsync(It.IsAny())).Returns(Task.CompletedTask); - - // Act - var result = await _messageService.SendMessageAsync(sendMessageParams); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.IsSuccess, Is.True); - Assert.That(result.Exception, Is.Null); - _mockMessagesRepo.Verify(r => r.AddAsync(It.Is(m => - m.RecipientId == groupId && - m.RecipientType == RecipientType.Group)), Times.Once); - } - - [Test] - public async Task SendMessageAsync_ToUser_PrivateChatNotFound_ReturnsFailure() - { - // Arrange - var senderId = Guid.NewGuid(); - var recipientId = Guid.NewGuid(); - - var sendParams = new SendMessage( - "Hello", - null, - recipientId, - RecipientType.User, - senderId, - DateTime.UtcNow, - new List()); - - _mockPrivateChatsRepo - .Setup(r => r.GetByIdAsync(recipientId)) - .ReturnsAsync((PrivateChat?)null); - - // Act - var result = await _messageService.SendMessageAsync(sendParams); - - // Assert - Assert.That(result.IsSuccess, Is.False); - Assert.That(result.Exception, Is.TypeOf()); - Assert.That(result.Message, Is.Null); - } - - // Test for EditMessageAsync action - [Test] - public async Task EditMessageAsync_Success() - { - // Arrange - var editorId = Guid.NewGuid(); - var messageId = Guid.NewGuid(); - - var originalMessage = new Message - { - Id = messageId, - SenderId = editorId, - EncryptedContent = "Old", - RecipientId = Guid.NewGuid(), - RecipientType = RecipientType.User - }; - - var editParams = new EditMessage(editorId, messageId, "New Content", DateTime.UtcNow); - - _mockMessagesRepo.Setup(r => r.FindByIdAsync(messageId)).ReturnsAsync(originalMessage); - _mockMessagesRepo.Setup(r => r.UpdateAsync(It.IsAny())).Returns(Task.CompletedTask); - - // Act - var result = await _messageService.EditMessageAsync(editParams); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.IsSuccess, Is.True); - Assert.That(result.OriginalMessage, Is.Not.Null); - - Assert.That(messageId, Is.EqualTo(result.OriginalMessage!.Id)); - - _mockMessagesRepo.Verify(r => r.UpdateAsync(It.Is(m => - m.Id == messageId && - m.EncryptedContent == "New Content" && - m.IsEdited == true && - m.EditedAt == editParams.EditedAt)), Times.Once); - } - - [Test] - public async Task EditMessageAsync_MessageNotFound_ReturnsFailure() - { - // Arrange - var editorId = Guid.NewGuid(); - var messageId = Guid.NewGuid(); - var editParams = new EditMessage(editorId, messageId, "New Content", DateTime.UtcNow); - - _mockMessagesRepo.Setup(r => r.FindByIdAsync(messageId)). - ThrowsAsync(new NotFoundByKeyException(messageId)); - - // Act - var result = await _messageService.EditMessageAsync(editParams); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.IsSuccess, Is.False); - Assert.That(result.Exception, Is.Not.Null); - Assert.That(result.Exception,Is.TypeOf>()); - Assert.That(result.OriginalMessage, Is.Null); - } - - [Test] - public async Task EditMessageAsync_NotSender_ReturnsFailure() - { - // Arrange - var editorId = Guid.NewGuid(); - var senderId = Guid.NewGuid(); // Different from editorId - var messageId = Guid.NewGuid(); - var originalMessage = new Message { Id = messageId, SenderId = senderId, EncryptedContent = "Old" }; - var editParams = new EditMessage(editorId, messageId, "New Content", DateTime.UtcNow); - - _mockMessagesRepo.Setup(r => r.FindByIdAsync(messageId)).ReturnsAsync(originalMessage); - - // Act - var result = await _messageService.EditMessageAsync(editParams); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.IsSuccess, Is.False); - Assert.That(result.Exception, Is.Not.Null); - Assert.That(result.Exception,Is.TypeOf()); - Assert.That(result.OriginalMessage, Is.Null); - } - - // Test for DeleteMessageAsync action - [Test] - public async Task DeleteMessageAsync_Success() - { - // Arrange - var deleterId = Guid.NewGuid(); - var messageId = Guid.NewGuid(); - var originalMessage = new Message { Id = messageId, SenderId = deleterId, RecipientId = Guid.NewGuid(), RecipientType = RecipientType.User }; - var deleteParams = new DeleteMessage(deleterId, messageId); - - _mockMessagesRepo.Setup(r => r.FindByIdAsync(messageId)).ReturnsAsync(originalMessage); - _mockMessagesRepo.Setup(r => r.RemoveAsync(messageId)).Returns(Task.CompletedTask); - - // Act - var result = await _messageService.DeleteMessageAsync(deleteParams); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.IsSuccess, Is.True); - Assert.That(result.OriginalMessage, Is.Not.Null); - Assert.That(messageId, Is.EqualTo(result.OriginalMessage!.Id)); - _mockMessagesRepo.Verify(r => r.RemoveAsync(messageId), Times.Once); - } - - [Test] - public async Task DeleteMessageAsync_MessageNotFound_ReturnsFailure() - { - // Arrange - var deleterId = Guid.NewGuid(); - var messageId = Guid.NewGuid(); - var deleteParams = new DeleteMessage(deleterId, messageId); - - _mockMessagesRepo.Setup(r => r.FindByIdAsync(messageId)). - ThrowsAsync(new NotFoundByKeyException(messageId)); - - // Act - var result = await _messageService.DeleteMessageAsync(deleteParams); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.IsSuccess, Is.False); - Assert.That(result.Exception, Is.Not.Null); - Assert.That(result.Exception,Is.TypeOf()); - Assert.That(result.OriginalMessage, Is.Null); - } - - [Test] - public async Task DeleteMessageAsync_NotSender_ReturnsFailure() - { - // Arrange - var deleterId = Guid.NewGuid(); - var senderId = Guid.NewGuid(); // Different - var messageId = Guid.NewGuid(); - var originalMessage = new Message { Id = messageId, SenderId = senderId }; - var deleteParams = new DeleteMessage(deleterId, messageId); - - _mockMessagesRepo.Setup(r => r.FindByIdAsync(messageId)).ReturnsAsync(originalMessage); - - // Act - var result = await _messageService.DeleteMessageAsync(deleteParams); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.IsSuccess, Is.False); - Assert.That(result.Exception, Is.Not.Null); - Assert.That(result.Exception,Is.TypeOf()); - Assert.That(result.OriginalMessage, Is.Null); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/Messages/MessagesLoaderTests.cs b/Govor.Application.Tests/Services/Messages/MessagesLoaderTests.cs deleted file mode 100644 index 03b4f94..0000000 --- a/Govor.Application.Tests/Services/Messages/MessagesLoaderTests.cs +++ /dev/null @@ -1,184 +0,0 @@ -using Govor.Application.Interfaces; -using Govor.Application.Messages; -using Govor.Application.Services.Messages; -using Govor.Domain.Models; -using Govor.Domain.Models.Messages; -using Govor.Domain.Repositories.Groups; -using Govor.Domain.Repositories.PrivateChats; -using Govor.Data; -using Microsoft.EntityFrameworkCore; -using Moq; - -namespace Govor.Application.Tests.Services.Messages; - -[TestFixture] -public class MessagesLoaderTests -{ - private IMessagesLoader _loader; - private Mock _privateChatsRepoMock; - private Mock _groupsRepoMock; - private GovorDbContext _dbContext; - - private Guid _currentUserId = Guid.NewGuid(); - private Guid _otherUserId = Guid.NewGuid(); - private Guid _groupChatId = Guid.NewGuid(); - - [SetUp] - public void Setup() - { - _privateChatsRepoMock = new Mock(); - _groupsRepoMock = new Mock(); - - var options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: Guid.NewGuid().ToString()) - .Options; - _dbContext = new GovorDbContext(options); - - _loader = new MessagesLoader(_groupsRepoMock.Object, _privateChatsRepoMock.Object, _dbContext); - } - - // Tests for LoadLastMessagesInUserChat action - [Test] - public async Task LoadLastMessagesInUserChat_ReturnsMessages_WhenChatExists() - { - // Arrange - var chatId = Guid.NewGuid(); - - _privateChatsRepoMock - .Setup(r => r.Exist(chatId)) - .Returns(true); - - var messages = new List - { - new() - { - Id = Guid.NewGuid(), - RecipientId = chatId, - RecipientType = RecipientType.User, - SentAt = DateTime.UtcNow - } - }; - - await _dbContext.Messages.AddRangeAsync(messages); - await _dbContext.SaveChangesAsync(); - - // Act - var result = await _loader.LoadMessagesInUserChat( - chatId, - _currentUserId, - null); - - // Assert - Assert.That(result, Has.Count.EqualTo(1)); - } - - [Test] - public async Task LoadLastMessagesInUserChat_ReturnsEmpty_WhenNoMessages() - { - // Arrange - var chatId = Guid.NewGuid(); - - _privateChatsRepoMock - .Setup(r => r.Exist(chatId)) - .Returns(true); - - // Act - var result = await _loader.LoadMessagesInUserChat( - chatId, - _currentUserId, - null); - - // Assert - Assert.That(result, Is.Empty); - } - - [Test] - public void LoadLastMessagesInUserChat_Throws_WhenUserIdIsEmpty() - { - // Act & Assert - var ex = Assert.ThrowsAsync(async () => - await _loader.LoadMessagesInUserChat(Guid.Empty, _currentUserId, null)); - - Assert.That(ex.Message, Does.Contain("PrivateChatId id cannot be empty")); - } - - [Test] - public void LoadLastMessagesInUserChat_Throws_WhenChatNotExists() - { - // Arrange - _privateChatsRepoMock.Setup(r => r.Exist(It.IsAny(), It.IsAny())).Returns(false); - - // Act & Assert - var ex = Assert.ThrowsAsync(async () => - await _loader.LoadMessagesInUserChat(_currentUserId, _otherUserId, null)); - - Assert.That(ex.Message, Is.EqualTo("Private chat not found")); - } - - // Tests for LoadLastMessagesInChatGroup action - [Test] - public async Task LoadLastMessagesInChatGroup_ReturnsMessages_WhenUserIsMember() - { - // Arrange - _groupsRepoMock.Setup(g => g.IsUserMemberOfGroupAsync(_currentUserId, _groupChatId)) - .ReturnsAsync(true); - - var messages = new List - { - new() { Id = Guid.NewGuid(), RecipientId = _groupChatId, RecipientType = RecipientType.Group } - }; - - await _dbContext.Messages.AddRangeAsync(messages); - await _dbContext.SaveChangesAsync(); - - // Act - var result = await _loader.LoadMessagesInChatGroup(_groupChatId, _currentUserId, null); - - // Assert - Assert.That(result, Has.Count.EqualTo(1)); - } - - [Test] - public void LoadLastMessagesInChatGroup_Throws_WhenChatIdEmpty() - { - // Act & Assert - var ex = Assert.ThrowsAsync(async () => - await _loader.LoadMessagesInChatGroup(Guid.Empty, _currentUserId, null)); - - Assert.That(ex.Message, Is.EqualTo("Chat id cannot be empty")); - } - - [Test] - public void LoadLastMessagesInChatGroup_Throws_WhenUserNotInGroup() - { - // Arrange - _groupsRepoMock.Setup(g => g.IsUserMemberOfGroupAsync(_currentUserId, _groupChatId)) - .ReturnsAsync(false); - - // Act & Assert - var ex = Assert.ThrowsAsync(async () => - await _loader.LoadMessagesInChatGroup(_groupChatId, _currentUserId, null)); - - Assert.That(ex.Message, Is.EqualTo("You are not a member of this group.")); - } - - [Test] - public async Task LoadLastMessagesInChatGroup_ReturnsEmpty_WhenNoMessages() - { - // Arrange - _groupsRepoMock.Setup(g => g.IsUserMemberOfGroupAsync(_currentUserId, _groupChatId)) - .ReturnsAsync(true); - - // Act - var result = await _loader.LoadMessagesInChatGroup(_groupChatId, _currentUserId, null); - - // Assert - Assert.That(result, Is.Empty); - } - - [TearDown] - public void TearDown() - { - _dbContext.Dispose(); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/PingHandlerServiceTests.cs b/Govor.Application.Tests/Services/PingHandlerServiceTests.cs deleted file mode 100644 index cd68952..0000000 --- a/Govor.Application.Tests/Services/PingHandlerServiceTests.cs +++ /dev/null @@ -1,65 +0,0 @@ -using Govor.Application.PingHandler; -using Govor.Domain.Models.Users; -using Govor.Data; -using Microsoft.EntityFrameworkCore; -using Microsoft.Extensions.Caching.Memory; - -namespace Govor.Application.Tests.Services; - -[TestFixture] -public class PingHandlerServiceTests -{ - private GovorDbContext _dbContext = null!; - private IMemoryCache _memoryCache = null!; - private PingHandlerService _service = null!; - private Guid _userId; - - [SetUp] - public void SetUp() - { - var options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(Guid.NewGuid().ToString()) - .Options; - - _dbContext = new GovorDbContext(options); - _memoryCache = new MemoryCache(new MemoryCacheOptions()); - _service = new PingHandlerService(_dbContext, _memoryCache); - - _userId = Guid.NewGuid(); - _dbContext.Users.Add(new User - { - Id = _userId, - Username = "TestUser", - WasOnline = DateTime.UtcNow.AddHours(-1), - Description = "Test description", - PasswordHash = "hashed_password_here" - }); - _dbContext.SaveChanges(); - } - - [Test] - public async Task Ping_DoesNotUpdate_WhenPingTooRecent() - { - // Arrange - var initial = DateTime.UtcNow.AddMinutes(-1); - _memoryCache.Set($"LastPing_{_userId}", DateTime.UtcNow); - - var user = await _dbContext.Users.FirstAsync(u => u.Id == _userId); - var originalTime = user.WasOnline; - - // Act - await _service.Ping(_userId); - - var updatedUser = await _dbContext.Users.FirstAsync(u => u.Id == _userId); - - // Assert - Assert.That(updatedUser.WasOnline, Is.EqualTo(originalTime)); - } - - [TearDown] - public void TearDown() - { - _dbContext?.Dispose(); - _memoryCache?.Dispose(); - } -} diff --git a/Govor.Application.Tests/Services/ProfileServiceTests.cs b/Govor.Application.Tests/Services/ProfileServiceTests.cs deleted file mode 100644 index 39ebd90..0000000 --- a/Govor.Application.Tests/Services/ProfileServiceTests.cs +++ /dev/null @@ -1,143 +0,0 @@ -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.Users; -using Govor.Data.Repositories.Exceptions; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.Application.Tests.Services; - -[TestFixture] -public class ProfileServiceTests -{ - private Mock _mockUsersRepo = null!; - private Mock> _mockLogger = null!; - private ProfileService _service = null!; - private User _testUser = null!; - - [SetUp] - public void SetUp() - { - _mockUsersRepo = new Mock(); - _mockLogger = new Mock>(); - - _service = new ProfileService(_mockUsersRepo.Object, _mockLogger.Object); - - _testUser = new User - { - Id = Guid.NewGuid(), - Username = "testuser", - Description = "old description", - IconId = Guid.NewGuid() - }; - } - - // ---------- GetUserProfileAsync ---------- - - [Test] - public async Task GetUserProfileAsync_ReturnsCorrectData() - { - // Arrange - _mockUsersRepo.Setup(r => r.FindByIdAsync(_testUser.Id)) - .ReturnsAsync(_testUser); - - // Act - var result = await _service.GetUserProfileAsync(_testUser.Id); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Id, Is.EqualTo(_testUser.Id)); - Assert.That(result.Username, Is.EqualTo("testuser")); - Assert.That(result.Description, Is.EqualTo("old description")); - Assert.That(result.IconId, Is.EqualTo(_testUser.IconId)); - - _mockUsersRepo.Verify(r => r.FindByIdAsync(_testUser.Id), Times.Once); - } - - [Test] - public void GetUserProfileAsync_Throws_WhenUserNotFound() - { - // Arrange - _mockUsersRepo.Setup(r => r.FindByIdAsync(It.IsAny())) - .ReturnsAsync((User)null!); - - // Act + Assert - Assert.ThrowsAsync(() => - _service.GetUserProfileAsync(Guid.NewGuid())); - } - - [Test] - public void GetUserProfileAsync_ThrowsNotFoundException_WhenNotFoundByKeyException() - { - // Arrange - var userId = Guid.NewGuid(); - _mockUsersRepo.Setup(r => r.FindByIdAsync(It.IsAny())) - .ThrowsAsync(new NotFoundByKeyException(userId)); - - // Act + Assert - Assert.ThrowsAsync(() => - _service.GetUserProfileAsync(userId)); - } - // ---------- SetDescription ---------- - - [Test] - public async Task SetDescription_UpdatesUserDescription() - { - // Arrange - var newDescription = "new cool description"; - _mockUsersRepo.Setup(r => r.FindByIdAsync(_testUser.Id)) - .ReturnsAsync(_testUser); - _mockUsersRepo.Setup(r => r.UpdateAsync(It.IsAny())) - .Returns(Task.CompletedTask); - - // Act - await _service.SetDescription(newDescription, _testUser.Id); - - // Assert - Assert.That(_testUser.Description, Is.EqualTo(newDescription)); - _mockUsersRepo.Verify(r => r.UpdateAsync(It.Is(u => u.Description == newDescription)), Times.Once); - } - - [Test] - public void SetDescription_Throws_WhenUserNotFound() - { - // Arrange - _mockUsersRepo.Setup(r => r.FindByIdAsync(It.IsAny())) - .ReturnsAsync((User)null!); - - // Act + Assert - Assert.ThrowsAsync(() => - _service.SetDescription("desc", Guid.NewGuid())); - } - - // ---------- SetNewIcon ---------- - - [Test] - public async Task SetNewIcon_UpdatesUserIconId() - { - // Arrange - var newIconId = Guid.NewGuid(); - _mockUsersRepo.Setup(r => r.FindByIdAsync(_testUser.Id)) - .ReturnsAsync(_testUser); - _mockUsersRepo.Setup(r => r.UpdateAsync(It.IsAny())) - .Returns(Task.CompletedTask); - - // Act - await _service.SetNewIcon(_testUser.Id, newIconId); - - // Assert - Assert.That(_testUser.IconId, Is.EqualTo(newIconId)); - _mockUsersRepo.Verify(r => r.UpdateAsync(It.Is(u => u.IconId == newIconId)), Times.Once); - } - - [Test] - public void SetNewIcon_Throws_WhenUserNotFound() - { - // Arrange - _mockUsersRepo.Setup(r => r.FindByIdAsync(It.IsAny())) - .ReturnsAsync((User)null!); - - // Act + Assert - Assert.ThrowsAsync(() => - _service.SetNewIcon(Guid.NewGuid(), Guid.NewGuid())); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/PushNotifications/PushNotificationServiceTests.cs b/Govor.Application.Tests/Services/PushNotifications/PushNotificationServiceTests.cs deleted file mode 100644 index fd1707f..0000000 --- a/Govor.Application.Tests/Services/PushNotifications/PushNotificationServiceTests.cs +++ /dev/null @@ -1,184 +0,0 @@ -using Govor.Application.Interfaces.PushNotifications; -using Govor.Application.Interfaces.PushNotifications.Models; -using Govor.Application.PushNotifications; -using Govor.Application.Services.PushNotifications; -using Govor.Domain.Repositories.PushTokens; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.Application.Tests.Services.PushNotifications; - -[TestFixture] -public class PushNotificationServiceTests -{ - private Mock _providerMock; - private Mock _tokenRepoMock; - private Mock> _loggerMock; - - private PushNotificationService _service; - - [SetUp] - public void Setup() - { - _providerMock = new Mock(MockBehavior.Strict); - _tokenRepoMock = new Mock(MockBehavior.Strict); - _loggerMock = new Mock>(); - - _service = new PushNotificationService( - _providerMock.Object, - _tokenRepoMock.Object, - _loggerMock.Object); - } - - #region SendToUserAsync - - [Test] - public async Task SendToUserAsync_NoTokens_DoesNotCallProvider() - { - // Arrange - var userId = Guid.NewGuid(); - - _tokenRepoMock - .Setup(r => r.GetActiveTokensAsync(userId)) - .ReturnsAsync(new List()); - - // Act - await _service.SendToUserAsync(userId, "title", "body", "chat"); - - // Assert - _providerMock.Verify( - p => p.SendMulticastAsync(It.IsAny>(), It.IsAny()), - Times.Never); - } - - [Test] - public async Task SendToUserAsync_SuccessfulSend_CallsProvider() - { - // Arrange - var userId = Guid.NewGuid(); - var tokens = new List { "t1", "t2" }; - - _tokenRepoMock - .Setup(r => r.GetActiveTokensAsync(userId)) - .ReturnsAsync(tokens); - - _providerMock - .Setup(p => p.SendMulticastAsync(tokens, It.IsAny())) - .ReturnsAsync(new SendPushResult(0, 0, [])); - - // Act - await _service.SendToUserAsync(userId, "title", "body", "chat"); - - // Assert - _providerMock.Verify( - p => p.SendMulticastAsync(tokens, It.IsAny()), - Times.Once); - - _tokenRepoMock.Verify( - r => r.RemoveTokensAsync(It.IsAny>()), - Times.Never); - } - - [Test] - public async Task SendToUserAsync_WithFailures_RemovesInvalidTokens() - { - // Arrange - var userId = Guid.NewGuid(); - var tokens = new List { "t1", "t2" }; - var failed = new List { "t2" }; - - _tokenRepoMock - .Setup(r => r.GetActiveTokensAsync(userId)) - .ReturnsAsync(tokens); - - _providerMock - .Setup(p => p.SendMulticastAsync(tokens, It.IsAny())) - .ReturnsAsync(new SendPushResult(0, 1, failed)); - - _tokenRepoMock - .Setup(r => r.RemoveTokensAsync(failed)) - .Returns(Task.CompletedTask); - - // Act - await _service.SendToUserAsync(userId, "title", "body", "chat"); - - // Assert - _tokenRepoMock.Verify(r => r.RemoveTokensAsync(failed), Times.Once); - } - - #endregion - - #region SendToUsersAsync - - [Test] - public async Task SendToUsersAsync_NoTokens_DoesNotCallProvider() - { - // Arrange - var users = new[] { Guid.NewGuid() }; - - _tokenRepoMock - .Setup(r => r.GetActiveTokensUsersAsync(users)) - .ReturnsAsync(new List()); - - // Act - await _service.SendToUsersAsync(users, "title", "body", "chat"); - - // Assert - _providerMock.Verify( - p => p.SendMulticastAsync(It.IsAny>(), It.IsAny()), - Times.Never); - } - - #endregion - - #region SendToSessionAsync - - [Test] - public async Task SendToSessionAsync_NoToken_DoesNothing() - { - // Arrange - var sessionId = Guid.NewGuid(); - - _tokenRepoMock - .Setup(r => r.GetActiveTokenBySessionAsync(sessionId)) - .ReturnsAsync(""); - - // Act - await _service.SendToSessionAsync(sessionId, "title", "body", "chat"); - - // Assert - _providerMock.Verify( - p => p.SendToTokenAsync(It.IsAny(), It.IsAny()), - Times.Never); - } - - [Test] - public async Task SendToSessionAsync_WithFailure_RemovesToken() - { - // Arrange - var sessionId = Guid.NewGuid(); - var token = "t1"; - - _tokenRepoMock - .Setup(r => r.GetActiveTokenBySessionAsync(sessionId)) - .ReturnsAsync(token); - - _providerMock - .Setup(p => p.SendToTokenAsync(token, It.IsAny())) - .ReturnsAsync(new SendPushResult(0, 1, [token])); - - _tokenRepoMock - .Setup(r => r.RemoveTokensAsync(It.IsAny>())) - .Returns(Task.CompletedTask); - - // Act - await _service.SendToSessionAsync(sessionId, "title", "body", "chat"); - - // Assert - _tokenRepoMock.Verify( - r => r.RemoveTokensAsync(It.Is>(x => x.Contains(token))), - Times.Once); - } - - #endregion -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/UserGroupsGetterServiceTests.cs b/Govor.Application.Tests/Services/UserGroupsGetterServiceTests.cs deleted file mode 100644 index 3b4702b..0000000 --- a/Govor.Application.Tests/Services/UserGroupsGetterServiceTests.cs +++ /dev/null @@ -1,70 +0,0 @@ -using AutoFixture; -using Govor.Application.Groups; -using Govor.Application.Interfaces; -using Govor.Domain.Models; -using Govor.Domain.Repositories.Groups; -using Govor.Data.Repositories.Exceptions; -using Moq; - -namespace Govor.Application.Tests.Services; - -[TestFixture] -public class UserGroupsGetterServiceTests -{ - private Fixture _fixture; - private Mock _repositoryMock; - private IUserGroupsGetterService _getterService; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _repositoryMock = new Mock(); - - _getterService = new UserGroupsGetterService(_repositoryMock.Object); - } - - [Test] - public async Task GetUserGroups_ShouldReturnAllUserGroups() - { - // Arrange - var chats = _fixture.CreateMany(); - var userId = chats.First().Members.First().Id; - - _repositoryMock.Setup(r => r.GetByUserIdAsync(userId)) - .ReturnsAsync([chats.First()]); - - // Act - var result = await _getterService.GetUserGroupsAsync(userId); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count(), Is.EqualTo(1)); - Assert.That(result, Is.EquivalentTo([chats.First()])); - } - - [Test] - public async Task GetUserGroups_ButGroupDoesNotExist_ShouldReturnEmptyList() - { - // Arrange - var userId = _fixture.Create(); - - _repositoryMock.Setup(r => r.GetByUserIdAsync(userId)) - .ThrowsAsync(new NotFoundByKeyException(userId)); - - // Act - var result = await _getterService.GetUserGroupsAsync(userId); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count(), Is.EqualTo(0)); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/UserOnlineStatus/OnlineUserStoreTests.cs b/Govor.Application.Tests/Services/UserOnlineStatus/OnlineUserStoreTests.cs deleted file mode 100644 index e01f7e7..0000000 --- a/Govor.Application.Tests/Services/UserOnlineStatus/OnlineUserStoreTests.cs +++ /dev/null @@ -1,83 +0,0 @@ -using Govor.Application.Interfaces.UserOnlineStatus; -using Govor.Application.Services.UserOnlineStatus; - -namespace Govor.Application.Tests.Services.UserOnlineStatus; - -[TestFixture] -public class OnlineUserStoreTests -{ - /* - private IOnlineUserStore _store; - private Guid _userId1; - private Guid _userId2; - - [SetUp] - public void Setup() - { - _store = new OnlineUserStore(); - _userId1 = Guid.NewGuid(); - _userId2 = Guid.NewGuid(); - } - - [Test] - public void SetOnlineUser_UserIsMarkedOnline() - { - // Act - _store.SetOnlineUser(_userId1); - - // Assert - Assert.That(_store.IsOnline(_userId1), Is.True); - } - - [Test] - public void SetOfflineUser_UserIsNoLongerOnline() - { - // Act - _store.SetOnlineUser(_userId1); - _store.SetOfflineUser(_userId1); - - // Assert - Assert.That(_store.IsOnline(_userId1), Is.False); - } - - [Test] - public void IsOnline_ReturnsFalse_ForUnknownUser() - { - // Act & Assert - Assert.That(_store.IsOnline(Guid.NewGuid()), Is.False); - } - - [Test] - public void GetAllOnlineUsers_ReturnsAllCurrentlyOnlineUsers() - { - // Arrange - _store.SetOnlineUser(_userId1); - _store.SetOnlineUser(_userId2); - - // Act - var onlineUsers = _store.GetAllOnlineUsers(); - - // Assert - Assert.That(onlineUsers, Is.EquivalentTo(new[] { _userId1, _userId2 })); - } - - [Test] - public void SetOnlineUser_Twice_DoesNotThrow() - { - // Act & Assert - Assert.DoesNotThrow(() => - { - _store.SetOnlineUser(_userId1); - _store.SetOnlineUser(_userId1); - }); - - Assert.That(_store.IsOnline(_userId1), Is.True); - } - - [Test] - public void SetOfflineUser_ForUnknownUser_DoesNotThrow() - { - // Act & Assert - Assert.DoesNotThrow(() => _store.SetOfflineUser(Guid.NewGuid())); - }*/ -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/UserPrivateChatsCreatorTests.cs b/Govor.Application.Tests/Services/UserPrivateChatsCreatorTests.cs deleted file mode 100644 index ad06d25..0000000 --- a/Govor.Application.Tests/Services/UserPrivateChatsCreatorTests.cs +++ /dev/null @@ -1,108 +0,0 @@ -using AutoFixture; -using Govor.Application.Interfaces; -using Govor.Application.PrivateUserChats; -using Govor.Domain.Models; -using Govor.Domain.Repositories.PrivateChats; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.Application.Tests.Services; - -[TestFixture] -public class UserPrivateChatsCreatorTests -{ - private Fixture _fixture; - private Mock> _mockLogger; - private Mock _mockPrivateChats; - private Mock _mockPrivateChatGroupManager; - private IUserPrivateChatsCreator _service; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _mockLogger = new Mock>(); - _mockPrivateChats = new Mock(); - _mockPrivateChatGroupManager = new Mock(); - - _service = new UserPrivateChatsCreator( - _mockPrivateChats.Object, - _mockPrivateChatGroupManager.Object, - _mockLogger.Object); - } - - [Test] - public async Task CreateAsync_ShouldCreateNewChat_WhenChatDoesNotExist() - { - // Arrange - var userA = Guid.NewGuid(); - var userB = Guid.NewGuid(); - - _mockPrivateChats - .Setup(x => x.Exist(userA, userB)) - .Returns(false); - - PrivateChat? addedChat = null; - - _mockPrivateChats - .Setup(x => x.AddAsync(It.IsAny())) - .Callback(chat => addedChat = chat) - .Returns(Task.CompletedTask); - - // Act - var result = await _service.CreateAsync(userA, userB); - - // Assert - _mockPrivateChats.Verify(x => x.AddAsync(It.IsAny()), Times.Once); - _mockPrivateChatGroupManager.Verify(x => x.AddUsersToPrivateChatGroupAsync(It.IsAny()), Times.Once); - - Assert.That(result, Is.Not.Null); - Assert.That(result.UserAId, Is.EqualTo(userA)); - Assert.That(result.UserBId, Is.EqualTo(userB)); - Assert.That(result.Id, Is.Not.EqualTo(Guid.Empty)); - - Assert.That(addedChat, Is.Not.Null); - Assert.That(addedChat!.Id, Is.EqualTo(result.Id)); - } - - [Test] - public async Task CreateAsync_ShouldReturnExistingChat_WhenChatAlreadyExists() - { - // Arrange - var userA = Guid.NewGuid(); - var userB = Guid.NewGuid(); - - var existingChat = _fixture.Build() - .With(x => x.UserAId, userA) - .With(x => x.UserBId, userB) - .Create(); - - _mockPrivateChats - .Setup(x => x.Exist(userA, userB)) - .Returns(true); - - _mockPrivateChats - .Setup(x => x.GetByMembersAsync(userA, userB)) - .ReturnsAsync(existingChat); - - // Act - var result = await _service.CreateAsync(userA, userB); - - // Assert - _mockPrivateChats.Verify(x => x.AddAsync(It.IsAny()), Times.Never); - - _mockPrivateChatGroupManager.Verify( - x => x.AddUsersToPrivateChatGroupAsync(It.IsAny()), - Times.Never); - - _mockPrivateChats.Verify(x => x.GetByMembersAsync(userA, userB), Times.Once); - - Assert.That(result, Is.EqualTo(existingChat)); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/UserSessions/UserSessionOpenerTests.cs b/Govor.Application.Tests/Services/UserSessions/UserSessionOpenerTests.cs deleted file mode 100644 index 396e1a9..0000000 --- a/Govor.Application.Tests/Services/UserSessions/UserSessionOpenerTests.cs +++ /dev/null @@ -1,155 +0,0 @@ -using Govor.Application.Services.UserSessions; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.UserSessionsRepository; -using Microsoft.Extensions.Logging; -using Microsoft.Extensions.Options; -using Moq; -using Govor.Application.Interfaces.Authentication; -using Govor.Application.Services.Authentication; -using Govor.Data.Repositories.Exceptions; - -namespace Govor.Application.Tests.Services.UserSessions; - -[TestFixture] -public class UserSessionOpenerTests -{ - private Mock _repositoryMock; - private Mock _jwtServiceMock; - private Mock _jwtTokenHasherMock; - private UserSessionOpener _service; - private User _user; - - private const string DeviceInfo = "Chrome on Windows"; - private const string RefreshToken = "new-refresh-token"; - private const string AccessToken = "new-access-token"; - private const string TokenHash = "hashed-refresh-token"; - - [SetUp] - public void Setup() - { - _repositoryMock = new Mock(); - _jwtServiceMock = new Mock(); - var loggerMock = new Mock>(); - _jwtTokenHasherMock = new Mock(); - var options = Options.Create(new JwtRefreshOption { RefreshTokenLifetimeDays = 30 }); - - _user = new User - { - Id = Guid.NewGuid(), - Username = "test", - Description = "some description", - PasswordHash = "hashed-password", - IconId = Guid.NewGuid(), - CreatedOn = DateOnly.FromDateTime(DateTime.Now), - WasOnline = DateTime.Now, - InviteId = Guid.NewGuid(), - // ... - }; - - _jwtServiceMock.Setup(j => j.GenerateRefreshTokenAsync(_user)).ReturnsAsync(RefreshToken); - _jwtTokenHasherMock.Setup(h => h.HashToken(RefreshToken)).Returns(TokenHash); - - _jwtServiceMock.Setup(j => j.GenerateAccessTokenAsync(_user, It.IsAny())).ReturnsAsync(AccessToken); - - - _service = new UserSessionOpener( - _repositoryMock.Object, - _jwtServiceMock.Object, - _jwtTokenHasherMock.Object, - options, - loggerMock.Object - ); - } - - // UpdateExistingSessionAsync - [Test] - public async Task OpenSessionAsync_ShouldUpdateExistingSession_WhenFoundByDeviceInfo() - { - // Arrange - var existingSessionId = Guid.NewGuid(); - var existingSession = new UserSession - { - Id = existingSessionId, - UserId = _user.Id, - DeviceInfo = DeviceInfo, - RefreshTokenHash = "old-hash", - CreatedAt = DateTime.UtcNow.AddDays(-10), - ExpiresAt = DateTime.UtcNow.AddDays(10), - IsRevoked = true - }; - - _repositoryMock.Setup(r => r.GetByUserIdAsync(_user.Id)).ReturnsAsync(new List { existingSession }); - - // Act - var result = await _service.OpenSessionAsync(_user, DeviceInfo); - - // Assert - Assert.Multiple(() => - { - Assert.That(result.refreshToken, Is.EqualTo(RefreshToken), "Должен быть возвращен новый RefreshToken."); - Assert.That(result.accessToken, Is.EqualTo(AccessToken), "Должен быть возвращен новый AccessToken."); - }); - - _repositoryMock.Verify(r => r.UpdateAsync(It.Is(s => - s.Id == existingSessionId && - s.RefreshTokenHash == TokenHash && - s.IsRevoked == false && - s.ExpiresAt > DateTime.UtcNow - )), Times.Once, "Должен быть вызван метод UpdateAsync с новыми данными."); - - _repositoryMock.Verify(r => r.AddAsync(It.IsAny()), Times.Never); - } - - // CreateNewSessionAsync - - [Test] - public async Task OpenSessionAsync_ShouldCreateNewSession_IfNoneFound() - { - // Arrange - _repositoryMock.Setup(r => r.GetByUserIdAsync(_user.Id)).ReturnsAsync(new List()); - - // Act - var result = await _service.OpenSessionAsync(_user, DeviceInfo); - - // Assert - Assert.Multiple(() => - { - Assert.That(result.refreshToken, Is.EqualTo(RefreshToken), "Должен быть возвращен новый RefreshToken."); - Assert.That(result.accessToken, Is.EqualTo(AccessToken), "Должен быть возвращен новый AccessToken."); - }); - - _repositoryMock.Verify(r => r.AddAsync(It.Is(s => - s.UserId == _user.Id && - s.DeviceInfo == DeviceInfo && - s.RefreshTokenHash == TokenHash && - s.IsRevoked == false - )), Times.Once, "Должен быть вызван метод AddAsync для создания новой сессии."); - - _repositoryMock.Verify(r => r.UpdateAsync(It.IsAny()), Times.Never); - } - - [Test] - public async Task OpenSessionAsync_ShouldCreateNewSession_WhenRepositoryThrowsNotFoundByKeyException() - { - // Arrange - _repositoryMock - .Setup(r => r.GetByUserIdAsync(_user.Id)) - .ThrowsAsync(new NotFoundByKeyException(_user.Id, "userId")); - - // Act - var result = await _service.OpenSessionAsync(_user, DeviceInfo); - - // Assert - Assert.Multiple(() => - { - Assert.That(result.refreshToken, Is.EqualTo(RefreshToken), "Должен быть возвращен новый RefreshToken."); - Assert.That(result.accessToken, Is.EqualTo(AccessToken), "Должен быть возвращен новый AccessToken."); - }); - - _repositoryMock.Verify(r => r.AddAsync(It.Is(s => - s.RefreshTokenHash == TokenHash - )), Times.Once, "Должен быть вызван AddAsync после перехвата исключения."); - - _repositoryMock.Verify(r => r.UpdateAsync(It.IsAny()), Times.Never); - } -} diff --git a/Govor.Application.Tests/Services/UserSessions/UserSessionReaderTests.cs b/Govor.Application.Tests/Services/UserSessions/UserSessionReaderTests.cs deleted file mode 100644 index 159278d..0000000 --- a/Govor.Application.Tests/Services/UserSessions/UserSessionReaderTests.cs +++ /dev/null @@ -1,75 +0,0 @@ -using AutoFixture; -using Govor.Application.Interfaces.UserSession; -using Govor.Application.Services.UserSessions; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.UserSessionsRepository; -using Govor.Data.Repositories.Exceptions; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.Application.Tests.Services.UserSessions; - -[TestFixture] -[TestOf(typeof(UserSessionReader))] -public class UserSessionReaderTests -{ - private Mock _mockUserSessionsRepository; - private Mock> _mockLogger; - private Fixture _fixture; - private IUserSessionReader _userSessionReader; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors.OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _mockUserSessionsRepository = new Mock(); - _mockLogger = new Mock>(); - - _userSessionReader = new UserSessionReader(_mockUserSessionsRepository.Object, - _mockLogger.Object); - } - - [Test] - public async Task GetAllUserSessionsAsync_ShouldReturnAllUserSessions() - { - // Arrange - var sessios = _fixture.Build() - .With(f => f.IsRevoked, false) - .CreateMany().ToList(); - - var userId = Guid.NewGuid(); - - _mockUserSessionsRepository.Setup(f => f.GetByUserIdAsync(userId)) - .ReturnsAsync(sessios); - // Act - var result = await _userSessionReader.GetAllSessionsAsync(userId); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.EquivalentTo(sessios)); - } - - [Test] - public async Task GetAllUserSessionsAsync_ThrowsNotFoundByKeyException_ReturnsEmptyList() - { - // Arrange - var userId = Guid.NewGuid(); - - _mockUserSessionsRepository.Setup(f => f.GetByUserIdAsync(userId)) - .ThrowsAsync(new NotFoundByKeyException(userId)); - - // Act - var result = await _userSessionReader.GetAllSessionsAsync(userId); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.Empty); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/UserSessions/UserSessionRefresherTests.cs b/Govor.Application.Tests/Services/UserSessions/UserSessionRefresherTests.cs deleted file mode 100644 index 1dfb754..0000000 --- a/Govor.Application.Tests/Services/UserSessions/UserSessionRefresherTests.cs +++ /dev/null @@ -1,148 +0,0 @@ -using Govor.Application.Interfaces.Authentication; -using Govor.Application.Services.Authentication; -using Govor.Application.Services.UserSessions; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.Users; -using Govor.Domain.Repositories.UserSessionsRepository; -using Govor.Data.Repositories.Exceptions; -using Microsoft.Extensions.Logging; -using Microsoft.Extensions.Options; -using Moq; - -namespace Govor.Application.Tests.Services.UserSessions; - -[TestFixture] -public class UserSessionRefresherTests -{ - private Mock _sessionsRepoMock; - private Mock _usersRepoMock; - private Mock _jwtServiceMock; - private Mock> _loggerMock; - private Mock> _optionsMock; - private Mock _jwtTokenHasherMock; - private JwtRefreshOption _options; - private UserSessionRefresher _refresher; - private const string OldRefreshToken = "old-refresh-token"; - private const string NewRefreshToken = "new-refresh-token"; - private const string NewAccessToken = "new-access-token"; - private User _user; - private UserSession _session; - - [SetUp] - public void Setup() - { - _sessionsRepoMock = new Mock(); - _usersRepoMock = new Mock(); - _jwtServiceMock = new Mock(); - _loggerMock = new Mock>(); - _optionsMock = new Mock>(); - _jwtTokenHasherMock = new Mock(); - - _options = new JwtRefreshOption { RefreshTokenLifetimeDays = 30 }; - - _optionsMock.SetupGet(o => o.Value).Returns(_options); - - _refresher = new UserSessionRefresher( - _sessionsRepoMock.Object, - _loggerMock.Object, - _usersRepoMock.Object, - _optionsMock.Object, - _jwtTokenHasherMock.Object, - _jwtServiceMock.Object); - - _user = new User - { - Id = Guid.NewGuid(), - Username = "TestUser", - PasswordHash = "hash", - InviteId = Guid.NewGuid() - }; - - _session = new UserSession - { - RefreshTokenHash = OldRefreshToken, - UserId = _user.Id, - DeviceInfo = "Chrome", - CreatedAt = DateTime.UtcNow.AddDays(-5), - ExpiresAt = DateTime.UtcNow.AddDays(5), - IsRevoked = false - }; - } - - [Test] - public async Task RefreshTokenAsync_ValidToken_ReturnsNewTokensAndCreatesNewSession() - { - // Arrange - _sessionsRepoMock.Setup(r => r.GetByHashedRefreshTokenAsync(OldRefreshToken)).ReturnsAsync(_session); - _jwtTokenHasherMock.Setup(h => h.HashToken(It.IsAny())).Returns(OldRefreshToken); - _usersRepoMock.Setup(r => r.FindByIdAsync(_user.Id)).ReturnsAsync(_user); - _jwtServiceMock.Setup(j => j.GenerateAccessTokenAsync(_user, _session.Id)).ReturnsAsync(NewAccessToken); - _jwtServiceMock.Setup(j => j.GenerateRefreshTokenAsync(_user)).ReturnsAsync(NewRefreshToken); - - // Act - var result = await _refresher.RefreshTokenAsync(OldRefreshToken); - - // Assert - Assert.Multiple(() => - { - Assert.That(result.accessToken, Is.EqualTo(NewAccessToken)); - Assert.That(result.refreshToken, Is.EqualTo(NewRefreshToken)); - }); - - _sessionsRepoMock.Verify( - r => r.UpdateAsync( - It.Is(s => - s.Id == _session.Id && - s.UserId == _user.Id && - s.IsRevoked == false - )), - Times.Once); - _sessionsRepoMock.Verify(r => r.AddAsync(It.IsAny()), Times.Never); - } - - [Test] - public void RefreshTokenAsync_RevokedToken_ThrowsUnauthorizedAccessException() - { - // Arrange - _session.IsRevoked = true; - _sessionsRepoMock.Setup(r => r.GetByHashedRefreshTokenAsync(OldRefreshToken)).ReturnsAsync(_session); - _jwtTokenHasherMock.Setup(h => h.HashToken(It.IsAny())).Returns(OldRefreshToken); - - // Act & Assert - var ex = Assert.ThrowsAsync(async () => - await _refresher.RefreshTokenAsync(OldRefreshToken)); - - Assert.That(ex.Message, Contains.Substring("Refresh token is invalid or expired")); - } - - [Test] - public void RefreshTokenAsync_ExpiredToken_ThrowsUnauthorizedAccessException() - { - // Arrange - _session.ExpiresAt = DateTime.UtcNow.AddMinutes(-1); - _sessionsRepoMock.Setup(r => r.GetByHashedRefreshTokenAsync(OldRefreshToken)).ReturnsAsync(_session); - _jwtTokenHasherMock.Setup(h => h.HashToken(It.IsAny())).Returns(OldRefreshToken); - - // Act & Assert - var ex = Assert.ThrowsAsync(async () => - await _refresher.RefreshTokenAsync(OldRefreshToken)); - - Assert.That(ex.Message, Contains.Substring("Refresh token is invalid or expired")); - } - - [Test] - public void RefreshTokenAsync_TokenNotFound_ThrowsUnauthorizedAccessException() - { - // Arrange - _sessionsRepoMock.Setup(r => r.GetByHashedRefreshTokenAsync(OldRefreshToken)) - .ThrowsAsync(new NotFoundByKeyException("token", OldRefreshToken)); - _jwtTokenHasherMock.Setup(h => h.HashToken(It.IsAny())).Returns(OldRefreshToken); - // Act & Assert - var ex = Assert.ThrowsAsync(async () => - await _refresher.RefreshTokenAsync(OldRefreshToken)); - - Assert.That(ex.Message, Contains.Substring("Invalid refresh token")); - } -} - diff --git a/Govor.Application.Tests/Services/UserSessions/UserSessionRevokerTests.cs b/Govor.Application.Tests/Services/UserSessions/UserSessionRevokerTests.cs deleted file mode 100644 index 240f48d..0000000 --- a/Govor.Application.Tests/Services/UserSessions/UserSessionRevokerTests.cs +++ /dev/null @@ -1,168 +0,0 @@ -using Govor.Application.Services.UserSessions; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories.PushTokens; -using Govor.Domain.Repositories.UserSessionsRepository; -using Govor.Data.Repositories.Exceptions; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.Application.Tests.Services.UserSessions; - -[TestFixture] -[TestOf(typeof(UserSessionRevoker))] -public class UserSessionRevokerTests -{ - private Mock _sessionsRepositoryMock; - private Mock> _loggerMock; - private Mock _pushTokenRepositoryMock; - private UserSessionRevoker _revoker; - - [SetUp] - public void SetUp() - { - _sessionsRepositoryMock = new Mock(); - _loggerMock = new Mock>(); - _pushTokenRepositoryMock = new Mock(); - _revoker = new UserSessionRevoker(_sessionsRepositoryMock.Object, _pushTokenRepositoryMock.Object, _loggerMock.Object); - } - - [Test] - public async Task CloseSessionByIdAsync_ValidSessionAndUserId_SetsIsRevokedAndUpdates() - { - // Arrange - var sessionId = Guid.NewGuid(); - var userId = Guid.NewGuid(); - var session = new UserSession { Id = sessionId, UserId = userId, IsRevoked = false }; - _sessionsRepositoryMock.Setup(r => r.GetByIdAsync(sessionId)).ReturnsAsync(session); - - // Act - await _revoker.CloseSessionByIdAsync(sessionId, userId); - - // Assert - Assert.That(session.IsRevoked, Is.True); - _sessionsRepositoryMock.Verify(r => r.UpdateAsync(session), Times.Once()); - _pushTokenRepositoryMock.Verify(r => r.DeactivateTokenBySessionAsync(sessionId), Times.Once()); - _loggerMock.VerifyNoOtherCalls(); - } - - [Test] - public void CloseSessionByIdAsync_UnauthorizedUser_ThrowsUnauthorizedAccessException() - { - // Arrange - var sessionId = Guid.NewGuid(); - var userId = Guid.NewGuid(); - var differentUserId = Guid.NewGuid(); - var session = new UserSession { Id = sessionId, UserId = userId, IsRevoked = false }; - _sessionsRepositoryMock.Setup(r => r.GetByIdAsync(sessionId)).ReturnsAsync(session); - - // Act & Assert - var ex = Assert.ThrowsAsync(() => - _revoker.CloseSessionByIdAsync(sessionId, differentUserId)); - Assert.That(ex.Message, Contains.Substring($"User {differentUserId} does not belong to this session {sessionId}")); - - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - It.IsAny(), - It.IsAny>()), Times.Once()); - - _sessionsRepositoryMock.Verify(r => r.UpdateAsync(It.IsAny()), Times.Never()); - _pushTokenRepositoryMock.Verify(r => r.DeactivateTokenBySessionAsync(sessionId), Times.Never()); - } - - [Test] - public async Task CloseSessionByIdAsync_AlreadyRevokedSession_DoesNotUpdate() - { - // Arrange - var sessionId = Guid.NewGuid(); - var userId = Guid.NewGuid(); - var session = new UserSession { Id = sessionId, UserId = userId, IsRevoked = true }; - _sessionsRepositoryMock.Setup(r => r.GetByIdAsync(sessionId)).ReturnsAsync(session); - - // Act - await _revoker.CloseSessionByIdAsync(sessionId, userId); - - // Assert - _sessionsRepositoryMock.Verify(r => r.UpdateAsync(It.IsAny()), Times.Never()); - _pushTokenRepositoryMock.Verify(r => r.DeactivateTokenBySessionAsync(sessionId), Times.Never()); - _loggerMock.VerifyNoOtherCalls(); - } - - [Test] - public void CloseSessionByIdAsync_NonExistentSession_ThrowsNotFoundException() - { - // Arrange - var sessionId = Guid.NewGuid(); - var userId = Guid.NewGuid(); - _sessionsRepositoryMock.Setup(r => r.GetByIdAsync(sessionId)) - .ThrowsAsync(new NotFoundByKeyException(sessionId)); - - // Act & Assert - var ex = Assert.ThrowsAsync(() => - _revoker.CloseSessionByIdAsync(sessionId, userId)); - Assert.That(ex.Message, Is.EqualTo("Session not found")); - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - It.IsAny(), - It.IsAny>()), Times.Once()); - _sessionsRepositoryMock.Verify(r => r.UpdateAsync(It.IsAny()), Times.Never()); - _pushTokenRepositoryMock.Verify(r => r.DeactivateTokenBySessionAsync(sessionId), Times.Never()); - } - - [Test] - public async Task CloseAllSessionsAsync_MultipleSessions_RevokesNonRevokedSessions() - { - // Arrange - var userId = Guid.NewGuid(); - var sessions = new List - { - new UserSession { Id = Guid.NewGuid(), UserId = userId, IsRevoked = false }, - new UserSession { Id = Guid.NewGuid(), UserId = userId, IsRevoked = true }, - new UserSession { Id = Guid.NewGuid(), UserId = userId, IsRevoked = false } - }; - _sessionsRepositoryMock.Setup(r => r.GetByUserIdAsync(userId)).ReturnsAsync(sessions); - - // Act - await _revoker.CloseAllSessionsAsync(userId); - - // Assert - Assert.That(sessions[0].IsRevoked, Is.True); - Assert.That(sessions[1].IsRevoked, Is.True); - Assert.That(sessions[2].IsRevoked, Is.True); - _sessionsRepositoryMock.Verify(r => r.UpdateAsync(sessions[0]), Times.Once()); - _sessionsRepositoryMock.Verify(r => r.UpdateAsync(sessions[2]), Times.Once()); - _pushTokenRepositoryMock.Verify(r => r.DeactivateTokenBySessionAsync(sessions[0].Id), Times.Once()); - _pushTokenRepositoryMock.Verify(r => r.DeactivateTokenBySessionAsync(sessions[2].Id), Times.Once()); - - _sessionsRepositoryMock.Verify(r => r.UpdateAsync(sessions[1]), Times.Never()); - _pushTokenRepositoryMock.Verify(r => r.DeactivateTokenBySessionAsync(sessions[1].Id), Times.Never); - _loggerMock.VerifyNoOtherCalls(); - } - - [Test] - public void CloseAllSessionsAsync_NoSessions_ThrowsNotFoundException() - { - // Arrange - var userId = Guid.NewGuid(); - _sessionsRepositoryMock.Setup(r => r.GetByUserIdAsync(userId)) - .ThrowsAsync(new NotFoundByKeyException(userId)); - - // Act & Assert - var ex = Assert.ThrowsAsync(() => - _revoker.CloseAllSessionsAsync(userId)); - Assert.That(ex.Message, Is.EqualTo("Session not found")); - _loggerMock.Verify(l => l.Log( - LogLevel.Warning, - It.IsAny(), - It.IsAny(), - It.IsAny(), - It.IsAny>()), Times.Once()); - - _pushTokenRepositoryMock.Verify(r => r.DeactivateTokenBySessionAsync(It.IsAny()), Times.Never); - _sessionsRepositoryMock.Verify(r => r.UpdateAsync(It.IsAny()), Times.Never()); - } -} \ No newline at end of file diff --git a/Govor.Application.Tests/Services/VerifyFriendshipTests.cs b/Govor.Application.Tests/Services/VerifyFriendshipTests.cs deleted file mode 100644 index cd3628e..0000000 --- a/Govor.Application.Tests/Services/VerifyFriendshipTests.cs +++ /dev/null @@ -1,95 +0,0 @@ -using AutoFixture; -using Govor.Application.Exceptions.VerifyFriendship; -using Govor.Domain.Models; -using Govor.Domain.Repositories.Friendships; -using Govor.Data.Repositories.Exceptions; -using Microsoft.Extensions.Logging; -using Moq; - -namespace Govor.Application.Tests.Services; - -[TestFixture] -public class VerifyFriendshipTests -{ - private Fixture _fixture; - private Mock> _mockLogger; - private Mock _mockFriendships; - private VerifyFriendship _service; - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _mockLogger = new Mock>(); - _mockFriendships = new Mock(); - - _service = new VerifyFriendship(_mockFriendships.Object, _mockLogger.Object); - } - - // Test for VerifyAsync action - [Test] - public async Task VerifyAsync_Success() - { - // Arrange - var friendship1 = _fixture.Create(); - friendship1.Status = FriendshipStatus.Accepted; - _mockFriendships.Setup(f => f.FindByUserIdAsync(friendship1.RequesterId)) - .ReturnsAsync([friendship1]); - // Act - await _service.VerifyAsync(friendship1.RequesterId, friendship1.AddresseeId); - // Assert - _mockFriendships.Verify(f => f.FindByUserIdAsync(friendship1.RequesterId), Times.Once()); - Assert.That(await _service.TryVerifyAsync(friendship1.RequesterId, friendship1.AddresseeId), Is.EqualTo(true)); - } - - [Test] - public async Task VerifyAsync_IDsEmpty() - { - // Arrange - var friendship1 = _fixture.Create(); - friendship1.RequesterId = Guid.Empty; - friendship1.AddresseeId = Guid.Empty; - - // Act & Assert - Assert.ThrowsAsync(() => _service.VerifyAsync(friendship1.RequesterId, friendship1.AddresseeId)); - Assert.That(await _service.TryVerifyAsync(friendship1.RequesterId, friendship1.AddresseeId), Is.EqualTo(false)); - } - - [Test] - public async Task VerifyAsync_ThrowsNotFoundByKeyException_ThrowsFriendshipException() - { - // Arrange - var friendship1 = _fixture.Create(); - friendship1.Status = FriendshipStatus.Accepted; - - _mockFriendships.Setup(f => f.FindByUserIdAsync(friendship1.RequesterId)) - .ThrowsAsync(new NotFoundByKeyException(friendship1.RequesterId)); - - // Act & Assert - Assert.ThrowsAsync(async () => await _service.VerifyAsync(friendship1.RequesterId, friendship1.AddresseeId)); - _mockFriendships.Verify(f => f.FindByUserIdAsync(friendship1.RequesterId), Times.Once()); - Assert.That(await _service.TryVerifyAsync(friendship1.RequesterId, friendship1.AddresseeId), Is.EqualTo(false)); - } - - [Test] - public async Task VerifyAsync_ReturnsEmptyFriendships_ThrowsFriendshipException() - { - // Arrange - var friendship1 = _fixture.Create(); - friendship1.Status = FriendshipStatus.Accepted; - - _mockFriendships.Setup(f => f.FindByUserIdAsync(friendship1.RequesterId)) - .ReturnsAsync(new List()); - - // Act & Assert - Assert.ThrowsAsync(async () => await _service.VerifyAsync(friendship1.RequesterId, friendship1.AddresseeId)); - _mockFriendships.Verify(f => f.FindByUserIdAsync(friendship1.RequesterId), Times.Once()); - Assert.That(await _service.TryVerifyAsync(friendship1.RequesterId, friendship1.AddresseeId), Is.EqualTo(false)); - } -} \ No newline at end of file diff --git a/Govor.Application/E2ee/E2eeProtocol.cs b/Govor.Application/E2ee/E2eeProtocol.cs index 2ca2e1d..5143ea8 100644 --- a/Govor.Application/E2ee/E2eeProtocol.cs +++ b/Govor.Application/E2ee/E2eeProtocol.cs @@ -1,6 +1,7 @@ using System.Security.Cryptography; using System.Text; using System.Text.Json; +using System.Text.Json.Nodes; using Jose; using AesGcm = System.Security.Cryptography.AesGcm; @@ -8,19 +9,39 @@ namespace Govor.Application.E2ee; // Shared verbatim with the mobile client. JOSE implements RFC 7515/7516; // the application envelope binds the ciphertext to its author and conversation. -public sealed record DeviceKey(Guid UserId, Guid SessionId, string IdentityKey, - string EncryptionKey, string Signature) +public sealed record DeviceKey( + Guid UserId, + Guid SessionId, + string IdentityKey, + string EncryptionKey, + string Signature) { public string Fingerprint => E2eeProtocol.Fingerprint(IdentityKey, EncryptionKey); } -public sealed record ConversationKeys(Guid ConversationId, int RecipientType, - Guid[] Members, DeviceKey[] Devices); +public sealed record ConversationKeys( + Guid ConversationId, + int RecipientType, + Guid[] Members, + DeviceKey[] Devices); + public sealed record AttachmentSecret(Guid MediaId, string Key, string FileName, string MimeType); + public sealed record MessagePlaintext(string Text, AttachmentSecret[] Attachments); -public sealed record EncryptedMessage(int Version, Guid MessageId, Guid ConversationId, - int RecipientType, DeviceKey Sender, Guid? ReplyToMessageId, long CreatedAt, - bool IsEdit, string[] Recipients, Guid[] MediaIds, string Ciphertext); + +public sealed record EncryptedMessage( + int Version, + Guid MessageId, + Guid ConversationId, + int RecipientType, + DeviceKey Sender, + Guid? ReplyToMessageId, + long CreatedAt, + bool IsEdit, + string[] Recipients, + Guid[] MediaIds, + string Ciphertext); + public sealed record DevicePrivateKeys(string IdentityKey, string EncryptionKey); public static class E2eeProtocol @@ -31,13 +52,16 @@ public static class E2eeProtocol public const string EncryptedMimeType = "application/vnd.govor.encrypted"; public static readonly JsonSerializerOptions Json = new() { PropertyNameCaseInsensitive = true }; - public static bool IsEncrypted(string? value) => value?.StartsWith(Prefix, StringComparison.Ordinal) == true; + public static bool IsEncrypted(string? value) + { + return value?.StartsWith(Prefix, StringComparison.Ordinal) == true; + } public static DevicePrivateKeys GenerateKeys() { using var signing = ECDsa.Create(ECCurve.NamedCurves.nistP256); using var encryption = RSA.Create(3072); - return new(Convert.ToBase64String(signing.ExportPkcs8PrivateKey()), + return new DevicePrivateKeys(Convert.ToBase64String(signing.ExportPkcs8PrivateKey()), Convert.ToBase64String(encryption.ExportPkcs8PrivateKey())); } @@ -50,7 +74,7 @@ public static class E2eeProtocol // Domain separation prevents using this signature as a message signature. var signature = signing.SignData(KeyBinding(publicEncryption), HashAlgorithmName.SHA256, DSASignatureFormat.IeeeP1363FixedFieldConcatenation); - return new(user, session, identity, publicEncryption, Convert.ToBase64String(signature)); + return new DeviceKey(user, session, identity, publicEncryption, Convert.ToBase64String(signature)); } public static void ValidatePublicKey(DeviceKey key) @@ -69,8 +93,11 @@ public static class E2eeProtocol throw new CryptographicException("Invalid E2EE key binding signature."); } - public static string Fingerprint(string identity, string encryption) => - Convert.ToHexString(SHA256.HashData(Encoding.UTF8.GetBytes($"govor-device-v1\n{identity}\n{encryption}"))); + public static string Fingerprint(string identity, string encryption) + { + return Convert.ToHexString( + SHA256.HashData(Encoding.UTF8.GetBytes($"govor-device-v1\n{identity}\n{encryption}"))); + } public static string Encrypt(MessagePlaintext plaintext, DevicePrivateKeys privateKeys, DeviceKey sender, ConversationKeys conversation, Guid messageId, Guid? replyTo = null, @@ -96,7 +123,8 @@ public static class E2eeProtocol }).ToArray(); var ciphertext = JWE.Encrypt(JsonSerializer.Serialize(plaintext), recipients, JweEncryption.A256GCM); var envelope = new EncryptedMessage(1, messageId, conversation.ConversationId, - conversation.RecipientType, sender, replyTo, createdAt ?? DateTimeOffset.UtcNow.ToUnixTimeMilliseconds(), + conversation.RecipientType, sender, replyTo, + createdAt ?? DateTimeOffset.UtcNow.ToUnixTimeMilliseconds(), isEdit, devices.Select(k => k.Fingerprint).Order(StringComparer.Ordinal).ToArray(), plaintext.Attachments.Select(a => a.MediaId).Order().ToArray(), ciphertext); using var signing = SigningPrivateKey(privateKeys); @@ -104,7 +132,10 @@ public static class E2eeProtocol if (result.Length > MaxEnvelopeLength) throw new CryptographicException("E2EE envelope is too large."); return result; } - finally { foreach (var key in keys) key.Dispose(); } + finally + { + foreach (var key in keys) key.Dispose(); + } } // Reading the unverified payload is used only to select its verification key. @@ -116,7 +147,7 @@ public static class E2eeProtocol var parts = value[Prefix.Length..].Split('.'); if (parts.Length != 3) throw new CryptographicException("Invalid signed E2EE envelope."); var envelope = JsonSerializer.Deserialize(Base64Url.Decode(parts[1]), Json) - ?? throw new CryptographicException("Invalid E2EE envelope."); + ?? throw new CryptographicException("Invalid E2EE envelope."); if (envelope.Version != 1 || envelope.Sender is null || envelope.MessageId == Guid.Empty || envelope.ConversationId == Guid.Empty || envelope.RecipientType is < 0 or > 1 || envelope.Recipients is null || envelope.Recipients.Length is 0 or > MaxDevices || @@ -142,7 +173,8 @@ public static class E2eeProtocol header.RootElement.TryGetProperty("zip", out _)) throw new CryptographicException("Unsupported content encryption."); var recipients = root.TryGetProperty("recipients", out var many) - ? many.EnumerateArray().ToArray() : new[] { root }; + ? many.EnumerateArray().ToArray() + : new[] { root }; if (recipients.Length != envelope.Recipients.Length || recipients.Any(r => r.GetProperty("header").GetProperty("alg").GetString() != "RSA-OAEP-256") || !recipients.Select(r => r.GetProperty("header").GetProperty("kid").GetString()) @@ -170,16 +202,17 @@ public static class E2eeProtocol throw new CryptographicException("This device cannot decrypt this message."); // Select our recipient explicitly. In particular Windows CNG can throw an // OS-specific error while trying another recipient's RSA-OAEP encrypted key. - var selected = System.Text.Json.Nodes.JsonNode.Parse(envelope.Ciphertext)!; - if (selected["recipients"] is System.Text.Json.Nodes.JsonArray recipients) + var selected = JsonNode.Parse(envelope.Ciphertext)!; + if (selected["recipients"] is JsonArray recipients) { var recipient = recipients.Single(r => r!["header"]!["kid"]!.GetValue() == fingerprint)!; - selected["recipients"] = new System.Text.Json.Nodes.JsonArray(recipient.DeepClone()); + selected["recipients"] = new JsonArray(recipient.DeepClone()); } + var decrypted = JWE.Decrypt(selected.ToJsonString(), rsa, JweAlgorithm.RSA_OAEP_256, JweEncryption.A256GCM); var plaintext = JsonSerializer.Deserialize(decrypted.Plaintext, Json) - ?? throw new CryptographicException("Invalid encrypted content."); + ?? throw new CryptographicException("Invalid encrypted content."); if (plaintext.Text is null || plaintext.Text.Length > 20_000 || plaintext.Attachments is null || !plaintext.Attachments.Select(a => a.MediaId).Order().SequenceEqual(envelope.MediaIds.Order())) throw new CryptographicException("Invalid encrypted attachment manifest."); @@ -195,11 +228,15 @@ public static class E2eeProtocol var data = new byte[12 + plaintext.Length + 16]; RandomNumberGenerator.Fill(data.AsSpan(0, 12)); using var aes = new AesGcm(key, 16); - aes.Encrypt(data.AsSpan(0, 12), plaintext, data.AsSpan(12, plaintext.Length), data.AsSpan(12 + plaintext.Length, 16), + aes.Encrypt(data.AsSpan(0, 12), plaintext, data.AsSpan(12, plaintext.Length), + data.AsSpan(12 + plaintext.Length, 16), "govor-attachment-v1"u8); return (data, Convert.ToBase64String(key)); } - finally { CryptographicOperations.ZeroMemory(key); } + finally + { + CryptographicOperations.ZeroMemory(key); + } } public static byte[] DecryptAttachment(byte[] ciphertext, string encodedKey) @@ -215,26 +252,57 @@ public static class E2eeProtocol ciphertext.AsSpan(12 + plaintext.Length, 16), plaintext, "govor-attachment-v1"u8); return plaintext; } - finally { CryptographicOperations.ZeroMemory(key); } + finally + { + CryptographicOperations.ZeroMemory(key); + } + } + + private static byte[] KeyBinding(string encryption) + { + return Encoding.UTF8.GetBytes("govor-key-binding-v1\n" + encryption); } - private static byte[] KeyBinding(string encryption) => Encoding.UTF8.GetBytes("govor-key-binding-v1\n" + encryption); private static ECDsa SigningPrivateKey(DevicePrivateKeys keys) { var bytes = Convert.FromBase64String(keys.IdentityKey); var key = ECDsa.Create(); - try { key.ImportPkcs8PrivateKey(bytes, out _); return key; } - catch { key.Dispose(); throw; } - finally { CryptographicOperations.ZeroMemory(bytes); } + try + { + key.ImportPkcs8PrivateKey(bytes, out _); + return key; + } + catch + { + key.Dispose(); + throw; + } + finally + { + CryptographicOperations.ZeroMemory(bytes); + } } + private static RSA EncryptionPrivateKey(DevicePrivateKeys keys) { var bytes = Convert.FromBase64String(keys.EncryptionKey); var key = RSA.Create(); - try { key.ImportPkcs8PrivateKey(bytes, out _); return key; } - catch { key.Dispose(); throw; } - finally { CryptographicOperations.ZeroMemory(bytes); } + try + { + key.ImportPkcs8PrivateKey(bytes, out _); + return key; + } + catch + { + key.Dispose(); + throw; + } + finally + { + CryptographicOperations.ZeroMemory(bytes); + } } + private static ECDsa SigningPublicKey(DeviceKey device) { var key = ECDsa.Create(); @@ -245,8 +313,13 @@ public static class E2eeProtocol if (read != bytes.Length) throw new CryptographicException("Trailing public key data."); return key; } - catch { key.Dispose(); throw; } + catch + { + key.Dispose(); + throw; + } } + private static RSA EncryptionPublicKey(DeviceKey device) { var key = RSA.Create(); @@ -257,6 +330,10 @@ public static class E2eeProtocol if (read != bytes.Length) throw new CryptographicException("Trailing public key data."); return key; } - catch { key.Dispose(); throw; } + catch + { + key.Dispose(); + throw; + } } -} +} \ No newline at end of file diff --git a/Govor.Application/Friends/FriendsBlockService.cs b/Govor.Application/Friends/FriendsBlockService.cs index 57c265c..e8cc437 100644 --- a/Govor.Application/Friends/FriendsBlockService.cs +++ b/Govor.Application/Friends/FriendsBlockService.cs @@ -1,14 +1,50 @@ +using Govor.Domain; +using Govor.Domain.Models; +using Microsoft.EntityFrameworkCore; + namespace Govor.Application.Friends; -public class FriendsBlockService : IFriendsBlockService +public class FriendsBlockService(GovorDbContext context) : IFriendsBlockService { - public Task BlockFriendRequestAsync(Guid userId, Guid currentUserId) + public async Task BlockFriendRequestAsync(Guid userId, Guid currentUserId) { - throw new NotImplementedException(); + if (userId == Guid.Empty || currentUserId == Guid.Empty || userId == currentUserId) + throw new ArgumentException("Two distinct users are required."); + if (await context.Users.CountAsync(u => u.Id == userId || u.Id == currentUserId) != 2) + throw new KeyNotFoundException("User not found."); + var friendship = await FindAsync(userId, currentUserId); + if (friendship?.Status == FriendshipStatus.Blocked) + { + if (friendship.RequesterId != currentUserId) + throw new UnauthorizedAccessException("Only the user who blocked this conversation can change the block."); + return; + } + if (friendship is null) + { + friendship = new Friendship { Id = Guid.NewGuid() }; + context.Friendships.Add(friendship); + } + // A blocked row records its owner as Requester; requests cannot overwrite it. + friendship.RequesterId = currentUserId; + friendship.AddresseeId = userId; + friendship.Status = FriendshipStatus.Blocked; + await context.SaveChangesAsync(); } - public Task UnblockFriendRequestAsync(Guid userId, Guid currentUserId) + public async Task UnblockFriendRequestAsync(Guid userId, Guid currentUserId) { - throw new NotImplementedException(); + if (userId == Guid.Empty || currentUserId == Guid.Empty || userId == currentUserId) + throw new ArgumentException("Two distinct users are required."); + var friendship = await FindAsync(userId, currentUserId); + if (friendship?.Status != FriendshipStatus.Blocked) return; + if (friendship.RequesterId != currentUserId) + throw new UnauthorizedAccessException("Only the user who blocked this conversation can remove the block."); + // Unblocking permits a new request; it does not restore friendship without consent. + friendship.Status = FriendshipStatus.Rejected; + await context.SaveChangesAsync(); } -} \ No newline at end of file + + private Task FindAsync(Guid userId, Guid currentUserId) => context.Friendships.FirstOrDefaultAsync(f => + (f.RequesterId == userId && f.AddresseeId == currentUserId) || + (f.RequesterId == currentUserId && f.AddresseeId == userId)); +} diff --git a/Govor.Application/Infrastructure/Validators/UsernameValidator.cs b/Govor.Application/Infrastructure/Validators/UsernameValidator.cs index 269beee..78ae8d4 100644 --- a/Govor.Application/Infrastructure/Validators/UsernameValidator.cs +++ b/Govor.Application/Infrastructure/Validators/UsernameValidator.cs @@ -42,7 +42,7 @@ public class UsernameValidator : IUsernameValidator public Result Validate(string username) { - if (username.Length < UserConstants.MIN_LENGHT_OF_NAME || username.Length > UserConstants.MAX_LENGHT_OF_NAME) + if (string.IsNullOrEmpty(username) || username.Length < UserConstants.MIN_LENGHT_OF_NAME || username.Length > UserConstants.MAX_LENGHT_OF_NAME) { return Result.Failure(Error.Validation( ErrorCode, diff --git a/Govor.Application/Medias/MediaService.cs b/Govor.Application/Medias/MediaService.cs index 202addb..59e36b0 100644 --- a/Govor.Application/Medias/MediaService.cs +++ b/Govor.Application/Medias/MediaService.cs @@ -78,24 +78,29 @@ public class MediaService : IMediaService return new Unit(); } - public Task> GetMediaByUrlAsync(string url) + public async Task> GetMediaByUrlAsync(string url) { - throw new NotImplementedException(); + if (string.IsNullOrWhiteSpace(url)) + return Result.Failure(Error.Validation("File.GetMediaByUrl", "Media URL is required.")); + var file = await _dbContext.MediaFiles.AsNoTracking().FirstOrDefaultAsync(m => m.Url == url); + return await ReadMediaAsync(file, "File.GetMediaByUrl"); } public async Task> GetMediaByIdAsync(Guid mediaId) + { + var file = await _dbContext.MediaFiles.AsNoTracking().FirstOrDefaultAsync(m => m.Id == mediaId); + return await ReadMediaAsync(file, "File.GetMediaById"); + } + + private async Task> ReadMediaAsync(MediaFile? mediaFile, string errorCode) { try { - var mediaFile = await _dbContext.MediaFiles - .AsNoTracking() - .FirstOrDefaultAsync(x => x.Id == mediaId); - if (mediaFile is null) { return Result.Failure(Error.NotFound( - "File.GetMediaById", - $"File with given id ({mediaId}) doesn't exist!") + errorCode, + "Media file does not exist.") ); } @@ -114,7 +119,7 @@ public class MediaService : IMediaService return new Media( mediaFile.UploaderId, mediaFile.DateCreated, - mediaFile.MediaType.ToString(), + Path.GetFileName(mediaFile.Url), contentBytes, mediaFile.MediaType, mediaFile.MineType, @@ -125,8 +130,8 @@ public class MediaService : IMediaService } catch (FileNotFoundException ex) { - _logger.LogWarning(ex, "Media file ({0}) not found on storage.", mediaId); - return Result.Failure(Error.ServerError("File.GetMediaById", $"Media file not found on storage!")); + _logger.LogWarning(ex, "Media file {MediaId} not found on storage.", mediaFile?.Id); + return Result.Failure(Error.ServerError(errorCode, "Media file not found on storage!")); } } diff --git a/Govor.Application/Storage/LocalStorageService.cs b/Govor.Application/Storage/LocalStorageService.cs index 9a673d2..a643279 100644 --- a/Govor.Application/Storage/LocalStorageService.cs +++ b/Govor.Application/Storage/LocalStorageService.cs @@ -6,7 +6,7 @@ public class LocalStorageService : IStorageService public LocalStorageService(string contentRootPath) { - _storagePath = Path.Combine(contentRootPath, "uploads"); + _storagePath = Path.GetFullPath(Path.Combine(contentRootPath, "uploads")); if (!Directory.Exists(_storagePath)) { @@ -38,7 +38,7 @@ public class LocalStorageService : IStorageService public async Task LoadAsync(string url) { - var filePath = Path.Combine(_storagePath, url); + var filePath = ResolvePath(url); if (!File.Exists(filePath)) throw new FileNotFoundException("File not found.", filePath); @@ -48,15 +48,7 @@ public class LocalStorageService : IStorageService public async Task RemoveAsync(string url) { - if (string.IsNullOrWhiteSpace(url)) - throw new ArgumentException("Invalid file url"); - - var rootPath = Path.GetFullPath(_storagePath); - - var fullPath = Path.GetFullPath(Path.Combine(rootPath, url)); - - if (!fullPath.StartsWith(rootPath, StringComparison.OrdinalIgnoreCase)) - throw new UnauthorizedAccessException("Invalid file path"); + var fullPath = ResolvePath(url); if (!File.Exists(fullPath)) return; @@ -80,4 +72,15 @@ public class LocalStorageService : IStorageService await Task.CompletedTask; } + + private string ResolvePath(string url) + { + if (string.IsNullOrWhiteSpace(url)) throw new ArgumentException("Invalid file url", nameof(url)); + if (Path.IsPathRooted(url)) throw new UnauthorizedAccessException("Invalid file path"); + var fullPath = Path.GetFullPath(Path.Combine(_storagePath, url)); + var comparison = OperatingSystem.IsWindows() ? StringComparison.OrdinalIgnoreCase : StringComparison.Ordinal; + if (!fullPath.StartsWith(_storagePath + Path.DirectorySeparatorChar, comparison)) + throw new UnauthorizedAccessException("Invalid file path"); + return fullPath; + } } diff --git a/Govor.Application/Users/UserOnlineStatus/UserPresenceReader.cs b/Govor.Application/Users/UserOnlineStatus/UserPresenceReader.cs index de7f951..0f5ad3e 100644 --- a/Govor.Application/Users/UserOnlineStatus/UserPresenceReader.cs +++ b/Govor.Application/Users/UserOnlineStatus/UserPresenceReader.cs @@ -1,9 +1,13 @@ +using Govor.Domain; +using Microsoft.EntityFrameworkCore; + namespace Govor.Application.Users.UserOnlineStatus; -public class UserPresenceReader : IUserPresenceReader +public class UserPresenceReader(GovorDbContext context) : IUserPresenceReader { public Task GetLastSeenAsync(Guid userId) { - throw new NotImplementedException(); + return context.Users.AsNoTracking().Where(u => u.Id == userId) + .Select(u => (DateTime?)u.WasOnline).FirstOrDefaultAsync(); } -} \ No newline at end of file +} diff --git a/Govor.Application/Users/UserSessions/Crypto/OneTimePreKeysRotator.cs b/Govor.Application/Users/UserSessions/Crypto/OneTimePreKeysRotator.cs index e652413..75fccc7 100644 --- a/Govor.Application/Users/UserSessions/Crypto/OneTimePreKeysRotator.cs +++ b/Govor.Application/Users/UserSessions/Crypto/OneTimePreKeysRotator.cs @@ -23,10 +23,13 @@ public class OneTimePreKeysRotator : IOneTimePreKeysRotator { var cryptoSession = await _context.UserCryptoSessions .Include(c => c.OneTimePreKeys) + .Include(c => c.UserSession) .FirstOrDefaultAsync(c => c.UserSessionId == sessionId); if (cryptoSession == null) throw new ArgumentException("Crypto session not found", nameof(sessionId)); + if (cryptoSession.UserSession.UserId != _current.GetCurrentUserId()) + throw new UnauthorizedAccessException("Only the session owner can rotate its keys."); // Удаляем все использованные ключи var usedKeys = cryptoSession.OneTimePreKeys.Where(k => k.IsUsed).ToList(); @@ -38,9 +41,10 @@ public class OneTimePreKeysRotator : IOneTimePreKeysRotator // Добавляем новые ключи (возможно, стоит ограничить количество) foreach (var key in newOneTimePreKeys) { - cryptoSession.OneTimePreKeys.Add(new OneTimePreKey + _context.OneTimePreKeys.Add(new OneTimePreKey { Id = Guid.NewGuid(), + UserCryptoSessionId = cryptoSession.Id, PublicKey = key, IsUsed = false, UploadedAt = DateTime.UtcNow @@ -54,10 +58,13 @@ public class OneTimePreKeysRotator : IOneTimePreKeysRotator { var key = await _context.OneTimePreKeys .Include(k => k.UserCryptoSession) + .ThenInclude(c => c.UserSession) .FirstOrDefaultAsync(k => k.Id == oneTimePreKeyId && k.UserCryptoSession.UserSessionId == sessionId); if (key == null) throw new ArgumentException("One-Time PreKey not found for this session", nameof(oneTimePreKeyId)); + if (key.UserCryptoSession.UserSession.UserId != _current.GetCurrentUserId()) + throw new UnauthorizedAccessException("Only the session owner can consume its keys."); if (key.IsUsed) return; // Уже помечен @@ -66,4 +73,4 @@ public class OneTimePreKeysRotator : IOneTimePreKeysRotator await _context.SaveChangesAsync(); } -} \ No newline at end of file +} diff --git a/Govor.Application/Users/UserSessions/Crypto/SessionKeyAttacher.cs b/Govor.Application/Users/UserSessions/Crypto/SessionKeyAttacher.cs index c4860fb..13d81b4 100644 --- a/Govor.Application/Users/UserSessions/Crypto/SessionKeyAttacher.cs +++ b/Govor.Application/Users/UserSessions/Crypto/SessionKeyAttacher.cs @@ -64,9 +64,10 @@ public class SessionKeyAttacher : ISessionKeyAttacher }; session.CryptoSession = cryptoSession; + _context.UserCryptoSessions.Add(cryptoSession); await _context.SaveChangesAsync(); _logger.LogInformation("Attached keys to session {SessionId}", sessionId); } -} \ No newline at end of file +} diff --git a/Govor.Application/Users/UserSessions/Crypto/SessionKeysReader.cs b/Govor.Application/Users/UserSessions/Crypto/SessionKeysReader.cs index bf7b7d1..31d2419 100644 --- a/Govor.Application/Users/UserSessions/Crypto/SessionKeysReader.cs +++ b/Govor.Application/Users/UserSessions/Crypto/SessionKeysReader.cs @@ -55,6 +55,7 @@ public class SessionKeysReader : ISessionKeysReader .AsNoTracking() .Include(c => c.OneTimePreKeys) .Include(c => c.UserSession) + .Include(c => c.SignedPreKey) .FirstOrDefaultAsync(c => c.UserSessionId == sessionId); } } diff --git a/Govor.Application/Users/UserSessions/UserSessionOpener.cs b/Govor.Application/Users/UserSessions/UserSessionOpener.cs index ff6a58b..0776aff 100644 --- a/Govor.Application/Users/UserSessions/UserSessionOpener.cs +++ b/Govor.Application/Users/UserSessions/UserSessionOpener.cs @@ -61,23 +61,6 @@ public class UserSessionOpener : IUserSessionOpener } } - private async Task UpdateExistingSessionAsync(User user, string deviceInfo, UserSession session) - { - var (accessToken, refreshToken) = await GenerateTokensAsync(user, session.Id); - - var newTokenHash = _jwtTokenHasher.HashToken(refreshToken); - var newExpiresAt = DateTime.UtcNow.AddDays(_options.RefreshTokenLifetimeDays); - - session.RefreshTokenHash = newTokenHash; - session.ExpiresAt = newExpiresAt; - session.CreatedAt = DateTime.UtcNow; - session.IsRevoked = false; - - _logger.LogInformation("Updated session for user {UserId} on device '{DeviceInfo}'", user.Id, deviceInfo); - - return new RefreshResult(refreshToken, accessToken); - } - private async Task CreateNewSessionAsync(User user, string deviceInfo) { var sessionId = Guid.NewGuid(); diff --git a/Govor.Contracts/Requests/MediaUploadRequest.cs b/Govor.Contracts/Requests/MediaUploadRequest.cs index 4baa48f..9db7809 100644 --- a/Govor.Contracts/Requests/MediaUploadRequest.cs +++ b/Govor.Contracts/Requests/MediaUploadRequest.cs @@ -13,8 +13,7 @@ public class MediaUploadRequest public MediaType Type { get; set; } [Required, MaxLength(255)] public string MimeType { get; set; } = string.Empty; - [Required] - public string EncryptedKey { get; set; } = string.Empty; + public string? EncryptedKey { get; set; } = string.Empty; [Required] public MediaOwnerType OwnerType { get; set; } = MediaOwnerType.Message; -} \ No newline at end of file +} diff --git a/Govor.Data.Tests/Govor.Data.Tests.csproj b/Govor.Data.Tests/Govor.Data.Tests.csproj deleted file mode 100644 index c7e42eb..0000000 --- a/Govor.Data.Tests/Govor.Data.Tests.csproj +++ /dev/null @@ -1,26 +0,0 @@ - - - - net8.0 - latest - enable - enable - false - - - - - - - - - - - - - - - - - - diff --git a/Govor.Data.Tests/Repositories/AdminsRepositoryTests.cs b/Govor.Data.Tests/Repositories/AdminsRepositoryTests.cs deleted file mode 100644 index 1730862..0000000 --- a/Govor.Data.Tests/Repositories/AdminsRepositoryTests.cs +++ /dev/null @@ -1,176 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Validators; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Govor.Domain; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class AdminsRepositoryTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private IObjectValidator _validator = new AdminValidator(); - - private int _testIteration = 0; - - [SetUp] - public void Setup() - { - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(AdminsRepositoryTests)}_{_testIteration}") - .Options; - _testIteration += 1; - } - - [Test] - public async Task Given_NotEmptyDbSet_When_GetAllAsync_Then_Admins_Are_Returned() - { - // Arrange - var random = new Random(); - var admins = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - context.AddRange(admins); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count(), Is.EqualTo(admins.Count())); - Assert.That(result.Select(r => r.UserId), Is.EquivalentTo(admins.Select(r => r.UserId))); - } - - [Test] - public async Task Given_EmptyDbSet_When_GetAllAsync_Should_Throw_NotFoundException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.GetAllAsync()); - } - - [Test] - public async Task Given_ValidUserId_When_GetByIdAsync_Then_Admin_Should_Return_Admin() - { - // Arrange - var admin = _fixture.Create(); - await using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - context.Add(admin); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetByIdAsync(admin.UserId); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.UserId, Is.EqualTo(admin.UserId)); - } - - [Test] - public async Task Given_InvalidUserId_When_GetByIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidAdmin_When_AddAsync_Then_Added() - { - // Arrange - var admin = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - // Act - await repository.AddAsync(admin); - - // Assert - Assert.That(context.Admins.Count, Is.EqualTo(1)); - Assert.That(context.Admins.First(), Is.EqualTo(admin)); - } - - [Test] - public async Task Given_InvalidAdmin_When_AddAsync_Should_Throw_AdditionException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.AddAsync(default)); - } - - [Test] - public void Given_ValidAdmin_When_Exist_Then_Returns_True() - { - // Arrange - var admin = _fixture.Create(); - using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - context.Add(admin); - context.SaveChanges(); - // Act - var result = repository.Exist(admin.UserId); - var result2 = repository.Exist(admin); - - // Assert - Assert.That(result, Is.True); - Assert.That(result2, Is.True); - } - - [Test] - public void Given_ExistAdmin_When_Exist_Then_Returns_False() - { - // Arrange - var admin = _fixture.Create(); - using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - // Act - var result = repository.Exist(admin.UserId); - var result2 = repository.Exist(admin); - - // Assert - Assert.That(result, Is.False); - Assert.That(result2, Is.False); - } - - [Test] - public void Given_NullAdmin_When_Exist_Should_Throw_InvalidObjectException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new AdminsRepository(context, _validator); - - // Act & Assert - Assert.Throws>(() => repository.Exist(default(Admin))); - } -} diff --git a/Govor.Data.Tests/Repositories/FriendshipsRepositoryTests.cs b/Govor.Data.Tests/Repositories/FriendshipsRepositoryTests.cs deleted file mode 100644 index d7d00f8..0000000 --- a/Govor.Data.Tests/Repositories/FriendshipsRepositoryTests.cs +++ /dev/null @@ -1,191 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Validators; -using Govor.Domain.Models; -using Govor.Domain; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class FriendshipsRepositoryTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private IObjectValidator _validator = new FriendshipValidator(); - - private int _testIteration = 0; - - [SetUp] - public void Setup() - { - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(FriendshipsRepositoryTests)}_{_testIteration}") - .Options; - _testIteration += 1; - } - - - [Test] - public async Task Given_NotEmptyDbSet_When_GetAllAsync_Then_Friendships_Are_Returned() - { - // Arrange - var random = new Random(); - var friendships = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - context.AddRange(friendships); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count(), Is.EqualTo(friendships.Count())); - Assert.That(result.Select(r => r.Id), Is.EquivalentTo(friendships.Select(r => r.Id))); - } - - [Test] - public async Task Given_EmptyDbSet_When_GetAllAsync_Should_Throw_NotFoundException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.GetAllAsync()); - } - - [Test] - public async Task Given_ValidFriendshipId_When_GetByIdAsync_Then_Friendships_Are_Returned() - { - // Arrange - var random = new Random(); - var friendships = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - context.AddRange(friendships); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetByIdAsync(friendships.First().Id); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Id, Is.EqualTo(friendships.First().Id)); - } - - [Test] - public async Task Given_InvalidFriendshipId_When_GetByIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidUserId_When_GetByIdAsync_Then_Friendships_Are_Returned() - { - // Arrange - var random = new Random(); - var friendships = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - context.AddRange(friendships); - await context.SaveChangesAsync(); - - // Act - var result = await repository.FindByUserIdAsync(friendships.First().RequesterId); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.First().Id, Is.EqualTo(friendships.First().Id)); - } - - [Test] - public async Task Given_InvalidUserId_When_GetByIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.FindByUserIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidFriendship_When_AddAsync_Then_Added() - { - // Arrange - var friendship = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - // Act - await repository.AddAsync(friendship); - - // Assert - Assert.That(context.Friendships.Count, Is.EqualTo(1)); - Assert.That(context.Friendships.First().Id, Is.EqualTo(friendship.Id)); - } - - [Test] - public async Task Given_InvalidFriendship_When_AddAsync_Should_Throw_AdditionException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.AddAsync(default)); - } - - [Test] - public async Task Given_ExistFriendship_When_Exist_Then_True() - { - // Arrange - var friendship = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - - context.Friendships.Add(friendship); - await context.SaveChangesAsync(); - - // Act - var result = repository.Exist(friendship.RequesterId, friendship.AddresseeId); - // Assert - Assert.That(result, Is.True); - } - - [Test] - public async Task Given_NotExistFriendship_When_Exist_Then_False() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new FriendshipsRepository(context, _validator); - // Act & Assert - Assert.That(repository.Exist(_fixture.Create(), _fixture.Create()), Is.False); - } -} \ No newline at end of file diff --git a/Govor.Data.Tests/Repositories/GroupRepositoryTests.cs b/Govor.Data.Tests/Repositories/GroupRepositoryTests.cs deleted file mode 100644 index 46def33..0000000 --- a/Govor.Data.Tests/Repositories/GroupRepositoryTests.cs +++ /dev/null @@ -1,308 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Validators; -using Govor.Domain.Models; -using Govor.Domain; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class GroupRepositoryTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private IObjectValidator _validator = new ChatGroupValidator(); - private int _testIteration = 0; - - [SetUp] - public void SetUp() - { - _testIteration += 1; - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(GroupRepositoryTests)}_{_testIteration}") - .Options; - } - - [Test] - public async Task Given_NotEmptySetDb_When_GetAll_Then_ReturnAll() - { - // Arrange - var random = new Random(); - var chats = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - context.ChatGroups.AddRange(chats); - await context.SaveChangesAsync(); - - // Act - - var result = await repository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(chats.Count)); - Assert.That(result, Is.EquivalentTo(chats)); - } - - [Test] - public void Given_EmptySetDb_When_GetAll_Should_Throw_NotFoundException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.GetAllAsync()); - } - - [Test] - public async Task Given_ValidChatId_When_GetById_Then_ReturnChat() - { - // Arrange - var chats = _fixture.CreateMany(10); - var id = chats.First().Id; - - await using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - context.ChatGroups.AddRange(chats); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetByIdAsync(id); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.EqualTo(chats.First())); - } - - [Test] - public void Given_InvalidMessageId_When_FindById_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => - await repository.GetByIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidQuery_When_SearchByNameAsync_Then_Returns_ChatGroups() - { - // Arrange - var random = new Random(); - var chats = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - context.ChatGroups.AddRange(chats); - await context.SaveChangesAsync(); - - // Act - var result = await repository.SearchByNameAsync(chats[0].Name[..14]); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(1)); - Assert.That(result.First(), Is.EqualTo(chats.First())); - } - - [Test] - public void Given_InvalidQuery_When_SearchPotentialFriendsAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await - repository.SearchByNameAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidAdminId_When_GetByAdminIdAsync_Returns_ChatGroups() - { - // Arrange - var random = new Random(); - var chats = _fixture.CreateMany(random.Next(3, 10)).ToList(); - var adminId = chats.First().Admins.First().UserId; - - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - context.ChatGroups.AddRange(chats); - await context.SaveChangesAsync(); - // Act - var result = await repository.GetByAdminIdAsync(adminId); - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(1)); - Assert.That(result.First(), Is.EqualTo(chats.First())); - } - - [Test] - public void Given_ValidInvalidAdminId_When_GetByAdminIdAsync_Throws_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await - repository.GetByAdminIdAsync(_fixture.Create())); - } - [Test] - public async Task Given_ValidMemberId_When_GetByAdminIdAsync_Returns_ChatGroups() - { - // Arrange - var random = new Random(); - var chats = _fixture.CreateMany(random.Next(3, 10)).ToList(); - var userId = chats.First().Members.First().UserId; - - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - context.ChatGroups.AddRange(chats); - await context.SaveChangesAsync(); - // Act - var result = await repository.GetByUserIdAsync(userId); - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(1)); - Assert.That(result.First(), Is.EqualTo(chats.First())); - } - - [Test] - public void Given_ValidInvalidMemberId_When_GetByAdminIdAsync_Throws_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await - repository.GetByUserIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidChatGroup_When_AddAsync_Then_PrivateChatAdded() - { - // Arrange - var chat = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act - await repository.AddAsync(chat); - - // Assert - Assert.That(context.ChatGroups.Count, Is.EqualTo(1)); - Assert.That(context.ChatGroups.First(), Is.EqualTo(chat)); - } - - [Test] - public void Given_InvalidChatGroup_When_AddAsync_Should_Throw_AdditionException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.AddAsync(default)); - } - - [Test] - public async Task Given_ExistChatGroup_When_Exist_Then_ReturnTrue() - { - // Arrange - var chat = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - context.ChatGroups.Add(chat); - await context.SaveChangesAsync(); - - // Act - var result1 = repository.Exist(chat.Id); - var result2 = repository.Exist(chat); - - - // Assert - Assert.That(result1, Is.True); - Assert.That(result2, Is.True); - } - - [Test] - public async Task Given_NotExistChatGroup_When_Exist_Then_ReturnFalse() - { - // Arrange - var chat = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act - var result1 = repository.Exist(chat.Id); - var result2 = repository.Exist(chat); - - // Assert - Assert.That(result1, Is.False); - Assert.That(result2, Is.False); - } - - [Test] - public async Task Given_ValidUserIdAndChatGroupId_When_IsUserMemberOfGroupAsync_Then_ReturnTrue() - { - // Arrange - var chat = _fixture.Create(); - var userId = chat.Members.First().UserId; - - await using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - await context.ChatGroups.AddAsync(chat); - await context.SaveChangesAsync(); - - // Act - var result = await repository.IsUserMemberOfGroupAsync(userId, chat.Id); - - // Assert - Assert.That(result, Is.True); - } - - [Test] - public async Task Given_InvalidValidUserIdAndChatGroupId_When_IsUserMemberOfGroupAsync_Then_ReturnFalse() - { - // Arrange - var chat = _fixture.Create(); - var userId = chat.Members.First().UserId; - - await using var context = new GovorDbContext(_options); - var repository = new GroupRepository(context, _validator); - - // Act - var result = await repository.IsUserMemberOfGroupAsync(userId, chat.Id); - - // Assert - Assert.That(result, Is.False); - } -} \ No newline at end of file diff --git a/Govor.Data.Tests/Repositories/InvitesRepositoryTests.cs b/Govor.Data.Tests/Repositories/InvitesRepositoryTests.cs deleted file mode 100644 index 9ef01af..0000000 --- a/Govor.Data.Tests/Repositories/InvitesRepositoryTests.cs +++ /dev/null @@ -1,249 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Validators; -using Govor.Domain.Models; -using Govor.Domain; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class InvitesRepositoryTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private IObjectValidator _validator = new InvitationValidator(); - private int _testIteration = 0; - - [SetUp] - public void Setup() - { - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(InvitesRepositoryTests)}_{_testIteration}") - .Options; - _testIteration += 1; - } - - [Test] - public async Task Given_NotEmptyDbSet_When_GetAllAsync_Then_Invites_Are_Returned() - { - // Arrange - var random = new Random(); - var invitations = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - context.Invitations.AddRange(invitations); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count(), Is.EqualTo(invitations.Count())); - Assert.That(result, Is.EquivalentTo(invitations)); - } - - [Test] - public async Task Given_EmptyDbSet_When_GetAllAsync_Should_Throw_NotFoundException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.GetAllAsync()); - } - - [Test] - public async Task Given_ValidInvitesId_When_FindByIdAsync_Then_Invites_Are_Returned() - { - // Arrange - var invitation = _fixture.Create(); - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - context.Invitations.Add(invitation); - await context.SaveChangesAsync(); - - // Act - var result = await repository.FindByIdAsync(invitation.Id); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Id, Is.EqualTo(invitation.Id)); - } - - [Test] - public async Task Given_InvalidInvitesId_When_FindByIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.FindByIdAsync(Guid.Empty)); - } - - [Test] - public async Task Given_ValidInvitesCode_When_FindByCodeAsync_Then_Invites_Are_Returned() - { - // Arrange - var invitation = _fixture.Create(); - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - context.Invitations.Add(invitation); - await context.SaveChangesAsync(); - - // Act - var result = await repository.FindByCodeAsync(invitation.Code); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Id, Is.EqualTo(invitation.Id)); - } - - [Test] - public async Task Given_InvalidCode_When_FindByCodeAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.FindByCodeAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidAdminInvites_When_FindAdminsInvitesAsync_Then_Invites_Are_Returned() - { - // Arrange - var random = new Random(); - var invitations = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - foreach (var inv in invitations) - { - inv.IsAdmin = true; - } - - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - context.Invitations.AddRange(invitations); - await context.SaveChangesAsync(); - - // Act - var result = await repository.FindAdminsInvitesAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count(), Is.EqualTo(invitations.Count())); - Assert.That(result, Is.EquivalentTo(invitations)); - } - - [Test] - public async Task Given_InvalidAdminsInvites_When_FindAdminsInvitesAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.FindAdminsInvitesAsync()); - } - - [Test] - public async Task Given_ValidAdmin_When_AddAsync_Then_Added() - { - // Arrange - var invitation = _fixture.Create(); - invitation.Code = string.Join("", _fixture.CreateMany(12)); - invitation.EndDate = invitation.DateCreated.AddHours(1); - - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - // Act - await repository.AddAsync(invitation); - - // Assert - Assert.That(context.Invitations.Count, Is.EqualTo(1)); - Assert.That(context.Invitations.First(), Is.EqualTo(invitation)); - } - - [Test] - public async Task Given_InvalidAdmin_When_AddAsync_Should_Throw_AdditionException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.AddAsync(default)); - } - - [Test] - public async Task Given_NotExistInvitesCode_When_Exist_Then_Returns_False() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - // Act - var result = repository.Exist(Guid.NewGuid()); - var result2 = repository.Exist(_fixture.Create()); - - Assert.That(result, Is.False); - Assert.That(result2, Is.False); - } - - [Test] - public async Task Given_ExistInvites_When_Exist_Then_Returns_False() - { - // Arrange - var invitation = _fixture.Create(); - - invitation.Code = string.Join("", _fixture.CreateMany(12)); - invitation.EndDate = invitation.DateCreated.AddHours(1); - - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - context.Invitations.Add(invitation); - await context.SaveChangesAsync(); - - // Act - var result = repository.Exist(invitation.Id); - var result2 = repository.Exist(invitation); - var result3 = repository.Exist(invitation.Code); - - Assert.That(result, Is.True); - Assert.That(result2, Is.True); - Assert.That(result3, Is.True); - } - - - [Test] - public async Task Given_InvalidInvites_When_Exist_Then_Returns_False() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new InvitesRepository(context, _validator); - - // Act & Assert - Assert.Throws>(() => repository.Exist(default(Invitation))); - } -} \ No newline at end of file diff --git a/Govor.Data.Tests/Repositories/MediaAttachmentsTests.cs b/Govor.Data.Tests/Repositories/MediaAttachmentsTests.cs deleted file mode 100644 index c99629e..0000000 --- a/Govor.Data.Tests/Repositories/MediaAttachmentsTests.cs +++ /dev/null @@ -1,249 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Validators; -using Govor.Domain.Models; -using Govor.Domain.Models.Messages; -using Govor.Domain; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class MediaAttachmentsTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private readonly IObjectValidator _validator = new MediaAttachmentsValidator(); - private int _testIteration = 0; - - [SetUp] - public void SetUp() - { - _testIteration += 1; - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(MediaAttachmentsTests)}_{_testIteration}") - .Options; - } - - [Test] - public async Task Given_NotEmptySetDb_When_GetAll_Then_ReturnAllAttachments() - { - // Arrange - var random = new Random(); - var attachments = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var attachmentsRepository = new MediaAttachmentsRepository(context, _validator); - - context.MediaAttachments.AddRange(attachments); - await context.SaveChangesAsync(); - - // Act - - var result = await attachmentsRepository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(attachments.Count)); - Assert.That(result, Is.EquivalentTo(attachments)); - } - - [Test] - public void Given_EmptySetDb_When_GetAll_Should_Throw_NotFoundException() - { - // Arrange - using var context = new GovorDbContext(_options); - var mediaAttachments = new MediaAttachmentsRepository(context, _validator); - // Act & Assert - Assert.ThrowsAsync(async () => await mediaAttachments.GetAllAsync()); - } - - [Test] - public async Task Given_ValidMessageId_When_GetAllByMessageId_Then_ReturnAllAttachments() - { - // Arrange - var random = new Random(); - var attachments = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var attachmentsRepository = new MediaAttachmentsRepository(context, _validator); - - context.MediaAttachments.AddRange(attachments); - await context.SaveChangesAsync(); - - // Act - var result = await attachmentsRepository.GetAllByMessageId(attachments.First().MessageId); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(1)); - Assert.That(result.First(), Is.EqualTo(attachments.First())); - } - - [Test] - public async Task Given_InvalidMessageId_When_GetAllByMessageId_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var attachmentsRepository = new MediaAttachmentsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await attachmentsRepository.GetAllByMessageId(_fixture.Create())); - } - - [Test] - public async Task Given_ValidAttachmentsId_When_FindByIdAsync_Then_Returns_Attachment() - { - // Arrange - var attachment = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var attachmentsRepository = new MediaAttachmentsRepository(context, _validator); - - context.MediaAttachments.Add(attachment); - await context.SaveChangesAsync(); - - // Act - var result = await attachmentsRepository.FindByIdAsync(attachment.Id); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.EqualTo(attachment)); - } - - [Test] - public async Task Given_InvalidAttachmentsId_When_FindByIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var attachmentsRepository = new MediaAttachmentsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await attachmentsRepository.FindByIdAsync(_fixture.Create())); - } - - - [Test] - public async Task Given_ValidAttachments_When_AddAsync_Then_AttachmentsAdded() - { - // Arrange - var attachments = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MediaAttachmentsRepository(context, _validator); - - // Act - await messagesRepository.AddAsync(attachments); - - // Assert - Assert.That(context.MediaAttachments.Count, Is.EqualTo(1)); - Assert.That(context.MediaAttachments.First(), Is.EqualTo(attachments)); - } - - [Test] - public async Task Given_InvalidAttachments_When_AddAsync_Should_Throw_AdditionException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new MediaAttachmentsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.AddAsync(default)); - } - - [Test] - public async Task Given_ExistAttachment_When_Exist_Then_ReturnTrue() - { - // Arrange - var attachments = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new MediaAttachmentsRepository(context, _validator); - - context.MediaAttachments.Add(attachments); - await context.SaveChangesAsync(); - - // Act - var result = repository.Exist(attachments); - var result2 = repository.Exist(attachments.Id); - - // Assert - Assert.That(result, Is.True); - Assert.That(result2, Is.True); - } - - [Test] - public async Task Given_NotExistMessage_When_Exist_Then_ReturnFalse() - { - // Arrange - var attachments = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new MediaAttachmentsRepository(context, _validator); - - - // Act - var result = repository.Exist(attachments); - var result2 = repository.Exist(attachments.Id); - - // Assert - Assert.That(result, Is.False); - Assert.That(result2, Is.False); - } - - [Test] - public async Task Given_NotEqualMessage_When_Exist_Then_ReturnFalse() - { - // Arrange - var attachments = _fixture.Create(); - var attachments2 = _fixture.Create(); - attachments2.Id = attachments.Id; - - await using var context = new GovorDbContext(_options); - var repository = new MediaAttachmentsRepository(context, _validator); - - context.MediaAttachments.Add(attachments); - await context.SaveChangesAsync(); - - // Act - var result = repository.Exist(attachments2); - - // Assert - Assert.That(result, Is.False); - } - - [Test] - public async Task Given_InvalidMessage_When_Exist_Should_Throw_InvalidObjectException() - { - // Arrange - var attachments = _fixture.Create(); - attachments.MessageId = Guid.Empty; - - await using var context = new GovorDbContext(_options); - var repository = new MediaAttachmentsRepository(context, _validator); - - // Act & Assert - Assert.Throws>(() => repository.Exist(attachments)); - } - - [Test] - public void Given_NullMessage_When_Exist_Should_Throw_InvalidObjectException() - { - using var context = new GovorDbContext(_options); - var repository = new MediaAttachmentsRepository(context, _validator); - - // Act & Assert - Assert.Throws>(() => repository.Exist(default(MediaAttachments))); - } -} \ No newline at end of file diff --git a/Govor.Data.Tests/Repositories/MessagesRepositoryTests.cs b/Govor.Data.Tests/Repositories/MessagesRepositoryTests.cs deleted file mode 100644 index 8b0c0fe..0000000 --- a/Govor.Data.Tests/Repositories/MessagesRepositoryTests.cs +++ /dev/null @@ -1,398 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Validators; -using Govor.Domain.Models; -using Govor.Domain.Models.Messages; -using Govor.Domain; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class MessagesRepositoryTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private readonly IObjectValidator _messageValidator = new MessageValidator(); - private int _testIteration = 0; - - [SetUp] - public void SetUp() - { - _testIteration += 1; - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(MessagesRepositoryTests)}_{_testIteration}") - .Options; - } - - [Test] - public async Task Given_NotEmptySetDb_When_GetAllMessages_Then_ReturnAllMessages() - { - // Arrange - var random = new Random(); - var messages = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.AddRange(messages); - await context.SaveChangesAsync(); - - // Act - - var result = await messagesRepository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(messages.Count)); - Assert.That(result, Is.EquivalentTo(messages)); - } - - [Test] - public void Given_EmptySetDb_When_GetAllMessages_Should_Throw_NotFoundException() - { - // Arrange - using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - // Act & Assert - Assert.ThrowsAsync(async () => await messagesRepository.GetAllAsync()); - } - - [Test] - public async Task Given_ValidMessageId_When_FindMessageById_Then_ReturnMessage() - { - // Arrange - var messages = _fixture.CreateMany(10); - var id = messages.First().Id; - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.AddRange(messages); - await context.SaveChangesAsync(); - - // Act - var result = await messagesRepository.FindByIdAsync(id); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.EqualTo(messages.First())); - } - - [Test] - public async Task Given_InvalidMessageId_When_FindById_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await messagesRepository.FindByIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidSenderId_When_FindBySenderIdAsync_Then_ReturnMessages() - { - // Arrange - var messages = _fixture.CreateMany(10).ToList(); - var senderId =_fixture.Create(); - - foreach (var message in messages) - { - message.SenderId = senderId; - } - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.AddRange(messages); - await context.SaveChangesAsync(); - - // Act - var results = await messagesRepository.FindBySenderIdAsync(senderId); - - // Assert - Assert.That(results, Is.Not.Null); - Assert.That(results, Is.EquivalentTo(messages)); - } - - [Test] - public void Given_InvalidSenderId_When_FindBySenderId_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await messagesRepository.FindBySenderIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidReceiverId_When_FindByReceiverIdAsync_Then_ReturnMessages() - { - // Arrange - var messages = _fixture.CreateMany(10).ToList(); - var receiverId =_fixture.Create(); - - foreach (var message in messages) - { - message.RecipientId = receiverId; - } - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.AddRange(messages); - await context.SaveChangesAsync(); - - // Act - var results = await messagesRepository.FindByReceiverIdAsync(receiverId); - - // Assert - Assert.That(results, Is.Not.Null); - Assert.That(results, Is.EquivalentTo(messages)); - } - - [Test] - public void Given_InvalidReceiverId_When_FindByReceiverIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await messagesRepository.FindByReceiverIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidSenderIdReceiverIdAndReceiverType_When_FindBySenderAndReceiverIdAsync_Then_ReturnMessages() - { - // Arrange - var messages = _fixture.CreateMany(10).ToList(); - - var receiverId =_fixture.Create(); - var senderId =_fixture.Create(); - RecipientType recipientType =_fixture.Create(); - - foreach (var message in messages) - { - message.RecipientId = receiverId; - message.SenderId = senderId; - message.RecipientType = recipientType; - } - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.AddRange(messages); - await context.SaveChangesAsync(); - - // Act - var results = await messagesRepository.FindBySenderAndReceiverIdAsync(senderId, receiverId, recipientType); - - Assert.That(results, Is.Not.Null); - Assert.That(results, Is.EquivalentTo(messages)); - } - - [Test] - public async Task Given_InvalidSenderId_When_FindBySenderAndReceiverIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - var messages = _fixture.CreateMany(10).ToList(); - - var receiverId =_fixture.Create(); - var senderId =_fixture.Create(); - RecipientType recipientType =_fixture.Create(); - - foreach (var message in messages) - { - message.RecipientId = receiverId; - message.RecipientType = recipientType; - } - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.AddRange(messages); - await context.SaveChangesAsync(); - - // Act & Assert - Assert.ThrowsAsync(async () => await messagesRepository.FindBySenderAndReceiverIdAsync(senderId, receiverId, recipientType)); - } - - [Test] - public async Task Given_InvalidReceiverId_When_FindBySenderAndReceiverIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - var messages = _fixture.CreateMany(10).ToList(); - - var receiverId =_fixture.Create(); - var senderId =_fixture.Create(); - RecipientType recipientType =_fixture.Create(); - - foreach (var message in messages) - { - message.SenderId = senderId; - message.RecipientType = recipientType; - } - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.AddRange(messages); - await context.SaveChangesAsync(); - - // Act & Assert - Assert.ThrowsAsync(async () => await messagesRepository.FindBySenderAndReceiverIdAsync(senderId, receiverId, recipientType)); - } - - [Test] - public async Task Given_ValidDateTime_When_FindByValidDateTimeAsync_Then_ReturnMessages() - { - // Assert - var messages = _fixture.CreateMany(10).ToList(); - var dateTime = _fixture.Create(); - - foreach (var message in messages) - { - message.SentAt = dateTime; - } - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.AddRange(messages); - await context.SaveChangesAsync(); - - // Act - var results = await messagesRepository.FindBySentAtAsync(dateTime); - - // Assert - Assert.That(results, Is.Not.Null); - Assert.That(results, Is.EquivalentTo(messages)); - } - - [Test] - public async Task Given_ValidMessage_When_AddAsync_Then_MessageAdded() - { - // Arrange - var message = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - // Act - await messagesRepository.AddAsync(message); - - // Assert - Assert.That(context.Messages.Count, Is.EqualTo(1)); - Assert.That(context.Messages.First(), Is.EqualTo(message)); - } - - [Test] - public async Task Given_InvalidMessage_When_AddAsync_Should_Throw_AdditionException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - // Act & Assert - Assert.ThrowsAsync(async () => await messagesRepository.AddAsync(default)); - } - - [Test] - public async Task Given_ExistMessage_When_Exist_Then_ReturnTrue() - { - // Arrange - var message = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.Add(message); - await context.SaveChangesAsync(); - - // Act - var result = messagesRepository.Exist(message); - var result2 = messagesRepository.Exist(message.Id); - - // Assert - Assert.That(result, Is.True); - Assert.That(result2, Is.True); - } - - [Test] - public async Task Given_NotExistMessage_When_Exist_Then_ReturnFalse() - { - // Arrange - var message = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - // Act - var result = messagesRepository.Exist(message); - var result2 = messagesRepository.Exist(message.Id); - - // Assert - Assert.That(result, Is.False); - Assert.That(result2, Is.False); - } - - [Test] - public async Task Given_NotEqualMessage_When_Exist_Then_ReturnFalse() - { - // Arrange - var message = _fixture.Create(); - var message2 = _fixture.Create(); - message.Id = message2.Id; - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - context.Messages.Add(message); - await context.SaveChangesAsync(); - - // Act - var result = messagesRepository.Exist(message2); - - // Assert - Assert.That(result, Is.False); - } - - [Test] - public async Task Given_InvalidMessage_When_Exist_Should_Throw_InvalidObjectException() - { - // Arrange - var message = _fixture.Create(); - message.SentAt = DateTime.MinValue; - message.RecipientId = Guid.Empty; - - await using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - // Act & Assert - Assert.Throws>(() => messagesRepository.Exist(message)); - } - - [Test] - public void Given_NullMessage_When_Exist_Should_Throw_InvalidObjectException() - { - using var context = new GovorDbContext(_options); - var messagesRepository = new MessagesRepository(context, _messageValidator); - - // Act & Assert - Assert.Throws>(() => messagesRepository.Exist(default(Message))); - } -} \ No newline at end of file diff --git a/Govor.Data.Tests/Repositories/PrivateChatsRepositoryTests.cs b/Govor.Data.Tests/Repositories/PrivateChatsRepositoryTests.cs deleted file mode 100644 index 657232d..0000000 --- a/Govor.Data.Tests/Repositories/PrivateChatsRepositoryTests.cs +++ /dev/null @@ -1,203 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Validators; -using Govor.Domain.Models; -using Govor.Domain; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class PrivateChatsRepositoryTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private IObjectValidator _validator = new PrivateChatValidator(); - private int _testIteration = 0; - - [SetUp] - public void SetUp() - { - _testIteration += 1; - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(PrivateChatsRepositoryTests)}_{_testIteration}") - .Options; - } - - [Test] - public async Task Given_NotEmptySetDb_When_GetAll_Then_ReturnAll() - { - // Arrange - var random = new Random(); - var chats = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - context.PrivateChats.AddRange(chats); - await context.SaveChangesAsync(); - - // Act - - var result = await repository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(chats.Count)); - Assert.That(result, Is.EquivalentTo(chats)); - } - - [Test] - public void Given_EmptySetDb_When_GetAll_Should_Throw_NotFoundException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - // Act & Assert - Assert.ThrowsAsync(async () => await repository.GetAllAsync()); - } - - [Test] - public async Task Given_ValidChatId_When_GetById_Then_ReturnChat() - { - // Arrange - var chats = _fixture.CreateMany(10); - var id = chats.First().Id; - - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - context.PrivateChats.AddRange(chats); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetByIdAsync(id); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.EqualTo(chats.First())); - } - - [Test] - public async Task Given_InvalidMessageId_When_FindById_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_MembersId_When_GetByMembersAsync_Then_ReturnChat() - { - // Arrange - var chats = _fixture.CreateMany(10); - var id1 = chats.First().UserAId; - var id2 = chats.First().UserBId; - - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - context.PrivateChats.AddRange(chats); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetByMembersAsync(id1, id2); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.EqualTo(chats.First())); - } - - [Test] - public async Task Given_InvalidMembersId_When_GetByMembersAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByMembersAsync(_fixture.Create(), _fixture.Create())); - } - - [Test] - public async Task Given_ValidPrivateChat_When_AddAsync_Then_PrivateChatAdded() - { - // Arrange - var chat = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - // Act - await repository.AddAsync(chat); - - // Assert - Assert.That(context.PrivateChats.Count, Is.EqualTo(1)); - Assert.That(context.PrivateChats.First(), Is.EqualTo(chat)); - } - - [Test] - public async Task Given_InvalidPrivateChat_When_AddAsync_Should_Throw_AdditionException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.AddAsync(default)); - } - - [Test] - public async Task Given_ExistPrivateChat_When_Exist_Then_ReturnTrue() - { - // Arrange - var chat = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - context.PrivateChats.Add(chat); - await context.SaveChangesAsync(); - - // Act - var result1 = repository.Exist(chat.UserAId, chat.UserBId); - var result2 = repository.Exist(chat.Id); - - - // Assert - Assert.That(result1, Is.True); - Assert.That(result2, Is.True); - } - - [Test] - public async Task Given_NotExistPrivateChat_When_Exist_Then_ReturnFalse() - { - // Arrange - var chat = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new PrivateChatsRepository(context, _validator); - - // Act - var result1 = repository.Exist(chat.UserAId, chat.UserBId); - var result2 = repository.Exist(chat.Id); - - // Assert - Assert.That(result1, Is.False); - Assert.That(result2, Is.False); - } -} \ No newline at end of file diff --git a/Govor.Data.Tests/Repositories/PushTokenRepository.cs b/Govor.Data.Tests/Repositories/PushTokenRepository.cs deleted file mode 100644 index e590b7b..0000000 --- a/Govor.Data.Tests/Repositories/PushTokenRepository.cs +++ /dev/null @@ -1,233 +0,0 @@ -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class PushTokenRepositoryTests -{ - private GovorDbContext _context; - private PushTokenRepository _repository; - - [SetUp] - public void Setup() - { - var options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(Guid.NewGuid().ToString()) - .Options; - - _context = new GovorDbContext(options); - _repository = new PushTokenRepository(_context); - } - - [TearDown] - public void TearDown() - { - _context.Dispose(); - } - - #region GetActiveTokensAsync - - [Test] - public async Task GetActiveTokensAsync_ReturnsUserTokens() - { - var userId = Guid.NewGuid(); - - _context.UserPushTokens.Add(new UserPushToken - { - UserId = userId, - Token = "token1", - IsActive = true - }); - - await _context.SaveChangesAsync(); - - var result = await _repository.GetActiveTokensAsync(userId); - - Assert.That(result, Contains.Item("token1")); - } - - #endregion - - #region GetActiveTokensUsersAsync - - [Test] - public async Task GetActiveTokensUsersAsync_ReturnsDistinctActiveTokens() - { - var user1 = Guid.NewGuid(); - var user2 = Guid.NewGuid(); - - _context.UserPushTokens.AddRange( - new UserPushToken { UserId = user1, Token = "t1", IsActive = true }, - new UserPushToken { UserId = user2, Token = "t2", IsActive = true }, - new UserPushToken { UserId = user2, Token = "inactive", IsActive = false } - ); - - await _context.SaveChangesAsync(); - - var result = await _repository.GetActiveTokensUsersAsync([user1, user2, user1]); - - Assert.That(result.Count, Is.EqualTo(2)); - Assert.That(result, Does.Not.Contain("inactive")); - } - - [Test] - public async Task GetActiveTokensUsersAsync_EmptyInput_ReturnsEmpty() - { - var result = await _repository.GetActiveTokensUsersAsync([]); - - Assert.That(result, Is.Empty); - } - - #endregion - - #region GetActiveTokenBySessionAsync - - [Test] - public async Task GetActiveTokenBySessionAsync_ReturnsToken() - { - var sessionId = Guid.NewGuid(); - - _context.UserPushTokens.Add(new UserPushToken - { - UserSessionId = sessionId, - Token = "sessionToken", - IsActive = true - }); - - await _context.SaveChangesAsync(); - - var result = await _repository.GetActiveTokenBySessionAsync(sessionId); - - Assert.That(result, Is.EqualTo("sessionToken")); - } - - [Test] - public async Task GetActiveTokenBySessionAsync_EmptySession_ReturnsEmptyString() - { - var result = await _repository.GetActiveTokenBySessionAsync(Guid.Empty); - - Assert.That(result, Is.EqualTo("")); - } - - #endregion - - #region AddOrUpdateTokenAsync - - [Test] - public void AddOrUpdateTokenAsync_InvalidUserId_Throws() - { - Assert.ThrowsAsync(() => - _repository.AddOrUpdateTokenAsync(Guid.Empty, null, "token", "android")); - } - - [Test] - public void AddOrUpdateTokenAsync_EmptyToken_Throws() - { - Assert.ThrowsAsync(() => - _repository.AddOrUpdateTokenAsync(Guid.NewGuid(), null, "", "android")); - } - - [Test] - public async Task AddOrUpdateTokenAsync_AddsNewToken() - { - var userId = Guid.NewGuid(); - - await _repository.AddOrUpdateTokenAsync(userId, null, "newToken", "android"); - - var token = await _context.UserPushTokens.FirstOrDefaultAsync(); - - Assert.That(token, Is.Not.Null); - Assert.That(token!.UserId, Is.EqualTo(userId)); - Assert.That(token.IsActive, Is.True); - } - - [Test] - public async Task AddOrUpdateTokenAsync_UpdatesExistingToken() - { - var userId = Guid.NewGuid(); - - var existing = new UserPushToken - { - UserId = Guid.NewGuid(), - Token = "sameToken", - Platform = "ios", - IsActive = false - }; - - _context.UserPushTokens.Add(existing); - await _context.SaveChangesAsync(); - - await _repository.AddOrUpdateTokenAsync(userId, null, "sameToken", "android"); - - var updated = await _context.UserPushTokens.FirstAsync(); - - Assert.That(updated.UserId, Is.EqualTo(userId)); - Assert.That(updated.Platform, Is.EqualTo("android")); - Assert.That(updated.IsActive, Is.True); - } - - #endregion - - #region RemoveTokensAsync - - [Test] - public async Task RemoveTokensAsync_RemovesTokens() - { - _context.UserPushTokens.Add(new UserPushToken - { - Token = "t1", - UserId = Guid.NewGuid() - }); - - await _context.SaveChangesAsync(); - - await _repository.RemoveTokensAsync(["t1"]); - - Assert.That(_context.UserPushTokens.Count(), Is.EqualTo(0)); - } - - [Test] - public async Task RemoveTokensAsync_EmptyInput_DoesNothing() - { - await _repository.RemoveTokensAsync([]); - - Assert.Pass(); - } - - #endregion - - #region DeactivateTokenBySessionAsync - - [Test] - public async Task DeactivateTokenBySessionAsync_DeactivatesTokens() - { - var sessionId = Guid.NewGuid(); - - _context.UserPushTokens.Add(new UserPushToken - { - UserSessionId = sessionId, - Token = "t1", - IsActive = true - }); - - await _context.SaveChangesAsync(); - - await _repository.DeactivateTokenBySessionAsync(sessionId); - - var token = await _context.UserPushTokens.FirstAsync(); - - Assert.That(token.IsActive, Is.False); - } - - [Test] - public async Task DeactivateTokenBySessionAsync_EmptySession_DoesNothing() - { - await _repository.DeactivateTokenBySessionAsync(Guid.Empty); - - Assert.Pass(); - } - - #endregion -} \ No newline at end of file diff --git a/Govor.Data.Tests/Repositories/UserSessionsRepositoryTests.cs b/Govor.Data.Tests/Repositories/UserSessionsRepositoryTests.cs deleted file mode 100644 index 4006783..0000000 --- a/Govor.Data.Tests/Repositories/UserSessionsRepositoryTests.cs +++ /dev/null @@ -1,310 +0,0 @@ -using AutoFixture; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class UserSessionsRepositoryTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private int _testIteration = 0; - - [SetUp] - public void SetUp() - { - _testIteration += 1; - - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(UserSessionsRepositoryTests)}_{_testIteration}") - .Options; - } - - [Test] - public async Task GetAllSessions_ReturnsAllSessions() - { - // Arrange - var random = new Random(); - var sessions = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - context.UserSessions.AddRange(sessions); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(sessions.Count)); - Assert.That(result, Is.EquivalentTo(sessions)); - } - - [Test] - public void Given_EmptySetDb_When_GetAll_Should_Throw_NotFoundException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - // Act & Assert - Assert.ThrowsAsync(async () => await repository.GetAllAsync()); - } - - [Test] - public async Task Given_ValidId_When_GetByIdAsync_ShouldReturnSession() - { - // Arrange - var random = new Random(); - var sessions = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - var id = sessions.First().Id; - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - context.UserSessions.AddRange(sessions); - await context.SaveChangesAsync(); - // Act - var result = await repository.GetByIdAsync(id); - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Id, Is.EqualTo(id)); - Assert.That(result, Is.EqualTo(sessions.First())); - } - - [Test] - public void Given_InvalidId_When_GetByIdAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByIdAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidCreatedAt_When_GetByCreatedAtAsync_ShouldReturnSession() - { - // Arrange - var random = new Random(); - var sessions = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - var created = sessions.First().CreatedAt; - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - context.UserSessions.AddRange(sessions); - await context.SaveChangesAsync(); - - // Act - var list = await repository.GetByCreatedAtAsync(created); - - - // Assert - var result = list.First(); - Assert.That(result, Is.Not.Null); - Assert.That(result.CreatedAt, Is.EqualTo(created)); - Assert.That(result, Is.EqualTo(sessions.First())); - } - - [Test] - public void Given_ValidCreatedAt_When_GetByCreatedAtAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByCreatedAtAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidExpiresAt_When_GetByExpiresAtAsync_ShouldReturnSession() - { - // Arrange - var random = new Random(); - var sessions = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - var expiresAt = sessions.First().ExpiresAt; - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - context.UserSessions.AddRange(sessions); - await context.SaveChangesAsync(); - - // Act - var list = await repository.GetByExpiresAtAsync(expiresAt); - - // Assert - var result = list.First(); - Assert.That(result, Is.Not.Null); - Assert.That(result.ExpiresAt, Is.EqualTo(expiresAt)); - Assert.That(result, Is.EqualTo(sessions.First())); - } - - [Test] - public void Given_ValidExpiresAt_When_GetByExpiresAtAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByExpiresAtAsync(_fixture.Create())); - } - - [Test] - public async Task Given_isRevoked_When_GetByRevokedAsync_ShouldReturnSession() - { - // Arrange - var random = new Random(); - var sessions = _fixture.Build() - .With(f => f.IsRevoked, true) - .CreateMany(random.Next(2, 10)).ToList(); - - var isRevoke = sessions.First().IsRevoked; - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - context.UserSessions.AddRange(sessions); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetByRevokedAsync(isRevoke); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.EquivalentTo(sessions)); - } - - [Test] - public void Given_InvalidRevoked_When_GetByExpiresAtAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByRevokedAsync(false)); - } - - [Test] - public async Task Given_ValidRefreshToken_When_GetByRefreshTokenAsync_ShouldReturnSession() - { - // Arrange - var random = new Random(); - var sessions = _fixture.Build() - .With(f => f.IsRevoked, true) - .CreateMany(random.Next(2, 10)).ToList(); - - var token = sessions.First().RefreshTokenHash; - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - context.UserSessions.AddRange(sessions); - await context.SaveChangesAsync(); - - // Act - var result = await repository.GetByHashedRefreshTokenAsync(token); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result, Is.EqualTo(sessions.First())); - } - - [Test] - public void Given_InvalidRefreshToken_When_GetByRefreshTokenAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - // Act & Assert - Assert.ThrowsAsync>(async () => await repository.GetByHashedRefreshTokenAsync(_fixture.Create())); - } - - [Test] - public async Task Given_ValidUserSessions_When_AddAsync_Then_UserSessionsAdded() - { - // Arrange - var session = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - // Act - await repository.AddAsync(session); - - // Assert - Assert.That(context.UserSessions.Count, Is.EqualTo(1)); - Assert.That(context.UserSessions.First(), Is.EqualTo(session)); - } - - [Test] - public async Task Given_InvalidUserSessions_When_AddAsync_Should_Throw_AdditionException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - // Act & Assert - Assert.ThrowsAsync(async () => await repository.AddAsync(default)); - } - - [Test] - public async Task Given_ExistUserSessions_When_Exist_Then_ReturnTrue() - { - // Arrange - var session = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - context.UserSessions.Add(session); - await context.SaveChangesAsync(); - - // Act - var result1 = repository.Exist(session); - var result2 = repository.Exist(session.Id); - var result3 = repository.Exist(session.RefreshTokenHash); - - // Assert - Assert.That(result1, Is.True); - Assert.That(result2, Is.True); - Assert.That(result3, Is.True); - } - - [Test] - public async Task Given_NotExistUserSessions_When_Exist_Then_ReturnFalse() - { - // Arrange - var session = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var repository = new UserSessionsRepository(context); - - // Act - var result1 = repository.Exist(session); - var result2 = repository.Exist(session.Id); - var result3 = repository.Exist(session.RefreshTokenHash); - // Assert - Assert.That(result1, Is.False); - Assert.That(result2, Is.False); - Assert.That(result3, Is.False); - } -} \ No newline at end of file diff --git a/Govor.Data.Tests/Repositories/UsersRepositoryTests.cs b/Govor.Data.Tests/Repositories/UsersRepositoryTests.cs deleted file mode 100644 index 65d0910..0000000 --- a/Govor.Data.Tests/Repositories/UsersRepositoryTests.cs +++ /dev/null @@ -1,425 +0,0 @@ -using AutoFixture; -using Govor.Domain.Infrastructure.Validators; -using Govor.Domain.Models; -using Govor.Domain.Models.Users; -using Govor.Domain; -using Govor.Domain.Repositories; -using Govor.Domain.Repositories.Exceptions; -using Microsoft.EntityFrameworkCore; - -namespace Govor.Domain.Tests.Repositories; - -[TestFixture] -public class UsersRepositoryTests -{ - private Fixture _fixture; - private DbContextOptions _options; - private readonly IObjectValidator _userValidator = new UserValidator(); - - [SetUp] - public void SetUp() - { - _fixture = new Fixture(); - - _fixture.Behaviors - .OfType() - .ToList() - .ForEach(b => _fixture.Behaviors.Remove(b)); - - _fixture.Behaviors.Add(new OmitOnRecursionBehavior()); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: "DbGovor") - .Options; - } - - [Test] - public async Task GetAll_Then_Returns_All_Users() - { - // Arrange - var random = new Random(); - var users = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - _options = new DbContextOptionsBuilder() - .UseInMemoryDatabase(databaseName: "DbGovor_users_getall") - .Options; - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.AddRange(users); - await context.SaveChangesAsync(); - - // Act - - var result = await userRepository.GetAllAsync(); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(users.Count)); - Assert.That(result.Select(u => u.Id), Is.EquivalentTo(users.Select(u => u.Id))); - Assert.That(result.Select(u => u.Username), Is.EquivalentTo(users.Select(u => u.Username))); - } - - [Test] - public async Task Given_ValidUserId_When_FindById_Then_Returns_User() - { - // Arrange - var user = _fixture.Create(); - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.Add(user); - await context.SaveChangesAsync(); - - // Act - var result = await userRepository.FindByIdAsync(user.Id); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Username, Is.EqualTo(user.Username)); - Assert.That(result.Id, Is.EqualTo(user.Id)); - } - - [Test] - public async Task Given_InvalidUserId_When_FindById_Should_Throw_NotFoundException() - { - // Arrange - var id = Guid.NewGuid(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await userRepository.FindByIdAsync(id)); - } - - [Test] - public async Task Given_RangeValidUserId_When_FindByRangeId_Then_Returns_Users() - { - // Arrange - var random = new Random(); - var users = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.AddRange(users); - await context.SaveChangesAsync(); - - // Act - var result = await userRepository.FindByRangeIdAsync(users.Select(u => u.Id)); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(users.Count)); - Assert.That(result.Select(r => r.Id), Is.EquivalentTo(users.Select(u => u.Id))); - Assert.That(result.Select(u => u.Username), Is.EquivalentTo(users.Select(u => u.Username))); - } - - [Test] - public async Task Given_InvalidRangeId_When_FindByRangeId_Should_Throw_NotFoundException() - { - // Arrange - var random = new Random(); - var ids = _fixture.CreateMany(random.Next(2, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - // Act & Assert - Assert.ThrowsAsync>>(async () => - await userRepository.FindByRangeIdAsync(ids)); - } - - [Test] - public async Task Given_ValidUsername_When_FindByUsername_Then_Returns_User() - { - // Arrange - var user = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.Add(user); - await context.SaveChangesAsync(); - - // Act - var result = await userRepository.FindByUsernameAsync(user.Username); - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Username, Is.EqualTo(user.Username)); - Assert.That(result.Id, Is.EqualTo(user.Id)); - } - - [Test] - public async Task Given_InvalidUsername_When_FindByUsername_Should_Throw_NotFoundByKeyException() - { - // Arrange - string username = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - // Act & Assert - - Assert.ThrowsAsync>(async () => await userRepository.FindByUsernameAsync(username)); - } - - [Test] - public async Task Given_ValidUsernames_When_FindByRangeUsernames_Then_Returns_Users() - { - // Arrange - var random = new Random(); - var users = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.AddRange(users); - await context.SaveChangesAsync(); - - // Act - var result = await userRepository.FindByRangeUsernamesAsync(users.Select(u => u.Username)); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Select(u => u.Username), Is.EquivalentTo(users.Select(u => u.Username))); - Assert.That(result.Select(u => u.Id), Is.EquivalentTo(users.Select(u => u.Id))); - } - - [Test] - public async Task Given_InvalidUsernames_When_FindByRangeUsernames_Should_Throw_NotFoundByKeyException() - { - // Arrange - var random = new Random(); - var usernames = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - // Act & Assert - Assert.ThrowsAsync>>(async () => - await userRepository.FindByRangeUsernamesAsync(usernames)); - } - - [Test] - public async Task Given_ValidQuery_When_SearchPotentialFriendsAsync_Then_Returns_Users() - { - // Arrange - var random = new Random(); - var users = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.AddRange(users); - await context.SaveChangesAsync(); - - // Act - var result = await userRepository.SearchPotentialFriendsAsync(users[1].Id, users[0].Username[..15]); - - // Assert - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(1)); - Assert.That(result.First().Id, Is.EqualTo(users[0].Id)); - } - - [Test] - public async Task Given_InvalidQuery_When_SearchPotentialFriendsAsync_Should_Throw_NotFoundByKeyException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - // Act & Assert - Assert.ThrowsAsync>(async () => await - userRepository.SearchPotentialFriendsAsync(_fixture.Create(), _fixture.Create())); - } - - [Test] - public async Task Given_ValidDateOnly_When_FindByCreatedDate_Then_Returns_Users() - { - // Arrange - var random = new Random(); - var users = _fixture.CreateMany(random.Next(3, 10)).ToList(); - - var selectedDate = users[random.Next(users.Count)].CreatedOn; - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.AddRange(users); - await context.SaveChangesAsync(); - - // Act - var result = await userRepository.FindUsersByCreatedDateAsync(selectedDate); - - // Assert - var expectedUsers = users - .Where(u => u.CreatedOn == selectedDate) - .ToList(); - - Assert.That(result, Is.Not.Null); - Assert.That(result.Count, Is.EqualTo(expectedUsers.Count)); - Assert.That(result.Select(u => u.Id), Is.EquivalentTo(expectedUsers.Select(u => u.Id))); - } - - [Test] - public async Task Given_InvalidDateOnly_When_FindByCreatedDate_Should_Throw_NotFoundByKeyException() - { - // Arrange - var date = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - // Act & Assert - Assert.ThrowsAsync>(async () => - await userRepository.FindUsersByCreatedDateAsync(date)); - } - - [Test] - public async Task Given_ValidUser_When_AddUser_Then_CreateUser() - { - var user = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - // Act - userRepository.AddAsync(user); - var res = context.Users.Find(user.Id); - - // Assert - - Assert.That(res, Is.Not.Null); - Assert.That(res.Username, Is.EqualTo(user.Username)); - Assert.That(res.Id, Is.EqualTo(user.Id)); - } - - [Test] - public async Task Given_InvalidUser_When_AddUser_Should_Throw_AdditionUserException() - { - var user = _fixture.Create(); - user.Username = string.Empty; - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - // Act & Assert - Assert.ThrowsAsync(async () => await userRepository.AddAsync(user)); - } - - [Test] - public async Task Given_ValidUser_When_ExistUser_Then_True() - { - // Arrange - var user = _fixture.Create(); - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.Add(user); - await context.SaveChangesAsync(); - - // Act - var res = await userRepository.ExistsAsync(user); - - // Assert - Assert.That(res, Is.True); - } - [Test] - public async Task Given_ValidUserButNotInDB_When_ExistUser_Then_False() - { - // Arrange - var user = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - - // Act - var res = await userRepository.ExistsAsync(user); - - // Assert - Assert.That(res, Is.False); - } - - [Test] - public async Task Given_InvalidUser_When_ExistUser_Should_Throw_InvalidObjectException() - { - // Arrange - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - // Act & Assert - Assert.ThrowsAsync>(async () => await userRepository.ExistsAsync(default)); - } - - [Test] - public async Task Given_ValidUserId_When_ExistUserById_Then_True() - { - // Arrange - var user = _fixture.Create(); - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.Add(user); - await context.SaveChangesAsync(); - - // Act - var res = await userRepository.ExistsByIdAsync(user.Id); - - // Assert - Assert.That(res, Is.True); - } - [Test] - public async Task Given_ValidUserIdButNotInDB_When_ExistUser_Then_False() - { - // Arrange - var user = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - - // Act - var res = await userRepository.ExistsByIdAsync(user.Id); - - // Assert - Assert.That(res, Is.False); - } - - [Test] - public async Task Given_ValidUsername_When_ExistUserById_Then_True() - { - // Arrange - var user = _fixture.Create(); - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - context.Users.Add(user); - await context.SaveChangesAsync(); - - // Act - var res = await userRepository.ExistsUsernameAsync(user.Username); - - // Assert - Assert.That(res, Is.True); - } - - [Test] - public async Task Given_ValidUsernameButNotInDB_When_ExistUser_Then_False() - { - // Arrange - var user = _fixture.Create(); - - await using var context = new GovorDbContext(_options); - var userRepository = new UsersRepository(context, _userValidator); - - - // Act - var res = await userRepository.ExistsUsernameAsync(user.Username); - - // Assert - Assert.That(res, Is.False); - } -} \ No newline at end of file diff --git a/Govor.Server.slnx b/Govor.Server.slnx index c6a0796..5c81e99 100644 --- a/Govor.Server.slnx +++ b/Govor.Server.slnx @@ -3,5 +3,10 @@ - + + + + + + diff --git a/Govor.sln b/Govor.sln index fbf82f2..9d1ec10 100644 --- a/Govor.sln +++ b/Govor.sln @@ -1,7 +1,5 @@ - + Microsoft Visual Studio Solution File, Format Version 12.00 -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.API.Tests", "Govor.API.Tests\Govor.API.Tests.csproj", "{15031CBD-F319-4755-BA91-B86F20BD8E37}" -EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.API", "Govor.API\Govor.API.csproj", "{EA8F272F-4276-438A-9DEA-C58860A440AE}" EndProject Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4}" @@ -15,67 +13,134 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.Contracts", "Govor.Co EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.Application", "Govor.Application\Govor.Application.csproj", "{FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}" EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.Application.Tests", "Govor.Application.Tests\Govor.Application.Tests.csproj", "{F56A64DF-2938-4BE0-83F2-B86429F19259}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.Data.Tests", "Govor.Data.Tests\Govor.Data.Tests.csproj", "{CF6B23EC-932A-4998-BA95-C94CAB7B092C}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.ConsoleClient.Tests", "Govor.ConsoleClient.Tests\Govor.ConsoleClient.Tests.csproj", "{B1E79EB6-DBD3-4E82-AB6D-DCFCE6533965}" -EndProject Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.Domain", "Govor.Domain\Govor.Domain.csproj", "{868EAA88-A8E8-4508-B264-1AE3576D47C1}" EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SmartRes", "..\SmartRes\SmartRes\SmartRes.csproj", "{3AB1DEB2-131B-476F-B4B7-7F8F5479D2FC}" +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.Server.Tests", "tests\Govor.Server.Tests\Govor.Server.Tests.csproj", "{C2BF62C6-D88C-443B-A698-AECEF314DCE0}" +EndProject +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.API.Tests", "tests\Govor.API.Tests\Govor.API.Tests.csproj", "{A2D7FE0B-7E2D-425C-BB68-731F9C412C83}" +EndProject +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.Application.Tests", "tests\Govor.Application.Tests\Govor.Application.Tests.csproj", "{6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}" +EndProject +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Govor.Domain.Tests", "tests\Govor.Domain.Tests\Govor.Domain.Tests.csproj", "{D54B34C6-DD49-4963-AF97-50617918134D}" EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|Any CPU = Debug|Any CPU + Debug|x64 = Debug|x64 + Debug|x86 = Debug|x86 Release|Any CPU = Release|Any CPU + Release|x64 = Release|x64 + Release|x86 = Release|x86 EndGlobalSection GlobalSection(ProjectConfigurationPlatforms) = postSolution - {15031CBD-F319-4755-BA91-B86F20BD8E37}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {15031CBD-F319-4755-BA91-B86F20BD8E37}.Debug|Any CPU.Build.0 = Debug|Any CPU - {15031CBD-F319-4755-BA91-B86F20BD8E37}.Release|Any CPU.ActiveCfg = Release|Any CPU - {15031CBD-F319-4755-BA91-B86F20BD8E37}.Release|Any CPU.Build.0 = Release|Any CPU {EA8F272F-4276-438A-9DEA-C58860A440AE}.Debug|Any CPU.ActiveCfg = Debug|Any CPU {EA8F272F-4276-438A-9DEA-C58860A440AE}.Debug|Any CPU.Build.0 = Debug|Any CPU + {EA8F272F-4276-438A-9DEA-C58860A440AE}.Debug|x64.ActiveCfg = Debug|Any CPU + {EA8F272F-4276-438A-9DEA-C58860A440AE}.Debug|x64.Build.0 = Debug|Any CPU + {EA8F272F-4276-438A-9DEA-C58860A440AE}.Debug|x86.ActiveCfg = Debug|Any CPU + {EA8F272F-4276-438A-9DEA-C58860A440AE}.Debug|x86.Build.0 = Debug|Any CPU {EA8F272F-4276-438A-9DEA-C58860A440AE}.Release|Any CPU.ActiveCfg = Release|Any CPU {EA8F272F-4276-438A-9DEA-C58860A440AE}.Release|Any CPU.Build.0 = Release|Any CPU + {EA8F272F-4276-438A-9DEA-C58860A440AE}.Release|x64.ActiveCfg = Release|Any CPU + {EA8F272F-4276-438A-9DEA-C58860A440AE}.Release|x64.Build.0 = Release|Any CPU + {EA8F272F-4276-438A-9DEA-C58860A440AE}.Release|x86.ActiveCfg = Release|Any CPU + {EA8F272F-4276-438A-9DEA-C58860A440AE}.Release|x86.Build.0 = Release|Any CPU {4E94907F-BE20-42A6-AB15-637850FEAD11}.Debug|Any CPU.ActiveCfg = Debug|Any CPU {4E94907F-BE20-42A6-AB15-637850FEAD11}.Debug|Any CPU.Build.0 = Debug|Any CPU + {4E94907F-BE20-42A6-AB15-637850FEAD11}.Debug|x64.ActiveCfg = Debug|Any CPU + {4E94907F-BE20-42A6-AB15-637850FEAD11}.Debug|x64.Build.0 = Debug|Any CPU + {4E94907F-BE20-42A6-AB15-637850FEAD11}.Debug|x86.ActiveCfg = Debug|Any CPU + {4E94907F-BE20-42A6-AB15-637850FEAD11}.Debug|x86.Build.0 = Debug|Any CPU {4E94907F-BE20-42A6-AB15-637850FEAD11}.Release|Any CPU.ActiveCfg = Release|Any CPU {4E94907F-BE20-42A6-AB15-637850FEAD11}.Release|Any CPU.Build.0 = Release|Any CPU + {4E94907F-BE20-42A6-AB15-637850FEAD11}.Release|x64.ActiveCfg = Release|Any CPU + {4E94907F-BE20-42A6-AB15-637850FEAD11}.Release|x64.Build.0 = Release|Any CPU + {4E94907F-BE20-42A6-AB15-637850FEAD11}.Release|x86.ActiveCfg = Release|Any CPU + {4E94907F-BE20-42A6-AB15-637850FEAD11}.Release|x86.Build.0 = Release|Any CPU {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Debug|Any CPU.Build.0 = Debug|Any CPU + {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Debug|x64.ActiveCfg = Debug|Any CPU + {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Debug|x64.Build.0 = Debug|Any CPU + {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Debug|x86.ActiveCfg = Debug|Any CPU + {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Debug|x86.Build.0 = Debug|Any CPU {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Release|Any CPU.ActiveCfg = Release|Any CPU {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Release|Any CPU.Build.0 = Release|Any CPU - {F56A64DF-2938-4BE0-83F2-B86429F19259}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {F56A64DF-2938-4BE0-83F2-B86429F19259}.Debug|Any CPU.Build.0 = Debug|Any CPU - {F56A64DF-2938-4BE0-83F2-B86429F19259}.Release|Any CPU.ActiveCfg = Release|Any CPU - {F56A64DF-2938-4BE0-83F2-B86429F19259}.Release|Any CPU.Build.0 = Release|Any CPU - {CF6B23EC-932A-4998-BA95-C94CAB7B092C}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {CF6B23EC-932A-4998-BA95-C94CAB7B092C}.Debug|Any CPU.Build.0 = Debug|Any CPU - {CF6B23EC-932A-4998-BA95-C94CAB7B092C}.Release|Any CPU.ActiveCfg = Release|Any CPU - {CF6B23EC-932A-4998-BA95-C94CAB7B092C}.Release|Any CPU.Build.0 = Release|Any CPU - {B1E79EB6-DBD3-4E82-AB6D-DCFCE6533965}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {B1E79EB6-DBD3-4E82-AB6D-DCFCE6533965}.Debug|Any CPU.Build.0 = Debug|Any CPU - {B1E79EB6-DBD3-4E82-AB6D-DCFCE6533965}.Release|Any CPU.ActiveCfg = Release|Any CPU - {B1E79EB6-DBD3-4E82-AB6D-DCFCE6533965}.Release|Any CPU.Build.0 = Release|Any CPU + {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Release|x64.ActiveCfg = Release|Any CPU + {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Release|x64.Build.0 = Release|Any CPU + {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Release|x86.ActiveCfg = Release|Any CPU + {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E}.Release|x86.Build.0 = Release|Any CPU {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Debug|Any CPU.Build.0 = Debug|Any CPU + {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Debug|x64.ActiveCfg = Debug|Any CPU + {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Debug|x64.Build.0 = Debug|Any CPU + {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Debug|x86.ActiveCfg = Debug|Any CPU + {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Debug|x86.Build.0 = Debug|Any CPU {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Release|Any CPU.ActiveCfg = Release|Any CPU {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Release|Any CPU.Build.0 = Release|Any CPU - {3AB1DEB2-131B-476F-B4B7-7F8F5479D2FC}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {3AB1DEB2-131B-476F-B4B7-7F8F5479D2FC}.Debug|Any CPU.Build.0 = Debug|Any CPU - {3AB1DEB2-131B-476F-B4B7-7F8F5479D2FC}.Release|Any CPU.ActiveCfg = Release|Any CPU - {3AB1DEB2-131B-476F-B4B7-7F8F5479D2FC}.Release|Any CPU.Build.0 = Release|Any CPU + {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Release|x64.ActiveCfg = Release|Any CPU + {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Release|x64.Build.0 = Release|Any CPU + {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Release|x86.ActiveCfg = Release|Any CPU + {868EAA88-A8E8-4508-B264-1AE3576D47C1}.Release|x86.Build.0 = Release|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Debug|Any CPU.Build.0 = Debug|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Debug|x64.ActiveCfg = Debug|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Debug|x64.Build.0 = Debug|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Debug|x86.ActiveCfg = Debug|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Debug|x86.Build.0 = Debug|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Release|Any CPU.ActiveCfg = Release|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Release|Any CPU.Build.0 = Release|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Release|x64.ActiveCfg = Release|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Release|x64.Build.0 = Release|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Release|x86.ActiveCfg = Release|Any CPU + {C2BF62C6-D88C-443B-A698-AECEF314DCE0}.Release|x86.Build.0 = Release|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Debug|Any CPU.Build.0 = Debug|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Debug|x64.ActiveCfg = Debug|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Debug|x64.Build.0 = Debug|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Debug|x86.ActiveCfg = Debug|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Debug|x86.Build.0 = Debug|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Release|Any CPU.ActiveCfg = Release|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Release|Any CPU.Build.0 = Release|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Release|x64.ActiveCfg = Release|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Release|x64.Build.0 = Release|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Release|x86.ActiveCfg = Release|Any CPU + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83}.Release|x86.Build.0 = Release|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Debug|Any CPU.Build.0 = Debug|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Debug|x64.ActiveCfg = Debug|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Debug|x64.Build.0 = Debug|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Debug|x86.ActiveCfg = Debug|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Debug|x86.Build.0 = Debug|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Release|Any CPU.ActiveCfg = Release|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Release|Any CPU.Build.0 = Release|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Release|x64.ActiveCfg = Release|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Release|x64.Build.0 = Release|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Release|x86.ActiveCfg = Release|Any CPU + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643}.Release|x86.Build.0 = Release|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Debug|Any CPU.Build.0 = Debug|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Debug|x64.ActiveCfg = Debug|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Debug|x64.Build.0 = Debug|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Debug|x86.ActiveCfg = Debug|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Debug|x86.Build.0 = Debug|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Release|Any CPU.ActiveCfg = Release|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Release|Any CPU.Build.0 = Release|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Release|x64.ActiveCfg = Release|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Release|x64.Build.0 = Release|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Release|x86.ActiveCfg = Release|Any CPU + {D54B34C6-DD49-4963-AF97-50617918134D}.Release|x86.Build.0 = Release|Any CPU + EndGlobalSection + GlobalSection(SolutionProperties) = preSolution + HideSolutionNode = FALSE EndGlobalSection GlobalSection(NestedProjects) = preSolution - {15031CBD-F319-4755-BA91-B86F20BD8E37} = {4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4} {EA8F272F-4276-438A-9DEA-C58860A440AE} = {114F53C1-B0AB-4BA0-9E36-0E811D1B3776} {4E94907F-BE20-42A6-AB15-637850FEAD11} = {114F53C1-B0AB-4BA0-9E36-0E811D1B3776} {FC5EDCA8-FD58-4078-8FB1-2BDBB2F6CA3E} = {114F53C1-B0AB-4BA0-9E36-0E811D1B3776} - {F56A64DF-2938-4BE0-83F2-B86429F19259} = {4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4} - {CF6B23EC-932A-4998-BA95-C94CAB7B092C} = {4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4} - {B1E79EB6-DBD3-4E82-AB6D-DCFCE6533965} = {4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4} {868EAA88-A8E8-4508-B264-1AE3576D47C1} = {114F53C1-B0AB-4BA0-9E36-0E811D1B3776} + {C2BF62C6-D88C-443B-A698-AECEF314DCE0} = {4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4} + {A2D7FE0B-7E2D-425C-BB68-731F9C412C83} = {4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4} + {6A736FA3-CAC5-44AE-8E17-C2C4F2EB6643} = {4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4} + {D54B34C6-DD49-4963-AF97-50617918134D} = {4ED5259A-6FB4-4D89-8E6B-4778DC68F7D4} EndGlobalSection EndGlobal diff --git a/README.md b/README.md index 99686f9..8f63246 100644 --- a/README.md +++ b/README.md @@ -22,3 +22,9 @@ This is my school project that I'm working on in my free time to level up my bac dock: https://nas-3.gitbook.io/govor-api Deployment: [Timeweb VPS + GitHub Actions](docs/vps-deployment.md) · [Timeweb App Platform](docs/timeweb-deployment.md). + +## Server tests + +Run all current server tests with `dotnet test Govor.Server.slnx -c Release`. +See [tests/README.md](tests/README.md) for the project layout, PostgreSQL setup, +coverage commands and validation limits. diff --git a/docs/diagnostics.md b/docs/diagnostics.md index 958996c..5473b23 100644 --- a/docs/diagnostics.md +++ b/docs/diagnostics.md @@ -4,7 +4,7 @@ Проверен master Govor-team/Govor, commit 4603be9f714135e0af72d505d17f3d1709834bea (GitHub и локальный checkout совпали). Изучены контроллеры, хабы, сервисы, DTO, EF-модели, DI, запуск и часть MAUI-интеграции. Старый опубликованный GitBook оставался на ревизии 18.12.2025 и расходился с кодом. -Сборка API на SDK 10.0.400 успешна: первая сборка 90 предупреждений, 0 ошибок. Restore Govor.API.Tests неуспешен: NU1201, net8.0 → net10.0. Тесты не выполнены; утверждать, что они проходят, нельзя. Производственный сервер, БД, Firebase, Docker и UI на устройствах не проверялись. +При исходной диагностике сборка API на SDK 10.0.400 прошла с 90 предупреждениями, но тесты .NET 8 не восстанавливались из-за NU1201. Обновление 24.10.2026: серверные тесты перенесены в `tests`, обновлены до .NET 10; Release-сборка и 710 тестов проходят на SQLite и изолированной PostgreSQL. Покрытие Application: 98,88% строк и 93,53% ветвей. Инструкции и ограничения проверки — в [tests/README.md](../tests/README.md). Production, Firebase и UI на устройствах не проверялись. Ниже «подтверждено» означает выявлено по конкретному коду или диагностике сборки, а не воспроизведено атакой на живой сервис. diff --git a/docs/e2ee.md b/docs/e2ee.md index 63bb423..ffc7d05 100644 --- a/docs/e2ee.md +++ b/docs/e2ee.md @@ -122,7 +122,7 @@ SecureStorage или потери устройства зашифрованна ## Проверка ```powershell -dotnet test Govor.Server.Tests/Govor.Server.Tests.csproj +dotnet test tests/Govor.Server.Tests/Govor.Server.Tests.csproj # В мобильном репозитории: dotnet test Govor.Mobile.Tests/Govor.Mobile.Tests.csproj dotnet build Govor.Mobile/Govor.Mobile.csproj -f net10.0-android -p:TargetFrameworks=net10.0-android diff --git a/docs/endpoints/groups.md b/docs/endpoints/groups.md index 97653a5..432a584 100644 --- a/docs/endpoints/groups.md +++ b/docs/endpoints/groups.md @@ -146,7 +146,7 @@ GET `/api/admin/required-channel` возвращает channelId и allowLeave. ```powershell dotnet ef database update --project Govor.Domain --startup-project Govor.API -dotnet test Govor.Server.Tests/Govor.Server.Tests.csproj -c Release +dotnet test tests/Govor.Server.Tests/Govor.Server.Tests.csproj -c Release ``` Миграция `20261003131521_PrimitiveGroupsAndRequiredChannel` добавляет владельца, время создания, настройки сервера, лимиты/отзыв ссылок и уникальные индексы членства/админов/кодов. Старые дубли членства объединяются с сохранением бана; удаляются ссылки на отсутствующих пользователей и роли неактивных участников. Неоднозначные старые коды приглашений отзываются. Известное использование старых ссылок восстанавливается по сохранённым членствам; сведения о ранее вышедших пользователях в старой модели отсутствовали. diff --git a/docs/endpoints/push.md b/docs/endpoints/push.md index e4d707f..01d7f04 100644 --- a/docs/endpoints/push.md +++ b/docs/endpoints/push.md @@ -50,6 +50,6 @@ Изменения не требуют новой миграции; в БД должна быть применена существующая `20261003070406_ReliableChatPush`. -Проверка: `dotnet test Govor.Server.Tests/Govor.Server.Tests.csproj`. Тесты проверяют HTTP API, SQL-очередь/аренду/retry, обработку ошибок и реальную сериализацию Firebase SDK через подменённый HTTP-транспорт. Для PostgreSQL предусмотрена `TEST_POSTGRES_CONNECTION` на отдельную БД с именем, заканчивающимся `_tests`. Эти тесты не подтверждают доставку на физическое устройство. +Проверка: `dotnet test tests/Govor.Server.Tests/Govor.Server.Tests.csproj`. Тесты проверяют HTTP API, SQL-очередь/аренду/retry, обработку ошибок и реальную сериализацию Firebase SDK через подменённый HTTP-транспорт. Для PostgreSQL предусмотрена `TEST_POSTGRES_CONNECTION` на отдельную БД с именем, заканчивающимся `_tests`. Эти тесты не подтверждают доставку на физическое устройство. Лимит пакета и классификация ошибок сверены с [документацией отправки FCM](https://firebase.google.com/docs/cloud-messaging/send/admin-sdk) и [кодами ошибок FCM](https://firebase.google.com/docs/cloud-messaging/error-codes). diff --git a/docs/endpoints/reactions.md b/docs/endpoints/reactions.md index 70c99d0..ec7cbbf 100644 --- a/docs/endpoints/reactions.md +++ b/docs/endpoints/reactions.md @@ -127,7 +127,7 @@ mode: All=0 — все активные реакции; None=1 — новые р ```powershell dotnet ef database update --project Govor.Domain --startup-project Govor.API -dotnet test Govor.Server.Tests/Govor.Server.Tests.csproj -c Release +dotnet test tests/Govor.Server.Tests/Govor.Server.Tests.csproj -c Release ``` Миграция `20261003101700_ReactionPacksAndChannelPolicies` создаёт каталог, установки, разрешения канала, версии и базовый пак; старые реакции сохраняются. Она подготовлена, но к вашей рабочей БД автоматически не применялась. Локальные тесты используют SQLite и HTTP pipeline с JWT; SignalR-доставка проверяется через mock транспорта. CI также настроен на PostgreSQL. Реальные устройства/сокеты и PostgreSQL локально не проверены. diff --git a/docs/getting-started.md b/docs/getting-started.md index 8123f6f..fbd32b2 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -47,10 +47,9 @@ Swagger включён во всех окружениях. UseSwagger обслу ## Что проверено -Restore API-зависимостей и сборка API завершились. Первая сборка: 90 предупреждений, 0 ошибок. Restore Govor.API.Tests завершился NU1201: net8.0 не может ссылаться на net10.0. Сервер с БД и Firebase не запускался; контейнер и миграции не проверялись. +Обновление 24.10.2026: серверные тесты обновлены до .NET 10 и находятся в `tests`. `dotnet test Govor.Server.slnx -c Release` запускает все четыре проекта. Release-сборка и 710 тестов проходят на SQLite и отдельной PostgreSQL с применением миграций. Инструкции и ограничения — в [tests/README.md](../tests/README.md). Production, реальная доставка Firebase и контейнер в рамках этой проверки не запускались. --- Проверено по исходникам на 03.10.2026, commit `4603be9`. Описано текущее поведение; успешная сборка не означает проверку работающего сервера. Источник: [Govor.API/Program.cs](https://github.com/Govor-team/Govor/blob/4603be9f714135e0af72d505d17f3d1709834bea/Govor.API/Program.cs). - diff --git a/docs/groups.md b/docs/groups.md index 9312c77..5259278 100644 --- a/docs/groups.md +++ b/docs/groups.md @@ -146,7 +146,7 @@ GET `/api/admin/required-channel` возвращает channelId и allowLeave. ```powershell dotnet ef database update --project Govor.Domain --startup-project Govor.API -dotnet test Govor.Server.Tests/Govor.Server.Tests.csproj -c Release +dotnet test tests/Govor.Server.Tests/Govor.Server.Tests.csproj -c Release ``` Миграция `20261003131521_PrimitiveGroupsAndRequiredChannel` добавляет владельца, время создания, настройки сервера, лимиты/отзыв ссылок и уникальные индексы членства/админов/кодов. Старые дубли членства объединяются с сохранением бана; удаляются ссылки на отсутствующих пользователей и роли неактивных участников. Неоднозначные старые коды приглашений отзываются. Известное использование старых ссылок восстанавливается по сохранённым членствам; сведения о ранее вышедших пользователях в старой модели отсутствовали. diff --git a/docs/server-fixes.md b/docs/server-fixes.md index 38d4ef9..411b9af 100644 --- a/docs/server-fixes.md +++ b/docs/server-fixes.md @@ -28,12 +28,12 @@ FCM разбивается на пачки до 500. Временный отка ## Сборка и обновление -Используйте .NET SDK 10 и `Govor.Server.slnx`: она включает актуальный сервер и Govor.Server.Tests, без удалённых проектов и внешнего исходного проекта SmartRes. Бинарный `libs/SmartRes.dll` используется по существующему правилу репозитория. Legacy-тесты net8 в старой solution не перенесены. +Используйте .NET SDK 10 и `Govor.Server.slnx`: она включает актуальный сервер и Govor.Server.Tests, без удалённых проектов и внешнего исходного проекта SmartRes. Бинарный `libs/SmartRes.dll` используется по существующему правилу репозитория. Обновление 24.10.2026: серверные тесты перенесены в tests, обновлены до .NET 10 и подключены к обоим solution. Инструкции и результаты — в [tests/README.md](../tests/README.md). ```powershell dotnet restore Govor.Server.slnx dotnet build Govor.Server.slnx --no-restore -c Release -dotnet test Govor.Server.Tests/Govor.Server.Tests.csproj --no-build -c Release +dotnet test Govor.Server.slnx --no-build -c Release dotnet ef database update --project Govor.Domain --startup-project Govor.API ``` diff --git a/tests/API-COVERAGE.md b/tests/API-COVERAGE.md new file mode 100644 index 0000000..821c5e1 --- /dev/null +++ b/tests/API-COVERAGE.md @@ -0,0 +1,86 @@ +# Покрытие Govor.API + +Итоговая проверка 24.10.2026: Release-сборка и 710 тестовых случаев проходят +на SQLite и PostgreSQL 17.4 без ошибок и пропусков. На этапе расширения API +добавлены 172 случая: API.Tests вырос с 103 до 271, Server.Tests — с 132 до 136. +Application.Tests содержит 295, Domain.Tests — 8 случаев. + +## Измерение + +| Область | Строки | Ветви | +| --- | ---: | ---: | +| Исходники API до расширения | 56,14% (1093/1947) | 55,86% (248/444) | +| Исходники API после расширения, SQLite | 98,10% (1910/1947) | 92,34% (410/444) | +| Полная сборка API после расширения, включая генератор | 88,47% (1910/2159) | 63,08% (410/650) | + +Исходники API включают Program.cs, конфигурацию DI, контроллеры, хабы, фильтр, +mapping и обработчики уведомлений. Все исполняемые строки контроллеров покрыты; +не все пути условий проверены. + +Единственное исключение из порога исходников — файл +`obj/Release/net10.0/Microsoft.AspNetCore.OpenApi.SourceGenerators/Microsoft.AspNetCore.OpenApi.SourceGenerators.XmlCommentGenerator/OpenApiXmlCommentSupport.generated.cs`. +Он генерируется SDK, содержит 212 строк и 206 путей ветвления и не вызывается +текущим Swagger pipeline. Swagger проверяется отдельным HTTP-тестом. +Исключение явно запрашивается параметром `-ExcludeGeneratedSources`; без него +скрипт измеряет полную сборку. JSON в обоих случаях сохраняет EntireAssembly, +а при исключении — также ExcludedFiles. Рабочий код ради процентов не исключался. + +## Добавленные проверки + +- Административные пользователи и приглашения: DTO, поля, пароль, неизвестный + пользователь, фильтрация активных приглашений, ключ администратора, ошибки. +- Ключи сессий: текущий sid, лимит 100 ключей, невалидная модель, проверка дружбы, + Base64, отсутствие SignedPreKey, исключение использованных ключей. +- Личные чаты: проверка дружбы перед созданием, обе ориентации участников, + запреты и ошибки сервисов. +- Наборы реакций: пользовательские и административные операции, пагинация, + подписки, видимость выключенных наборов, emoji и медиа, лимиты и cancellation. +- Группы: списки, участники, приглашения, отмена приглашения, обязательный канал, + удаление аватара и сообщения; уведомления отправляются после успеха. +- ChatsHub: жизненный цикл, Send/Edit/Remove/Read/ReadChat, реакции, параметры + актёра и времени, вложения, ответы, ошибки и отсутствие лишних уведомлений. +- ProfileHub и PresenceHub: подписки групп, онлайн на первом соединении, + офлайн на последнем, нормализация описания, аватар, адресаты и сбои рассылки. +- HubExceptionFilter: активные и отсутствующие сессии, типизированные и обычные + возвращаемые значения, соответствие исключений статусам. +- Уведомления и push: получатели, уже прочитанные сообщения, отсутствующий профиль, + постоянные и временные ошибки поиска чата, отмена с сохранением lease для повтора. +- DI и worker: PostgreSQL provider и retry, detailed errors, отключённый Firebase, + LocalStorage, освобождение scope и остановка при отмене. +- HTTP: административные роли, реальные mappings реакций, регистрация E2EE, + неизменяемость ключей, каталог участников, ping, readiness и Swagger contract. + +Проверки SQL-поведения находятся в Integration, тесты с mocks — в Unit. +HTTP-проверки приложения находятся в Govor.Server.Tests/Api. Удалены 32 пустых +каталога старой структуры; это были остатки переноса, а не незавершённые тесты. + +## Запуск и CI + +```powershell +dotnet build Govor.Server.slnx -c Release --no-restore +dotnet test Govor.Server.slnx -c Release --no-build --no-restore --logger trx --results-directory artifacts/coverage --collect 'XPlat Code Coverage;Format=json,cobertura' +./tests/Measure-ApplicationCoverage.ps1 -ResultsDirectory artifacts/coverage +./tests/Measure-ApplicationCoverage.ps1 -ResultsDirectory artifacts/coverage -AssemblyName Govor.API -ExcludeGeneratedSources -MinimumLineCoverage 98 -MinimumBranchCoverage 92 +``` + +Для PostgreSQL задайте TEST_POSTGRES_CONNECTION согласно [README.md](README.md). +CI проверяет оба порога на SQLite и PostgreSQL. Объединяются попадания всех четырёх +проектов, проценты отдельных проектов не складываются. Каждый новый запуск должен +использовать свежую папку отчётов. Проверен и отрицательный сценарий: требование +100% корректно отклоняется скриптом. + +Итоговые локальные TRX и JSON: `artifacts/test-results/api-final-sqlite` и +`artifacts/test-results/api-final-postgres`. Скрипт создаёт api-coverage.json и +application-coverage.json. Артефакты игнорируются Git; CI сохраняет свои отчёты. + +## Границы проверки + +Остаются 37 строк и 34 пути ветвления исходников API. Большинство строк находятся +в Program.cs: production startup guards, создание реального Firebase с credentials, +режим migrate-only и отдельные ошибки readiness. Остаются также защитный выход +ProfileHub при пустом наборе адресатов (текущий пользователь добавляется всегда), +часть обработки отмены worker и несколько комбинаций условий. Точные строки есть +в JSON-отчёте. Это высокое, но не стопроцентное покрытие. + +Compiler/nullable и NuGet warnings остаются. Реальные Firebase credentials, +доставка push на устройство, нагрузка и production-развёртывание не проверялись. diff --git a/tests/APPLICATION-COVERAGE.md b/tests/APPLICATION-COVERAGE.md new file mode 100644 index 0000000..1cbd11c --- /dev/null +++ b/tests/APPLICATION-COVERAGE.md @@ -0,0 +1,90 @@ +# Покрытие Govor.Application + +Проверка 24.10.2026, Release, .NET SDK 10.0.400. Покрытие Application увеличено +с 82,8% строк до **98,88% строк** и **93,53% ветвей**. На этапе расширения +Application добавлена 191 проверка, затем при расширении API — ещё 172. + +| Проект | SQLite: пройдено | PostgreSQL 17.4: пройдено | +| --- | ---: | ---: | +| Govor.Application.Tests | 295 | 295 | +| Govor.API.Tests | 271 | 271 | +| Govor.Domain.Tests | 8 | 8 | +| Govor.Server.Tests | 136 | 136 | +| Всего | 710 | 710 | + +Ошибок и пропусков нет в обоих прогонах. Release-сборка проходит; существующие +compiler/nullable warnings и предупреждения NuGet для ImageSharp остаются. + +## Что проверяется + +Unit-тесты проверяют JWT, пароли, username, claims, присутствие, файловое +хранилище, push dispatch и ошибки транспорта, границы форматов E2EE. Mocks +используются для внешних зависимостей и управляемых отказов. + +Интеграционные тесты проверяют регистрацию и роли, профили, дружбу и блокировки, +сессии и refresh/replay, криптографические ключи, push-токены, сообщения и +прочтения, доступ к медиа, группы и аватары, реакции и наборы реакций. +Проверяются права доступа, отсутствующие данные, валидация, ошибки сохранения +и откат транзакций. Перехватчик команд БД воспроизводит отдельные отказы и гонки. + +Серверные тесты дополняют проверку через HTTP и SignalR: авторизация, E2EE, +некорректные конверты и маршрутизация, лимиты устройств, вложения, Firebase +batching и классификация ошибок. Внешний Firebase transport подменён. + +SQLite использует отдельную in-memory БД. PostgreSQL проверяет реальные +миграции, ограничения и поведение запросов: каждый экземпляр тестовой БД +получает уникальную схему, которая удаляется после теста. Для локального +прогона использован отдельный временный кластер на 127.0.0.1:55439 с БД +govor_validation_tests. Он не использует рабочие базы. + +## Реализованные методы и исправления + +- Last seen читается из БД; для неизвестного пользователя возвращается null. +- Медиа по URL ищется по точному URL в метаданных и читается из storage; + пустой URL и отсутствующие данные обрабатываются явно. +- Блокировка сохраняет инициатора как владельца блокировки. Другой участник + не может перехватить или снять её. Разблокировка переводит отношение в + Rejected: для дружбы снова требуется согласие. +- Новые криптографические сессии и одноразовые ключи явно добавляются в EF, + исправляя ошибочное UPDATE и DbUpdateConcurrencyException. +- Ротация и расходование ключей проверяют владельца сессии; чтение ключей + включает SignedPreKey. +- Чтение и удаление файлов проверяют канонический путь с границей корневой + директории, включая обход через `..` и похожее имя соседней папки. +- Пустой username возвращает ошибку валидации вместо NullReferenceException. + +## Подсчёт и воспроизведение + +Из корня репозитория после Release-сборки: + +```powershell +dotnet test Govor.Server.slnx -c Release --no-build --no-restore --logger trx --results-directory artifacts/coverage --collect 'XPlat Code Coverage;Format=json,cobertura' +./tests/Measure-ApplicationCoverage.ps1 -ResultsDirectory artifacts/coverage +``` + +Для PostgreSQL задайте TEST_POSTGRES_CONNECTION согласно [README.md](README.md). +Запуски с покрытием и другие тестовые запуски не должны одновременно использовать +одни и те же выходные сборки. Для нового измерения используйте свежую папку результатов. + +Скрипт объединяет попадания по строкам и ветвям Govor.Application.dll из всех +четырёх проектов, устраняет дубликаты и создаёт application-coverage.json. +Итог: 2727 из 2758 строк, 1199 из 1282 путей ветвления. Код сборки Application +не исключался из измерения. CI на SQLite и PostgreSQL требует минимум +98% строк и 92% ветвей; снижение ниже порога завершает проверку ошибкой. + +Локальный итоговый отчёт: +`artifacts/test-results/api-final-sqlite/application-coverage.json`. +TRX итоговых прогонов находятся в `api-final-sqlite` и +`api-final-postgres` под `artifacts/test-results`. + +## Оставшиеся ограничения + +Покрытие не равно 100%: остаются 31 строка и 83 пути ветвления. Это в том числе +старые конструкторы исключений/результатов, отдельные защитные проверки E2EE, +ветви ошибок файловой системы и media processor, обработка отдельных гонок +и отказов в authentication, groups, reactions и push. Точные строки перечислены +в JSON-отчёте; показатель строк не означает полного покрытия всех условий. + +Эти результаты подтверждают прохождение проверенных сценариев, но не доказывают +отсутствие всех ошибок. Нагрузочные испытания, production-развёртывание и +доставка push на физические устройства в эту проверку не входили. diff --git a/Govor.Server.Tests/Govor.Server.Tests.csproj b/tests/Directory.Build.props similarity index 51% rename from Govor.Server.Tests/Govor.Server.Tests.csproj rename to tests/Directory.Build.props index b5e6abe..51ed75b 100644 --- a/Govor.Server.Tests/Govor.Server.Tests.csproj +++ b/tests/Directory.Build.props @@ -1,21 +1,25 @@ - + net10.0 enable enable - false true + false + + + - - + + + + - - - - ../libs/SmartRes.dll + + $(MSBuildThisFileDirectory)../libs/SmartRes.dll + diff --git a/tests/Govor.API.Tests/GlobalUsings.cs b/tests/Govor.API.Tests/GlobalUsings.cs new file mode 100644 index 0000000..bdbe82c --- /dev/null +++ b/tests/Govor.API.Tests/GlobalUsings.cs @@ -0,0 +1,6 @@ +global using Govor.Application.Friends; +global using Govor.Application.Infrastructure.Extensions; +global using Govor.Application.Medias; +global using Govor.Application.Storage; +global using Govor.Application.Users.UserOnlineStatus; +global using Govor.Application.PrivateUserChats; diff --git a/tests/Govor.API.Tests/Govor.API.Tests.csproj b/tests/Govor.API.Tests/Govor.API.Tests.csproj new file mode 100644 index 0000000..ff79ab8 --- /dev/null +++ b/tests/Govor.API.Tests/Govor.API.Tests.csproj @@ -0,0 +1,6 @@ + + + + + + diff --git a/tests/Govor.API.Tests/Integration/Controllers/GroupControllerBoundaryTests.cs b/tests/Govor.API.Tests/Integration/Controllers/GroupControllerBoundaryTests.cs new file mode 100644 index 0000000..4341da1 --- /dev/null +++ b/tests/Govor.API.Tests/Integration/Controllers/GroupControllerBoundaryTests.cs @@ -0,0 +1,165 @@ +using AutoMapper; +using Govor.API.Controllers; +using Govor.API.Controllers.AdminStuff; +using Govor.API.Hubs.Infrastructure; +using Govor.Application.Groups; +using Govor.Application.Infrastructure.Extensions; +using Govor.Application.Messages; +using Govor.Application.Reactions; +using Govor.Contracts.Requests; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Messages; +using Govor.Tests.Shared; +using Microsoft.AspNetCore.Http; +using Microsoft.AspNetCore.Mvc; +using Moq; + +namespace Govor.API.Tests.Integration.Controllers; + +[TestFixture] +public class GroupControllerBoundaryTests +{ + [Test] + public async Task MembersAndInvitationsMapContractsAndRevokeUsesCurrentActor() + { + var actor = Guid.NewGuid(); var group = Guid.NewGuid(); var invitation = Guid.NewGuid(); + var user = new Mock(); user.Setup(x => x.GetCurrentUserId()).Returns(actor); + var groups = new Mock(); var mapper = new Mock(); + var members = new List(); var invitations = new List(); + var memberDtos = new List(); + var invitationDtos = new List(); + groups.Setup(x => x.MembersAsync(actor, group, true, 3, 7)).ReturnsAsync(members); + groups.Setup(x => x.InvitationsAsync(actor, group)).ReturnsAsync(invitations); + groups.Setup(x => x.RevokeInvitationAsync(actor, group, invitation)).ReturnsAsync(Result.Success()); + mapper.Setup(x => x.Map>(members)).Returns(memberDtos); + mapper.Setup(x => x.Map>(invitations)).Returns(invitationDtos); + var controller = new GroupsController(groups.Object, user.Object, mapper.Object, null!, Mock.Of(), Mock.Of(), Mock.Of()); + Assert.That(((OkObjectResult)await controller.Members(group, true, 3, 7)).Value, Is.SameAs(memberDtos)); + Assert.That(((OkObjectResult)await controller.Invitations(group)).Value, Is.SameAs(invitationDtos)); + Assert.That(((StatusCodeResult)await controller.RevokeInvitation(group, invitation)).StatusCode, Is.EqualTo(204)); + groups.Verify(x => x.RevokeInvitationAsync(actor, group, invitation), Times.Once); + } + + [TestCase(false)] + [TestCase(true)] + public async Task RequiredChannelReadMapsSettingsAndFailuresPreventMutation(bool failure) + { + var actor = Guid.NewGuid(); + var groups = new Mock(); + var user = new Mock(); + user.Setup(x => x.GetCurrentUserId()).Returns(actor); + var settings = new ServerCommunitySettings { RequiredChannelId = Guid.NewGuid(), AllowLeave = true }; + groups.Setup(x => x.GetRequiredChannelAsync(actor)).ReturnsAsync(failure + ? Result.Failure(Error.Forbidden("denied", "denied")) + : settings); + var notifier = new Mock(MockBehavior.Strict); + var controller = new RequiredChannelController(groups.Object, user.Object, notifier.Object); + var response = (ObjectResult)await controller.Get(); + Assert.That(response.StatusCode, Is.EqualTo(failure ? 403 : 200)); + if (failure) + { + Assert.That(((ObjectResult)await controller.Set(new())).StatusCode, Is.EqualTo(403)); + groups.Verify(x => x.SetRequiredChannelAsync(It.IsAny(), It.IsAny(), It.IsAny()), + Times.Never); + } + else + { + Assert.That(response.Value!.GetType().GetProperty("channelId")!.GetValue(response.Value), + Is.EqualTo(settings.RequiredChannelId)); + } + + notifier.VerifyNoOtherCalls(); + } + + [Test] + public async Task GroupReadsForwardQueryAndPaging() + { + using var db = new TestDatabase(); + var groups = new Mock(); + var user = new Mock(); + user.Setup(x => x.GetCurrentUserId()).Returns(db.Alice); + var mapper = new Mock(); + var list = new List(); + var mapped = new List(); + groups.Setup(x => x.MineAsync(db.Alice, 3, 7)).ReturnsAsync(list); + groups.Setup(x => x.SearchAsync(db.Alice, "needle", 4, 8)).ReturnsAsync(list); + mapper.Setup(x => x.Map>(list)).Returns(mapped); + var controller = new GroupsController(groups.Object, user.Object, mapper.Object, db.Context, + Mock.Of(), Mock.Of(), Mock.Of()); + Assert.That(((OkObjectResult)await controller.Mine(3, 7)).Value, Is.SameAs(mapped)); + Assert.That(((OkObjectResult)await controller.Search("needle", 4, 8)).Value, Is.SameAs(mapped)); + groups.Verify(x => x.MineAsync(db.Alice, 3, 7), Times.Once); + groups.Verify(x => x.SearchAsync(db.Alice, "needle", 4, 8), Times.Once); + } + + [TestCase(false)] + [TestCase(true)] + public async Task AvatarRemovalNotifiesOnlyAfterSuccess(bool failure) + { + using var db = new TestDatabase(); + var user = new Mock(); + user.Setup(x => x.GetCurrentUserId()).Returns(db.Alice); + var avatars = new Mock(); + avatars.Setup(x => x.RemoveAsync(db.Alice, db.ChatId)) + .ReturnsAsync(failure ? Result.Failure(Error.Forbidden("denied", "denied")) : Result.Success()); + var notifier = new Mock(); + var controller = new GroupsController(Mock.Of(), user.Object, Mock.Of(), + db.Context, Mock.Of(), notifier.Object, avatars.Object); + var response = await controller.RemoveAvatar(db.ChatId); + Assert.That(failure ? ((ObjectResult)response).StatusCode : ((StatusCodeResult)response).StatusCode, + Is.EqualTo(failure ? 403 : 204)); + notifier.Verify(x => x.NotifyGroupProfileChangedAsync(db.ChatId), failure ? Times.Never() : Times.Once()); + } + + [TestCase(0)] + [TestCase(2_097_153)] + public async Task AvatarLengthRejectsBeforeService(int size) + { + var file = new Mock(); + file.SetupGet(x => x.Length).Returns(size); + var avatars = new Mock(MockBehavior.Strict); + var controller = new GroupsController(Mock.Of(), Mock.Of(), + Mock.Of(), null!, Mock.Of(), Mock.Of(), + avatars.Object); + Assert.That(await controller.UploadAvatar(Guid.NewGuid(), new() { File = file.Object }), + Is.TypeOf()); + avatars.VerifyNoOtherCalls(); + } + + [Test] + public async Task FailedGroupMessageRemovalNeverNotifies() + { + using var db = new TestDatabase(); + var message = db.AddMessage(type: RecipientType.Group); + var user = new Mock(); + user.Setup(x => x.GetCurrentUserId()).Returns(db.Alice); + var remover = new Mock(); + remover.Setup(x => x.DeleteMessageAsync(It.IsAny())) + .ReturnsAsync(Result.Failure(Error.Forbidden("denied", "denied"))); + var notifier = new Mock(MockBehavior.Strict); + var controller = new GroupsController(Mock.Of(), user.Object, Mock.Of(), + db.Context, remover.Object, notifier.Object, Mock.Of()); + Assert.That(((ObjectResult)await controller.RemoveMessage(db.ChatId, message.Id)).StatusCode, Is.EqualTo(403)); + notifier.VerifyNoOtherCalls(); + } + + [Test] + public async Task ChannelReactionReadMapsPolicy() + { + var actor = Guid.NewGuid(); + var group = Guid.NewGuid(); + var user = new Mock(); + user.Setup(x => x.GetCurrentUserId()).Returns(actor); + var service = new Mock(); + var policy = new ChannelReactionPolicy(group, Govor.Domain.Models.Reactions.ChannelReactionMode.All, 2, []); + service.Setup(x => x.GetPolicyAsync(actor, group)).ReturnsAsync(policy); + var mapper = new Mock(); + var dto = new Govor.Contracts.Responses.SignalR.ChannelReactionPolicyResponse(); + mapper.Setup(x => x.Map(policy)).Returns(dto); + var controller = new ChannelReactionsController(service.Object, user.Object, mapper.Object, + Mock.Of()); + Assert.That(((OkObjectResult)await controller.Get(group)).Value, Is.SameAs(dto)); + } +} + diff --git a/tests/Govor.API.Tests/Integration/Filters/HubExceptionFilterTests.cs b/tests/Govor.API.Tests/Integration/Filters/HubExceptionFilterTests.cs new file mode 100644 index 0000000..e9f76e8 --- /dev/null +++ b/tests/Govor.API.Tests/Integration/Filters/HubExceptionFilterTests.cs @@ -0,0 +1,89 @@ +using Govor.API.Common.Extensions; +using Govor.API.Common.Mapping; +using Govor.API.Filters; +using Govor.Application.Profiles; +using Govor.Application.Users.UserOnlineStatus; +using Govor.Contracts.DTOs; +using Govor.Contracts.Responses.SignalR; +using Govor.Domain.Common; +using Govor.Domain.Models.Users; +using Govor.Tests.Shared; +using Microsoft.AspNetCore.Mvc; +using Microsoft.AspNetCore.SignalR; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; +using System.Security.Claims; + +namespace Govor.API.Tests.Integration.Filters; + +[TestFixture] +public class HubExceptionFilterTests +{ + public sealed class TestHub : Hub + { + public Task> Typed() => Task.FromResult(HubResult.Ok(7)); + public Task Plain() => Task.CompletedTask; + public int Synchronous() => 7; + } + + [TestCase(0, HubResultStatus.BadRequest)] + [TestCase(1, HubResultStatus.Unauthorized)] + [TestCase(2, HubResultStatus.NotFound)] + [TestCase(3, HubResultStatus.Conflict)] + [TestCase(4, HubResultStatus.ServerError)] + public async Task ActiveSessionExceptionsAreMappedWithoutLeakingServerErrors(int kind, HubResultStatus expected) + { + using var db = new TestDatabase(); + var sid = Guid.NewGuid(); + db.Context.UserSessions.Add(new() + { + Id = sid, UserId = db.Alice, DeviceInfo = "test", RefreshTokenHash = "hash", CreatedAt = DateTime.UtcNow, + ExpiresAt = DateTime.UtcNow.AddDays(1) + }); + db.Context.SaveChanges(); + var caller = new Mock(); + caller.SetupGet(x => x.User).Returns(new ClaimsPrincipal(new ClaimsIdentity( + new[] { new Claim("userId", db.Alice.ToString()), new Claim("sid", sid.ToString()) }, "test"))); + using var hub = new TestHub(); + var invocation = new HubInvocationContext(caller.Object, Mock.Of(), hub, + typeof(TestHub).GetMethod(nameof(TestHub.Typed))!, []); + Exception error = kind switch + { + 0 => new ArgumentException("invalid"), 1 => new UnauthorizedAccessException("denied"), + 2 => new KeyNotFoundException("missing"), 3 => new InvalidOperationException("conflict"), + _ => new Exception("private detail") + }; + var result = + (HubResult)(await new HubExceptionFilter(NullLogger.Instance, db.Context) + .InvokeMethodAsync(invocation, _ => throw error))!; + Assert.That(result.Status, Is.EqualTo(expected)); + if (kind == 4) Assert.That(result.ErrorMessage, Is.EqualTo("Internal server error")); + caller.Verify(x => x.Abort(), Times.Never); + } + + [TestCase(nameof(TestHub.Typed))] + [TestCase(nameof(TestHub.Plain))] + [TestCase(nameof(TestHub.Synchronous))] + public async Task MissingSessionAbortsAndHandlesReturnShapes(string method) + { + using var db = new TestDatabase(); + using var hub = new TestHub(); + var caller = new Mock(); + caller.SetupGet(x => x.User).Returns(new ClaimsPrincipal()); + var invocation = new HubInvocationContext(caller.Object, Mock.Of(), hub, + typeof(TestHub).GetMethod(method)!, []); + var invoked = false; + var result = + await new HubExceptionFilter(NullLogger.Instance, db.Context).InvokeMethodAsync( + invocation, _ => + { + invoked = true; + return ValueTask.FromResult(7); + }); + Assert.That(invoked, Is.False); + caller.Verify(x => x.Abort(), Times.Once); + if (method == nameof(TestHub.Typed)) + Assert.That(((HubResult)result!).Status, Is.EqualTo(HubResultStatus.Unauthorized)); + else Assert.That(result, Is.Null); + } +} diff --git a/tests/Govor.API.Tests/Integration/Notifications/ChatPushWorkerTests.cs b/tests/Govor.API.Tests/Integration/Notifications/ChatPushWorkerTests.cs new file mode 100644 index 0000000..5b65a49 --- /dev/null +++ b/tests/Govor.API.Tests/Integration/Notifications/ChatPushWorkerTests.cs @@ -0,0 +1,35 @@ +using Govor.API.Hubs.Infrastructure; +using Govor.Application.Infrastructure.Common; +using Govor.Tests.Shared; +using Microsoft.Extensions.DependencyInjection; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Integration.Notifications; + +[TestFixture] +public class ChatPushWorkerTests +{ + private sealed class Worker(IServiceScopeFactory factory):ChatPushWorker(factory,NullLogger.Instance) + { + public Task Run(CancellationToken token)=>ExecuteAsync(token); + } + [TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)] + public async Task WorkerDisposesScopesAndStopsOnCancellationIncludingFailurePaths(int mode) + { + using var db=new TestDatabase();using var cancellation=new CancellationTokenSource(); + var factory=new Mock();var scope=new Mock();var provider=new Mock(); + var clock=new Mock();clock.SetupGet(x=>x.Now).Returns(DateTime.UtcNow); + var dispatcher=new ChatPushDispatcher(db.Context,Mock.Of(),clock.Object); + scope.SetupGet(x=>x.ServiceProvider).Returns(provider.Object);provider.Setup(x=>x.GetService(typeof(ChatPushDispatcher))).Returns(dispatcher); + scope.Setup(x=>x.Dispose()).Callback(()=>cancellation.Cancel()); + if(mode==0) cancellation.Cancel(); + if(mode is 1 or 2) factory.Setup(x=>x.CreateScope()).Returns(()=>{cancellation.Cancel();throw mode==1?new OperationCanceledException(cancellation.Token):new InvalidOperationException("scope failure");}); + else factory.Setup(x=>x.CreateScope()).Returns(scope.Object); + using var worker=new Worker(factory.Object); + await worker.Run(cancellation.Token).WaitAsync(TimeSpan.FromSeconds(5)); + factory.Verify(x=>x.CreateScope(),mode==0?Times.Never():Times.Once()); + scope.Verify(x=>x.Dispose(),mode==3?Times.Once():Times.Never()); + } +} + diff --git a/tests/Govor.API.Tests/Integration/Notifications/NotificationBoundaryTests.cs b/tests/Govor.API.Tests/Integration/Notifications/NotificationBoundaryTests.cs new file mode 100644 index 0000000..9b29e97 --- /dev/null +++ b/tests/Govor.API.Tests/Integration/Notifications/NotificationBoundaryTests.cs @@ -0,0 +1,93 @@ +using Govor.API.Hubs; +using Govor.API.Hubs.Infrastructure; +using Govor.Application.PrivateUserChats; +using Govor.Application.Profiles; +using Govor.Application.PushNotifications; +using Govor.Contracts.Responses.SignalR; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Messages; +using Govor.Tests.Shared; +using Microsoft.AspNetCore.SignalR; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; +using Govor.Application.Infrastructure.Common; +using Microsoft.EntityFrameworkCore; + +namespace Govor.API.Tests.Integration.Notifications; + +[TestFixture] +public class NotificationBoundaryTests +{ + [TestCase(true)] + [TestCase(false)] + public async Task MissingChatIsAcknowledgedButTemporaryLookupFailureRequiresRetry(bool missing) + { + using var db = new TestDatabase(); + var chats = new Mock(); + chats.Setup(x => x.GetPrivateChatAsync(db.ChatId)).ReturnsAsync(Result.Failure( + missing ? Error.NotFound("missing", "missing") : Error.ServerError("database", "unavailable"))); + var push = new Mock(MockBehavior.Strict); + var notifier = new ChatNotificationService(Mock.Of>(), push.Object, chats.Object, + Mock.Of(), db.Context, NullLogger.Instance); + Assert.That(await notifier.DeliverPushAsync(new() { RecipientId = db.ChatId, RecipientType = RecipientType.User }), Is.EqualTo(missing)); + push.VerifyNoOtherCalls(); + } + + [Test] + public async Task CancellationDuringPushLeavesClaimForLaterRetry() + { + using var db = new TestDatabase(); + using var cancellation = new CancellationTokenSource(); + var message = db.AddMessage(); + var now = DateTime.UtcNow; + db.Context.ChatPushNotifications.Add(new() { MessageId = message.Id, NextAttemptAt = now.AddMinutes(-1) }); + await db.Context.SaveChangesAsync(); + var notifier = new Mock(); + notifier.Setup(x => x.DeliverPushAsync(It.IsAny())).Returns(() => + { + cancellation.Cancel(); + throw new OperationCanceledException(cancellation.Token); + }); + var clock = new Mock(); + clock.SetupGet(x => x.Now).Returns(now); + var dispatcher = new ChatPushDispatcher(db.Context, notifier.Object, clock.Object); + Assert.ThrowsAsync(() => dispatcher.DispatchAsync(cancellation.Token)); + var pending = await db.Context.ChatPushNotifications.AsNoTracking().SingleAsync(); + Assert.That(pending.Attempts, Is.EqualTo(1)); + Assert.That(pending.NextAttemptAt, Is.GreaterThan(now)); + } + + [TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)] [TestCase(4)] + public async Task PushHandlesNoRecipientsReadersMissingProfileAndProviderFailures(int mode) + { + using var db=new TestDatabase();var message=db.AddMessage(); + if(mode==1){db.Context.MessageViews.Add(new(){Id=Guid.NewGuid(),MessageId=message.Id,UserId=db.Bob,ViewedAt=DateTime.UtcNow});db.Context.SaveChanges();} + var chats=new Mock();chats.Setup(x=>x.GetPrivateChatAsync(db.ChatId)).ReturnsAsync(mode==0?new PrivateChat{UserAId=db.Alice,UserBId=db.Alice}:new PrivateChat{UserAId=db.Alice,UserBId=db.Bob}); + var profiles=new Mock();profiles.Setup(x=>x.GetUserProfileAsync(db.Alice)).ReturnsAsync(Result.Failure(Error.NotFound("missing","missing"))); + var push=new Mock(); + if(mode==4) push.Setup(x=>x.SendToUsersAsync(It.IsAny>(),It.IsAny(),It.IsAny(),It.IsAny(),It.IsAny(),It.IsAny?>())).ThrowsAsync(new Exception("transport")); + else push.Setup(x=>x.SendToUsersAsync(It.IsAny>(),It.IsAny(),It.IsAny(),It.IsAny(),It.IsAny(),It.IsAny?>())).ReturnsAsync(mode==3?Result.Failure(Error.ServerError("push","failure")):Result.Success()); + var notifier=new ChatNotificationService(Mock.Of>(),push.Object,chats.Object,profiles.Object,db.Context,NullLogger.Instance); + var result=await notifier.DeliverPushAsync(new(){MessageId=message.Id,SenderId=db.Alice,RecipientId=db.ChatId,RecipientType=RecipientType.User}); + Assert.That(result,Is.EqualTo(mode<3)); + if(mode<2){push.VerifyNoOtherCalls();profiles.VerifyNoOtherCalls();} + else push.Verify(x=>x.SendToUsersAsync(It.Is>(ids=>ids.SequenceEqual(new[]{db.Bob})),"Govor","New message","chat_messages",$"chat_{db.ChatId}",It.IsAny?>()),Times.Once); + } + [Test] + public async Task LegacyReadAndRemovalEventsReachActiveSessionAndMissingChatIsIgnored() + { + using var db=new TestDatabase();var sid=Guid.NewGuid();db.Context.UserSessions.Add(new(){Id=sid,UserId=db.Alice,ExpiresAt=DateTime.UtcNow.AddDays(1)});db.Context.SaveChanges(); + var proxy=new Mock();var clients=new Mock();clients.Setup(x=>x.Groups(It.IsAny>())).Returns(proxy.Object); + var hub=new Mock>();hub.SetupGet(x=>x.Clients).Returns(clients.Object); + var chats=new Mock();chats.Setup(x=>x.GetPrivateChatAsync(db.ChatId)).ReturnsAsync(new PrivateChat{UserAId=db.Alice,UserBId=db.Bob}); + var notifier=new ChatNotificationService(hub.Object,Mock.Of(),chats.Object,Mock.Of(),db.Context,NullLogger.Instance); + await notifier.NotifyMessageWasReadAsync(new(){ViewId=Guid.NewGuid(),MessageId=Guid.NewGuid(),ReaderId=db.Alice,WhenWas=DateTime.UtcNow,RecipientId=db.ChatId,RecipientType=RecipientType.User}); + await notifier.NotifyMessageRemovedAsync(new(){MessageId=Guid.NewGuid(),SenderId=db.Alice,RecipientId=db.ChatId,RecipientType=RecipientType.User}); + await notifier.NotifyMessageEditedAsync(new(){MessageId=Guid.NewGuid(),EditorId=db.Alice,RecipientId=db.ChatId,RecipientType=RecipientType.User}); + foreach(var method in new[]{"MessageReaded","MessageRead","MessageRemoved","MessageEdited"})proxy.Verify(x=>x.SendCoreAsync(method,It.IsAny(),default),Times.Once); + chats.Setup(x=>x.GetPrivateChatAsync(db.ChatId)).ReturnsAsync(Result.Failure(Error.NotFound("missing","missing"))); + proxy.Invocations.Clear();await notifier.NotifyChatReadAsync(new(){ChatId=db.ChatId,RecipientType=RecipientType.User});proxy.VerifyNoOtherCalls(); + } +} + diff --git a/tests/Govor.API.Tests/Unit/Common/ConfigurationTests.cs b/tests/Govor.API.Tests/Unit/Common/ConfigurationTests.cs new file mode 100644 index 0000000..3a21837 --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Common/ConfigurationTests.cs @@ -0,0 +1,38 @@ +using Govor.API.Common.Extensions; +using Govor.Application.PushNotifications; +using Govor.Application.PushNotifications.Providers; +using Govor.Application.Storage; +using Govor.Domain; +using Microsoft.AspNetCore.Hosting; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Configuration; +using Microsoft.Extensions.DependencyInjection; +using Moq; + +namespace Govor.API.Tests.Unit.Common; + +[TestFixture] +public class ConfigurationTests +{ + [TestCase(false)] [TestCase(true)] + public void DatabaseConfigurationUsesPostgresAndHonorsDetailedErrors(bool detailed) + { + var config=new ConfigurationBuilder().AddInMemoryCollection(new Dictionary{{"ConnectionStrings:GovorDbContext","Host=localhost;Database=configuration_tests;Username=tests"},{"Database:EnableDetailedErrors",detailed.ToString()}}).Build(); + var services=new ServiceCollection();services.AddGovorDbContext(config); + using var provider=services.BuildServiceProvider();using var scope=provider.CreateScope();var db=scope.ServiceProvider.GetRequiredService(); + Assert.That(db.Database.ProviderName,Is.EqualTo("Npgsql.EntityFrameworkCore.PostgreSQL")); + Assert.That(db.Database.CreateExecutionStrategy().RetriesOnFailure,Is.True); + var options=scope.ServiceProvider.GetRequiredService>(); + Assert.That(options.FindExtension()!.DetailedErrorsEnabled,Is.EqualTo(detailed)); + } + [Test] + public void DisabledFirebaseAndLocalStorageResolveThroughProductionRegistration() + { + var services=new ServiceCollection();services.AddLogging(); + services.AddSingleton(new ConfigurationBuilder().AddInMemoryCollection(new Dictionary{{"Firebase:Enabled","false"}}).Build()); + var environment=new Mock();environment.SetupGet(x=>x.ContentRootPath).Returns(Path.GetTempPath());services.AddSingleton(environment.Object); + services.AddServices();using var provider=services.BuildServiceProvider();using var scope=provider.CreateScope(); + Assert.That(scope.ServiceProvider.GetRequiredService(),Is.TypeOf()); + Assert.That(scope.ServiceProvider.GetRequiredService(),Is.TypeOf()); + } +} diff --git a/tests/Govor.API.Tests/Unit/Common/ErrorAndMappingTests.cs b/tests/Govor.API.Tests/Unit/Common/ErrorAndMappingTests.cs new file mode 100644 index 0000000..cf793c7 --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Common/ErrorAndMappingTests.cs @@ -0,0 +1,65 @@ +using Govor.API.Common.Extensions; +using Govor.API.Common.Mapping; +using Govor.API.Filters; +using Govor.Application.Profiles; +using Govor.Application.Users.UserOnlineStatus; +using Govor.Contracts.DTOs; +using Govor.Contracts.Responses.SignalR; +using Govor.Domain.Common; +using Govor.Domain.Models.Users; +using Govor.Tests.Shared; +using Microsoft.AspNetCore.Mvc; +using Microsoft.AspNetCore.SignalR; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; +using System.Security.Claims; + +namespace Govor.API.Tests.Unit.Common; + +[TestFixture] +public class ErrorAndMappingTests +{ + [TestCase(ErrorType.NotFound, 404, "Not Found")] + [TestCase(ErrorType.Validation, 400, "Validation Error")] + [TestCase(ErrorType.Conflict, 409, "Conflict")] + [TestCase(ErrorType.Unauthorized, 401, "Unauthorized")] + [TestCase(ErrorType.Forbidden, 403, "Forbidden")] + [TestCase(ErrorType.ServerError, 500, "Internal Server Error")] + [TestCase(ErrorType.Failure, 400, "Bad Request")] + public void ResultErrorsPreserveCodeDetailsAndFieldErrors(ErrorType type, int status, string title) + { + var fields = new Dictionary { { "field", ["required"] } }; + var error = new Error("code", "detail", type, fields); + var response = (ObjectResult)Result.Failure(error).ToActionResult(); + var problem = (ProblemDetails)response.Value!; + Assert.Multiple(() => + { + Assert.That(response.StatusCode, Is.EqualTo(status)); + Assert.That(problem.Title, Is.EqualTo(title)); + Assert.That(problem.Detail, Is.EqualTo("detail")); + Assert.That(problem.Extensions["errorCode"], Is.EqualTo("code")); + Assert.That(problem.Extensions["errors"], Is.SameAs(fields)); + }); + var hub = error.ToHubResult(); + Assert.That((int)hub.Status, Is.EqualTo(status)); + Assert.That(hub.ErrorMessage, Is.EqualTo(type == ErrorType.ServerError ? "Internal server error." : "detail")); + } + + [TestCase(false)] + [TestCase(true)] + public void MappingActionsUseCurrentOnlineState(bool online) + { + var id = Guid.NewGuid(); + var store = new Mock(); + store.Setup(x => x.IsOnline(id)).Returns(online); + var user = new UserDto(); + new UserToUserDtoMappingAction(store.Object).Process(new User { Id = id }, user, null!); + var profile = new UserProfileDto(); + new UserProfileToUserProfileDtoMappingAction(store.Object).Process(new UserProfile { Id = id }, profile, null!); + Assert.That(user.IsOnline, Is.EqualTo(online)); + Assert.That(profile.IsOnline, Is.EqualTo(online)); + store.Verify(x => x.IsOnline(id), Times.Exactly(2)); + } +} + + diff --git a/tests/Govor.API.Tests/Unit/Controllers/AdministrationControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/AdministrationControllerTests.cs new file mode 100644 index 0000000..801635f --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/AdministrationControllerTests.cs @@ -0,0 +1,135 @@ +using Govor.API.Controllers.AdminStuff; +using Govor.Application.Infrastructure.AdminsStuff; +using Govor.Contracts.Requests; +using Govor.Contracts.DTOs; +using Govor.Contracts.Responses.Admins; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Users; +using Microsoft.AspNetCore.Mvc; +using Microsoft.Extensions.Configuration; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class AdministrationControllerTests +{ + private Mock _generator = null!; + private Mock _getter = null!; + private InviteUserController _invites = null!; + private readonly DateTime _end = new(2030, 1, 1, 0, 0, 0, DateTimeKind.Utc); + + [TearDown] + public void TearDown() => _invites.Dispose(); + + [SetUp] + public void Setup() + { + _generator = new(); _getter = new(); + _invites = Create("admin-secret"); + } + + private InviteUserController Create(string? key) => new(_generator.Object, _getter.Object, + new ConfigurationBuilder().AddInMemoryCollection(new Dictionary { ["InvitationAdmin:Key"] = key }).Build(), + NullLogger.Instance); + + [TestCase(false)] + [TestCase(true)] + public async Task InvitationForwardsAllFields(bool withKey) + { + _generator.Setup(g => g.GenerateInvitationCode(_end, 12, true, "description")).ReturnsAsync("code"); + var response = withKey + ? await _invites.InvitationWithKey(new() { AdminKey = "admin-secret", EndDate = _end, MaxParticipants = 12, IsAdmin = true, Description = "description" }) + : await _invites.Invitation(new() { EndDate = _end, MaxParticipants = 12, IsAdmin = true, Description = "description" }); + Assert.That(((OkObjectResult)response).Value, Is.EqualTo("code")); + _generator.Verify(g => g.GenerateInvitationCode(_end, 12, true, "description"), Times.Once); + } + + [TestCase(null, "admin-secret", 503)] + [TestCase(" ", "admin-secret", 503)] + [TestCase("admin-secret", "", 401)] + [TestCase("admin-secret", "ADMIN-SECRET", 401)] + public async Task InvalidAdminKeyNeverGeneratesInvitation(string? configured, string supplied, int status) + { + var result = (ObjectResult)await Create(configured).InvitationWithKey(new() { AdminKey = supplied }); + Assert.That(result.StatusCode, Is.EqualTo(status)); + _generator.VerifyNoOtherCalls(); + } + + [TestCase(false)] + [TestCase(true)] + public async Task GeneratorExceptionProducesBadRequest(bool withKey) + { + _generator.Setup(g => g.GenerateInvitationCode(It.IsAny(), It.IsAny(), It.IsAny(), It.IsAny())).ThrowsAsync(new InvalidOperationException("failure")); + var result = withKey ? await _invites.InvitationWithKey(new() { AdminKey = "admin-secret" }) : await _invites.Invitation(new()); + Assert.That(result, Is.TypeOf()); + } + + [TestCase(false)] + [TestCase(true)] + public async Task InvitationListsMapFieldsAndFilterActive(bool activeOnly) + { + var active = new Invitation { Id = Guid.NewGuid(), Code = "code", Description = "desc", IsAdmin = true, MaxParticipants = 7, DateCreated = _end.AddDays(-1), EndDate = _end, Users = [new User()] }; + var inactive = new Invitation { Id = Guid.NewGuid(), IsActive = false }; + _getter.Setup(g => g.GetAllAsync()).ReturnsAsync([active, inactive]); + var result = activeOnly ? await _invites.GetAllActiveInvitations() : await _invites.GetAllInvitations(); + var dtos = (List)((OkObjectResult)result).Value!; + Assert.That(dtos, Has.Count.EqualTo(activeOnly ? 1 : 2)); + var dto = dtos.Single(x => x.Id == active.Id); + Assert.Multiple(() => { + Assert.That(dto.Code, Is.EqualTo(active.Code)); Assert.That(dto.Description, Is.EqualTo(active.Description)); + Assert.That(dto.ParticipantCount, Is.EqualTo(1)); Assert.That(dto.IsAdmin, Is.True); + Assert.That(dto.MaxParticipants, Is.EqualTo(7)); Assert.That(dto.CreatedAt, Is.EqualTo(active.DateCreated)); Assert.That(dto.EndAt, Is.EqualTo(_end)); + }); + _getter.Setup(g => g.FindByIdAsync(active.Id)).ReturnsAsync(active); + Assert.That(((InvitationResponses)((OkObjectResult)await _invites.GetInvitationById(active.Id)).Value!).Id, Is.EqualTo(active.Id)); + } + + [TestCase(0)] [TestCase(1)] [TestCase(2)] + public async Task InvitationReadExceptionsProduceBadRequest(int operation) + { + _getter.Setup(g => g.GetAllAsync()).ThrowsAsync(new Exception("failure")); + _getter.Setup(g => g.FindByIdAsync(It.IsAny())).ThrowsAsync(new Exception("failure")); + var result = operation switch { 0 => await _invites.GetAllInvitations(), 1 => await _invites.GetAllActiveInvitations(), _ => await _invites.GetInvitationById(Guid.NewGuid()) }; + Assert.That(result, Is.TypeOf()); + } + + [Test] + public async Task MissingInvitationReturnsNotFound() + { + _getter.Setup(g => g.FindByIdAsync(It.IsAny())).ReturnsAsync(Result.Failure(Error.NotFound("missing", "missing"))); + Assert.That(await _invites.GetInvitationById(Guid.NewGuid()), Is.TypeOf()); + } + + [Test] + public async Task UserDtosHandleMissingAndAdminInvitations() + { + var users = new Mock(); + var a = new User { Id = Guid.NewGuid(), Username = "a", Description = "desc", Invite = new Invitation { IsAdmin = true } }; + var b = new User { Id = Guid.NewGuid(), Username = "b" }; + users.Setup(u => u.GetAllUsersAsync()).ReturnsAsync([a,b]); + users.Setup(u => u.GetUserById(a.Id)).ReturnsAsync(a); + var controller = new UsersController(NullLogger.Instance, users.Object); + var dtos = (List)((OkObjectResult)await controller.AllUsers()).Value!; + Assert.That(dtos.Select(x => x.IsAdmin), Is.EqualTo(new[] { true, false })); + Assert.That(((UserResponse)((OkObjectResult)await controller.GetUserById(a.Id)).Value!).Username, Is.EqualTo("a")); + Assert.That(await controller.GetUserById(b.Id), Is.TypeOf()); + Assert.That(await controller.SetNewPassword(b.Id, new() { Password = "password" }), Is.TypeOf()); + Assert.That(await controller.SetNewPassword(a.Id, new() { Password = "password" }), Is.TypeOf()); + users.Verify(u => u.SetPasswordAsync(a.Id, "password"), Times.Once); + users.Verify(u => u.SetPasswordAsync(b.Id, It.IsAny()), Times.Never); + } + + [TestCase(0)] [TestCase(1)] [TestCase(2)] + public async Task UserAdministrationErrorsReturn500(int operation) + { + var users = new Mock(); + users.Setup(u => u.GetAllUsersAsync()).ThrowsAsync(new Exception("failure")); + users.Setup(u => u.GetUserById(It.IsAny())).ThrowsAsync(new Exception("failure")); + var controller = new UsersController(NullLogger.Instance, users.Object); + var result = operation switch { 0 => await controller.AllUsers(), 1 => await controller.GetUserById(Guid.NewGuid()), _ => await controller.SetNewPassword(Guid.NewGuid(), new() { Password = "password" }) }; + Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500)); + } +} diff --git a/tests/Govor.API.Tests/Unit/Controllers/AuthControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/AuthControllerTests.cs new file mode 100644 index 0000000..6fe9c2a --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/AuthControllerTests.cs @@ -0,0 +1,136 @@ +using Govor.API.Controllers.Authentication; +using Govor.API.Hubs.Infrastructure; +using Govor.Application.Authentication; +using Govor.Application.Users.UserSessions; +using Govor.Contracts.Requests; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Users; +using Microsoft.AspNetCore.Mvc; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class AuthControllerTests +{ + private Mock _accounts = null!; + private Mock _invites = null!; + private Mock _sessions = null!; + private Mock _notifier = null!; + private AuthController _controller = null!; + private readonly User _user = new() { Id = Guid.NewGuid(), Username = "Иван" }; + private readonly Invitation _invite = new() { Id = Guid.NewGuid(), Code = "test" }; + private readonly RefreshResult _tokens = new("refresh", "access"); + + [SetUp] + public void SetUp() + { + _accounts = new Mock(); + _invites = new Mock(); + _sessions = new Mock(); + _notifier = new Mock(); + _controller = new(_accounts.Object, _invites.Object, _sessions.Object, + NullLogger.Instance, _notifier.Object); + _invites.Setup(i => i.ValidateAsync("test")).ReturnsAsync(_invite); + _accounts.Setup(a => a.RegistrationAsync("Иван", "secret", _invite)).ReturnsAsync(_user); + _accounts.Setup(a => a.LoginAsync("Иван", "secret")).ReturnsAsync(_user); + _sessions.Setup(s => s.OpenSessionAsync(_user, "phone")).ReturnsAsync(_tokens); + } + + [Test] + public async Task RegistrationValidatesInvitationCreatesAccountNotifiesGroupsThenOpensSession() + { + var order = new List(); + _notifier.Setup(n => n.NotifyUserJoinedGroupsAsync(_user.Id)).Callback(() => order.Add("notify")).Returns(Task.CompletedTask); + _sessions.Setup(s => s.OpenSessionAsync(_user, "phone")).Callback(() => order.Add("session")).ReturnsAsync(_tokens); + var response = await _controller.Register(new RegistrationRequest { Name = "Иван", Password = "secret", InviteLink = "test", DeviceInfo = "phone" }); + Assert.That(((OkObjectResult)response).Value, Is.EqualTo(_tokens)); + Assert.That(order, Is.EqualTo(new[] { "notify", "session" })); + _invites.Verify(i => i.ValidateAsync("test"), Times.Once); + _accounts.Verify(a => a.RegistrationAsync("Иван", "secret", _invite), Times.Once); + } + + [Test] + public async Task InvalidInvitationStopsRegistrationPipeline() + { + _invites.Setup(i => i.ValidateAsync("test")).ReturnsAsync(Result.Failure(Error.Validation("Invite.Invalid", "invalid"))); + var response = (ObjectResult)await _controller.Register(new RegistrationRequest { Name = "Иван", Password = "secret", InviteLink = "test" }); + Assert.That(response.StatusCode, Is.EqualTo(400)); + Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Invite.Invalid")); + _accounts.VerifyNoOtherCalls(); + _sessions.VerifyNoOtherCalls(); + _notifier.VerifyNoOtherCalls(); + } + + [TestCase(ErrorType.Conflict, 409)] + [TestCase(ErrorType.Validation, 400)] + public async Task RegistrationFailureDoesNotNotifyOrOpenSession(ErrorType type, int status) + { + _accounts.Setup(a => a.RegistrationAsync("Иван", "secret", _invite)) + .ReturnsAsync(Result.Failure(new Error("Auth.Failed", "failure", type))); + var response = (ObjectResult)await _controller.Register(new RegistrationRequest { Name = "Иван", Password = "secret", InviteLink = "test" }); + Assert.That(response.StatusCode, Is.EqualTo(status)); + _sessions.VerifyNoOtherCalls(); + _notifier.VerifyNoOtherCalls(); + } + + [Test] + public async Task LoginReturnsTokensForTheRequestedDevice() + { + var response = (OkObjectResult)await _controller.Login(new LoginRequest { Name = "Иван", Password = "secret", DeviceInfo = "phone" }); + Assert.That(response.Value, Is.EqualTo(_tokens)); + _sessions.Verify(s => s.OpenSessionAsync(_user, "phone"), Times.Once); + _invites.VerifyNoOtherCalls(); + _notifier.VerifyNoOtherCalls(); + } + + [TestCase(ErrorType.NotFound, 404)] + [TestCase(ErrorType.Failure, 400)] + [TestCase(ErrorType.Unauthorized, 401)] + public async Task FailedLoginDoesNotOpenSession(ErrorType type, int status) + { + _accounts.Setup(a => a.LoginAsync("Иван", "secret")).ReturnsAsync(Result.Failure(new Error("Auth.Failed", "failure", type))); + var response = (ObjectResult)await _controller.Login(new LoginRequest { Name = "Иван", Password = "secret", DeviceInfo = "phone" }); + Assert.That(response.StatusCode, Is.EqualTo(status)); + _sessions.VerifyNoOtherCalls(); + } + + [Test] + public async Task SessionFailureIsReturnedToClient() + { + _sessions.Setup(s => s.OpenSessionAsync(_user, "phone")) + .ReturnsAsync(Result.Failure(Error.ServerError("Session.Failed", "failure"))); + Assert.That(((ObjectResult)await _controller.Login(new LoginRequest { Name = "Иван", Password = "secret", DeviceInfo = "phone" })).StatusCode, Is.EqualTo(500)); + } +} + +[TestFixture] +public class RefreshControllerTests +{ + [Test] + public async Task SuccessfulRefreshReturnsCurrentTokenContract() + { + var service = new Mock(); + var tokens = new RefreshResult("new-refresh", "new-access"); + service.Setup(s => s.RefreshTokenAsync("old")).ReturnsAsync(tokens); + var controller = new RefreshController(NullLogger.Instance, service.Object); + var response = (OkObjectResult)await controller.Refresh(new RefreshTokenRequest { RefreshToken = "old" }); + Assert.That(response.Value, Is.SameAs(tokens)); + } + + [TestCase(ErrorType.Failure, 400)] + [TestCase(ErrorType.Unauthorized, 401)] + [TestCase(ErrorType.ServerError, 500)] + public async Task RefreshFailureMapsToProblemDetails(ErrorType type, int status) + { + var service = new Mock(); + service.Setup(s => s.RefreshTokenAsync("invalid")) + .ReturnsAsync(Result.Failure(new Error("Auth.InvalidToken", "invalid", type))); + var controller = new RefreshController(NullLogger.Instance, service.Object); + var response = (ObjectResult)await controller.Refresh(new RefreshTokenRequest { RefreshToken = "invalid" }); + Assert.That(response.StatusCode, Is.EqualTo(status)); + Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Auth.InvalidToken")); + } +} diff --git a/tests/Govor.API.Tests/Unit/Controllers/ChatLoadControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/ChatLoadControllerTests.cs new file mode 100644 index 0000000..74a1fa7 --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/ChatLoadControllerTests.cs @@ -0,0 +1,81 @@ +using AutoMapper; +using Govor.API.Controllers; +using Govor.Application.Messages; +using Govor.Contracts.Requests; +using Govor.Contracts.Responses; +using Govor.Domain.Common; +using Govor.Domain.Models.Messages; +using Microsoft.AspNetCore.Mvc; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class ChatLoadControllerTests +{ + private Mock _loader = null!; + private Mock _mapper = null!; + private ChatLoadController _controller = null!; + private readonly Guid _user = Guid.NewGuid(), _chat = Guid.NewGuid(); + + [SetUp] + public void SetUp() + { + _loader = new Mock(); + _mapper = new Mock(); + var current = new Mock(); + current.Setup(c => c.GetCurrentUserId()).Returns(_user); + _controller = new(NullLogger.Instance, _loader.Object, current.Object, _mapper.Object); + } + + private Task Load(bool group, MessageQuery query) => + group ? _controller.GetGroupMessages(_chat, query) : _controller.GetUserMessages(_chat, query); + + [TestCase(false)] + [TestCase(true)] + public async Task SuccessfulPageIsMappedAndReturnsOk(bool group) + { + var messages = new List { new() { Id = Guid.NewGuid() } }; + var response = new List(); + _mapper.Setup(m => m.Map>(messages)).Returns(response); + _loader.Setup(l => l.LoadMessagesInChatGroup(_chat, _user, null, 20, 2)).ReturnsAsync(messages); + _loader.Setup(l => l.LoadMessagesInUserChat(_chat, _user, null, 20, 2)).ReturnsAsync(messages); + Assert.That(((OkObjectResult)await Load(group, new MessageQuery { Before = 20, After = 2 })).Value, Is.SameAs(response)); + } + + [TestCase(false, -1, 0)] + [TestCase(true, 0, -1)] + [TestCase(false, 101, 0)] + [TestCase(true, 0, 101)] + [TestCase(false, 60, 41)] + [TestCase(true, 60, 41)] + public async Task InvalidPageLimitsDoNotCallLoader(bool group, int before, int after) + { + Assert.That(await Load(group, new MessageQuery { Before = before, After = after }), Is.TypeOf()); + _loader.VerifyNoOtherCalls(); + } + + [TestCase(false, ErrorType.Forbidden, 403)] + [TestCase(true, ErrorType.Forbidden, 403)] + [TestCase(false, ErrorType.NotFound, 404)] + [TestCase(true, ErrorType.Validation, 400)] + public async Task ServiceFailureReturnsProblemDetails(bool group, ErrorType type, int status) + { + var failure = Result.Failure>(new Error("Chat.Failed", "failure", type)); + _loader.Setup(l => l.LoadMessagesInChatGroup(_chat, _user, null, 20, 2)).ReturnsAsync(failure); + _loader.Setup(l => l.LoadMessagesInUserChat(_chat, _user, null, 20, 2)).ReturnsAsync(failure); + var response = (ObjectResult)await Load(group, new MessageQuery { Before = 20, After = 2 }); + Assert.That(response.StatusCode, Is.EqualTo(status)); + Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Chat.Failed")); + } + + [TestCase(false)] + [TestCase(true)] + public async Task UnexpectedExceptionReturns500(bool group) + { + _loader.Setup(l => l.LoadMessagesInChatGroup(_chat, _user, null, 20, 2)).ThrowsAsync(new Exception("database unavailable")); + _loader.Setup(l => l.LoadMessagesInUserChat(_chat, _user, null, 20, 2)).ThrowsAsync(new Exception("database unavailable")); + Assert.That(((ObjectResult)await Load(group, new MessageQuery { Before = 20, After = 2 })).StatusCode, Is.EqualTo(500)); + } +} diff --git a/tests/Govor.API.Tests/Unit/Controllers/ControllerFailureTests.cs b/tests/Govor.API.Tests/Unit/Controllers/ControllerFailureTests.cs new file mode 100644 index 0000000..9ba4acd --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/ControllerFailureTests.cs @@ -0,0 +1,79 @@ +using AutoMapper; +using Govor.API.Controllers; +using Govor.API.Hubs; +using Govor.Application.Infrastructure.Extensions; +using Govor.Application.Medias; +using Govor.Application.Profiles; +using Govor.Application.PushNotifications; +using Govor.Application.Users.UserSessions; +using Govor.Application.Users.UserOnlineStatus; +using Govor.Application.PingHandler; +using Govor.Contracts.Requests; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Microsoft.AspNetCore.Http; +using Microsoft.AspNetCore.Mvc; +using Microsoft.AspNetCore.SignalR; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class ControllerFailureTests +{ + [TestCase(0,false)] [TestCase(0,true)] [TestCase(1,false)] [TestCase(1,true)] [TestCase(2,false)] [TestCase(2,true)] + public async Task SessionRevocationExceptionsProduceExpectedStatus(int action,bool unauthorized) + { + var user=new Mock();var session=new Mock();var revoker=new Mock(); + Exception error=unauthorized?new UnauthorizedAccessException():new Exception("private detail"); + revoker.Setup(x=>x.CloseSessionByIdAsync(It.IsAny(),It.IsAny())).ThrowsAsync(error); + revoker.Setup(x=>x.CloseAllSessionsAsync(It.IsAny())).ThrowsAsync(error); + using var controller=new SessionController(NullLogger.Instance,user.Object,session.Object,Mock.Of(),revoker.Object,Mock.Of()); + var response=action switch{0=>await controller.CloseSession(Guid.NewGuid()),1=>await controller.CloseCurrent(),_=>await controller.CloseAllSessions()}; + if(unauthorized) Assert.That(response,Is.TypeOf());else {Assert.That(((ObjectResult)response).StatusCode,Is.EqualTo(500));Assert.That(((ObjectResult)response).Value,Is.Not.EqualTo("private detail"));} + } + [TestCase(false)] [TestCase(true)] public async Task ProfileByIdHandlesServiceExceptions(bool unauthorized) + { + var profiles=new Mock();profiles.Setup(x=>x.GetUserProfileAsync(It.IsAny())).ThrowsAsync(unauthorized?new UnauthorizedAccessException():new Exception("failure")); + var controller=new ProfileController(NullLogger.Instance,Mock.Of(),profiles.Object,Mock.Of(),Mock.Of>(),Mock.Of()); + var response=await controller.DownloadProfileByUserId(Guid.NewGuid()); + if(unauthorized) Assert.That(response,Is.TypeOf());else Assert.That(((ObjectResult)response).StatusCode,Is.EqualTo(500)); + } + [Test] public async Task ProfileByIdMapsRequestedUser() + { + var id=Guid.NewGuid();var value=new UserProfile{Id=id};var profiles=new Mock();profiles.Setup(x=>x.GetUserProfileAsync(id)).ReturnsAsync(value); + var mapper=new Mock();var dto=new Govor.Contracts.DTOs.UserProfileDto();mapper.Setup(x=>x.Map(value)).Returns(dto); + var controller=new ProfileController(NullLogger.Instance,Mock.Of(),profiles.Object,Mock.Of(),Mock.Of>(),mapper.Object); + Assert.That(((OkObjectResult)await controller.DownloadProfileByUserId(id)).Value,Is.SameAs(dto)); + } + [TestCase(0)] [TestCase(1)] [TestCase(2)] public async Task MediaUploadFailuresAreMapped(int kind) + { + var media=new Mock(); + if(kind==0) media.Setup(x=>x.UploadMediaAsync(It.IsAny())).ReturnsAsync(Result.Failure(Error.ServerError("storage","failure"))); + else media.Setup(x=>x.UploadMediaAsync(It.IsAny())).ThrowsAsync(kind==1?new UnauthorizedAccessException():new Exception("failure")); + using var stream=new MemoryStream([1]);using var controller=new MediaController(NullLogger.Instance,media.Object,Mock.Of(),Mock.Of()); + var response=await controller.Upload(new(){FromFile=new FormFile(stream,0,1,"file","avatar.png"),OwnerType=MediaOwnerType.Avatar,MimeType="image/png"}); + if(kind==1) Assert.That(response,Is.TypeOf());else Assert.That(((ObjectResult)response).StatusCode,Is.EqualTo(500)); + } + [TestCase(0)] [TestCase(1)] public async Task MediaUploadRejectsMissingMimeAndOversizeBeforeStorage(int kind) + { + var media=new Mock(MockBehavior.Strict);var file=new Mock();file.SetupGet(x=>x.Length).Returns(kind==0?1:20_000_001); + using var controller=new MediaController(NullLogger.Instance,media.Object,Mock.Of(),Mock.Of()); + Assert.That(await controller.Upload(new(){FromFile=file.Object,OwnerType=MediaOwnerType.Avatar,MimeType=kind==0?" ":"image/png"}),Is.TypeOf());media.VerifyNoOtherCalls(); + } + [Test] public async Task OnlineStatusReaderFailureProduces500() + { + var presence=new Mock();presence.Setup(x=>x.GetLastSeenAsync(It.IsAny())).ThrowsAsync(new Exception("failure")); + using var controller=new OnlinePingingController(NullLogger.Instance,Mock.Of(),Mock.Of(),presence.Object,Mock.Of()); + Assert.That(((ObjectResult)await controller.GetStatus(Guid.NewGuid())).StatusCode,Is.EqualTo(500)); + } + [Test] public async Task PushRegistrationHidesUnexpectedServiceFailure() + { + var push=new Mock();push.Setup(x=>x.AddOrUpdateTokenAsync(It.IsAny(),It.IsAny(),"token","android")).ThrowsAsync(new Exception("private detail")); + using var controller=new PushTokensController(push.Object,Mock.Of(),Mock.Of(),NullLogger.Instance){ControllerContext=new(){HttpContext=new DefaultHttpContext()}}; + var result=(ObjectResult)await controller.RegisterToken(new(){Token="token",Platform="android"}); + Assert.That(result.StatusCode,Is.EqualTo(500));Assert.That(((ProblemDetails)result.Value!).Detail,Does.Not.Contain("private detail")); + } +} + diff --git a/Govor.API.Tests/IntegrationTests/Controllers/FriendsRequestQueryControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/FriendsRequestQueryControllerTests.cs similarity index 84% rename from Govor.API.Tests/IntegrationTests/Controllers/FriendsRequestQueryControllerTests.cs rename to tests/Govor.API.Tests/Unit/Controllers/FriendsRequestQueryControllerTests.cs index 2f9b8a1..2134235 100644 --- a/Govor.API.Tests/IntegrationTests/Controllers/FriendsRequestQueryControllerTests.cs +++ b/tests/Govor.API.Tests/Unit/Controllers/FriendsRequestQueryControllerTests.cs @@ -1,26 +1,23 @@ using AutoFixture; using AutoMapper; using Govor.API.Controllers.Friends; -using Govor.Application.Interfaces.Friends; -using Govor.Application.Interfaces.Infrastructure.Extensions; using Govor.Contracts.DTOs; using Govor.Domain.Models; using Microsoft.AspNetCore.Mvc; using Microsoft.Extensions.Logging; using Moq; -namespace Govor.API.Tests.IntegrationTests.Controllers; +namespace Govor.API.Tests.Unit.Controllers; [TestFixture] public class FriendsRequestQueryControllerTests { - private Fixture _fixture; - private Mock> _loggerMock; - private Mock _friendsServiceMock; - private Mock _currentUserServiceMock; - private Mock _mapperMock; - private FriendsRequestQueryController _controller; - + private Fixture _fixture = null!; + private Mock> _loggerMock = null!; + private Mock _friendsServiceMock = null!; + private Mock _currentUserServiceMock = null!; + private Mock _mapperMock = null!; + private FriendsRequestQueryController _controller = null!; [SetUp] public void SetUp() { @@ -76,7 +73,7 @@ public class FriendsRequestQueryControllerTests } [Test] - public async Task GetIncomingRequests_Throws_InvalidOperationException_ReturnsBadRequest() + public async Task GetIncomingRequests_ServiceFailure_Returns500() { // Arrange var currentId = _fixture.Create(); @@ -91,12 +88,7 @@ public class FriendsRequestQueryControllerTests var result = await _controller.GetIncomingRequests(); // Assert - Assert.That(result, Is.InstanceOf()); - var okResult = result as OkObjectResult; - List value = okResult.Value as List; - - Assert.That(value, Is.Not.Null); - Assert.That(value.Count, Is.EqualTo(0)); + Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500)); } [Test] @@ -156,7 +148,7 @@ public class FriendsRequestQueryControllerTests } [Test] - public async Task GetResponses_Throws_InvalidOperationException_ReturnsEmptyList() + public async Task GetResponses_ServiceFailure_Returns500() { // Arrange var currentId = _fixture.Create(); @@ -171,12 +163,7 @@ public class FriendsRequestQueryControllerTests var result = await _controller.GetResponses(); // Assert - Assert.That(result, Is.InstanceOf()); - var okResult = result as OkObjectResult; - List value = okResult.Value as List; - - Assert.That(value, Is.Not.Null); - Assert.That(value.Count, Is.EqualTo(0)); + Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500)); } [Test] @@ -205,4 +192,4 @@ public class FriendsRequestQueryControllerTests { _controller?.Dispose(); } -} \ No newline at end of file +} diff --git a/Govor.API.Tests/IntegrationTests/Controllers/FriendshipControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/FriendshipControllerTests.cs similarity index 89% rename from Govor.API.Tests/IntegrationTests/Controllers/FriendshipControllerTests.cs rename to tests/Govor.API.Tests/Unit/Controllers/FriendshipControllerTests.cs index 98eb09e..83a61fa 100644 --- a/Govor.API.Tests/IntegrationTests/Controllers/FriendshipControllerTests.cs +++ b/tests/Govor.API.Tests/Unit/Controllers/FriendshipControllerTests.cs @@ -2,26 +2,23 @@ using AutoFixture; using AutoMapper; using Govor.API.Controllers.Friends; using Govor.Application.Exceptions.FriendsService; -using Govor.Application.Interfaces.Friends; -using Govor.Application.Interfaces.Infrastructure.Extensions; using Govor.Contracts.DTOs; using Govor.Domain.Models.Users; using Microsoft.AspNetCore.Mvc; using Microsoft.Extensions.Logging; using Moq; -namespace Govor.API.Tests.IntegrationTests.Controllers; +namespace Govor.API.Tests.Unit.Controllers; [TestFixture] public class FriendshipControllerTests { - private Fixture _fixture; - private Mock> _loggerMock; - private Mock _friendsServiceMock; - private Mock _currentUserServiceMock; - private Mock _mapperMock; - private FriendshipController _controller; - + private Fixture _fixture = null!; + private Mock> _loggerMock = null!; + private Mock _friendsServiceMock = null!; + private Mock _currentUserServiceMock = null!; + private Mock _mapperMock = null!; + private FriendshipController _controller = null!; [SetUp] public void SetUp() { @@ -127,7 +124,7 @@ public class FriendshipControllerTests } [Test] - public async Task GetFriends_InvalidOperationException_ReturnsBadRequest() + public async Task GetFriends_ServiceFailure_Returns500() { // Arrange var currentId = _fixture.Create(); @@ -143,7 +140,7 @@ public class FriendshipControllerTests var result = await _controller.GetFriends(); // Assert - Assert.That(result, Is.InstanceOf()); + Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500)); } [Test] @@ -174,4 +171,4 @@ public class FriendshipControllerTests { _controller.Dispose(); } -} \ No newline at end of file +} diff --git a/tests/Govor.API.Tests/Unit/Controllers/MediaControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/MediaControllerTests.cs new file mode 100644 index 0000000..35eb8fe --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/MediaControllerTests.cs @@ -0,0 +1,112 @@ +using System.ComponentModel.DataAnnotations; +using Govor.API.Controllers; +using Govor.Application.E2ee; +using Govor.Application.Medias; +using Govor.Contracts.Requests; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Messages; +using Microsoft.AspNetCore.Http; +using Microsoft.AspNetCore.Mvc; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class MediaControllerTests +{ + private Mock _media = null!; + private Mock _access = null!; + private MediaController _controller = null!; + private readonly Guid _user = Guid.NewGuid(); + + [SetUp] + public void SetUp() + { + _media = new Mock(); + _access = new Mock(); + var current = new Mock(); + current.Setup(c => c.GetCurrentUserId()).Returns(_user); + _controller = new(NullLogger.Instance, _media.Object, _access.Object, current.Object); + } + + private static MediaUploadRequest Request(string mime = E2eeProtocol.EncryptedMimeType, string key = "") => + new() { FromFile = new FormFile(new MemoryStream(new byte[] { 1, 2, 3 }), 0, 3, "file", "encrypted.bin"), + Type = MediaType.File, MimeType = mime, EncryptedKey = key, OwnerType = MediaOwnerType.Message }; + + [Test] + public async Task EncryptedUploadPassesCiphertextWithoutKeysToService() + { + var upload = new MediaUploadResult(Guid.NewGuid(), "stored.bin"); + _media.Setup(m => m.UploadMediaAsync(It.IsAny())).ReturnsAsync(upload); + var request = Request(); + var validation = new List(); + Assert.That(Validator.TryValidateObject(request, new ValidationContext(request), validation, true), + Is.True, string.Join("; ", validation.Select(v => v.ErrorMessage))); + Assert.That(((OkObjectResult)await _controller.Upload(request)).Value, Is.SameAs(upload)); + _media.Verify(m => m.UploadMediaAsync(It.Is(data => data.UploaderId == _user && + data.EncryptedKey == "" && data.Data.SequenceEqual(new byte[] { 1, 2, 3 }) && + data.MimeType == E2eeProtocol.EncryptedMimeType && data.OwnerId == null)), Times.Once); + } + + [TestCase("image/png", "")] + [TestCase(E2eeProtocol.EncryptedMimeType, "decryption-secret")] + public async Task PlaintextAttachmentOrLeakedKeyIsRejected(string mime, string key) + { + Assert.That(await _controller.Upload(Request(mime, key)), Is.TypeOf()); + _media.VerifyNoOtherCalls(); + } + + [TestCase(MediaOwnerType.System)] + [TestCase(MediaOwnerType.GroupAvatar)] + [TestCase(MediaOwnerType.Reaction)] + public async Task UnsupportedOwnerIsRejected(MediaOwnerType type) + { + var request = Request(); + request.OwnerType = type; + Assert.That(await _controller.Upload(request), Is.TypeOf()); + _media.VerifyNoOtherCalls(); + } + + [Test] + public async Task MissingFileAndInvalidModelAreRejected() + { + var request = Request(); + request.FromFile = null!; + Assert.That(await _controller.Upload(request), Is.TypeOf()); + _controller.ModelState.AddModelError("file", "invalid"); + Assert.That(await _controller.Upload(Request()), Is.TypeOf()); + _media.VerifyNoOtherCalls(); + } + + [Test] + public async Task DownloadDeniesAccessBeforeLoadingFile() + { + Assert.That(await _controller.Download(Guid.NewGuid()), Is.TypeOf()); + _media.VerifyNoOtherCalls(); + } + + [Test] + public async Task DownloadReturnsBytesAndSanitizesFileName() + { + var id = Guid.NewGuid(); + _access.Setup(a => a.HasAccessAsync(id, _user)).ReturnsAsync(true); + _media.Setup(m => m.GetMediaByIdAsync(id)).ReturnsAsync(new Media(_user, DateTime.UtcNow, + "folder/encrypted.bin", new byte[] { 1, 2 }, MediaType.File, E2eeProtocol.EncryptedMimeType, "", MediaOwnerType.Message, null)); + var response = (FileContentResult)await _controller.Download(id); + Assert.That(response.FileContents, Is.EqualTo(new byte[] { 1, 2 })); + Assert.That(response.FileDownloadName, Is.EqualTo("encrypted.bin")); + Assert.That(response.ContentType, Is.EqualTo(E2eeProtocol.EncryptedMimeType)); + } + + [TestCase(ErrorType.NotFound, 404)] + [TestCase(ErrorType.ServerError, 500)] + public async Task DownloadServiceFailureReturnsProblemDetails(ErrorType type, int status) + { + var id = Guid.NewGuid(); + _access.Setup(a => a.HasAccessAsync(id, _user)).ReturnsAsync(true); + _media.Setup(m => m.GetMediaByIdAsync(id)).ReturnsAsync(Result.Failure(new Error("Media.Failed", "failure", type))); + Assert.That(((ObjectResult)await _controller.Download(id)).StatusCode, Is.EqualTo(status)); + } +} diff --git a/Govor.API.Tests/IntegrationTests/Controllers/OnlinePingingControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/OnlinePingingControllerTests.cs similarity index 78% rename from Govor.API.Tests/IntegrationTests/Controllers/OnlinePingingControllerTests.cs rename to tests/Govor.API.Tests/Unit/Controllers/OnlinePingingControllerTests.cs index d99c066..51b05ba 100644 --- a/Govor.API.Tests/IntegrationTests/Controllers/OnlinePingingControllerTests.cs +++ b/tests/Govor.API.Tests/Unit/Controllers/OnlinePingingControllerTests.cs @@ -1,21 +1,18 @@ using Govor.API.Controllers; -using Govor.Application.Interfaces; -using Govor.Application.Interfaces.Infrastructure.Extensions; using Govor.Application.PingHandler; using Microsoft.AspNetCore.Mvc; using Microsoft.Extensions.Logging; using Moq; -namespace Govor.API.Tests.IntegrationTests.Controllers; +namespace Govor.API.Tests.Unit.Controllers; [TestFixture] public class OnlinePingingControllerTests { - private Mock> _loggerMock; - private Mock _pingHandlerServiceMock; - private Mock _currentUserServiceMock; - private OnlinePingingController _controller; - + private Mock> _loggerMock = null!; + private Mock _pingHandlerServiceMock = null!; + private Mock _currentUserServiceMock = null!; + private OnlinePingingController _controller = null!; [SetUp] public void SetUp() { @@ -23,7 +20,7 @@ public class OnlinePingingControllerTests _pingHandlerServiceMock = new Mock(); _currentUserServiceMock = new Mock(); _controller = new OnlinePingingController(_loggerMock.Object, _pingHandlerServiceMock.Object, - _currentUserServiceMock.Object); + _currentUserServiceMock.Object, Mock.Of(), Mock.Of()); } [Test] @@ -44,7 +41,7 @@ public class OnlinePingingControllerTests } [Test] - public async Task Ping_InvalidOperationException_ReturnsBadRequest() + public async Task Ping_InvalidOperationException_Returns500() { // Arrange var userId = Guid.NewGuid(); @@ -56,14 +53,12 @@ public class OnlinePingingControllerTests var result = await _controller.Ping(); // Assert - Assert.That(result, Is.InstanceOf()); - var badRequestResult = (BadRequestObjectResult)result; - Assert.That(badRequestResult.Value, Is.EqualTo("User can't be found in our database.")); + Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500)); _loggerMock.VerifyLog(LogLevel.Error, exception.Message, Times.Once()); } [Test] - public async Task Ping_UnauthorizedAccessException_ReturnsForbid() + public async Task Ping_ServiceException_Returns500() { // Arrange var userId = Guid.NewGuid(); @@ -75,7 +70,7 @@ public class OnlinePingingControllerTests var result = await _controller.Ping(); // Assert - Assert.That(result, Is.InstanceOf()); + Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500)); _loggerMock.VerifyLog(LogLevel.Error, exception.Message, Times.Once()); } @@ -99,7 +94,7 @@ public class OnlinePingingControllerTests } [Test] - public async Task Ping_UnauthorizedUserId_ThrowsUnauthorizedAccessException() + public async Task Ping_CurrentUserException_Returns500WithoutPinging() { // Arrange var exception = new UnauthorizedAccessException("userID claim is missing or invalid"); @@ -109,7 +104,7 @@ public class OnlinePingingControllerTests var result = await _controller.Ping(); // Assert - Assert.That(result, Is.InstanceOf()); + Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500)); _loggerMock.VerifyLog(LogLevel.Error, exception.Message, Times.Once()); _pingHandlerServiceMock.Verify(x => x.Ping(It.IsAny()), Times.Never()); } @@ -133,7 +128,7 @@ public static class LoggerMockExtensions It.IsAny(), It.Is((v, t) => v.ToString().Contains(message)), It.IsAny(), - It.IsAny>()), + It.IsAny>()), times); } } diff --git a/tests/Govor.API.Tests/Unit/Controllers/PrivateChatControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/PrivateChatControllerTests.cs new file mode 100644 index 0000000..57104c5 --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/PrivateChatControllerTests.cs @@ -0,0 +1,59 @@ +using Govor.API.Controllers; +using Govor.Application.Friends; +using Govor.Application.Exceptions.VerifyFriendship; +using Govor.Application.Infrastructure.Extensions; +using Govor.Application.PrivateUserChats; +using Govor.Contracts.DTOs; +using Govor.Domain.Models; +using Microsoft.AspNetCore.Mvc; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class PrivateChatControllerTests +{ + private readonly Guid _user=Guid.NewGuid(),_friend=Guid.NewGuid(); + private Mock _verify=null!; + private Mock _creator=null!; + private Mock _getter=null!; + private PrivateChatController _controller=null!; + [SetUp] public void Setup() + { + _verify=new(); _creator=new(); _getter=new(); + var user=new Mock(); user.Setup(x=>x.GetCurrentUserId()).Returns(_user); + _controller=new(user.Object,_verify.Object,_creator.Object,_getter.Object,NullLogger.Instance); + } + [TearDown] public void TearDown()=>_controller.Dispose(); + [Test] public async Task FriendshipIsVerifiedBeforeCreatingChat() + { + var order=new List(); var chat=new PrivateChat{Id=Guid.NewGuid()}; + _verify.Setup(x=>x.VerifyAsync(_user,_friend)).Callback(()=>order.Add("verify")).Returns(Task.CompletedTask); + _creator.Setup(x=>x.CreateAsync(_user,_friend)).Callback(()=>order.Add("create")).ReturnsAsync(chat); + Assert.That(((OkObjectResult)await _controller.GetChatByFriendId(_friend)).Value,Is.EqualTo(chat.Id)); + Assert.That(order,Is.EqualTo(new[]{"verify","create"})); + } + [TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)] + public async Task VerificationFailuresNeverCreateChat(int kind) + { + Exception error=kind switch{0=>new UnauthorizedAccessException(),1=>new ArgumentException("invalid"),2=>new FriendshipException("denied"),_=>new Exception("private")}; + _verify.Setup(x=>x.VerifyAsync(_user,_friend)).ThrowsAsync(error); + var result=await _controller.GetChatByFriendId(_friend); + if(kind is 0 or 2) Assert.That(result,Is.TypeOf()); + else Assert.That(((ObjectResult)result).StatusCode,Is.EqualTo(kind==1?400:500)); + _creator.VerifyNoOtherCalls(); + } + [Test] public async Task ChatListSelectsOtherParticipantForBothOrientations() + { + _getter.Setup(x=>x.GetUserChatsAsync(_user)).ReturnsAsync([new(){Id=Guid.NewGuid(),UserAId=_user,UserBId=_friend},new(){Id=Guid.NewGuid(),UserAId=_friend,UserBId=_user}]); + var result=(List)((OkObjectResult)await _controller.GetChatsByFriends()).Value!; + Assert.That(result.Select(x=>x.FriendId),Is.EqualTo(new[]{_friend,_friend})); + } + [TestCase(false)] [TestCase(true)] public async Task ChatListHandlesErrors(bool unauthorized) + { + _getter.Setup(x=>x.GetUserChatsAsync(_user)).ThrowsAsync(unauthorized?new UnauthorizedAccessException():new Exception("private")); + var result=await _controller.GetChatsByFriends(); + if(unauthorized) Assert.That(result,Is.TypeOf()); else Assert.That(((ObjectResult)result).StatusCode,Is.EqualTo(500)); + } +} diff --git a/Govor.API.Tests/IntegrationTests/Controllers/ProfileControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/ProfileControllerTests.cs similarity index 93% rename from Govor.API.Tests/IntegrationTests/Controllers/ProfileControllerTests.cs rename to tests/Govor.API.Tests/Unit/Controllers/ProfileControllerTests.cs index 83653e8..7d06a61 100644 --- a/Govor.API.Tests/IntegrationTests/Controllers/ProfileControllerTests.cs +++ b/tests/Govor.API.Tests/Unit/Controllers/ProfileControllerTests.cs @@ -1,16 +1,12 @@ -using System.Text; +using System.Text; using AutoMapper; using Govor.API.Controllers; using Govor.API.Hubs; -using Govor.Application.Interfaces; -using Govor.Application.Interfaces.Infrastructure.Extensions; -using Govor.Application.Interfaces.Medias; using Govor.Application.Profiles; using Govor.Contracts.DTOs; using Govor.Contracts.Requests; using Govor.Domain.Models; using Govor.Domain.Models.Messages; -using Govor.Data.Repositories.Exceptions; using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.SignalR; @@ -34,7 +30,6 @@ private Mock> _mockLogger = null!; private ProfileController _controller = null!; private Guid _userId; - [SetUp] public void SetUp() { @@ -137,7 +132,7 @@ private Mock> _mockLogger = null!; .ReturnsAsync(expectedMediaInfo); _mockProfileService.Setup(s => s.SetNewIcon(_userId, mediaId)) - .Returns(Task.CompletedTask); + .ReturnsAsync(Govor.Domain.Common.Result.Success()); // Act var result = await _controller.UploadAvatar(request); @@ -240,19 +235,20 @@ private Mock> _mockLogger = null!; } [Test] - public async Task DowloadProfile_ReturnsBadRequest_WhenNotFoundExceptionThrown() + public async Task DownloadProfile_MissingProfile_Returns404ProblemDetails() { // Arrange _mockProfileService.Setup(s => s.GetUserProfileAsync(_userId)) - .ThrowsAsync(new NotFoundException("Cannot find profile")); + .ReturnsAsync(Govor.Domain.Common.Result.Failure( + Govor.Domain.Common.Error.NotFound("Profile.UserNotFound", "Cannot find profile"))); // Act var result = await _controller.DownloadProfile(); // Assert - var notFoundResult = result as NotFoundObjectResult; - Assert.That(notFoundResult, Is.Not.Null); - Assert.That(notFoundResult!.Value, Is.EqualTo("Profile not found")); + var response = (ObjectResult)result; + Assert.That(response.StatusCode, Is.EqualTo(404)); + Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Profile.UserNotFound")); } [Test] @@ -271,4 +267,4 @@ private Mock> _mockLogger = null!; Assert.That(objectResult!.StatusCode, Is.EqualTo(500)); Assert.That(objectResult.Value, Is.EqualTo("Unexpected Error! Please try again later.")); } -} \ No newline at end of file +} diff --git a/tests/Govor.API.Tests/Unit/Controllers/ReactionPackControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/ReactionPackControllerTests.cs new file mode 100644 index 0000000..db2a58e --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/ReactionPackControllerTests.cs @@ -0,0 +1,92 @@ +using AutoMapper; +using Govor.API.Controllers; +using Govor.API.Controllers.AdminStuff; +using Govor.Application.Infrastructure.Extensions; +using Govor.Application.Reactions; +using Govor.Contracts.Responses; +using Govor.Domain.Common; +using Govor.Domain.Models.Reactions; +using Microsoft.AspNetCore.Http; +using Microsoft.AspNetCore.Mvc; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class ReactionPackControllerTests +{ + private readonly Guid _user=Guid.NewGuid(),_pack=Guid.NewGuid(),_reaction=Guid.NewGuid(); + private Mock _packs=null!; + private Mock _mapper=null!; + private ReactionPacksController _controller=null!; + private ReactionPacksAdminController _admin=null!; + private ReactionPackResponse _packResponse=null!; + private ReactionItemResponse _itemResponse=null!; + [SetUp] public void Setup() + { + _packs=new();_mapper=new();var user=new Mock();user.Setup(x=>x.GetCurrentUserId()).Returns(_user); + _packResponse=new();_itemResponse=new(); + _mapper.Setup(x=>x.Map(It.IsAny())).Returns(_packResponse); + _mapper.Setup(x=>x.Map(It.IsAny())).Returns(_itemResponse); + _controller=new(_packs.Object,user.Object,_mapper.Object); + _admin=new(_packs.Object,user.Object,_mapper.Object){ControllerContext=new(){HttpContext=new DefaultHttpContext()}}; + } + [TestCase(false)] [TestCase(true)] public async Task ListsForwardPaginationAndVisibility(bool admin) + { + var list=new List();var mapped=new List(); + _packs.Setup(x=>x.ListAsync(_user,false,admin,7,9)).ReturnsAsync(list); + _mapper.Setup(x=>x.Map>(list)).Returns(mapped); + var result=admin?await _admin.List(7,9):await _controller.List(7,9); + Assert.That(((OkObjectResult)result).Value,Is.SameAs(mapped)); + _packs.Verify(x=>x.ListAsync(_user,false,admin,7,9),Times.Once); + _packs.Setup(x=>x.ListAsync(_user,true,false,4,6)).ReturnsAsync(list); + Assert.That(((OkObjectResult)await _controller.Mine(4,6)).Value,Is.SameAs(mapped)); + _packs.Verify(x=>x.ListAsync(_user,true,false,4,6),Times.Once); + } + [TestCase(false)] [TestCase(true)] public async Task GetMapsSuccessfulPackOrPreservesFailure(bool failure) + { + _packs.Setup(x=>x.GetAsync(_pack,It.IsAny())).ReturnsAsync(failure?Result.Failure(Error.NotFound("missing","missing")):new ReactionPack()); + foreach(var result in new[]{await _controller.Get(_pack),await _admin.Get(_pack)}) + if(failure) Assert.That(((ObjectResult)result).StatusCode,Is.EqualTo(404));else Assert.That(((OkObjectResult)result).Value,Is.SameAs(_packResponse)); + _packs.Verify(x=>x.GetAsync(_pack,true),Times.Once);_packs.Verify(x=>x.GetAsync(_pack,false),Times.Once); + } + [Test] public async Task SharedAndReactionMapContracts() + { + _packs.Setup(x=>x.GetSharedAsync("share")).ReturnsAsync(new ReactionPack());_packs.Setup(x=>x.GetReactionAsync(_reaction)).ReturnsAsync(new ReactionItem()); + Assert.That(((OkObjectResult)await _controller.Shared("share")).Value,Is.SameAs(_packResponse)); + Assert.That(((OkObjectResult)await _controller.Reaction(_reaction)).Value,Is.SameAs(_itemResponse)); + Assert.That(_controller.Limits(),Is.TypeOf()); + } + [TestCase(false)] [TestCase(true)] public async Task SubscriptionsForwardDesiredState(bool subscribe) + { + _packs.Setup(x=>x.SubscribeAsync(_user,_pack,subscribe)).ReturnsAsync(SmartRes.Unit.Value); + var result=subscribe?await _controller.Subscribe(_pack):await _controller.Unsubscribe(_pack); + Assert.That(((StatusCodeResult)result).StatusCode,Is.EqualTo(204));_packs.Verify(x=>x.SubscribeAsync(_user,_pack,subscribe),Times.Once); + } + [Test] public async Task AdminMutationsForwardActorFieldsAndMapContracts() + { + _packs.Setup(x=>x.CreateAsync(_user,"name","desc")).ReturnsAsync(new ReactionPack()); + _packs.Setup(x=>x.UpdateAsync(_user,_pack,"new","changed",false)).ReturnsAsync(new ReactionPack()); + _packs.Setup(x=>x.DisableAsync(_user,_pack)).ReturnsAsync(SmartRes.Unit.Value); + _packs.Setup(x=>x.AddEmojiAsync(_user,_pack,"emoji","👍")).ReturnsAsync(new ReactionItem()); + _packs.Setup(x=>x.DisableReactionAsync(_user,_pack,_reaction)).ReturnsAsync(SmartRes.Unit.Value); + Assert.That(((OkObjectResult)await _admin.Create(new(){Name="name",Description="desc"})).Value,Is.SameAs(_packResponse)); + Assert.That(((OkObjectResult)await _admin.Update(_pack,new(){Name="new",Description="changed",IsEnabled=false})).Value,Is.SameAs(_packResponse)); + Assert.That(((StatusCodeResult)await _admin.Disable(_pack)).StatusCode,Is.EqualTo(204)); + Assert.That(((OkObjectResult)await _admin.Emoji(_pack,new(){Name="emoji",Emoji="👍"})).Value,Is.SameAs(_itemResponse)); + Assert.That(((StatusCodeResult)await _admin.DisableReaction(_pack,_reaction)).StatusCode,Is.EqualTo(204)); + } + [TestCase(-1)] [TestCase(0)] [TestCase(2_097_153)] public async Task MediaRejectsMissingEmptyOrOversizedFile(int length) + { + var file=new Mock();file.SetupGet(x=>x.Length).Returns(length); + Assert.That(await _admin.Media(_pack,new(){File=length<0?null!:file.Object}),Is.TypeOf());_packs.VerifyNoOtherCalls(); + } + [Test] public async Task MediaCopiesBytesAndPassesRequestCancellation() + { + using var stream=new MemoryStream([1,2,3]);using var cancellation=new CancellationTokenSource();_admin.HttpContext.RequestAborted=cancellation.Token; + _packs.Setup(x=>x.AddMediaAsync(_user,_pack,"image",It.Is(b=>b.SequenceEqual(new byte[]{1,2,3})),cancellation.Token)).ReturnsAsync(new ReactionItem()); + var result=await _admin.Media(_pack,new(){Name="image",File=new FormFile(stream,0,3,"file","image.png")}); + Assert.That(((OkObjectResult)result).Value,Is.SameAs(_itemResponse)); + _packs.Verify(x=>x.AddMediaAsync(_user,_pack,"image",It.IsAny(),cancellation.Token),Times.Once); + } +} diff --git a/tests/Govor.API.Tests/Unit/Controllers/SessionControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/SessionControllerTests.cs new file mode 100644 index 0000000..d232804 --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/SessionControllerTests.cs @@ -0,0 +1,93 @@ +using AutoMapper; +using Govor.API.Controllers; +using Govor.Application.Users.UserSessions; +using Govor.Contracts.DTOs; +using Govor.Domain.Common; +using Govor.Domain.Models.Users; +using Microsoft.AspNetCore.Mvc; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class SessionControllerTests +{ + private SessionController _controller = null!; + private Mock _reader = null!; + private Mock _revoker = null!; + private Mock _mapper = null!; + private readonly Guid _user = Guid.NewGuid(), _session = Guid.NewGuid(); + + [SetUp] + public void SetUp() + { + _reader = new Mock(); + _revoker = new Mock(); + _mapper = new Mock(); + var current = new Mock(); + current.Setup(c => c.GetCurrentUserId()).Returns(_user); + var session = new Mock(); + session.Setup(s => s.GetUserSessionId()).Returns(_session); + _controller = new(NullLogger.Instance, current.Object, + session.Object, _reader.Object, _revoker.Object, _mapper.Object); + } + + [Test] + public async Task SessionsAreReadForCurrentUserAndMapped() + { + var sessions = new List { new() { Id = _session, UserId = _user } }; + var dtos = new List { new() { Id = _session } }; + _reader.Setup(r => r.GetAllSessionsAsync(_user)).ReturnsAsync(sessions); + _mapper.Setup(m => m.Map>(sessions)).Returns(dtos); + Assert.That(((OkObjectResult)await _controller.GetAllSessions()).Value, Is.SameAs(dtos)); + } + + [Test] + public async Task CloseActionsReturn204AndUseCurrentOwner() + { + _revoker.Setup(r => r.CloseSessionByIdAsync(_session, _user)).ReturnsAsync(Result.Success()); + _revoker.Setup(r => r.CloseAllSessionsAsync(_user)).ReturnsAsync(Result.Success()); + Assert.That(((StatusCodeResult)await _controller.CloseSession(_session)).StatusCode, Is.EqualTo(204)); + Assert.That(((StatusCodeResult)await _controller.CloseCurrent()).StatusCode, Is.EqualTo(204)); + Assert.That(((StatusCodeResult)await _controller.CloseAllSessions()).StatusCode, Is.EqualTo(204)); + _revoker.Verify(r => r.CloseSessionByIdAsync(_session, _user), Times.Exactly(2)); + _revoker.Verify(r => r.CloseAllSessionsAsync(_user), Times.Once); + } + + [Test] + public async Task EmptySessionIdDoesNotRevokeAnything() + { + Assert.That(await _controller.CloseSession(Guid.Empty), Is.TypeOf()); + _revoker.VerifyNoOtherCalls(); + } + + [TestCase(ErrorType.NotFound, 404)] + [TestCase(ErrorType.Conflict, 409)] + [TestCase(ErrorType.Forbidden, 403)] + public async Task CloseFailuresReturnProblemDetails(ErrorType type, int status) + { + _revoker.Setup(r => r.CloseSessionByIdAsync(_session, _user)) + .ReturnsAsync(Result.Failure(new Error("Session.Failed", "failure", type))); + foreach (var action in new Func>[] { () => _controller.CloseSession(_session), _controller.CloseCurrent }) + { + var response = (ObjectResult)await action(); + Assert.That(response.StatusCode, Is.EqualTo(status)); + Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Session.Failed")); + } + } + + [Test] + public async Task UnauthorizedCurrentUserReturnsForbid() + { + _reader.Setup(r => r.GetAllSessionsAsync(_user)).ThrowsAsync(new UnauthorizedAccessException()); + Assert.That(await _controller.GetAllSessions(), Is.TypeOf()); + } + + [Test] + public async Task UnexpectedReaderExceptionReturns500() + { + _reader.Setup(r => r.GetAllSessionsAsync(_user)).ThrowsAsync(new Exception("database unavailable")); + Assert.That(((ObjectResult)await _controller.GetAllSessions()).StatusCode, Is.EqualTo(500)); + } +} diff --git a/tests/Govor.API.Tests/Unit/Controllers/SessionKeysControllerTests.cs b/tests/Govor.API.Tests/Unit/Controllers/SessionKeysControllerTests.cs new file mode 100644 index 0000000..8f4faaa --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Controllers/SessionKeysControllerTests.cs @@ -0,0 +1,92 @@ +using Govor.API.Controllers.Authentication; +using Govor.Application.Friends; +using Govor.Application.Infrastructure.Extensions; +using Govor.Application.Users.UserSessions.Crypto; +using Govor.Contracts.Requests; +using Govor.Contracts.DTOs; +using Govor.Domain.Models.Users; +using Govor.Domain.Models.Users.Crypto; +using Microsoft.AspNetCore.Mvc; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Controllers; + +[TestFixture] +public class SessionKeysControllerTests +{ + private readonly Guid _user = Guid.NewGuid(), _session = Guid.NewGuid(), _friend = Guid.NewGuid(); + private Mock _friends = null!; + private Mock _attacher = null!; + private Mock _reader = null!; + private Mock _rotator = null!; + private SessionKeysController _controller = null!; + + [SetUp] + public void Setup() + { + _friends = new(); _attacher = new(); _reader = new(); _rotator = new(); + var user = new Mock(); user.Setup(x => x.GetCurrentUserId()).Returns(_user); + var session = new Mock(); session.Setup(x => x.GetUserSessionId()).Returns(_session); + _controller = new(NullLogger.Instance, _friends.Object, session.Object, _attacher.Object, _reader.Object, user.Object, _rotator.Object); + } + + [TestCase(false, 0)] [TestCase(false, 100)] [TestCase(false, 101)] [TestCase(true, 1)] + public async Task UploadValidatesModelAndKeyCount(bool invalidModel, int count) + { + var request = new UploadKeysRequest { IdentityKey = [1], SignedPreKey = [2], SignedPreKeySignature = [3], OneTimePreKeys = Enumerable.Range(0,count).Select(_ => new byte[] {4}).ToList() }; + if (invalidModel) _controller.ModelState.AddModelError("keys", "invalid"); + var result = await _controller.UploadSessionKeys(request); + if (invalidModel || count > 100) { Assert.That(result, Is.TypeOf()); _attacher.VerifyNoOtherCalls(); } + else { + Assert.That(result, Is.TypeOf()); + _attacher.Verify(x => x.AttachKeysAsync(_session, request.IdentityKey, request.SignedPreKey, request.SignedPreKeySignature, request.OneTimePreKeys), Times.Once); + } + } + + [TestCase(false, 0)] [TestCase(false, 100)] [TestCase(false, 101)] [TestCase(true, 1)] + public async Task RotationValidatesAndUsesAuthenticatedSession(bool invalidModel, int count) + { + var request = new RotateOneTimePreKeysRequest { NewOneTimePreKeys = Enumerable.Range(0,count).Select(_ => new byte[] {4}).ToList() }; + if (invalidModel) _controller.ModelState.AddModelError("keys", "invalid"); + var result = await _controller.RotateOneTimePreKeys(request); + if (invalidModel || count > 100) { Assert.That(result, Is.TypeOf()); _rotator.VerifyNoOtherCalls(); } + else { Assert.That(result, Is.TypeOf()); _rotator.Verify(x => x.RotateOneTimePreKeysAsync(_session, request.NewOneTimePreKeys), Times.Once); } + } + + [Test] + public async Task NonFriendCannotReadKeys() + { + _friends.Setup(x => x.GetFriendsAsync(_friend)).ReturnsAsync([]); + Assert.That(await _controller.GetUserPublicKeys(_friend), Is.TypeOf()); + _reader.VerifyNoOtherCalls(); + } + + [Test] + public async Task FriendKeysAreBase64AndUsedPrekeysAreExcluded() + { + _friends.Setup(x => x.GetFriendsAsync(_friend)).ReturnsAsync([new User { Id = _user }]); + var unusedId = Guid.NewGuid(); + _reader.Setup(x => x.GetAllActiveKeysAsync(_friend)).ReturnsAsync([ + new UserCryptoSession { PublicIdentityKey = [1], SignedPreKey = new() { Id = Guid.NewGuid(), PublicSignedPreKey = [2], SignedPreKeySignature = [3] }, OneTimePreKeys = [new() {Id = unusedId, PublicKey = [4]}, new() {Id = Guid.NewGuid(), PublicKey = [5], IsUsed = true}] }, + new UserCryptoSession { PublicIdentityKey = [6], SignedPreKey = null!, OneTimePreKeys = [] } + ]); + var dtos = ((IEnumerable)((OkObjectResult)await _controller.GetUserPublicKeys(_friend)).Value!).ToList(); + Assert.Multiple(() => { + Assert.That(dtos[0].IdentityKey, Is.EqualTo("AQ==")); Assert.That(dtos[0].SignedPreKey!.Key, Is.EqualTo("Ag==")); + Assert.That(dtos[0].SignedPreKey!.Signature, Is.EqualTo("Aw==")); Assert.That(dtos[0].OneTimePreKeys.Single().Id, Is.EqualTo(unusedId)); + Assert.That(dtos[0].OneTimePreKeys.Single().Key, Is.EqualTo("BA==")); Assert.That(dtos[1].SignedPreKey, Is.Null); + }); + } + + [Test] + public async Task CountAndConsumptionUseAuthenticatedSession() + { + _reader.Setup(x => x.GetRemainingOneTimePreKeysCountAsync(_session)).ReturnsAsync(17); + var result = (OkObjectResult)await _controller.GetRemainingOneTimePreKeysCount(); + Assert.That(result.Value!.GetType().GetProperty("remaining")!.GetValue(result.Value), Is.EqualTo(17)); + var key = Guid.NewGuid(); + Assert.That(await _controller.MarkOneTimePreKeyAsUsed(key), Is.TypeOf()); + _rotator.Verify(x => x.MarkOneTimePreKeyAsUsedAsync(_session, key), Times.Once); + } +} diff --git a/tests/Govor.API.Tests/Unit/Hubs/ChatsHubTests.cs b/tests/Govor.API.Tests/Unit/Hubs/ChatsHubTests.cs new file mode 100644 index 0000000..41a0336 --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Hubs/ChatsHubTests.cs @@ -0,0 +1,191 @@ +using AutoMapper; +using Govor.API.Common.SignalR.Helpers; +using Govor.API.Hubs; +using Govor.API.Hubs.Infrastructure; +using Govor.Application.Exceptions.VerifyFriendship; +using Govor.Application.Infrastructure.Common; +using Govor.Application.Messages; +using Govor.Application.Messages.Parameters; +using Govor.Application.Reactions; +using Govor.Contracts.Requests; +using Govor.Contracts.Requests.SignalR; +using Govor.Contracts.Responses.SignalR; +using Govor.Domain.Common; +using Govor.Domain.Models.Messages; +using Microsoft.AspNetCore.SignalR; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; +using System.Security.Claims; + +namespace Govor.API.Tests.Unit.Hubs; + +[TestFixture] +public class ChatsHubTests +{ + private readonly Guid _user = Guid.NewGuid(), _chat = Guid.NewGuid(); + private readonly DateTime _now = new(2026,10,24,0,0,0,DateTimeKind.Utc); + private Mock _read = null!; + private Mock _send = null!; + private Mock _edit = null!; + private Mock _remove = null!; + private Mock _reactions = null!; + private Mock _notifier = null!; + private Mock _userAccessor = null!; + private Mock _connections = null!; + private Mock _context = null!; + private Mock _groups = null!; + private Mock _mapper = null!; + private ChatsHub _hub = null!; + private Message Message() => new() { Id=Guid.NewGuid(),SenderId=_user,RecipientId=_chat,RecipientType=RecipientType.User,EncryptedContent="cipher",SentAt=_now }; + + [SetUp] + public void Setup() + { + _read=new(); _send=new(); _edit=new(); _remove=new(); _reactions=new(); _notifier=new(); _connections=new(); _groups=new(); _mapper=new(); _context=new(); _userAccessor=new(); + _userAccessor.Setup(x=>x.GetUserId(It.IsAny(),It.IsAny())).Returns(_user); + var clock=new Mock(); clock.SetupGet(x=>x.Now).Returns(_now); + _context.SetupGet(x=>x.ConnectionId).Returns("connection"); + _context.SetupGet(x=>x.User).Returns(new ClaimsPrincipal(new ClaimsIdentity(new[]{new Claim("sid",_chat.ToString())}))); + _hub=new(NullLogger.Instance,_read.Object,_send.Object,_edit.Object,_remove.Object,_userAccessor.Object,_notifier.Object,clock.Object,_connections.Object,_reactions.Object,_mapper.Object) {Context=_context.Object,Groups=_groups.Object}; + } + [TearDown] public void TearDown()=>_hub.Dispose(); + + [TestCase(false)] [TestCase(true)] + public async Task LifecycleMaintainsConnectionAndSessionGroup(bool error) + { + await _hub.OnConnectedAsync(); await _hub.OnDisconnectedAsync(error?new Exception("disconnect"):null); + _connections.Verify(x=>x.OnConnectedAsync("connection",_user),Times.Once); + _connections.Verify(x=>x.OnDisconnectedAsync("connection",_user),Times.Once); + _groups.Verify(x=>x.AddToGroupAsync("connection",ChatHubConstants.GetSessionGroup(_chat),default),Times.Once); + } + [TestCase(false)] [TestCase(true)] + public async Task MissingUserOrSessionAbortsConnection(bool missingUser) + { + if(missingUser) _userAccessor.Setup(x=>x.GetUserId(It.IsAny(),It.IsAny())).Returns(Guid.Empty); + else _context.SetupGet(x=>x.User).Returns(new ClaimsPrincipal()); + await _hub.OnConnectedAsync(); _context.Verify(x=>x.Abort(),Times.Once); _groups.VerifyNoOtherCalls(); + } + + [TestCase(false)] [TestCase(true)] + public async Task SendMapsActorClockReplyAndMediaThenNotifies(bool media) + { + var message=Message(); var mediaId=Guid.NewGuid(); var reply=Guid.NewGuid(); + if (media) message.MediaAttachments = [new() { MediaFile = new() { Id = mediaId } }]; + _send.Setup(x=>x.SendMessageAsync(It.IsAny())).ReturnsAsync(new SendMessageResult(true,null,message)); + var response=await _hub.Send(new() {RecipientId=_chat,EncryptedContent="cipher",ReplyToMessageId=reply,MediaAttachments=media?[new(){MediaId=mediaId,EncryptedKey="key"}]:null!}); + Assert.That(response.Status,Is.EqualTo(HubResultStatus.Success)); + Assert.That(response.Result!.ReplyToMessageId,Is.EqualTo(reply)); + Assert.That(response.Result.MediaAttachments.Select(m => m.Id), Is.EqualTo(media ? new[] { mediaId } : Array.Empty())); + _send.Verify(x=>x.SendMessageAsync(It.Is(p=>p.FromUserId==_user && p.RecipientId==_chat && p.SendAt==_now && p.ReplyToMessageId==reply && p.Media.Count()==(media?1:0))),Times.Once); + _notifier.Verify(x=>x.NotifyMessageSentAsync(response.Result!),Times.Once); + } + + [TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)] + public async Task InvalidSendNeverInvokesService(int kind) + { + MessageRequest? request=kind switch {0=>null,1=>new(){EncryptedContent=" "},2=>new(){EncryptedContent=new string('a',1_000_001)},_=>new(){EncryptedContent="",MediaAttachments=null!}}; + Assert.That((await _hub.Send(request!)).Status,Is.EqualTo(HubResultStatus.BadRequest)); _send.VerifyNoOtherCalls(); _notifier.VerifyNoOtherCalls(); + } + + [TestCase(0,HubResultStatus.Forbidden)] [TestCase(1,HubResultStatus.Unauthorized)] + [TestCase(2,HubResultStatus.BadRequest)] [TestCase(3,HubResultStatus.NotFound)] + [TestCase(4,HubResultStatus.BadRequest)] [TestCase(5,HubResultStatus.ServerError)] + public async Task ServiceExceptionsMapToHubStatus(int kind,HubResultStatus expected) + { + Exception error=kind switch {0=>new UnauthorizedAccessException(),1=>new FriendshipException("friend"),2=>new ArgumentException("invalid"),3=>new KeyNotFoundException(),4=>new InvalidOperationException("conflict"),_=>new Exception("private detail")}; + _send.Setup(x=>x.SendMessageAsync(It.IsAny())).ReturnsAsync(new SendMessageResult(false,error,null!)); + var response=await _hub.Send(new(){EncryptedContent="cipher"}); Assert.That(response.Status,Is.EqualTo(expected)); + if(kind==5) Assert.That(response.ErrorMessage,Does.Not.Contain("private detail")); + _notifier.VerifyNoOtherCalls(); + } + + [Test] + public async Task SendFailureWithoutExceptionIsBadRequest() + { + _send.Setup(x=>x.SendMessageAsync(It.IsAny())).ReturnsAsync(new SendMessageResult(false,null,null!)); + Assert.That((await _hub.Send(new(){EncryptedContent="cipher"})).Status,Is.EqualTo(HubResultStatus.BadRequest)); + } + + [Test] + public async Task ReadMapsCurrentReadersViewAndNotifies() + { + var message=Message(); var view=new MessageView{Id=Guid.NewGuid(),UserId=_user,ViewedAt=_now}; message.MessageViews=[new(){UserId=Guid.NewGuid()},view]; + _read.Setup(x=>x.ReadMessageAsync(_user,message.Id)).ReturnsAsync(message); + var result=await _hub.Read(new(){MessageId=message.Id}); + Assert.That(result.Result!.ViewId,Is.EqualTo(view.Id)); Assert.That(result.Result.ReaderId,Is.EqualTo(_user)); + _notifier.Verify(x=>x.NotifyMessageWasReadAsync(result.Result!),Times.Once); + } + [Test] + public async Task ReadFailureDoesNotNotify() + { + _read.Setup(x=>x.ReadMessageAsync(_user,It.IsAny())).ReturnsAsync(Govor.Domain.Common.Result.Failure(Error.NotFound("missing","missing"))); + Assert.That((await _hub.Read(new())).Status,Is.EqualTo(HubResultStatus.NotFound)); _notifier.VerifyNoOtherCalls(); + } + + [TestCase(false)] [TestCase(true)] + public async Task ReadChatMapsResultOrFailure(bool failure) + { + var value=new ChatReadResult(_chat,RecipientType.User,_user,_now,null,null,[Guid.NewGuid()],2,3); + _read.Setup(x=>x.ReadChatAsync(_user,_chat,RecipientType.User,null,null)).ReturnsAsync(failure?Govor.Domain.Common.Result.Failure(Error.Forbidden("denied","denied")):value); + var result=await _hub.ReadChat(_chat,new(){RecipientType=RecipientType.User}); + Assert.That(result.Status,Is.EqualTo(failure?HubResultStatus.Forbidden:HubResultStatus.Success)); + if(failure) _notifier.VerifyNoOtherCalls(); else {Assert.That(result.Result!.ReadCount,Is.EqualTo(2)); Assert.That(result.Result.UnreadCount,Is.EqualTo(3)); _notifier.Verify(x=>x.NotifyChatReadAsync(result.Result!),Times.Once);} + } + + [TestCase(RemoveMessageRequestType.HideForMe,false)] [TestCase(RemoveMessageRequestType.ForceRemove,true)] [TestCase((RemoveMessageRequestType)99,false)] + public async Task RemovalMapsScopeAndNotifies(RemoveMessageRequestType type,bool force) + { + var message=Message(); + _remove.Setup(x=>x.DeleteMessageAsync(It.IsAny())).ReturnsAsync(message); + var result=await _hub.Remove(new(){MessageId=message.Id,RequestType=type}); + Assert.That(result.Status,Is.EqualTo(HubResultStatus.Success)); + _remove.Verify(x=>x.DeleteMessageAsync(new DeleteMessage(_user,message.Id,force)),Times.Once); + _notifier.Verify(x=>x.NotifyMessageRemovedAsync(result.Result!),Times.Once); + } + [Test] + public async Task RemovalFailureDoesNotNotify() + { + _remove.Setup(x=>x.DeleteMessageAsync(It.IsAny())).ReturnsAsync(Govor.Domain.Common.Result.Failure(Error.Forbidden("denied","denied"))); + Assert.That((await _hub.Remove(new())).Status,Is.EqualTo(HubResultStatus.Forbidden)); _notifier.VerifyNoOtherCalls(); + } + + [TestCase(false)] [TestCase(true)] + public async Task EditSuccessUsesClockAndPreservesRouting(bool noOriginal) + { + var message=Message(); message.ReplyToMessageId=Guid.NewGuid(); + _edit.Setup(x=>x.EditMessageAsync(It.IsAny())).ReturnsAsync(new EditMessageResult(true,null,noOriginal?null:message)); + var result=await _hub.Edit(new(){MessageId=message.Id,NewEncryptedContent="new cipher"}); + if(noOriginal){Assert.That(result.Status,Is.EqualTo(HubResultStatus.BadRequest)); _notifier.VerifyNoOtherCalls();return;} + Assert.That(result.Result!.ReplyToMessageId,Is.EqualTo(message.ReplyToMessageId)); Assert.That(result.Result.EditedAt,Is.EqualTo(_now)); + _edit.Verify(x=>x.EditMessageAsync(new EditMessage(_user,message.Id,"new cipher",_now)),Times.Once); + _notifier.Verify(x=>x.NotifyMessageEditedAsync(result.Result!),Times.Once); + } + + [TestCase(false,false)] [TestCase(true,false)] [TestCase(true,true)] + public async Task ReactionsNotifyOnlyOnChange(bool changed,bool remove) + { + var message=Guid.NewGuid(); Guid? reaction=remove?null:Guid.NewGuid(); + var state=new MessageReactionState(message,_chat,RecipientType.User,1,_user,null,[],changed); + _reactions.Setup(x=>x.SetAsync(_user,message,reaction)).ReturnsAsync(state); + var mapped=new MessageReactionsChangedResponse(); _mapper.Setup(x=>x.Map(state)).Returns(mapped); + var result=remove?await _hub.RemoveReaction(message):await _hub.React(message,new(){ReactionId=reaction!.Value}); + Assert.That(result.Result,Is.SameAs(mapped)); + _notifier.Verify(x=>x.NotifyMessageReactionsChangedAsync(mapped),changed?Times.Once():Times.Never()); + } + [Test] + public async Task ReactionFailureDoesNotNotify() + { + _reactions.Setup(x=>x.SetAsync(_user,It.IsAny(),It.IsAny())).ReturnsAsync(Govor.Domain.Common.Result.Failure(Error.Forbidden("denied","denied"))); + Assert.That((await _hub.RemoveReaction(Guid.NewGuid())).Status,Is.EqualTo(HubResultStatus.Forbidden)); _notifier.VerifyNoOtherCalls(); + } + [Test] + public async Task NullRequestsAreRejected() + { + Assert.That((await _hub.Read(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest)); + Assert.That((await _hub.ReadChat(_chat,null!)).Status,Is.EqualTo(HubResultStatus.BadRequest)); + Assert.That((await _hub.Remove(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest)); + Assert.That((await _hub.Edit(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest)); + Assert.That((await _hub.React(Guid.NewGuid(),null!)).Status,Is.EqualTo(HubResultStatus.BadRequest)); + _notifier.VerifyNoOtherCalls(); + } +} diff --git a/tests/Govor.API.Tests/Unit/Hubs/FriendsHubBoundaryTests.cs b/tests/Govor.API.Tests/Unit/Hubs/FriendsHubBoundaryTests.cs new file mode 100644 index 0000000..eb9cd0b --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Hubs/FriendsHubBoundaryTests.cs @@ -0,0 +1,40 @@ +using AutoMapper; +using Govor.API.Common.SignalR.Helpers; +using Govor.API.Hubs; +using Govor.Application.Friends; +using Govor.Contracts.Responses.SignalR; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Microsoft.AspNetCore.SignalR; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.API.Tests.Unit.Hubs; + +[TestFixture] +public class FriendsHubBoundaryTests +{ + [TestCase(false,false)] [TestCase(false,true)] [TestCase(true,false)] [TestCase(true,true)] + public async Task LifecycleHandlesMissingUserAndDisconnectErrors(bool invalid,bool error) + { + var id=invalid?Guid.Empty:Guid.NewGuid();var accessor=new Mock();accessor.Setup(x=>x.GetUserId(It.IsAny(),It.IsAny())).Returns(id); + var context=new Mock();context.SetupGet(x=>x.ConnectionId).Returns("connection");var groups=new Mock(); + using var hub=new FriendsHub(NullLogger.Instance,Mock.Of(),accessor.Object,Mock.Of()){Context=context.Object,Groups=groups.Object}; + await hub.OnConnectedAsync();await hub.OnDisconnectedAsync(error?new Exception("disconnect"):null); + context.Verify(x=>x.Abort(),invalid?Times.Once():Times.Never()); + groups.Verify(x=>x.AddToGroupAsync("connection",id.ToString(),default),invalid?Times.Never():Times.Once()); + groups.Verify(x=>x.RemoveFromGroupAsync("connection",id.ToString(),default),invalid?Times.Never():Times.Once()); + } + [TestCase(0)] [TestCase(1)] [TestCase(2)] public async Task FailedFriendCommandsDoNotNotify(int operation) + { + var commands=new Mock();var id=Guid.NewGuid(); + commands.Setup(x=>x.SendAsync(It.IsAny(),id)).ReturnsAsync(Result.Failure(Error.Forbidden("denied","denied"))); + commands.Setup(x=>x.AcceptAsync(id,It.IsAny())).ReturnsAsync(Result.Failure(Error.Forbidden("denied","denied"))); + commands.Setup(x=>x.RejectAsync(id,It.IsAny())).ReturnsAsync(Result.Failure(Error.Forbidden("denied","denied"))); + var clients=new Mock(MockBehavior.Strict); + using var hub=new FriendsHub(NullLogger.Instance,commands.Object,Mock.Of(),Mock.Of()){Clients=clients.Object}; + var result=operation switch{0=>await hub.SendRequest(id),1=>await hub.AcceptRequest(id),_=>await hub.RejectRequest(id)}; + Assert.That(result.Status,Is.EqualTo(operation==0?HubResultStatus.ServerError:HubResultStatus.BadRequest));clients.VerifyNoOtherCalls(); + } +} + diff --git a/Govor.API.Tests/IntegrationTests/Hubs/FriendsHubTests.cs b/tests/Govor.API.Tests/Unit/Hubs/FriendsHubTests.cs similarity index 98% rename from Govor.API.Tests/IntegrationTests/Hubs/FriendsHubTests.cs rename to tests/Govor.API.Tests/Unit/Hubs/FriendsHubTests.cs index c5a2bd0..93d4923 100644 --- a/Govor.API.Tests/IntegrationTests/Hubs/FriendsHubTests.cs +++ b/tests/Govor.API.Tests/Unit/Hubs/FriendsHubTests.cs @@ -3,8 +3,6 @@ using AutoMapper; using Govor.API.Common.SignalR.Helpers; using Govor.API.Hubs; using Govor.Application.Exceptions.FriendsService; -using Govor.Application.Interfaces.Friends; -using Govor.Application.Interfaces.Infrastructure.Extensions; using Govor.Contracts.DTOs; using Govor.Contracts.Responses.SignalR; using Govor.Domain.Models; @@ -12,7 +10,7 @@ using Microsoft.AspNetCore.SignalR; using Microsoft.Extensions.Logging; using Moq; -namespace Govor.API.Tests.IntegrationTests.Hubs; +namespace Govor.API.Tests.Unit.Hubs; [TestFixture] public class FriendsHubTests @@ -24,7 +22,7 @@ public class FriendsHubTests private Mock> _loggerMock = null!; private Mock _mapperMock = null!; private FriendsHub _hub = null!; - private Fixture _fixture; + private Fixture _fixture = null!; private readonly Guid _userId = Guid.NewGuid(); private readonly Guid _targetUserId = Guid.NewGuid(); diff --git a/Govor.API.Tests/Common/SignalR/Helpers/HubUserAccessorTests.cs b/tests/Govor.API.Tests/Unit/Hubs/HubUserAccessorTests.cs similarity index 96% rename from Govor.API.Tests/Common/SignalR/Helpers/HubUserAccessorTests.cs rename to tests/Govor.API.Tests/Unit/Hubs/HubUserAccessorTests.cs index 698999f..43cdc2e 100644 --- a/Govor.API.Tests/Common/SignalR/Helpers/HubUserAccessorTests.cs +++ b/tests/Govor.API.Tests/Unit/Hubs/HubUserAccessorTests.cs @@ -10,9 +10,8 @@ namespace Govor.API.Tests.Common.SignalR.Helpers; [TestOf(typeof(HubUserAccessor))] public class HubUserAccessorTests { - private HubUserAccessor _accessor; - private Mock> _loggerMock; - + private HubUserAccessor _accessor = null!; + private Mock> _loggerMock = null!; [SetUp] public void SetUp() { @@ -111,4 +110,4 @@ public class HubUserAccessorTests // Act & Assert Assert.Throws(() => _accessor.GetUserId(contextMock.Object, suppressException: false)); } -} \ No newline at end of file +} diff --git a/Govor.API.Tests/IntegrationTests/Hubs/Infrastructure/ConnectionStoreTests.cs b/tests/Govor.API.Tests/Unit/Hubs/Infrastructure/ConnectionStoreTests.cs similarity index 97% rename from Govor.API.Tests/IntegrationTests/Hubs/Infrastructure/ConnectionStoreTests.cs rename to tests/Govor.API.Tests/Unit/Hubs/Infrastructure/ConnectionStoreTests.cs index 00d05ae..430774c 100644 --- a/Govor.API.Tests/IntegrationTests/Hubs/Infrastructure/ConnectionStoreTests.cs +++ b/tests/Govor.API.Tests/Unit/Hubs/Infrastructure/ConnectionStoreTests.cs @@ -1,12 +1,11 @@ using Govor.API.Hubs.Infrastructure; -namespace Govor.API.Tests.IntegrationTests.Hubs.Infrastructure; +namespace Govor.API.Tests.Unit.Hubs.Infrastructure; [TestFixture] public class ConnectionStoreTests { - private ConnectionStore _store; - + private ConnectionStore _store = null!; [SetUp] public void Setup() { @@ -140,4 +139,4 @@ public class ConnectionStoreTests Assert.That(connections, Contains.Item("conn1")); Assert.That(connections, Contains.Item("conn2")); } -} \ No newline at end of file +} diff --git a/Govor.API.Tests/IntegrationTests/Hubs/Infrastructure/PrivateChatGroupManagerTests.cs b/tests/Govor.API.Tests/Unit/Hubs/Infrastructure/PrivateChatGroupManagerTests.cs similarity index 93% rename from Govor.API.Tests/IntegrationTests/Hubs/Infrastructure/PrivateChatGroupManagerTests.cs rename to tests/Govor.API.Tests/Unit/Hubs/Infrastructure/PrivateChatGroupManagerTests.cs index 57c69cc..d07bd85 100644 --- a/Govor.API.Tests/IntegrationTests/Hubs/Infrastructure/PrivateChatGroupManagerTests.cs +++ b/tests/Govor.API.Tests/Unit/Hubs/Infrastructure/PrivateChatGroupManagerTests.cs @@ -1,22 +1,19 @@ using Govor.API.Hubs; using Govor.API.Hubs.Infrastructure; using Govor.Application.Infrastructure.Extensions; -using Govor.Application.Interfaces; using Govor.Domain.Models; using Microsoft.AspNetCore.SignalR; using Moq; -namespace Govor.API.Tests.IntegrationTests.Hubs.Infrastructure; +namespace Govor.API.Tests.Unit.Hubs.Infrastructure; [TestFixture] public class PrivateChatGroupManagerTests { - private Mock _connectionStoreMock; - private Mock> _hubContextMock; - private Mock _groupsMock; - - private PrivateChatGroupManager _service; - + private Mock _connectionStoreMock = null!; + private Mock> _hubContextMock = null!; + private Mock _groupsMock = null!; + private PrivateChatGroupManager _service = null!; [SetUp] public void Setup() { @@ -153,4 +150,4 @@ public class PrivateChatGroupManagerTests g => g.RemoveFromGroupAsync(It.IsAny(), It.IsAny(), default), Times.Never); } -} \ No newline at end of file +} diff --git a/tests/Govor.API.Tests/Unit/Hubs/ProfileAndPresenceHubTests.cs b/tests/Govor.API.Tests/Unit/Hubs/ProfileAndPresenceHubTests.cs new file mode 100644 index 0000000..3b9a378 --- /dev/null +++ b/tests/Govor.API.Tests/Unit/Hubs/ProfileAndPresenceHubTests.cs @@ -0,0 +1,153 @@ +using Govor.API.Common.SignalR.Helpers; +using Govor.API.Hubs; +using Govor.Application.Friends; +using Govor.Application.Medias; +using Govor.Application.Profiles; +using Govor.Application.Synching; +using Govor.Application.Users.UserOnlineStatus; +using Govor.Contracts.Responses.SignalR; +using Govor.Domain.Common; +using Govor.Domain.Models.Users; +using Microsoft.AspNetCore.SignalR; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; +using SmartRes; + +namespace Govor.API.Tests.Unit.Hubs; + +[TestFixture] +public class ProfileHubTests +{ + private readonly Guid _user = Guid.NewGuid(), _friend = Guid.NewGuid(); + private Mock _friends = null!; + private Mock _profiles = null!; + private Mock _media = null!; + private Mock _proxy = null!; + private Mock _clients = null!; + private Mock _groups = null!; + private ProfileHub _hub = null!; + private List _recipients = null!; + + [SetUp] + public void Setup() + { + _friends = new(); _profiles = new(); _media = new(); _proxy = new(); _clients = new(); _groups = new(); _recipients = []; + var accessor = new Mock(); accessor.Setup(x => x.GetUserId(It.IsAny(), It.IsAny())).Returns(_user); + var sync = new Mock(); sync.Setup(x => x.NormalizeNewlines(It.IsAny())).Returns((string s) => s.Replace("\r\n", "\n")); + _clients.Setup(x => x.Groups(It.IsAny>())).Callback>(ids => _recipients.AddRange(ids)).Returns(_proxy.Object); + var context = new Mock(); context.SetupGet(x => x.ConnectionId).Returns("connection"); + _friends.Setup(x => x.GetFriendsAsync(_user)).ReturnsAsync([new() {Id = _friend}, new() {Id = Guid.Empty}]); + _friends.Setup(x => x.GetPotentialFriendsAsync(_user)).ReturnsAsync([new() {Id = _friend}, new() {Id = Guid.Empty}]); + _profiles.Setup(x => x.SetDescription(It.IsAny(), _user)).ReturnsAsync(SmartRes.Unit.Value); + _profiles.Setup(x => x.SetNewIcon(_user, It.IsAny())).ReturnsAsync(SmartRes.Unit.Value); + _media.Setup(x => x.HasMediaAsync(It.IsAny())).ReturnsAsync(true); + _hub = new(_friends.Object, _profiles.Object, accessor.Object, sync.Object, _media.Object, NullLogger.Instance) { Clients = _clients.Object, Context = context.Object, Groups = _groups.Object }; + } + [TearDown] public void TearDown() => _hub.Dispose(); + + [TestCase(null)] [TestCase("")] + public async Task DescriptionNullIsRejectedAndEmptyIsAllowed(string? description) + { + var result = await _hub.SetDescription(description); + Assert.That(result.Status, Is.EqualTo(description is null ? HubResultStatus.BadRequest : HubResultStatus.Success)); + if (description is null) _profiles.VerifyNoOtherCalls(); + } + [TestCase(500, HubResultStatus.Success)] [TestCase(501, HubResultStatus.BadRequest)] + public async Task DescriptionLengthBoundary(int size, HubResultStatus expected) => Assert.That((await _hub.SetDescription(new string('a',size))).Status, Is.EqualTo(expected)); + + [Test] + public async Task DescriptionNormalizesAndNotifiesDistinctNonemptyRecipients() + { + var result = await _hub.SetDescription("one\r\ntwo"); + Assert.That(result.Status, Is.EqualTo(HubResultStatus.Success)); + _profiles.Verify(x => x.SetDescription("one\ntwo", _user), Times.Once); + Assert.That(_recipients, Is.EquivalentTo(new[] {$"user:{_user}", $"user:{_friend}"})); + _proxy.Verify(x => x.SendCoreAsync("DescriptionUpdated", It.Is(args => args.Length == 1), default), Times.Once); + } + + [TestCase(false)] [TestCase(true)] + public async Task ProfileServiceFailuresDoNotNotify(bool avatar) + { + _profiles.Setup(x => x.SetDescription(It.IsAny(), _user)).ReturnsAsync(Result.Failure(Error.Forbidden("denied", "denied"))); + _profiles.Setup(x => x.SetNewIcon(_user, It.IsAny())).ReturnsAsync(Result.Failure(Error.Forbidden("denied", "denied"))); + var result = avatar ? await _hub.SetAvatar(Guid.NewGuid()) : await _hub.SetDescription("hello"); + Assert.That(result.Status, Is.EqualTo(HubResultStatus.Forbidden)); _proxy.VerifyNoOtherCalls(); + } + + [TestCase(false)] [TestCase(true)] + public async Task ProfileServiceExceptionsReturnServerError(bool avatar) + { + _profiles.Setup(x => x.SetDescription(It.IsAny(), _user)).ThrowsAsync(new Exception("failure")); + _profiles.Setup(x => x.SetNewIcon(_user, It.IsAny())).ThrowsAsync(new Exception("failure")); + var result = avatar ? await _hub.SetAvatar(Guid.NewGuid()) : await _hub.SetDescription("hello"); + Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError)); _proxy.VerifyNoOtherCalls(); + } + + [TestCase(true)] [TestCase(false)] + public async Task InvalidAvatarNeverChangesProfile(bool empty) + { + _media.Setup(x => x.HasMediaAsync(It.IsAny())).ReturnsAsync(false); + Assert.That((await _hub.SetAvatar(empty ? Guid.Empty : Guid.NewGuid())).Status, Is.EqualTo(HubResultStatus.BadRequest)); + _profiles.VerifyNoOtherCalls(); + } + + [Test] + public async Task AvatarPersistsAndNotifies() + { + var icon = Guid.NewGuid(); + Assert.That((await _hub.SetAvatar(icon)).Status, Is.EqualTo(HubResultStatus.Success)); + _profiles.Verify(x => x.SetNewIcon(_user, icon), Times.Once); + _proxy.Verify(x => x.SendCoreAsync("AvatarUpdated", It.IsAny(), default), Times.Once); + } + + [TestCase(false)] [TestCase(true)] + public async Task NotificationFailuresDoNotUndoPersistedProfile(bool deliveryFailure) + { + if (deliveryFailure) _proxy.Setup(x => x.SendCoreAsync(It.IsAny(), It.IsAny(), default)).ThrowsAsync(new Exception("transport")); + else { + _friends.Setup(x => x.GetFriendsAsync(_user)).ThrowsAsync(new Exception("friends")); + _friends.Setup(x => x.GetPotentialFriendsAsync(_user)).ThrowsAsync(new Exception("potential")); + } + Assert.That((await _hub.SetDescription("hello")).Status, Is.EqualTo(HubResultStatus.Success)); + if (!deliveryFailure) Assert.That(_recipients, Is.EqualTo(new[] { $"user:{_user}" })); + } + + [TestCase(false)] [TestCase(true)] + public async Task LifecycleMaintainsUserGroup(bool error) + { + await _hub.OnConnectedAsync(); await _hub.OnDisconnectedAsync(error ? new Exception("disconnect") : null); + _groups.Verify(x => x.AddToGroupAsync("connection", $"user:{_user}", default), Times.Once); + _groups.Verify(x => x.RemoveFromGroupAsync("connection", $"user:{_user}", default), Times.Once); + } +} + +[TestFixture] +public class PresenceHubTests +{ + [TestCase(true, true)] [TestCase(true, false)] [TestCase(false, true)] [TestCase(false, false)] + public async Task OnlyFirstConnectionAndLastDisconnectionBroadcast(bool first, bool last) + { + var user = Guid.NewGuid(); var friend = Guid.NewGuid(); + var accessor = new Mock(); accessor.Setup(x => x.GetUserId(It.IsAny(), It.IsAny())).Returns(user); + var store = new Mock(); store.Setup(x => x.AddConnection(user,"connection")).Returns(first); store.Setup(x => x.RemoveConnection(user,"connection")).Returns(last); + var scope = new Mock(); scope.Setup(x => x.GetNotifiedUsers(user)).ReturnsAsync([friend]); + var proxy = new Mock(); var clients = new Mock(); clients.Setup(x => x.Groups(It.Is>(ids => ids.SequenceEqual(new[] {friend.ToString()})))).Returns(proxy.Object); + var groups = new Mock(); var context = new Mock(); context.SetupGet(x => x.ConnectionId).Returns("connection"); + using var hub = new PresenceHub(NullLogger.Instance,scope.Object,store.Object,accessor.Object) { Context = context.Object, Clients = clients.Object, Groups = groups.Object }; + await hub.OnConnectedAsync(); await hub.OnDisconnectedAsync(null!); + proxy.Verify(x => x.SendCoreAsync("UserOnline",It.Is(args => Equals(args[0],user)),default),first ? Times.Once() : Times.Never()); + proxy.Verify(x => x.SendCoreAsync("UserOffline",It.Is(args => Equals(args[0],user)),default),last ? Times.Once() : Times.Never()); + groups.Verify(x => x.AddToGroupAsync("connection",user.ToString(),default),Times.Once); + groups.Verify(x => x.RemoveFromGroupAsync("connection",user.ToString(),default),Times.Once); + } + [Test] + public async Task InvalidUserAbortsWithoutStoreOrNotifications() + { + var accessor = new Mock(); var context = new Mock(); + var store = new Mock(MockBehavior.Strict); var scope = new Mock(MockBehavior.Strict); + using var hub = new PresenceHub(NullLogger.Instance,scope.Object,store.Object,accessor.Object) {Context=context.Object}; + await hub.OnConnectedAsync(); await hub.OnDisconnectedAsync(null!); + context.Verify(x => x.Abort(),Times.Once); store.VerifyNoOtherCalls(); scope.VerifyNoOtherCalls(); + } +} + diff --git a/tests/Govor.Application.Tests/GlobalUsings.cs b/tests/Govor.Application.Tests/GlobalUsings.cs new file mode 100644 index 0000000..944e32c --- /dev/null +++ b/tests/Govor.Application.Tests/GlobalUsings.cs @@ -0,0 +1,10 @@ +global using Govor.Application.Authentication; +global using Govor.Application.Authentication.JWT; +global using Govor.Application.Friends; +global using Govor.Application.Infrastructure.Extensions; +global using Govor.Application.Infrastructure.Validators; +global using Govor.Application.Medias; +global using Govor.Application.Storage; +global using Govor.Application.Users.UserOnlineStatus; +global using Govor.Application.Users.UserSessions; +global using Govor.Domain; diff --git a/tests/Govor.Application.Tests/Govor.Application.Tests.csproj b/tests/Govor.Application.Tests/Govor.Application.Tests.csproj new file mode 100644 index 0000000..a691fcc --- /dev/null +++ b/tests/Govor.Application.Tests/Govor.Application.Tests.csproj @@ -0,0 +1,6 @@ + + + + + + diff --git a/tests/Govor.Application.Tests/Integration/Administration/AdministrationTests.cs b/tests/Govor.Application.Tests/Integration/Administration/AdministrationTests.cs new file mode 100644 index 0000000..fbd5c15 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Administration/AdministrationTests.cs @@ -0,0 +1,105 @@ +using Govor.Application.Infrastructure.AdminsStuff; +using Govor.Application.Infrastructure.Common; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Users; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Integration.Administration; + +[TestFixture] +public class AdministrationTests +{ + private TestDatabase _db = null!; + private UsersService _users = null!; + private InvitationGetter _invitations = null!; + private Mock _hasher = null!; + [SetUp] + public void SetUp() + { + _db = new TestDatabase(); + _hasher = new Mock(); + _hasher.Setup(h => h.Hash("new password")).Returns("new hash"); + _users = new(_db.Context, _hasher.Object); + _invitations = new(NullLogger.Instance, _db.Context); + } + [TearDown] public void TearDown() => _db.Dispose(); + + [Test] + public async Task PasswordResetRevokesOnlyTargetsSessionsAndPushTokens() + { + var own = new UserSession { UserId = _db.Alice, RefreshTokenHash = "alice" }; + var bob = new UserSession { UserId = _db.Bob, RefreshTokenHash = "bob" }; + _db.Context.UserSessions.AddRange(own, bob); + _db.Context.UserPushTokens.AddRange( + new UserPushToken { UserId = _db.Alice, UserSessionId = own.Id, Token = "alice", Platform = "android" }, + new UserPushToken { UserId = _db.Bob, UserSessionId = bob.Id, Token = "bob", Platform = "android" }); + await _db.Context.SaveChangesAsync(); + await _users.SetPasswordAsync(_db.Alice, "new password"); + _db.Context.ChangeTracker.Clear(); + Assert.That((await _users.GetUserById(_db.Alice)).PasswordHash, Is.EqualTo("new hash")); + Assert.That((await _db.Context.UserSessions.SingleAsync(s => s.Id == own.Id)).IsRevoked, Is.True); + Assert.That((await _db.Context.UserSessions.SingleAsync(s => s.Id == bob.Id)).IsRevoked, Is.False); + Assert.That((await _db.Context.UserPushTokens.SingleAsync(t => t.UserId == _db.Alice)).IsActive, Is.False); + Assert.That((await _db.Context.UserPushTokens.SingleAsync(t => t.UserId == _db.Bob)).IsActive, Is.True); + } + + [Test] + public async Task MissingUserDoesNotHashOrChangeAccounts() + { + var missing = Guid.NewGuid(); + Assert.That(await _users.GetUserById(missing), Is.Null); + await _users.SetPasswordAsync(missing, "new password"); + _hasher.VerifyNoOtherCalls(); + Assert.That(await _db.Context.Users.CountAsync(), Is.EqualTo(3)); + } + + [Test] + public async Task UserListIsBoundedAndUntracked() + { + var invite = await _db.Context.Invitations.SingleAsync(); + _db.Context.Users.AddRange(Enumerable.Range(0, 60).Select(i => new User { + Id = Guid.NewGuid(), Username = "user-" + i, PasswordHash = "hash", InviteId = invite.Id, Description = "" })); + await _db.Context.SaveChangesAsync(); + _db.Context.ChangeTracker.Clear(); + Assert.That(await _users.GetAllUsersAsync(), Has.Count.EqualTo(50)); + Assert.That(_db.Context.ChangeTracker.Entries(), Is.Empty); + } + + [Test] + public async Task InvitationListFiltersInactiveButLookupCanReadIt() + { + var inactive = new Invitation { Id = Guid.NewGuid(), Code = "inactive", Description = "", IsActive = false }; + _db.Context.Invitations.Add(inactive); + await _db.Context.SaveChangesAsync(); + _db.Context.ChangeTracker.Clear(); + Assert.That((await _invitations.GetAllAsync()).Any(i => i.Id == inactive.Id), Is.False); + Assert.That((await _invitations.FindByIdAsync(inactive.Id)).Value.Code, Is.EqualTo("inactive")); + Assert.That((await _invitations.FindByIdAsync(Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That(_db.Context.ChangeTracker.Entries(), Is.Empty); + } + + [Test] + public async Task RolesDefaultToUserAndAdminRoleComesFromInvitation() + { + var clock = Mock.Of(); + var invites = new InvitesService(_db.Context, clock); + var user = await _users.GetUserById(_db.Alice); + Assert.That(await invites.GetRoleNameAsync(Guid.NewGuid()), Is.EqualTo("User")); + Assert.That(await invites.GetRoleNameAsync(user), Is.EqualTo("User")); + var invitation = await _db.Context.Invitations.SingleAsync(); + invitation.IsAdmin = true; + await _db.Context.SaveChangesAsync(); + Assert.That(await invites.GetRoleNameAsync(user), Is.EqualTo("Admin")); + } + + [Test] + public async Task UnknownInvitationReturnsNotFound() + { + var service = new InvitesService(_db.Context, Mock.Of()); + Assert.That((await service.ValidateAsync("unknown")).Error.Type, Is.EqualTo(ErrorType.NotFound)); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Authentication/AuthServiceTests.cs b/tests/Govor.Application.Tests/Integration/Authentication/AuthServiceTests.cs new file mode 100644 index 0000000..3eebca9 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Authentication/AuthServiceTests.cs @@ -0,0 +1,102 @@ +using Govor.Application.Authentication; +using Govor.Application.Infrastructure.Common; +using Govor.Application.Infrastructure.Validators; +using Govor.Application.Users; +using Govor.Domain.Common; +using Microsoft.EntityFrameworkCore; +using Moq; + +namespace Govor.Application.Tests.Authentication; + +[TestFixture] +public class AuthServiceTests +{ + private TestDatabase _db = null!; + private AuthService _service = null!; + private Mock _hasher = null!; + private readonly DateTime _now = new(2026, 10, 24, 0, 0, 0, DateTimeKind.Utc); + + [SetUp] + public void SetUp() + { + _db = new TestDatabase(); + _hasher = new Mock(); + _hasher.Setup(h => h.Hash(It.IsAny())).Returns("hashed-password"); + _hasher.Setup(h => h.Verify("correct", It.IsAny())).Returns(true); + var validator = new Mock(); + validator.Setup(v => v.Validate(It.IsAny())).Returns(Result.Success()); + var clock = new Mock(); + clock.SetupGet(c => c.Now).Returns(_now); + _service = new AuthService(_db.Context, new UserNameExistValidator(_db.Context), + _hasher.Object, validator.Object, clock.Object); + } + + [TearDown] public void TearDown() => _db.Dispose(); + + [TestCase(false)] + [TestCase(true)] + public async Task RegistrationPersistsAccountReservesInvitationAndAssignsRole(bool admin) + { + var invite = await _db.Context.Invitations.SingleAsync(); + invite.IsAdmin = admin; + await _db.Context.SaveChangesAsync(); + var result = await _service.RegistrationAsync("Новый", "secret", invite); + Assert.That(result.IsSuccess, Is.True); + _db.Context.ChangeTracker.Clear(); + var user = await _db.Context.Users.SingleAsync(u => u.Id == result.Value.Id); + Assert.Multiple(() => + { + Assert.That(user.Username, Is.EqualTo("Новый")); + Assert.That(user.PasswordHash, Is.EqualTo("hashed-password")); + Assert.That(user.CreatedOn, Is.EqualTo(DateOnly.FromDateTime(_now))); + Assert.That(user.InviteId, Is.EqualTo(invite.Id)); + }); + Assert.That(await _db.Context.Admins.AnyAsync(a => a.UserId == user.Id), Is.EqualTo(admin)); + Assert.That((await _db.Context.Invitations.SingleAsync()).Participants, Is.EqualTo(1)); + } + + [Test] + public async Task ExistingUsernameReturnsConflictWithoutConsumingInvitation() + { + var user = await _db.Context.Users.FirstAsync(); + var invite = await _db.Context.Invitations.SingleAsync(); + var result = await _service.RegistrationAsync(user.Username, "secret", invite); + Assert.That(result.Error.Type, Is.EqualTo(ErrorType.Conflict)); + Assert.That((await _db.Context.Invitations.AsNoTracking().SingleAsync()).Participants, Is.Zero); + _hasher.Verify(h => h.Hash(It.IsAny()), Times.Never); + } + + [TestCase("expired")] + [TestCase("full")] + [TestCase("inactive")] + public async Task UnavailableInvitationDoesNotCreateAccount(string reason) + { + var invite = await _db.Context.Invitations.SingleAsync(); + if (reason == "expired") invite.EndDate = _now; + if (reason == "full") invite.MaxParticipants = 3; + if (reason == "inactive") invite.IsActive = false; + await _db.Context.SaveChangesAsync(); + var result = await _service.RegistrationAsync("Новый", "secret", invite); + Assert.That(result.Error.Code, Is.EqualTo("Auth.InvitationUnavailable")); + Assert.That(await _db.Context.Users.CountAsync(), Is.EqualTo(3)); + } + + [TestCase("correct", true)] + [TestCase("wrong", false)] + public async Task LoginVerifiesStoredPassword(string password, bool success) + { + var user = await _db.Context.Users.FirstAsync(); + var result = await _service.LoginAsync(user.Username, password); + Assert.That(result.IsSuccess, Is.EqualTo(success)); + _hasher.Verify(h => h.Verify(password, user.PasswordHash), Times.Once); + if (success) Assert.That(result.Value.Id, Is.EqualTo(user.Id)); + } + + [Test] + public async Task MissingUserReturnsNotFound() + { + var result = await _service.LoginAsync("missing", "secret"); + Assert.That(result.Error.Type, Is.EqualTo(ErrorType.NotFound)); + _hasher.Verify(h => h.Verify(It.IsAny(), It.IsAny()), Times.Never); + } +} diff --git a/tests/Govor.Application.Tests/Integration/Authentication/AuthenticationFailureTests.cs b/tests/Govor.Application.Tests/Integration/Authentication/AuthenticationFailureTests.cs new file mode 100644 index 0000000..0d07e1f --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Authentication/AuthenticationFailureTests.cs @@ -0,0 +1,49 @@ +using Govor.Application.Infrastructure.Common; +using Govor.Application.Users; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Microsoft.EntityFrameworkCore; +using Moq; + +namespace Govor.Application.Tests.Integration.Authentication; + +[TestFixture] +public class AuthenticationFailureTests +{ + [Test] + public async Task InvalidUsernameStopsRegistrationBeforePasswordHashOrDatabaseWrite() + { + using var db = new TestDatabase(); + var error = Error.Validation("Username.Invalid", "invalid username"); + var validator = new Mock(); + validator.Setup(v => v.Validate("bad")).Returns(Result.Failure(error)); + var hasher = new Mock(MockBehavior.Strict); + var exists = new Mock(MockBehavior.Strict); + var service = new AuthService(db.Context, exists.Object, hasher.Object, validator.Object, Mock.Of()); + var result = await service.RegistrationAsync("bad", "password", await db.Context.Invitations.SingleAsync()); + Assert.That(result.Error, Is.SameAs(error)); + Assert.That(await db.Context.Users.CountAsync(), Is.EqualTo(3)); + hasher.VerifyNoOtherCalls(); + exists.VerifyNoOtherCalls(); + } + + [Test] + public async Task NonChannelRequiredGroupRejectsRegistrationWithoutConsumingInvitation() + { + using var db = new TestDatabase(); + var group = new ChatGroup { Id = Guid.NewGuid(), Name = "not a channel", Description = "" }; + db.Context.ChatGroups.Add(group); + (await db.Context.ServerCommunitySettings.SingleAsync()).RequiredChannelId = group.Id; + await db.Context.SaveChangesAsync(); + var validator = Mock.Of(v => v.Validate("Новый") == Result.Success()); + var hasher = Mock.Of(h => h.Hash("password") == "hash"); + var service = new AuthService(db.Context, new UserNameExistValidator(db.Context), hasher, validator, + Mock.Of(c => c.Now == DateTime.UtcNow.Date)); + var invitation = await db.Context.Invitations.SingleAsync(); + var result = await service.RegistrationAsync("Новый", "password", invitation); + Assert.That(result.Error.Code, Is.EqualTo("Auth.RequiredChannelUnavailable")); + Assert.That(await db.Context.Users.CountAsync(), Is.EqualTo(3)); + Assert.That((await db.Context.Invitations.AsNoTracking().SingleAsync()).Participants, Is.Zero); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Friends/FriendsBlockServiceTests.cs b/tests/Govor.Application.Tests/Integration/Friends/FriendsBlockServiceTests.cs new file mode 100644 index 0000000..7c34204 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Friends/FriendsBlockServiceTests.cs @@ -0,0 +1,80 @@ +using Govor.Application.Messages; +using Govor.Application.PrivateUserChats; +using Govor.Domain.Models; +using Govor.Domain.Models.Messages; +using Microsoft.EntityFrameworkCore; + +namespace Govor.Application.Tests.Integration.Friends; + +[TestFixture] +public class FriendsBlockServiceTests +{ + private TestDatabase _db = null!; + private FriendsBlockService _service = null!; + [SetUp] public void SetUp() { _db = new TestDatabase(); _service = new(_db.Context); } + [TearDown] public void TearDown() => _db.Dispose(); + + [TestCase(false)] + [TestCase(true)] + public async Task BlockCreatesOrUpdatesRelationshipAndPreventsNewMessages(bool existing) + { + Guid? original = null; + if (existing) + { + var friend = new Friendship { Id = Guid.NewGuid(), RequesterId = _db.Bob, AddresseeId = _db.Alice, Status = FriendshipStatus.Accepted }; + _db.Context.Friendships.Add(friend); + await _db.Context.SaveChangesAsync(); + original = friend.Id; + } + await _service.BlockFriendRequestAsync(_db.Bob, _db.Alice); + await _service.BlockFriendRequestAsync(_db.Bob, _db.Alice); + _db.Context.ChangeTracker.Clear(); + var block = await _db.Context.Friendships.SingleAsync(); + Assert.That(block.RequesterId, Is.EqualTo(_db.Alice)); + Assert.That(block.AddresseeId, Is.EqualTo(_db.Bob)); + Assert.That(block.Status, Is.EqualTo(FriendshipStatus.Blocked)); + if (original.HasValue) Assert.That(block.Id, Is.EqualTo(original.Value)); + var sender = new MessageSendingService(_db.Context, Microsoft.Extensions.Logging.Abstractions.NullLogger.Instance); + var sent = await sender.SendMessageAsync(new("hello", null, _db.ChatId, RecipientType.User, _db.Bob, DateTime.UtcNow, [])); + Assert.That(sent.IsSuccess, Is.False); + Assert.That(sent.Exception, Is.TypeOf()); + var requests = new FriendRequestCommandService(_db.Context, Moq.Mock.Of()); + Assert.That((await requests.SendAsync(_db.Bob, _db.Alice)).IsFailure, Is.True); + } + + [Test] + public async Task OnlyBlockOwnerCanRemoveOrReplaceBlockAndUnblockAllowsNewRequest() + { + await _service.BlockFriendRequestAsync(_db.Bob, _db.Alice); + Assert.ThrowsAsync(() => _service.UnblockFriendRequestAsync(_db.Alice, _db.Bob)); + Assert.ThrowsAsync(() => _service.BlockFriendRequestAsync(_db.Alice, _db.Bob)); + await _service.UnblockFriendRequestAsync(_db.Bob, _db.Alice); + await _service.UnblockFriendRequestAsync(_db.Bob, _db.Alice); + Assert.That((await _db.Context.Friendships.SingleAsync()).Status, Is.EqualTo(FriendshipStatus.Rejected)); + var requests = new FriendRequestCommandService(_db.Context, Moq.Mock.Of()); + Assert.That((await requests.SendAsync(_db.Alice, _db.Bob)).IsSuccess, Is.True); + Assert.That((await _db.Context.Friendships.SingleAsync()).Status, Is.EqualTo(FriendshipStatus.Pending)); + } + + [Test] + public async Task UnblockingMissingOrUnblockedRelationshipDoesNotChangeFriendship() + { + await _service.UnblockFriendRequestAsync(_db.Bob, _db.Alice); + _db.Context.Friendships.Add(new Friendship { Id = Guid.NewGuid(), RequesterId = _db.Alice, + AddresseeId = _db.Bob, Status = FriendshipStatus.Accepted }); + await _db.Context.SaveChangesAsync(); + await _service.UnblockFriendRequestAsync(_db.Bob, _db.Alice); + Assert.That((await _db.Context.Friendships.SingleAsync()).Status, Is.EqualTo(FriendshipStatus.Accepted)); + } + + [Test] + public void InvalidOrMissingUsersCannotBeBlocked() + { + Assert.ThrowsAsync(() => _service.BlockFriendRequestAsync(_db.Alice, _db.Alice)); + Assert.ThrowsAsync(() => _service.BlockFriendRequestAsync(Guid.Empty, _db.Alice)); + Assert.ThrowsAsync(() => _service.UnblockFriendRequestAsync(_db.Alice, Guid.Empty)); + Assert.ThrowsAsync(() => _service.UnblockFriendRequestAsync(_db.Alice, _db.Alice)); + Assert.ThrowsAsync(() => _service.BlockFriendRequestAsync(Guid.NewGuid(), _db.Alice)); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Friends/FriendshipTests.cs b/tests/Govor.Application.Tests/Integration/Friends/FriendshipTests.cs new file mode 100644 index 0000000..1154cfd --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Friends/FriendshipTests.cs @@ -0,0 +1,126 @@ +using Govor.Application.Friends; +using Govor.Application.PrivateUserChats; +using Govor.Application.Exceptions.VerifyFriendship; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Friends; + +[TestFixture] +public class FriendshipTests +{ + private TestDatabase _db = null!; + private FriendRequestCommandService _commands = null!; + private Mock _chats = null!; + + [SetUp] + public void SetUp() + { + _db = new TestDatabase(); + _chats = new Mock(); + _commands = new FriendRequestCommandService(_db.Context, _chats.Object); + } + [TearDown] public void TearDown() => _db.Dispose(); + + [Test] + public async Task RequestCanBeAcceptedOnlyByAddresseeAndCreatesChat() + { + var sent = await _commands.SendAsync(_db.Alice, _db.Bob); + Assert.That(sent.Value.Status, Is.EqualTo(FriendshipStatus.Pending)); + Assert.That((await _commands.AcceptAsync(sent.Value.Id, _db.Outsider)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _commands.AcceptAsync(sent.Value.Id, _db.Bob)).Value.Status, Is.EqualTo(FriendshipStatus.Accepted)); + Assert.That((await _commands.AcceptAsync(sent.Value.Id, _db.Bob)).IsFailure, Is.True); + _chats.Verify(c => c.CreateAsync(_db.Bob, _db.Alice), Times.Once); + var verifier = new VerifyFriendship(_db.Context, NullLogger.Instance); + Assert.That(await verifier.TryVerifyAsync(_db.Alice, _db.Bob), Is.True); + Assert.That(await verifier.TryVerifyAsync(_db.Bob, _db.Alice), Is.True); + Assert.DoesNotThrowAsync(() => verifier.VerifyAsync(_db.Alice, _db.Bob)); + } + + [Test] + public async Task DuplicateAndReversePendingRequestsReturnConflict() + { + await _commands.SendAsync(_db.Alice, _db.Bob); + Assert.That((await _commands.SendAsync(_db.Alice, _db.Bob)).Error.Type, Is.EqualTo(ErrorType.Conflict)); + Assert.That((await _commands.SendAsync(_db.Bob, _db.Alice)).Error.Type, Is.EqualTo(ErrorType.Conflict)); + Assert.That(await _db.Context.Friendships.CountAsync(), Is.EqualTo(1)); + } + + [Test] + public async Task SelfRequestDoesNotPersist() + { + Assert.That((await _commands.SendAsync(_db.Alice, _db.Alice)).IsFailure, Is.True); + Assert.That(await _db.Context.Friendships.CountAsync(), Is.Zero); + } + + [Test] + public async Task RejectedRequestCanBeResentInOtherDirection() + { + var sent = (await _commands.SendAsync(_db.Alice, _db.Bob)).Value; + Assert.That((await _commands.RejectAsync(sent.Id, _db.Alice)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _commands.RejectAsync(sent.Id, _db.Bob)).Value.Status, Is.EqualTo(FriendshipStatus.Rejected)); + var resent = (await _commands.SendAsync(_db.Bob, _db.Alice)).Value; + Assert.That(resent.Id, Is.EqualTo(sent.Id)); + Assert.That(resent.AddresseeId, Is.EqualTo(_db.Alice)); + Assert.That(resent.Status, Is.EqualTo(FriendshipStatus.Pending)); + _chats.VerifyNoOtherCalls(); + } + + [Test] + public async Task MissingRequestsReturnNotFound() + { + Assert.That((await _commands.AcceptAsync(Guid.NewGuid(), _db.Bob)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _commands.RejectAsync(Guid.NewGuid(), _db.Bob)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + } + + [TestCase(FriendshipStatus.Accepted)] + [TestCase(FriendshipStatus.Blocked)] + public async Task EstablishedOrBlockedFriendshipCannotBeRequestedOrRejected(FriendshipStatus status) + { + var sent = (await _commands.SendAsync(_db.Alice, _db.Bob)).Value; + sent.Status = status; + await _db.Context.SaveChangesAsync(); + Assert.That((await _commands.SendAsync(_db.Bob, _db.Alice)).Error.Type, Is.EqualTo(ErrorType.Conflict)); + Assert.That((await _commands.RejectAsync(sent.Id, _db.Bob)).Error.Type, Is.EqualTo(ErrorType.Conflict)); + } + + [Test] + public async Task QueriesFilterStatusAndDirection() + { + var sent = (await _commands.SendAsync(_db.Alice, _db.Bob)).Value; + var query = new FriendRequestQueryService(_db.Context); + var friends = new FriendshipService(_db.Context); + Assert.That((await query.GetIncomingAsync(_db.Bob)).Select(f => f.Id), Is.EqualTo(new[] { sent.Id })); + Assert.That(await query.GetIncomingAsync(_db.Alice), Is.Empty); + Assert.That((await friends.GetPotentialFriendsAsync(_db.Alice)).Select(u => u.Id), Is.EqualTo(new[] { _db.Bob })); + Assert.That(await friends.GetFriendsAsync(_db.Alice), Is.Empty); + await _commands.AcceptAsync(sent.Id, _db.Bob); + Assert.That(await query.GetIncomingAsync(_db.Bob), Is.Empty); + Assert.That(await query.GetResponsesAsync(_db.Alice), Is.Empty); + Assert.That((await friends.GetFriendsAsync(_db.Alice)).Select(u => u.Id), Is.EqualTo(new[] { _db.Bob })); + Assert.That((await friends.GetFriendsAsync(_db.Bob)).Select(u => u.Id), Is.EqualTo(new[] { _db.Alice })); + } + + [Test] + public async Task SearchExcludesCurrentUserAndEmptyQuery() + { + var service = new FriendshipService(_db.Context); + Assert.That(await service.SearchUsersAsync(" ", _db.Alice), Is.Empty); + Assert.That((await service.SearchUsersAsync("-", _db.Alice)).Select(u => u.Id), + Is.EquivalentTo(new[] { _db.Bob, _db.Outsider })); + } + + [Test] + public async Task VerifierRejectsMissingOrPendingFriendshipAndEmptyIds() + { + var verifier = new VerifyFriendship(_db.Context, NullLogger.Instance); + await _commands.SendAsync(_db.Alice, _db.Bob); + Assert.That(await verifier.TryVerifyAsync(_db.Alice, _db.Bob), Is.False); + Assert.That(await verifier.TryVerifyAsync(Guid.Empty, _db.Bob), Is.False); + Assert.ThrowsAsync(() => verifier.VerifyAsync(_db.Alice, _db.Bob)); + Assert.ThrowsAsync(() => verifier.VerifyAsync(Guid.Empty, _db.Bob)); + } +} diff --git a/tests/Govor.Application.Tests/Integration/Groups/GroupAvatarBoundaryTests.cs b/tests/Govor.Application.Tests/Integration/Groups/GroupAvatarBoundaryTests.cs new file mode 100644 index 0000000..8bff4a1 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Groups/GroupAvatarBoundaryTests.cs @@ -0,0 +1,85 @@ +using Govor.Application.Groups; +using Govor.Application.Infrastructure.Common; +using Govor.Application.Reactions; +using Govor.Application.Tests.Support; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Reactions; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Integration.Groups; + +[TestFixture] +public class GroupAvatarBoundaryTests +{ + private TestDatabase _db = null!; + private Guid _group; + private Mock _processor = null!; + private Mock _storage = null!; + private readonly ProcessedReactionMedia _image = new(new byte[] { 1 }, ReactionKind.Image, "image/png", ".png", 10, 10, 0); + private GroupAvatarService Service(GovorDbContext? context = null) => new(context ?? _db.Context, + Mock.Of(c => c.Now == DateTime.UtcNow.Date), _processor.Object, _storage.Object, NullLogger.Instance); + [SetUp] + public async Task SetUp() + { + _db = new TestDatabase(); + _group = Guid.NewGuid(); + _db.Context.ChatGroups.Add(new ChatGroup { Id = _group, Name = "group", Description = "", OwnerUserId = _db.Alice }); + _db.Context.GroupMemberships.Add(new GroupMembership { Id = Guid.NewGuid(), GroupId = _group, UserId = _db.Alice }); + await _db.Context.SaveChangesAsync(); + _processor = new Mock(MockBehavior.Strict); + _storage = new Mock(MockBehavior.Strict); + } + [TearDown] public void TearDown() => _db.Dispose(); + + [Test] + public async Task NonOwnerCannotProcessSaveOrRemoveAvatar() + { + Assert.That((await Service().UploadAsync(_db.Bob, _group, new byte[] { 1 })).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await Service().RemoveAsync(_db.Bob, _group)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + _processor.VerifyNoOtherCalls(); + _storage.VerifyNoOtherCalls(); + } + + [Test] + public async Task InvalidAndAnimatedImagesAreRejectedBeforeStorage() + { + var error = Error.Validation("Media.Invalid", "invalid"); + _processor.SetupSequence(p => p.ProcessAsync(It.IsAny(), It.IsAny())) + .ReturnsAsync(Result.Failure(error)).ReturnsAsync(_image with { Kind = ReactionKind.Gif }); + Assert.That((await Service().UploadAsync(_db.Alice, _group, new byte[] { 1 })).Error, Is.SameAs(error)); + Assert.That((await Service().UploadAsync(_db.Alice, _group, new byte[] { 1 })).Error.Code, Is.EqualTo("Group.Avatar.Invalid")); + _storage.VerifyNoOtherCalls(); + } + + [Test] + public async Task LossOfOwnershipDuringImageProcessingPreventsUpload() + { + _processor.Setup(p => p.ProcessAsync(It.IsAny(), It.IsAny())).Returns(async () => + { + await _db.Context.ChatGroups.Where(g => g.Id == _group).ExecuteUpdateAsync(s => s.SetProperty(g => g.OwnerUserId, _db.Bob)); + return Result.Success(_image); + }); + Assert.That((await Service().UploadAsync(_db.Alice, _group, new byte[] { 1 })).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + _storage.VerifyNoOtherCalls(); + } + + [TestCase(false)] + [TestCase(true)] + public async Task FailedMetadataWriteRollsBackAndCleansStoredImage(bool cleanupFails) + { + _processor.Setup(p => p.ProcessAsync(It.IsAny(), It.IsAny())).ReturnsAsync(_image); + _storage.Setup(s => s.SaveAsync(It.IsAny(), It.IsAny())).ReturnsAsync("failed.png"); + if (cleanupFails) _storage.Setup(s => s.RemoveAsync("failed.png")).ThrowsAsync(new IOException("cleanup failure")); + else _storage.Setup(s => s.RemoveAsync("failed.png")).Returns(Task.CompletedTask); + using var failed = _db.CreateContext(new FailDatabaseCommand(sql => sql.Contains("INSERT INTO \"MediaFiles\"", StringComparison.Ordinal))); + Assert.ThrowsAsync(() => Service(failed).UploadAsync(_db.Alice, _group, new byte[] { 1 })); + _storage.Verify(s => s.RemoveAsync("failed.png"), Times.Once); + Assert.That(await _db.Context.MediaFiles.CountAsync(), Is.Zero); + Assert.That((await _db.Context.ChatGroups.AsNoTracking().SingleAsync()).ImageId, Is.EqualTo(Guid.Empty)); + Assert.That(failed.ChangeTracker.Entries(), Is.Empty); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Groups/GroupManagementBoundaryTests.cs b/tests/Govor.Application.Tests/Integration/Groups/GroupManagementBoundaryTests.cs new file mode 100644 index 0000000..abdf4e7 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Groups/GroupManagementBoundaryTests.cs @@ -0,0 +1,78 @@ +using Govor.Application.Groups; +using Govor.Application.Infrastructure.Common; +using Govor.Domain.Common; +using Microsoft.EntityFrameworkCore; +using Moq; + +namespace Govor.Application.Tests.Integration.Groups; + +[TestFixture] +public class GroupManagementBoundaryTests +{ + private TestDatabase _db = null!; + private GroupManagementService _service = null!; + private Guid _group; + [SetUp] + public async Task SetUp() + { + _db = new TestDatabase(); + _service = new(_db.Context, Mock.Of(c => c.Now == DateTime.UtcNow.Date)); + _group = (await _service.CreateAsync(_db.Alice, "group", "", false, false)).Value.Group.Id; + await _service.JoinPublicAsync(_db.Bob, _group); + } + [TearDown] public void TearDown() => _db.Dispose(); + + [TestCase("name")] + [TestCase("description")] + [TestCase("null-description")] + public async Task InvalidGroupProfilesCannotCreateOrUpdate(string kind) + { + var name = kind == "name" ? new string('x', 101) : "group"; + var description = kind == "description" ? new string('x', 501) : kind == "null-description" ? null : ""; + Assert.That((await _service.CreateAsync(_db.Alice, name, description!, false, false)).IsFailure, Is.True); + Assert.That((await _service.UpdateAsync(_db.Alice, _group, name, description!, false)).IsFailure, Is.True); + Assert.That(await _db.Context.ChatGroups.CountAsync(), Is.EqualTo(1)); + } + + [Test] + public async Task UnknownActorCannotCreateOrJoinGroups() + { + Assert.That((await _service.CreateAsync(Guid.NewGuid(), "name", "", false, false)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.JoinPublicAsync(Guid.NewGuid(), _group)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.UpdateAsync(_db.Alice, Guid.NewGuid(), "name", "", false)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + } + + [Test] + public async Task MembershipAndAdministrationGuardsProtectOwnerAndOutsiders() + { + Assert.That((await _service.MembersAsync(_db.Outsider, _group, false, 0, 20)).IsFailure, Is.True); + Assert.That((await _service.MembersAsync(_db.Bob, _group, true, 0, 20)).IsFailure, Is.True); + Assert.That((await _service.LeaveAsync(_db.Outsider, _group)).IsFailure, Is.True); + Assert.That((await _service.LeaveAsync(_db.Alice, _group)).IsFailure, Is.True); + Assert.That((await _service.SetAdministratorAsync(_db.Alice, _group, _db.Alice, true)).IsFailure, Is.True); + Assert.That((await _service.SetAdministratorAsync(_db.Alice, _group, _db.Outsider, true)).IsFailure, Is.True); + Assert.That((await _service.TransferOwnershipAsync(_db.Alice, _group, _db.Outsider)).IsFailure, Is.True); + Assert.That((await _service.TransferOwnershipAsync(_db.Alice, _group, _db.Alice)).IsFailure, Is.True); + Assert.That((await _service.SetBanAsync(_db.Alice, _group, _db.Outsider, true)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + } + + [TestCase(0, 1, "")] + [TestCase(366, 1, "")] + [TestCase(1, -1, "")] + [TestCase(1, 1000001, "")] + [TestCase(1, 1, null)] + public async Task InvalidInvitationLimitsAreRejected(int days, int limit, string? description) => + Assert.That((await _service.CreateInvitationAsync(_db.Alice, _group, days, limit, description!)).Error.Type, Is.EqualTo(ErrorType.Validation)); + + [Test] + public async Task MissingAndUnauthorizedInvitationsCannotBeViewedOrRevoked() + { + Assert.That((await _service.PreviewInvitationAsync(_db.Bob, "unknown")).IsFailure, Is.True); + Assert.That((await _service.JoinByInvitationAsync(_db.Bob, "unknown")).IsFailure, Is.True); + Assert.That((await _service.InvitationsAsync(_db.Bob, _group)).IsFailure, Is.True); + Assert.That((await _service.RevokeInvitationAsync(_db.Bob, _group, Guid.NewGuid())).IsFailure, Is.True); + Assert.That((await _service.RevokeInvitationAsync(_db.Alice, _group, Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.SetRequiredChannelAsync(_db.Alice, Guid.Empty, true)).IsFailure, Is.True); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Medias/MediaAccessTests.cs b/tests/Govor.Application.Tests/Integration/Medias/MediaAccessTests.cs new file mode 100644 index 0000000..838e226 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Medias/MediaAccessTests.cs @@ -0,0 +1,70 @@ +using Govor.Application.Medias; +using Govor.Domain.Models; +using Govor.Domain.Models.Messages; +using Microsoft.EntityFrameworkCore; + +namespace Govor.Application.Tests.Medias; + +[TestFixture] +public class MediaAccessTests +{ + private TestDatabase _db = null!; + private AccesserToDownloadMediaService _service = null!; + [SetUp] public void SetUp() { _db = new TestDatabase(); _service = new(_db.Context); } + [TearDown] public void TearDown() => _db.Dispose(); + + private async Task AddMedia(MediaOwnerType type, Guid? owner = null) + { + var media = new MediaFile { Id = Guid.NewGuid(), UploaderId = _db.Alice, Url = "test.bin", + MineType = "application/octet-stream", OwnerType = type, OwnerId = owner, DateCreated = DateTime.UtcNow }; + _db.Context.MediaFiles.Add(media); + await _db.Context.SaveChangesAsync(); + return media; + } + + [Test] + public async Task MessageAttachmentIsAvailableOnlyToChatParticipants() + { + var message = _db.AddMessage(); + var media = await AddMedia(MediaOwnerType.Message, message.Id); + _db.Context.MediaAttachments.Add(new MediaAttachments { Id = Guid.NewGuid(), MessageId = message.Id, MediaFileId = media.Id }); + await _db.Context.SaveChangesAsync(); + Assert.That(await _service.HasAccessAsync(media.Id, _db.Alice), Is.True); + Assert.That(await _service.HasAccessAsync(media.Id, _db.Bob), Is.True); + Assert.That(await _service.HasAccessAsync(media.Id, _db.Outsider), Is.False); + } + + [TestCase(MediaOwnerType.Avatar)] + [TestCase(MediaOwnerType.System)] + public async Task PublicMediaCanBeDownloaded(MediaOwnerType type) => + Assert.That(await _service.HasAccessAsync((await AddMedia(type)).Id, _db.Outsider), Is.True); + + [TestCase(MediaOwnerType.Message)] + [TestCase(MediaOwnerType.Reaction)] + [TestCase((MediaOwnerType)99)] + public async Task UnattachedMediaCannotBeDownloaded(MediaOwnerType type) => + Assert.That(await _service.HasAccessAsync((await AddMedia(type)).Id, _db.Alice), Is.False); + + [Test] + public async Task UnknownMediaCannotBeDownloaded() => + Assert.That(await _service.HasAccessAsync(Guid.NewGuid(), _db.Alice), Is.False); + + [TestCase(false)] + [TestCase(true)] + public async Task GroupAvatarRequiresMembershipForPrivateGroupAndRejectsBannedMembers(bool isPrivate) + { + var group = new ChatGroup { Id = Guid.NewGuid(), Name = "group", Description = "", IsPrivate = isPrivate }; + _db.Context.ChatGroups.Add(group); + var member = new GroupMembership { Id = Guid.NewGuid(), GroupId = group.Id, UserId = _db.Bob }; + _db.Context.GroupMemberships.Add(member); + await _db.Context.SaveChangesAsync(); + var media = await AddMedia(MediaOwnerType.GroupAvatar, group.Id); + group.ImageId = media.Id; + await _db.Context.SaveChangesAsync(); + Assert.That(await _service.HasAccessAsync(media.Id, _db.Bob), Is.True); + Assert.That(await _service.HasAccessAsync(media.Id, _db.Outsider), Is.EqualTo(!isPrivate)); + member.IsBanned = true; + await _db.Context.SaveChangesAsync(); + Assert.That(await _service.HasAccessAsync(media.Id, _db.Bob), Is.False); + } +} diff --git a/tests/Govor.Application.Tests/Integration/Medias/MediaServiceTests.cs b/tests/Govor.Application.Tests/Integration/Medias/MediaServiceTests.cs new file mode 100644 index 0000000..b22ea1c --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Medias/MediaServiceTests.cs @@ -0,0 +1,110 @@ +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Messages; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Integration.Medias; + +[TestFixture] +public class MediaServiceTests +{ + private TestDatabase _db = null!; + private Mock _storage = null!; + private MediaService _service = null!; + [SetUp] + public void SetUp() + { + _db = new TestDatabase(); + _storage = new Mock(); + _storage.Setup(s => s.SaveAsync(It.IsAny(), It.IsAny())).ReturnsAsync("folder/test.bin"); + _storage.Setup(s => s.LoadAsync("folder/test.bin")).ReturnsAsync(() => new MemoryStream(new byte[] { 1, 2, 3 })); + _service = new(_storage.Object, _db.Context, NullLogger.Instance); + } + [TearDown] public void TearDown() => _db.Dispose(); + + private Task> Upload(MediaOwnerType type = MediaOwnerType.Message) => + _service.UploadMediaAsync(new Media(_db.Alice, DateTime.UtcNow, "test.bin", new byte[] { 1, 2, 3 }, + MediaType.File, "application/octet-stream", "", type, null)); + + [Test] + public async Task UploadReadByIdAndUrlAndDeleteRoundTrip() + { + var uploaded = (await Upload()).Value; + _db.Context.ChangeTracker.Clear(); + Assert.That(await _service.HasMediaAsync(uploaded.MediaId), Is.True); + Assert.That(await _service.HasMediaByUrlAsync(uploaded.Url), Is.True); + foreach (var media in new[] { (await _service.GetMediaByIdAsync(uploaded.MediaId)).Value, + (await _service.GetMediaByUrlAsync(uploaded.Url)).Value }) + { + Assert.That(media.Data, Is.EqualTo(new byte[] { 1, 2, 3 })); + Assert.That(media.UploaderId, Is.EqualTo(_db.Alice)); + Assert.That(media.FileName, Is.EqualTo("test.bin")); + Assert.That(media.MimeType, Is.EqualTo("application/octet-stream")); + Assert.That(media.EncryptedKey, Is.Empty); + } + Assert.That((await _service.DeleteMediaAsync(uploaded.MediaId)).IsSuccess, Is.True); + Assert.That(await _service.HasMediaAsync(uploaded.MediaId), Is.False); + Assert.That(await _service.HasMediaByUrlAsync(uploaded.Url), Is.False); + _storage.Verify(s => s.RemoveAsync(uploaded.Url), Times.Once); + } + + [Test] + public async Task UnknownMediaOperationsReturnNotFoundAndNeverReadStorage() + { + Assert.That((await _service.GetMediaByIdAsync(Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.GetMediaByUrlAsync("unknown")).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.DeleteMediaAsync(Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.AttachToMessageAsync(Guid.NewGuid(), Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + _storage.VerifyNoOtherCalls(); + } + + [TestCase("")] + [TestCase(" ")] + [TestCase(null)] + public async Task BlankUrlReturnsValidationError(string? url) => + Assert.That((await _service.GetMediaByUrlAsync(url!)).Error.Type, Is.EqualTo(ErrorType.Validation)); + + [Test] + public async Task InvalidUploadReturnsFailureWithoutMetadata() + { + _storage.Setup(s => s.SaveAsync(It.IsAny(), It.IsAny())).ThrowsAsync(new ArgumentException("bad data")); + Assert.That((await Upload()).IsFailure, Is.True); + Assert.That(await _db.Context.MediaFiles.CountAsync(), Is.Zero); + } + + [TestCase(false)] + [TestCase(true)] + public async Task MissingStorageFileReturnsServerError(bool byUrl) + { + var uploaded = (await Upload()).Value; + _storage.Setup(s => s.LoadAsync(uploaded.Url)).ThrowsAsync(new FileNotFoundException()); + var result = byUrl ? await _service.GetMediaByUrlAsync(uploaded.Url) : await _service.GetMediaByIdAsync(uploaded.MediaId); + Assert.That(result.Error.Type, Is.EqualTo(ErrorType.ServerError)); + Assert.That(await _service.HasMediaAsync(uploaded.MediaId), Is.True); + } + + [Test] + public async Task FailedStorageDeletePreservesMetadata() + { + var uploaded = (await Upload()).Value; + _storage.Setup(s => s.RemoveAsync(uploaded.Url)).ThrowsAsync(new IOException("disk failure")); + Assert.ThrowsAsync(() => _service.DeleteMediaAsync(uploaded.MediaId)); + Assert.That(await _service.HasMediaAsync(uploaded.MediaId), Is.True); + } + + [Test] + public async Task MessageMediaCanBeAssignedButAvatarCannot() + { + var messageMedia = (await Upload()).Value; + var avatar = (await Upload(MediaOwnerType.Avatar)).Value; + var message = _db.AddMessage(); + Assert.That((await _service.AttachToMessageAsync(messageMedia.MediaId, message.Id)).IsSuccess, Is.True); + Assert.That((await _service.AttachToMessageAsync(avatar.MediaId, message.Id)).IsFailure, Is.True); + _db.Context.ChangeTracker.Clear(); + Assert.That((await _db.Context.MediaFiles.SingleAsync(m => m.Id == messageMedia.MediaId)).OwnerId, Is.EqualTo(message.Id)); + Assert.That((await _db.Context.MediaFiles.SingleAsync(m => m.Id == avatar.MediaId)).OwnerType, Is.EqualTo(MediaOwnerType.Avatar)); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Messages/MessageCommandBoundaryTests.cs b/tests/Govor.Application.Tests/Integration/Messages/MessageCommandBoundaryTests.cs new file mode 100644 index 0000000..6bc3810 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Messages/MessageCommandBoundaryTests.cs @@ -0,0 +1,154 @@ +using Govor.Application.Messages; +using Govor.Application.Messages.Parameters; +using Govor.Application.Tests.Support; +using Govor.Domain.Models; +using Govor.Domain.Models.Messages; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Microsoft.Extensions.Options; + +namespace Govor.Application.Tests.Integration.Messages; + +[TestFixture] +public class MessageCommandBoundaryTests +{ + private TestDatabase _db = null!; + private Guid _group; + private readonly DateTime _now = new(2026, 10, 24, 0, 0, 0, DateTimeKind.Utc); + [SetUp] + public async Task SetUp() + { + _db = new TestDatabase(); + _group = Guid.NewGuid(); + _db.Context.ChatGroups.Add(new ChatGroup { Id = _group, Name = "public", Description = "", OwnerUserId = _db.Alice }); + _db.Context.GroupMemberships.Add(new GroupMembership { Id = Guid.NewGuid(), GroupId = _group, UserId = _db.Alice }); + await _db.Context.SaveChangesAsync(); + } + [TearDown] public void TearDown() => _db.Dispose(); + private MessageSendingService Sender(GovorDbContext? db = null) => new(db ?? _db.Context, NullLogger.Instance); + private MessageEditingService Editor(GovorDbContext? db = null, bool enabled = true) => new(db ?? _db.Context, + NullLogger.Instance, Options.Create(new MessageEditingOptions { Enabled = enabled, MaxEditTimeMinutes = 5 })); + private Message GroupMessage() => _db.AddMessage(chat: _group, type: RecipientType.Group, sentAt: _now); + + [Test] + public async Task PublicGroupMessagePersistsAttachmentsAndPushAtomically() + { + var file = new MediaFile { Id = Guid.NewGuid(), UploaderId = _db.Alice, Url = "photo.png", + MineType = "image/png", OwnerType = MediaOwnerType.Message }; + _db.Context.MediaFiles.Add(file); + await _db.Context.SaveChangesAsync(); + var sent = await Sender().SendMessageAsync(new("public content", null, _group, RecipientType.Group, + _db.Alice, _now, new[] { new SendMedia(file.Id, "") })); + Assert.That(sent.IsSuccess, Is.True); + Assert.That(await _db.Context.MediaAttachments.CountAsync(a => a.MessageId == sent.Message.Id), Is.EqualTo(1)); + Assert.That(await _db.Context.ChatPushNotifications.AnyAsync(p => p.MessageId == sent.Message.Id), Is.True); + } + + [TestCase("empty")] + [TestCase("too-long")] + [TestCase("too-many-files")] + [TestCase("bad-envelope")] + [TestCase("bad-type")] + [TestCase("missing-group")] + [TestCase("missing-chat")] + [TestCase("missing-media")] + [TestCase("foreign-reply")] + public async Task InvalidSendDoesNotPersistMessageOrPush(string reason) + { + var content = reason == "empty" ? "" : reason == "too-long" ? new string('x', Govor.Application.E2ee.E2eeProtocol.MaxEnvelopeLength + 1) : + reason == "bad-envelope" ? Govor.Application.E2ee.E2eeProtocol.Prefix + "bad" : "content"; + var files = reason == "too-many-files" ? Enumerable.Range(0, 101).Select(_ => new SendMedia(Guid.NewGuid(), "")).ToArray() : + reason == "missing-media" ? new[] { new SendMedia(Guid.NewGuid(), "") } : Array.Empty(); + var type = reason == "bad-type" ? (RecipientType)99 : reason == "missing-chat" ? RecipientType.User : RecipientType.Group; + var target = reason is "missing-group" or "missing-chat" ? Guid.NewGuid() : _group; + var request = new SendMessage(content, reason == "foreign-reply" ? Guid.NewGuid() : null, target, type, _db.Alice, _now, files); + Assert.That((await Sender().SendMessageAsync(request)).IsSuccess, Is.False); + Assert.That(await _db.Context.Messages.CountAsync(), Is.Zero); + Assert.That(await _db.Context.ChatPushNotifications.CountAsync(), Is.Zero); + } + + [Test] + public async Task PublicGroupEditPersistsAndReturnsOriginalContext() + { + var message = GroupMessage(); + var result = await Editor().EditMessageAsync(new(_db.Alice, message.Id, "edited", _now.AddMinutes(1))); + Assert.That(result.IsSuccess, Is.True); + Assert.That(result.OriginalMessage!.Id, Is.EqualTo(message.Id)); + var stored = await _db.Context.Messages.AsNoTracking().SingleAsync(); + Assert.That(stored.EncryptedContent, Is.EqualTo("edited")); + Assert.That(stored.IsEdited, Is.True); + Assert.That(stored.EditedAt, Is.EqualTo(_now.AddMinutes(1))); + } + + [TestCase("missing")] + [TestCase("not-author")] + [TestCase("expired")] + [TestCase("blank")] + [TestCase("null")] + [TestCase("too-long")] + public async Task InvalidEditLeavesOriginalMessage(string reason) + { + var message = GroupMessage(); + var content = reason == "blank" ? " " : reason == "null" ? null : reason == "too-long" ? + new string('x', Govor.Application.E2ee.E2eeProtocol.MaxEnvelopeLength + 1) : "edited"; + var result = await Editor().EditMessageAsync(new(reason == "not-author" ? _db.Bob : _db.Alice, + reason == "missing" ? Guid.NewGuid() : message.Id, content!, reason == "expired" ? _now.AddMinutes(6) : _now.AddMinutes(1))); + Assert.That(result.IsSuccess, Is.False); + Assert.That((await _db.Context.Messages.AsNoTracking().SingleAsync()).EncryptedContent, Is.EqualTo("hello")); + } + + [Test] + public async Task DisablingEditDeadlinePermitsAnOldPublicGroupMessage() + { + var message = GroupMessage(); + Assert.That((await Editor(enabled: false).EditMessageAsync(new(_db.Alice, message.Id, "edited", _now.AddDays(1)))).IsSuccess, Is.True); + } + + [TestCase("send")] + [TestCase("edit")] + [TestCase("delete")] + public async Task PersistenceFailureRollsBackGroupOperation(string operation) + { + var message = operation == "send" ? null : GroupMessage(); + var predicate = operation == "send" ? "INSERT INTO \"ChatPushNotifications\"" : + operation == "edit" ? "UPDATE \"Messages\"" : "DELETE FROM \"Messages\""; + using var failed = _db.CreateContext(new FailDatabaseCommand(sql => sql.Contains(predicate, StringComparison.Ordinal))); + if (operation == "send") + Assert.ThrowsAsync(() => Sender(failed).SendMessageAsync(new("content", null, _group, RecipientType.Group, _db.Alice, _now, []))); + else if (operation == "edit") + Assert.ThrowsAsync(() => Editor(failed).EditMessageAsync(new(_db.Alice, message!.Id, "edited", _now))); + else + Assert.ThrowsAsync(() => new MessageRemovingService(failed, NullLogger.Instance) + .DeleteMessageAsync(new(_db.Alice, message!.Id, true))); + Assert.That(await _db.Context.Messages.CountAsync(), Is.EqualTo(operation == "send" ? 0 : 1)); + Assert.That(await _db.Context.ChatPushNotifications.CountAsync(), Is.Zero); + if (operation == "edit") Assert.That((await _db.Context.Messages.AsNoTracking().SingleAsync()).EncryptedContent, Is.EqualTo("hello")); + Assert.That(failed.ChangeTracker.Entries(), Is.Empty); + } + + [Test] + public async Task DeleteValidatesMissingMessageAndExplicitGlobalRemoval() + { + var service = new MessageRemovingService(_db.Context, NullLogger.Instance); + Assert.That((await service.DeleteMessageAsync(new(_db.Alice, Guid.NewGuid(), true))).Error.Code, Is.EqualTo("Message.NotFound")); + var message = GroupMessage(); + Assert.That((await service.DeleteMessageAsync(new(_db.Alice, message.Id, false))).Error.Code, Is.EqualTo("Message.HideNotSupported")); + Assert.That((await service.DeleteMessageAsync(new(_db.Bob, message.Id, true))).Error.Code, Is.EqualTo("Chat.AccessDenied")); + Assert.That(await _db.Context.Messages.AnyAsync(m => m.Id == message.Id), Is.True); + } + + [Test] + public async Task GroupHistoryUsesMembershipAndBoundaryPagination() + { + var messages = Enumerable.Range(0, 3).Select(i => _db.AddMessage(chat: _group, type: RecipientType.Group, sentAt: _now.AddMinutes(i))).ToArray(); + var loader = new MessagesLoader(_db.Context); + Assert.That((await loader.LoadMessagesInChatGroup(_group, _db.Alice, messages[1].Id, 1, 1)).Value.Select(m => m.Id), + Is.EqualTo(messages.Select(m => m.Id))); + Assert.That((await loader.LoadMessagesInChatGroup(_group, _db.Bob, null)).IsFailure, Is.True); + Assert.That((await loader.LoadMessagesInChatGroup(Guid.Empty, _db.Alice, null)).IsFailure, Is.True); + Assert.That(await _db.Context.HasChatAccessAsync(Guid.Empty, _group, RecipientType.Group), Is.False); + Assert.That(await _db.Context.HasChatAccessAsync(_db.Alice, Guid.Empty, RecipientType.Group), Is.False); + Assert.That(await _db.Context.HasChatAccessAsync(_db.Alice, _group, (RecipientType)99), Is.False); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Messages/MessagesLoaderTests.cs b/tests/Govor.Application.Tests/Integration/Messages/MessagesLoaderTests.cs new file mode 100644 index 0000000..e1c0164 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Messages/MessagesLoaderTests.cs @@ -0,0 +1,60 @@ +using Govor.Application.Messages; +using Govor.Domain.Models.Messages; +using Microsoft.EntityFrameworkCore; + +namespace Govor.Application.Tests.Messages; + +[TestFixture] +public class MessagesLoaderTests +{ + private TestDatabase _db = null!; + private MessagesLoader _loader = null!; + [SetUp] public void SetUp() { _db = new TestDatabase(); _loader = new(_db.Context); } + [TearDown] public void TearDown() => _db.Dispose(); + + [Test] + public async Task LatestPageIsChronologicalAndLimited() + { + var start = DateTime.UtcNow.AddHours(-1); + var messages = Enumerable.Range(0, 5).Select(i => _db.AddMessage(sentAt: start.AddMinutes(i))).ToArray(); + var result = await _loader.LoadMessagesInUserChat(_db.ChatId, _db.Bob, null, 3, 0); + Assert.That(result.IsSuccess, Is.True); + Assert.That(result.Value.Select(m => m.Id), Is.EqualTo(messages.Skip(2).Select(m => m.Id))); + } + + [Test] + public async Task AnchorIncludesRequestedMessagesOnBothSides() + { + var start = DateTime.UtcNow.AddHours(-1); + var messages = Enumerable.Range(0, 5).Select(i => _db.AddMessage(sentAt: start.AddMinutes(i))).ToArray(); + var result = await _loader.LoadMessagesInUserChat(_db.ChatId, _db.Alice, messages[2].Id, 1, 1); + Assert.That(result.Value.Select(m => m.Id), Is.EqualTo(messages.Skip(1).Take(3).Select(m => m.Id))); + } + + [Test] + public async Task EqualTimestampsUseIdAsStableTieBreaker() + { + var now = DateTime.UtcNow; + for (var i = 1; i <= 5; i++) _db.AddMessage(sentAt: now, id: Guid.Parse($"00000000-0000-0000-0000-{i:D12}")); + var expected = await _db.Context.Messages.OrderBy(m => m.Id).Select(m => m.Id).ToArrayAsync(); + var result = await _loader.LoadMessagesInUserChat(_db.ChatId, _db.Bob, expected[2], 1, 1); + Assert.That(result.Value.Select(m => m.Id), Is.EqualTo(expected.Skip(1).Take(3))); + } + + [Test] + public async Task MissingAnchorReturnsEmptyPage() + { + _db.AddMessage(); + var result = await _loader.LoadMessagesInUserChat(_db.ChatId, _db.Alice, Guid.NewGuid()); + Assert.That(result.IsSuccess, Is.True); + Assert.That(result.Value, Is.Empty); + } + + [Test] + public async Task OutsiderCannotLoadPrivateChat() => + Assert.That((await _loader.LoadMessagesInUserChat(_db.ChatId, _db.Outsider, null)).IsFailure, Is.True); + + [Test] + public async Task EmptyConversationIsRejected() => + Assert.That((await _loader.LoadMessagesInUserChat(Guid.Empty, _db.Alice, null)).IsFailure, Is.True); +} diff --git a/tests/Govor.Application.Tests/Integration/Messages/ReadBoundaryTests.cs b/tests/Govor.Application.Tests/Integration/Messages/ReadBoundaryTests.cs new file mode 100644 index 0000000..e171980 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Messages/ReadBoundaryTests.cs @@ -0,0 +1,43 @@ +using Govor.Application.Messages; +using Govor.Application.Infrastructure.Common; +using Govor.Domain.Models.Messages; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Integration.Messages; + +[TestFixture] +public class ReadBoundaryTests +{ + [Test] + public async Task EmptyChatReturnsZeroAndMissingBoundaryDoesNotCreateReceipts() + { + using var db = new TestDatabase(); + var reader = new MessageReadingService(db.Context, NullLogger.Instance, + Mock.Of(c => c.Now == DateTime.UtcNow.Date)); + var empty = await reader.ReadChatAsync(db.Bob, db.ChatId, RecipientType.User); + Assert.That(empty.IsSuccess, Is.True); + Assert.That(empty.Value.ReadCount, Is.Zero); + Assert.That(empty.Value.UnreadCount, Is.Zero); + Assert.That((await reader.ReadChatAsync(db.Bob, db.ChatId, RecipientType.User, upToMessageId: Guid.NewGuid())).Error.Code, + Is.EqualTo("Message.Read.BoundaryNotFound")); + Assert.That((await reader.ReadMessageAsync(db.Bob, Guid.NewGuid())).Error.Code, Is.EqualTo("Message.NotFound")); + Assert.That((await reader.GetUnreadCountAsync(db.Outsider, db.ChatId, RecipientType.User)).IsFailure, Is.True); + Assert.That(await db.Context.MessageViews.CountAsync(), Is.Zero); + } + + [Test] + public async Task InvalidSelectionsAndOwnMessagesCannotBeMarkedRead() + { + using var db = new TestDatabase(); + var reader = new MessageReadingService(db.Context, NullLogger.Instance, Mock.Of()); + var own = db.AddMessage(sender: db.Bob); + Assert.That((await reader.ReadChatAsync(db.Bob, db.ChatId, RecipientType.User, new[] { own.Id })).Error.Code, Is.EqualTo("Message.Read.OwnMessage")); + foreach (var selection in new[] { Array.Empty(), new[] { Guid.Empty }, Enumerable.Repeat(own.Id, 101).ToArray() }) + Assert.That((await reader.ReadChatAsync(db.Bob, db.ChatId, RecipientType.User, selection)).IsFailure, Is.True); + Assert.That((await reader.ReadChatAsync(db.Bob, db.ChatId, RecipientType.User, new[] { own.Id }, own.Id)).IsFailure, Is.True); + Assert.That(await db.Context.MessageViews.CountAsync(), Is.Zero); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/PrivateUserChats/UserPrivateChatsCreatorTests.cs b/tests/Govor.Application.Tests/Integration/PrivateUserChats/UserPrivateChatsCreatorTests.cs new file mode 100644 index 0000000..e45ad13 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/PrivateUserChats/UserPrivateChatsCreatorTests.cs @@ -0,0 +1,73 @@ +using Govor.Application.PrivateUserChats; +using Govor.Application.Groups; +using Govor.Application.Infrastructure.AdminsStuff; +using Govor.Domain.Models; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.PrivateUserChats; + +[TestFixture] +public class UserPrivateChatsCreatorTests +{ + private TestDatabase _db = null!; + private Mock _manager = null!; + private UserPrivateChatsCreator _service = null!; + [SetUp] + public void SetUp() + { + _db = new TestDatabase(); + _manager = new Mock(); + _service = new(_db.Context, _manager.Object, NullLogger.Instance); + } + [TearDown] public void TearDown() => _db.Dispose(); + + [Test] + public async Task ExistingChatIsFoundInEitherUserOrder() + { + Assert.That((await _service.CreateAsync(_db.Alice, _db.Bob)).Id, Is.EqualTo(_db.ChatId)); + Assert.That((await _service.CreateAsync(_db.Bob, _db.Alice)).Id, Is.EqualTo(_db.ChatId)); + Assert.That(await _db.Context.PrivateChats.CountAsync(), Is.EqualTo(1)); + _manager.VerifyNoOtherCalls(); + } + + [Test] + public async Task NewChatIsSavedAndUsersJoinSignalRGroupOnce() + { + var chat = await _service.CreateAsync(_db.Alice, _db.Outsider); + Assert.That(await _db.Context.PrivateChats.AnyAsync(c => c.Id == chat.Id), Is.True); + await _service.CreateAsync(_db.Outsider, _db.Alice); + _manager.Verify(m => m.AddUsersToPrivateChatGroupAsync(It.Is(c => c.Id == chat.Id)), Times.Once); + } + + [Test] + public async Task GroupListExcludesBannedAndUnrelatedMemberships() + { + var group = new ChatGroup { Id = Guid.NewGuid(), Name = "group", Description = "" }; + _db.Context.ChatGroups.Add(group); + _db.Context.GroupMemberships.AddRange( + new GroupMembership { Id = Guid.NewGuid(), GroupId = group.Id, UserId = _db.Alice }, + new GroupMembership { Id = Guid.NewGuid(), GroupId = group.Id, UserId = _db.Bob, IsBanned = true }); + await _db.Context.SaveChangesAsync(); + var getter = new UserGroupsGetterService(_db.Context); + Assert.That((await getter.GetUserGroupsAsync(_db.Alice)).Select(g => g.Id), Is.EqualTo(new[] { group.Id })); + Assert.That(await getter.GetUserGroupsAsync(_db.Bob), Is.Empty); + Assert.That(await getter.GetUserGroupsAsync(_db.Outsider), Is.Empty); + } + + [Test] + public async Task InvitationGeneratorPersistsUniqueCodesAndMetadata() + { + var generator = new InvitationGenerator(_db.Context); + var end = DateTime.UtcNow.Date.AddDays(2); + var first = await generator.GenerateInvitationCode(end, 5, true, "admin"); + var second = await generator.GenerateInvitationCode(end, 10, false); + Assert.That(first, Is.Not.EqualTo(second)); + var invite = await _db.Context.Invitations.AsNoTracking().SingleAsync(i => i.Code == first); + Assert.That(invite.EndDate, Is.EqualTo(end)); + Assert.That(invite.MaxParticipants, Is.EqualTo(5)); + Assert.That(invite.IsAdmin, Is.True); + Assert.That(invite.Description, Is.EqualTo("admin")); + } +} diff --git a/tests/Govor.Application.Tests/Integration/Profiles/ProfileServiceTests.cs b/tests/Govor.Application.Tests/Integration/Profiles/ProfileServiceTests.cs new file mode 100644 index 0000000..509f0f0 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Profiles/ProfileServiceTests.cs @@ -0,0 +1,62 @@ +using Govor.Application.Profiles; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; + +namespace Govor.Application.Tests.Profiles; + +[TestFixture] +public class ProfileServiceTests +{ + private TestDatabase _db = null!; + private ProfileService _service = null!; + [SetUp] public void SetUp() { _db = new TestDatabase(); _service = new(_db.Context, NullLogger.Instance); } + [TearDown] public void TearDown() => _db.Dispose(); + + [Test] + public async Task ReadAndUpdateDescriptionPersistWithoutChangingOtherUsers() + { + Assert.That((await _service.SetDescription("new description", _db.Alice)).IsSuccess, Is.True); + var profile = (await _service.GetUserProfileAsync(_db.Alice)).Value; + Assert.That(profile.Id, Is.EqualTo(_db.Alice)); + Assert.That(profile.Description, Is.EqualTo("new description")); + Assert.That((await _service.GetUserProfileAsync(_db.Bob)).Value.Description, Is.Empty); + } + + [Test] + public async Task MissingUserReturnsNotFound() + { + Assert.That((await _service.GetUserProfileAsync(Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.SetDescription("test", Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + } + + [TestCase(true, MediaOwnerType.Avatar, true)] + [TestCase(false, MediaOwnerType.Avatar, false)] + [TestCase(true, MediaOwnerType.Message, false)] + public async Task IconMustBeOwnUploadedAvatar(bool owned, MediaOwnerType type, bool success) + { + var media = new MediaFile { Id = Guid.NewGuid(), UploaderId = owned ? _db.Alice : _db.Bob, + Url = "avatar.png", MineType = "image/png", OwnerType = type }; + _db.Context.MediaFiles.Add(media); + await _db.Context.SaveChangesAsync(); + Assert.That((await _service.SetNewIcon(_db.Alice, media.Id)).IsSuccess, Is.EqualTo(success)); + Assert.That((await _service.GetUserProfileAsync(_db.Alice)).Value.IconId, + Is.EqualTo(success ? media.Id : Guid.Empty)); + } + + [Test] + public async Task AvatarOfDeletedAccountDoesNotPermitUpdatingMissingProfile() + { + var media = new MediaFile { Id = Guid.NewGuid(), UploaderId = _db.Outsider, Url = "avatar.png", + MineType = "image/png", OwnerType = MediaOwnerType.Avatar }; + _db.Context.MediaFiles.Add(media); + await _db.Context.SaveChangesAsync(); + await _db.Context.Users.Where(u => u.Id == _db.Outsider).ExecuteDeleteAsync(); + Assert.That((await _service.SetNewIcon(_db.Outsider, media.Id)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + } + + [Test] + public async Task UnknownMediaCannotBeUsedAsIcon() => + Assert.That((await _service.SetNewIcon(_db.Alice, Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.Forbidden)); +} diff --git a/tests/Govor.Application.Tests/Integration/PushNotifications/PushTokenServiceTests.cs b/tests/Govor.Application.Tests/Integration/PushNotifications/PushTokenServiceTests.cs new file mode 100644 index 0000000..7c32ac4 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/PushNotifications/PushTokenServiceTests.cs @@ -0,0 +1,103 @@ +using Govor.Application.PushNotifications; +using Govor.Application.Infrastructure.Common; +using Govor.Application.Tests.Support; +using Govor.Domain.Common; +using Govor.Domain.Models.Users; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Integration.PushNotifications; + +[TestFixture] +public class PushTokenServiceTests +{ + private TestDatabase _db = null!; + private PushTokenService _service = null!; + private readonly DateTime _now = new(2026, 10, 24, 0, 0, 0, DateTimeKind.Utc); + private INowDateTimeProvider Clock => Mock.Of(c => c.Now == _now); + [SetUp] public void SetUp() { _db = new TestDatabase(); _service = new(_db.Context, Clock, NullLogger.Instance); } + [TearDown] public void TearDown() => _db.Dispose(); + + private async Task Add(Guid user, string token, bool revoked = false, bool expired = false, bool active = true) + { + var session = new UserSession { UserId = user, RefreshTokenHash = token, ExpiresAt = _now.AddDays(expired ? -1 : 1), IsRevoked = revoked }; + _db.Context.UserSessions.Add(session); + _db.Context.UserPushTokens.Add(new UserPushToken { UserId = user, UserSessionId = session.Id, + Token = token, Platform = "android", IsActive = active }); + await _db.Context.SaveChangesAsync(); + return session.Id; + } + + [Test] + public async Task TokenQueriesFilterOwnerExpiryRevocationAndActivity() + { + var alice = await Add(_db.Alice, "alice"); + await Add(_db.Alice, "expired", expired: true); + await Add(_db.Alice, "revoked", revoked: true); + await Add(_db.Alice, "inactive", active: false); + await Add(_db.Bob, "bob"); + Assert.That((await _service.GetStringsActiveTokensAsync(_db.Alice)).Value, Is.EqualTo(new[] { "alice" })); + Assert.That((await _service.GetActiveTokenBySessionAsync(alice)).Value, Is.EqualTo("alice")); + Assert.That((await _service.GetUsersStringsActiveTokensAsync(new[] { _db.Alice, _db.Bob, _db.Alice })).Value, + Is.EquivalentTo(new[] { "alice", "bob" })); + Assert.That((await _service.GetActiveTokenBySessionAsync(Guid.NewGuid())).Value, Is.Null); + } + + [Test] + public async Task DeactivationScopesAndRemovalPreserveUnrelatedTokens() + { + var first = await Add(_db.Alice, "first"); + await Add(_db.Alice, "second"); + await Add(_db.Bob, "bob"); + Assert.That((await _service.DeactivateTokenBySessionAsync(first)).IsSuccess, Is.True); + Assert.That((await _service.GetStringsActiveTokensAsync(_db.Alice)).Value, Is.EqualTo(new[] { "second" })); + Assert.That((await _service.DeactivateAllTokensByUserIdAsync(_db.Alice)).IsSuccess, Is.True); + Assert.That((await _service.GetStringsActiveTokensAsync(_db.Alice)).Value, Is.Empty); + Assert.That((await _service.GetStringsActiveTokensAsync(_db.Bob)).Value, Is.EqualTo(new[] { "bob" })); + Assert.That((await _service.RemoveTokensAsync(new[] { "first", "second", "unknown" })).IsSuccess, Is.True); + Assert.That(await _db.Context.UserPushTokens.AsNoTracking().Select(t => t.Token).ToListAsync(), Is.EqualTo(new[] { "bob" })); + Assert.That((await _service.RemoveTokensAsync(Array.Empty())).IsSuccess, Is.True); + Assert.That((await _service.RemoveTokensAsync(null!)).IsSuccess, Is.True); + } + + [Test] + public async Task EveryDatabaseOperationReturnsFailureWhenItsCommandFails() + { + using var failed = _db.CreateContext(new FailDatabaseCommand()); + var service = new PushTokenService(failed, Clock, NullLogger.Instance); + Assert.That((await service.DeactivateTokenBySessionAsync(Guid.NewGuid())).IsFailure, Is.True); + Assert.That((await service.DeactivateAllTokensByUserIdAsync(_db.Alice)).IsFailure, Is.True); + Assert.That((await service.GetStringsActiveTokensAsync(_db.Alice)).IsFailure, Is.True); + Assert.That((await service.GetUsersStringsActiveTokensAsync(new[] { _db.Alice })).IsFailure, Is.True); + Assert.That((await service.GetActiveTokenBySessionAsync(Guid.NewGuid())).IsFailure, Is.True); + Assert.That((await service.RemoveTokensAsync(new[] { "token" })).IsFailure, Is.True); + } + + [TestCase("empty")] + [TestCase("long-token")] + [TestCase("long-platform")] + public async Task InvalidTokenArgumentsDoNotCreateRows(string kind) + { + var token = kind == "empty" ? "" : kind == "long-token" ? new string('t', 513) : "token"; + var platform = kind == "long-platform" ? new string('p', 51) : "android"; + Assert.That((await _service.AddOrUpdateTokenAsync(_db.Alice, Guid.NewGuid(), token, platform)).Error.Type, Is.EqualTo(ErrorType.Validation)); + Assert.That(await _db.Context.UserPushTokens.CountAsync(), Is.Zero); + } + + [Test] + public async Task TwoExistingTokenRowsMergeWhenDeviceChangesAccount() + { + var alice = await Add(_db.Alice, "shared"); + var bob = await Add(_db.Bob, "old-bob"); + Assert.That((await _service.AddOrUpdateTokenAsync(_db.Bob, bob, "shared", "ios")).IsSuccess, Is.True); + _db.Context.ChangeTracker.Clear(); + var token = await _db.Context.UserPushTokens.SingleAsync(); + Assert.That(token.UserId, Is.EqualTo(_db.Bob)); + Assert.That(token.UserSessionId, Is.EqualTo(bob)); + Assert.That(token.Token, Is.EqualTo("shared")); + Assert.That(token.Platform, Is.EqualTo("ios")); + Assert.That((await _service.GetActiveTokenBySessionAsync(alice)).Value, Is.Null); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Reactions/ReactionPackBoundaryTests.cs b/tests/Govor.Application.Tests/Integration/Reactions/ReactionPackBoundaryTests.cs new file mode 100644 index 0000000..58ebb1b --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Reactions/ReactionPackBoundaryTests.cs @@ -0,0 +1,158 @@ +using Govor.Application.Infrastructure.Common; +using Govor.Application.Reactions; +using Govor.Application.Tests.Support; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Reactions; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Integration.Reactions; + +[TestFixture] +public class ReactionPackBoundaryTests +{ + private TestDatabase _db = null!; + private ReactionPackService _service = null!; + private Mock _processor = null!; + private Mock _storage = null!; + private readonly DateTime _now = new(2026, 10, 24, 0, 0, 0, DateTimeKind.Utc); + private ReactionPackService Service(GovorDbContext db) => new(db, Mock.Of(c => c.Now == _now), + _processor.Object, _storage.Object, NullLogger.Instance); + [SetUp] + public async Task SetUp() + { + _db = new TestDatabase(); + var invite = new Invitation { Id = Guid.NewGuid(), Code = "admin", Description = "", IsAdmin = true }; + _db.Context.Invitations.Add(invite); + (await _db.Context.Users.SingleAsync(u => u.Id == _db.Alice)).InviteId = invite.Id; + await _db.Context.SaveChangesAsync(); + _processor = new Mock(MockBehavior.Strict); + _storage = new Mock(MockBehavior.Strict); + _service = Service(_db.Context); + } + [TearDown] public void TearDown() => _db.Dispose(); + private async Task Pack() => (await _service.CreateAsync(_db.Alice, "Custom", "")).Value; + + [Test] + public async Task UpdateDisableAndHistoryPreserveDefinitions() + { + var pack = await Pack(); + var item = (await _service.AddEmojiAsync(_db.Alice, pack.Id, "like", "👍")).Value; + var updated = await _service.UpdateAsync(_db.Alice, pack.Id, " Renamed ", " details ", true); + Assert.That(updated.Value.Name, Is.EqualTo("Renamed")); + Assert.That(updated.Value.Description, Is.EqualTo("details")); + Assert.That((await _service.DisableReactionAsync(_db.Alice, pack.Id, item.Id)).IsSuccess, Is.True); + Assert.That((await _service.GetAsync(pack.Id)).Value.Reactions, Is.Empty); + Assert.That((await _service.GetAsync(pack.Id, includeDisabled: true)).Value.Reactions.Single().Id, Is.EqualTo(item.Id)); + Assert.That((await _service.GetReactionAsync(item.Id)).Value.IsEnabled, Is.False); + Assert.That((await _service.UpdateAsync(_db.Alice, pack.Id, "Renamed", "", false)).IsSuccess, Is.True); + Assert.That((await _service.GetAsync(pack.Id)).IsFailure, Is.True); + Assert.That((await _service.GetAsync(pack.Id, true)).IsSuccess, Is.True); + Assert.That((await _service.GetSharedAsync(pack.ShareCode)).IsFailure, Is.True); + Assert.That((await _service.SubscribeAsync(_db.Bob, pack.Id, true)).IsFailure, Is.True); + Assert.That((await _service.ListAsync(_db.Bob, includeDisabled: true)).Any(p => p.Id == pack.Id), Is.True); + } + + [Test] + public async Task DefaultPackCannotBeChangedDisabledOrUninstalled() + { + var pack = await _db.Context.ReactionPacks.SingleAsync(p => p.IsDefault); + var item = await _db.Context.ReactionItems.FirstAsync(r => r.PackId == pack.Id); + Assert.That((await _service.UpdateAsync(_db.Alice, pack.Id, "default", "", true)).IsFailure, Is.True); + Assert.That((await _service.DisableAsync(_db.Alice, pack.Id)).IsFailure, Is.True); + Assert.That((await _service.DisableReactionAsync(_db.Alice, pack.Id, item.Id)).IsFailure, Is.True); + Assert.That((await _service.SubscribeAsync(_db.Bob, pack.Id, false)).IsFailure, Is.True); + Assert.That((await _service.SubscribeAsync(_db.Bob, pack.Id, true)).IsSuccess, Is.True); + } + + [Test] + public async Task MissingPackOrItemReturnsFailureForEveryMutation() + { + var id = Guid.NewGuid(); + Assert.That((await _service.GetAsync(id)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.GetReactionAsync(id)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.GetSharedAsync("missing")).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.UpdateAsync(_db.Alice, id, "name", "", true)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.DisableAsync(_db.Alice, id)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.DisableReactionAsync(_db.Alice, id, id)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.AddEmojiAsync(_db.Alice, id, "name", "👍")).IsFailure, Is.True); + } + + [Test] + public async Task NonAdminCannotMutatePacksOrUploadFiles() + { + var pack = await Pack(); + Assert.That((await _service.CreateAsync(_db.Bob, "name", "")).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.UpdateAsync(_db.Bob, pack.Id, "name", "", true)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.DisableAsync(_db.Bob, pack.Id)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.DisableReactionAsync(_db.Bob, pack.Id, Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.AddEmojiAsync(_db.Bob, pack.Id, "name", "👍")).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.AddMediaAsync(_db.Bob, pack.Id, "name", new byte[] { 1 })).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + _processor.VerifyNoOtherCalls(); + _storage.VerifyNoOtherCalls(); + } + + [TestCase("")] + [TestCase(" ")] + [TestCase("letters")] + [TestCase("👍👍")] + public async Task InvalidEmojiDoesNotCreateReaction(string emoji) + { + var pack = await Pack(); + Assert.That((await _service.AddEmojiAsync(_db.Alice, pack.Id, "name", emoji)).IsFailure, Is.True); + Assert.That(await _db.Context.ReactionItems.CountAsync(r => r.PackId == pack.Id), Is.Zero); + } + + [TestCase("name")] + [TestCase("description")] + [TestCase("reaction")] + public async Task OversizedTextIsRejected(string field) + { + var pack = await Pack(); + if (field == "name") Assert.That((await _service.CreateAsync(_db.Alice, new string('x', 101), "")).IsFailure, Is.True); + if (field == "description") Assert.That((await _service.UpdateAsync(_db.Alice, pack.Id, "name", new string('x', 501), true)).IsFailure, Is.True); + if (field == "reaction") Assert.That((await _service.AddEmojiAsync(_db.Alice, pack.Id, "", "👍")).IsFailure, Is.True); + } + + [Test] + public async Task DisabledEntriesStillCountTowardPackLimit() + { + var pack = await Pack(); + _db.Context.ReactionItems.AddRange(Enumerable.Range(0, 100).Select(i => new ReactionItem { + Id = Guid.NewGuid(), PackId = pack.Id, Name = "item-" + i, Code = ":test_" + i + ":", Emoji = "👍", IsEnabled = false })); + await _db.Context.SaveChangesAsync(); + Assert.That((await _service.AddEmojiAsync(_db.Alice, pack.Id, "overflow", "👍")).IsFailure, Is.True); + } + + [Test] + public async Task ProcessorFailureIsReturnedBeforeStorageWrite() + { + var pack = await Pack(); + var error = Error.Validation("Media.Invalid", "bad image"); + _processor.Setup(p => p.ProcessAsync(It.IsAny(), It.IsAny())) + .ReturnsAsync(Result.Failure(error)); + Assert.That((await _service.AddMediaAsync(_db.Alice, pack.Id, "name", new byte[] { 1 })).Error, Is.SameAs(error)); + _storage.VerifyNoOtherCalls(); + } + + [TestCase(false)] + [TestCase(true)] + public async Task FailedDatabaseWriteRollsBackMediaAndAttemptsStorageCleanup(bool cleanupFails) + { + var pack = await Pack(); + _processor.Setup(p => p.ProcessAsync(It.IsAny(), It.IsAny())).ReturnsAsync( + new ProcessedReactionMedia(new byte[] { 1 }, ReactionKind.Image, "image/png", ".png", 10, 10, 0)); + _storage.Setup(s => s.SaveAsync(It.IsAny(), It.IsAny())).ReturnsAsync("failed.png"); + if (cleanupFails) _storage.Setup(s => s.RemoveAsync("failed.png")).ThrowsAsync(new IOException("cleanup failure")); + else _storage.Setup(s => s.RemoveAsync("failed.png")).Returns(Task.CompletedTask); + using var failed = _db.CreateContext(new FailDatabaseCommand(sql => sql.Contains("INSERT INTO \"MediaFiles\"", StringComparison.Ordinal))); + Assert.ThrowsAsync(() => Service(failed).AddMediaAsync(_db.Alice, pack.Id, "name", new byte[] { 1 })); + _storage.Verify(s => s.RemoveAsync("failed.png"), Times.Once); + Assert.That(await _db.Context.ReactionItems.CountAsync(r => r.PackId == pack.Id), Is.Zero); + Assert.That(await _db.Context.MediaFiles.CountAsync(), Is.Zero); + Assert.That(failed.ChangeTracker.Entries(), Is.Empty); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Reactions/ReactionPolicyBoundaryTests.cs b/tests/Govor.Application.Tests/Integration/Reactions/ReactionPolicyBoundaryTests.cs new file mode 100644 index 0000000..f04833f --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Reactions/ReactionPolicyBoundaryTests.cs @@ -0,0 +1,66 @@ +using Govor.Application.Infrastructure.Common; +using Govor.Application.Reactions; +using Govor.Domain.Common; +using Govor.Domain.Models; +using Govor.Domain.Models.Reactions; +using Microsoft.EntityFrameworkCore; +using Moq; + +namespace Govor.Application.Tests.Integration.Reactions; + +[TestFixture] +public class ReactionPolicyBoundaryTests +{ + private TestDatabase _db = null!; + private MessageReactionService _service = null!; + private Guid _group; + [SetUp] + public async Task SetUp() + { + _db = new TestDatabase(); + _group = Guid.NewGuid(); + _db.Context.ChatGroups.Add(new ChatGroup { Id = _group, Name = "channel", Description = "", IsChannel = true, OwnerUserId = _db.Alice }); + _db.Context.GroupMemberships.Add(new GroupMembership { Id = Guid.NewGuid(), GroupId = _group, UserId = _db.Alice }); + await _db.Context.SaveChangesAsync(); + _service = new(_db.Context, Mock.Of(c => c.Now == DateTime.UtcNow.Date)); + } + [TearDown] public void TearDown() => _db.Dispose(); + + [TestCase("mode")] + [TestCase("null")] + [TestCase("too-many")] + [TestCase("empty-id")] + [TestCase("wrong-mode")] + [TestCase("unavailable")] + public async Task InvalidPolicyDoesNotChangeModeVersionOrAllowedReactions(string reason) + { + var ids = reason == "null" ? null : reason == "too-many" ? Enumerable.Repeat(Guid.NewGuid(), 101).ToArray() : + reason == "empty-id" ? new[] { Guid.Empty } : new[] { Guid.NewGuid() }; + var mode = reason == "mode" ? (ChannelReactionMode)99 : reason == "wrong-mode" ? ChannelReactionMode.All : ChannelReactionMode.Selected; + var result = await _service.SetPolicyAsync(_db.Alice, _group, mode, ids!); + Assert.That(result.Error.Type, Is.EqualTo(ErrorType.Validation)); + var stored = await _db.Context.ChatGroups.AsNoTracking().SingleAsync(); + Assert.That(stored.ReactionPolicyVersion, Is.Zero); + Assert.That(stored.ReactionMode, Is.EqualTo(ChannelReactionMode.All)); + Assert.That(await _db.Context.ChannelAllowedReactions.CountAsync(), Is.Zero); + } + + [Test] + public async Task MissingOrInaccessibleMessageAndGroupCannotBeRead() + { + var message = _db.AddMessage(); + Assert.That((await _service.GetAsync(_db.Alice, Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That((await _service.GetAsync(_db.Outsider, message.Id)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.GetPolicyAsync(_db.Outsider, _group)).Error.Type, Is.EqualTo(ErrorType.Forbidden)); + Assert.That((await _service.SetPolicyAsync(_db.Outsider, _group, ChannelReactionMode.None, [])).IsFailure, Is.True); + } + + [Test] + public async Task OrdinaryGroupCannotReceiveChannelPolicy() + { + await _db.Context.ChatGroups.Where(g => g.Id == _group).ExecuteUpdateAsync(s => s.SetProperty(g => g.IsChannel, false)); + Assert.That((await _service.SetPolicyAsync(_db.Alice, _group, ChannelReactionMode.None, [])).Error.Code, + Is.EqualTo("Reaction.Policy.NotChannel")); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Users/PingHandlerServiceTests.cs b/tests/Govor.Application.Tests/Integration/Users/PingHandlerServiceTests.cs new file mode 100644 index 0000000..d1d7a9a --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Users/PingHandlerServiceTests.cs @@ -0,0 +1,28 @@ +using Govor.Application.PingHandler; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Caching.Memory; + +namespace Govor.Application.Tests.Users; + +[TestFixture] +public class PingHandlerServiceTests +{ + [Test] + public async Task PingUpdatesLastSeenAndThrottlesRepeatedRequests() + { + using var db = new TestDatabase(); + using var cache = new MemoryCache(new MemoryCacheOptions()); + var service = new PingHandlerService(db.Context, cache); + var old = DateTime.UtcNow.AddHours(-1); + await db.Context.Users.Where(u => u.Id == db.Alice).ExecuteUpdateAsync(s => s.SetProperty(u => u.WasOnline, old)); + var before = DateTime.UtcNow; + await service.Ping(db.Alice); + var updated = await db.Context.Users.AsNoTracking().SingleAsync(u => u.Id == db.Alice); + Assert.That(updated.WasOnline, Is.GreaterThanOrEqualTo(before)); + Assert.That(cache.TryGetValue($"LastPing_{db.Alice}", out DateTime _), Is.True); + await db.Context.Users.Where(u => u.Id == db.Alice).ExecuteUpdateAsync(s => s.SetProperty(u => u.WasOnline, old)); + var storedBeforeThrottledPing = (await db.Context.Users.AsNoTracking().SingleAsync(u => u.Id == db.Alice)).WasOnline; + await service.Ping(db.Alice); + Assert.That((await db.Context.Users.AsNoTracking().SingleAsync(u => u.Id == db.Alice)).WasOnline, Is.EqualTo(storedBeforeThrottledPing)); + } +} diff --git a/tests/Govor.Application.Tests/Integration/Users/ReaderTests.cs b/tests/Govor.Application.Tests/Integration/Users/ReaderTests.cs new file mode 100644 index 0000000..a96f5ea --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Users/ReaderTests.cs @@ -0,0 +1,48 @@ +using Govor.Application.PrivateUserChats; +using Govor.Domain.Common; +using Microsoft.EntityFrameworkCore; + +namespace Govor.Application.Tests.Integration.Users; + +[TestFixture] +public class ReaderTests +{ + [Test] + public async Task PresenceReturnsPersistedLastSeenOrNullForMissingUser() + { + using var db = new TestDatabase(); + var time = new DateTime(2026, 10, 24, 10, 0, 0, DateTimeKind.Utc); + await db.Context.Users.Where(u => u.Id == db.Alice).ExecuteUpdateAsync(s => s.SetProperty(u => u.WasOnline, time)); + var reader = new UserPresenceReader(db.Context); + Assert.That(await reader.GetLastSeenAsync(db.Alice), Is.EqualTo(time)); + Assert.That(await reader.GetLastSeenAsync(Guid.NewGuid()), Is.Null); + Assert.That(await reader.GetLastSeenAsync(Guid.Empty), Is.Null); + } + + [Test] + public async Task PrivateChatReaderFiltersBothPositionsAndHandlesMissingChat() + { + using var db = new TestDatabase(); + var reader = new UserPrivateChatsGetter(db.Context); + Assert.That((await reader.GetUserChatsAsync(db.Alice)).Select(c => c.Id), Is.EqualTo(new[] { db.ChatId })); + Assert.That((await reader.GetUserChatsAsync(db.Bob)).Select(c => c.Id), Is.EqualTo(new[] { db.ChatId })); + Assert.That(await reader.GetUserChatsAsync(db.Outsider), Is.Empty); + Assert.That((await reader.GetPrivateChatAsync(db.ChatId)).Value.Id, Is.EqualTo(db.ChatId)); + Assert.That((await reader.GetPrivateChatAsync(Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound)); + Assert.That(await reader.ExistChatAsync(db.Alice, db.Bob), Is.True); + Assert.That(await reader.ExistChatAsync(db.Bob, db.Alice), Is.True); + Assert.That(await reader.ExistChatAsync(db.Alice, db.Outsider), Is.False); + } + + [Test] + public async Task UsernameExistenceHandlesBlankUnknownAndExistingUsernames() + { + using var db = new TestDatabase(); + var validator = new Govor.Application.Users.UserNameExistValidator(db.Context); + Assert.That(await validator.IsUsernameExistsAsync(" "), Is.False); + Assert.That(await validator.IsUsernameExistsAsync(null!), Is.False); + Assert.That(await validator.IsUsernameExistsAsync("missing"), Is.False); + Assert.That(await validator.IsUsernameExistsAsync(db.Alice.ToString()), Is.True); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Users/SessionCryptoTests.cs b/tests/Govor.Application.Tests/Integration/Users/SessionCryptoTests.cs new file mode 100644 index 0000000..45f7e22 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Users/SessionCryptoTests.cs @@ -0,0 +1,135 @@ +using Govor.Application.Users.UserSessions.Crypto; +using Govor.Domain.Models.Users; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Integration.Users; + +[TestFixture] +public class SessionCryptoTests +{ + private TestDatabase _db = null!; + private SessionKeyAttacher _attacher = null!; + private SessionKeysReader _reader = null!; + private OneTimePreKeysRotator _rotator = null!; + private Mock _current = null!; + + [SetUp] + public void SetUp() + { + _db = new TestDatabase(); + _current = new Mock(); + _current.Setup(c => c.GetCurrentUserId()).Returns(_db.Alice); + _attacher = new(NullLogger.Instance, _current.Object, _db.Context); + _reader = new(NullLogger.Instance, _db.Context); + _rotator = new(NullLogger.Instance, _current.Object, _db.Context); + } + [TearDown] public void TearDown() => _db.Dispose(); + + private async Task Session(Guid? user = null, bool revoked = false, bool expired = false) + { + var session = new UserSession { UserId = user ?? _db.Alice, RefreshTokenHash = Guid.NewGuid().ToString(), + ExpiresAt = DateTime.UtcNow.AddDays(expired ? -1 : 1), IsRevoked = revoked }; + _db.Context.UserSessions.Add(session); + await _db.Context.SaveChangesAsync(); + return session; + } + private Task Attach(Guid id) => _attacher.AttachKeysAsync(id, new byte[] { 1 }, new byte[] { 2 }, + new byte[] { 3 }, new[] { new byte[] { 4 }, new byte[] { 5 } }); + + [Test] + public async Task AttachesIdentitySignedAndOneTimeKeysAndReadsThemFromDatabase() + { + var session = await Session(); + Assert.That(await _reader.HasKeysAttachedAsync(session.Id), Is.False); + await Attach(session.Id); + _db.Context.ChangeTracker.Clear(); + Assert.That(await _reader.HasKeysAttachedAsync(session.Id), Is.True); + var keys = (await _reader.GetAllActiveKeysAsync(_db.Alice)).Single(); + Assert.Multiple(() => + { + Assert.That(keys.UserSessionId, Is.EqualTo(session.Id)); + Assert.That(keys.PublicIdentityKey, Is.EqualTo(new byte[] { 1 })); + Assert.That(keys.SignedPreKey.PublicSignedPreKey, Is.EqualTo(new byte[] { 2 })); + Assert.That(keys.SignedPreKey.SignedPreKeySignature, Is.EqualTo(new byte[] { 3 })); + Assert.That(keys.OneTimePreKeys.Select(k => k.PublicKey[0]), Is.EquivalentTo(new byte[] { 4, 5 })); + }); + Assert.That(await _reader.GetRemainingOneTimePreKeysCountAsync(session.Id), Is.EqualTo(2)); + var bySession = await _reader.GetKeysBySessionIdAsync(session.Id); + Assert.That(bySession!.UserSession.Id, Is.EqualTo(session.Id)); + Assert.That(bySession.OneTimePreKeys.Count, Is.EqualTo(2)); + Assert.That(bySession.SignedPreKey, Is.Not.Null); + } + + [Test] + public async Task CannotReplaceAttachedKeysOrAttachToAnotherUsersSession() + { + var own = await Session(); + var other = await Session(_db.Bob); + await Attach(own.Id); + Assert.ThrowsAsync(() => Attach(own.Id)); + Assert.ThrowsAsync(() => Attach(other.Id)); + Assert.ThrowsAsync(() => Attach(Guid.NewGuid())); + Assert.That(await _reader.HasKeysAttachedAsync(other.Id), Is.False); + } + + [Test] + public async Task ActiveKeysExcludeExpiredRevokedAndOtherUsersSessions() + { + var active = await Session(); + var expired = await Session(expired: true); + var revoked = await Session(revoked: true); + var bob = await Session(_db.Bob); + foreach (var session in new[] { active, expired, revoked }) await Attach(session.Id); + _current.Setup(c => c.GetCurrentUserId()).Returns(_db.Bob); + await Attach(bob.Id); + _db.Context.ChangeTracker.Clear(); + Assert.That((await _reader.GetAllActiveKeysAsync(_db.Alice)).Select(k => k.UserSessionId), Is.EqualTo(new[] { active.Id })); + Assert.That((await _reader.GetAllActiveKeysAsync(_db.Bob)).Select(k => k.UserSessionId), Is.EqualTo(new[] { bob.Id })); + } + + [Test] + public async Task UsedKeyIsIdempotentAndRotationDeletesOnlyUsedKeys() + { + var session = await Session(); + await Attach(session.Id); + var keys = await _db.Context.OneTimePreKeys.OrderBy(k => k.Id).ToListAsync(); + await _rotator.MarkOneTimePreKeyAsUsedAsync(session.Id, keys[0].Id); + await _rotator.MarkOneTimePreKeyAsUsedAsync(session.Id, keys[0].Id); + Assert.That(await _reader.GetRemainingOneTimePreKeysCountAsync(session.Id), Is.EqualTo(1)); + await _rotator.RotateOneTimePreKeysAsync(session.Id, new[] { new byte[] { 6 } }); + _db.Context.ChangeTracker.Clear(); + Assert.That(await _db.Context.OneTimePreKeys.AnyAsync(k => k.Id == keys[0].Id), Is.False); + Assert.That(await _db.Context.OneTimePreKeys.AnyAsync(k => k.Id == keys[1].Id), Is.True); + Assert.That(await _reader.GetRemainingOneTimePreKeysCountAsync(session.Id), Is.EqualTo(2)); + await _rotator.RotateOneTimePreKeysAsync(session.Id, Array.Empty()); + Assert.That(await _reader.GetRemainingOneTimePreKeysCountAsync(session.Id), Is.EqualTo(2)); + } + + [Test] + public async Task AnotherUserCannotRotateOrConsumeKeysOfThisSession() + { + var session = await Session(); + await Attach(session.Id); + var key = await _db.Context.OneTimePreKeys.FirstAsync(); + _current.Setup(c => c.GetCurrentUserId()).Returns(_db.Bob); + Assert.ThrowsAsync(() => _rotator.RotateOneTimePreKeysAsync(session.Id, new[] { new byte[] { 9 } })); + Assert.ThrowsAsync(() => _rotator.MarkOneTimePreKeyAsUsedAsync(session.Id, key.Id)); + Assert.That(await _reader.GetRemainingOneTimePreKeysCountAsync(session.Id), Is.EqualTo(2)); + } + + [Test] + public async Task MissingSessionAndMismatchedKeyAreRejected() + { + var session = await Session(); + await Attach(session.Id); + var key = await _db.Context.OneTimePreKeys.FirstAsync(); + Assert.ThrowsAsync(() => _rotator.MarkOneTimePreKeyAsUsedAsync(Guid.NewGuid(), key.Id)); + Assert.ThrowsAsync(() => _rotator.MarkOneTimePreKeyAsUsedAsync(session.Id, Guid.NewGuid())); + Assert.ThrowsAsync(() => _rotator.RotateOneTimePreKeysAsync(Guid.NewGuid(), Array.Empty())); + Assert.That(await _reader.GetKeysBySessionIdAsync(Guid.NewGuid()), Is.Null); + Assert.That(await _reader.GetRemainingOneTimePreKeysCountAsync(Guid.NewGuid()), Is.Zero); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Users/UserSessionFailureTests.cs b/tests/Govor.Application.Tests/Integration/Users/UserSessionFailureTests.cs new file mode 100644 index 0000000..1567c0b --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Users/UserSessionFailureTests.cs @@ -0,0 +1,105 @@ +using Govor.Application.Authentication.JWT; +using Govor.Application.Tests.Support; +using Govor.Application.PushNotifications; +using Govor.Domain.Common; +using Govor.Domain.Models.Users; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Microsoft.Extensions.Options; +using Moq; + +namespace Govor.Application.Tests.Integration.Users; + +[TestFixture] +public class UserSessionFailureTests +{ + [Test] + public async Task ReaderAndRevokerReturnFailuresWithoutTouchingPushTokensOnDatabaseErrors() + { + using var db = new TestDatabase(); + var session = new UserSession { UserId = db.Alice, RefreshTokenHash = "hash", ExpiresAt = DateTime.UtcNow.AddDays(1) }; + db.Context.UserSessions.Add(session); + await db.Context.SaveChangesAsync(); + using var failed = db.CreateContext(new FailDatabaseCommand()); + var push = new Mock(MockBehavior.Strict); + var reader = new UserSessionReader(failed, NullLogger.Instance); + var revoker = new UserSessionRevoker(failed, push.Object, NullLogger.Instance); + Assert.That((await reader.GetAllSessionsAsync(db.Alice)).IsFailure, Is.True); + Assert.That((await revoker.CloseSessionByIdAsync(session.Id, db.Alice)).IsFailure, Is.True); + Assert.That((await revoker.CloseAllSessionsAsync(db.Alice)).IsFailure, Is.True); + push.VerifyNoOtherCalls(); + Assert.That((await db.Context.UserSessions.AsNoTracking().SingleAsync()).IsRevoked, Is.False); + } + + [Test] + public async Task OpeningSessionStopsAfterReaderFailure() + { + using var db = new TestDatabase(); + var reader = new Mock(); + var error = Error.ServerError("Sessions.Unavailable", "unavailable"); + reader.Setup(r => r.GetAllSessionsAsync(db.Alice)).ReturnsAsync(Result.Failure>(error)); + var jwt = new Mock(MockBehavior.Strict); + var opener = new UserSessionOpener(NullLogger.Instance, reader.Object, db.Context, + Mock.Of(), Options.Create(new JwtRefreshOption()), jwt.Object); + var result = await opener.OpenSessionAsync(await db.Context.Users.SingleAsync(u => u.Id == db.Alice), "phone"); + Assert.That(result.Error, Is.SameAs(error)); + jwt.VerifyNoOtherCalls(); + Assert.That(await db.Context.UserSessions.CountAsync(), Is.Zero); + } + + [Test] + public async Task FailedSessionInsertReturnsFailureAndLeavesNoSession() + { + using var db = new TestDatabase(); + using var failed = db.CreateContext(new FailDatabaseCommand(sql => sql.Contains("INSERT INTO \"UserSessions\"", StringComparison.Ordinal))); + var reader = new UserSessionReader(failed, NullLogger.Instance); + var jwt = new Mock(); + jwt.Setup(j => j.GenerateAccessTokenAsync(It.IsAny(), It.IsAny())).ReturnsAsync("access"); + jwt.Setup(j => j.GenerateRefreshTokenAsync(It.IsAny())).ReturnsAsync("refresh"); + var hash = new Mock(); + hash.Setup(h => h.HashToken("refresh")).Returns("hash"); + var opener = new UserSessionOpener(NullLogger.Instance, reader, failed, hash.Object, + Options.Create(new JwtRefreshOption { RefreshTokenLifetimeDays = 30 }), jwt.Object); + Assert.That((await opener.OpenSessionAsync(await db.Context.Users.SingleAsync(u => u.Id == db.Alice), null!)).IsFailure, Is.True); + Assert.That(await db.Context.UserSessions.CountAsync(), Is.Zero); + } + + [Test] + public async Task RefreshDatabaseFailureReturnsFailure() + { + using var db = new TestDatabase(); + using var failed = db.CreateContext(new FailDatabaseCommand()); + var hash = Mock.Of(h => h.HashToken("token") == "hash"); + var service = new UserSessionRefresher(NullLogger.Instance, + Options.Create(new JwtRefreshOption()), hash, Mock.Of(), failed); + Assert.That((await service.RefreshTokenAsync("token")).IsFailure, Is.True); + } + + [Test] + public async Task RevocationBetweenTokenLookupAndRotationRejectsRefresh() + { + using var db = new TestDatabase(); + var session = new UserSession { UserId = db.Alice, RefreshTokenHash = "old-hash", ExpiresAt = DateTime.UtcNow.AddDays(1) }; + db.Context.UserSessions.Add(session); + await db.Context.SaveChangesAsync(); + var jwt = new Mock(); + jwt.Setup(j => j.GenerateAccessTokenAsync(It.IsAny(), session.Id)).ReturnsAsync("access"); + jwt.Setup(j => j.GenerateRefreshTokenAsync(It.IsAny())).Returns(async () => + { + await db.Context.UserSessions.Where(s => s.Id == session.Id).ExecuteUpdateAsync(s => s.SetProperty(s => s.IsRevoked, true)); + return "new"; + }); + var hash = new Mock(); + hash.Setup(h => h.HashToken("old")).Returns("old-hash"); + hash.Setup(h => h.HashToken("new")).Returns("new-hash"); + using var context = db.CreateContext(); + var service = new UserSessionRefresher(NullLogger.Instance, + Options.Create(new JwtRefreshOption { RefreshTokenLifetimeDays = 30 }), hash.Object, jwt.Object, context); + var result = await service.RefreshTokenAsync("old"); + Assert.That(result.Error.Type, Is.EqualTo(ErrorType.Unauthorized)); + var stored = await db.Context.UserSessions.AsNoTracking().SingleAsync(); + Assert.That(stored.RefreshTokenHash, Is.EqualTo("old-hash")); + Assert.That(stored.IsRevoked, Is.True); + } +} + diff --git a/tests/Govor.Application.Tests/Integration/Users/UserSessionTests.cs b/tests/Govor.Application.Tests/Integration/Users/UserSessionTests.cs new file mode 100644 index 0000000..fe8a2a4 --- /dev/null +++ b/tests/Govor.Application.Tests/Integration/Users/UserSessionTests.cs @@ -0,0 +1,132 @@ +using Govor.Application.Authentication.JWT; +using Govor.Application.Users.UserSessions; +using Govor.Application.PushNotifications; +using Govor.Domain.Common; +using Govor.Domain.Models.Users; +using Microsoft.EntityFrameworkCore; +using Microsoft.Extensions.Logging.Abstractions; +using Microsoft.Extensions.Options; +using Moq; + +namespace Govor.Application.Tests.Users; + +[TestFixture] +public class UserSessionTests +{ + private TestDatabase _db = null!; + private Mock _jwt = null!; + private Mock _hasher = null!; + private UserSessionReader _reader = null!; + private UserSessionRefresher _refresher = null!; + private UserSessionOpener _opener = null!; + private Mock _push = null!; + private UserSessionRevoker _revoker = null!; + + [SetUp] + public void SetUp() + { + _db = new TestDatabase(); + _jwt = new Mock(); + _jwt.Setup(j => j.GenerateAccessTokenAsync(It.IsAny(), It.IsAny())) + .ReturnsAsync((User _, Guid sid) => "access-" + sid); + _jwt.Setup(j => j.GenerateRefreshTokenAsync(It.IsAny())).ReturnsAsync(() => Guid.NewGuid().ToString()); + _hasher = new Mock(); + _hasher.Setup(h => h.HashToken(It.IsAny())).Returns((string token) => "hash-" + token); + _reader = new UserSessionReader(_db.Context, NullLogger.Instance); + var options = Options.Create(new JwtRefreshOption { RefreshTokenLifetimeDays = 30 }); + _opener = new UserSessionOpener(NullLogger.Instance, _reader, _db.Context, + _hasher.Object, options, _jwt.Object); + _refresher = new UserSessionRefresher(NullLogger.Instance, options, + _hasher.Object, _jwt.Object, _db.Context); + _push = new Mock(); + _push.Setup(p => p.DeactivateTokenBySessionAsync(It.IsAny())).ReturnsAsync(Result.Success()); + _push.Setup(p => p.DeactivateAllTokensByUserIdAsync(It.IsAny())).ReturnsAsync(Result.Success()); + _revoker = new UserSessionRevoker(_db.Context, _push.Object, NullLogger.Instance); + } + [TearDown] public void TearDown() => _db.Dispose(); + + private async Task AddSession(Guid user, bool revoked = false, bool expired = false) + { + var session = new UserSession { UserId = user, RefreshTokenHash = "hash-" + Guid.NewGuid(), + ExpiresAt = DateTime.UtcNow.AddDays(expired ? -1 : 1), IsRevoked = revoked, DeviceInfo = "phone" }; + _db.Context.UserSessions.Add(session); + await _db.Context.SaveChangesAsync(); + return session; + } + + [Test] + public async Task SameDeviceLabelStillCreatesDistinctSessionsAndStoresOnlyTokenHashes() + { + var user = await _db.Context.Users.SingleAsync(u => u.Id == _db.Alice); + var first = await _opener.OpenSessionAsync(user, "phone"); + var second = await _opener.OpenSessionAsync(user, "phone"); + Assert.That(first.IsSuccess && second.IsSuccess, Is.True); + var sessions = await _db.Context.UserSessions.AsNoTracking().ToListAsync(); + Assert.That(sessions, Has.Count.EqualTo(2)); + Assert.That(sessions.Select(s => s.Id).Distinct().Count(), Is.EqualTo(2)); + Assert.That(sessions.Select(s => s.RefreshTokenHash), Is.EquivalentTo( + new[] { "hash-" + first.Value.refreshToken, "hash-" + second.Value.refreshToken })); + Assert.That(sessions.All(s => s.ExpiresAt > DateTime.UtcNow.AddDays(29)), Is.True); + } + + [Test] + public async Task ReaderFiltersOwnerAndRevocation() + { + var own = await AddSession(_db.Alice); + await AddSession(_db.Alice, revoked: true); + await AddSession(_db.Bob); + Assert.That((await _reader.GetAllSessionsAsync(_db.Alice)).Value.Select(s => s.Id), Is.EqualTo(new[] { own.Id })); + Assert.That((await _reader.GetAllSessionsAsync(Guid.Empty)).IsFailure, Is.True); + } + + [Test] + public async Task RefreshRotatesHashAndRejectsReplay() + { + var session = await AddSession(_db.Alice); + var oldToken = session.RefreshTokenHash["hash-".Length..]; + var result = await _refresher.RefreshTokenAsync(oldToken); + Assert.That(result.IsSuccess, Is.True); + Assert.That(result.Value.accessToken, Is.EqualTo("access-" + session.Id)); + _db.Context.ChangeTracker.Clear(); + Assert.That((await _db.Context.UserSessions.SingleAsync()).RefreshTokenHash, + Is.EqualTo("hash-" + result.Value.refreshToken)); + Assert.That((await _refresher.RefreshTokenAsync(oldToken)).IsFailure, Is.True); + } + + [TestCase(true, false)] + [TestCase(false, true)] + public async Task RevokedOrExpiredSessionCannotRefresh(bool revoked, bool expired) + { + var session = await AddSession(_db.Alice, revoked, expired); + Assert.That((await _refresher.RefreshTokenAsync(session.RefreshTokenHash["hash-".Length..])).IsFailure, Is.True); + _jwt.Verify(j => j.GenerateRefreshTokenAsync(It.IsAny()), Times.Never); + } + + [TestCase("")] + [TestCase(" ")] + [TestCase("unknown")] + public async Task InvalidRefreshTokenReturnsFailure(string token) => + Assert.That((await _refresher.RefreshTokenAsync(token)).IsFailure, Is.True); + + [Test] + public async Task SessionCanBeRevokedOnlyByOwnerAndPushTokenIsDeactivated() + { + var session = await AddSession(_db.Alice); + Assert.That((await _revoker.CloseSessionByIdAsync(session.Id, _db.Bob)).Error.Type, Is.EqualTo(ErrorType.NotFound)); + _push.VerifyNoOtherCalls(); + Assert.That((await _revoker.CloseSessionByIdAsync(session.Id, _db.Alice)).IsSuccess, Is.True); + Assert.That((await _db.Context.UserSessions.AsNoTracking().SingleAsync()).IsRevoked, Is.True); + _push.Verify(p => p.DeactivateTokenBySessionAsync(session.Id), Times.Once); + } + + [Test] + public async Task CloseAllIsIdempotentAndKeepsOtherUsersSessions() + { + await AddSession(_db.Alice); + var bob = await AddSession(_db.Bob); + Assert.That((await _revoker.CloseAllSessionsAsync(_db.Alice)).IsSuccess, Is.True); + Assert.That((await _revoker.CloseAllSessionsAsync(_db.Alice)).IsSuccess, Is.True); + Assert.That((await _db.Context.UserSessions.AsNoTracking().SingleAsync(s => s.Id == bob.Id)).IsRevoked, Is.False); + _push.Verify(p => p.DeactivateAllTokensByUserIdAsync(_db.Alice), Times.Once); + } +} diff --git a/tests/Govor.Application.Tests/Support/FailDatabaseCommand.cs b/tests/Govor.Application.Tests/Support/FailDatabaseCommand.cs new file mode 100644 index 0000000..01407a7 --- /dev/null +++ b/tests/Govor.Application.Tests/Support/FailDatabaseCommand.cs @@ -0,0 +1,32 @@ +using System.Data.Common; +using Microsoft.EntityFrameworkCore.Diagnostics; + +namespace Govor.Application.Tests.Support; + +// Inject a provider-independent command failure after schema/seed initialization. +internal sealed class FailDatabaseCommand(Func? matches = null, Func? beforeFailure = null) : DbCommandInterceptor +{ + private readonly Func _matches = matches ?? (_ => true); + public override async ValueTask> ReaderExecutingAsync(DbCommand command, + CommandEventData eventData, InterceptionResult result, CancellationToken cancellationToken = default) + { + if (_matches(command.CommandText)) + { + if (beforeFailure is not null) await beforeFailure(); + throw new InvalidOperationException("Simulated database failure."); + } + return result; + } + + public override async ValueTask> NonQueryExecutingAsync(DbCommand command, + CommandEventData eventData, InterceptionResult result, CancellationToken cancellationToken = default) + { + if (_matches(command.CommandText)) + { + if (beforeFailure is not null) await beforeFailure(); + throw new InvalidOperationException("Simulated database failure."); + } + return result; + } +} + diff --git a/Govor.Application.Tests/Services/Authentication/JwtServiceTests.cs b/tests/Govor.Application.Tests/Unit/Authentication/JwtServiceTests.cs similarity index 89% rename from Govor.Application.Tests/Services/Authentication/JwtServiceTests.cs rename to tests/Govor.Application.Tests/Unit/Authentication/JwtServiceTests.cs index d6dd2ff..709ee2c 100644 --- a/Govor.Application.Tests/Services/Authentication/JwtServiceTests.cs +++ b/tests/Govor.Application.Tests/Unit/Authentication/JwtServiceTests.cs @@ -2,8 +2,6 @@ using System.IdentityModel.Tokens.Jwt; using System.Security.Claims; using System.Text; using AutoFixture; -using Govor.Application.Interfaces.Authentication; -using Govor.Application.Services.Authentication; using Govor.Domain.Models.Users; using Microsoft.Extensions.Options; using Microsoft.IdentityModel.Tokens; @@ -14,15 +12,13 @@ namespace Govor.Application.Tests.Services.Authentication; [TestFixture] public class JwtServiceTests { - private Fixture _fixture; - private Mock> _jwtOptionsMock; - private Mock> _jwtRefreshOptionsMock; - private Mock _invitesServiceMock; - private IJwtService _jwtService; - - private JwtAccessOption _testJwtAccessOptions; - private JwtRefreshOption _testJwtRefreshOptions; - + private Fixture _fixture = null!; + private Mock> _jwtOptionsMock = null!; + private Mock> _jwtRefreshOptionsMock = null!; + private Mock _invitesServiceMock = null!; + private IJwtService _jwtService = null!; + private JwtAccessOption _testJwtAccessOptions = null!; + private JwtRefreshOption _testJwtRefreshOptions = null!; [SetUp] public void SetUp() { @@ -62,7 +58,7 @@ public class JwtServiceTests var user = _fixture.Create(); var sessionId = Guid.NewGuid(); var expectedRole = "User"; - _invitesServiceMock.Setup(s => s.GetRoleAsync(user)).ReturnsAsync(expectedRole); + _invitesServiceMock.Setup(s => s.GetRoleNameAsync(user)).ReturnsAsync(expectedRole); // Act var tokenString = await _jwtService.GenerateAccessTokenAsync(user, sessionId); @@ -86,7 +82,7 @@ public class JwtServiceTests var user = new User { Id = Guid.NewGuid(), Username = "TestUser" }; var sessionId = Guid.NewGuid(); var role = "Admin"; - _invitesServiceMock.Setup(s => s.GetRoleAsync(user)).ReturnsAsync(role); + _invitesServiceMock.Setup(s => s.GetRoleNameAsync(user)).ReturnsAsync(role); // Act var token = await _jwtService.GenerateAccessTokenAsync(user, sessionId); @@ -154,4 +150,4 @@ public class JwtServiceTests Assert.That(claim, Is.Not.Null); Assert.That(userId.ToString(), Is.EqualTo(claim.Value)); } -} \ No newline at end of file +} diff --git a/Govor.Application.Tests/Services/Authentication/JwtTokenHasherTests.cs b/tests/Govor.Application.Tests/Unit/Authentication/JwtTokenHasherTests.cs similarity index 93% rename from Govor.Application.Tests/Services/Authentication/JwtTokenHasherTests.cs rename to tests/Govor.Application.Tests/Unit/Authentication/JwtTokenHasherTests.cs index 6063c1a..a83c746 100644 --- a/Govor.Application.Tests/Services/Authentication/JwtTokenHasherTests.cs +++ b/tests/Govor.Application.Tests/Unit/Authentication/JwtTokenHasherTests.cs @@ -1,13 +1,11 @@ using AutoFixture; -using Govor.Application.Interfaces.Authentication; -using Govor.Application.Services.Authentication; using Microsoft.Extensions.Configuration; [TestFixture] public class JwtTokenHasherTests { - private IJwtTokenHasher _jwtTokenHasher; - private Fixture _fixture; + private IJwtTokenHasher _jwtTokenHasher = null!; + private Fixture _fixture = null!; private const string TestSecret = "SuperSecretPepper123!"; [SetUp] @@ -92,4 +90,4 @@ public class JwtTokenHasherTests // Act & Assert Assert.Throws(() => new JwtTokenHasher(emptyConfig)); } -} \ No newline at end of file +} diff --git a/Govor.Application.Tests/Services/PasswordHasherTests.cs b/tests/Govor.Application.Tests/Unit/Authentication/PasswordHasherTests.cs similarity index 87% rename from Govor.Application.Tests/Services/PasswordHasherTests.cs rename to tests/Govor.Application.Tests/Unit/Authentication/PasswordHasherTests.cs index cb6b195..411e3ea 100644 --- a/Govor.Application.Tests/Services/PasswordHasherTests.cs +++ b/tests/Govor.Application.Tests/Unit/Authentication/PasswordHasherTests.cs @@ -1,15 +1,12 @@ using AutoFixture; -using Govor.Application.Services.Authentication; -using Govor.Domain.Infrastructure.Extensions; namespace Govor.Application.Tests.Services; [TestFixture] public class PasswordHasherTests { - private IPasswordHasher _passwordHasher; - private Fixture _fixture; - + private IPasswordHasher _passwordHasher = null!; + private Fixture _fixture = null!; [SetUp] public void StarUp() { @@ -48,4 +45,4 @@ public class PasswordHasherTests // Assert Assert.That(result, Is.False); } -} \ No newline at end of file +} diff --git a/Govor.Application.Tests/Infrastructure/Extensions/CurrentUserServiceTests.cs b/tests/Govor.Application.Tests/Unit/Infrastructure/Extensions/CurrentUserServiceTests.cs similarity index 95% rename from Govor.Application.Tests/Infrastructure/Extensions/CurrentUserServiceTests.cs rename to tests/Govor.Application.Tests/Unit/Infrastructure/Extensions/CurrentUserServiceTests.cs index 31fc66b..5e0deab 100644 --- a/Govor.Application.Tests/Infrastructure/Extensions/CurrentUserServiceTests.cs +++ b/tests/Govor.Application.Tests/Unit/Infrastructure/Extensions/CurrentUserServiceTests.cs @@ -1,6 +1,5 @@ using System.Security.Claims; using Govor.Application.Infrastructure.Extensions; -using Govor.Application.Interfaces.Infrastructure.Extensions; using Microsoft.AspNetCore.Http; using Moq; @@ -9,9 +8,8 @@ namespace Govor.Application.Tests.Infrastructure.Extensions; [TestFixture] public class CurrentUserServiceTests { - private Mock _httpContextAccessorMock; - private ICurrentUserService _currentUserService; - + private Mock _httpContextAccessorMock = null!; + private ICurrentUserService _currentUserService = null!; [SetUp] public void SetUp() { @@ -104,4 +102,4 @@ public class CurrentUserServiceTests var ex = Assert.Throws(() => _currentUserService.GetCurrentUserId()); Assert.That(ex.Message, Is.EqualTo("userID claim is missing or invalid")); } -} \ No newline at end of file +} diff --git a/Govor.Application.Tests/Infrastructure/Extensions/CurrentUserSessionServiceTests.cs b/tests/Govor.Application.Tests/Unit/Infrastructure/Extensions/CurrentUserSessionServiceTests.cs similarity index 95% rename from Govor.Application.Tests/Infrastructure/Extensions/CurrentUserSessionServiceTests.cs rename to tests/Govor.Application.Tests/Unit/Infrastructure/Extensions/CurrentUserSessionServiceTests.cs index c9c42e5..873dc74 100644 --- a/Govor.Application.Tests/Infrastructure/Extensions/CurrentUserSessionServiceTests.cs +++ b/tests/Govor.Application.Tests/Unit/Infrastructure/Extensions/CurrentUserSessionServiceTests.cs @@ -1,6 +1,5 @@ using System.Security.Claims; using Govor.Application.Infrastructure.Extensions; -using Govor.Application.Interfaces.Infrastructure.Extensions; using Microsoft.AspNetCore.Http; using Moq; @@ -10,9 +9,8 @@ namespace Govor.Application.Tests.Infrastructure.Extensions; [TestOf(typeof(CurrentUserSessionService))] public class CurrentUserSessionServiceTests { - private Mock _httpContextAccessorMock; - private ICurrentUserSessionService _sessionService; - + private Mock _httpContextAccessorMock = null!; + private ICurrentUserSessionService _sessionService = null!; [SetUp] public void SetUp() { @@ -106,4 +104,4 @@ public class CurrentUserSessionServiceTests var ex = Assert.Throws(() => _sessionService.GetUserSessionId()); Assert.That(ex.Message, Is.EqualTo("Session id (sid) claim is missing or invalid")); } -} \ No newline at end of file +} diff --git a/tests/Govor.Application.Tests/Unit/Infrastructure/Validators/UsernameBoundaryTests.cs b/tests/Govor.Application.Tests/Unit/Infrastructure/Validators/UsernameBoundaryTests.cs new file mode 100644 index 0000000..c6f58c8 --- /dev/null +++ b/tests/Govor.Application.Tests/Unit/Infrastructure/Validators/UsernameBoundaryTests.cs @@ -0,0 +1,52 @@ +using Govor.Domain.Common; +using Microsoft.Extensions.Configuration; + +namespace Govor.Application.Tests.Unit.Infrastructure.Validators; + +[TestFixture] +public class UsernameBoundaryTests +{ + private static Dictionary Settings() => new() + { + ["UsernameModeration:BlockedExact:0"] = "админ", + ["UsernameModeration:BlockedContains:0"] = "запрет", + ["UsernameModeration:Reserved:0"] = "логин" + }; + private static UsernameValidator Validator() => new(new ConfigurationBuilder().AddInMemoryCollection(Settings()).Build()); + + [Test] + public void NameLengthBoundariesAndNullReturnValidationResults() + { + var validator = Validator(); + var longest = string.Concat(Enumerable.Repeat("Иван", 11)); + Assert.That(validator.Validate("Иван").IsSuccess, Is.True); + Assert.That(validator.Validate(longest).IsSuccess, Is.True); + foreach (var invalid in new[] { null, "", " ", "Ива", longest + "а" }) + { + var result = validator.Validate(invalid!); + Assert.That(result.IsFailure, Is.True); + Assert.That(result.Error.Type, Is.EqualTo(ErrorType.Validation)); + Assert.That(validator.TryValidate(invalid!), Is.False); + } + } + + [TestCase("Абббб", true)] + [TestCase("Аббббб", false)] + [TestCase("Иван0", true)] + [TestCase("Админ", false)] + [TestCase("ЛОГИН", false)] + [TestCase("Запрет123", false)] + public void SyntaxRepetitionAndModerationAreApplied(string name, bool valid) => + Assert.That(Validator().Validate(name).IsSuccess, Is.EqualTo(valid)); + + [TestCase("BlockedExact")] + [TestCase("BlockedContains")] + [TestCase("Reserved")] + public void MissingModerationSectionFailsConfiguration(string section) + { + var settings = Settings(); + settings.Remove("UsernameModeration:" + section + ":0"); + Assert.Throws(() => new UsernameValidator(new ConfigurationBuilder().AddInMemoryCollection(settings).Build())); + } +} + diff --git a/Govor.Application.Tests/Infrastructure/Validators/UsernameValidatorTests.cs b/tests/Govor.Application.Tests/Unit/Infrastructure/Validators/UsernameValidatorTests.cs similarity index 58% rename from Govor.Application.Tests/Infrastructure/Validators/UsernameValidatorTests.cs rename to tests/Govor.Application.Tests/Unit/Infrastructure/Validators/UsernameValidatorTests.cs index 2a99dd8..47bd5e7 100644 --- a/Govor.Application.Tests/Infrastructure/Validators/UsernameValidatorTests.cs +++ b/tests/Govor.Application.Tests/Unit/Infrastructure/Validators/UsernameValidatorTests.cs @@ -7,8 +7,7 @@ namespace Govor.Application.Tests.Infrastructure.Validators; [TestFixture] public class UsernameValidatorTests { - private UsernameValidator _validator; - + private UsernameValidator _validator = null!; [SetUp] public void SetUp() { @@ -35,9 +34,9 @@ public class UsernameValidatorTests [TestCase("Алексей")] [TestCase("Ёжик")] [TestCase("Иван123")] // содержит цифры - public void Validate_ValidUsernames_ShouldNotThrow(string username) + public void Validate_ValidUsernames_ReturnsSuccess(string username) { - Assert.DoesNotThrow(() => _validator.Validate(username)); + Assert.That(_validator.Validate(username).IsSuccess, Is.True); } [TestCase("Ivan")] // не кириллица @@ -46,43 +45,55 @@ public class UsernameValidatorTests [TestCase("")] // пусто [TestCase("И")] // меньше минимума [TestCase("ИванИванИванИванИванИванИванИванИванИванИванИванИван")] // больше максимума (44 символа) - public void Validate_InvalidUsernames_ShouldThrow(string username) + public void Validate_InvalidUsernames_ReturnsFailure(string username) { - Assert.Throws(() => _validator.Validate(username)); + var result = _validator.Validate(username); + Assert.That(result.IsFailure, Is.True); + Assert.That(result.Error.Type, Is.EqualTo(Govor.Domain.Common.ErrorType.Validation)); } [TestCase("Ааааааа")] [TestCase("Бbbbb")] - public void Validate_RepeatingCharacters_ShouldThrow(string username) + public void Validate_RepeatingCharacters_ReturnsFailure(string username) { - Assert.Throws(() => _validator.Validate(username)); + var result = _validator.Validate(username); + Assert.That(result.IsFailure, Is.True); + Assert.That(result.Error.Type, Is.EqualTo(Govor.Domain.Common.ErrorType.Validation)); } [TestCase("Админ")] [TestCase("Модератор")] - public void Validate_BlockedExact_ShouldThrow(string username) + public void Validate_BlockedExact_ReturnsFailure(string username) { - Assert.Throws(() => _validator.Validate(username)); + var result = _validator.Validate(username); + Assert.That(result.IsFailure, Is.True); + Assert.That(result.Error.Type, Is.EqualTo(Govor.Domain.Common.ErrorType.Validation)); } [TestCase("Гитлер123")] [TestCase("Нацист")] - public void Validate_BlockedContains_ShouldThrow(string username) + public void Validate_BlockedContains_ReturnsFailure(string username) { - Assert.Throws(() => _validator.Validate(username)); + var result = _validator.Validate(username); + Assert.That(result.IsFailure, Is.True); + Assert.That(result.Error.Type, Is.EqualTo(Govor.Domain.Common.ErrorType.Validation)); } [TestCase("Логин")] [TestCase("Регистрация")] - public void Validate_ReservedNames_ShouldThrow(string username) + public void Validate_ReservedNames_ReturnsFailure(string username) { - Assert.Throws(() => _validator.Validate(username)); + var result = _validator.Validate(username); + Assert.That(result.IsFailure, Is.True); + Assert.That(result.Error.Type, Is.EqualTo(Govor.Domain.Common.ErrorType.Validation)); } [TestCase("Г1тлер")] public void Validate_Normalization_ShouldDetectBlockedWord(string username) { - Assert.Throws(() => _validator.Validate(username)); + var result = _validator.Validate(username); + Assert.That(result.IsFailure, Is.True); + Assert.That(result.Error.Type, Is.EqualTo(Govor.Domain.Common.ErrorType.Validation)); } [TestCase("Иван", ExpectedResult = true)] @@ -93,4 +104,4 @@ public class UsernameValidatorTests { return _validator.TryValidate(username); } -} \ No newline at end of file +} diff --git a/tests/Govor.Application.Tests/Unit/PushNotifications/PushNotificationServiceTests.cs b/tests/Govor.Application.Tests/Unit/PushNotifications/PushNotificationServiceTests.cs new file mode 100644 index 0000000..50a73ad --- /dev/null +++ b/tests/Govor.Application.Tests/Unit/PushNotifications/PushNotificationServiceTests.cs @@ -0,0 +1,147 @@ +using Govor.Application.PushNotifications; +using Govor.Application.PushNotifications.Providers; +using Govor.Application.Interfaces.PushNotifications.Models; +using Govor.Domain.Common; +using Microsoft.Extensions.Logging.Abstractions; +using Moq; + +namespace Govor.Application.Tests.Unit.PushNotifications; + +[TestFixture] +public class PushNotificationServiceTests +{ + private Mock _provider = null!; + private Mock _tokens = null!; + private PushNotificationService _service = null!; + private readonly Guid _recipient = Guid.NewGuid(); + private static readonly Error Failure = Error.ServerError("Test.Failure", "unavailable"); + + [SetUp] + public void SetUp() + { + _provider = new Mock(MockBehavior.Strict); + _tokens = new Mock(MockBehavior.Strict); + _service = new(_provider.Object, _tokens.Object, NullLogger.Instance); + } + + [Test] + public async Task TokenLookupErrorsAreReturnedWithoutSending() + { + _tokens.Setup(t => t.GetStringsActiveTokensAsync(_recipient)).ReturnsAsync(Result.Failure>(Failure)); + _tokens.Setup(t => t.GetUsersStringsActiveTokensAsync(It.IsAny>())).ReturnsAsync(Result.Failure>(Failure)); + _tokens.Setup(t => t.GetActiveTokenBySessionAsync(_recipient)).ReturnsAsync(Result.Failure(Failure)); + Assert.That((await _service.SendToUserAsync(_recipient, "t", "b", "c")).Error, Is.SameAs(Failure)); + Assert.That((await _service.SendToUsersAsync(new[] { _recipient }, "t", "b", "c")).Error, Is.SameAs(Failure)); + Assert.That((await _service.SendToSessionAsync(_recipient, "t", "b", "c")).Error, Is.SameAs(Failure)); + _provider.VerifyNoOtherCalls(); + } + + [Test] + public async Task MissingTokensAreSuccessfulNoOpsForEveryDeliveryMode() + { + _tokens.Setup(t => t.GetStringsActiveTokensAsync(_recipient)).ReturnsAsync(new List()); + _tokens.Setup(t => t.GetUsersStringsActiveTokensAsync(It.IsAny>())).ReturnsAsync(new List()); + _tokens.Setup(t => t.GetActiveTokenBySessionAsync(_recipient)).ReturnsAsync((string?)null); + Assert.That((await _service.SendToUserAsync(_recipient, "t", "b", "c")).IsSuccess, Is.True); + Assert.That((await _service.SendToUsersAsync(new[] { _recipient }, "t", "b", "c")).IsSuccess, Is.True); + Assert.That((await _service.SendToSessionAsync(_recipient, "t", "b", "c")).IsSuccess, Is.True); + _provider.VerifyNoOtherCalls(); + } + + [Test] + public async Task EmptyOrNullBulkRecipientsAreRejectedBeforeTokenLookup() + { + Assert.That((await _service.SendToUsersAsync(Array.Empty(), "t", "b", "c")).Error.Code, Is.EqualTo("Push.InvalidArgs")); + Assert.That((await _service.SendToUsersAsync(null!, "t", "b", "c")).IsFailure, Is.True); + _tokens.VerifyNoOtherCalls(); + _provider.VerifyNoOtherCalls(); + } + + [Test] + public async Task SessionDeliveryPreservesPayload() + { + var data = new Dictionary { ["id"] = "message" }; + _tokens.Setup(t => t.GetActiveTokenBySessionAsync(_recipient)).ReturnsAsync("device"); + _provider.Setup(p => p.SendToTokenAsync("device", It.Is(m => m.Title == "title" && + m.Body == "body" && m.ChannelId == "channel" && m.Tag == "tag" && m.Data == data))) + .ReturnsAsync(new SendPushResult(1, 0, Array.Empty())); + Assert.That((await _service.SendToSessionAsync(_recipient, "title", "body", "channel", "tag", data)).IsSuccess, Is.True); + _provider.VerifyAll(); + } + + [Test] + public async Task SessionProviderExceptionBecomesFailureAndKeepsToken() + { + _tokens.Setup(t => t.GetActiveTokenBySessionAsync(_recipient)).ReturnsAsync("device"); + _provider.Setup(p => p.SendToTokenAsync("device", It.IsAny())).ThrowsAsync(new IOException("provider offline")); + Assert.That((await _service.SendToSessionAsync(_recipient, "t", "b", "c")).IsFailure, Is.True); + _tokens.Verify(t => t.RemoveTokensAsync(It.IsAny>()), Times.Never); + } + + [Test] + public async Task BulkRecipientsAndTokensAreDeduplicatedAndBatchingContinuesAfterFailure() + { + var tokens = Enumerable.Range(0, 501).Select(i => "device-" + i).ToList(); + tokens.Add(tokens[0]); + _tokens.Setup(t => t.GetUsersStringsActiveTokensAsync(It.Is>(ids => ids.SequenceEqual(new[] { _recipient })))) + .ReturnsAsync(tokens); + var batches = new List(); + _provider.Setup(p => p.SendMulticastAsync(It.IsAny>(), It.IsAny())) + .Returns((IReadOnlyList batch, PushMessage message) => + { + batches.Add(batch.Count); + Assert.That(message.Data, Is.Empty); + return batches.Count == 1 ? Task.FromException(new IOException("offline")) : + Task.FromResult(new SendPushResult(batch.Count, 0, Array.Empty())); + }); + var result = await _service.SendToUsersAsync(new[] { _recipient, _recipient }, "t", "b", "c"); + Assert.That(result.Error.Code, Is.EqualTo("Push.DeliveryFailed")); + Assert.That(batches, Is.EqualTo(new[] { 500, 1 })); + _tokens.Verify(t => t.RemoveTokensAsync(It.IsAny>()), Times.Never); + } + + [Test] + public async Task OnlyUnregisteredTokensFromThisBatchCanBeRemoved() + { + _tokens.Setup(t => t.GetStringsActiveTokensAsync(_recipient)).ReturnsAsync(new List { "valid", "gone" }); + _provider.Setup(p => p.SendMulticastAsync(It.IsAny>(), It.IsAny())) + .ReturnsAsync(new SendPushResult(1, 1, new[] { "gone", "gone", "unrelated" })); + _tokens.Setup(t => t.RemoveTokensAsync(It.Is>(ts => ts.SequenceEqual(new[] { "gone" })))) + .ReturnsAsync(Result.Success()); + Assert.That((await _service.SendToUserAsync(_recipient, "t", "b", "c")).IsSuccess, Is.True); + _tokens.VerifyAll(); + } + + [Test] + public async Task TokenRemovalFailureIsPropagated() + { + _tokens.Setup(t => t.GetActiveTokenBySessionAsync(_recipient)).ReturnsAsync("gone"); + _provider.Setup(p => p.SendToTokenAsync("gone", It.IsAny())).ReturnsAsync(new SendPushResult(0, 1, new[] { "gone" })); + _tokens.Setup(t => t.RemoveTokensAsync(It.IsAny>())).ReturnsAsync(Result.Failure(Failure)); + Assert.That((await _service.SendToSessionAsync(_recipient, "t", "b", "c")).Error, Is.SameAs(Failure)); + } + + [TestCase(0, 0)] + [TestCase(0, 1)] + [TestCase(2, 0)] + public async Task IncompleteOrInconsistentProviderCountsAreFailures(int success, int failed) + { + _tokens.Setup(t => t.GetActiveTokenBySessionAsync(_recipient)).ReturnsAsync("device"); + _provider.Setup(p => p.SendToTokenAsync("device", It.IsAny())) + .ReturnsAsync(new SendPushResult(success, failed, Array.Empty())); + Assert.That((await _service.SendToSessionAsync(_recipient, "t", "b", "c")).Error.Code, Is.EqualTo("Push.DeliveryFailed")); + } + + [Test] + public async Task NullProviderAcceptsSingleAndMulticastWithoutNetwork() + { + var provider = new NullPushProvider(); + Assert.That(provider.Name, Is.EqualTo("NULL")); + Assert.That((await provider.SendToTokenAsync("device", new PushMessage())).SuccessCount, Is.EqualTo(1)); + var result = await provider.SendMulticastAsync(new[] { "a", "b" }, new PushMessage()); + Assert.That(result.SuccessCount, Is.EqualTo(2)); + Assert.That(result.FailureCount, Is.Zero); + Assert.That(result.FailedTokens, Is.Empty); + } +} + diff --git a/tests/Govor.Application.Tests/Unit/Security/E2eeProtocolBoundaryTests.cs b/tests/Govor.Application.Tests/Unit/Security/E2eeProtocolBoundaryTests.cs new file mode 100644 index 0000000..8c9aefa --- /dev/null +++ b/tests/Govor.Application.Tests/Unit/Security/E2eeProtocolBoundaryTests.cs @@ -0,0 +1,187 @@ +using System.Security.Cryptography; +using System.Text; +using System.Text.Json; +using System.Text.Json.Nodes; +using Govor.Application.E2ee; +using Jose; + +namespace Govor.Application.Tests.Unit.Security; + +[TestFixture] +public class E2eeProtocolBoundaryTests +{ + private DevicePrivateKeys _keys = null!; + private DeviceKey _device = null!; + private ConversationKeys _conversation = null!; + private Guid _message; + [OneTimeSetUp] + public void SetUp() + { + _keys = E2eeProtocol.GenerateKeys(); + _device = E2eeProtocol.PublicKey(_keys, Guid.NewGuid(), Guid.NewGuid()); + _conversation = new(Guid.NewGuid(), 0, new[] { _device.UserId }, new[] { _device }); + _message = Guid.NewGuid(); + } + + private string Encrypt() => E2eeProtocol.Encrypt(new("secret", []), _keys, _device, _conversation, _message); + private string Sign(EncryptedMessage envelope) + { + using var signing = ECDsa.Create(); + signing.ImportPkcs8PrivateKey(Convert.FromBase64String(_keys.IdentityKey), out _); + return E2eeProtocol.Prefix + JWT.Encode(JsonSerializer.Serialize(envelope), signing, JwsAlgorithm.ES256); + } + + [TestCase("plaintext")] + [TestCase("too-large")] + [TestCase("segments")] + [TestCase("null-json")] + public void InspectRejectsInvalidEnvelopeBeforeTrustingPayload(string reason) + { + var input = reason switch { + "plaintext" => "secret", + "too-large" => E2eeProtocol.Prefix + new string('x', E2eeProtocol.MaxEnvelopeLength), + "segments" => E2eeProtocol.Prefix + "only.two", + _ => E2eeProtocol.Prefix + "header." + Base64Url.Encode("null"u8.ToArray()) + ".signature" + }; + Assert.Throws(() => E2eeProtocol.Inspect(input)); + } + + [TestCase("version")] + [TestCase("sender")] + [TestCase("message")] + [TestCase("conversation")] + [TestCase("type")] + [TestCase("recipients")] + [TestCase("media")] + [TestCase("ciphertext")] + public void InspectRejectsInvalidRoutingFields(string field) + { + var envelope = E2eeProtocol.Inspect(Encrypt()); + envelope = field switch { + "version" => envelope with { Version = 2 }, + "sender" => envelope with { Sender = null! }, + "message" => envelope with { MessageId = Guid.Empty }, + "conversation" => envelope with { ConversationId = Guid.Empty }, + "type" => envelope with { RecipientType = 2 }, + "recipients" => envelope with { Recipients = [] }, + "media" => envelope with { MediaIds = null! }, + _ => envelope with { Ciphertext = "" } + }; + Assert.Throws(() => E2eeProtocol.Inspect(Sign(envelope))); + } + + [TestCase("empty-message")] + [TestCase("empty-content")] + [TestCase("long-text")] + [TestCase("null-attachments")] + [TestCase("many-attachments")] + [TestCase("no-devices")] + [TestCase("many-devices")] + public void EncryptEnforcesContentAndRecipientLimits(string reason) + { + var plaintext = reason switch { + "empty-content" => new MessagePlaintext(" ", []), + "long-text" => new MessagePlaintext(new string('x', 20_001), []), + "null-attachments" => new MessagePlaintext("secret", null!), + "many-attachments" => new MessagePlaintext("secret", Enumerable.Range(0, 101) + .Select(_ => new AttachmentSecret(Guid.NewGuid(), "key", "file", "type")).ToArray()), + _ => new MessagePlaintext("secret", []) + }; + var directory = reason == "no-devices" ? _conversation with { Devices = [] } : + reason == "many-devices" ? _conversation with { Devices = Enumerable.Repeat(_device, 501).ToArray() } : _conversation; + Assert.Throws(() => E2eeProtocol.Encrypt(plaintext, _keys, _device, directory, + reason == "empty-message" ? Guid.Empty : _message)); + } + + [TestCase("unprotected")] + [TestCase("aad")] + [TestCase("compression")] + [TestCase("encryption")] + [TestCase("manifest")] + [TestCase("algorithm")] + public void ValidSignatureDoesNotAuthorizeUnsupportedEncryptionHeaders(string reason) + { + var envelope = E2eeProtocol.Inspect(Encrypt()); + var jwe = JsonNode.Parse(envelope.Ciphertext)!; + if (reason is "unprotected" or "aad") jwe[reason] = reason == "aad" ? JsonValue.Create("value") : new JsonObject(); + if (reason is "compression" or "encryption") + { + var header = JsonNode.Parse(Base64Url.Decode(jwe["protected"]!.GetValue()))!; + if (reason == "compression") header["zip"] = "DEF"; else header["enc"] = "A128GCM"; + jwe["protected"] = Base64Url.Encode(Encoding.UTF8.GetBytes(header.ToJsonString())); + } + if (reason == "algorithm") + { + var recipient = jwe["recipients"] is JsonArray recipients ? recipients[0]! : jwe; + recipient["header"]!["alg"] = "RSA1_5"; + } + if (reason == "manifest") envelope = envelope with { Recipients = new[] { "wrong-fingerprint" } }; + var signed = Sign(envelope with { Ciphertext = jwe.ToJsonString() }); + Assert.Throws(() => E2eeProtocol.Verify(signed)); + } + + [Test] + public void RecipientTypeAndEditContextAreAuthenticated() + { + var encrypted = Encrypt(); + Assert.Throws(() => E2eeProtocol.Decrypt(encrypted, _keys, _message, + _conversation.ConversationId, 1, _device.UserId)); + Assert.Throws(() => E2eeProtocol.Decrypt(encrypted, _keys, _message, + _conversation.ConversationId, 0, _device.UserId, expectedEdit: true)); + } + + [TestCase("identity")] + [TestCase("encryption")] + [TestCase("trailing-identity")] + [TestCase("trailing-encryption")] + [TestCase("empty-user")] + [TestCase("empty-session")] + public void InvalidDevicePublicKeysAreRejected(string reason) + { + var bad = reason switch { + "identity" => _device with { IdentityKey = "AAAA" }, + "encryption" => _device with { EncryptionKey = "AAAA" }, + "trailing-identity" => _device with { IdentityKey = Convert.ToBase64String(Convert.FromBase64String(_device.IdentityKey).Concat(new byte[] { 1 }).ToArray()) }, + "trailing-encryption" => _device with { EncryptionKey = Convert.ToBase64String(Convert.FromBase64String(_device.EncryptionKey).Concat(new byte[] { 1 }).ToArray()) }, + "empty-user" => _device with { UserId = Guid.Empty }, + _ => _device with { SessionId = Guid.Empty } + }; + Assert.Throws(() => E2eeProtocol.ValidatePublicKey(bad)); + } + + [Test] + public void InvalidPrivateKeysDoNotProducePublicKeys() + { + Assert.Throws(() => E2eeProtocol.PublicKey(_keys with { IdentityKey = "AAAA" }, _device.UserId, _device.SessionId)); + Assert.Throws(() => E2eeProtocol.PublicKey(_keys with { EncryptionKey = "AAAA" }, _device.UserId, _device.SessionId)); + } + + [TestCase("short")] + [TestCase("large")] + [TestCase("key")] + public void AttachmentsEnforceCiphertextSizeAndKeyLength(string reason) + { + if (reason == "large") Assert.Throws(() => E2eeProtocol.EncryptAttachment(new byte[19_000_001])); + else if (reason == "short") Assert.Throws(() => E2eeProtocol.DecryptAttachment(new byte[27], Convert.ToBase64String(new byte[32]))); + else + { + var (encrypted, _) = E2eeProtocol.EncryptAttachment(new byte[] { 1 }); + Assert.Throws(() => E2eeProtocol.DecryptAttachment(encrypted, Convert.ToBase64String(new byte[16]))); + } + } + + [TestCase("null")] + [TestCase("{\"Text\":null,\"Attachments\":[]}")] + [TestCase("{\"Text\":\"secret\",\"Attachments\":[{\"MediaId\":\"11111111-1111-1111-1111-111111111111\"}]}")] + public void DecryptionRejectsMalformedPlaintextOrAttachmentManifest(string plaintext) + { + using var rsa = RSA.Create(); + rsa.ImportSubjectPublicKeyInfo(Convert.FromBase64String(_device.EncryptionKey), out _); + var ciphertext = JWE.Encrypt(plaintext, new[] { new JweRecipient(JweAlgorithm.RSA_OAEP_256, rsa, + new Dictionary { ["kid"] = _device.Fingerprint }) }, JweEncryption.A256GCM); + var envelope = E2eeProtocol.Inspect(Encrypt()) with { Ciphertext = ciphertext }; + Assert.Throws(() => E2eeProtocol.Decrypt(Sign(envelope), _keys, _message, + _conversation.ConversationId, 0, _device.UserId)); + } +} + diff --git a/tests/Govor.Application.Tests/Unit/Storage/LocalStorageBoundaryTests.cs b/tests/Govor.Application.Tests/Unit/Storage/LocalStorageBoundaryTests.cs new file mode 100644 index 0000000..5515700 --- /dev/null +++ b/tests/Govor.Application.Tests/Unit/Storage/LocalStorageBoundaryTests.cs @@ -0,0 +1,78 @@ +namespace Govor.Application.Tests.Unit.Storage; + +[TestFixture] +public class LocalStorageBoundaryTests +{ + private string _root = null!; + private LocalStorageService _service = null!; + [SetUp] + public void SetUp() + { + _root = Path.Combine(Path.GetTempPath(), "govor-storage-tests-" + Guid.NewGuid().ToString("N")); + Directory.CreateDirectory(_root); + _service = new(_root); + } + [TearDown] + public void TearDown() + { + var resolved = Path.GetFullPath(_root); + if (!resolved.StartsWith(Path.GetFullPath(Path.GetTempPath()), StringComparison.OrdinalIgnoreCase) || + !Path.GetFileName(resolved).StartsWith("govor-storage-tests-", StringComparison.Ordinal)) + throw new InvalidOperationException("Unexpected temporary storage path."); + Directory.Delete(resolved, recursive: true); + } + + [TestCase("../uploads-sibling/secret.bin")] + [TestCase("../outside.bin")] + public async Task TraversalCannotReadOrDeleteFilesOutsideUploadRoot(string relative) + { + var target = Path.GetFullPath(Path.Combine(_root, "uploads", relative)); + Directory.CreateDirectory(Path.GetDirectoryName(target)!); + await File.WriteAllTextAsync(target, "secret"); + Assert.ThrowsAsync(() => _service.LoadAsync(relative)); + Assert.ThrowsAsync(() => _service.RemoveAsync(relative)); + Assert.That(await File.ReadAllTextAsync(target), Is.EqualTo("secret")); + } + + [Test] + public async Task AbsolutePathsAreRejectedEvenInsideStorage() + { + var absolute = Path.Combine(_root, "uploads", "absolute.bin"); + await File.WriteAllTextAsync(absolute, "secret"); + Assert.ThrowsAsync(() => _service.LoadAsync(absolute)); + Assert.ThrowsAsync(() => _service.RemoveAsync(absolute)); + Assert.That(File.Exists(absolute), Is.True); + } + + [Test] + public async Task ReadOnlyFileCanBeDeletedAndRepeatedDeleteIsANoOp() + { + var path = await _service.SaveAsync(new byte[] { 1, 2 }, "../file.bin"); + var fullPath = Path.Combine(_root, "uploads", path); + File.SetAttributes(fullPath, File.GetAttributes(fullPath) | FileAttributes.ReadOnly); + await _service.RemoveAsync(path); + await _service.RemoveAsync(path); + Assert.That(File.Exists(fullPath), Is.False); + } + + [TestCase("")] + [TestCase(" ")] + [TestCase(null)] + public void InvalidPathsAreRejected(string? path) + { + Assert.ThrowsAsync(() => _service.LoadAsync(path!)); + Assert.ThrowsAsync(() => _service.RemoveAsync(path!)); + } + + [Test] + public async Task ReusingExistingRootIsSafeAndMissingLoadIsReported() + { + _service = new(_root); + Assert.ThrowsAsync(() => _service.LoadAsync("missing.bin")); + var relative = await _service.SaveAsync(new byte[] { 3, 4 }, "same.bin"); + await using var stream = await _service.LoadAsync(relative); + Assert.That(stream.CanRead, Is.True); + Assert.That(stream.Length, Is.EqualTo(2)); + } +} + diff --git a/Govor.API.Tests/LocalStorageServiceTests.cs b/tests/Govor.Application.Tests/Unit/Storage/LocalStorageServiceTests.cs similarity index 95% rename from Govor.API.Tests/LocalStorageServiceTests.cs rename to tests/Govor.Application.Tests/Unit/Storage/LocalStorageServiceTests.cs index f6be86e..f50a2cc 100644 --- a/Govor.API.Tests/LocalStorageServiceTests.cs +++ b/tests/Govor.Application.Tests/Unit/Storage/LocalStorageServiceTests.cs @@ -1,5 +1,4 @@ using AutoFixture; -using Govor.Application.Interfaces; using Microsoft.AspNetCore.Hosting; using Moq; @@ -8,11 +7,10 @@ namespace Govor.Application.Tests.Services; [TestFixture] public class LocalStorageServiceTests { - private Fixture _fixture; - private IStorageService _service; - private Mock _webHostEnvironmentMock; - private string _tempDirectory; - + private Fixture _fixture = null!; + private IStorageService _service = null!; + private Mock _webHostEnvironmentMock = null!; + private string _tempDirectory = null!; [SetUp] public void SetUp() { @@ -136,4 +134,4 @@ public class LocalStorageServiceTests // Act & Assert Assert.DoesNotThrowAsync(async () => await _service.RemoveAsync(_fixture.Create()+".txt")); } -} \ No newline at end of file +} diff --git a/Govor.Application.Tests/Services/SynchingServiceTests.cs b/tests/Govor.Application.Tests/Unit/Synching/SynchingServiceTests.cs similarity index 99% rename from Govor.Application.Tests/Services/SynchingServiceTests.cs rename to tests/Govor.Application.Tests/Unit/Synching/SynchingServiceTests.cs index 31f68b5..a6a1d6d 100644 --- a/Govor.Application.Tests/Services/SynchingServiceTests.cs +++ b/tests/Govor.Application.Tests/Unit/Synching/SynchingServiceTests.cs @@ -102,4 +102,4 @@ public class SynchingServiceTests // Assert Assert.That(result, Is.EqualTo(input)); } -} \ No newline at end of file +} diff --git a/tests/Govor.Application.Tests/Unit/Users/OnlineUserStoreTests.cs b/tests/Govor.Application.Tests/Unit/Users/OnlineUserStoreTests.cs new file mode 100644 index 0000000..1f41acb --- /dev/null +++ b/tests/Govor.Application.Tests/Unit/Users/OnlineUserStoreTests.cs @@ -0,0 +1,43 @@ +using Govor.Application.Users.UserOnlineStatus; + +namespace Govor.Application.Tests.Users; + +[TestFixture] +public class OnlineUserStoreTests +{ + [Test] + public void UserRemainsOnlineUntilLastConnectionLeaves() + { + var store = new OnlineUserStore(); + var user = Guid.NewGuid(); + Assert.That(store.IsOnline(user), Is.False); + Assert.That(store.AddConnection(user, "phone"), Is.True); + Assert.That(store.AddConnection(user, "desktop"), Is.False); + Assert.That(store.AddConnection(user, "phone"), Is.False); + Assert.That(store.GetConnections(user), Is.EquivalentTo(new[] { "phone", "desktop" })); + Assert.That(store.GetAllOnlineUsers(), Is.EqualTo(new[] { user })); + Assert.That(store.RemoveConnection(user, "phone"), Is.False); + Assert.That(store.IsOnline(user), Is.True); + Assert.That(store.RemoveConnection(user, "desktop"), Is.True); + Assert.That(store.IsOnline(user), Is.False); + Assert.That(store.GetAllOnlineUsers(), Is.Empty); + Assert.That(store.GetConnections(user), Is.Empty); + } + + [Test] + public void ConnectionSnapshotsAndOtherUsersAreIndependent() + { + var store = new OnlineUserStore(); + var alice = Guid.NewGuid(); + var bob = Guid.NewGuid(); + store.AddConnection(alice, "alice"); + var snapshot = store.GetConnections(alice); + store.AddConnection(alice, "second"); + store.AddConnection(bob, "bob"); + store.RemoveConnection(alice, "alice"); + store.RemoveConnection(alice, "second"); + Assert.That(snapshot, Is.EqualTo(new[] { "alice" })); + Assert.That(store.IsOnline(bob), Is.True); + Assert.That(store.RemoveConnection(Guid.NewGuid(), "unknown"), Is.False); + } +} diff --git a/Govor.Application.Tests/Services/UserOnlineStatus/UserNotificationScopeServiceTests.cs b/tests/Govor.Application.Tests/Unit/Users/UserNotificationScopeServiceTests.cs similarity index 75% rename from Govor.Application.Tests/Services/UserOnlineStatus/UserNotificationScopeServiceTests.cs rename to tests/Govor.Application.Tests/Unit/Users/UserNotificationScopeServiceTests.cs index d031e73..fcdb57f 100644 --- a/Govor.Application.Tests/Services/UserOnlineStatus/UserNotificationScopeServiceTests.cs +++ b/tests/Govor.Application.Tests/Unit/Users/UserNotificationScopeServiceTests.cs @@ -1,10 +1,6 @@ using AutoFixture; -using Govor.Application.Interfaces.Friends; -using Govor.Application.Interfaces.UserOnlineStatus; -using Govor.Application.Services.UserOnlineStatus; using Govor.Domain.Models; using Govor.Domain.Models.Users; -using Govor.Data.Repositories.Exceptions; using Microsoft.Extensions.Logging; using Moq; @@ -14,13 +10,11 @@ namespace Govor.Application.Tests.Services.UserOnlineStatus; [TestOf(typeof(UserNotificationScopeService))] public class UserNotificationScopeServiceTests { - private Mock> _mockLogger; - private Mock _mockFriendshipService; - private IUserNotificationScopeService _service; - private Fixture _fixture; + private Mock> _mockLogger = null!; + private Mock _mockFriendshipService = null!; + private IUserNotificationScopeService _service = null!; + private Fixture _fixture = null!; private Guid _userId; - - [SetUp] public void SetUp() { @@ -55,14 +49,14 @@ public class UserNotificationScopeServiceTests } [Test] - public async Task GetNotifiedUsers_ThrowsInvalidOperationException_WhenUserDoesNotExist() + public async Task GetNotifiedUsers_PropagatesFriendshipServiceFailure() { // Arrange _mockFriendshipService.Setup(f => f.GetFriendsAsync(_userId)) - .ThrowsAsync(new NotFoundByKeyException(_userId, "Database is empty.")); + .ThrowsAsync(new InvalidOperationException("Database is empty.")); // Act & Assert var ex = Assert.ThrowsAsync(async () => await _service.GetNotifiedUsers(_userId)); - Assert.That(ex.Message, Is.EqualTo("User not found")); + Assert.That(ex.Message, Is.EqualTo("Database is empty.")); } } diff --git a/tests/Govor.Domain.Tests/GlobalUsings.cs b/tests/Govor.Domain.Tests/GlobalUsings.cs new file mode 100644 index 0000000..51bce71 --- /dev/null +++ b/tests/Govor.Domain.Tests/GlobalUsings.cs @@ -0,0 +1 @@ +global using Govor.Domain; diff --git a/tests/Govor.Domain.Tests/Govor.Domain.Tests.csproj b/tests/Govor.Domain.Tests/Govor.Domain.Tests.csproj new file mode 100644 index 0000000..c6922a4 --- /dev/null +++ b/tests/Govor.Domain.Tests/Govor.Domain.Tests.csproj @@ -0,0 +1,5 @@ + + + + + diff --git a/Govor.Server.Tests/GroupMigrationTests.cs b/tests/Govor.Domain.Tests/Migrations/GroupMigrationTests.cs similarity index 98% rename from Govor.Server.Tests/GroupMigrationTests.cs rename to tests/Govor.Domain.Tests/Migrations/GroupMigrationTests.cs index 5d95ee1..95635f8 100644 --- a/Govor.Server.Tests/GroupMigrationTests.cs +++ b/tests/Govor.Domain.Tests/Migrations/GroupMigrationTests.cs @@ -2,7 +2,7 @@ using Govor.Domain.Migrations; using Microsoft.Data.Sqlite; using Microsoft.EntityFrameworkCore.Migrations.Operations; -namespace Govor.Server.Tests; +namespace Govor.Domain.Tests.Migrations; [TestFixture] public class GroupMigrationTests diff --git a/tests/Govor.Domain.Tests/Persistence/DatabaseConstraintTests.cs b/tests/Govor.Domain.Tests/Persistence/DatabaseConstraintTests.cs new file mode 100644 index 0000000..905f281 --- /dev/null +++ b/tests/Govor.Domain.Tests/Persistence/DatabaseConstraintTests.cs @@ -0,0 +1,89 @@ +using Govor.Domain.Models; +using Govor.Domain.Models.Messages; +using Govor.Domain.Models.Users; +using Microsoft.EntityFrameworkCore; + +namespace Govor.Domain.Tests.Persistence; + +[TestFixture] +public class DatabaseConstraintTests +{ + private TestDatabase _db = null!; + [SetUp] public void SetUp() => _db = new TestDatabase(); + [TearDown] public void TearDown() => _db.Dispose(); + + [Test] + public async Task UsernamesAreUnique() + { + var user = await _db.Context.Users.FirstAsync(); + _db.Context.Users.Add(new User { Id = Guid.NewGuid(), Username = user.Username, + PasswordHash = "test", InviteId = user.InviteId, Description = "" }); + Assert.ThrowsAsync(() => _db.Context.SaveChangesAsync()); + } + + [Test] + public async Task RefreshTokenHashesAreUnique() + { + _db.Context.UserSessions.AddRange( + new UserSession { UserId = _db.Alice, RefreshTokenHash = "duplicate" }, + new UserSession { UserId = _db.Bob, RefreshTokenHash = "duplicate" }); + Assert.ThrowsAsync(() => _db.Context.SaveChangesAsync()); + } + + [Test] + public void SessionRequiresExistingUser() + { + _db.Context.UserSessions.Add(new UserSession { UserId = Guid.NewGuid(), RefreshTokenHash = "test" }); + Assert.ThrowsAsync(() => _db.Context.SaveChangesAsync()); + } + + [Test] + public async Task ReadReceiptsAreUniquePerUserAndMessage() + { + var message = _db.AddMessage(); + _db.Context.MessageViews.AddRange( + new MessageView { Id = Guid.NewGuid(), UserId = _db.Bob, MessageId = message.Id, ViewedAt = DateTime.UtcNow }, + new MessageView { Id = Guid.NewGuid(), UserId = _db.Bob, MessageId = message.Id, ViewedAt = DateTime.UtcNow }); + Assert.ThrowsAsync(() => _db.Context.SaveChangesAsync()); + } + + [Test] + public async Task RemovingMessageCascadesReceiptsReactionsAndAttachments() + { + var message = _db.AddMessage(); + var media = new MediaFile { Id = Guid.NewGuid(), UploaderId = _db.Alice, Url = "test.bin", MineType = "application/octet-stream" }; + _db.Context.MediaFiles.Add(media); + _db.Context.MediaAttachments.Add(new MediaAttachments { Id = Guid.NewGuid(), MessageId = message.Id, MediaFileId = media.Id }); + _db.Context.MessageViews.Add(new MessageView { Id = Guid.NewGuid(), MessageId = message.Id, UserId = _db.Bob, ViewedAt = DateTime.UtcNow }); + _db.Context.MessageReactions.Add(new MessageReaction { Id = Guid.NewGuid(), MessageId = message.Id, UserId = _db.Bob, ReactionCode = "like", ReactedAt = DateTime.UtcNow }); + await _db.Context.SaveChangesAsync(); + _db.Context.ChangeTracker.Clear(); + await _db.Context.Messages.Where(m => m.Id == message.Id).ExecuteDeleteAsync(); + Assert.That(await _db.Context.MediaAttachments.CountAsync(), Is.Zero); + Assert.That(await _db.Context.MessageViews.CountAsync(), Is.Zero); + Assert.That(await _db.Context.MessageReactions.CountAsync(), Is.Zero); + Assert.That(await _db.Context.MediaFiles.AnyAsync(m => m.Id == media.Id), Is.True); + } + + [Test] + public async Task GroupMembershipIsUniquePerUserAndGroup() + { + var group = new ChatGroup { Id = Guid.NewGuid(), Name = "group", Description = "" }; + _db.Context.ChatGroups.Add(group); + await _db.Context.SaveChangesAsync(); + _db.Context.GroupMemberships.AddRange( + new GroupMembership { Id = Guid.NewGuid(), GroupId = group.Id, UserId = _db.Alice }, + new GroupMembership { Id = Guid.NewGuid(), GroupId = group.Id, UserId = _db.Alice }); + Assert.ThrowsAsync(() => _db.Context.SaveChangesAsync()); + } + + [Test] + public async Task RemovingUserCascadesSessions() + { + _db.Context.UserSessions.Add(new UserSession { UserId = _db.Outsider, RefreshTokenHash = "test" }); + await _db.Context.SaveChangesAsync(); + _db.Context.ChangeTracker.Clear(); + await _db.Context.Users.Where(u => u.Id == _db.Outsider).ExecuteDeleteAsync(); + Assert.That(await _db.Context.UserSessions.CountAsync(), Is.Zero); + } +} diff --git a/tests/Govor.Server.Tests/Api/AdditionalApiTests.cs b/tests/Govor.Server.Tests/Api/AdditionalApiTests.cs new file mode 100644 index 0000000..88cf311 --- /dev/null +++ b/tests/Govor.Server.Tests/Api/AdditionalApiTests.cs @@ -0,0 +1,94 @@ +using System.Net; +using System.Net.Http.Json; +using System.Text.Json; +using Govor.Application.E2ee; +using Govor.Contracts.DTOs; +using Govor.Contracts.Responses; +using Microsoft.EntityFrameworkCore; + +namespace Govor.Server.Tests; + +public partial class ReadApiTests +{ + [Test] + public async Task HealthAndSwaggerEndpointsExposeExpectedContracts() + { + Assert.That((await _client.GetAsync("/server/ping")).StatusCode, Is.EqualTo(HttpStatusCode.OK)); + Assert.That(await _client.GetStringAsync("/"), Is.EqualTo("Not for browsers")); + var ready = await _client.GetAsync("/server/ready"); + Assert.That(ready.StatusCode, Is.EqualTo(_db.Connection is Npgsql.NpgsqlConnection + ? HttpStatusCode.OK : HttpStatusCode.ServiceUnavailable)); + var swagger = await _client.GetAsync("/swagger/v1/swagger.json"); + Assert.That(swagger.StatusCode, Is.EqualTo(HttpStatusCode.OK)); + using var document = JsonDocument.Parse(await swagger.Content.ReadAsStringAsync()); + Assert.That(document.RootElement.GetProperty("paths").TryGetProperty("/api/e2ee/device", out _), Is.True); + Assert.That(document.RootElement.GetProperty("components").GetProperty("securitySchemes") + .GetProperty("Bearer").GetProperty("scheme").GetString(), Is.EqualTo("bearer")); + } + + [Test] + public async Task AdminHttpRoutesRequireRoleAndReturnPersistedUserAndInvitationData() + { + Assert.That((await _client.GetAsync("/api/admin/Users/all")).StatusCode,Is.EqualTo(HttpStatusCode.Unauthorized)); + Authorize(role:"Admin"); + var list=await _client.GetAsync("/api/admin/Users/all");Assert.That(list.StatusCode,Is.EqualTo(HttpStatusCode.OK)); + using var users=JsonDocument.Parse(await list.Content.ReadAsStringAsync());Assert.That(users.RootElement.GetArrayLength(),Is.EqualTo(3)); + Assert.That((await _client.GetAsync($"/api/admin/Users/{_db.Alice}")).StatusCode,Is.EqualTo(HttpStatusCode.OK)); + Assert.That((await _client.GetAsync($"/api/admin/Users/{Guid.NewGuid()}")).StatusCode,Is.EqualTo(HttpStatusCode.NotFound)); + var before=(await _db.Context.Users.AsNoTracking().SingleAsync(x=>x.Id==_db.Alice)).PasswordHash; + Assert.That((await _client.PostAsJsonAsync($"/api/admin/Users/user/{_db.Alice}/password",new{password="new-password-123"})).StatusCode,Is.EqualTo(HttpStatusCode.NoContent)); + Assert.That((await _db.Context.Users.AsNoTracking().SingleAsync(x=>x.Id==_db.Alice)).PasswordHash,Is.Not.EqualTo(before)); + var created=await _client.PostAsJsonAsync("/api/admin/InviteUser/Invitation",new{endDate=DateTime.UtcNow.AddDays(2),maxParticipants=5,isAdmin=false,description="http invitation"}); + Assert.That(created.StatusCode,Is.EqualTo(HttpStatusCode.OK)); + var invitation=await _db.Context.Invitations.AsNoTracking().SingleAsync(x=>x.Description=="http invitation"); + foreach(var path in new[]{"/api/admin/InviteUser","/api/admin/InviteUser/GetAllActiveInvitations",$"/api/admin/InviteUser/{invitation.Id}"}) + Assert.That((await _client.GetAsync(path)).StatusCode,Is.EqualTo(HttpStatusCode.OK)); + Assert.That((await _client.GetAsync($"/api/admin/InviteUser/{Guid.NewGuid()}")).StatusCode,Is.EqualTo(HttpStatusCode.NotFound)); + Authorize(); + Assert.That((await _client.PostAsJsonAsync("/api/admin/InviteUser/Invitation",new{endDate=DateTime.UtcNow.AddDays(2),maxParticipants=5})).StatusCode,Is.EqualTo(HttpStatusCode.Forbidden)); + } + + [Test] + public async Task ReactionPackHttpCrudAndSubscriptionsUseRealMappings() + { + Authorize(role:"Admin");ReactionTests.MakeAdmin(_db.Context,_db.Bob); + var created=await _client.PostAsJsonAsync("/api/admin/reaction-packs",new{name="http pack",description="original"}); + Assert.That(created.StatusCode,Is.EqualTo(HttpStatusCode.OK));var pack=(await created.Content.ReadFromJsonAsync())!; + Assert.That((await _client.PutAsJsonAsync($"/api/admin/reaction-packs/{pack.Id}",new{name="updated",description="changed",isEnabled=true})).StatusCode,Is.EqualTo(HttpStatusCode.OK)); + var emoji=await _client.PostAsJsonAsync($"/api/admin/reaction-packs/{pack.Id}/reactions/emoji",new{name="wave",emoji="👋"}); + Assert.That(emoji.StatusCode,Is.EqualTo(HttpStatusCode.OK));var item=(await emoji.Content.ReadFromJsonAsync())!; + foreach(var path in new[]{"/api/reaction-packs",$"/api/reaction-packs/{pack.Id}",$"/api/reaction-packs/shared/{pack.ShareCode}",$"/api/reactions/{item.Id}","/api/reaction-packs/limits",$"/api/admin/reaction-packs/{pack.Id}"}) + Assert.That((await _client.GetAsync(path)).StatusCode,Is.EqualTo(HttpStatusCode.OK),path); + Assert.That((await _client.PutAsync($"/api/reaction-packs/{pack.Id}/subscription",null)).StatusCode,Is.EqualTo(HttpStatusCode.NoContent)); + Assert.That((await _client.DeleteAsync($"/api/reaction-packs/{pack.Id}/subscription")).StatusCode,Is.EqualTo(HttpStatusCode.NoContent)); + Assert.That((await _client.DeleteAsync($"/api/admin/reaction-packs/{pack.Id}/reactions/{item.Id}")).StatusCode,Is.EqualTo(HttpStatusCode.NoContent)); + Assert.That((await _client.DeleteAsync($"/api/admin/reaction-packs/{pack.Id}")).StatusCode,Is.EqualTo(HttpStatusCode.NoContent)); + Assert.That((await _client.GetAsync($"/api/reaction-packs/{pack.Id}")).StatusCode,Is.EqualTo(HttpStatusCode.NotFound)); + Assert.That((await _client.GetAsync($"/api/admin/reaction-packs/{pack.Id}")).StatusCode,Is.EqualTo(HttpStatusCode.OK)); + } + + [Test] + public async Task E2eeHttpRegistrationIsIdempotentAndImmutableAndDirectoryChecksAccess() + { + Authorize(); + var privateKeys=E2eeProtocol.GenerateKeys();var key=E2eeProtocol.PublicKey(privateKeys,_db.Bob,_session); + Assert.That((await _client.PutAsJsonAsync("/api/e2ee/device",key)).StatusCode,Is.EqualTo(HttpStatusCode.OK)); + Assert.That((await _client.PutAsJsonAsync("/api/e2ee/device",key)).StatusCode,Is.EqualTo(HttpStatusCode.OK)); + var replacement=E2eeProtocol.PublicKey(E2eeProtocol.GenerateKeys(),_db.Bob,_session); + Assert.That((await _client.PutAsJsonAsync("/api/e2ee/device",replacement)).StatusCode,Is.EqualTo(HttpStatusCode.Conflict)); + Assert.That((await _client.PutAsJsonAsync("/api/e2ee/device",key with{UserId=_db.Alice})).StatusCode,Is.EqualTo(HttpStatusCode.Forbidden)); + Assert.That((await _client.PutAsJsonAsync("/api/e2ee/device",key with{IdentityKey="invalid"})).StatusCode,Is.EqualTo(HttpStatusCode.BadRequest)); + Assert.That((await _client.GetAsync($"/api/e2ee/conversations/0/{_db.ChatId}/keys")).StatusCode,Is.EqualTo(HttpStatusCode.Conflict)); + Assert.That((await _client.GetAsync($"/api/e2ee/conversations/0/{Guid.NewGuid()}/keys")).StatusCode,Is.EqualTo(HttpStatusCode.Forbidden)); + foreach(var path in new[]{$"/api/e2ee/conversations/2/{_db.ChatId}/keys",$"/api/e2ee/conversations/0/{Guid.Empty}/keys"}) + Assert.That((await _client.GetAsync(path)).StatusCode,Is.EqualTo(HttpStatusCode.BadRequest)); + var aliceSession=new Govor.Domain.Models.Users.UserSession{UserId=_db.Alice,RefreshTokenHash="alice-e2ee",ExpiresAt=DateTime.UtcNow.AddDays(1)}; + _db.Context.UserSessions.Add(aliceSession);await _db.Context.SaveChangesAsync(); + var aliceKey=E2eeProtocol.PublicKey(E2eeProtocol.GenerateKeys(),_db.Alice,aliceSession.Id); + await new E2eeService(_db.Context).RegisterAsync(_db.Alice,aliceSession.Id,aliceKey); + var directoryResponse=await _client.GetAsync($"/api/e2ee/conversations/0/{_db.ChatId}/keys"); + Assert.That(directoryResponse.StatusCode,Is.EqualTo(HttpStatusCode.OK)); + var directory=(await directoryResponse.Content.ReadFromJsonAsync())!; + Assert.That(directory.Members,Is.EquivalentTo(new[]{_db.Alice,_db.Bob}));Assert.That(directory.Devices,Has.Length.EqualTo(2)); + } +} diff --git a/Govor.Server.Tests/ReadApiTests.cs b/tests/Govor.Server.Tests/Api/ReadApiTests.cs similarity index 93% rename from Govor.Server.Tests/ReadApiTests.cs rename to tests/Govor.Server.Tests/Api/ReadApiTests.cs index 1fa08d2..de66992 100644 --- a/Govor.Server.Tests/ReadApiTests.cs +++ b/tests/Govor.Server.Tests/Api/ReadApiTests.cs @@ -33,7 +33,7 @@ namespace Govor.Server.Tests; [TestFixture] [NonParallelizable] -public class ReadApiTests +public partial class ReadApiTests { private const string Secret = "Govor-server-tests-only-signing-key-at-least-64-characters-long-123456"; private TestDatabase _db = null!; @@ -41,7 +41,6 @@ public class ReadApiTests private HttpClient _client = null!; private Mock _notifier = null!; private Guid _session; - [SetUp] public void SetUp() { @@ -69,6 +68,41 @@ public class ReadApiTests _db.Dispose(); } + [Test] + public async Task OnlineStatusEndpointUsesPersistedLastSeenAndHandlesMissingUser() + { + Assert.That((await _client.GetAsync($"/api/online/status/{_db.Alice}")).StatusCode, Is.EqualTo(HttpStatusCode.Unauthorized)); + Authorize(); + var response = await _client.GetAsync($"/api/online/status/{_db.Alice}"); + Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK)); + using var json = JsonDocument.Parse(await response.Content.ReadAsStringAsync()); + var expected = (await _db.Context.Users.AsNoTracking().SingleAsync(u => u.Id == _db.Alice)).WasOnline; + Assert.That(json.RootElement.GetProperty("lastSeen").GetDateTime(), Is.EqualTo(expected)); + var missing = await _client.GetAsync($"/api/online/status/{Guid.NewGuid()}"); + Assert.That(missing.StatusCode, Is.EqualTo(HttpStatusCode.OK)); + using var missingJson = JsonDocument.Parse(await missing.Content.ReadAsStringAsync()); + Assert.That(missingJson.RootElement.GetProperty("lastSeen").ValueKind, Is.EqualTo(JsonValueKind.Null)); + } + + [Test] + [TestCase(false)] + [TestCase(true)] + public async Task EncryptedAttachmentUploadAcceptsMissingOrEmptyDecryptionKey(bool sendEmptyKey) + { + Authorize(); + using var form = new MultipartFormDataContent(); + form.Add(new ByteArrayContent(new byte[] { 1, 2, 3 }), "FromFile", "encrypted.bin"); + form.Add(new StringContent("0"), "Type"); + form.Add(new StringContent("0"), "OwnerType"); + form.Add(new StringContent(Govor.Application.E2ee.E2eeProtocol.EncryptedMimeType), "MimeType"); + if (sendEmptyKey) form.Add(new StringContent(""), "EncryptedKey"); + var response = await _client.PostAsync("/api/media/upload", form); + Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK), await response.Content.ReadAsStringAsync()); + var media = await _db.Context.MediaFiles.AsNoTracking().SingleAsync(); + Assert.That(media.UploaderId, Is.EqualTo(_db.Bob)); + Assert.That(media.MineType, Is.EqualTo(Govor.Application.E2ee.E2eeProtocol.EncryptedMimeType)); + } + [Test] public async Task ReadEndpointPersistsReceiptsNotifiesAndReturnsUnreadCount() { @@ -538,6 +572,9 @@ public class ReadApiTests services.AddDataProtection().UseEphemeralDataProtectionProvider(); services.RemoveAll(); services.AddSingleton(new EphemeralDataProtectionProvider()); + foreach (var registration in services.Where(d => d.ServiceType == typeof(IHostedService) && + d.ImplementationType?.FullName == "Microsoft.AspNetCore.DataProtection.Internal.DataProtectionHostedService").ToArray()) + services.Remove(registration); var worker = services.Single(d => d.ServiceType == typeof(IHostedService) && d.ImplementationType == typeof(ChatPushWorker)); services.Remove(worker); services.RemoveAll>(); @@ -554,3 +591,4 @@ public class ReadApiTests } } } + diff --git a/tests/Govor.Server.Tests/Govor.Server.Tests.csproj b/tests/Govor.Server.Tests/Govor.Server.Tests.csproj new file mode 100644 index 0000000..e35f2f2 --- /dev/null +++ b/tests/Govor.Server.Tests/Govor.Server.Tests.csproj @@ -0,0 +1,6 @@ + + + + + + diff --git a/Govor.Server.Tests/GroupTests.cs b/tests/Govor.Server.Tests/Groups/GroupTests.cs similarity index 100% rename from Govor.Server.Tests/GroupTests.cs rename to tests/Govor.Server.Tests/Groups/GroupTests.cs diff --git a/Govor.Server.Tests/InvitationClockTests.cs b/tests/Govor.Server.Tests/Groups/InvitationClockTests.cs similarity index 100% rename from Govor.Server.Tests/InvitationClockTests.cs rename to tests/Govor.Server.Tests/Groups/InvitationClockTests.cs diff --git a/Govor.Server.Tests/MessageAccessTests.cs b/tests/Govor.Server.Tests/Messages/MessageAccessTests.cs similarity index 100% rename from Govor.Server.Tests/MessageAccessTests.cs rename to tests/Govor.Server.Tests/Messages/MessageAccessTests.cs diff --git a/Govor.Server.Tests/ReadConcurrencyTests.cs b/tests/Govor.Server.Tests/Messages/ReadConcurrencyTests.cs similarity index 100% rename from Govor.Server.Tests/ReadConcurrencyTests.cs rename to tests/Govor.Server.Tests/Messages/ReadConcurrencyTests.cs diff --git a/Govor.Server.Tests/FirebasePushProviderTests.cs b/tests/Govor.Server.Tests/Notifications/FirebasePushProviderTests.cs similarity index 71% rename from Govor.Server.Tests/FirebasePushProviderTests.cs rename to tests/Govor.Server.Tests/Notifications/FirebasePushProviderTests.cs index 1e739ac..790e9ad 100644 --- a/Govor.Server.Tests/FirebasePushProviderTests.cs +++ b/tests/Govor.Server.Tests/Notifications/FirebasePushProviderTests.cs @@ -67,6 +67,35 @@ public class FirebasePushProviderTests Assert.That(sent.GetProperty("webpush").GetProperty("notification").GetProperty("tag").GetString(), Is.EqualTo("chat_123")); } + [Test] + public async Task LargeMulticastBatchesDistinctTokensAndUsesDefaultPlatformChannel() + { + var tokens = Enumerable.Range(0, 501).Select(i => "device-" + i).ToArray(); + var result = await _provider.SendMulticastAsync(tokens.Append(tokens[0]).ToArray(), new PushMessage { Title = "test", Body = "test" }); + Assert.That(result.SuccessCount, Is.EqualTo(501)); + Assert.That(result.FailureCount, Is.Zero); + Assert.That(_requests.Select(r => r.GetProperty("token").GetString()), Is.EquivalentTo(tokens)); + Assert.That(_requests.First().GetProperty("android").GetProperty("notification").GetProperty("channel_id").GetString(), Is.EqualTo("chat_messages")); + Assert.That((await _provider.SendMulticastAsync(Array.Empty(), new PushMessage())).SuccessCount, Is.Zero); + } + + [TestCase("UNREGISTERED", HttpStatusCode.NotFound, true)] + [TestCase("INVALID_ARGUMENT", HttpStatusCode.BadRequest, false)] + public async Task SingleDeliveryInvalidatesOnlyPermanentlyUnregisteredDevice(string code, HttpStatusCode status, bool permanent) + { + _status = status; + _response = JsonSerializer.Serialize(new { error = new { code = (int)status, message = "FCM failure", + status = status == HttpStatusCode.NotFound ? "NOT_FOUND" : "INVALID_ARGUMENT", + details = new[] { new Dictionary { ["@type"] = "type.googleapis.com/google.firebase.fcm.v1.FcmError", ["errorCode"] = code } } } }); + if (permanent) + { + var result = await _provider.SendToTokenAsync("device", new PushMessage { Title = "test", Body = "test" }); + Assert.That(result.SuccessCount, Is.Zero); + Assert.That(result.FailedTokens, Is.EqualTo(new[] { "device" })); + } + else Assert.ThrowsAsync(() => _provider.SendToTokenAsync("device", new PushMessage { Title = "test", Body = "test" })); + } + [TestCase("UNREGISTERED", HttpStatusCode.NotFound, true)] [TestCase("INVALID_ARGUMENT", HttpStatusCode.BadRequest, false)] [TestCase("SENDER_ID_MISMATCH", HttpStatusCode.Forbidden, false)] diff --git a/Govor.Server.Tests/NotificationTests.cs b/tests/Govor.Server.Tests/Notifications/NotificationTests.cs similarity index 99% rename from Govor.Server.Tests/NotificationTests.cs rename to tests/Govor.Server.Tests/Notifications/NotificationTests.cs index 87fbe7e..ab3d78d 100644 --- a/Govor.Server.Tests/NotificationTests.cs +++ b/tests/Govor.Server.Tests/Notifications/NotificationTests.cs @@ -27,7 +27,6 @@ public class NotificationTests private string[] _targetGroups = []; private Guid _aliceSession; private Guid _bobSession; - [SetUp] public void SetUp() { diff --git a/Govor.Server.Tests/PushDeliveryTests.cs b/tests/Govor.Server.Tests/Notifications/PushDeliveryTests.cs similarity index 99% rename from Govor.Server.Tests/PushDeliveryTests.cs rename to tests/Govor.Server.Tests/Notifications/PushDeliveryTests.cs index 70bc59a..37638aa 100644 --- a/Govor.Server.Tests/PushDeliveryTests.cs +++ b/tests/Govor.Server.Tests/Notifications/PushDeliveryTests.cs @@ -15,7 +15,6 @@ public class PushDeliveryTests private Mock _provider = null!; private PushNotificationService _service = null!; private Guid _user; - [SetUp] public void SetUp() { diff --git a/Govor.Server.Tests/PushReliabilityTests.cs b/tests/Govor.Server.Tests/Notifications/PushReliabilityTests.cs similarity index 94% rename from Govor.Server.Tests/PushReliabilityTests.cs rename to tests/Govor.Server.Tests/Notifications/PushReliabilityTests.cs index 9977ec8..1f67a92 100644 --- a/Govor.Server.Tests/PushReliabilityTests.cs +++ b/tests/Govor.Server.Tests/Notifications/PushReliabilityTests.cs @@ -21,12 +21,12 @@ public class PushReliabilityTests private Mock _clock = null!; private PushTokenService _tokens = null!; private DateTime _now; - [SetUp] public void SetUp() { _db = new TestDatabase(); _now = DateTime.UtcNow.AddMinutes(1); + _now = _now.AddTicks(-(_now.Ticks % TimeSpan.TicksPerMicrosecond)); _clock = new Mock(); _clock.SetupGet(c => c.Now).Returns(() => _now); _tokens = new PushTokenService(_db.Context, _clock.Object, NullLogger.Instance); @@ -63,20 +63,20 @@ public class PushReliabilityTests private async Task EncryptedHelloAsync() { var directory = new Govor.Application.E2ee.E2eeService(_db.Context); - var devices = new List(); - var privateKeys = Govor.Security.E2eeProtocol.GenerateKeys(); + var devices = new List(); + var privateKeys = Govor.Application.E2ee.E2eeProtocol.GenerateKeys(); foreach (var user in new[] { _db.Alice, _db.Bob }) { var session = new UserSession { UserId = user, RefreshTokenHash = Guid.NewGuid().ToString(), ExpiresAt = DateTime.UtcNow.AddDays(30) }; _db.Context.UserSessions.Add(session); await _db.Context.SaveChangesAsync(); - var key = Govor.Security.E2eeProtocol.PublicKey(user == _db.Alice ? privateKeys : - Govor.Security.E2eeProtocol.GenerateKeys(), user, session.Id); + var key = Govor.Application.E2ee.E2eeProtocol.PublicKey(user == _db.Alice ? privateKeys : + Govor.Application.E2ee.E2eeProtocol.GenerateKeys(), user, session.Id); await directory.RegisterAsync(user, session.Id, key); devices.Add(key); } - return Govor.Security.E2eeProtocol.Encrypt(new("hello", []), privateKeys, devices[0], + return Govor.Application.E2ee.E2eeProtocol.Encrypt(new("hello", []), privateKeys, devices[0], await directory.GetConversationKeysAsync(_db.Alice, _db.ChatId, Govor.Domain.Models.Messages.RecipientType.User), Guid.NewGuid()); } diff --git a/Govor.Server.Tests/ReactionMediaTests.cs b/tests/Govor.Server.Tests/Reactions/ReactionMediaTests.cs similarity index 100% rename from Govor.Server.Tests/ReactionMediaTests.cs rename to tests/Govor.Server.Tests/Reactions/ReactionMediaTests.cs diff --git a/Govor.Server.Tests/ReactionTests.cs b/tests/Govor.Server.Tests/Reactions/ReactionTests.cs similarity index 100% rename from Govor.Server.Tests/ReactionTests.cs rename to tests/Govor.Server.Tests/Reactions/ReactionTests.cs diff --git a/Govor.Server.Tests/E2eeTests.cs b/tests/Govor.Server.Tests/Security/E2eeTests.cs similarity index 74% rename from Govor.Server.Tests/E2eeTests.cs rename to tests/Govor.Server.Tests/Security/E2eeTests.cs index 2aa6ce9..24169e3 100644 --- a/Govor.Server.Tests/E2eeTests.cs +++ b/tests/Govor.Server.Tests/Security/E2eeTests.cs @@ -6,7 +6,6 @@ using Govor.Application.Messages.Parameters; using Govor.Domain.Models; using Govor.Domain.Models.Messages; using Govor.Domain.Models.Users; -using Govor.Security; using Microsoft.EntityFrameworkCore; using Microsoft.Extensions.Logging.Abstractions; using NUnit.Framework; @@ -50,6 +49,73 @@ public class E2eeTests _alice, _a, await _e2ee.GetConversationKeysAsync(_db.Alice, conversation ?? _db.ChatId, (RecipientType)type), id ?? Guid.NewGuid(), isEdit: edit); + [Test] + public async Task EveryParticipantNeedsARegisteredDeviceAndDeviceCountIsBounded() + { + await _db.Context.UserCryptoSessions.Where(c => c.UserSessionId == _b.SessionId).ExecuteDeleteAsync(); + Assert.ThrowsAsync(() => _e2ee.GetConversationKeysAsync(_db.Alice, _db.ChatId, RecipientType.User)); + _b = await Register(_db.Bob, _bob); + Assert.That((await _e2ee.GetConversationKeysAsync(_db.Alice, _db.ChatId, RecipientType.User)).Devices, Has.Length.EqualTo(2)); + for (var i = 0; i < E2eeProtocol.MaxDevices; i++) + { + var session = new UserSession { UserId = _db.Alice, RefreshTokenHash = "limit-" + i, ExpiresAt = DateTime.UtcNow.AddDays(1) }; + var cryptoId = Guid.NewGuid(); + _db.Context.UserCryptoSessions.Add(new Govor.Domain.Models.Users.Crypto.UserCryptoSession + { + Id = cryptoId, UserSession = session, UserSessionId = session.Id, + PublicIdentityKey = Convert.FromBase64String(_a.IdentityKey), + SignedPreKey = new Govor.Domain.Models.Users.Crypto.SignedPreKey + { + Id = Guid.NewGuid(), UserCryptoSessionId = cryptoId, + PublicSignedPreKey = Convert.FromBase64String(_a.EncryptionKey), SignedPreKeySignature = Convert.FromBase64String(_a.Signature) + }, + OneTimePreKeys = [] + }); + } + await _db.Context.SaveChangesAsync(); + var limitError = Assert.ThrowsAsync(() => _e2ee.GetConversationKeysAsync(_db.Alice, _db.ChatId, RecipientType.User)); + Assert.That(limitError!.Message, Does.Contain("Too many E2EE devices")); + } + + [TestCase(false)] + [TestCase(true)] + public async Task ExpiredOrRevokedSessionCannotRegisterKeys(bool revoked) + { + await _db.Context.UserSessions.Where(s => s.Id == _a.SessionId).ExecuteUpdateAsync(s => s + .SetProperty(s => s.IsRevoked, revoked).SetProperty(s => s.ExpiresAt, DateTime.UtcNow.AddDays(revoked ? 1 : -1))); + Assert.ThrowsAsync(() => _e2ee.RegisterAsync(_db.Alice, _a.SessionId, _a)); + Assert.ThrowsAsync(() => _e2ee.RegisterAsync(_db.Alice, Guid.NewGuid(), _a)); + } + + [TestCase("malformed")] + [TestCase("routing")] + [TestCase("stale")] + public async Task InvalidEnvelopeContextIsReturnedAsValidationFailure(string reason) + { + var directory = await _e2ee.GetConversationKeysAsync(_db.Alice, _db.ChatId, RecipientType.User); + var content = reason == "malformed" ? E2eeProtocol.Prefix + "invalid" : E2eeProtocol.Encrypt(new("secret", []), + _alice, _a, directory, Guid.NewGuid(), createdAt: DateTimeOffset.UtcNow.AddMinutes(reason == "stale" ? -6 : 0).ToUnixTimeMilliseconds()); + Assert.ThrowsAsync(() => _e2ee.ValidateAsync(content, reason == "routing" ? _db.Bob : _db.Alice, + _db.ChatId, RecipientType.User, null, [])); + } + + [TestCase(false)] + [TestCase(true)] + public async Task EncryptedMessageRejectsPlaintextAttachmentAndLeakedKey(bool leakedKey) + { + var mediaId = Guid.NewGuid(); + _db.Context.MediaFiles.Add(new MediaFile { Id = mediaId, UploaderId = _db.Alice, OwnerType = MediaOwnerType.Message, + Url = "attachment.bin", MineType = leakedKey ? E2eeProtocol.EncryptedMimeType : "image/png" }); + await _db.Context.SaveChangesAsync(); + var content = await Encrypt(attachments: [new(mediaId, "secret", "attachment.png", "image/png")]); + var result = await new MessageSendingService(_db.Context, NullLogger.Instance).SendMessageAsync( + new(content, null, _db.ChatId, RecipientType.User, _db.Alice, DateTime.UtcNow, [new(mediaId, leakedKey ? "leaked" : "")])); + Assert.That(result.IsSuccess, Is.False); + Assert.That(result.Exception, Is.TypeOf()); + Assert.That(await _db.Context.Messages.CountAsync(), Is.Zero); + Assert.That(await _db.Context.ChatPushNotifications.CountAsync(), Is.Zero); + } + [Test] public async Task BothParticipantsCanDecryptButServerAndOutsiderCannot() { diff --git a/Govor.Server.Tests/HubSessionTests.cs b/tests/Govor.Server.Tests/Security/HubSessionTests.cs similarity index 100% rename from Govor.Server.Tests/HubSessionTests.cs rename to tests/Govor.Server.Tests/Security/HubSessionTests.cs diff --git a/tests/Measure-ApplicationCoverage.ps1 b/tests/Measure-ApplicationCoverage.ps1 new file mode 100644 index 0000000..fb9d4f8 --- /dev/null +++ b/tests/Measure-ApplicationCoverage.ps1 @@ -0,0 +1,97 @@ +[CmdletBinding()] +param( + [Parameter(Mandatory)][string]$ResultsDirectory, + [string]$AssemblyName = 'Govor.Application', + [switch]$ExcludeGeneratedSources, + [double]$MinimumLineCoverage = 98, + [double]$MinimumBranchCoverage = 92 +) + +$ErrorActionPreference = 'Stop' +$lines = @{} +$branches = @{} +$reports = @(Get-ChildItem -LiteralPath $ResultsDirectory -Recurse -Filter coverage.json) +if ($reports.Count -eq 0) { throw "No Coverlet JSON reports found in $ResultsDirectory." } + +foreach ($report in $reports) { + $coverage = Get-Content -Raw -LiteralPath $report.FullName | ConvertFrom-Json -AsHashtable + foreach ($module in $coverage.Keys) { + if ([IO.Path]::GetFileName($module) -ne "$AssemblyName.dll") { continue } + foreach ($document in $coverage[$module].Keys) { + $file = $document.Replace('\', '/') + $marker = $file.IndexOf("$AssemblyName/", [StringComparison]::Ordinal) + if ($marker -ge 0) { $file = $file.Substring($marker) } + if (!$lines.ContainsKey($file)) { $lines[$file] = @{}; $branches[$file] = @{} } + foreach ($type in $coverage[$module][$document].Keys) { + foreach ($methodName in $coverage[$module][$document][$type].Keys) { + $method = $coverage[$module][$document][$type][$methodName] + foreach ($line in $method.Lines.Keys) { + $lines[$file][$line] = ($method.Lines[$line] -gt 0) -or $lines[$file][$line] + } + foreach ($branch in $method.Branches) { + $key = "$type|$methodName|$($branch.Line)|$($branch.Offset)|$($branch.EndOffset)|$($branch.Path)" + if (!$branches[$file].ContainsKey($key)) { + $branches[$file][$key] = @{ Line = $branch.Line; Covered = $false } + } + $branches[$file][$key].Covered = ($branch.Hits -gt 0) -or $branches[$file][$key].Covered + } + } + } + } + } +} +if ($lines.Count -eq 0) { throw "$AssemblyName.dll was not instrumented." } + +$files = @(foreach ($file in ($lines.Keys | Sort-Object)) { + $missingLines = @($lines[$file].Keys | Where-Object { !$lines[$file][$_] } | ForEach-Object { [int]$_ } | Sort-Object) + $missingBranches = @($branches[$file].Values | Where-Object { !$_.Covered } | ForEach-Object { [int]$_.Line } | Sort-Object -Unique) + [pscustomobject]@{ + File = $file + Lines = $lines[$file].Count + CoveredLines = @($lines[$file].Values | Where-Object { $_ }).Count + Branches = $branches[$file].Count + CoveredBranches = @($branches[$file].Values | Where-Object { $_.Covered }).Count + MissingLines = $missingLines + MissingBranchLines = $missingBranches + } +}) +$assemblyFiles = $files +$generatedFiles = @($files | Where-Object { $_.File -match '/obj/' }) +if ($ExcludeGeneratedSources) { + $files = @($files | Where-Object { $_.File -notmatch '/obj/' }) +} +$totalLines = ($files | Measure-Object Lines -Sum).Sum +$coveredLines = ($files | Measure-Object CoveredLines -Sum).Sum +$totalBranches = ($files | Measure-Object Branches -Sum).Sum +$coveredBranches = ($files | Measure-Object CoveredBranches -Sum).Sum +$lineCoverage = 100 * $coveredLines / [Math]::Max(1, $totalLines) +$branchCoverage = 100 * $coveredBranches / [Math]::Max(1, $totalBranches) +$summary = [ordered]@{ + Assembly = $AssemblyName + ExcludeGeneratedSources = [bool]$ExcludeGeneratedSources + ExcludedFiles = @(if ($ExcludeGeneratedSources) { $generatedFiles.File }) + EntireAssembly = [ordered]@{ + CoveredLines = ($assemblyFiles | Measure-Object CoveredLines -Sum).Sum + TotalLines = ($assemblyFiles | Measure-Object Lines -Sum).Sum + CoveredBranches = ($assemblyFiles | Measure-Object CoveredBranches -Sum).Sum + TotalBranches = ($assemblyFiles | Measure-Object Branches -Sum).Sum + } + LineCoverage = [Math]::Round($lineCoverage, 2) + BranchCoverage = [Math]::Round($branchCoverage, 2) + CoveredLines = $coveredLines + TotalLines = $totalLines + CoveredBranches = $coveredBranches + TotalBranches = $totalBranches + Files = $files +} +$summary | ConvertTo-Json -Depth 8 | Set-Content (Join-Path $ResultsDirectory "$($AssemblyName.Split('.')[-1].ToLowerInvariant())-coverage.json") +Write-Output ("${AssemblyName}: {0:F2}% lines ({1}/{2}), {3:F2}% branches ({4}/{5})." -f + $lineCoverage, $coveredLines, $totalLines, $branchCoverage, $coveredBranches, $totalBranches) +$files | Where-Object { $_.MissingLines.Count -gt 0 -or $_.MissingBranchLines.Count -gt 0 } | + Sort-Object { $_.Lines - $_.CoveredLines } -Descending | + Select-Object File, @{ Name = 'MissedLines'; Expression = { $_.MissingLines -join ',' } }, + @{ Name = 'MissedBranchLines'; Expression = { $_.MissingBranchLines -join ',' } } | Format-Table -Wrap + +if ($lineCoverage -lt $MinimumLineCoverage -or $branchCoverage -lt $MinimumBranchCoverage) { + throw "$AssemblyName coverage is below $MinimumLineCoverage% lines / $MinimumBranchCoverage% branches." +} diff --git a/tests/README.md b/tests/README.md new file mode 100644 index 0000000..2bb3a60 --- /dev/null +++ b/tests/README.md @@ -0,0 +1,126 @@ +# Серверные тесты Govor + +Все действующие серверные тесты находятся в этой папке и входят в оба решения: +`Govor.Server.slnx` и `Govor.sln`. Требуется .NET SDK 10 из `global.json`. + +| Проект | Назначение | +| --- | --- | +| `Govor.API.Tests/Unit` | Контроллеры, преобразование Result в HTTP, SignalR helpers; зависимости подменены mocks | +| `Govor.API.Tests/Integration` | HubExceptionFilter с реальными сессиями, запросы групп, доставка уведомлений и отмена фонового push | +| `Govor.Application.Tests/Unit` | JWT, пароли, username moderation, claims, online connections, storage, нормализация текста | +| `Govor.Application.Tests/Integration` | Сервисы регистрации, дружбы, профилей, сессий, истории сообщений и доступа к медиа с реальной SQL-базой | +| `Govor.Domain.Tests/Persistence` | Уникальные индексы, внешние ключи и каскадное удаление | +| `Govor.Domain.Tests/Migrations` | Очистка старых данных групп при миграции | +| `Govor.Server.Tests` | HTTP/JWT, SignalR, E2EE, группы, реакции, прочтения, push-очередь и Firebase transport | +| `Shared/TestDatabase.cs` | Изолированная БД и минимальные данные; исходник подключён к тестовым проектам через Directory.Build.props | + +## Полный запуск + +Из корня репозитория: + +```powershell +dotnet restore Govor.Server.slnx +dotnet build Govor.Server.slnx --no-restore -c Release +dotnet test Govor.Server.slnx --no-build --no-restore -c Release --logger trx --results-directory artifacts/test-results +``` + +По умолчанию каждый тест использует собственную SQLite in-memory БД с внешними +ключами. Тесты не запускают production-сервер, не используют его БД, Firebase credentials +или файловое хранилище. HTTP-тесты поднимают приложение внутри WebApplicationFactory; +Firebase и storage заменены тестовыми реализациями. + +Для проверки PostgreSQL укажите отдельную тестовую БД: + +```powershell +$env:TEST_POSTGRES_CONNECTION = 'Host=localhost;Port=5432;Database=govor_tests;Username=govor;Password=tests-only' +dotnet test Govor.Server.slnx --no-build --no-restore -c Release --logger trx --results-directory artifacts/test-results/postgres +Remove-Item Env:TEST_POSTGRES_CONNECTION +``` + +Имя БД обязано заканчиваться на `_tests`; пользователь должен иметь право создавать +и удалять схемы. Каждый экземпляр TestDatabase создаёт уникальную схему, применяет +полную цепочку миграций и удаляет схему при Dispose. Пул соединений отключён: +уникальный SearchPath иначе создаёт отдельный пул для каждого теста и исчерпывает +лимит PostgreSQL. Для детерминированного сравнения времени учитывается точность +PostgreSQL в одну микросекунду. + +На Windows криптографические тесты требуют рабочего профиля Windows CNG. +Ограниченная sandbox-учётная запись может завершать импорт PKCS#8 ошибкой +`CryptographicException`; проверку нужно запускать под обычным пользователем. + +## Покрытие + +```powershell +dotnet test Govor.Server.slnx --no-build --no-restore -c Release --collect 'XPlat Code Coverage;Format=json,cobertura' --results-directory artifacts/coverage +./tests/Measure-ApplicationCoverage.ps1 -ResultsDirectory artifacts/coverage +./tests/Measure-ApplicationCoverage.ps1 -ResultsDirectory artifacts/coverage -AssemblyName Govor.API -ExcludeGeneratedSources -MinimumLineCoverage 98 -MinimumBranchCoverage 92 +``` + +Каждый тестовый проект создаёт свой `coverage.cobertura.xml`. Эти файлы нельзя +суммировать как независимые проценты: они покрывают пересекающиеся серверные сборки. + +Объединённое покрытие `Govor.Application` в итоговом прогоне 24.10.2026: +**98,88% строк (2727/2758)** и **93,53% ветвей (1199/1282)**. До расширения +покрытие строк составляло 82,8%. Скрипт объединяет JSON-отчёты всех четырёх +проектов: строка или ветвь считается покрытой, если выполнена хотя бы в одном +проекте. Сборка Application включена целиком, без исключения неудобного кода. +CI проверяет минимальные пороги 98% строк и 92% ветвей. + +Это не полное покрытие: остаются 31 строка и 83 пути ветвления. Подробности, +реализованные сценарии и ограничения — в [APPLICATION-COVERAGE.md](APPLICATION-COVERAGE.md). + +Покрытие исходников `Govor.API`: **98,10% строк (1910/1947)** и **92,34% ветвей +(410/444)**. Все контроллеры выполнены по строкам; это не означает проверки всех +комбинаций условий. Для API из порога исключён только сгенерированный файл OpenAPI +из `obj`; с ним полная сборка имеет 88,47% строк и 63,08% ветвей. JSON сохраняет +полные числа и список исключений. Подробности — в [API-COVERAGE.md](API-COVERAGE.md). + +## Обновление устаревших тестов + +Старые NUnit-проекты .NET 8 переведены на .NET 10; общие версии test SDK, +стабильного NUnit и адаптера заданы в `Directory.Build.props`. Тесты больше не +ссылаются на удалённые Govor.Data/Repositories, старые пространства имён Services/Interfaces +и внешний исходный проект SmartRes; используется существующий `libs/SmartRes.dll`. + +Проверки удалённых репозиториев и IObjectValidator заменены проверками текущих +сервисов и ограничений модели EF. Вместо ожидания исключений проверяются Result, +HTTP status и ProblemDetails. Закомментированные тесты удалённых API Presence/Chats +убраны; актуальные сценарии SignalR выполняются в Govor.Server.Tests. +LocalStorageServiceTests перенесены из API к приложению. + +Тесты удалённого консольного клиента `Govor.ConsoleClient.Tests` не входят в +серверные решения. Их исходники оставлены в прежней папке вне `tests`. + +CI запускает все четыре проекта в Release на SQLite и PostgreSQL, проверяет +пороги покрытия и сохраняет TRX и отчёты покрытия для обеих конфигураций. +Для Application и исходников API установлены пороги 98% строк / 92% ветвей. + +## Результат проверки 24.10.2026 + +Release-сборка и 710 тестов проходят на SQLite и PostgreSQL 17.4; пропущенных +тестов нет. Проверены регистрация и роли, сессии и refresh/replay, доступ к чатам +и медиа, пагинация, миграции и ограничения данных, группы, реакции, E2EE, HTTP/SignalR, +push retries и сериализация Firebase через подменённый транспорт. + +При расширении покрытия Application добавлена 191 проверка; в самом проекте +Application.Tests теперь 295 тестовых случаев. Реализованы чтение last seen, +чтение медиа по URL и блокировка/разблокировка друзей. Исправлены обнаруженные +ошибки сохранения криптографических ключей EF, проверки владельца сессии, +загрузки SignedPreKey, обработки пустого username и выхода за корень storage. + +При расширении API добавлены ещё 172 проверки: API.Tests содержит 271 случай, +Server.Tests — 136. Пустые каталоги прежней структуры удалены; места для будущих +тестов заранее не создаются. Папка `Shared` в IDE также может быть виртуальной +ссылкой на общий исходник `tests/Shared/TestDatabase.cs`. + +Найден и исправлен дефект загрузки вложений: Required/implicit Required для +EncryptedKey отклонял пустое поле, хотя E2EE-вложение должно приходить без ключа +расшифровки. Регрессионные unit- и HTTP-тесты покрывают отсутствующее и пустое поле, +а plaintext и переданный ключ по-прежнему отклоняются. + +В исходной кодовой базе остаются nullable/compiler warnings и предупреждения +NuGet NU1902/NU1903 для SixLabors.ImageSharp 3.1.12. Переход на новые ImageSharp +требует отдельной проверки совместимости и лицензирования: официальные +[release notes](https://github.com/SixLabors/ImageSharp/releases) отмечают изменение +license enforcement вместе с security fixes. Успех тестов не снимает эти предупреждения +и не подтверждает доставку push на физическое устройство или production-развёртывание. diff --git a/Govor.Server.Tests/TestDatabase.cs b/tests/Shared/TestDatabase.cs similarity index 81% rename from Govor.Server.Tests/TestDatabase.cs rename to tests/Shared/TestDatabase.cs index 99bc30d..7c02919 100644 --- a/Govor.Server.Tests/TestDatabase.cs +++ b/tests/Shared/TestDatabase.cs @@ -8,13 +8,14 @@ using System.Data.Common; using Npgsql; using Microsoft.EntityFrameworkCore.Diagnostics; -namespace Govor.Server.Tests; +namespace Govor.Tests.Shared; public sealed class TestDatabase : IDisposable { public DbConnection Connection { get; } private readonly string? _schema; - public GovorDbContext Context { get; } + private bool _disposed; + public GovorDbContext Context { get; } = null!; public Guid Alice { get; } = Guid.NewGuid(); public Guid Bob { get; } = Guid.NewGuid(); public Guid Outsider { get; } = Guid.NewGuid(); @@ -32,6 +33,9 @@ public sealed class TestDatabase : IDisposable throw new InvalidOperationException("PostgreSQL tests require a dedicated database ending in _tests."); _schema = "test_" + Guid.NewGuid().ToString("N"); settings.SearchPath = _schema; + // Each fixture has a unique search path. Pooling would retain one pool + // per schema and exhaust PostgreSQL's connection limit across the suite. + settings.Pooling = false; Connection = new NpgsqlConnection(settings.ConnectionString); } Connection.Open(); @@ -94,13 +98,18 @@ public sealed class TestDatabase : IDisposable public void Dispose() { - Context.Dispose(); - if (_schema is not null) + if (_disposed) return; + _disposed = true; + try { - using var command = Connection.CreateCommand(); - command.CommandText = $"DROP SCHEMA {_schema} CASCADE"; - command.ExecuteNonQuery(); + Context?.Dispose(); + if (_schema is not null && Connection.State == System.Data.ConnectionState.Open) + { + using var command = Connection.CreateCommand(); + command.CommandText = $"DROP SCHEMA IF EXISTS {_schema} CASCADE"; + command.ExecuteNonQuery(); + } } - Connection.Dispose(); + finally { Connection.Dispose(); } } }