Admins Repository

+ tests
This commit is contained in:
Artemy
2025-06-24 15:14:45 +07:00
parent ce013eae49
commit 672fc95823
4 changed files with 239 additions and 16 deletions
@@ -1,7 +1,9 @@
using AutoFixture; using AutoFixture;
using Govor.Core.Infrastructure.Validators;
using Govor.Core.Models; using Govor.Core.Models;
using Govor.Data; using Govor.Data;
using Govor.Data.Repositories; using Govor.Data.Repositories;
using Govor.Data.Repositories.Exceptions;
using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure; using Microsoft.EntityFrameworkCore.Infrastructure;
@@ -12,6 +14,8 @@ public class AdminsRepositoryTests
{ {
private Fixture _fixture; private Fixture _fixture;
private DbContextOptions<GovorDbContext> _options; private DbContextOptions<GovorDbContext> _options;
private IObjectValidator<Admin> _validator = new AdminValidator();
private int _testIteration = 0; private int _testIteration = 0;
[SetUp] [SetUp]
@@ -19,9 +23,17 @@ public class AdminsRepositoryTests
{ {
_fixture = new Fixture(); _fixture = new Fixture();
_fixture.Behaviors
.OfType<ThrowingRecursionBehavior>()
.ToList()
.ForEach(b => _fixture.Behaviors.Remove(b));
_fixture.Behaviors.Add(new OmitOnRecursionBehavior());
_options = new DbContextOptionsBuilder<GovorDbContext>() _options = new DbContextOptionsBuilder<GovorDbContext>()
.UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(AdminsRepositoryTests)}_{_testIteration}") .UseInMemoryDatabase(databaseName: $"DbGovor_{nameof(AdminsRepositoryTests)}_{_testIteration}")
.Options; .Options;
_testIteration += 1;
} }
[Test] [Test]
@@ -32,7 +44,7 @@ public class AdminsRepositoryTests
var admins = _fixture.CreateMany<Admin>(random.Next(3, 10)).ToList(); var admins = _fixture.CreateMany<Admin>(random.Next(3, 10)).ToList();
await using var context = new GovorDbContext(_options); await using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context); var repository = new AdminsRepository(context, _validator);
context.AddRange(admins); context.AddRange(admins);
await context.SaveChangesAsync(); await context.SaveChangesAsync();
@@ -45,4 +57,119 @@ public class AdminsRepositoryTests
Assert.That(result.Count(), Is.EqualTo(admins.Count())); Assert.That(result.Count(), Is.EqualTo(admins.Count()));
Assert.That(result.Select(r => r.UserId), Is.EquivalentTo(admins.Select(r => r.UserId))); Assert.That(result.Select(r => r.UserId), Is.EquivalentTo(admins.Select(r => r.UserId)));
} }
[Test]
public async Task Given_EmptyDbSet_When_GetAllAsync_Should_Throw_NotFoundException()
{
// Arrange
await using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context, _validator);
// Act & Assert
Assert.ThrowsAsync<NotFoundException>(async () => await repository.GetAllAsync());
}
[Test]
public async Task Given_ValidUserId_When_GetByIdAsync_Then_Admin_Should_Return_Admin()
{
// Arrange
var admin = _fixture.Create<Admin>();
await using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context, _validator);
context.Add(admin);
await context.SaveChangesAsync();
// Act
var result = await repository.GetByIdAsync(admin.UserId);
// Assert
Assert.That(result, Is.Not.Null);
Assert.That(result.UserId, Is.EqualTo(admin.UserId));
}
[Test]
public async Task Given_InvalidUserId_When_GetByIdAsync_Should_Throw_NotFoundByKeyException()
{
await using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context, _validator);
// Act & Assert
Assert.ThrowsAsync<NotFoundByKeyException<Guid>>(async () => await repository.GetByIdAsync(Guid.Empty));
}
[Test]
public async Task Given_ValidAdmin_When_AddAsync_Then_Added()
{
// Arrange
var admin = _fixture.Create<Admin>();
await using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context, _validator);
// Act
await repository.AddAsync(admin);
// Assert
Assert.That(context.Admins.Count, Is.EqualTo(1));
Assert.That(context.Admins.First(), Is.EqualTo(admin));
}
[Test]
public async Task Given_InvalidAdmin_When_AddAsync_Should_Throw_AdditionException()
{
// Arrange
await using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context, _validator);
// Act & Assert
Assert.ThrowsAsync<AdditionException>(async () => await repository.AddAsync(default));
}
[Test]
public void Given_ValidAdmin_When_Exist_Then_Returns_True()
{
// Arrange
var admin = _fixture.Create<Admin>();
using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context, _validator);
context.Add(admin);
context.SaveChanges();
// Act
var result = repository.Exist(admin.UserId);
var result2 = repository.Exist(admin);
// Assert
Assert.That(result, Is.True);
Assert.That(result2, Is.True);
}
[Test]
public void Given_ExistAdmin_When_Exist_Then_Returns_False()
{
// Arrange
var admin = _fixture.Create<Admin>();
using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context, _validator);
// Act
var result = repository.Exist(admin.UserId);
var result2 = repository.Exist(admin);
// Assert
Assert.That(result, Is.False);
Assert.That(result2, Is.False);
}
[Test]
public void Given_NullAdmin_When_Exist_Should_Throw_InvalidObjectException()
{
// Arrange
using var context = new GovorDbContext(_options);
var repository = new AdminsRepository(context, _validator);
// Act & Assert
Assert.Throws<InvalidObjectException<Admin>>(() => repository.Exist(default(Admin)));
}
} }
@@ -0,0 +1,34 @@
using Govor.Core.Models;
namespace Govor.Core.Infrastructure.Validators;
public class AdminValidator : IObjectValidator<Admin>
{
public void Validate(Admin admin)
{
try
{
if(admin is null)
throw new ArgumentNullException(nameof(admin));
if(admin.UserId == Guid.Empty)
throw new ArgumentException("User ID cannot be empty", nameof(admin.UserId));
}
catch (Exception e)
{
throw new InvalidObjectException<Admin>(e);
}
}
public bool TryValidate(Admin admin)
{
try
{
Validate(admin);
return true;
}
catch (Exception e)
{
return false;
}
}
}
+70 -13
View File
@@ -1,4 +1,5 @@
using Govor.Core.Infrastructure.Extensions; using Govor.Core.Infrastructure.Extensions;
using Govor.Core.Infrastructure.Validators;
using Govor.Core.Models; using Govor.Core.Models;
using Govor.Core.Repositories.Admins; using Govor.Core.Repositories.Admins;
using Govor.Data.Repositories.Exceptions; using Govor.Data.Repositories.Exceptions;
@@ -6,10 +7,10 @@ using Microsoft.EntityFrameworkCore;
namespace Govor.Data.Repositories; namespace Govor.Data.Repositories;
public class AdminsRepository(GovorDbContext context) : IAdminsRepository public class AdminsRepository(GovorDbContext context, IObjectValidator<Admin> validator) : IAdminsRepository
{ {
private GovorDbContext _context = context; private GovorDbContext _context = context;
private IObjectValidator<Admin> _validator = validator;
public async Task<List<Admin>> GetAllAsync() public async Task<List<Admin>> GetAllAsync()
{ {
return await _context.Admins return await _context.Admins
@@ -18,33 +19,89 @@ public class AdminsRepository(GovorDbContext context) : IAdminsRepository
.ToListOrThrowIfEmpty(new NotFoundException("Database is empty")); .ToListOrThrowIfEmpty(new NotFoundException("Database is empty"));
} }
public Task<Admin> GetByIdAsync(Guid id) public async Task<Admin> GetByIdAsync(Guid id)
{ {
throw new NotImplementedException(); return await _context.Admins
.AsNoTracking()
.Include(a => a.User)
.FirstOrDefaultAsync(u => u.UserId == id)
?? throw new NotFoundByKeyException<Guid>(id, "User with given id does not exist");
} }
public Task AddAsync(Admin admin) public async Task AddAsync(Admin admin)
{ {
throw new NotImplementedException(); try
{
_validator.Validate(admin);
_context.Admins.Add(admin);
await _context.SaveChangesAsync();
}
catch (InvalidObjectException<Admin> ex)
{
throw new AdditionException("Admin with given data invalid", ex);
}
catch (Exception ex)
{
throw new AdditionException("Cannot add admin", ex);
}
} }
public Task UpdateAsync(Admin admin) public async Task UpdateAsync(Admin admin)
{ {
throw new NotImplementedException(); try
{
_validator.Validate(admin);
var rowsAffected = await _context.Admins
.Where(a => a.UserId == admin.UserId)
.ExecuteUpdateAsync(u => u
.SetProperty(a => a.UserId, admin.UserId)
);
if (rowsAffected == 0)
throw new NotFoundByKeyException<Guid>(admin.UserId);
}
catch (NotFoundByKeyException<Guid> ex)
{
throw new UpdateException($"Not found admin by given id {admin.UserId}", ex);
}
catch (Exception ex)
{
throw new UpdateException($"Error when updating the admin {admin.UserId}", ex);
}
} }
public Task DeleteAsync(Guid admin) public async Task DeleteAsync(Guid admin)
{ {
throw new NotImplementedException(); try
{
var result = await GetByIdAsync(admin);
_context.Admins.Remove(result);
await _context.SaveChangesAsync();
}
catch (NotFoundByKeyException<Guid> ex)
{
throw new RemoveException($"Not found admin by given id {admin}", ex);
}
catch (Exception ex)
{
throw new RemoveException("Error when removing the admin", ex);
}
} }
public bool Exist(Guid guid) public bool Exist(Guid id)
{ {
throw new NotImplementedException(); return _context.Users.Any(u => u.Id == id);
} }
public bool Exist(Admin admin) public bool Exist(Admin admin)
{ {
throw new NotImplementedException(); _validator.Validate(admin);
return _context.Admins.Any(u =>
u.UserId == admin.UserId
);
} }
} }
@@ -32,6 +32,7 @@ public class UsersRepository : IUsersRepository
return await _context.Users return await _context.Users
.AsNoTracking() .AsNoTracking()
.Include(u => u.Invite)
.FirstOrDefaultAsync(x => x.Id == id) .FirstOrDefaultAsync(x => x.Id == id)
?? throw new NotFoundByKeyException<Guid>(id, "User with given id does not exist"); ?? throw new NotFoundByKeyException<Guid>(id, "User with given id does not exist");
} }
@@ -44,6 +45,7 @@ public class UsersRepository : IUsersRepository
return await _context.Users return await _context.Users
.AsNoTracking() .AsNoTracking()
.Where(x => ids.Contains(x.Id)) .Where(x => ids.Contains(x.Id))
.Include(u => u.Invite)
.ToListOrThrowIfEmpty(new NotFoundByKeyException<IEnumerable<Guid>>(ids,"Users with given ids not found")); .ToListOrThrowIfEmpty(new NotFoundByKeyException<IEnumerable<Guid>>(ids,"Users with given ids not found"));
} }
@@ -54,6 +56,7 @@ public class UsersRepository : IUsersRepository
return await _context.Users return await _context.Users
.AsNoTracking() .AsNoTracking()
.Include(u => u.Invite)
.FirstOrDefaultAsync(x => x.Username == username) .FirstOrDefaultAsync(x => x.Username == username)
?? throw new NotFoundByKeyException<string>(username, "User with given username does not exist"); ?? throw new NotFoundByKeyException<string>(username, "User with given username does not exist");
} }
@@ -66,6 +69,7 @@ public class UsersRepository : IUsersRepository
return await _context.Users return await _context.Users
.AsNoTracking() .AsNoTracking()
.Where(x => usernames.Contains(x.Username)) .Where(x => usernames.Contains(x.Username))
.Include(u => u.Invite)
.ToListOrThrowIfEmpty(new NotFoundByKeyException<IEnumerable<string>>(usernames, "Users with given usernames not found")); .ToListOrThrowIfEmpty(new NotFoundByKeyException<IEnumerable<string>>(usernames, "Users with given usernames not found"));
} }
@@ -77,6 +81,7 @@ public class UsersRepository : IUsersRepository
return await _context.Users return await _context.Users
.AsNoTracking() .AsNoTracking()
.Where(u => createdDate == u.CreatedOn) .Where(u => createdDate == u.CreatedOn)
.Include(u => u.Invite)
.ToListOrThrowIfEmpty(new NotFoundByKeyException<DateOnly>(createdDate, "Users with given created date do not exist")); .ToListOrThrowIfEmpty(new NotFoundByKeyException<DateOnly>(createdDate, "Users with given created date do not exist"));
} }