SessionControllerTests

This commit is contained in:
Artemy
2025-07-24 18:29:35 +07:00
parent 6a6c3d513d
commit a0ef087110
4 changed files with 435 additions and 1 deletions
@@ -0,0 +1,278 @@
using AutoMapper;
using Govor.API.Controllers;
using Govor.Application.Interfaces.Infrastructure.Extensions;
using Govor.Application.Interfaces.UserSession;
using Govor.Contracts.DTOs;
using Govor.Core.Models;
using Govor.Data.Repositories.Exceptions;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging;
using Moq;
namespace Govor.API.Tests.Controllers;
[TestFixture]
[TestOf(typeof(SessionController))]
public class SessionControllerTests
{
private Mock<ILogger<SessionController>> _loggerMock;
private Mock<ICurrentUserService> _currentUserServiceMock;
private Mock<IUserSessionReader> _userSessionReaderMock;
private Mock<IUserSessionRevoker> _userSessionRevokerMock;
private Mock<IMapper> _mapperMock;
private SessionController _controller;
[SetUp]
public void SetUp()
{
_loggerMock = new Mock<ILogger<SessionController>>();
_currentUserServiceMock = new Mock<ICurrentUserService>();
_userSessionReaderMock = new Mock<IUserSessionReader>();
_userSessionRevokerMock = new Mock<IUserSessionRevoker>();
_mapperMock = new Mock<IMapper>();
_controller = new SessionController(
_loggerMock.Object,
_currentUserServiceMock.Object,
_userSessionReaderMock.Object,
_userSessionRevokerMock.Object,
_mapperMock.Object);
}
[Test]
public async Task GetAllSessions_Successful_ReturnsOkWithMappedSessions()
{
// Arrange
var userId = Guid.NewGuid();
var sessions = new List<UserSession> { new UserSession { Id = Guid.NewGuid(), UserId = userId } };
var sessionDtos = new List<SessionDto> { new SessionDto { Id = sessions[0].Id } };
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
_userSessionReaderMock.Setup(r => r.GetAllSessionsAsync(userId)).ReturnsAsync(sessions);
_mapperMock.Setup(m => m.Map<List<SessionDto>>(sessions)).Returns(sessionDtos);
// Act
var result = await _controller.GetAllSessions();
// Assert
Assert.That(result, Is.TypeOf<OkObjectResult>());
var okResult = result as OkObjectResult;
Assert.That(okResult.Value, Is.EqualTo(sessionDtos));
_loggerMock.VerifyNoOtherCalls();
}
[Test]
public async Task GetAllSessions_UnauthorizedAccess_ReturnsForbid()
{
// Arrange
var userId = Guid.NewGuid();
var exception = new UnauthorizedAccessException("Unauthorized");
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
_userSessionReaderMock.Setup(r => r.GetAllSessionsAsync(userId)).ThrowsAsync(exception);
// Act
var result = await _controller.GetAllSessions();
// Assert
Assert.That(result, Is.TypeOf<ForbidResult>());
_loggerMock.Verify(l => l.Log(
LogLevel.Warning,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
exception,
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
}
[Test]
public async Task GetAllSessions_UnexpectedError_Returns500()
{
// Arrange
var userId = Guid.NewGuid();
var exception = new Exception("Unexpected error");
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
_userSessionReaderMock.Setup(r => r.GetAllSessionsAsync(userId)).ThrowsAsync(exception);
// Act
var result = await _controller.GetAllSessions();
// Assert
Assert.That(result, Is.TypeOf<ObjectResult>());
var statusResult = result as ObjectResult;
Assert.That(statusResult.StatusCode, Is.EqualTo(500));
Assert.That(statusResult.Value, Is.EqualTo("Unexpected Error! Please try again later."));
_loggerMock.Verify(l => l.Log(
LogLevel.Error,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
exception,
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
}
[Test]
public async Task CloseSession_ValidSessionId_ReturnsOk()
{
// Arrange
var userId = Guid.NewGuid();
var sessionId = Guid.NewGuid();
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
// Act
var result = await _controller.CloseSession(sessionId);
// Assert
Assert.That(result, Is.TypeOf<OkResult>());
_userSessionRevokerMock.Verify(r => r.CloseSessionByIdAsync(sessionId, userId), Times.Once());
_loggerMock.VerifyNoOtherCalls();
}
[Test]
public async Task CloseSession_EmptySessionId_ReturnsBadRequest()
{
// Arrange
var sessionId = Guid.Empty;
// Act
var result = await _controller.CloseSession(sessionId);
// Assert
Assert.That(result, Is.TypeOf<BadRequestObjectResult>());
var badRequestResult = result as BadRequestObjectResult;
Assert.That(badRequestResult.Value, Is.EqualTo("Invalid sessionId."));
_userSessionRevokerMock.Verify(r => r.CloseSessionByIdAsync(It.IsAny<Guid>(), It.IsAny<Guid>()), Times.Never());
_loggerMock.VerifyNoOtherCalls();
}
[Test]
public async Task CloseSession_UnauthorizedAccess_ReturnsForbid()
{
// Arrange
var userId = Guid.NewGuid();
var sessionId = Guid.NewGuid();
var exception = new UnauthorizedAccessException("Unauthorized");
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
_userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception);
// Act
var result = await _controller.CloseSession(sessionId);
// Assert
Assert.That(result, Is.TypeOf<ForbidResult>());
_loggerMock.Verify(l => l.Log(
LogLevel.Warning,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
exception,
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
}
[Test]
public async Task CloseSession_NotFound_ReturnsNotFound()
{
// Arrange
var userId = Guid.NewGuid();
var sessionId = Guid.NewGuid();
var exception = new NotFoundException("Session not found");
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
_userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception);
// Act
var result = await _controller.CloseSession(sessionId);
// Assert
Assert.That(result, Is.TypeOf<NotFoundObjectResult>());
var notFoundResult = result as NotFoundObjectResult;
Assert.That(notFoundResult.Value, Is.EqualTo("Session not found"));
_loggerMock.Verify(l => l.Log(
LogLevel.Warning,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
exception,
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
}
[Test]
public async Task CloseSession_InvalidOperation_ReturnsBadRequest()
{
// Arrange
var userId = Guid.NewGuid();
var sessionId = Guid.NewGuid();
var exception = new InvalidOperationException("Invalid operation");
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
_userSessionRevokerMock.Setup(r => r.CloseSessionByIdAsync(sessionId, userId)).ThrowsAsync(exception);
// Act
var result = await _controller.CloseSession(sessionId);
// Assert
Assert.That(result, Is.TypeOf<BadRequestObjectResult>());
var badRequestResult = result as BadRequestObjectResult;
Assert.That(badRequestResult.Value, Is.EqualTo("Invalid operation"));
_loggerMock.Verify(l => l.Log(
LogLevel.Error,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
exception,
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
}
[Test]
public async Task CloseAllSessions_Successful_ReturnsOk()
{
// Arrange
var userId = Guid.NewGuid();
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
// Act
var result = await _controller.CloseAllSessions();
// Assert
Assert.That(result, Is.TypeOf<OkResult>());
_userSessionRevokerMock.Verify(r => r.CloseAllSessionsAsync(userId), Times.Once());
_loggerMock.VerifyNoOtherCalls();
}
[Test]
public async Task CloseAllSessions_UnauthorizedAccess_ReturnsForbid()
{
// Arrange
var userId = Guid.NewGuid();
var exception = new UnauthorizedAccessException("Unauthorized");
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
_userSessionRevokerMock.Setup(r => r.CloseAllSessionsAsync(userId)).ThrowsAsync(exception);
// Act
var result = await _controller.CloseAllSessions();
// Assert
Assert.That(result, Is.TypeOf<ForbidResult>());
_loggerMock.Verify(l => l.Log(
LogLevel.Warning,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
exception,
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
}
[Test]
public async Task CloseAllSessions_UnexpectedError_Returns500()
{
// Arrange
var userId = Guid.NewGuid();
var exception = new Exception("Unexpected error");
_currentUserServiceMock.Setup(s => s.GetCurrentUserId()).Returns(userId);
_userSessionRevokerMock.Setup(r => r.CloseAllSessionsAsync(userId)).ThrowsAsync(exception);
// Act
var result = await _controller.CloseAllSessions();
// Assert
Assert.That(result, Is.TypeOf<ObjectResult>());
var statusResult = result as ObjectResult;
Assert.That(statusResult.StatusCode, Is.EqualTo(500));
Assert.That(statusResult.Value, Is.EqualTo("Unexpected Error! Please try again later."));
_loggerMock.Verify(l => l.Log(
LogLevel.Error,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
exception,
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
}
}
@@ -34,7 +34,10 @@ public class UserSessionReaderTests
public async Task GetAllUserSessionsAsync_ShouldReturnAllUserSessions() public async Task GetAllUserSessionsAsync_ShouldReturnAllUserSessions()
{ {
// Arrange // Arrange
var sessios = _fixture.CreateMany<UserSession>().ToList(); var sessios = _fixture.Build<UserSession>()
.With(f => f.IsRevoked, false)
.CreateMany().ToList();
var userId = Guid.NewGuid(); var userId = Guid.NewGuid();
_mockUserSessionsRepository.Setup(f => f.GetByUserIdAsync(userId)) _mockUserSessionsRepository.Setup(f => f.GetByUserIdAsync(userId))
@@ -0,0 +1,152 @@
using Govor.Application.Services.UserSessions;
using Govor.Core.Models;
using Govor.Core.Repositories.UserSessionsRepository;
using Govor.Data.Repositories.Exceptions;
using Microsoft.Extensions.Logging;
using Moq;
namespace Govor.Application.Tests.Services.UserSessions;
[TestFixture]
[TestOf(typeof(UserSessionRevoker))]
public class UserSessionRevokerTests
{
private Mock<IUserSessionsRepository> _sessionsRepositoryMock;
private Mock<ILogger<UserSessionRevoker>> _loggerMock;
private UserSessionRevoker _revoker;
[SetUp]
public void SetUp()
{
_sessionsRepositoryMock = new Mock<IUserSessionsRepository>();
_loggerMock = new Mock<ILogger<UserSessionRevoker>>();
_revoker = new UserSessionRevoker(_sessionsRepositoryMock.Object, _loggerMock.Object);
}
[Test]
public async Task CloseSessionByIdAsync_ValidSessionAndUserId_SetsIsRevokedAndUpdates()
{
// Arrange
var sessionId = Guid.NewGuid();
var userId = Guid.NewGuid();
var session = new UserSession { Id = sessionId, UserId = userId, IsRevoked = false };
_sessionsRepositoryMock.Setup(r => r.GetByIdAsync(sessionId)).ReturnsAsync(session);
// Act
await _revoker.CloseSessionByIdAsync(sessionId, userId);
// Assert
Assert.That(session.IsRevoked, Is.True);
_sessionsRepositoryMock.Verify(r => r.UpdateAsync(session), Times.Once());
_loggerMock.VerifyNoOtherCalls();
}
[Test]
public void CloseSessionByIdAsync_UnauthorizedUser_ThrowsUnauthorizedAccessException()
{
// Arrange
var sessionId = Guid.NewGuid();
var userId = Guid.NewGuid();
var differentUserId = Guid.NewGuid();
var session = new UserSession { Id = sessionId, UserId = userId, IsRevoked = false };
_sessionsRepositoryMock.Setup(r => r.GetByIdAsync(sessionId)).ReturnsAsync(session);
// Act & Assert
var ex = Assert.ThrowsAsync<UnauthorizedAccessException>(() =>
_revoker.CloseSessionByIdAsync(sessionId, differentUserId));
Assert.That(ex.Message, Contains.Substring($"User {differentUserId} does not belong to this session {sessionId}"));
_loggerMock.Verify(l => l.Log(
LogLevel.Warning,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
It.IsAny<Exception>(),
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
_sessionsRepositoryMock.Verify(r => r.UpdateAsync(It.IsAny<UserSession>()), Times.Never());
}
[Test]
public async Task CloseSessionByIdAsync_AlreadyRevokedSession_DoesNotUpdate()
{
// Arrange
var sessionId = Guid.NewGuid();
var userId = Guid.NewGuid();
var session = new UserSession { Id = sessionId, UserId = userId, IsRevoked = true };
_sessionsRepositoryMock.Setup(r => r.GetByIdAsync(sessionId)).ReturnsAsync(session);
// Act
await _revoker.CloseSessionByIdAsync(sessionId, userId);
// Assert
_sessionsRepositoryMock.Verify(r => r.UpdateAsync(It.IsAny<UserSession>()), Times.Never());
_loggerMock.VerifyNoOtherCalls();
}
[Test]
public void CloseSessionByIdAsync_NonExistentSession_ThrowsNotFoundException()
{
// Arrange
var sessionId = Guid.NewGuid();
var userId = Guid.NewGuid();
_sessionsRepositoryMock.Setup(r => r.GetByIdAsync(sessionId))
.ThrowsAsync(new NotFoundByKeyException<Guid>(sessionId));
// Act & Assert
var ex = Assert.ThrowsAsync<NotFoundException>(() =>
_revoker.CloseSessionByIdAsync(sessionId, userId));
Assert.That(ex.Message, Is.EqualTo("Session not found"));
_loggerMock.Verify(l => l.Log(
LogLevel.Warning,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
It.IsAny<Exception>(),
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
_sessionsRepositoryMock.Verify(r => r.UpdateAsync(It.IsAny<UserSession>()), Times.Never());
}
[Test]
public async Task CloseAllSessionsAsync_MultipleSessions_RevokesNonRevokedSessions()
{
// Arrange
var userId = Guid.NewGuid();
var sessions = new List<UserSession>
{
new UserSession { Id = Guid.NewGuid(), UserId = userId, IsRevoked = false },
new UserSession { Id = Guid.NewGuid(), UserId = userId, IsRevoked = true },
new UserSession { Id = Guid.NewGuid(), UserId = userId, IsRevoked = false }
};
_sessionsRepositoryMock.Setup(r => r.GetByUserIdAsync(userId)).ReturnsAsync(sessions);
// Act
await _revoker.CloseAllSessionsAsync(userId);
// Assert
Assert.That(sessions[0].IsRevoked, Is.True);
Assert.That(sessions[1].IsRevoked, Is.True);
Assert.That(sessions[2].IsRevoked, Is.True);
_sessionsRepositoryMock.Verify(r => r.UpdateAsync(sessions[0]), Times.Once());
_sessionsRepositoryMock.Verify(r => r.UpdateAsync(sessions[2]), Times.Once());
_sessionsRepositoryMock.Verify(r => r.UpdateAsync(sessions[1]), Times.Never());
_loggerMock.VerifyNoOtherCalls();
}
[Test]
public void CloseAllSessionsAsync_NoSessions_ThrowsNotFoundException()
{
// Arrange
var userId = Guid.NewGuid();
_sessionsRepositoryMock.Setup(r => r.GetByUserIdAsync(userId))
.ThrowsAsync(new NotFoundByKeyException<Guid>(userId));
// Act & Assert
var ex = Assert.ThrowsAsync<NotFoundException>(() =>
_revoker.CloseAllSessionsAsync(userId));
Assert.That(ex.Message, Is.EqualTo("Session not found"));
_loggerMock.Verify(l => l.Log(
LogLevel.Warning,
It.IsAny<EventId>(),
It.IsAny<It.IsAnyType>(),
It.IsAny<Exception>(),
It.IsAny<Func<It.IsAnyType, Exception, string>>()), Times.Once());
_sessionsRepositoryMock.Verify(r => r.UpdateAsync(It.IsAny<UserSession>()), Times.Never());
}
}
+1
View File
@@ -7,4 +7,5 @@ public class GroupMembership
public Guid UserId { get; set; } public Guid UserId { get; set; }
public Guid? InvitationId { get; set; } public Guid? InvitationId { get; set; }
public bool IsBanned { get; set; } public bool IsBanned { get; set; }
public DateTime MemberSince { get; set; }
} }