mirror of
https://github.com/Govor-team/Govor.git
synced 2026-11-16 20:56:03 +00:00
Harden push notification delivery
Keep encrypted message content out of push payloads and improve cross-platform notification data. Add token registration validation and per-session unregister support, batch and deduplicate sends, remove only confirmed unregistered tokens, and protect queued retries with leases. Add delivery tests and document the push API and Firebase setup.
This commit is contained in:
@@ -13,20 +13,34 @@ namespace Govor.API.Controllers;
|
||||
[ApiController]
|
||||
[Authorize(Roles = "Admin,User")]
|
||||
[Route("api/groups/{groupId:guid}/reactions")]
|
||||
public class ChannelReactionsController(IMessageReactionService reactions, ICurrentUserService currentUser,
|
||||
IMapper mapper, IChatNotificationService notifier) : ControllerBase
|
||||
public class ChannelReactionsController(
|
||||
IMessageReactionService reactions,
|
||||
ICurrentUserService currentUser,
|
||||
IMapper mapper,
|
||||
IChatNotificationService notifier) : ControllerBase
|
||||
{
|
||||
[HttpGet]
|
||||
public async Task<IActionResult> Get(Guid groupId) => (await reactions.GetPolicyAsync(currentUser.GetCurrentUserId(), groupId))
|
||||
.Map(p => mapper.Map<ChannelReactionPolicyResponse>(p)).ToActionResult();
|
||||
public async Task<IActionResult> Get(Guid groupId) =>
|
||||
(await reactions.GetPolicyAsync(currentUser.GetCurrentUserId(), groupId))
|
||||
.Map(p => mapper.Map<ChannelReactionPolicyResponse>(p))
|
||||
.ToActionResult();
|
||||
|
||||
[HttpPut]
|
||||
public async Task<IActionResult> Set(Guid groupId, [FromBody] ChannelReactionPolicyRequest request)
|
||||
{
|
||||
var result = await reactions.SetPolicyAsync(currentUser.GetCurrentUserId(), groupId, request.Mode, request.ReactionIds);
|
||||
if (result.IsFailure) return result.ToActionResult();
|
||||
var result = await reactions.SetPolicyAsync(
|
||||
currentUser.GetCurrentUserId(),
|
||||
groupId,
|
||||
request.Mode,
|
||||
request.ReactionIds);
|
||||
|
||||
if (result.IsFailure)
|
||||
return result.ToActionResult();
|
||||
|
||||
var response = mapper.Map<ChannelReactionPolicyResponse>(result.Value);
|
||||
|
||||
await notifier.NotifyChannelReactionPolicyChangedAsync(response);
|
||||
|
||||
return Ok(response);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -112,7 +112,7 @@ public class ProfileController : ControllerBase
|
||||
}
|
||||
|
||||
[HttpGet("download/{id}")]
|
||||
public async Task<IActionResult> DowloadProfileByUserId(Guid id)
|
||||
public async Task<IActionResult> DownloadProfileByUserId(Guid id)
|
||||
{
|
||||
try
|
||||
{
|
||||
|
||||
@@ -15,15 +15,18 @@ public class PushTokensController : Controller
|
||||
private readonly ICurrentUserService _currentUser;
|
||||
private readonly ICurrentUserSessionService _currentSession;
|
||||
private readonly IPushTokenService _pushTokenService;
|
||||
private readonly ILogger<PushTokensController> _logger;
|
||||
|
||||
public PushTokensController(
|
||||
IPushTokenService pushTokenService,
|
||||
ICurrentUserService currentUser,
|
||||
ICurrentUserSessionService currentSession)
|
||||
ICurrentUserSessionService currentSession,
|
||||
ILogger<PushTokensController> logger)
|
||||
{
|
||||
_pushTokenService = pushTokenService;
|
||||
_currentUser = currentUser;
|
||||
_currentSession = currentSession;
|
||||
_logger = logger;
|
||||
}
|
||||
|
||||
[HttpPost("pushes/token/register")]
|
||||
@@ -31,30 +34,22 @@ public class PushTokensController : Controller
|
||||
{
|
||||
try
|
||||
{
|
||||
if (!ModelState.IsValid)
|
||||
return BadRequest(ModelState);
|
||||
|
||||
if (string.IsNullOrEmpty(req.Token) || string.IsNullOrWhiteSpace(req.Platform))
|
||||
return BadRequest(ModelState);
|
||||
|
||||
var currentId = _currentUser.GetCurrentUserId();
|
||||
var currentSessionId = _currentSession.GetUserSessionId();
|
||||
|
||||
var result = await _pushTokenService.AddOrUpdateTokenAsync(
|
||||
userId: currentId,
|
||||
sessionId: currentSessionId,
|
||||
token: req.Token,
|
||||
platform: req.Platform);
|
||||
|
||||
return result.ToActionResult();
|
||||
}
|
||||
catch (ArgumentException ex)
|
||||
{
|
||||
return BadRequest(ex.Message);
|
||||
var result = await _pushTokenService.AddOrUpdateTokenAsync(
|
||||
_currentUser.GetCurrentUserId(), _currentSession.GetUserSessionId(), req.Token, req.Platform);
|
||||
return result.ToActionResult();
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
return StatusCode(500, "Unexpected Error! Please try again later.");
|
||||
_logger.LogError(ex, "Failed to register push token for the current session");
|
||||
return Problem(statusCode: StatusCodes.Status500InternalServerError,
|
||||
detail: "Push token registration failed. Please try again later.");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
[HttpDelete("pushes/token")]
|
||||
public async Task<IActionResult> UnregisterToken()
|
||||
{
|
||||
var result = await _pushTokenService.DeactivateTokenBySessionAsync(_currentSession.GetUserSessionId());
|
||||
return result.ToActionResult();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user