Harden push notification delivery

Keep encrypted message content out of push payloads and improve cross-platform notification data. Add token registration validation and per-session unregister support, batch and deduplicate sends, remove only confirmed unregistered tokens, and protect queued retries with leases. Add delivery tests and document the push API and Firebase setup.
This commit is contained in:
Artemy
2026-10-17 19:53:34 +07:00
parent 9aa7e017e2
commit e060b2bcbb
21 changed files with 16353 additions and 132 deletions
+29 -1
View File
@@ -75,7 +75,7 @@ public class NotificationTests
Assert.That(_events.Single(e => e.Method == ChatHubConstants.MessageSent).Groups,
Is.EqualTo(new[] { ChatHubConstants.GetSessionGroup(_aliceSession) }));
_push.Verify(p => p.SendToUsersAsync(It.Is<IEnumerable<Guid>>(ids => ids.SequenceEqual(new[] { _db.Bob })),
"Alice", "hello", "chat_messages", $"chat_{_db.ChatId}",
"Alice", "New message", "chat_messages", $"chat_{_db.ChatId}",
It.Is<Dictionary<string, string>?>(data => data != null && data["messageId"] == message.MessageId.ToString())), Times.Once);
}
@@ -99,6 +99,34 @@ public class NotificationTests
It.IsAny<Dictionary<string, string>?>()), Times.Once);
}
[Test]
public async Task MessageReadBeforeRetrySuppressesPush()
{
var saved = _db.AddMessage();
_db.Context.MessageViews.Add(new MessageView
{ Id = Guid.NewGuid(), MessageId = saved.Id, UserId = _db.Bob, ViewedAt = DateTime.UtcNow });
await _db.Context.SaveChangesAsync();
var message = Message();
message.MessageId = saved.Id;
Assert.That(await _notifier.DeliverPushAsync(message), Is.True);
_push.Verify(p => p.SendToUsersAsync(It.IsAny<IEnumerable<Guid>>(), It.IsAny<string>(), It.IsAny<string>(),
It.IsAny<string>(), It.IsAny<string>(), It.IsAny<Dictionary<string, string>?>()), Times.Never);
}
[Test]
public async Task PushDoesNotExposeContentAndKeepsRoutingData()
{
var message = Message();
message.EncryptedContent = "sensitive plaintext or ciphertext";
Assert.That(await _notifier.DeliverPushAsync(message), Is.True);
_push.Verify(p => p.SendToUsersAsync(It.IsAny<IEnumerable<Guid>>(), "Alice", "New message",
"chat_messages", $"chat_{_db.ChatId}", It.Is<Dictionary<string, string>?>(data => data != null &&
data["type"] == "chat_message" && data["senderId"] == _db.Alice.ToString() &&
data["chatId"] == _db.ChatId.ToString() && data["isGroup"] == "false" &&
data["messageId"] == message.MessageId.ToString() && !data.Values.Contains(message.EncryptedContent))), Times.Once);
}
[Test]
public async Task SignalRFailureStillAttemptsPushAndProviderFailureDoesNotFailSavedSend()
{