X11: Prevent BadWindow when creating small windows

mirror of https://github.com/glfw/glfw.git synced 2026-09-23 00:59:48 +00:00

The glfwCreateWindow function ensures that the width and height are
at least greater or equal than zero, but on X11 it is invalid to
create a window with dimensions that equal zero, see [1].

This change ensures that the dimensions passed to XCreateWindow are
at least 1 by 1.

This issue was detected in [2], where a call to glfwCreateWindow
was done to request a 1x1 window, with a _glfw.x11.contentScaleX of
less than 1.0 (0.958333) this results in a request for a 0x0 window
which then causes an BadWindow error from X11.

[1]: https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/e003f52661679e95b51ff24e317af6178fe2a73c/specs/libX11/CH03.xml#L1333-1337
[2]: https://github.com/WerWolv/ImHex/pull/2390

This commit is contained in:

Ivor Wanders

2025-08-09 11:13:20 -04:00

committed by

Doug Binks

parent 8e15281d34

commit 6de70d8252

3 changed files with 7 additions and 0 deletions

									
										CONTRIBUTORS.md
									
		+1
		
												View File
												
				@@ -282,6 +282,7 @@ video tutorials.

				 - Corentin Wallez

				 - Torsten Walluhn

				 - Patrick Walton

				 - Ivor Wanders

				 - Jim Wang

				 - Xo Wang

				 - Andre Weissflog