Expand server tests and enforce coverage

Consolidate server tests under tests/, upgrade them to .NET 10, and add CI coverage thresholds and reports. Expand API and application boundary coverage while fixing related issues in media handling, friend blocking, session crypto, presence, username validation, and local storage.
This commit is contained in:
Artemy
2026-10-24 15:30:32 +07:00
parent 33550d4fc9
commit 2d99c57a3b
161 changed files with 5515 additions and 8419 deletions
@@ -0,0 +1,165 @@
using AutoMapper;
using Govor.API.Controllers;
using Govor.API.Controllers.AdminStuff;
using Govor.API.Hubs.Infrastructure;
using Govor.Application.Groups;
using Govor.Application.Infrastructure.Extensions;
using Govor.Application.Messages;
using Govor.Application.Reactions;
using Govor.Contracts.Requests;
using Govor.Domain.Common;
using Govor.Domain.Models;
using Govor.Domain.Models.Messages;
using Govor.Tests.Shared;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Moq;
namespace Govor.API.Tests.Integration.Controllers;
[TestFixture]
public class GroupControllerBoundaryTests
{
[Test]
public async Task MembersAndInvitationsMapContractsAndRevokeUsesCurrentActor()
{
var actor = Guid.NewGuid(); var group = Guid.NewGuid(); var invitation = Guid.NewGuid();
var user = new Mock<ICurrentUserService>(); user.Setup(x => x.GetCurrentUserId()).Returns(actor);
var groups = new Mock<IGroupManagementService>(); var mapper = new Mock<IMapper>();
var members = new List<GroupMember>(); var invitations = new List<GroupInvitation>();
var memberDtos = new List<Govor.Contracts.Responses.GroupMemberResponse>();
var invitationDtos = new List<Govor.Contracts.Responses.GroupInvitationResponse>();
groups.Setup(x => x.MembersAsync(actor, group, true, 3, 7)).ReturnsAsync(members);
groups.Setup(x => x.InvitationsAsync(actor, group)).ReturnsAsync(invitations);
groups.Setup(x => x.RevokeInvitationAsync(actor, group, invitation)).ReturnsAsync(Result.Success());
mapper.Setup(x => x.Map<List<Govor.Contracts.Responses.GroupMemberResponse>>(members)).Returns(memberDtos);
mapper.Setup(x => x.Map<List<Govor.Contracts.Responses.GroupInvitationResponse>>(invitations)).Returns(invitationDtos);
var controller = new GroupsController(groups.Object, user.Object, mapper.Object, null!, Mock.Of<IMessageRemovingService>(), Mock.Of<IChatNotificationService>(), Mock.Of<IGroupAvatarService>());
Assert.That(((OkObjectResult)await controller.Members(group, true, 3, 7)).Value, Is.SameAs(memberDtos));
Assert.That(((OkObjectResult)await controller.Invitations(group)).Value, Is.SameAs(invitationDtos));
Assert.That(((StatusCodeResult)await controller.RevokeInvitation(group, invitation)).StatusCode, Is.EqualTo(204));
groups.Verify(x => x.RevokeInvitationAsync(actor, group, invitation), Times.Once);
}
[TestCase(false)]
[TestCase(true)]
public async Task RequiredChannelReadMapsSettingsAndFailuresPreventMutation(bool failure)
{
var actor = Guid.NewGuid();
var groups = new Mock<IGroupManagementService>();
var user = new Mock<ICurrentUserService>();
user.Setup(x => x.GetCurrentUserId()).Returns(actor);
var settings = new ServerCommunitySettings { RequiredChannelId = Guid.NewGuid(), AllowLeave = true };
groups.Setup(x => x.GetRequiredChannelAsync(actor)).ReturnsAsync(failure
? Result.Failure<ServerCommunitySettings>(Error.Forbidden("denied", "denied"))
: settings);
var notifier = new Mock<IChatNotificationService>(MockBehavior.Strict);
var controller = new RequiredChannelController(groups.Object, user.Object, notifier.Object);
var response = (ObjectResult)await controller.Get();
Assert.That(response.StatusCode, Is.EqualTo(failure ? 403 : 200));
if (failure)
{
Assert.That(((ObjectResult)await controller.Set(new())).StatusCode, Is.EqualTo(403));
groups.Verify(x => x.SetRequiredChannelAsync(It.IsAny<Guid>(), It.IsAny<Guid?>(), It.IsAny<bool>()),
Times.Never);
}
else
{
Assert.That(response.Value!.GetType().GetProperty("channelId")!.GetValue(response.Value),
Is.EqualTo(settings.RequiredChannelId));
}
notifier.VerifyNoOtherCalls();
}
[Test]
public async Task GroupReadsForwardQueryAndPaging()
{
using var db = new TestDatabase();
var groups = new Mock<IGroupManagementService>();
var user = new Mock<ICurrentUserService>();
user.Setup(x => x.GetCurrentUserId()).Returns(db.Alice);
var mapper = new Mock<IMapper>();
var list = new List<GroupSummary>();
var mapped = new List<Govor.Contracts.Responses.GroupResponse>();
groups.Setup(x => x.MineAsync(db.Alice, 3, 7)).ReturnsAsync(list);
groups.Setup(x => x.SearchAsync(db.Alice, "needle", 4, 8)).ReturnsAsync(list);
mapper.Setup(x => x.Map<List<Govor.Contracts.Responses.GroupResponse>>(list)).Returns(mapped);
var controller = new GroupsController(groups.Object, user.Object, mapper.Object, db.Context,
Mock.Of<IMessageRemovingService>(), Mock.Of<IChatNotificationService>(), Mock.Of<IGroupAvatarService>());
Assert.That(((OkObjectResult)await controller.Mine(3, 7)).Value, Is.SameAs(mapped));
Assert.That(((OkObjectResult)await controller.Search("needle", 4, 8)).Value, Is.SameAs(mapped));
groups.Verify(x => x.MineAsync(db.Alice, 3, 7), Times.Once);
groups.Verify(x => x.SearchAsync(db.Alice, "needle", 4, 8), Times.Once);
}
[TestCase(false)]
[TestCase(true)]
public async Task AvatarRemovalNotifiesOnlyAfterSuccess(bool failure)
{
using var db = new TestDatabase();
var user = new Mock<ICurrentUserService>();
user.Setup(x => x.GetCurrentUserId()).Returns(db.Alice);
var avatars = new Mock<IGroupAvatarService>();
avatars.Setup(x => x.RemoveAsync(db.Alice, db.ChatId))
.ReturnsAsync(failure ? Result.Failure(Error.Forbidden("denied", "denied")) : Result.Success());
var notifier = new Mock<IChatNotificationService>();
var controller = new GroupsController(Mock.Of<IGroupManagementService>(), user.Object, Mock.Of<IMapper>(),
db.Context, Mock.Of<IMessageRemovingService>(), notifier.Object, avatars.Object);
var response = await controller.RemoveAvatar(db.ChatId);
Assert.That(failure ? ((ObjectResult)response).StatusCode : ((StatusCodeResult)response).StatusCode,
Is.EqualTo(failure ? 403 : 204));
notifier.Verify(x => x.NotifyGroupProfileChangedAsync(db.ChatId), failure ? Times.Never() : Times.Once());
}
[TestCase(0)]
[TestCase(2_097_153)]
public async Task AvatarLengthRejectsBeforeService(int size)
{
var file = new Mock<IFormFile>();
file.SetupGet(x => x.Length).Returns(size);
var avatars = new Mock<IGroupAvatarService>(MockBehavior.Strict);
var controller = new GroupsController(Mock.Of<IGroupManagementService>(), Mock.Of<ICurrentUserService>(),
Mock.Of<IMapper>(), null!, Mock.Of<IMessageRemovingService>(), Mock.Of<IChatNotificationService>(),
avatars.Object);
Assert.That(await controller.UploadAvatar(Guid.NewGuid(), new() { File = file.Object }),
Is.TypeOf<BadRequestObjectResult>());
avatars.VerifyNoOtherCalls();
}
[Test]
public async Task FailedGroupMessageRemovalNeverNotifies()
{
using var db = new TestDatabase();
var message = db.AddMessage(type: RecipientType.Group);
var user = new Mock<ICurrentUserService>();
user.Setup(x => x.GetCurrentUserId()).Returns(db.Alice);
var remover = new Mock<IMessageRemovingService>();
remover.Setup(x => x.DeleteMessageAsync(It.IsAny<Govor.Application.Messages.Parameters.DeleteMessage>()))
.ReturnsAsync(Result.Failure<Message>(Error.Forbidden("denied", "denied")));
var notifier = new Mock<IChatNotificationService>(MockBehavior.Strict);
var controller = new GroupsController(Mock.Of<IGroupManagementService>(), user.Object, Mock.Of<IMapper>(),
db.Context, remover.Object, notifier.Object, Mock.Of<IGroupAvatarService>());
Assert.That(((ObjectResult)await controller.RemoveMessage(db.ChatId, message.Id)).StatusCode, Is.EqualTo(403));
notifier.VerifyNoOtherCalls();
}
[Test]
public async Task ChannelReactionReadMapsPolicy()
{
var actor = Guid.NewGuid();
var group = Guid.NewGuid();
var user = new Mock<ICurrentUserService>();
user.Setup(x => x.GetCurrentUserId()).Returns(actor);
var service = new Mock<IMessageReactionService>();
var policy = new ChannelReactionPolicy(group, Govor.Domain.Models.Reactions.ChannelReactionMode.All, 2, []);
service.Setup(x => x.GetPolicyAsync(actor, group)).ReturnsAsync(policy);
var mapper = new Mock<IMapper>();
var dto = new Govor.Contracts.Responses.SignalR.ChannelReactionPolicyResponse();
mapper.Setup(x => x.Map<Govor.Contracts.Responses.SignalR.ChannelReactionPolicyResponse>(policy)).Returns(dto);
var controller = new ChannelReactionsController(service.Object, user.Object, mapper.Object,
Mock.Of<IChatNotificationService>());
Assert.That(((OkObjectResult)await controller.Get(group)).Value, Is.SameAs(dto));
}
}
@@ -0,0 +1,89 @@
using Govor.API.Common.Extensions;
using Govor.API.Common.Mapping;
using Govor.API.Filters;
using Govor.Application.Profiles;
using Govor.Application.Users.UserOnlineStatus;
using Govor.Contracts.DTOs;
using Govor.Contracts.Responses.SignalR;
using Govor.Domain.Common;
using Govor.Domain.Models.Users;
using Govor.Tests.Shared;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using System.Security.Claims;
namespace Govor.API.Tests.Integration.Filters;
[TestFixture]
public class HubExceptionFilterTests
{
public sealed class TestHub : Hub
{
public Task<HubResult<int>> Typed() => Task.FromResult(HubResult<int>.Ok(7));
public Task Plain() => Task.CompletedTask;
public int Synchronous() => 7;
}
[TestCase(0, HubResultStatus.BadRequest)]
[TestCase(1, HubResultStatus.Unauthorized)]
[TestCase(2, HubResultStatus.NotFound)]
[TestCase(3, HubResultStatus.Conflict)]
[TestCase(4, HubResultStatus.ServerError)]
public async Task ActiveSessionExceptionsAreMappedWithoutLeakingServerErrors(int kind, HubResultStatus expected)
{
using var db = new TestDatabase();
var sid = Guid.NewGuid();
db.Context.UserSessions.Add(new()
{
Id = sid, UserId = db.Alice, DeviceInfo = "test", RefreshTokenHash = "hash", CreatedAt = DateTime.UtcNow,
ExpiresAt = DateTime.UtcNow.AddDays(1)
});
db.Context.SaveChanges();
var caller = new Mock<HubCallerContext>();
caller.SetupGet(x => x.User).Returns(new ClaimsPrincipal(new ClaimsIdentity(
new[] { new Claim("userId", db.Alice.ToString()), new Claim("sid", sid.ToString()) }, "test")));
using var hub = new TestHub();
var invocation = new HubInvocationContext(caller.Object, Mock.Of<IServiceProvider>(), hub,
typeof(TestHub).GetMethod(nameof(TestHub.Typed))!, []);
Exception error = kind switch
{
0 => new ArgumentException("invalid"), 1 => new UnauthorizedAccessException("denied"),
2 => new KeyNotFoundException("missing"), 3 => new InvalidOperationException("conflict"),
_ => new Exception("private detail")
};
var result =
(HubResult<int>)(await new HubExceptionFilter(NullLogger<HubExceptionFilter>.Instance, db.Context)
.InvokeMethodAsync(invocation, _ => throw error))!;
Assert.That(result.Status, Is.EqualTo(expected));
if (kind == 4) Assert.That(result.ErrorMessage, Is.EqualTo("Internal server error"));
caller.Verify(x => x.Abort(), Times.Never);
}
[TestCase(nameof(TestHub.Typed))]
[TestCase(nameof(TestHub.Plain))]
[TestCase(nameof(TestHub.Synchronous))]
public async Task MissingSessionAbortsAndHandlesReturnShapes(string method)
{
using var db = new TestDatabase();
using var hub = new TestHub();
var caller = new Mock<HubCallerContext>();
caller.SetupGet(x => x.User).Returns(new ClaimsPrincipal());
var invocation = new HubInvocationContext(caller.Object, Mock.Of<IServiceProvider>(), hub,
typeof(TestHub).GetMethod(method)!, []);
var invoked = false;
var result =
await new HubExceptionFilter(NullLogger<HubExceptionFilter>.Instance, db.Context).InvokeMethodAsync(
invocation, _ =>
{
invoked = true;
return ValueTask.FromResult<object?>(7);
});
Assert.That(invoked, Is.False);
caller.Verify(x => x.Abort(), Times.Once);
if (method == nameof(TestHub.Typed))
Assert.That(((HubResult<int>)result!).Status, Is.EqualTo(HubResultStatus.Unauthorized));
else Assert.That(result, Is.Null);
}
}
@@ -0,0 +1,35 @@
using Govor.API.Hubs.Infrastructure;
using Govor.Application.Infrastructure.Common;
using Govor.Tests.Shared;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Integration.Notifications;
[TestFixture]
public class ChatPushWorkerTests
{
private sealed class Worker(IServiceScopeFactory factory):ChatPushWorker(factory,NullLogger<ChatPushWorker>.Instance)
{
public Task Run(CancellationToken token)=>ExecuteAsync(token);
}
[TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)]
public async Task WorkerDisposesScopesAndStopsOnCancellationIncludingFailurePaths(int mode)
{
using var db=new TestDatabase();using var cancellation=new CancellationTokenSource();
var factory=new Mock<IServiceScopeFactory>();var scope=new Mock<IServiceScope>();var provider=new Mock<IServiceProvider>();
var clock=new Mock<INowDateTimeProvider>();clock.SetupGet(x=>x.Now).Returns(DateTime.UtcNow);
var dispatcher=new ChatPushDispatcher(db.Context,Mock.Of<IChatNotificationService>(),clock.Object);
scope.SetupGet(x=>x.ServiceProvider).Returns(provider.Object);provider.Setup(x=>x.GetService(typeof(ChatPushDispatcher))).Returns(dispatcher);
scope.Setup(x=>x.Dispose()).Callback(()=>cancellation.Cancel());
if(mode==0) cancellation.Cancel();
if(mode is 1 or 2) factory.Setup(x=>x.CreateScope()).Returns(()=>{cancellation.Cancel();throw mode==1?new OperationCanceledException(cancellation.Token):new InvalidOperationException("scope failure");});
else factory.Setup(x=>x.CreateScope()).Returns(scope.Object);
using var worker=new Worker(factory.Object);
await worker.Run(cancellation.Token).WaitAsync(TimeSpan.FromSeconds(5));
factory.Verify(x=>x.CreateScope(),mode==0?Times.Never():Times.Once());
scope.Verify(x=>x.Dispose(),mode==3?Times.Once():Times.Never());
}
}
@@ -0,0 +1,93 @@
using Govor.API.Hubs;
using Govor.API.Hubs.Infrastructure;
using Govor.Application.PrivateUserChats;
using Govor.Application.Profiles;
using Govor.Application.PushNotifications;
using Govor.Contracts.Responses.SignalR;
using Govor.Domain.Common;
using Govor.Domain.Models;
using Govor.Domain.Models.Messages;
using Govor.Tests.Shared;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using Govor.Application.Infrastructure.Common;
using Microsoft.EntityFrameworkCore;
namespace Govor.API.Tests.Integration.Notifications;
[TestFixture]
public class NotificationBoundaryTests
{
[TestCase(true)]
[TestCase(false)]
public async Task MissingChatIsAcknowledgedButTemporaryLookupFailureRequiresRetry(bool missing)
{
using var db = new TestDatabase();
var chats = new Mock<IUserPrivateChatsGetterService>();
chats.Setup(x => x.GetPrivateChatAsync(db.ChatId)).ReturnsAsync(Result.Failure<PrivateChat>(
missing ? Error.NotFound("missing", "missing") : Error.ServerError("database", "unavailable")));
var push = new Mock<IPushNotificationService>(MockBehavior.Strict);
var notifier = new ChatNotificationService(Mock.Of<IHubContext<ChatsHub>>(), push.Object, chats.Object,
Mock.Of<IProfileService>(), db.Context, NullLogger<ChatNotificationService>.Instance);
Assert.That(await notifier.DeliverPushAsync(new() { RecipientId = db.ChatId, RecipientType = RecipientType.User }), Is.EqualTo(missing));
push.VerifyNoOtherCalls();
}
[Test]
public async Task CancellationDuringPushLeavesClaimForLaterRetry()
{
using var db = new TestDatabase();
using var cancellation = new CancellationTokenSource();
var message = db.AddMessage();
var now = DateTime.UtcNow;
db.Context.ChatPushNotifications.Add(new() { MessageId = message.Id, NextAttemptAt = now.AddMinutes(-1) });
await db.Context.SaveChangesAsync();
var notifier = new Mock<IChatNotificationService>();
notifier.Setup(x => x.DeliverPushAsync(It.IsAny<UserMessageResponse>())).Returns(() =>
{
cancellation.Cancel();
throw new OperationCanceledException(cancellation.Token);
});
var clock = new Mock<INowDateTimeProvider>();
clock.SetupGet(x => x.Now).Returns(now);
var dispatcher = new ChatPushDispatcher(db.Context, notifier.Object, clock.Object);
Assert.ThrowsAsync<OperationCanceledException>(() => dispatcher.DispatchAsync(cancellation.Token));
var pending = await db.Context.ChatPushNotifications.AsNoTracking().SingleAsync();
Assert.That(pending.Attempts, Is.EqualTo(1));
Assert.That(pending.NextAttemptAt, Is.GreaterThan(now));
}
[TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)] [TestCase(4)]
public async Task PushHandlesNoRecipientsReadersMissingProfileAndProviderFailures(int mode)
{
using var db=new TestDatabase();var message=db.AddMessage();
if(mode==1){db.Context.MessageViews.Add(new(){Id=Guid.NewGuid(),MessageId=message.Id,UserId=db.Bob,ViewedAt=DateTime.UtcNow});db.Context.SaveChanges();}
var chats=new Mock<IUserPrivateChatsGetterService>();chats.Setup(x=>x.GetPrivateChatAsync(db.ChatId)).ReturnsAsync(mode==0?new PrivateChat{UserAId=db.Alice,UserBId=db.Alice}:new PrivateChat{UserAId=db.Alice,UserBId=db.Bob});
var profiles=new Mock<IProfileService>();profiles.Setup(x=>x.GetUserProfileAsync(db.Alice)).ReturnsAsync(Result.Failure<UserProfile>(Error.NotFound("missing","missing")));
var push=new Mock<IPushNotificationService>();
if(mode==4) push.Setup(x=>x.SendToUsersAsync(It.IsAny<IEnumerable<Guid>>(),It.IsAny<string>(),It.IsAny<string>(),It.IsAny<string>(),It.IsAny<string>(),It.IsAny<Dictionary<string,string>?>())).ThrowsAsync(new Exception("transport"));
else push.Setup(x=>x.SendToUsersAsync(It.IsAny<IEnumerable<Guid>>(),It.IsAny<string>(),It.IsAny<string>(),It.IsAny<string>(),It.IsAny<string>(),It.IsAny<Dictionary<string,string>?>())).ReturnsAsync(mode==3?Result.Failure(Error.ServerError("push","failure")):Result.Success());
var notifier=new ChatNotificationService(Mock.Of<IHubContext<ChatsHub>>(),push.Object,chats.Object,profiles.Object,db.Context,NullLogger<ChatNotificationService>.Instance);
var result=await notifier.DeliverPushAsync(new(){MessageId=message.Id,SenderId=db.Alice,RecipientId=db.ChatId,RecipientType=RecipientType.User});
Assert.That(result,Is.EqualTo(mode<3));
if(mode<2){push.VerifyNoOtherCalls();profiles.VerifyNoOtherCalls();}
else push.Verify(x=>x.SendToUsersAsync(It.Is<IEnumerable<Guid>>(ids=>ids.SequenceEqual(new[]{db.Bob})),"Govor","New message","chat_messages",$"chat_{db.ChatId}",It.IsAny<Dictionary<string,string>?>()),Times.Once);
}
[Test]
public async Task LegacyReadAndRemovalEventsReachActiveSessionAndMissingChatIsIgnored()
{
using var db=new TestDatabase();var sid=Guid.NewGuid();db.Context.UserSessions.Add(new(){Id=sid,UserId=db.Alice,ExpiresAt=DateTime.UtcNow.AddDays(1)});db.Context.SaveChanges();
var proxy=new Mock<IClientProxy>();var clients=new Mock<IHubClients>();clients.Setup(x=>x.Groups(It.IsAny<IReadOnlyList<string>>())).Returns(proxy.Object);
var hub=new Mock<IHubContext<ChatsHub>>();hub.SetupGet(x=>x.Clients).Returns(clients.Object);
var chats=new Mock<IUserPrivateChatsGetterService>();chats.Setup(x=>x.GetPrivateChatAsync(db.ChatId)).ReturnsAsync(new PrivateChat{UserAId=db.Alice,UserBId=db.Bob});
var notifier=new ChatNotificationService(hub.Object,Mock.Of<IPushNotificationService>(),chats.Object,Mock.Of<IProfileService>(),db.Context,NullLogger<ChatNotificationService>.Instance);
await notifier.NotifyMessageWasReadAsync(new(){ViewId=Guid.NewGuid(),MessageId=Guid.NewGuid(),ReaderId=db.Alice,WhenWas=DateTime.UtcNow,RecipientId=db.ChatId,RecipientType=RecipientType.User});
await notifier.NotifyMessageRemovedAsync(new(){MessageId=Guid.NewGuid(),SenderId=db.Alice,RecipientId=db.ChatId,RecipientType=RecipientType.User});
await notifier.NotifyMessageEditedAsync(new(){MessageId=Guid.NewGuid(),EditorId=db.Alice,RecipientId=db.ChatId,RecipientType=RecipientType.User});
foreach(var method in new[]{"MessageReaded","MessageRead","MessageRemoved","MessageEdited"})proxy.Verify(x=>x.SendCoreAsync(method,It.IsAny<object?[]>(),default),Times.Once);
chats.Setup(x=>x.GetPrivateChatAsync(db.ChatId)).ReturnsAsync(Result.Failure<PrivateChat>(Error.NotFound("missing","missing")));
proxy.Invocations.Clear();await notifier.NotifyChatReadAsync(new(){ChatId=db.ChatId,RecipientType=RecipientType.User});proxy.VerifyNoOtherCalls();
}
}