Expand server tests and enforce coverage

Consolidate server tests under tests/, upgrade them to .NET 10, and add CI coverage thresholds and reports. Expand API and application boundary coverage while fixing related issues in media handling, friend blocking, session crypto, presence, username validation, and local storage.
This commit is contained in:
Artemy
2026-10-24 15:30:32 +07:00
parent 33550d4fc9
commit 2d99c57a3b
161 changed files with 5515 additions and 8419 deletions
@@ -0,0 +1,38 @@
using Govor.API.Common.Extensions;
using Govor.Application.PushNotifications;
using Govor.Application.PushNotifications.Providers;
using Govor.Application.Storage;
using Govor.Domain;
using Microsoft.AspNetCore.Hosting;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Moq;
namespace Govor.API.Tests.Unit.Common;
[TestFixture]
public class ConfigurationTests
{
[TestCase(false)] [TestCase(true)]
public void DatabaseConfigurationUsesPostgresAndHonorsDetailedErrors(bool detailed)
{
var config=new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?>{{"ConnectionStrings:GovorDbContext","Host=localhost;Database=configuration_tests;Username=tests"},{"Database:EnableDetailedErrors",detailed.ToString()}}).Build();
var services=new ServiceCollection();services.AddGovorDbContext(config);
using var provider=services.BuildServiceProvider();using var scope=provider.CreateScope();var db=scope.ServiceProvider.GetRequiredService<GovorDbContext>();
Assert.That(db.Database.ProviderName,Is.EqualTo("Npgsql.EntityFrameworkCore.PostgreSQL"));
Assert.That(db.Database.CreateExecutionStrategy().RetriesOnFailure,Is.True);
var options=scope.ServiceProvider.GetRequiredService<DbContextOptions<GovorDbContext>>();
Assert.That(options.FindExtension<Microsoft.EntityFrameworkCore.Infrastructure.CoreOptionsExtension>()!.DetailedErrorsEnabled,Is.EqualTo(detailed));
}
[Test]
public void DisabledFirebaseAndLocalStorageResolveThroughProductionRegistration()
{
var services=new ServiceCollection();services.AddLogging();
services.AddSingleton<IConfiguration>(new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string,string?>{{"Firebase:Enabled","false"}}).Build());
var environment=new Mock<IWebHostEnvironment>();environment.SetupGet(x=>x.ContentRootPath).Returns(Path.GetTempPath());services.AddSingleton(environment.Object);
services.AddServices();using var provider=services.BuildServiceProvider();using var scope=provider.CreateScope();
Assert.That(scope.ServiceProvider.GetRequiredService<IStorageService>(),Is.TypeOf<LocalStorageService>());
Assert.That(scope.ServiceProvider.GetRequiredService<IPushNotificationProvider>(),Is.TypeOf<NullPushProvider>());
}
}
@@ -0,0 +1,65 @@
using Govor.API.Common.Extensions;
using Govor.API.Common.Mapping;
using Govor.API.Filters;
using Govor.Application.Profiles;
using Govor.Application.Users.UserOnlineStatus;
using Govor.Contracts.DTOs;
using Govor.Contracts.Responses.SignalR;
using Govor.Domain.Common;
using Govor.Domain.Models.Users;
using Govor.Tests.Shared;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using System.Security.Claims;
namespace Govor.API.Tests.Unit.Common;
[TestFixture]
public class ErrorAndMappingTests
{
[TestCase(ErrorType.NotFound, 404, "Not Found")]
[TestCase(ErrorType.Validation, 400, "Validation Error")]
[TestCase(ErrorType.Conflict, 409, "Conflict")]
[TestCase(ErrorType.Unauthorized, 401, "Unauthorized")]
[TestCase(ErrorType.Forbidden, 403, "Forbidden")]
[TestCase(ErrorType.ServerError, 500, "Internal Server Error")]
[TestCase(ErrorType.Failure, 400, "Bad Request")]
public void ResultErrorsPreserveCodeDetailsAndFieldErrors(ErrorType type, int status, string title)
{
var fields = new Dictionary<string, string[]> { { "field", ["required"] } };
var error = new Error("code", "detail", type, fields);
var response = (ObjectResult)Result.Failure<int>(error).ToActionResult();
var problem = (ProblemDetails)response.Value!;
Assert.Multiple(() =>
{
Assert.That(response.StatusCode, Is.EqualTo(status));
Assert.That(problem.Title, Is.EqualTo(title));
Assert.That(problem.Detail, Is.EqualTo("detail"));
Assert.That(problem.Extensions["errorCode"], Is.EqualTo("code"));
Assert.That(problem.Extensions["errors"], Is.SameAs(fields));
});
var hub = error.ToHubResult<int>();
Assert.That((int)hub.Status, Is.EqualTo(status));
Assert.That(hub.ErrorMessage, Is.EqualTo(type == ErrorType.ServerError ? "Internal server error." : "detail"));
}
[TestCase(false)]
[TestCase(true)]
public void MappingActionsUseCurrentOnlineState(bool online)
{
var id = Guid.NewGuid();
var store = new Mock<IOnlineUserStore>();
store.Setup(x => x.IsOnline(id)).Returns(online);
var user = new UserDto();
new UserToUserDtoMappingAction(store.Object).Process(new User { Id = id }, user, null!);
var profile = new UserProfileDto();
new UserProfileToUserProfileDtoMappingAction(store.Object).Process(new UserProfile { Id = id }, profile, null!);
Assert.That(user.IsOnline, Is.EqualTo(online));
Assert.That(profile.IsOnline, Is.EqualTo(online));
store.Verify(x => x.IsOnline(id), Times.Exactly(2));
}
}
@@ -0,0 +1,135 @@
using Govor.API.Controllers.AdminStuff;
using Govor.Application.Infrastructure.AdminsStuff;
using Govor.Contracts.Requests;
using Govor.Contracts.DTOs;
using Govor.Contracts.Responses.Admins;
using Govor.Domain.Common;
using Govor.Domain.Models;
using Govor.Domain.Models.Users;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class AdministrationControllerTests
{
private Mock<IInvitationGenerator> _generator = null!;
private Mock<IInvitationGetter> _getter = null!;
private InviteUserController _invites = null!;
private readonly DateTime _end = new(2030, 1, 1, 0, 0, 0, DateTimeKind.Utc);
[TearDown]
public void TearDown() => _invites.Dispose();
[SetUp]
public void Setup()
{
_generator = new(); _getter = new();
_invites = Create("admin-secret");
}
private InviteUserController Create(string? key) => new(_generator.Object, _getter.Object,
new ConfigurationBuilder().AddInMemoryCollection(new Dictionary<string, string?> { ["InvitationAdmin:Key"] = key }).Build(),
NullLogger<InviteUserController>.Instance);
[TestCase(false)]
[TestCase(true)]
public async Task InvitationForwardsAllFields(bool withKey)
{
_generator.Setup(g => g.GenerateInvitationCode(_end, 12, true, "description")).ReturnsAsync("code");
var response = withKey
? await _invites.InvitationWithKey(new() { AdminKey = "admin-secret", EndDate = _end, MaxParticipants = 12, IsAdmin = true, Description = "description" })
: await _invites.Invitation(new() { EndDate = _end, MaxParticipants = 12, IsAdmin = true, Description = "description" });
Assert.That(((OkObjectResult)response).Value, Is.EqualTo("code"));
_generator.Verify(g => g.GenerateInvitationCode(_end, 12, true, "description"), Times.Once);
}
[TestCase(null, "admin-secret", 503)]
[TestCase(" ", "admin-secret", 503)]
[TestCase("admin-secret", "", 401)]
[TestCase("admin-secret", "ADMIN-SECRET", 401)]
public async Task InvalidAdminKeyNeverGeneratesInvitation(string? configured, string supplied, int status)
{
var result = (ObjectResult)await Create(configured).InvitationWithKey(new() { AdminKey = supplied });
Assert.That(result.StatusCode, Is.EqualTo(status));
_generator.VerifyNoOtherCalls();
}
[TestCase(false)]
[TestCase(true)]
public async Task GeneratorExceptionProducesBadRequest(bool withKey)
{
_generator.Setup(g => g.GenerateInvitationCode(It.IsAny<DateTime>(), It.IsAny<int>(), It.IsAny<bool>(), It.IsAny<string>())).ThrowsAsync(new InvalidOperationException("failure"));
var result = withKey ? await _invites.InvitationWithKey(new() { AdminKey = "admin-secret" }) : await _invites.Invitation(new());
Assert.That(result, Is.TypeOf<BadRequestObjectResult>());
}
[TestCase(false)]
[TestCase(true)]
public async Task InvitationListsMapFieldsAndFilterActive(bool activeOnly)
{
var active = new Invitation { Id = Guid.NewGuid(), Code = "code", Description = "desc", IsAdmin = true, MaxParticipants = 7, DateCreated = _end.AddDays(-1), EndDate = _end, Users = [new User()] };
var inactive = new Invitation { Id = Guid.NewGuid(), IsActive = false };
_getter.Setup(g => g.GetAllAsync()).ReturnsAsync([active, inactive]);
var result = activeOnly ? await _invites.GetAllActiveInvitations() : await _invites.GetAllInvitations();
var dtos = (List<InvitationResponses>)((OkObjectResult)result).Value!;
Assert.That(dtos, Has.Count.EqualTo(activeOnly ? 1 : 2));
var dto = dtos.Single(x => x.Id == active.Id);
Assert.Multiple(() => {
Assert.That(dto.Code, Is.EqualTo(active.Code)); Assert.That(dto.Description, Is.EqualTo(active.Description));
Assert.That(dto.ParticipantCount, Is.EqualTo(1)); Assert.That(dto.IsAdmin, Is.True);
Assert.That(dto.MaxParticipants, Is.EqualTo(7)); Assert.That(dto.CreatedAt, Is.EqualTo(active.DateCreated)); Assert.That(dto.EndAt, Is.EqualTo(_end));
});
_getter.Setup(g => g.FindByIdAsync(active.Id)).ReturnsAsync(active);
Assert.That(((InvitationResponses)((OkObjectResult)await _invites.GetInvitationById(active.Id)).Value!).Id, Is.EqualTo(active.Id));
}
[TestCase(0)] [TestCase(1)] [TestCase(2)]
public async Task InvitationReadExceptionsProduceBadRequest(int operation)
{
_getter.Setup(g => g.GetAllAsync()).ThrowsAsync(new Exception("failure"));
_getter.Setup(g => g.FindByIdAsync(It.IsAny<Guid>())).ThrowsAsync(new Exception("failure"));
var result = operation switch { 0 => await _invites.GetAllInvitations(), 1 => await _invites.GetAllActiveInvitations(), _ => await _invites.GetInvitationById(Guid.NewGuid()) };
Assert.That(result, Is.TypeOf<BadRequestObjectResult>());
}
[Test]
public async Task MissingInvitationReturnsNotFound()
{
_getter.Setup(g => g.FindByIdAsync(It.IsAny<Guid>())).ReturnsAsync(Result.Failure<Invitation>(Error.NotFound("missing", "missing")));
Assert.That(await _invites.GetInvitationById(Guid.NewGuid()), Is.TypeOf<NotFoundObjectResult>());
}
[Test]
public async Task UserDtosHandleMissingAndAdminInvitations()
{
var users = new Mock<IUsersAdministration>();
var a = new User { Id = Guid.NewGuid(), Username = "a", Description = "desc", Invite = new Invitation { IsAdmin = true } };
var b = new User { Id = Guid.NewGuid(), Username = "b" };
users.Setup(u => u.GetAllUsersAsync()).ReturnsAsync([a,b]);
users.Setup(u => u.GetUserById(a.Id)).ReturnsAsync(a);
var controller = new UsersController(NullLogger<UsersController>.Instance, users.Object);
var dtos = (List<UserResponse>)((OkObjectResult)await controller.AllUsers()).Value!;
Assert.That(dtos.Select(x => x.IsAdmin), Is.EqualTo(new[] { true, false }));
Assert.That(((UserResponse)((OkObjectResult)await controller.GetUserById(a.Id)).Value!).Username, Is.EqualTo("a"));
Assert.That(await controller.GetUserById(b.Id), Is.TypeOf<NotFoundResult>());
Assert.That(await controller.SetNewPassword(b.Id, new() { Password = "password" }), Is.TypeOf<NotFoundResult>());
Assert.That(await controller.SetNewPassword(a.Id, new() { Password = "password" }), Is.TypeOf<NoContentResult>());
users.Verify(u => u.SetPasswordAsync(a.Id, "password"), Times.Once);
users.Verify(u => u.SetPasswordAsync(b.Id, It.IsAny<string>()), Times.Never);
}
[TestCase(0)] [TestCase(1)] [TestCase(2)]
public async Task UserAdministrationErrorsReturn500(int operation)
{
var users = new Mock<IUsersAdministration>();
users.Setup(u => u.GetAllUsersAsync()).ThrowsAsync(new Exception("failure"));
users.Setup(u => u.GetUserById(It.IsAny<Guid>())).ThrowsAsync(new Exception("failure"));
var controller = new UsersController(NullLogger<UsersController>.Instance, users.Object);
var result = operation switch { 0 => await controller.AllUsers(), 1 => await controller.GetUserById(Guid.NewGuid()), _ => await controller.SetNewPassword(Guid.NewGuid(), new() { Password = "password" }) };
Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500));
}
}
@@ -0,0 +1,136 @@
using Govor.API.Controllers.Authentication;
using Govor.API.Hubs.Infrastructure;
using Govor.Application.Authentication;
using Govor.Application.Users.UserSessions;
using Govor.Contracts.Requests;
using Govor.Domain.Common;
using Govor.Domain.Models;
using Govor.Domain.Models.Users;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class AuthControllerTests
{
private Mock<IAccountService> _accounts = null!;
private Mock<IInvitesService> _invites = null!;
private Mock<IUserSessionOpener> _sessions = null!;
private Mock<IChatNotificationService> _notifier = null!;
private AuthController _controller = null!;
private readonly User _user = new() { Id = Guid.NewGuid(), Username = "Иван" };
private readonly Invitation _invite = new() { Id = Guid.NewGuid(), Code = "test" };
private readonly RefreshResult _tokens = new("refresh", "access");
[SetUp]
public void SetUp()
{
_accounts = new Mock<IAccountService>();
_invites = new Mock<IInvitesService>();
_sessions = new Mock<IUserSessionOpener>();
_notifier = new Mock<IChatNotificationService>();
_controller = new(_accounts.Object, _invites.Object, _sessions.Object,
NullLogger<AuthController>.Instance, _notifier.Object);
_invites.Setup(i => i.ValidateAsync("test")).ReturnsAsync(_invite);
_accounts.Setup(a => a.RegistrationAsync("Иван", "secret", _invite)).ReturnsAsync(_user);
_accounts.Setup(a => a.LoginAsync("Иван", "secret")).ReturnsAsync(_user);
_sessions.Setup(s => s.OpenSessionAsync(_user, "phone")).ReturnsAsync(_tokens);
}
[Test]
public async Task RegistrationValidatesInvitationCreatesAccountNotifiesGroupsThenOpensSession()
{
var order = new List<string>();
_notifier.Setup(n => n.NotifyUserJoinedGroupsAsync(_user.Id)).Callback(() => order.Add("notify")).Returns(Task.CompletedTask);
_sessions.Setup(s => s.OpenSessionAsync(_user, "phone")).Callback(() => order.Add("session")).ReturnsAsync(_tokens);
var response = await _controller.Register(new RegistrationRequest { Name = "Иван", Password = "secret", InviteLink = "test", DeviceInfo = "phone" });
Assert.That(((OkObjectResult)response).Value, Is.EqualTo(_tokens));
Assert.That(order, Is.EqualTo(new[] { "notify", "session" }));
_invites.Verify(i => i.ValidateAsync("test"), Times.Once);
_accounts.Verify(a => a.RegistrationAsync("Иван", "secret", _invite), Times.Once);
}
[Test]
public async Task InvalidInvitationStopsRegistrationPipeline()
{
_invites.Setup(i => i.ValidateAsync("test")).ReturnsAsync(Result.Failure<Invitation>(Error.Validation("Invite.Invalid", "invalid")));
var response = (ObjectResult)await _controller.Register(new RegistrationRequest { Name = "Иван", Password = "secret", InviteLink = "test" });
Assert.That(response.StatusCode, Is.EqualTo(400));
Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Invite.Invalid"));
_accounts.VerifyNoOtherCalls();
_sessions.VerifyNoOtherCalls();
_notifier.VerifyNoOtherCalls();
}
[TestCase(ErrorType.Conflict, 409)]
[TestCase(ErrorType.Validation, 400)]
public async Task RegistrationFailureDoesNotNotifyOrOpenSession(ErrorType type, int status)
{
_accounts.Setup(a => a.RegistrationAsync("Иван", "secret", _invite))
.ReturnsAsync(Result.Failure<User>(new Error("Auth.Failed", "failure", type)));
var response = (ObjectResult)await _controller.Register(new RegistrationRequest { Name = "Иван", Password = "secret", InviteLink = "test" });
Assert.That(response.StatusCode, Is.EqualTo(status));
_sessions.VerifyNoOtherCalls();
_notifier.VerifyNoOtherCalls();
}
[Test]
public async Task LoginReturnsTokensForTheRequestedDevice()
{
var response = (OkObjectResult)await _controller.Login(new LoginRequest { Name = "Иван", Password = "secret", DeviceInfo = "phone" });
Assert.That(response.Value, Is.EqualTo(_tokens));
_sessions.Verify(s => s.OpenSessionAsync(_user, "phone"), Times.Once);
_invites.VerifyNoOtherCalls();
_notifier.VerifyNoOtherCalls();
}
[TestCase(ErrorType.NotFound, 404)]
[TestCase(ErrorType.Failure, 400)]
[TestCase(ErrorType.Unauthorized, 401)]
public async Task FailedLoginDoesNotOpenSession(ErrorType type, int status)
{
_accounts.Setup(a => a.LoginAsync("Иван", "secret")).ReturnsAsync(Result.Failure<User>(new Error("Auth.Failed", "failure", type)));
var response = (ObjectResult)await _controller.Login(new LoginRequest { Name = "Иван", Password = "secret", DeviceInfo = "phone" });
Assert.That(response.StatusCode, Is.EqualTo(status));
_sessions.VerifyNoOtherCalls();
}
[Test]
public async Task SessionFailureIsReturnedToClient()
{
_sessions.Setup(s => s.OpenSessionAsync(_user, "phone"))
.ReturnsAsync(Result.Failure<RefreshResult>(Error.ServerError("Session.Failed", "failure")));
Assert.That(((ObjectResult)await _controller.Login(new LoginRequest { Name = "Иван", Password = "secret", DeviceInfo = "phone" })).StatusCode, Is.EqualTo(500));
}
}
[TestFixture]
public class RefreshControllerTests
{
[Test]
public async Task SuccessfulRefreshReturnsCurrentTokenContract()
{
var service = new Mock<IUserSessionRefresher>();
var tokens = new RefreshResult("new-refresh", "new-access");
service.Setup(s => s.RefreshTokenAsync("old")).ReturnsAsync(tokens);
var controller = new RefreshController(NullLogger<RefreshController>.Instance, service.Object);
var response = (OkObjectResult)await controller.Refresh(new RefreshTokenRequest { RefreshToken = "old" });
Assert.That(response.Value, Is.SameAs(tokens));
}
[TestCase(ErrorType.Failure, 400)]
[TestCase(ErrorType.Unauthorized, 401)]
[TestCase(ErrorType.ServerError, 500)]
public async Task RefreshFailureMapsToProblemDetails(ErrorType type, int status)
{
var service = new Mock<IUserSessionRefresher>();
service.Setup(s => s.RefreshTokenAsync("invalid"))
.ReturnsAsync(Result.Failure<RefreshResult>(new Error("Auth.InvalidToken", "invalid", type)));
var controller = new RefreshController(NullLogger<RefreshController>.Instance, service.Object);
var response = (ObjectResult)await controller.Refresh(new RefreshTokenRequest { RefreshToken = "invalid" });
Assert.That(response.StatusCode, Is.EqualTo(status));
Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Auth.InvalidToken"));
}
}
@@ -0,0 +1,81 @@
using AutoMapper;
using Govor.API.Controllers;
using Govor.Application.Messages;
using Govor.Contracts.Requests;
using Govor.Contracts.Responses;
using Govor.Domain.Common;
using Govor.Domain.Models.Messages;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class ChatLoadControllerTests
{
private Mock<IMessagesLoader> _loader = null!;
private Mock<IMapper> _mapper = null!;
private ChatLoadController _controller = null!;
private readonly Guid _user = Guid.NewGuid(), _chat = Guid.NewGuid();
[SetUp]
public void SetUp()
{
_loader = new Mock<IMessagesLoader>();
_mapper = new Mock<IMapper>();
var current = new Mock<ICurrentUserService>();
current.Setup(c => c.GetCurrentUserId()).Returns(_user);
_controller = new(NullLogger<ChatLoadController>.Instance, _loader.Object, current.Object, _mapper.Object);
}
private Task<IActionResult> Load(bool group, MessageQuery query) =>
group ? _controller.GetGroupMessages(_chat, query) : _controller.GetUserMessages(_chat, query);
[TestCase(false)]
[TestCase(true)]
public async Task SuccessfulPageIsMappedAndReturnsOk(bool group)
{
var messages = new List<Message> { new() { Id = Guid.NewGuid() } };
var response = new List<MessageResponse>();
_mapper.Setup(m => m.Map<List<MessageResponse>>(messages)).Returns(response);
_loader.Setup(l => l.LoadMessagesInChatGroup(_chat, _user, null, 20, 2)).ReturnsAsync(messages);
_loader.Setup(l => l.LoadMessagesInUserChat(_chat, _user, null, 20, 2)).ReturnsAsync(messages);
Assert.That(((OkObjectResult)await Load(group, new MessageQuery { Before = 20, After = 2 })).Value, Is.SameAs(response));
}
[TestCase(false, -1, 0)]
[TestCase(true, 0, -1)]
[TestCase(false, 101, 0)]
[TestCase(true, 0, 101)]
[TestCase(false, 60, 41)]
[TestCase(true, 60, 41)]
public async Task InvalidPageLimitsDoNotCallLoader(bool group, int before, int after)
{
Assert.That(await Load(group, new MessageQuery { Before = before, After = after }), Is.TypeOf<BadRequestObjectResult>());
_loader.VerifyNoOtherCalls();
}
[TestCase(false, ErrorType.Forbidden, 403)]
[TestCase(true, ErrorType.Forbidden, 403)]
[TestCase(false, ErrorType.NotFound, 404)]
[TestCase(true, ErrorType.Validation, 400)]
public async Task ServiceFailureReturnsProblemDetails(bool group, ErrorType type, int status)
{
var failure = Result.Failure<List<Message>>(new Error("Chat.Failed", "failure", type));
_loader.Setup(l => l.LoadMessagesInChatGroup(_chat, _user, null, 20, 2)).ReturnsAsync(failure);
_loader.Setup(l => l.LoadMessagesInUserChat(_chat, _user, null, 20, 2)).ReturnsAsync(failure);
var response = (ObjectResult)await Load(group, new MessageQuery { Before = 20, After = 2 });
Assert.That(response.StatusCode, Is.EqualTo(status));
Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Chat.Failed"));
}
[TestCase(false)]
[TestCase(true)]
public async Task UnexpectedExceptionReturns500(bool group)
{
_loader.Setup(l => l.LoadMessagesInChatGroup(_chat, _user, null, 20, 2)).ThrowsAsync(new Exception("database unavailable"));
_loader.Setup(l => l.LoadMessagesInUserChat(_chat, _user, null, 20, 2)).ThrowsAsync(new Exception("database unavailable"));
Assert.That(((ObjectResult)await Load(group, new MessageQuery { Before = 20, After = 2 })).StatusCode, Is.EqualTo(500));
}
}
@@ -0,0 +1,79 @@
using AutoMapper;
using Govor.API.Controllers;
using Govor.API.Hubs;
using Govor.Application.Infrastructure.Extensions;
using Govor.Application.Medias;
using Govor.Application.Profiles;
using Govor.Application.PushNotifications;
using Govor.Application.Users.UserSessions;
using Govor.Application.Users.UserOnlineStatus;
using Govor.Application.PingHandler;
using Govor.Contracts.Requests;
using Govor.Domain.Common;
using Govor.Domain.Models;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class ControllerFailureTests
{
[TestCase(0,false)] [TestCase(0,true)] [TestCase(1,false)] [TestCase(1,true)] [TestCase(2,false)] [TestCase(2,true)]
public async Task SessionRevocationExceptionsProduceExpectedStatus(int action,bool unauthorized)
{
var user=new Mock<ICurrentUserService>();var session=new Mock<ICurrentUserSessionService>();var revoker=new Mock<IUserSessionRevoker>();
Exception error=unauthorized?new UnauthorizedAccessException():new Exception("private detail");
revoker.Setup(x=>x.CloseSessionByIdAsync(It.IsAny<Guid>(),It.IsAny<Guid>())).ThrowsAsync(error);
revoker.Setup(x=>x.CloseAllSessionsAsync(It.IsAny<Guid>())).ThrowsAsync(error);
using var controller=new SessionController(NullLogger<SessionController>.Instance,user.Object,session.Object,Mock.Of<IUserSessionReader>(),revoker.Object,Mock.Of<IMapper>());
var response=action switch{0=>await controller.CloseSession(Guid.NewGuid()),1=>await controller.CloseCurrent(),_=>await controller.CloseAllSessions()};
if(unauthorized) Assert.That(response,Is.TypeOf<ForbidResult>());else {Assert.That(((ObjectResult)response).StatusCode,Is.EqualTo(500));Assert.That(((ObjectResult)response).Value,Is.Not.EqualTo("private detail"));}
}
[TestCase(false)] [TestCase(true)] public async Task ProfileByIdHandlesServiceExceptions(bool unauthorized)
{
var profiles=new Mock<IProfileService>();profiles.Setup(x=>x.GetUserProfileAsync(It.IsAny<Guid>())).ThrowsAsync(unauthorized?new UnauthorizedAccessException():new Exception("failure"));
var controller=new ProfileController(NullLogger<ProfileController>.Instance,Mock.Of<IMediaService>(),profiles.Object,Mock.Of<ICurrentUserService>(),Mock.Of<IHubContext<ProfileHub>>(),Mock.Of<IMapper>());
var response=await controller.DownloadProfileByUserId(Guid.NewGuid());
if(unauthorized) Assert.That(response,Is.TypeOf<ForbidResult>());else Assert.That(((ObjectResult)response).StatusCode,Is.EqualTo(500));
}
[Test] public async Task ProfileByIdMapsRequestedUser()
{
var id=Guid.NewGuid();var value=new UserProfile{Id=id};var profiles=new Mock<IProfileService>();profiles.Setup(x=>x.GetUserProfileAsync(id)).ReturnsAsync(value);
var mapper=new Mock<IMapper>();var dto=new Govor.Contracts.DTOs.UserProfileDto();mapper.Setup(x=>x.Map<Govor.Contracts.DTOs.UserProfileDto>(value)).Returns(dto);
var controller=new ProfileController(NullLogger<ProfileController>.Instance,Mock.Of<IMediaService>(),profiles.Object,Mock.Of<ICurrentUserService>(),Mock.Of<IHubContext<ProfileHub>>(),mapper.Object);
Assert.That(((OkObjectResult)await controller.DownloadProfileByUserId(id)).Value,Is.SameAs(dto));
}
[TestCase(0)] [TestCase(1)] [TestCase(2)] public async Task MediaUploadFailuresAreMapped(int kind)
{
var media=new Mock<IMediaService>();
if(kind==0) media.Setup(x=>x.UploadMediaAsync(It.IsAny<Media>())).ReturnsAsync(Result.Failure<MediaUploadResult>(Error.ServerError("storage","failure")));
else media.Setup(x=>x.UploadMediaAsync(It.IsAny<Media>())).ThrowsAsync(kind==1?new UnauthorizedAccessException():new Exception("failure"));
using var stream=new MemoryStream([1]);using var controller=new MediaController(NullLogger<MediaController>.Instance,media.Object,Mock.Of<IAccesserToDownloadMedia>(),Mock.Of<ICurrentUserService>());
var response=await controller.Upload(new(){FromFile=new FormFile(stream,0,1,"file","avatar.png"),OwnerType=MediaOwnerType.Avatar,MimeType="image/png"});
if(kind==1) Assert.That(response,Is.TypeOf<ForbidResult>());else Assert.That(((ObjectResult)response).StatusCode,Is.EqualTo(500));
}
[TestCase(0)] [TestCase(1)] public async Task MediaUploadRejectsMissingMimeAndOversizeBeforeStorage(int kind)
{
var media=new Mock<IMediaService>(MockBehavior.Strict);var file=new Mock<IFormFile>();file.SetupGet(x=>x.Length).Returns(kind==0?1:20_000_001);
using var controller=new MediaController(NullLogger<MediaController>.Instance,media.Object,Mock.Of<IAccesserToDownloadMedia>(),Mock.Of<ICurrentUserService>());
Assert.That(await controller.Upload(new(){FromFile=file.Object,OwnerType=MediaOwnerType.Avatar,MimeType=kind==0?" ":"image/png"}),Is.TypeOf<BadRequestObjectResult>());media.VerifyNoOtherCalls();
}
[Test] public async Task OnlineStatusReaderFailureProduces500()
{
var presence=new Mock<IUserPresenceReader>();presence.Setup(x=>x.GetLastSeenAsync(It.IsAny<Guid>())).ThrowsAsync(new Exception("failure"));
using var controller=new OnlinePingingController(NullLogger<OnlinePingingController>.Instance,Mock.Of<IPingHandlerService>(),Mock.Of<ICurrentUserService>(),presence.Object,Mock.Of<IOnlineUserStore>());
Assert.That(((ObjectResult)await controller.GetStatus(Guid.NewGuid())).StatusCode,Is.EqualTo(500));
}
[Test] public async Task PushRegistrationHidesUnexpectedServiceFailure()
{
var push=new Mock<IPushTokenService>();push.Setup(x=>x.AddOrUpdateTokenAsync(It.IsAny<Guid>(),It.IsAny<Guid>(),"token","android")).ThrowsAsync(new Exception("private detail"));
using var controller=new PushTokensController(push.Object,Mock.Of<ICurrentUserService>(),Mock.Of<ICurrentUserSessionService>(),NullLogger<PushTokensController>.Instance){ControllerContext=new(){HttpContext=new DefaultHttpContext()}};
var result=(ObjectResult)await controller.RegisterToken(new(){Token="token",Platform="android"});
Assert.That(result.StatusCode,Is.EqualTo(500));Assert.That(((ProblemDetails)result.Value!).Detail,Does.Not.Contain("private detail"));
}
}
@@ -0,0 +1,195 @@
using AutoFixture;
using AutoMapper;
using Govor.API.Controllers.Friends;
using Govor.Contracts.DTOs;
using Govor.Domain.Models;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class FriendsRequestQueryControllerTests
{
private Fixture _fixture = null!;
private Mock<ILogger<FriendsRequestQueryController>> _loggerMock = null!;
private Mock<IFriendRequestQueryService> _friendsServiceMock = null!;
private Mock<ICurrentUserService> _currentUserServiceMock = null!;
private Mock<IMapper> _mapperMock = null!;
private FriendsRequestQueryController _controller = null!;
[SetUp]
public void SetUp()
{
_fixture = new Fixture();
_fixture.Behaviors.OfType<ThrowingRecursionBehavior>().ToList().ForEach(b => _fixture.Behaviors.Remove(b));
_fixture.Behaviors.Add(new OmitOnRecursionBehavior());
_loggerMock = new Mock<ILogger<FriendsRequestQueryController>>();
_friendsServiceMock = new Mock<IFriendRequestQueryService>();
_currentUserServiceMock = new Mock<ICurrentUserService>();
_mapperMock = new Mock<IMapper>();
_controller = new FriendsRequestQueryController(
_loggerMock.Object,
_friendsServiceMock.Object,
_currentUserServiceMock.Object,
_mapperMock.Object
);
}
[Test]
public async Task GetIncomingRequests_ValidRequest_ReturnsOkResult()
{
// Arrange
var currentId = _fixture.Create<Guid>();
var friendships = _fixture.CreateMany<Friendship>().ToList();
var dtos = friendships.Select(f => new FriendshipDto()
{
AddresseeId = f.AddresseeId,
RequesterId = f.RequesterId
}).ToList();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetIncomingAsync(currentId))
.ReturnsAsync(friendships);
_mapperMock.Setup(f => f.Map<List<FriendshipDto>>(friendships)).Returns(dtos);
// Act
var result = await _controller.GetIncomingRequests();
// Assert
Assert.That(result, Is.InstanceOf<OkObjectResult>());
var okResult = result as OkObjectResult;
List<FriendshipDto> value = okResult.Value as List<FriendshipDto>;
Assert.That(value, Is.Not.Null);
Assert.That(value.Count, Is.EqualTo(friendships.Count));
Assert.That(value.Select(f => f.AddresseeId), Is.EquivalentTo(friendships.Select(f => f.AddresseeId)));
Assert.That(value.Select(f => f.RequesterId), Is.EquivalentTo(friendships.Select(f => f.RequesterId)));
}
[Test]
public async Task GetIncomingRequests_ServiceFailure_Returns500()
{
// Arrange
var currentId = _fixture.Create<Guid>();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetIncomingAsync(currentId))
.ThrowsAsync(new InvalidOperationException());
// Act
var result = await _controller.GetIncomingRequests();
// Assert
Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500));
}
[Test]
public async Task GetIncomingRequest_StatusCode500_IfThrowsSomeException()
{
// Arrange
var currentId = _fixture.Create<Guid>();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetIncomingAsync(currentId))
.ThrowsAsync(new Exception());
// Act
var result = await _controller.GetIncomingRequests();
// Assert
Assert.That(result, Is.InstanceOf<ObjectResult>());
var objectResult = result as ObjectResult;
Assert.That(objectResult.StatusCode, Is.EqualTo(500));
}
// Test for GetResponses action
[Test]
public async Task GetResponses_ValidRequest_ReturnsOkResult()
{
// Arrange
var currentId = _fixture.Create<Guid>();
var friendships = _fixture.CreateMany<Friendship>().ToList();
var dtos = friendships.Select(f => new FriendshipDto()
{
AddresseeId = f.AddresseeId,
RequesterId = f.RequesterId
}).ToList();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetResponsesAsync(currentId))
.ReturnsAsync(friendships);
_mapperMock.Setup(f => f.Map<List<FriendshipDto>>(friendships)).Returns(dtos);
// Act
var result = await _controller.GetResponses();
// Assert
Assert.That(result, Is.InstanceOf<OkObjectResult>());
var okResult = result as OkObjectResult;
List<FriendshipDto> value = okResult.Value as List<FriendshipDto>;
Assert.That(value, Is.Not.Null);
Assert.That(value.Count, Is.EqualTo(friendships.Count));
Assert.That(value.Select(f => f.AddresseeId), Is.EquivalentTo(friendships.Select(f => f.AddresseeId)));
Assert.That(value.Select(f => f.RequesterId), Is.EquivalentTo(friendships.Select(f => f.RequesterId)));
}
[Test]
public async Task GetResponses_ServiceFailure_Returns500()
{
// Arrange
var currentId = _fixture.Create<Guid>();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetResponsesAsync(currentId))
.ThrowsAsync(new InvalidOperationException());
// Act
var result = await _controller.GetResponses();
// Assert
Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500));
}
[Test]
public async Task GetResponses_StatusCode500_IfThrowsSomeException()
{
// Arrange
var currentId = _fixture.Create<Guid>();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetResponsesAsync(currentId))
.ThrowsAsync(new Exception());
// Act
var result = await _controller.GetResponses();
// Assert
Assert.That(result, Is.InstanceOf<ObjectResult>());
var objectResult = result as ObjectResult;
Assert.That(objectResult.StatusCode, Is.EqualTo(500));
}
[TearDown]
public void TearDown()
{
_controller?.Dispose();
}
}
@@ -0,0 +1,174 @@
using AutoFixture;
using AutoMapper;
using Govor.API.Controllers.Friends;
using Govor.Application.Exceptions.FriendsService;
using Govor.Contracts.DTOs;
using Govor.Domain.Models.Users;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class FriendshipControllerTests
{
private Fixture _fixture = null!;
private Mock<ILogger<FriendshipController>> _loggerMock = null!;
private Mock<IFriendshipService> _friendsServiceMock = null!;
private Mock<ICurrentUserService> _currentUserServiceMock = null!;
private Mock<IMapper> _mapperMock = null!;
private FriendshipController _controller = null!;
[SetUp]
public void SetUp()
{
_fixture = new Fixture();
_fixture.Behaviors.OfType<ThrowingRecursionBehavior>().ToList().ForEach(b => _fixture.Behaviors.Remove(b));
_fixture.Behaviors.Add(new OmitOnRecursionBehavior());
_loggerMock = new Mock<ILogger<FriendshipController>>();
_friendsServiceMock = new Mock<IFriendshipService>();
_currentUserServiceMock = new Mock<ICurrentUserService>();
_mapperMock = new Mock<IMapper>();
_controller = new FriendshipController(
_loggerMock.Object,
_friendsServiceMock.Object,
_currentUserServiceMock.Object,
_mapperMock.Object
);
}
// Tests for Search action
[Test]
public async Task Search_ValidRequest_ReturnsOkResult()
{
var users = _fixture.CreateMany<User>().ToList();
var dtos = users.Select(u => new UserDto { Id = u.Id }).ToList();
var userId = _fixture.Create<Guid>();
var query = _fixture.Create<string>();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId()).Returns(userId);
_friendsServiceMock.Setup(f => f.SearchUsersAsync(query, userId))
.ReturnsAsync(users);
_mapperMock.Setup(m => m.Map<List<UserDto>>(users)).Returns(dtos);
// Act
var result = await _controller.Search(query);
var okResult = result as OkObjectResult;
dynamic value = okResult.Value;
List<UserDto> userDtos = value as List<UserDto>;
// Assert
Assert.That(value, Is.Not.Null);
Assert.That(value.Count, Is.EqualTo(users.Count));
Assert.That(userDtos.Select(u => u.Id), Is.EqualTo(users.Select(u => u.Id)));
}
[Test]
public async Task Search_InvalidQuery_BadRequest()
{
// Act
var result = await _controller.Search(string.Empty);
// Assert
Assert.That(result, Is.InstanceOf<BadRequestObjectResult>());
var badRequestResult = result as BadRequestObjectResult;
Assert.That(badRequestResult.Value, Is.EqualTo("Query cannot be empty"));
}
[Test]
public async Task Search_StatusCode500_IfThrowsSomeException()
{
// Arrange
_friendsServiceMock.Setup(f => f.SearchUsersAsync(It.IsAny<string>(), It.IsAny<Guid>()))
.ThrowsAsync(new Exception(_fixture.Create<string>()));
// Act
var result = await _controller.Search(_fixture.Create<string>());
// Assert
Assert.That(result, Is.InstanceOf<ObjectResult>());
var objectResult = result as ObjectResult;
Assert.That(objectResult.StatusCode, Is.EqualTo(500));
}
[Test]
public async Task GetFriends_ValidRequest_ReturnsOkResult()
{
// Arrange
var currentId = _fixture.Create<Guid>();
var users = _fixture.CreateMany<User>().ToList();
var dtos = users.Select(u => new UserDto { Id = u.Id }).ToList();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetFriendsAsync(currentId))
.ReturnsAsync(users);
_mapperMock.Setup(m => m.Map<List<UserDto>>(users)).Returns(dtos);
// Act
var result = await _controller.GetFriends();
// Assert
Assert.That(result, Is.InstanceOf<OkObjectResult>());
var okResult = result as OkObjectResult;
List<UserDto> value = okResult.Value as List<UserDto>;
Assert.That(value, Is.Not.Null);
Assert.That(value.Count, Is.EqualTo(users.Count));
Assert.That(value.Select(u => u.Id), Is.EqualTo(users.Select(u => u.Id)));
}
[Test]
public async Task GetFriends_ServiceFailure_Returns500()
{
// Arrange
var currentId = _fixture.Create<Guid>();
var users = _fixture.CreateMany<User>().ToList();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetFriendsAsync(currentId))
.ThrowsAsync(new InvalidOperationException());
// Act
var result = await _controller.GetFriends();
// Assert
Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500));
}
[Test]
public async Task GetFriends_Exception_ReturnsStatusCode500()
{
// Arrange
var currentId = _fixture.Create<Guid>();
var users = _fixture.CreateMany<User>().ToList();
_currentUserServiceMock.Setup(c => c.GetCurrentUserId())
.Returns(currentId);
_friendsServiceMock.Setup(f => f.GetFriendsAsync(currentId))
.ThrowsAsync(new Exception());
// Act
var result = await _controller.GetFriends();
// Assert
Assert.That(result, Is.InstanceOf<ObjectResult>());
var objectResult = result as ObjectResult;
Assert.That(objectResult.StatusCode, Is.EqualTo(500));
}
[TearDown]
public void TearDown()
{
_controller.Dispose();
}
}
@@ -0,0 +1,112 @@
using System.ComponentModel.DataAnnotations;
using Govor.API.Controllers;
using Govor.Application.E2ee;
using Govor.Application.Medias;
using Govor.Contracts.Requests;
using Govor.Domain.Common;
using Govor.Domain.Models;
using Govor.Domain.Models.Messages;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class MediaControllerTests
{
private Mock<IMediaService> _media = null!;
private Mock<IAccesserToDownloadMedia> _access = null!;
private MediaController _controller = null!;
private readonly Guid _user = Guid.NewGuid();
[SetUp]
public void SetUp()
{
_media = new Mock<IMediaService>();
_access = new Mock<IAccesserToDownloadMedia>();
var current = new Mock<ICurrentUserService>();
current.Setup(c => c.GetCurrentUserId()).Returns(_user);
_controller = new(NullLogger<MediaController>.Instance, _media.Object, _access.Object, current.Object);
}
private static MediaUploadRequest Request(string mime = E2eeProtocol.EncryptedMimeType, string key = "") =>
new() { FromFile = new FormFile(new MemoryStream(new byte[] { 1, 2, 3 }), 0, 3, "file", "encrypted.bin"),
Type = MediaType.File, MimeType = mime, EncryptedKey = key, OwnerType = MediaOwnerType.Message };
[Test]
public async Task EncryptedUploadPassesCiphertextWithoutKeysToService()
{
var upload = new MediaUploadResult(Guid.NewGuid(), "stored.bin");
_media.Setup(m => m.UploadMediaAsync(It.IsAny<Media>())).ReturnsAsync(upload);
var request = Request();
var validation = new List<ValidationResult>();
Assert.That(Validator.TryValidateObject(request, new ValidationContext(request), validation, true),
Is.True, string.Join("; ", validation.Select(v => v.ErrorMessage)));
Assert.That(((OkObjectResult)await _controller.Upload(request)).Value, Is.SameAs(upload));
_media.Verify(m => m.UploadMediaAsync(It.Is<Media>(data => data.UploaderId == _user &&
data.EncryptedKey == "" && data.Data.SequenceEqual(new byte[] { 1, 2, 3 }) &&
data.MimeType == E2eeProtocol.EncryptedMimeType && data.OwnerId == null)), Times.Once);
}
[TestCase("image/png", "")]
[TestCase(E2eeProtocol.EncryptedMimeType, "decryption-secret")]
public async Task PlaintextAttachmentOrLeakedKeyIsRejected(string mime, string key)
{
Assert.That(await _controller.Upload(Request(mime, key)), Is.TypeOf<BadRequestObjectResult>());
_media.VerifyNoOtherCalls();
}
[TestCase(MediaOwnerType.System)]
[TestCase(MediaOwnerType.GroupAvatar)]
[TestCase(MediaOwnerType.Reaction)]
public async Task UnsupportedOwnerIsRejected(MediaOwnerType type)
{
var request = Request();
request.OwnerType = type;
Assert.That(await _controller.Upload(request), Is.TypeOf<BadRequestObjectResult>());
_media.VerifyNoOtherCalls();
}
[Test]
public async Task MissingFileAndInvalidModelAreRejected()
{
var request = Request();
request.FromFile = null!;
Assert.That(await _controller.Upload(request), Is.TypeOf<BadRequestObjectResult>());
_controller.ModelState.AddModelError("file", "invalid");
Assert.That(await _controller.Upload(Request()), Is.TypeOf<BadRequestObjectResult>());
_media.VerifyNoOtherCalls();
}
[Test]
public async Task DownloadDeniesAccessBeforeLoadingFile()
{
Assert.That(await _controller.Download(Guid.NewGuid()), Is.TypeOf<ForbidResult>());
_media.VerifyNoOtherCalls();
}
[Test]
public async Task DownloadReturnsBytesAndSanitizesFileName()
{
var id = Guid.NewGuid();
_access.Setup(a => a.HasAccessAsync(id, _user)).ReturnsAsync(true);
_media.Setup(m => m.GetMediaByIdAsync(id)).ReturnsAsync(new Media(_user, DateTime.UtcNow,
"folder/encrypted.bin", new byte[] { 1, 2 }, MediaType.File, E2eeProtocol.EncryptedMimeType, "", MediaOwnerType.Message, null));
var response = (FileContentResult)await _controller.Download(id);
Assert.That(response.FileContents, Is.EqualTo(new byte[] { 1, 2 }));
Assert.That(response.FileDownloadName, Is.EqualTo("encrypted.bin"));
Assert.That(response.ContentType, Is.EqualTo(E2eeProtocol.EncryptedMimeType));
}
[TestCase(ErrorType.NotFound, 404)]
[TestCase(ErrorType.ServerError, 500)]
public async Task DownloadServiceFailureReturnsProblemDetails(ErrorType type, int status)
{
var id = Guid.NewGuid();
_access.Setup(a => a.HasAccessAsync(id, _user)).ReturnsAsync(true);
_media.Setup(m => m.GetMediaByIdAsync(id)).ReturnsAsync(Result.Failure<Media>(new Error("Media.Failed", "failure", type)));
Assert.That(((ObjectResult)await _controller.Download(id)).StatusCode, Is.EqualTo(status));
}
}
@@ -0,0 +1,134 @@
using Govor.API.Controllers;
using Govor.Application.PingHandler;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class OnlinePingingControllerTests
{
private Mock<ILogger<OnlinePingingController>> _loggerMock = null!;
private Mock<IPingHandlerService> _pingHandlerServiceMock = null!;
private Mock<ICurrentUserService> _currentUserServiceMock = null!;
private OnlinePingingController _controller = null!;
[SetUp]
public void SetUp()
{
_loggerMock = new Mock<ILogger<OnlinePingingController>>();
_pingHandlerServiceMock = new Mock<IPingHandlerService>();
_currentUserServiceMock = new Mock<ICurrentUserService>();
_controller = new OnlinePingingController(_loggerMock.Object, _pingHandlerServiceMock.Object,
_currentUserServiceMock.Object, Mock.Of<IUserPresenceReader>(), Mock.Of<IOnlineUserStore>());
}
[Test]
public async Task Ping_ValidUserId_ReturnsOk()
{
// Arrange
var userId = Guid.NewGuid();
_currentUserServiceMock.Setup(x => x.GetCurrentUserId()).Returns(userId);
_pingHandlerServiceMock.Setup(x => x.Ping(userId)).Returns(Task.CompletedTask);
// Act
var result = await _controller.Ping();
// Assert
Assert.That(result, Is.InstanceOf<OkResult>());
_pingHandlerServiceMock.Verify(x => x.Ping(userId), Times.Once());
_loggerMock.VerifyLog(LogLevel.Information, $"Ping from user {userId} processed successfully", Times.Once());
}
[Test]
public async Task Ping_InvalidOperationException_Returns500()
{
// Arrange
var userId = Guid.NewGuid();
var exception = new InvalidOperationException("User not found");
_currentUserServiceMock.Setup(x => x.GetCurrentUserId()).Returns(userId);
_pingHandlerServiceMock.Setup(x => x.Ping(userId)).ThrowsAsync(exception);
// Act
var result = await _controller.Ping();
// Assert
Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500));
_loggerMock.VerifyLog(LogLevel.Error, exception.Message, Times.Once());
}
[Test]
public async Task Ping_ServiceException_Returns500()
{
// Arrange
var userId = Guid.NewGuid();
var exception = new UnauthorizedAccessException("Unauthorized");
_currentUserServiceMock.Setup(x => x.GetCurrentUserId()).Returns(userId);
_pingHandlerServiceMock.Setup(x => x.Ping(userId)).ThrowsAsync(exception);
// Act
var result = await _controller.Ping();
// Assert
Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500));
_loggerMock.VerifyLog(LogLevel.Error, exception.Message, Times.Once());
}
[Test]
public async Task Ping_GeneralException_ReturnsStatusCode500()
{
// Arrange
var userId = Guid.NewGuid();
var exception = new Exception("Unexpected error");
_currentUserServiceMock.Setup(x => x.GetCurrentUserId()).Returns(userId);
_pingHandlerServiceMock.Setup(x => x.Ping(userId)).ThrowsAsync(exception);
// Act
var result = await _controller.Ping();
// Assert
Assert.That(result, Is.InstanceOf<ObjectResult>());
var objectResult = (ObjectResult)result;
Assert.That(objectResult.StatusCode, Is.EqualTo(500));
_loggerMock.VerifyLog(LogLevel.Error, exception.Message, Times.Once());
}
[Test]
public async Task Ping_CurrentUserException_Returns500WithoutPinging()
{
// Arrange
var exception = new UnauthorizedAccessException("userID claim is missing or invalid");
_currentUserServiceMock.Setup(x => x.GetCurrentUserId()).Throws(exception);
// Act
var result = await _controller.Ping();
// Assert
Assert.That(((ObjectResult)result).StatusCode, Is.EqualTo(500));
_loggerMock.VerifyLog(LogLevel.Error, exception.Message, Times.Once());
_pingHandlerServiceMock.Verify(x => x.Ping(It.IsAny<Guid>()), Times.Never());
}
[TearDown]
public void TearDown()
{
_controller?.Dispose();
}
}
// Helper extension for verifying logger calls
public static class LoggerMockExtensions
{
public static void VerifyLog<T>(this Mock<ILogger<T>> logger, LogLevel level, string message, Times times)
{
logger.Verify(
x => x.Log(
It.Is<LogLevel>(l => l == level),
It.IsAny<EventId>(),
It.Is<It.IsAnyType>((v, t) => v.ToString().Contains(message)),
It.IsAny<Exception>(),
It.IsAny<Func<It.IsAnyType, Exception?, string>>()),
times);
}
}
@@ -0,0 +1,59 @@
using Govor.API.Controllers;
using Govor.Application.Friends;
using Govor.Application.Exceptions.VerifyFriendship;
using Govor.Application.Infrastructure.Extensions;
using Govor.Application.PrivateUserChats;
using Govor.Contracts.DTOs;
using Govor.Domain.Models;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class PrivateChatControllerTests
{
private readonly Guid _user=Guid.NewGuid(),_friend=Guid.NewGuid();
private Mock<IVerifyFriendship> _verify=null!;
private Mock<IUserPrivateChatsCreator> _creator=null!;
private Mock<IUserPrivateChatsGetterService> _getter=null!;
private PrivateChatController _controller=null!;
[SetUp] public void Setup()
{
_verify=new(); _creator=new(); _getter=new();
var user=new Mock<ICurrentUserService>(); user.Setup(x=>x.GetCurrentUserId()).Returns(_user);
_controller=new(user.Object,_verify.Object,_creator.Object,_getter.Object,NullLogger<ChatLoadController>.Instance);
}
[TearDown] public void TearDown()=>_controller.Dispose();
[Test] public async Task FriendshipIsVerifiedBeforeCreatingChat()
{
var order=new List<string>(); var chat=new PrivateChat{Id=Guid.NewGuid()};
_verify.Setup(x=>x.VerifyAsync(_user,_friend)).Callback(()=>order.Add("verify")).Returns(Task.CompletedTask);
_creator.Setup(x=>x.CreateAsync(_user,_friend)).Callback(()=>order.Add("create")).ReturnsAsync(chat);
Assert.That(((OkObjectResult)await _controller.GetChatByFriendId(_friend)).Value,Is.EqualTo(chat.Id));
Assert.That(order,Is.EqualTo(new[]{"verify","create"}));
}
[TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)]
public async Task VerificationFailuresNeverCreateChat(int kind)
{
Exception error=kind switch{0=>new UnauthorizedAccessException(),1=>new ArgumentException("invalid"),2=>new FriendshipException("denied"),_=>new Exception("private")};
_verify.Setup(x=>x.VerifyAsync(_user,_friend)).ThrowsAsync(error);
var result=await _controller.GetChatByFriendId(_friend);
if(kind is 0 or 2) Assert.That(result,Is.TypeOf<ForbidResult>());
else Assert.That(((ObjectResult)result).StatusCode,Is.EqualTo(kind==1?400:500));
_creator.VerifyNoOtherCalls();
}
[Test] public async Task ChatListSelectsOtherParticipantForBothOrientations()
{
_getter.Setup(x=>x.GetUserChatsAsync(_user)).ReturnsAsync([new(){Id=Guid.NewGuid(),UserAId=_user,UserBId=_friend},new(){Id=Guid.NewGuid(),UserAId=_friend,UserBId=_user}]);
var result=(List<PrivateChatDto>)((OkObjectResult)await _controller.GetChatsByFriends()).Value!;
Assert.That(result.Select(x=>x.FriendId),Is.EqualTo(new[]{_friend,_friend}));
}
[TestCase(false)] [TestCase(true)] public async Task ChatListHandlesErrors(bool unauthorized)
{
_getter.Setup(x=>x.GetUserChatsAsync(_user)).ThrowsAsync(unauthorized?new UnauthorizedAccessException():new Exception("private"));
var result=await _controller.GetChatsByFriends();
if(unauthorized) Assert.That(result,Is.TypeOf<ForbidResult>()); else Assert.That(((ObjectResult)result).StatusCode,Is.EqualTo(500));
}
}
@@ -0,0 +1,270 @@
using System.Text;
using AutoMapper;
using Govor.API.Controllers;
using Govor.API.Hubs;
using Govor.Application.Profiles;
using Govor.Contracts.DTOs;
using Govor.Contracts.Requests;
using Govor.Domain.Models;
using Govor.Domain.Models.Messages;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging;
using Moq;
using Newtonsoft.Json.Linq;
namespace Govor.API.Tests;
[TestFixture]
public class ProfileControllerTests
{
private Mock<ILogger<ProfileController>> _mockLogger = null!;
private Mock<IMediaService> _mockMediaService = null!;
private Mock<IProfileService> _mockProfileService = null!;
private Mock<ICurrentUserService> _mockCurrentUserService = null!;
private Mock<IHubContext<ProfileHub>> _mockProfileHubContext = null!;
private Mock<IHubClients> _mockClients = null!;
private Mock<IClientProxy> _mockClientProxy = null!;
private Mock<IMapper> _mockMapper = null!;
private ProfileController _controller = null!;
private Guid _userId;
[SetUp]
public void SetUp()
{
_mockLogger = new Mock<ILogger<ProfileController>>();
_mockMediaService = new Mock<IMediaService>();
_mockProfileService = new Mock<IProfileService>();
_mockCurrentUserService = new Mock<ICurrentUserService>();
_mockMapper = new Mock<IMapper>();
_mockProfileHubContext = new Mock<IHubContext<ProfileHub>>();
_mockClients = new Mock<IHubClients>();
_mockClientProxy = new Mock<IClientProxy>();
_mockProfileHubContext.Setup(x => x.Clients).Returns(_mockClients.Object);
_mockClients.Setup(x => x.All).Returns(_mockClientProxy.Object);
_mockClientProxy.Setup(x => x.SendCoreAsync(It.IsAny<string>(), It.IsAny<object?[]?>(), It.IsAny<CancellationToken>()))
.Returns(Task.CompletedTask);
_controller = new ProfileController(
_mockLogger.Object,
_mockMediaService.Object,
_mockProfileService.Object,
_mockCurrentUserService.Object,
_mockProfileHubContext.Object,
_mockMapper.Object);
_userId = Guid.NewGuid();
_mockCurrentUserService.Setup(x => x.GetCurrentUserId()).Returns(_userId);
}
[Test]
public async Task UploadAvatar_ReturnsBadRequest_WhenFileIsEmpty()
{
// Arrange
var request = new AvatarUploadRequest
{
FromFile = null
};
// Act
var result = await _controller.UploadAvatar(request);
// Assert
Assert.That(result, Is.InstanceOf<BadRequestObjectResult>());
var badRequestResult = (BadRequestObjectResult)result;
Assert.That(badRequestResult.Value, Is.EqualTo("File is empty."));
_mockMediaService.Verify(s => s.UploadMediaAsync(It.IsAny<Media>()), Times.Never);
}
[Test]
public async Task UploadAvatar_ReturnsBadRequest_WhenFileLengthIsZero()
{
// Arrange
var mockFile = new Mock<IFormFile>();
mockFile.Setup(f => f.Length).Returns(0);
var request = new AvatarUploadRequest
{
FromFile = mockFile.Object
};
// Act
var result = await _controller.UploadAvatar(request);
// Assert
Assert.That(result, Is.InstanceOf<BadRequestObjectResult>());
var badRequestResult = (BadRequestObjectResult)result;
Assert.That(badRequestResult.Value, Is.EqualTo("File is empty."));
_mockMediaService.Verify(s => s.UploadMediaAsync(It.IsAny<Media>()), Times.Never);
}
[Test]
public async Task UploadAvatar_ReturnsOkAndPerformsAllActions_WhenFileIsValid()
{
// Arrange
var mediaId = Guid.NewGuid();
var expectedMediaInfo = new MediaUploadResult(mediaId, $"/media/{mediaId}");
var fileName = "test_avatar.jpg";
var fileContent = "This is a test image content";
var stream = new MemoryStream(Encoding.UTF8.GetBytes(fileContent));
var mockFile = new Mock<IFormFile>();
mockFile.Setup(f => f.FileName).Returns(fileName);
mockFile.Setup(f => f.Length).Returns(stream.Length);
mockFile.Setup(f => f.OpenReadStream()).Returns(stream);
mockFile.Setup(f => f.CopyToAsync(It.IsAny<Stream>(), It.IsAny<CancellationToken>()))
.Callback<Stream, CancellationToken>((s, t) => stream.CopyTo(s)); // Для ReadFileAsync
var request = new AvatarUploadRequest
{
FromFile = mockFile.Object,
Type = MediaType.Image,
MimeType = "image/jpeg"
};
_mockMediaService.Setup(s => s.UploadMediaAsync(It.IsAny<Media>()))
.ReturnsAsync(expectedMediaInfo);
_mockProfileService.Setup(s => s.SetNewIcon(_userId, mediaId))
.ReturnsAsync(Govor.Domain.Common.Result.Success());
// Act
var result = await _controller.UploadAvatar(request);
// Assert
Assert.That(result, Is.InstanceOf<OkObjectResult>());
var okResult = (OkObjectResult)result;
Assert.That(okResult.StatusCode, Is.EqualTo(200));
Assert.That(okResult.Value, Is.EqualTo(expectedMediaInfo));
mockFile.Verify(f => f.CopyToAsync(It.IsAny<Stream>(), It.IsAny<CancellationToken>()), Times.Once);
_mockMediaService.Verify(s => s.UploadMediaAsync(It.Is<Media>(m =>
m.OwnerId == _userId &&
m.OwnerType == MediaOwnerType.Avatar &&
m.FileName == fileName
)), Times.Once);
_mockProfileService.Verify(s => s.SetNewIcon(_userId, mediaId), Times.Once);
}
[Test]
public async Task UploadAvatar_ReturnsInternalServerError_WhenMediaServiceFails()
{
// Arrange
var mockFile = new Mock<IFormFile>();
mockFile.Setup(f => f.Length).Returns(100);
mockFile.Setup(f => f.OpenReadStream()).Returns(new MemoryStream(Encoding.UTF8.GetBytes("test")));
var request = new AvatarUploadRequest { FromFile = mockFile.Object };
_mockMediaService.Setup(s => s.UploadMediaAsync(It.IsAny<Media>()))
.ThrowsAsync(new System.Exception("Simulated upload failure"));
// Act
var result = await _controller.UploadAvatar(request);
// Assert
Assert.That(result, Is.InstanceOf<ObjectResult>());
var objectResult = (ObjectResult)result;
Assert.That(objectResult.StatusCode, Is.EqualTo(500));
_mockProfileService.Verify(s => s.SetNewIcon(It.IsAny<Guid>(), It.IsAny<Guid>()), Times.Never);
_mockClientProxy.Verify(
c => c.SendCoreAsync(It.IsAny<string>(), It.IsAny<object?[]?>(), It.IsAny<CancellationToken>()),
Times.Never,
"The Hub should not be called in case of a service error."
);
}
[Test]
public async Task DowloadProfile_ReturnsOk_WhenProfileExists()
{
// Arrange
var userProfile = new UserProfile
{
Id = _userId,
Username = "test_user",
Description = "test description",
IconId = Guid.NewGuid()
};
var userProfileDto = new UserProfileDto
{
Id = _userId,
Username = "test_user",
Description = "test description",
IconId = userProfile.IconId
};
_mockProfileService.Setup(s => s.GetUserProfileAsync(_userId))
.ReturnsAsync(userProfile);
_mockMapper.Setup(m => m.Map<UserProfileDto>(userProfile))
.Returns(userProfileDto);
// Act
var result = await _controller.DownloadProfile();
// Assert
var okResult = result as OkObjectResult;
Assert.That(okResult, Is.Not.Null);
Assert.That(okResult!.StatusCode, Is.EqualTo(200));
Assert.That(okResult.Value, Is.EqualTo(userProfileDto));
}
[Test]
public async Task DowloadProfile_ReturnsForbid_WhenUnauthorizedAccessExceptionThrown()
{
// Arrange
_mockProfileService.Setup(s => s.GetUserProfileAsync(_userId))
.ThrowsAsync(new UnauthorizedAccessException("Access denied"));
// Act
var result = await _controller.DownloadProfile();
// Assert
Assert.That(result, Is.InstanceOf<ForbidResult>());
}
[Test]
public async Task DownloadProfile_MissingProfile_Returns404ProblemDetails()
{
// Arrange
_mockProfileService.Setup(s => s.GetUserProfileAsync(_userId))
.ReturnsAsync(Govor.Domain.Common.Result.Failure<UserProfile>(
Govor.Domain.Common.Error.NotFound("Profile.UserNotFound", "Cannot find profile")));
// Act
var result = await _controller.DownloadProfile();
// Assert
var response = (ObjectResult)result;
Assert.That(response.StatusCode, Is.EqualTo(404));
Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Profile.UserNotFound"));
}
[Test]
public async Task DowloadProfile_Returns500_WhenUnexpectedExceptionThrown()
{
// Arrange
_mockProfileService.Setup(s => s.GetUserProfileAsync(_userId))
.ThrowsAsync(new Exception("Unexpected error"));
// Act
var result = await _controller.DownloadProfile();
// Assert
var objectResult = result as ObjectResult;
Assert.That(objectResult, Is.Not.Null);
Assert.That(objectResult!.StatusCode, Is.EqualTo(500));
Assert.That(objectResult.Value, Is.EqualTo("Unexpected Error! Please try again later."));
}
}
@@ -0,0 +1,92 @@
using AutoMapper;
using Govor.API.Controllers;
using Govor.API.Controllers.AdminStuff;
using Govor.Application.Infrastructure.Extensions;
using Govor.Application.Reactions;
using Govor.Contracts.Responses;
using Govor.Domain.Common;
using Govor.Domain.Models.Reactions;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class ReactionPackControllerTests
{
private readonly Guid _user=Guid.NewGuid(),_pack=Guid.NewGuid(),_reaction=Guid.NewGuid();
private Mock<IReactionPackService> _packs=null!;
private Mock<IMapper> _mapper=null!;
private ReactionPacksController _controller=null!;
private ReactionPacksAdminController _admin=null!;
private ReactionPackResponse _packResponse=null!;
private ReactionItemResponse _itemResponse=null!;
[SetUp] public void Setup()
{
_packs=new();_mapper=new();var user=new Mock<ICurrentUserService>();user.Setup(x=>x.GetCurrentUserId()).Returns(_user);
_packResponse=new();_itemResponse=new();
_mapper.Setup(x=>x.Map<ReactionPackResponse>(It.IsAny<object>())).Returns(_packResponse);
_mapper.Setup(x=>x.Map<ReactionItemResponse>(It.IsAny<object>())).Returns(_itemResponse);
_controller=new(_packs.Object,user.Object,_mapper.Object);
_admin=new(_packs.Object,user.Object,_mapper.Object){ControllerContext=new(){HttpContext=new DefaultHttpContext()}};
}
[TestCase(false)] [TestCase(true)] public async Task ListsForwardPaginationAndVisibility(bool admin)
{
var list=new List<ReactionPack>();var mapped=new List<ReactionPackResponse>();
_packs.Setup(x=>x.ListAsync(_user,false,admin,7,9)).ReturnsAsync(list);
_mapper.Setup(x=>x.Map<List<ReactionPackResponse>>(list)).Returns(mapped);
var result=admin?await _admin.List(7,9):await _controller.List(7,9);
Assert.That(((OkObjectResult)result).Value,Is.SameAs(mapped));
_packs.Verify(x=>x.ListAsync(_user,false,admin,7,9),Times.Once);
_packs.Setup(x=>x.ListAsync(_user,true,false,4,6)).ReturnsAsync(list);
Assert.That(((OkObjectResult)await _controller.Mine(4,6)).Value,Is.SameAs(mapped));
_packs.Verify(x=>x.ListAsync(_user,true,false,4,6),Times.Once);
}
[TestCase(false)] [TestCase(true)] public async Task GetMapsSuccessfulPackOrPreservesFailure(bool failure)
{
_packs.Setup(x=>x.GetAsync(_pack,It.IsAny<bool>())).ReturnsAsync(failure?Result.Failure<ReactionPack>(Error.NotFound("missing","missing")):new ReactionPack());
foreach(var result in new[]{await _controller.Get(_pack),await _admin.Get(_pack)})
if(failure) Assert.That(((ObjectResult)result).StatusCode,Is.EqualTo(404));else Assert.That(((OkObjectResult)result).Value,Is.SameAs(_packResponse));
_packs.Verify(x=>x.GetAsync(_pack,true),Times.Once);_packs.Verify(x=>x.GetAsync(_pack,false),Times.Once);
}
[Test] public async Task SharedAndReactionMapContracts()
{
_packs.Setup(x=>x.GetSharedAsync("share")).ReturnsAsync(new ReactionPack());_packs.Setup(x=>x.GetReactionAsync(_reaction)).ReturnsAsync(new ReactionItem());
Assert.That(((OkObjectResult)await _controller.Shared("share")).Value,Is.SameAs(_packResponse));
Assert.That(((OkObjectResult)await _controller.Reaction(_reaction)).Value,Is.SameAs(_itemResponse));
Assert.That(_controller.Limits(),Is.TypeOf<OkObjectResult>());
}
[TestCase(false)] [TestCase(true)] public async Task SubscriptionsForwardDesiredState(bool subscribe)
{
_packs.Setup(x=>x.SubscribeAsync(_user,_pack,subscribe)).ReturnsAsync(SmartRes.Unit.Value);
var result=subscribe?await _controller.Subscribe(_pack):await _controller.Unsubscribe(_pack);
Assert.That(((StatusCodeResult)result).StatusCode,Is.EqualTo(204));_packs.Verify(x=>x.SubscribeAsync(_user,_pack,subscribe),Times.Once);
}
[Test] public async Task AdminMutationsForwardActorFieldsAndMapContracts()
{
_packs.Setup(x=>x.CreateAsync(_user,"name","desc")).ReturnsAsync(new ReactionPack());
_packs.Setup(x=>x.UpdateAsync(_user,_pack,"new","changed",false)).ReturnsAsync(new ReactionPack());
_packs.Setup(x=>x.DisableAsync(_user,_pack)).ReturnsAsync(SmartRes.Unit.Value);
_packs.Setup(x=>x.AddEmojiAsync(_user,_pack,"emoji","👍")).ReturnsAsync(new ReactionItem());
_packs.Setup(x=>x.DisableReactionAsync(_user,_pack,_reaction)).ReturnsAsync(SmartRes.Unit.Value);
Assert.That(((OkObjectResult)await _admin.Create(new(){Name="name",Description="desc"})).Value,Is.SameAs(_packResponse));
Assert.That(((OkObjectResult)await _admin.Update(_pack,new(){Name="new",Description="changed",IsEnabled=false})).Value,Is.SameAs(_packResponse));
Assert.That(((StatusCodeResult)await _admin.Disable(_pack)).StatusCode,Is.EqualTo(204));
Assert.That(((OkObjectResult)await _admin.Emoji(_pack,new(){Name="emoji",Emoji="👍"})).Value,Is.SameAs(_itemResponse));
Assert.That(((StatusCodeResult)await _admin.DisableReaction(_pack,_reaction)).StatusCode,Is.EqualTo(204));
}
[TestCase(-1)] [TestCase(0)] [TestCase(2_097_153)] public async Task MediaRejectsMissingEmptyOrOversizedFile(int length)
{
var file=new Mock<IFormFile>();file.SetupGet(x=>x.Length).Returns(length);
Assert.That(await _admin.Media(_pack,new(){File=length<0?null!:file.Object}),Is.TypeOf<BadRequestObjectResult>());_packs.VerifyNoOtherCalls();
}
[Test] public async Task MediaCopiesBytesAndPassesRequestCancellation()
{
using var stream=new MemoryStream([1,2,3]);using var cancellation=new CancellationTokenSource();_admin.HttpContext.RequestAborted=cancellation.Token;
_packs.Setup(x=>x.AddMediaAsync(_user,_pack,"image",It.Is<byte[]>(b=>b.SequenceEqual(new byte[]{1,2,3})),cancellation.Token)).ReturnsAsync(new ReactionItem());
var result=await _admin.Media(_pack,new(){Name="image",File=new FormFile(stream,0,3,"file","image.png")});
Assert.That(((OkObjectResult)result).Value,Is.SameAs(_itemResponse));
_packs.Verify(x=>x.AddMediaAsync(_user,_pack,"image",It.IsAny<byte[]>(),cancellation.Token),Times.Once);
}
}
@@ -0,0 +1,93 @@
using AutoMapper;
using Govor.API.Controllers;
using Govor.Application.Users.UserSessions;
using Govor.Contracts.DTOs;
using Govor.Domain.Common;
using Govor.Domain.Models.Users;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class SessionControllerTests
{
private SessionController _controller = null!;
private Mock<IUserSessionReader> _reader = null!;
private Mock<IUserSessionRevoker> _revoker = null!;
private Mock<IMapper> _mapper = null!;
private readonly Guid _user = Guid.NewGuid(), _session = Guid.NewGuid();
[SetUp]
public void SetUp()
{
_reader = new Mock<IUserSessionReader>();
_revoker = new Mock<IUserSessionRevoker>();
_mapper = new Mock<IMapper>();
var current = new Mock<ICurrentUserService>();
current.Setup(c => c.GetCurrentUserId()).Returns(_user);
var session = new Mock<ICurrentUserSessionService>();
session.Setup(s => s.GetUserSessionId()).Returns(_session);
_controller = new(NullLogger<SessionController>.Instance, current.Object,
session.Object, _reader.Object, _revoker.Object, _mapper.Object);
}
[Test]
public async Task SessionsAreReadForCurrentUserAndMapped()
{
var sessions = new List<UserSession> { new() { Id = _session, UserId = _user } };
var dtos = new List<SessionDto> { new() { Id = _session } };
_reader.Setup(r => r.GetAllSessionsAsync(_user)).ReturnsAsync(sessions);
_mapper.Setup(m => m.Map<List<SessionDto>>(sessions)).Returns(dtos);
Assert.That(((OkObjectResult)await _controller.GetAllSessions()).Value, Is.SameAs(dtos));
}
[Test]
public async Task CloseActionsReturn204AndUseCurrentOwner()
{
_revoker.Setup(r => r.CloseSessionByIdAsync(_session, _user)).ReturnsAsync(Result.Success());
_revoker.Setup(r => r.CloseAllSessionsAsync(_user)).ReturnsAsync(Result.Success());
Assert.That(((StatusCodeResult)await _controller.CloseSession(_session)).StatusCode, Is.EqualTo(204));
Assert.That(((StatusCodeResult)await _controller.CloseCurrent()).StatusCode, Is.EqualTo(204));
Assert.That(((StatusCodeResult)await _controller.CloseAllSessions()).StatusCode, Is.EqualTo(204));
_revoker.Verify(r => r.CloseSessionByIdAsync(_session, _user), Times.Exactly(2));
_revoker.Verify(r => r.CloseAllSessionsAsync(_user), Times.Once);
}
[Test]
public async Task EmptySessionIdDoesNotRevokeAnything()
{
Assert.That(await _controller.CloseSession(Guid.Empty), Is.TypeOf<BadRequestObjectResult>());
_revoker.VerifyNoOtherCalls();
}
[TestCase(ErrorType.NotFound, 404)]
[TestCase(ErrorType.Conflict, 409)]
[TestCase(ErrorType.Forbidden, 403)]
public async Task CloseFailuresReturnProblemDetails(ErrorType type, int status)
{
_revoker.Setup(r => r.CloseSessionByIdAsync(_session, _user))
.ReturnsAsync(Result.Failure(new Error("Session.Failed", "failure", type)));
foreach (var action in new Func<Task<IActionResult>>[] { () => _controller.CloseSession(_session), _controller.CloseCurrent })
{
var response = (ObjectResult)await action();
Assert.That(response.StatusCode, Is.EqualTo(status));
Assert.That(((ProblemDetails)response.Value!).Extensions["errorCode"], Is.EqualTo("Session.Failed"));
}
}
[Test]
public async Task UnauthorizedCurrentUserReturnsForbid()
{
_reader.Setup(r => r.GetAllSessionsAsync(_user)).ThrowsAsync(new UnauthorizedAccessException());
Assert.That(await _controller.GetAllSessions(), Is.TypeOf<ForbidResult>());
}
[Test]
public async Task UnexpectedReaderExceptionReturns500()
{
_reader.Setup(r => r.GetAllSessionsAsync(_user)).ThrowsAsync(new Exception("database unavailable"));
Assert.That(((ObjectResult)await _controller.GetAllSessions()).StatusCode, Is.EqualTo(500));
}
}
@@ -0,0 +1,92 @@
using Govor.API.Controllers.Authentication;
using Govor.Application.Friends;
using Govor.Application.Infrastructure.Extensions;
using Govor.Application.Users.UserSessions.Crypto;
using Govor.Contracts.Requests;
using Govor.Contracts.DTOs;
using Govor.Domain.Models.Users;
using Govor.Domain.Models.Users.Crypto;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Controllers;
[TestFixture]
public class SessionKeysControllerTests
{
private readonly Guid _user = Guid.NewGuid(), _session = Guid.NewGuid(), _friend = Guid.NewGuid();
private Mock<IFriendshipService> _friends = null!;
private Mock<ISessionKeyAttacher> _attacher = null!;
private Mock<ISessionKeysReader> _reader = null!;
private Mock<IOneTimePreKeysRotator> _rotator = null!;
private SessionKeysController _controller = null!;
[SetUp]
public void Setup()
{
_friends = new(); _attacher = new(); _reader = new(); _rotator = new();
var user = new Mock<ICurrentUserService>(); user.Setup(x => x.GetCurrentUserId()).Returns(_user);
var session = new Mock<ICurrentUserSessionService>(); session.Setup(x => x.GetUserSessionId()).Returns(_session);
_controller = new(NullLogger<SessionKeysController>.Instance, _friends.Object, session.Object, _attacher.Object, _reader.Object, user.Object, _rotator.Object);
}
[TestCase(false, 0)] [TestCase(false, 100)] [TestCase(false, 101)] [TestCase(true, 1)]
public async Task UploadValidatesModelAndKeyCount(bool invalidModel, int count)
{
var request = new UploadKeysRequest { IdentityKey = [1], SignedPreKey = [2], SignedPreKeySignature = [3], OneTimePreKeys = Enumerable.Range(0,count).Select(_ => new byte[] {4}).ToList() };
if (invalidModel) _controller.ModelState.AddModelError("keys", "invalid");
var result = await _controller.UploadSessionKeys(request);
if (invalidModel || count > 100) { Assert.That(result, Is.TypeOf<BadRequestObjectResult>()); _attacher.VerifyNoOtherCalls(); }
else {
Assert.That(result, Is.TypeOf<OkResult>());
_attacher.Verify(x => x.AttachKeysAsync(_session, request.IdentityKey, request.SignedPreKey, request.SignedPreKeySignature, request.OneTimePreKeys), Times.Once);
}
}
[TestCase(false, 0)] [TestCase(false, 100)] [TestCase(false, 101)] [TestCase(true, 1)]
public async Task RotationValidatesAndUsesAuthenticatedSession(bool invalidModel, int count)
{
var request = new RotateOneTimePreKeysRequest { NewOneTimePreKeys = Enumerable.Range(0,count).Select(_ => new byte[] {4}).ToList() };
if (invalidModel) _controller.ModelState.AddModelError("keys", "invalid");
var result = await _controller.RotateOneTimePreKeys(request);
if (invalidModel || count > 100) { Assert.That(result, Is.TypeOf<BadRequestObjectResult>()); _rotator.VerifyNoOtherCalls(); }
else { Assert.That(result, Is.TypeOf<OkObjectResult>()); _rotator.Verify(x => x.RotateOneTimePreKeysAsync(_session, request.NewOneTimePreKeys), Times.Once); }
}
[Test]
public async Task NonFriendCannotReadKeys()
{
_friends.Setup(x => x.GetFriendsAsync(_friend)).ReturnsAsync([]);
Assert.That(await _controller.GetUserPublicKeys(_friend), Is.TypeOf<ForbidResult>());
_reader.VerifyNoOtherCalls();
}
[Test]
public async Task FriendKeysAreBase64AndUsedPrekeysAreExcluded()
{
_friends.Setup(x => x.GetFriendsAsync(_friend)).ReturnsAsync([new User { Id = _user }]);
var unusedId = Guid.NewGuid();
_reader.Setup(x => x.GetAllActiveKeysAsync(_friend)).ReturnsAsync([
new UserCryptoSession { PublicIdentityKey = [1], SignedPreKey = new() { Id = Guid.NewGuid(), PublicSignedPreKey = [2], SignedPreKeySignature = [3] }, OneTimePreKeys = [new() {Id = unusedId, PublicKey = [4]}, new() {Id = Guid.NewGuid(), PublicKey = [5], IsUsed = true}] },
new UserCryptoSession { PublicIdentityKey = [6], SignedPreKey = null!, OneTimePreKeys = [] }
]);
var dtos = ((IEnumerable<PublicSessionKeysDto>)((OkObjectResult)await _controller.GetUserPublicKeys(_friend)).Value!).ToList();
Assert.Multiple(() => {
Assert.That(dtos[0].IdentityKey, Is.EqualTo("AQ==")); Assert.That(dtos[0].SignedPreKey!.Key, Is.EqualTo("Ag=="));
Assert.That(dtos[0].SignedPreKey!.Signature, Is.EqualTo("Aw==")); Assert.That(dtos[0].OneTimePreKeys.Single().Id, Is.EqualTo(unusedId));
Assert.That(dtos[0].OneTimePreKeys.Single().Key, Is.EqualTo("BA==")); Assert.That(dtos[1].SignedPreKey, Is.Null);
});
}
[Test]
public async Task CountAndConsumptionUseAuthenticatedSession()
{
_reader.Setup(x => x.GetRemainingOneTimePreKeysCountAsync(_session)).ReturnsAsync(17);
var result = (OkObjectResult)await _controller.GetRemainingOneTimePreKeysCount();
Assert.That(result.Value!.GetType().GetProperty("remaining")!.GetValue(result.Value), Is.EqualTo(17));
var key = Guid.NewGuid();
Assert.That(await _controller.MarkOneTimePreKeyAsUsed(key), Is.TypeOf<OkObjectResult>());
_rotator.Verify(x => x.MarkOneTimePreKeyAsUsedAsync(_session, key), Times.Once);
}
}
@@ -0,0 +1,191 @@
using AutoMapper;
using Govor.API.Common.SignalR.Helpers;
using Govor.API.Hubs;
using Govor.API.Hubs.Infrastructure;
using Govor.Application.Exceptions.VerifyFriendship;
using Govor.Application.Infrastructure.Common;
using Govor.Application.Messages;
using Govor.Application.Messages.Parameters;
using Govor.Application.Reactions;
using Govor.Contracts.Requests;
using Govor.Contracts.Requests.SignalR;
using Govor.Contracts.Responses.SignalR;
using Govor.Domain.Common;
using Govor.Domain.Models.Messages;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using System.Security.Claims;
namespace Govor.API.Tests.Unit.Hubs;
[TestFixture]
public class ChatsHubTests
{
private readonly Guid _user = Guid.NewGuid(), _chat = Guid.NewGuid();
private readonly DateTime _now = new(2026,10,24,0,0,0,DateTimeKind.Utc);
private Mock<IMessageReadingService> _read = null!;
private Mock<IMessageSendingService> _send = null!;
private Mock<IMessageEditingService> _edit = null!;
private Mock<IMessageRemovingService> _remove = null!;
private Mock<IMessageReactionService> _reactions = null!;
private Mock<IChatNotificationService> _notifier = null!;
private Mock<IHubUserAccessor> _userAccessor = null!;
private Mock<IConnectionManager> _connections = null!;
private Mock<HubCallerContext> _context = null!;
private Mock<IGroupManager> _groups = null!;
private Mock<IMapper> _mapper = null!;
private ChatsHub _hub = null!;
private Message Message() => new() { Id=Guid.NewGuid(),SenderId=_user,RecipientId=_chat,RecipientType=RecipientType.User,EncryptedContent="cipher",SentAt=_now };
[SetUp]
public void Setup()
{
_read=new(); _send=new(); _edit=new(); _remove=new(); _reactions=new(); _notifier=new(); _connections=new(); _groups=new(); _mapper=new(); _context=new(); _userAccessor=new();
_userAccessor.Setup(x=>x.GetUserId(It.IsAny<HubCallerContext>(),It.IsAny<bool>())).Returns(_user);
var clock=new Mock<INowDateTimeProvider>(); clock.SetupGet(x=>x.Now).Returns(_now);
_context.SetupGet(x=>x.ConnectionId).Returns("connection");
_context.SetupGet(x=>x.User).Returns(new ClaimsPrincipal(new ClaimsIdentity(new[]{new Claim("sid",_chat.ToString())})));
_hub=new(NullLogger<ChatsHub>.Instance,_read.Object,_send.Object,_edit.Object,_remove.Object,_userAccessor.Object,_notifier.Object,clock.Object,_connections.Object,_reactions.Object,_mapper.Object) {Context=_context.Object,Groups=_groups.Object};
}
[TearDown] public void TearDown()=>_hub.Dispose();
[TestCase(false)] [TestCase(true)]
public async Task LifecycleMaintainsConnectionAndSessionGroup(bool error)
{
await _hub.OnConnectedAsync(); await _hub.OnDisconnectedAsync(error?new Exception("disconnect"):null);
_connections.Verify(x=>x.OnConnectedAsync("connection",_user),Times.Once);
_connections.Verify(x=>x.OnDisconnectedAsync("connection",_user),Times.Once);
_groups.Verify(x=>x.AddToGroupAsync("connection",ChatHubConstants.GetSessionGroup(_chat),default),Times.Once);
}
[TestCase(false)] [TestCase(true)]
public async Task MissingUserOrSessionAbortsConnection(bool missingUser)
{
if(missingUser) _userAccessor.Setup(x=>x.GetUserId(It.IsAny<HubCallerContext>(),It.IsAny<bool>())).Returns(Guid.Empty);
else _context.SetupGet(x=>x.User).Returns(new ClaimsPrincipal());
await _hub.OnConnectedAsync(); _context.Verify(x=>x.Abort(),Times.Once); _groups.VerifyNoOtherCalls();
}
[TestCase(false)] [TestCase(true)]
public async Task SendMapsActorClockReplyAndMediaThenNotifies(bool media)
{
var message=Message(); var mediaId=Guid.NewGuid(); var reply=Guid.NewGuid();
if (media) message.MediaAttachments = [new() { MediaFile = new() { Id = mediaId } }];
_send.Setup(x=>x.SendMessageAsync(It.IsAny<SendMessage>())).ReturnsAsync(new SendMessageResult(true,null,message));
var response=await _hub.Send(new() {RecipientId=_chat,EncryptedContent="cipher",ReplyToMessageId=reply,MediaAttachments=media?[new(){MediaId=mediaId,EncryptedKey="key"}]:null!});
Assert.That(response.Status,Is.EqualTo(HubResultStatus.Success));
Assert.That(response.Result!.ReplyToMessageId,Is.EqualTo(reply));
Assert.That(response.Result.MediaAttachments.Select(m => m.Id), Is.EqualTo(media ? new[] { mediaId } : Array.Empty<Guid>()));
_send.Verify(x=>x.SendMessageAsync(It.Is<SendMessage>(p=>p.FromUserId==_user && p.RecipientId==_chat && p.SendAt==_now && p.ReplyToMessageId==reply && p.Media.Count()==(media?1:0))),Times.Once);
_notifier.Verify(x=>x.NotifyMessageSentAsync(response.Result!),Times.Once);
}
[TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)]
public async Task InvalidSendNeverInvokesService(int kind)
{
MessageRequest? request=kind switch {0=>null,1=>new(){EncryptedContent=" "},2=>new(){EncryptedContent=new string('a',1_000_001)},_=>new(){EncryptedContent="",MediaAttachments=null!}};
Assert.That((await _hub.Send(request!)).Status,Is.EqualTo(HubResultStatus.BadRequest)); _send.VerifyNoOtherCalls(); _notifier.VerifyNoOtherCalls();
}
[TestCase(0,HubResultStatus.Forbidden)] [TestCase(1,HubResultStatus.Unauthorized)]
[TestCase(2,HubResultStatus.BadRequest)] [TestCase(3,HubResultStatus.NotFound)]
[TestCase(4,HubResultStatus.BadRequest)] [TestCase(5,HubResultStatus.ServerError)]
public async Task ServiceExceptionsMapToHubStatus(int kind,HubResultStatus expected)
{
Exception error=kind switch {0=>new UnauthorizedAccessException(),1=>new FriendshipException("friend"),2=>new ArgumentException("invalid"),3=>new KeyNotFoundException(),4=>new InvalidOperationException("conflict"),_=>new Exception("private detail")};
_send.Setup(x=>x.SendMessageAsync(It.IsAny<SendMessage>())).ReturnsAsync(new SendMessageResult(false,error,null!));
var response=await _hub.Send(new(){EncryptedContent="cipher"}); Assert.That(response.Status,Is.EqualTo(expected));
if(kind==5) Assert.That(response.ErrorMessage,Does.Not.Contain("private detail"));
_notifier.VerifyNoOtherCalls();
}
[Test]
public async Task SendFailureWithoutExceptionIsBadRequest()
{
_send.Setup(x=>x.SendMessageAsync(It.IsAny<SendMessage>())).ReturnsAsync(new SendMessageResult(false,null,null!));
Assert.That((await _hub.Send(new(){EncryptedContent="cipher"})).Status,Is.EqualTo(HubResultStatus.BadRequest));
}
[Test]
public async Task ReadMapsCurrentReadersViewAndNotifies()
{
var message=Message(); var view=new MessageView{Id=Guid.NewGuid(),UserId=_user,ViewedAt=_now}; message.MessageViews=[new(){UserId=Guid.NewGuid()},view];
_read.Setup(x=>x.ReadMessageAsync(_user,message.Id)).ReturnsAsync(message);
var result=await _hub.Read(new(){MessageId=message.Id});
Assert.That(result.Result!.ViewId,Is.EqualTo(view.Id)); Assert.That(result.Result.ReaderId,Is.EqualTo(_user));
_notifier.Verify(x=>x.NotifyMessageWasReadAsync(result.Result!),Times.Once);
}
[Test]
public async Task ReadFailureDoesNotNotify()
{
_read.Setup(x=>x.ReadMessageAsync(_user,It.IsAny<Guid>())).ReturnsAsync(Govor.Domain.Common.Result.Failure<Message>(Error.NotFound("missing","missing")));
Assert.That((await _hub.Read(new())).Status,Is.EqualTo(HubResultStatus.NotFound)); _notifier.VerifyNoOtherCalls();
}
[TestCase(false)] [TestCase(true)]
public async Task ReadChatMapsResultOrFailure(bool failure)
{
var value=new ChatReadResult(_chat,RecipientType.User,_user,_now,null,null,[Guid.NewGuid()],2,3);
_read.Setup(x=>x.ReadChatAsync(_user,_chat,RecipientType.User,null,null)).ReturnsAsync(failure?Govor.Domain.Common.Result.Failure<ChatReadResult>(Error.Forbidden("denied","denied")):value);
var result=await _hub.ReadChat(_chat,new(){RecipientType=RecipientType.User});
Assert.That(result.Status,Is.EqualTo(failure?HubResultStatus.Forbidden:HubResultStatus.Success));
if(failure) _notifier.VerifyNoOtherCalls(); else {Assert.That(result.Result!.ReadCount,Is.EqualTo(2)); Assert.That(result.Result.UnreadCount,Is.EqualTo(3)); _notifier.Verify(x=>x.NotifyChatReadAsync(result.Result!),Times.Once);}
}
[TestCase(RemoveMessageRequestType.HideForMe,false)] [TestCase(RemoveMessageRequestType.ForceRemove,true)] [TestCase((RemoveMessageRequestType)99,false)]
public async Task RemovalMapsScopeAndNotifies(RemoveMessageRequestType type,bool force)
{
var message=Message();
_remove.Setup(x=>x.DeleteMessageAsync(It.IsAny<DeleteMessage>())).ReturnsAsync(message);
var result=await _hub.Remove(new(){MessageId=message.Id,RequestType=type});
Assert.That(result.Status,Is.EqualTo(HubResultStatus.Success));
_remove.Verify(x=>x.DeleteMessageAsync(new DeleteMessage(_user,message.Id,force)),Times.Once);
_notifier.Verify(x=>x.NotifyMessageRemovedAsync(result.Result!),Times.Once);
}
[Test]
public async Task RemovalFailureDoesNotNotify()
{
_remove.Setup(x=>x.DeleteMessageAsync(It.IsAny<DeleteMessage>())).ReturnsAsync(Govor.Domain.Common.Result.Failure<Message>(Error.Forbidden("denied","denied")));
Assert.That((await _hub.Remove(new())).Status,Is.EqualTo(HubResultStatus.Forbidden)); _notifier.VerifyNoOtherCalls();
}
[TestCase(false)] [TestCase(true)]
public async Task EditSuccessUsesClockAndPreservesRouting(bool noOriginal)
{
var message=Message(); message.ReplyToMessageId=Guid.NewGuid();
_edit.Setup(x=>x.EditMessageAsync(It.IsAny<EditMessage>())).ReturnsAsync(new EditMessageResult(true,null,noOriginal?null:message));
var result=await _hub.Edit(new(){MessageId=message.Id,NewEncryptedContent="new cipher"});
if(noOriginal){Assert.That(result.Status,Is.EqualTo(HubResultStatus.BadRequest)); _notifier.VerifyNoOtherCalls();return;}
Assert.That(result.Result!.ReplyToMessageId,Is.EqualTo(message.ReplyToMessageId)); Assert.That(result.Result.EditedAt,Is.EqualTo(_now));
_edit.Verify(x=>x.EditMessageAsync(new EditMessage(_user,message.Id,"new cipher",_now)),Times.Once);
_notifier.Verify(x=>x.NotifyMessageEditedAsync(result.Result!),Times.Once);
}
[TestCase(false,false)] [TestCase(true,false)] [TestCase(true,true)]
public async Task ReactionsNotifyOnlyOnChange(bool changed,bool remove)
{
var message=Guid.NewGuid(); Guid? reaction=remove?null:Guid.NewGuid();
var state=new MessageReactionState(message,_chat,RecipientType.User,1,_user,null,[],changed);
_reactions.Setup(x=>x.SetAsync(_user,message,reaction)).ReturnsAsync(state);
var mapped=new MessageReactionsChangedResponse(); _mapper.Setup(x=>x.Map<MessageReactionsChangedResponse>(state)).Returns(mapped);
var result=remove?await _hub.RemoveReaction(message):await _hub.React(message,new(){ReactionId=reaction!.Value});
Assert.That(result.Result,Is.SameAs(mapped));
_notifier.Verify(x=>x.NotifyMessageReactionsChangedAsync(mapped),changed?Times.Once():Times.Never());
}
[Test]
public async Task ReactionFailureDoesNotNotify()
{
_reactions.Setup(x=>x.SetAsync(_user,It.IsAny<Guid>(),It.IsAny<Guid?>())).ReturnsAsync(Govor.Domain.Common.Result.Failure<MessageReactionState>(Error.Forbidden("denied","denied")));
Assert.That((await _hub.RemoveReaction(Guid.NewGuid())).Status,Is.EqualTo(HubResultStatus.Forbidden)); _notifier.VerifyNoOtherCalls();
}
[Test]
public async Task NullRequestsAreRejected()
{
Assert.That((await _hub.Read(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
Assert.That((await _hub.ReadChat(_chat,null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
Assert.That((await _hub.Remove(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
Assert.That((await _hub.Edit(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
Assert.That((await _hub.React(Guid.NewGuid(),null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
_notifier.VerifyNoOtherCalls();
}
}
@@ -0,0 +1,40 @@
using AutoMapper;
using Govor.API.Common.SignalR.Helpers;
using Govor.API.Hubs;
using Govor.Application.Friends;
using Govor.Contracts.Responses.SignalR;
using Govor.Domain.Common;
using Govor.Domain.Models;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.API.Tests.Unit.Hubs;
[TestFixture]
public class FriendsHubBoundaryTests
{
[TestCase(false,false)] [TestCase(false,true)] [TestCase(true,false)] [TestCase(true,true)]
public async Task LifecycleHandlesMissingUserAndDisconnectErrors(bool invalid,bool error)
{
var id=invalid?Guid.Empty:Guid.NewGuid();var accessor=new Mock<IHubUserAccessor>();accessor.Setup(x=>x.GetUserId(It.IsAny<HubCallerContext>(),It.IsAny<bool>())).Returns(id);
var context=new Mock<HubCallerContext>();context.SetupGet(x=>x.ConnectionId).Returns("connection");var groups=new Mock<IGroupManager>();
using var hub=new FriendsHub(NullLogger<FriendsHub>.Instance,Mock.Of<IFriendRequestCommandService>(),accessor.Object,Mock.Of<IMapper>()){Context=context.Object,Groups=groups.Object};
await hub.OnConnectedAsync();await hub.OnDisconnectedAsync(error?new Exception("disconnect"):null);
context.Verify(x=>x.Abort(),invalid?Times.Once():Times.Never());
groups.Verify(x=>x.AddToGroupAsync("connection",id.ToString(),default),invalid?Times.Never():Times.Once());
groups.Verify(x=>x.RemoveFromGroupAsync("connection",id.ToString(),default),invalid?Times.Never():Times.Once());
}
[TestCase(0)] [TestCase(1)] [TestCase(2)] public async Task FailedFriendCommandsDoNotNotify(int operation)
{
var commands=new Mock<IFriendRequestCommandService>();var id=Guid.NewGuid();
commands.Setup(x=>x.SendAsync(It.IsAny<Guid>(),id)).ReturnsAsync(Result.Failure<Friendship>(Error.Forbidden("denied","denied")));
commands.Setup(x=>x.AcceptAsync(id,It.IsAny<Guid>())).ReturnsAsync(Result.Failure<Friendship>(Error.Forbidden("denied","denied")));
commands.Setup(x=>x.RejectAsync(id,It.IsAny<Guid>())).ReturnsAsync(Result.Failure<Friendship>(Error.Forbidden("denied","denied")));
var clients=new Mock<IHubCallerClients>(MockBehavior.Strict);
using var hub=new FriendsHub(NullLogger<FriendsHub>.Instance,commands.Object,Mock.Of<IHubUserAccessor>(),Mock.Of<IMapper>()){Clients=clients.Object};
var result=operation switch{0=>await hub.SendRequest(id),1=>await hub.AcceptRequest(id),_=>await hub.RejectRequest(id)};
Assert.That(result.Status,Is.EqualTo(operation==0?HubResultStatus.ServerError:HubResultStatus.BadRequest));clients.VerifyNoOtherCalls();
}
}
@@ -0,0 +1,342 @@
using AutoFixture;
using AutoMapper;
using Govor.API.Common.SignalR.Helpers;
using Govor.API.Hubs;
using Govor.Application.Exceptions.FriendsService;
using Govor.Contracts.DTOs;
using Govor.Contracts.Responses.SignalR;
using Govor.Domain.Models;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging;
using Moq;
namespace Govor.API.Tests.Unit.Hubs;
[TestFixture]
public class FriendsHubTests
{
private Mock<IFriendRequestCommandService> _friendRequestServiceMock = null!;
private Mock<IHubUserAccessor> _currentUserServiceMock = null!;
private Mock<IHubCallerClients> _clientsMock = null!;
private Mock<IClientProxy> _clientProxyMock = null!;
private Mock<ILogger<FriendsHub>> _loggerMock = null!;
private Mock<IMapper> _mapperMock = null!;
private FriendsHub _hub = null!;
private Fixture _fixture = null!;
private readonly Guid _userId = Guid.NewGuid();
private readonly Guid _targetUserId = Guid.NewGuid();
[SetUp]
public void Setup()
{
_fixture = new Fixture();
_fixture.Behaviors.OfType<ThrowingRecursionBehavior>().ToList().ForEach(b => _fixture.Behaviors.Remove(b));
_fixture.Behaviors.Add(new OmitOnRecursionBehavior());
_friendRequestServiceMock = new Mock<IFriendRequestCommandService>();
_currentUserServiceMock = new Mock<IHubUserAccessor>();
_clientsMock = new Mock<IHubCallerClients>();
_clientProxyMock = new Mock<IClientProxy>();
_loggerMock = new Mock<ILogger<FriendsHub>>();
_mapperMock = new Mock<IMapper>();
_currentUserServiceMock.Setup(x => x.GetUserId(
It.IsAny<HubCallerContext>(),
It.IsAny<bool>()))
.Returns(_userId);
_clientsMock.Setup(c => c.Group(It.IsAny<string>())).Returns(_clientProxyMock.Object);
_hub = new FriendsHub(
_loggerMock.Object,
_friendRequestServiceMock.Object,
_currentUserServiceMock.Object,
_mapperMock.Object)
{
Clients = _clientsMock.Object
};
}
// Tests for SendRequest action
[Test]
public async Task SendRequest_ShouldReturnCreated_WhenSuccess()
{
var friendship = _fixture.Build<Friendship>()
.With(f => f.Status, FriendshipStatus.Pending)
.With(f => f.RequesterId, _userId)
.With(f =>f.AddresseeId, _targetUserId)
.Create();
var dto = new FriendshipDto()
{
Id = friendship.Id,
Status = FriendshipStatus.Accepted,
AddresseeId = friendship.AddresseeId,
RequesterId = friendship.RequesterId,
};
_mapperMock.Setup(f => f.Map<FriendshipDto>(friendship))
.Returns(dto);
_friendRequestServiceMock.Setup(f => f.SendAsync(_userId, _targetUserId))
.ReturnsAsync(friendship);
// Act
var result = await _hub.SendRequest(_targetUserId);
// Assert
Assert.That(result, Is.Not.Null);
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Created));
_friendRequestServiceMock.Verify(s => s.SendAsync(_userId, _targetUserId), Times.Once);
_clientProxyMock.Verify(c => c.SendCoreAsync(
"FriendRequestReceived",
It.Is<object[]>(o => o[0]!.Equals(dto)),
default), Times.Once);
}
[Test]
public async Task SendRequest_ShouldReturnBadRequest_WhenInvalidOperation()
{
// Arrange
_friendRequestServiceMock
.Setup(s => s.SendAsync(_userId, _targetUserId))
.ThrowsAsync(new InvalidOperationException("Invalid"));
// Act
var result = await _hub.SendRequest(_targetUserId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.BadRequest));
Assert.That(result.ErrorMessage, Is.EqualTo("Invalid"));
}
[Test]
public async Task SendRequest_ShouldReturnConflict_WhenAlreadySent()
{
// Arrange
_friendRequestServiceMock
.Setup(s => s.SendAsync(_userId, _targetUserId))
.ThrowsAsync(new RequestAlreadySentException(_userId, _targetUserId));
// Act
var result = await _hub.SendRequest(_targetUserId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Conflict));
Assert.That(result.ErrorMessage, Is.EqualTo($"Request was already sent from {_userId} to {_targetUserId}"));
}
[Test]
public async Task SendRequest_ShouldReturnUnauthorized_WhenCurrentUserIsNotAuthenticated()
{
// Arrange
_currentUserServiceMock.Setup(x => x.GetUserId(It.IsAny<HubCallerContext>(), It.IsAny<bool>()))
.Throws(new UnauthorizedAccessException("userId claim is missing or invalid"));
// Act
var result = await _hub.SendRequest(_targetUserId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Unauthorized));
Assert.That(result.ErrorMessage, Is.EqualTo("userId claim is missing or invalid"));
}
[Test]
public async Task SendRequest_ShouldReturnError_WhenSomeExceptionOccurs()
{
// Arrange
_friendRequestServiceMock
.Setup(s => s.SendAsync(_userId, _targetUserId))
.ThrowsAsync(new Exception("error"));
// Act
var result = await _hub.SendRequest(_targetUserId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError));
Assert.That(result.ErrorMessage, Is.EqualTo("Unexpected error! Please try later!"));
}
// Test for AcceptRequest action
[Test]
public async Task AcceptRequest_ShouldReturnOk_WhenSuccess()
{
// Arrange
var friendship = _fixture.Build<Friendship>()
.With(f => f.Status, FriendshipStatus.Pending)
.Create();
var dto = new FriendshipDto()
{
Id = friendship.Id,
Status = FriendshipStatus.Accepted,
AddresseeId = friendship.AddresseeId,
RequesterId = friendship.RequesterId
};
_mapperMock.Setup(f => f.Map<FriendshipDto>(friendship))
.Returns(dto);
_friendRequestServiceMock.Setup(f => f.AcceptAsync(friendship.Id, _userId))
.ReturnsAsync(friendship);
// Act
var result = await _hub.AcceptRequest(friendship.Id);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Success));
_friendRequestServiceMock.Verify(s => s.AcceptAsync(friendship.Id, _userId), Times.Once);
_clientProxyMock.Verify(c => c.SendCoreAsync(
"FriendRequestAccepted",
It.Is<object[]>(o => o.Length == 1 && o[0] == dto),
default), Times.Once);
}
[Test]
public async Task AcceptRequest_ShouldReturnBadRequest_InvalidOperation()
{
// Arrange
var friendshipId = Guid.NewGuid();
_friendRequestServiceMock
.Setup(s => s.AcceptAsync(friendshipId, _userId))
.ThrowsAsync(new InvalidOperationException("Invalid"));
// Act
var result = await _hub.AcceptRequest(friendshipId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.BadRequest));
Assert.That(result.ErrorMessage, Is.EqualTo("Invalid"));
}
[Test]
public async Task AcceptRequest_ShouldReturnUnauthorized_UnauthorizedAccess()
{
// Arrange
var friendshipId = Guid.NewGuid();
_friendRequestServiceMock
.Setup(s => s.AcceptAsync(friendshipId, _userId))
.ThrowsAsync(new UnauthorizedAccessException("userId claim is missing or invalid"));
// Act
var result = await _hub.AcceptRequest(friendshipId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Unauthorized));
Assert.That(result.ErrorMessage, Is.EqualTo("userId claim is missing or invalid"));
}
[Test]
public async Task AcceptRequest_ShouldReturnError_WhenSomeExceptionOccurs()
{
// Arrange
var friendshipId = Guid.NewGuid();
_friendRequestServiceMock
.Setup(s => s.AcceptAsync(friendshipId, _userId))
.ThrowsAsync(new Exception("error"));
// Act
var result = await _hub.AcceptRequest(friendshipId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError));
Assert.That(result.ErrorMessage, Is.EqualTo("Unexpected error! Please try later!"));
}
// Test for RejectRequest action
[Test]
public async Task RejectRequest_ShouldReturnOk_WhenSuccess()
{
// Arrange
var friendship = _fixture.Build<Friendship>()
.With(f => f.Status, FriendshipStatus.Pending)
.Create();
var dto = new FriendshipDto()
{
Id = friendship.Id,
Status = FriendshipStatus.Accepted,
AddresseeId = friendship.AddresseeId,
RequesterId = friendship.RequesterId
};
_mapperMock.Setup(f => f.Map<FriendshipDto>(friendship))
.Returns(dto);
_friendRequestServiceMock.Setup(f => f.RejectAsync(friendship.Id, _userId))
.ReturnsAsync(friendship);
// Act
var result = await _hub.RejectRequest(friendship.Id);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Success));
_friendRequestServiceMock.Verify(s => s.RejectAsync(friendship.Id, _userId), Times.Once);
_clientProxyMock.Verify(c => c.SendCoreAsync(
"FriendRequestRejected",
It.Is<object[]>(o => o[0]!.Equals(dto)),
default), Times.Once);
}
[Test]
public async Task RejectRequest_ShouldReturnBadRequest_InvalidOperation()
{
// Arrange
var friendshipId = Guid.NewGuid();
_friendRequestServiceMock
.Setup(s => s.RejectAsync(friendshipId, _userId))
.ThrowsAsync(new InvalidOperationException("Invalid"));
// Act
var result = await _hub.RejectRequest(friendshipId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.BadRequest));
Assert.That(result.ErrorMessage, Is.EqualTo("Invalid"));
}
[Test]
public async Task RejectRequest_ShouldReturnUnauthorized_UnauthorizedAccess()
{
// Arrange
var friendshipId = Guid.NewGuid();
_friendRequestServiceMock
.Setup(s => s.RejectAsync(friendshipId, _userId))
.ThrowsAsync(new UnauthorizedAccessException("userId claim is missing or invalid"));
// Act
var result = await _hub.RejectRequest(friendshipId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Unauthorized));
Assert.That(result.ErrorMessage, Is.EqualTo("userId claim is missing or invalid"));
}
[Test]
public async Task RejectRequest_ShouldReturnError_WhenSomeExceptionOccurs()
{
// Arrange
var friendshipId = Guid.NewGuid();
_friendRequestServiceMock
.Setup(s => s.RejectAsync(friendshipId, _userId))
.ThrowsAsync(new Exception("error"));
// Act
var result = await _hub.RejectRequest(friendshipId);
// Assert
Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError));
Assert.That(result.ErrorMessage, Is.EqualTo("Unexpected error! Please try later!"));
}
[TearDown]
public void TearDown()
{
_hub?.Dispose();
}
}
@@ -0,0 +1,113 @@
using System.Security.Claims;
using Govor.API.Common.SignalR.Helpers;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging;
using Moq;
namespace Govor.API.Tests.Common.SignalR.Helpers;
[TestFixture]
[TestOf(typeof(HubUserAccessor))]
public class HubUserAccessorTests
{
private HubUserAccessor _accessor = null!;
private Mock<ILogger<HubUserAccessor>> _loggerMock = null!;
[SetUp]
public void SetUp()
{
_loggerMock = new Mock<ILogger<HubUserAccessor>>();
_accessor = new HubUserAccessor(_loggerMock.Object);
}
private HubCallerContext CreateContextWithClaims(params Claim[] claims)
{
var principal = new ClaimsPrincipal(new ClaimsIdentity(claims));
var contextMock = new Mock<HubCallerContext>();
contextMock.Setup(c => c.User).Returns(principal);
return contextMock.Object;
}
[Test]
public void GetUserId_ValidClaim_ReturnsGuid()
{
// Arrange
var expectedGuid = Guid.NewGuid();
var context = CreateContextWithClaims(new Claim("userId", expectedGuid.ToString()));
// Act
var result = _accessor.GetUserId(context);
// Assert
Assert.That(expectedGuid, Is.EqualTo(result));
}
[Test]
public void GetUserId_InvalidClaim_ThrowsException_WhenNotSuppressed()
{
// Arrange
var context = CreateContextWithClaims(new Claim("userId", "not-a-guid"));
// Act & Assert
Assert.Throws<UnauthorizedAccessException>(() => _accessor.GetUserId(context, suppressException: false));
}
[Test]
public void GetUserId_InvalidClaim_ReturnsEmptyGuid_WhenSuppressed()
{
// Arrange
var context = CreateContextWithClaims(new Claim("userId", "not-a-guid"));
// Act
var result = _accessor.GetUserId(context, suppressException: true);
// Assert
Assert.That(Guid.Empty, Is.EqualTo(result));
}
[Test]
public void GetUserId_NoClaim_ThrowsException_WhenNotSuppressed()
{
// Arrange
var context = CreateContextWithClaims();
// Act & Assert
Assert.Throws<UnauthorizedAccessException>(() => _accessor.GetUserId(context, suppressException: false));
}
[Test]
public void GetUserId_NoClaim_ReturnsEmptyGuid_WhenSuppressed()
{
// Arrange
var context = CreateContextWithClaims();
// Act
var result = _accessor.GetUserId(context, suppressException: true);
// Assert
Assert.That(Guid.Empty, Is.EqualTo(result));
}
[Test]
public void GetUserId_UserIsNull_ReturnsEmptyGuid_WhenSuppressed()
{
// Arrange
var contextMock = new Mock<HubCallerContext>();
contextMock.Setup(c => c.User).Returns((ClaimsPrincipal?)null);
// Act
var result = _accessor.GetUserId(contextMock.Object, suppressException: true);
// Assert
Assert.That(Guid.Empty, Is.EqualTo(result));
}
[Test]
public void GetUserId_UserIsNull_ThrowsException_WhenNotSuppressed()
{
// Arrange
var contextMock = new Mock<HubCallerContext>();
contextMock.Setup(c => c.User).Returns((ClaimsPrincipal?)null);
// Act & Assert
Assert.Throws<UnauthorizedAccessException>(() => _accessor.GetUserId(contextMock.Object, suppressException: false));
}
}
@@ -0,0 +1,142 @@
using Govor.API.Hubs.Infrastructure;
namespace Govor.API.Tests.Unit.Hubs.Infrastructure;
[TestFixture]
public class ConnectionStoreTests
{
private ConnectionStore _store = null!;
[SetUp]
public void Setup()
{
_store = new ConnectionStore();
}
[Test]
public void AddConnection_AddsConnection()
{
// Arrange
var userId = Guid.NewGuid();
var connectionId = "conn1";
// Act
_store.AddConnection(userId, connectionId);
var connections = _store.GetConnections(userId);
// Assert
Assert.That(connections, Contains.Item(connectionId));
}
[Test]
public void AddConnection_DoesNotDuplicateConnection()
{
// Arrange
var userId = Guid.NewGuid();
var connectionId = "conn1";
// Act
_store.AddConnection(userId, connectionId);
_store.AddConnection(userId, connectionId);
var connections = _store.GetConnections(userId).ToList();
// Assert
Assert.That(connections.Count, Is.EqualTo(1));
}
[Test]
public void RemoveConnection_RemovesConnection()
{
// Arrange
var userId = Guid.NewGuid();
var connectionId = "conn1";
// Act
_store.AddConnection(userId, connectionId);
_store.RemoveConnection(userId, connectionId);
var connections = _store.GetConnections(userId);
// Assert
Assert.That(connections, Is.Empty);
}
[Test]
public void RemoveConnection_LastConnection_RemovesUserEntry()
{
// Arrange
var userId = Guid.NewGuid();
var connectionId = "conn1";
// Act
_store.AddConnection(userId, connectionId);
_store.RemoveConnection(userId, connectionId);
var connections = _store.GetConnections(userId);
// Assert
Assert.That(connections, Is.Empty);
}
[Test]
public void RemoveConnection_NonExistingUser_DoesNotThrow()
{
// Arrange
var userId = Guid.NewGuid();
// Act & Assert
Assert.DoesNotThrow(() =>
_store.RemoveConnection(userId, "conn1"));
}
[Test]
public void GetConnections_NonExistingUser_ReturnsEmpty()
{
// Arrange
var userId = Guid.NewGuid();
// Act
var connections = _store.GetConnections(userId);
// Assert
Assert.That(connections, Is.Empty);
}
[Test]
public void MultipleUsers_IsolatedConnections()
{
// Arrange
var userA = Guid.NewGuid();
var userB = Guid.NewGuid();
// Act
_store.AddConnection(userA, "A1");
_store.AddConnection(userB, "B1");
var connectionsA = _store.GetConnections(userA);
var connectionsB = _store.GetConnections(userB);
// Assert
Assert.That(connectionsA, Contains.Item("A1"));
Assert.That(connectionsB, Contains.Item("B1"));
Assert.That(connectionsA, Does.Not.Contain("B1"));
}
[Test]
public void MultipleConnections_ForSameUser_WorkCorrectly()
{
// Arrange
var userId = Guid.NewGuid();
// Act
_store.AddConnection(userId, "conn1");
_store.AddConnection(userId, "conn2");
var connections = _store.GetConnections(userId).ToList();
// Assert
Assert.That(connections.Count, Is.EqualTo(2));
Assert.That(connections, Contains.Item("conn1"));
Assert.That(connections, Contains.Item("conn2"));
}
}
@@ -0,0 +1,153 @@
using Govor.API.Hubs;
using Govor.API.Hubs.Infrastructure;
using Govor.Application.Infrastructure.Extensions;
using Govor.Domain.Models;
using Microsoft.AspNetCore.SignalR;
using Moq;
namespace Govor.API.Tests.Unit.Hubs.Infrastructure;
[TestFixture]
public class PrivateChatGroupManagerTests
{
private Mock<IConnectionStore> _connectionStoreMock = null!;
private Mock<IHubContext<ChatsHub>> _hubContextMock = null!;
private Mock<IGroupManager> _groupsMock = null!;
private PrivateChatGroupManager _service = null!;
[SetUp]
public void Setup()
{
_connectionStoreMock = new Mock<IConnectionStore>();
_groupsMock = new Mock<IGroupManager>();
_hubContextMock = new Mock<IHubContext<ChatsHub>>();
_hubContextMock
.SetupGet(h => h.Groups)
.Returns(_groupsMock.Object);
_service = new PrivateChatGroupManager(
_connectionStoreMock.Object,
_hubContextMock.Object);
}
[Test]
public async Task AddUsersToPrivateChatGroupAsync_AddsAllConnectionsToGroup()
{
// Arrange
var chat = new PrivateChat
{
Id = Guid.NewGuid(),
UserAId = Guid.NewGuid(),
UserBId = Guid.NewGuid()
};
var connectionsA = new List<string> { "connA1", "connA2" };
var connectionsB = new List<string> { "connB1" };
_connectionStoreMock
.Setup(s => s.GetConnections(chat.UserAId))
.Returns(connectionsA);
_connectionStoreMock
.Setup(s => s.GetConnections(chat.UserBId))
.Returns(connectionsB);
var expectedGroup = ChatHubConstants.GetPrivateChat(chat.Id);
// Act
await _service.AddUsersToPrivateChatGroupAsync(chat);
// Assert
foreach (var conn in connectionsA.Concat(connectionsB))
{
_groupsMock.Verify(
g => g.AddToGroupAsync(conn, expectedGroup, default),
Times.Once);
}
}
[Test]
public async Task RemoveUsersFromPrivateChatGroupAsync_RemovesAllConnectionsFromGroup()
{
// Arrange
var chat = new PrivateChat
{
Id = Guid.NewGuid(),
UserAId = Guid.NewGuid(),
UserBId = Guid.NewGuid()
};
var connectionsA = new List<string> { "connA1" };
var connectionsB = new List<string> { "connB1", "connB2" };
_connectionStoreMock
.Setup(s => s.GetConnections(chat.UserAId))
.Returns(connectionsA);
_connectionStoreMock
.Setup(s => s.GetConnections(chat.UserBId))
.Returns(connectionsB);
var expectedGroup = ChatHubConstants.GetPrivateChat(chat.Id);
// Act
await _service.RemoveUsersFromPrivateChatGroupAsync(chat);
// Assert
foreach (var conn in connectionsA.Concat(connectionsB))
{
_groupsMock.Verify(
g => g.RemoveFromGroupAsync(conn, expectedGroup, default),
Times.Once);
}
}
[Test]
public async Task AddUsersToPrivateChatGroupAsync_NoConnections_DoesNothing()
{
// Arrange
var chat = new PrivateChat
{
Id = Guid.NewGuid(),
UserAId = Guid.NewGuid(),
UserBId = Guid.NewGuid()
};
_connectionStoreMock
.Setup(s => s.GetConnections(It.IsAny<Guid>()))
.Returns(new List<string>());
// Act
await _service.AddUsersToPrivateChatGroupAsync(chat);
// Assert
_groupsMock.Verify(
g => g.AddToGroupAsync(It.IsAny<string>(), It.IsAny<string>(), default),
Times.Never);
}
[Test]
public async Task RemoveUsersFromPrivateChatGroupAsync_NoConnections_DoesNothing()
{
// Arrange
var chat = new PrivateChat
{
Id = Guid.NewGuid(),
UserAId = Guid.NewGuid(),
UserBId = Guid.NewGuid()
};
_connectionStoreMock
.Setup(s => s.GetConnections(It.IsAny<Guid>()))
.Returns(new List<string>());
// Act
await _service.RemoveUsersFromPrivateChatGroupAsync(chat);
// Assert
_groupsMock.Verify(
g => g.RemoveFromGroupAsync(It.IsAny<string>(), It.IsAny<string>(), default),
Times.Never);
}
}
@@ -0,0 +1,153 @@
using Govor.API.Common.SignalR.Helpers;
using Govor.API.Hubs;
using Govor.Application.Friends;
using Govor.Application.Medias;
using Govor.Application.Profiles;
using Govor.Application.Synching;
using Govor.Application.Users.UserOnlineStatus;
using Govor.Contracts.Responses.SignalR;
using Govor.Domain.Common;
using Govor.Domain.Models.Users;
using Microsoft.AspNetCore.SignalR;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
using SmartRes;
namespace Govor.API.Tests.Unit.Hubs;
[TestFixture]
public class ProfileHubTests
{
private readonly Guid _user = Guid.NewGuid(), _friend = Guid.NewGuid();
private Mock<IFriendshipService> _friends = null!;
private Mock<IProfileService> _profiles = null!;
private Mock<IMediaService> _media = null!;
private Mock<IClientProxy> _proxy = null!;
private Mock<IHubCallerClients> _clients = null!;
private Mock<IGroupManager> _groups = null!;
private ProfileHub _hub = null!;
private List<string> _recipients = null!;
[SetUp]
public void Setup()
{
_friends = new(); _profiles = new(); _media = new(); _proxy = new(); _clients = new(); _groups = new(); _recipients = [];
var accessor = new Mock<IHubUserAccessor>(); accessor.Setup(x => x.GetUserId(It.IsAny<HubCallerContext>(), It.IsAny<bool>())).Returns(_user);
var sync = new Mock<ISynchingService>(); sync.Setup(x => x.NormalizeNewlines(It.IsAny<string>())).Returns((string s) => s.Replace("\r\n", "\n"));
_clients.Setup(x => x.Groups(It.IsAny<IReadOnlyList<string>>())).Callback<IReadOnlyList<string>>(ids => _recipients.AddRange(ids)).Returns(_proxy.Object);
var context = new Mock<HubCallerContext>(); context.SetupGet(x => x.ConnectionId).Returns("connection");
_friends.Setup(x => x.GetFriendsAsync(_user)).ReturnsAsync([new() {Id = _friend}, new() {Id = Guid.Empty}]);
_friends.Setup(x => x.GetPotentialFriendsAsync(_user)).ReturnsAsync([new() {Id = _friend}, new() {Id = Guid.Empty}]);
_profiles.Setup(x => x.SetDescription(It.IsAny<string>(), _user)).ReturnsAsync(SmartRes.Unit.Value);
_profiles.Setup(x => x.SetNewIcon(_user, It.IsAny<Guid>())).ReturnsAsync(SmartRes.Unit.Value);
_media.Setup(x => x.HasMediaAsync(It.IsAny<Guid>())).ReturnsAsync(true);
_hub = new(_friends.Object, _profiles.Object, accessor.Object, sync.Object, _media.Object, NullLogger<ProfileHub>.Instance) { Clients = _clients.Object, Context = context.Object, Groups = _groups.Object };
}
[TearDown] public void TearDown() => _hub.Dispose();
[TestCase(null)] [TestCase("")]
public async Task DescriptionNullIsRejectedAndEmptyIsAllowed(string? description)
{
var result = await _hub.SetDescription(description);
Assert.That(result.Status, Is.EqualTo(description is null ? HubResultStatus.BadRequest : HubResultStatus.Success));
if (description is null) _profiles.VerifyNoOtherCalls();
}
[TestCase(500, HubResultStatus.Success)] [TestCase(501, HubResultStatus.BadRequest)]
public async Task DescriptionLengthBoundary(int size, HubResultStatus expected) => Assert.That((await _hub.SetDescription(new string('a',size))).Status, Is.EqualTo(expected));
[Test]
public async Task DescriptionNormalizesAndNotifiesDistinctNonemptyRecipients()
{
var result = await _hub.SetDescription("one\r\ntwo");
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Success));
_profiles.Verify(x => x.SetDescription("one\ntwo", _user), Times.Once);
Assert.That(_recipients, Is.EquivalentTo(new[] {$"user:{_user}", $"user:{_friend}"}));
_proxy.Verify(x => x.SendCoreAsync("DescriptionUpdated", It.Is<object?[]>(args => args.Length == 1), default), Times.Once);
}
[TestCase(false)] [TestCase(true)]
public async Task ProfileServiceFailuresDoNotNotify(bool avatar)
{
_profiles.Setup(x => x.SetDescription(It.IsAny<string>(), _user)).ReturnsAsync(Result.Failure<SmartRes.Unit>(Error.Forbidden("denied", "denied")));
_profiles.Setup(x => x.SetNewIcon(_user, It.IsAny<Guid>())).ReturnsAsync(Result.Failure<SmartRes.Unit>(Error.Forbidden("denied", "denied")));
var result = avatar ? await _hub.SetAvatar(Guid.NewGuid()) : await _hub.SetDescription("hello");
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Forbidden)); _proxy.VerifyNoOtherCalls();
}
[TestCase(false)] [TestCase(true)]
public async Task ProfileServiceExceptionsReturnServerError(bool avatar)
{
_profiles.Setup(x => x.SetDescription(It.IsAny<string>(), _user)).ThrowsAsync(new Exception("failure"));
_profiles.Setup(x => x.SetNewIcon(_user, It.IsAny<Guid>())).ThrowsAsync(new Exception("failure"));
var result = avatar ? await _hub.SetAvatar(Guid.NewGuid()) : await _hub.SetDescription("hello");
Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError)); _proxy.VerifyNoOtherCalls();
}
[TestCase(true)] [TestCase(false)]
public async Task InvalidAvatarNeverChangesProfile(bool empty)
{
_media.Setup(x => x.HasMediaAsync(It.IsAny<Guid>())).ReturnsAsync(false);
Assert.That((await _hub.SetAvatar(empty ? Guid.Empty : Guid.NewGuid())).Status, Is.EqualTo(HubResultStatus.BadRequest));
_profiles.VerifyNoOtherCalls();
}
[Test]
public async Task AvatarPersistsAndNotifies()
{
var icon = Guid.NewGuid();
Assert.That((await _hub.SetAvatar(icon)).Status, Is.EqualTo(HubResultStatus.Success));
_profiles.Verify(x => x.SetNewIcon(_user, icon), Times.Once);
_proxy.Verify(x => x.SendCoreAsync("AvatarUpdated", It.IsAny<object?[]>(), default), Times.Once);
}
[TestCase(false)] [TestCase(true)]
public async Task NotificationFailuresDoNotUndoPersistedProfile(bool deliveryFailure)
{
if (deliveryFailure) _proxy.Setup(x => x.SendCoreAsync(It.IsAny<string>(), It.IsAny<object?[]>(), default)).ThrowsAsync(new Exception("transport"));
else {
_friends.Setup(x => x.GetFriendsAsync(_user)).ThrowsAsync(new Exception("friends"));
_friends.Setup(x => x.GetPotentialFriendsAsync(_user)).ThrowsAsync(new Exception("potential"));
}
Assert.That((await _hub.SetDescription("hello")).Status, Is.EqualTo(HubResultStatus.Success));
if (!deliveryFailure) Assert.That(_recipients, Is.EqualTo(new[] { $"user:{_user}" }));
}
[TestCase(false)] [TestCase(true)]
public async Task LifecycleMaintainsUserGroup(bool error)
{
await _hub.OnConnectedAsync(); await _hub.OnDisconnectedAsync(error ? new Exception("disconnect") : null);
_groups.Verify(x => x.AddToGroupAsync("connection", $"user:{_user}", default), Times.Once);
_groups.Verify(x => x.RemoveFromGroupAsync("connection", $"user:{_user}", default), Times.Once);
}
}
[TestFixture]
public class PresenceHubTests
{
[TestCase(true, true)] [TestCase(true, false)] [TestCase(false, true)] [TestCase(false, false)]
public async Task OnlyFirstConnectionAndLastDisconnectionBroadcast(bool first, bool last)
{
var user = Guid.NewGuid(); var friend = Guid.NewGuid();
var accessor = new Mock<IHubUserAccessor>(); accessor.Setup(x => x.GetUserId(It.IsAny<HubCallerContext>(), It.IsAny<bool>())).Returns(user);
var store = new Mock<IOnlineUserStore>(); store.Setup(x => x.AddConnection(user,"connection")).Returns(first); store.Setup(x => x.RemoveConnection(user,"connection")).Returns(last);
var scope = new Mock<IUserNotificationScopeService>(); scope.Setup(x => x.GetNotifiedUsers(user)).ReturnsAsync([friend]);
var proxy = new Mock<IClientProxy>(); var clients = new Mock<IHubCallerClients>(); clients.Setup(x => x.Groups(It.Is<IReadOnlyList<string>>(ids => ids.SequenceEqual(new[] {friend.ToString()})))).Returns(proxy.Object);
var groups = new Mock<IGroupManager>(); var context = new Mock<HubCallerContext>(); context.SetupGet(x => x.ConnectionId).Returns("connection");
using var hub = new PresenceHub(NullLogger<PresenceHub>.Instance,scope.Object,store.Object,accessor.Object) { Context = context.Object, Clients = clients.Object, Groups = groups.Object };
await hub.OnConnectedAsync(); await hub.OnDisconnectedAsync(null!);
proxy.Verify(x => x.SendCoreAsync("UserOnline",It.Is<object?[]>(args => Equals(args[0],user)),default),first ? Times.Once() : Times.Never());
proxy.Verify(x => x.SendCoreAsync("UserOffline",It.Is<object?[]>(args => Equals(args[0],user)),default),last ? Times.Once() : Times.Never());
groups.Verify(x => x.AddToGroupAsync("connection",user.ToString(),default),Times.Once);
groups.Verify(x => x.RemoveFromGroupAsync("connection",user.ToString(),default),Times.Once);
}
[Test]
public async Task InvalidUserAbortsWithoutStoreOrNotifications()
{
var accessor = new Mock<IHubUserAccessor>(); var context = new Mock<HubCallerContext>();
var store = new Mock<IOnlineUserStore>(MockBehavior.Strict); var scope = new Mock<IUserNotificationScopeService>(MockBehavior.Strict);
using var hub = new PresenceHub(NullLogger<PresenceHub>.Instance,scope.Object,store.Object,accessor.Object) {Context=context.Object};
await hub.OnConnectedAsync(); await hub.OnDisconnectedAsync(null!);
context.Verify(x => x.Abort(),Times.Once); store.VerifyNoOtherCalls(); scope.VerifyNoOtherCalls();
}
}