mirror of
https://github.com/Govor-team/Govor.git
synced 2026-11-17 12:59:25 +00:00
Expand server tests and enforce coverage
Consolidate server tests under tests/, upgrade them to .NET 10, and add CI coverage thresholds and reports. Expand API and application boundary coverage while fixing related issues in media handling, friend blocking, session crypto, presence, username validation, and local storage.
This commit is contained in:
@@ -0,0 +1,191 @@
|
||||
using AutoMapper;
|
||||
using Govor.API.Common.SignalR.Helpers;
|
||||
using Govor.API.Hubs;
|
||||
using Govor.API.Hubs.Infrastructure;
|
||||
using Govor.Application.Exceptions.VerifyFriendship;
|
||||
using Govor.Application.Infrastructure.Common;
|
||||
using Govor.Application.Messages;
|
||||
using Govor.Application.Messages.Parameters;
|
||||
using Govor.Application.Reactions;
|
||||
using Govor.Contracts.Requests;
|
||||
using Govor.Contracts.Requests.SignalR;
|
||||
using Govor.Contracts.Responses.SignalR;
|
||||
using Govor.Domain.Common;
|
||||
using Govor.Domain.Models.Messages;
|
||||
using Microsoft.AspNetCore.SignalR;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Moq;
|
||||
using System.Security.Claims;
|
||||
|
||||
namespace Govor.API.Tests.Unit.Hubs;
|
||||
|
||||
[TestFixture]
|
||||
public class ChatsHubTests
|
||||
{
|
||||
private readonly Guid _user = Guid.NewGuid(), _chat = Guid.NewGuid();
|
||||
private readonly DateTime _now = new(2026,10,24,0,0,0,DateTimeKind.Utc);
|
||||
private Mock<IMessageReadingService> _read = null!;
|
||||
private Mock<IMessageSendingService> _send = null!;
|
||||
private Mock<IMessageEditingService> _edit = null!;
|
||||
private Mock<IMessageRemovingService> _remove = null!;
|
||||
private Mock<IMessageReactionService> _reactions = null!;
|
||||
private Mock<IChatNotificationService> _notifier = null!;
|
||||
private Mock<IHubUserAccessor> _userAccessor = null!;
|
||||
private Mock<IConnectionManager> _connections = null!;
|
||||
private Mock<HubCallerContext> _context = null!;
|
||||
private Mock<IGroupManager> _groups = null!;
|
||||
private Mock<IMapper> _mapper = null!;
|
||||
private ChatsHub _hub = null!;
|
||||
private Message Message() => new() { Id=Guid.NewGuid(),SenderId=_user,RecipientId=_chat,RecipientType=RecipientType.User,EncryptedContent="cipher",SentAt=_now };
|
||||
|
||||
[SetUp]
|
||||
public void Setup()
|
||||
{
|
||||
_read=new(); _send=new(); _edit=new(); _remove=new(); _reactions=new(); _notifier=new(); _connections=new(); _groups=new(); _mapper=new(); _context=new(); _userAccessor=new();
|
||||
_userAccessor.Setup(x=>x.GetUserId(It.IsAny<HubCallerContext>(),It.IsAny<bool>())).Returns(_user);
|
||||
var clock=new Mock<INowDateTimeProvider>(); clock.SetupGet(x=>x.Now).Returns(_now);
|
||||
_context.SetupGet(x=>x.ConnectionId).Returns("connection");
|
||||
_context.SetupGet(x=>x.User).Returns(new ClaimsPrincipal(new ClaimsIdentity(new[]{new Claim("sid",_chat.ToString())})));
|
||||
_hub=new(NullLogger<ChatsHub>.Instance,_read.Object,_send.Object,_edit.Object,_remove.Object,_userAccessor.Object,_notifier.Object,clock.Object,_connections.Object,_reactions.Object,_mapper.Object) {Context=_context.Object,Groups=_groups.Object};
|
||||
}
|
||||
[TearDown] public void TearDown()=>_hub.Dispose();
|
||||
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task LifecycleMaintainsConnectionAndSessionGroup(bool error)
|
||||
{
|
||||
await _hub.OnConnectedAsync(); await _hub.OnDisconnectedAsync(error?new Exception("disconnect"):null);
|
||||
_connections.Verify(x=>x.OnConnectedAsync("connection",_user),Times.Once);
|
||||
_connections.Verify(x=>x.OnDisconnectedAsync("connection",_user),Times.Once);
|
||||
_groups.Verify(x=>x.AddToGroupAsync("connection",ChatHubConstants.GetSessionGroup(_chat),default),Times.Once);
|
||||
}
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task MissingUserOrSessionAbortsConnection(bool missingUser)
|
||||
{
|
||||
if(missingUser) _userAccessor.Setup(x=>x.GetUserId(It.IsAny<HubCallerContext>(),It.IsAny<bool>())).Returns(Guid.Empty);
|
||||
else _context.SetupGet(x=>x.User).Returns(new ClaimsPrincipal());
|
||||
await _hub.OnConnectedAsync(); _context.Verify(x=>x.Abort(),Times.Once); _groups.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task SendMapsActorClockReplyAndMediaThenNotifies(bool media)
|
||||
{
|
||||
var message=Message(); var mediaId=Guid.NewGuid(); var reply=Guid.NewGuid();
|
||||
if (media) message.MediaAttachments = [new() { MediaFile = new() { Id = mediaId } }];
|
||||
_send.Setup(x=>x.SendMessageAsync(It.IsAny<SendMessage>())).ReturnsAsync(new SendMessageResult(true,null,message));
|
||||
var response=await _hub.Send(new() {RecipientId=_chat,EncryptedContent="cipher",ReplyToMessageId=reply,MediaAttachments=media?[new(){MediaId=mediaId,EncryptedKey="key"}]:null!});
|
||||
Assert.That(response.Status,Is.EqualTo(HubResultStatus.Success));
|
||||
Assert.That(response.Result!.ReplyToMessageId,Is.EqualTo(reply));
|
||||
Assert.That(response.Result.MediaAttachments.Select(m => m.Id), Is.EqualTo(media ? new[] { mediaId } : Array.Empty<Guid>()));
|
||||
_send.Verify(x=>x.SendMessageAsync(It.Is<SendMessage>(p=>p.FromUserId==_user && p.RecipientId==_chat && p.SendAt==_now && p.ReplyToMessageId==reply && p.Media.Count()==(media?1:0))),Times.Once);
|
||||
_notifier.Verify(x=>x.NotifyMessageSentAsync(response.Result!),Times.Once);
|
||||
}
|
||||
|
||||
[TestCase(0)] [TestCase(1)] [TestCase(2)] [TestCase(3)]
|
||||
public async Task InvalidSendNeverInvokesService(int kind)
|
||||
{
|
||||
MessageRequest? request=kind switch {0=>null,1=>new(){EncryptedContent=" "},2=>new(){EncryptedContent=new string('a',1_000_001)},_=>new(){EncryptedContent="",MediaAttachments=null!}};
|
||||
Assert.That((await _hub.Send(request!)).Status,Is.EqualTo(HubResultStatus.BadRequest)); _send.VerifyNoOtherCalls(); _notifier.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[TestCase(0,HubResultStatus.Forbidden)] [TestCase(1,HubResultStatus.Unauthorized)]
|
||||
[TestCase(2,HubResultStatus.BadRequest)] [TestCase(3,HubResultStatus.NotFound)]
|
||||
[TestCase(4,HubResultStatus.BadRequest)] [TestCase(5,HubResultStatus.ServerError)]
|
||||
public async Task ServiceExceptionsMapToHubStatus(int kind,HubResultStatus expected)
|
||||
{
|
||||
Exception error=kind switch {0=>new UnauthorizedAccessException(),1=>new FriendshipException("friend"),2=>new ArgumentException("invalid"),3=>new KeyNotFoundException(),4=>new InvalidOperationException("conflict"),_=>new Exception("private detail")};
|
||||
_send.Setup(x=>x.SendMessageAsync(It.IsAny<SendMessage>())).ReturnsAsync(new SendMessageResult(false,error,null!));
|
||||
var response=await _hub.Send(new(){EncryptedContent="cipher"}); Assert.That(response.Status,Is.EqualTo(expected));
|
||||
if(kind==5) Assert.That(response.ErrorMessage,Does.Not.Contain("private detail"));
|
||||
_notifier.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task SendFailureWithoutExceptionIsBadRequest()
|
||||
{
|
||||
_send.Setup(x=>x.SendMessageAsync(It.IsAny<SendMessage>())).ReturnsAsync(new SendMessageResult(false,null,null!));
|
||||
Assert.That((await _hub.Send(new(){EncryptedContent="cipher"})).Status,Is.EqualTo(HubResultStatus.BadRequest));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task ReadMapsCurrentReadersViewAndNotifies()
|
||||
{
|
||||
var message=Message(); var view=new MessageView{Id=Guid.NewGuid(),UserId=_user,ViewedAt=_now}; message.MessageViews=[new(){UserId=Guid.NewGuid()},view];
|
||||
_read.Setup(x=>x.ReadMessageAsync(_user,message.Id)).ReturnsAsync(message);
|
||||
var result=await _hub.Read(new(){MessageId=message.Id});
|
||||
Assert.That(result.Result!.ViewId,Is.EqualTo(view.Id)); Assert.That(result.Result.ReaderId,Is.EqualTo(_user));
|
||||
_notifier.Verify(x=>x.NotifyMessageWasReadAsync(result.Result!),Times.Once);
|
||||
}
|
||||
[Test]
|
||||
public async Task ReadFailureDoesNotNotify()
|
||||
{
|
||||
_read.Setup(x=>x.ReadMessageAsync(_user,It.IsAny<Guid>())).ReturnsAsync(Govor.Domain.Common.Result.Failure<Message>(Error.NotFound("missing","missing")));
|
||||
Assert.That((await _hub.Read(new())).Status,Is.EqualTo(HubResultStatus.NotFound)); _notifier.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task ReadChatMapsResultOrFailure(bool failure)
|
||||
{
|
||||
var value=new ChatReadResult(_chat,RecipientType.User,_user,_now,null,null,[Guid.NewGuid()],2,3);
|
||||
_read.Setup(x=>x.ReadChatAsync(_user,_chat,RecipientType.User,null,null)).ReturnsAsync(failure?Govor.Domain.Common.Result.Failure<ChatReadResult>(Error.Forbidden("denied","denied")):value);
|
||||
var result=await _hub.ReadChat(_chat,new(){RecipientType=RecipientType.User});
|
||||
Assert.That(result.Status,Is.EqualTo(failure?HubResultStatus.Forbidden:HubResultStatus.Success));
|
||||
if(failure) _notifier.VerifyNoOtherCalls(); else {Assert.That(result.Result!.ReadCount,Is.EqualTo(2)); Assert.That(result.Result.UnreadCount,Is.EqualTo(3)); _notifier.Verify(x=>x.NotifyChatReadAsync(result.Result!),Times.Once);}
|
||||
}
|
||||
|
||||
[TestCase(RemoveMessageRequestType.HideForMe,false)] [TestCase(RemoveMessageRequestType.ForceRemove,true)] [TestCase((RemoveMessageRequestType)99,false)]
|
||||
public async Task RemovalMapsScopeAndNotifies(RemoveMessageRequestType type,bool force)
|
||||
{
|
||||
var message=Message();
|
||||
_remove.Setup(x=>x.DeleteMessageAsync(It.IsAny<DeleteMessage>())).ReturnsAsync(message);
|
||||
var result=await _hub.Remove(new(){MessageId=message.Id,RequestType=type});
|
||||
Assert.That(result.Status,Is.EqualTo(HubResultStatus.Success));
|
||||
_remove.Verify(x=>x.DeleteMessageAsync(new DeleteMessage(_user,message.Id,force)),Times.Once);
|
||||
_notifier.Verify(x=>x.NotifyMessageRemovedAsync(result.Result!),Times.Once);
|
||||
}
|
||||
[Test]
|
||||
public async Task RemovalFailureDoesNotNotify()
|
||||
{
|
||||
_remove.Setup(x=>x.DeleteMessageAsync(It.IsAny<DeleteMessage>())).ReturnsAsync(Govor.Domain.Common.Result.Failure<Message>(Error.Forbidden("denied","denied")));
|
||||
Assert.That((await _hub.Remove(new())).Status,Is.EqualTo(HubResultStatus.Forbidden)); _notifier.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task EditSuccessUsesClockAndPreservesRouting(bool noOriginal)
|
||||
{
|
||||
var message=Message(); message.ReplyToMessageId=Guid.NewGuid();
|
||||
_edit.Setup(x=>x.EditMessageAsync(It.IsAny<EditMessage>())).ReturnsAsync(new EditMessageResult(true,null,noOriginal?null:message));
|
||||
var result=await _hub.Edit(new(){MessageId=message.Id,NewEncryptedContent="new cipher"});
|
||||
if(noOriginal){Assert.That(result.Status,Is.EqualTo(HubResultStatus.BadRequest)); _notifier.VerifyNoOtherCalls();return;}
|
||||
Assert.That(result.Result!.ReplyToMessageId,Is.EqualTo(message.ReplyToMessageId)); Assert.That(result.Result.EditedAt,Is.EqualTo(_now));
|
||||
_edit.Verify(x=>x.EditMessageAsync(new EditMessage(_user,message.Id,"new cipher",_now)),Times.Once);
|
||||
_notifier.Verify(x=>x.NotifyMessageEditedAsync(result.Result!),Times.Once);
|
||||
}
|
||||
|
||||
[TestCase(false,false)] [TestCase(true,false)] [TestCase(true,true)]
|
||||
public async Task ReactionsNotifyOnlyOnChange(bool changed,bool remove)
|
||||
{
|
||||
var message=Guid.NewGuid(); Guid? reaction=remove?null:Guid.NewGuid();
|
||||
var state=new MessageReactionState(message,_chat,RecipientType.User,1,_user,null,[],changed);
|
||||
_reactions.Setup(x=>x.SetAsync(_user,message,reaction)).ReturnsAsync(state);
|
||||
var mapped=new MessageReactionsChangedResponse(); _mapper.Setup(x=>x.Map<MessageReactionsChangedResponse>(state)).Returns(mapped);
|
||||
var result=remove?await _hub.RemoveReaction(message):await _hub.React(message,new(){ReactionId=reaction!.Value});
|
||||
Assert.That(result.Result,Is.SameAs(mapped));
|
||||
_notifier.Verify(x=>x.NotifyMessageReactionsChangedAsync(mapped),changed?Times.Once():Times.Never());
|
||||
}
|
||||
[Test]
|
||||
public async Task ReactionFailureDoesNotNotify()
|
||||
{
|
||||
_reactions.Setup(x=>x.SetAsync(_user,It.IsAny<Guid>(),It.IsAny<Guid?>())).ReturnsAsync(Govor.Domain.Common.Result.Failure<MessageReactionState>(Error.Forbidden("denied","denied")));
|
||||
Assert.That((await _hub.RemoveReaction(Guid.NewGuid())).Status,Is.EqualTo(HubResultStatus.Forbidden)); _notifier.VerifyNoOtherCalls();
|
||||
}
|
||||
[Test]
|
||||
public async Task NullRequestsAreRejected()
|
||||
{
|
||||
Assert.That((await _hub.Read(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
|
||||
Assert.That((await _hub.ReadChat(_chat,null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
|
||||
Assert.That((await _hub.Remove(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
|
||||
Assert.That((await _hub.Edit(null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
|
||||
Assert.That((await _hub.React(Guid.NewGuid(),null!)).Status,Is.EqualTo(HubResultStatus.BadRequest));
|
||||
_notifier.VerifyNoOtherCalls();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,40 @@
|
||||
using AutoMapper;
|
||||
using Govor.API.Common.SignalR.Helpers;
|
||||
using Govor.API.Hubs;
|
||||
using Govor.Application.Friends;
|
||||
using Govor.Contracts.Responses.SignalR;
|
||||
using Govor.Domain.Common;
|
||||
using Govor.Domain.Models;
|
||||
using Microsoft.AspNetCore.SignalR;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Moq;
|
||||
|
||||
namespace Govor.API.Tests.Unit.Hubs;
|
||||
|
||||
[TestFixture]
|
||||
public class FriendsHubBoundaryTests
|
||||
{
|
||||
[TestCase(false,false)] [TestCase(false,true)] [TestCase(true,false)] [TestCase(true,true)]
|
||||
public async Task LifecycleHandlesMissingUserAndDisconnectErrors(bool invalid,bool error)
|
||||
{
|
||||
var id=invalid?Guid.Empty:Guid.NewGuid();var accessor=new Mock<IHubUserAccessor>();accessor.Setup(x=>x.GetUserId(It.IsAny<HubCallerContext>(),It.IsAny<bool>())).Returns(id);
|
||||
var context=new Mock<HubCallerContext>();context.SetupGet(x=>x.ConnectionId).Returns("connection");var groups=new Mock<IGroupManager>();
|
||||
using var hub=new FriendsHub(NullLogger<FriendsHub>.Instance,Mock.Of<IFriendRequestCommandService>(),accessor.Object,Mock.Of<IMapper>()){Context=context.Object,Groups=groups.Object};
|
||||
await hub.OnConnectedAsync();await hub.OnDisconnectedAsync(error?new Exception("disconnect"):null);
|
||||
context.Verify(x=>x.Abort(),invalid?Times.Once():Times.Never());
|
||||
groups.Verify(x=>x.AddToGroupAsync("connection",id.ToString(),default),invalid?Times.Never():Times.Once());
|
||||
groups.Verify(x=>x.RemoveFromGroupAsync("connection",id.ToString(),default),invalid?Times.Never():Times.Once());
|
||||
}
|
||||
[TestCase(0)] [TestCase(1)] [TestCase(2)] public async Task FailedFriendCommandsDoNotNotify(int operation)
|
||||
{
|
||||
var commands=new Mock<IFriendRequestCommandService>();var id=Guid.NewGuid();
|
||||
commands.Setup(x=>x.SendAsync(It.IsAny<Guid>(),id)).ReturnsAsync(Result.Failure<Friendship>(Error.Forbidden("denied","denied")));
|
||||
commands.Setup(x=>x.AcceptAsync(id,It.IsAny<Guid>())).ReturnsAsync(Result.Failure<Friendship>(Error.Forbidden("denied","denied")));
|
||||
commands.Setup(x=>x.RejectAsync(id,It.IsAny<Guid>())).ReturnsAsync(Result.Failure<Friendship>(Error.Forbidden("denied","denied")));
|
||||
var clients=new Mock<IHubCallerClients>(MockBehavior.Strict);
|
||||
using var hub=new FriendsHub(NullLogger<FriendsHub>.Instance,commands.Object,Mock.Of<IHubUserAccessor>(),Mock.Of<IMapper>()){Clients=clients.Object};
|
||||
var result=operation switch{0=>await hub.SendRequest(id),1=>await hub.AcceptRequest(id),_=>await hub.RejectRequest(id)};
|
||||
Assert.That(result.Status,Is.EqualTo(operation==0?HubResultStatus.ServerError:HubResultStatus.BadRequest));clients.VerifyNoOtherCalls();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,342 @@
|
||||
using AutoFixture;
|
||||
using AutoMapper;
|
||||
using Govor.API.Common.SignalR.Helpers;
|
||||
using Govor.API.Hubs;
|
||||
using Govor.Application.Exceptions.FriendsService;
|
||||
using Govor.Contracts.DTOs;
|
||||
using Govor.Contracts.Responses.SignalR;
|
||||
using Govor.Domain.Models;
|
||||
using Microsoft.AspNetCore.SignalR;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Moq;
|
||||
|
||||
namespace Govor.API.Tests.Unit.Hubs;
|
||||
|
||||
[TestFixture]
|
||||
public class FriendsHubTests
|
||||
{
|
||||
private Mock<IFriendRequestCommandService> _friendRequestServiceMock = null!;
|
||||
private Mock<IHubUserAccessor> _currentUserServiceMock = null!;
|
||||
private Mock<IHubCallerClients> _clientsMock = null!;
|
||||
private Mock<IClientProxy> _clientProxyMock = null!;
|
||||
private Mock<ILogger<FriendsHub>> _loggerMock = null!;
|
||||
private Mock<IMapper> _mapperMock = null!;
|
||||
private FriendsHub _hub = null!;
|
||||
private Fixture _fixture = null!;
|
||||
private readonly Guid _userId = Guid.NewGuid();
|
||||
private readonly Guid _targetUserId = Guid.NewGuid();
|
||||
|
||||
[SetUp]
|
||||
public void Setup()
|
||||
{
|
||||
_fixture = new Fixture();
|
||||
_fixture.Behaviors.OfType<ThrowingRecursionBehavior>().ToList().ForEach(b => _fixture.Behaviors.Remove(b));
|
||||
_fixture.Behaviors.Add(new OmitOnRecursionBehavior());
|
||||
|
||||
_friendRequestServiceMock = new Mock<IFriendRequestCommandService>();
|
||||
_currentUserServiceMock = new Mock<IHubUserAccessor>();
|
||||
_clientsMock = new Mock<IHubCallerClients>();
|
||||
_clientProxyMock = new Mock<IClientProxy>();
|
||||
_loggerMock = new Mock<ILogger<FriendsHub>>();
|
||||
_mapperMock = new Mock<IMapper>();
|
||||
|
||||
_currentUserServiceMock.Setup(x => x.GetUserId(
|
||||
It.IsAny<HubCallerContext>(),
|
||||
It.IsAny<bool>()))
|
||||
.Returns(_userId);
|
||||
|
||||
_clientsMock.Setup(c => c.Group(It.IsAny<string>())).Returns(_clientProxyMock.Object);
|
||||
|
||||
_hub = new FriendsHub(
|
||||
_loggerMock.Object,
|
||||
_friendRequestServiceMock.Object,
|
||||
_currentUserServiceMock.Object,
|
||||
_mapperMock.Object)
|
||||
{
|
||||
Clients = _clientsMock.Object
|
||||
};
|
||||
}
|
||||
|
||||
// Tests for SendRequest action
|
||||
[Test]
|
||||
public async Task SendRequest_ShouldReturnCreated_WhenSuccess()
|
||||
{
|
||||
var friendship = _fixture.Build<Friendship>()
|
||||
.With(f => f.Status, FriendshipStatus.Pending)
|
||||
.With(f => f.RequesterId, _userId)
|
||||
.With(f =>f.AddresseeId, _targetUserId)
|
||||
.Create();
|
||||
|
||||
var dto = new FriendshipDto()
|
||||
{
|
||||
Id = friendship.Id,
|
||||
Status = FriendshipStatus.Accepted,
|
||||
AddresseeId = friendship.AddresseeId,
|
||||
RequesterId = friendship.RequesterId,
|
||||
};
|
||||
|
||||
_mapperMock.Setup(f => f.Map<FriendshipDto>(friendship))
|
||||
.Returns(dto);
|
||||
|
||||
_friendRequestServiceMock.Setup(f => f.SendAsync(_userId, _targetUserId))
|
||||
.ReturnsAsync(friendship);
|
||||
|
||||
// Act
|
||||
var result = await _hub.SendRequest(_targetUserId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result, Is.Not.Null);
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Created));
|
||||
|
||||
_friendRequestServiceMock.Verify(s => s.SendAsync(_userId, _targetUserId), Times.Once);
|
||||
|
||||
_clientProxyMock.Verify(c => c.SendCoreAsync(
|
||||
"FriendRequestReceived",
|
||||
It.Is<object[]>(o => o[0]!.Equals(dto)),
|
||||
default), Times.Once);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task SendRequest_ShouldReturnBadRequest_WhenInvalidOperation()
|
||||
{
|
||||
// Arrange
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.SendAsync(_userId, _targetUserId))
|
||||
.ThrowsAsync(new InvalidOperationException("Invalid"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.SendRequest(_targetUserId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.BadRequest));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("Invalid"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task SendRequest_ShouldReturnConflict_WhenAlreadySent()
|
||||
{
|
||||
// Arrange
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.SendAsync(_userId, _targetUserId))
|
||||
.ThrowsAsync(new RequestAlreadySentException(_userId, _targetUserId));
|
||||
|
||||
// Act
|
||||
var result = await _hub.SendRequest(_targetUserId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Conflict));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo($"Request was already sent from {_userId} to {_targetUserId}"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task SendRequest_ShouldReturnUnauthorized_WhenCurrentUserIsNotAuthenticated()
|
||||
{
|
||||
// Arrange
|
||||
_currentUserServiceMock.Setup(x => x.GetUserId(It.IsAny<HubCallerContext>(), It.IsAny<bool>()))
|
||||
.Throws(new UnauthorizedAccessException("userId claim is missing or invalid"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.SendRequest(_targetUserId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Unauthorized));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("userId claim is missing or invalid"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task SendRequest_ShouldReturnError_WhenSomeExceptionOccurs()
|
||||
{
|
||||
// Arrange
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.SendAsync(_userId, _targetUserId))
|
||||
.ThrowsAsync(new Exception("error"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.SendRequest(_targetUserId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("Unexpected error! Please try later!"));
|
||||
}
|
||||
|
||||
// Test for AcceptRequest action
|
||||
[Test]
|
||||
public async Task AcceptRequest_ShouldReturnOk_WhenSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var friendship = _fixture.Build<Friendship>()
|
||||
.With(f => f.Status, FriendshipStatus.Pending)
|
||||
.Create();
|
||||
var dto = new FriendshipDto()
|
||||
{
|
||||
Id = friendship.Id,
|
||||
Status = FriendshipStatus.Accepted,
|
||||
AddresseeId = friendship.AddresseeId,
|
||||
RequesterId = friendship.RequesterId
|
||||
};
|
||||
|
||||
_mapperMock.Setup(f => f.Map<FriendshipDto>(friendship))
|
||||
.Returns(dto);
|
||||
|
||||
_friendRequestServiceMock.Setup(f => f.AcceptAsync(friendship.Id, _userId))
|
||||
.ReturnsAsync(friendship);
|
||||
|
||||
// Act
|
||||
var result = await _hub.AcceptRequest(friendship.Id);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Success));
|
||||
_friendRequestServiceMock.Verify(s => s.AcceptAsync(friendship.Id, _userId), Times.Once);
|
||||
|
||||
_clientProxyMock.Verify(c => c.SendCoreAsync(
|
||||
"FriendRequestAccepted",
|
||||
It.Is<object[]>(o => o.Length == 1 && o[0] == dto),
|
||||
default), Times.Once);
|
||||
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task AcceptRequest_ShouldReturnBadRequest_InvalidOperation()
|
||||
{
|
||||
// Arrange
|
||||
var friendshipId = Guid.NewGuid();
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.AcceptAsync(friendshipId, _userId))
|
||||
.ThrowsAsync(new InvalidOperationException("Invalid"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.AcceptRequest(friendshipId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.BadRequest));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("Invalid"));
|
||||
}
|
||||
|
||||
|
||||
[Test]
|
||||
public async Task AcceptRequest_ShouldReturnUnauthorized_UnauthorizedAccess()
|
||||
{
|
||||
// Arrange
|
||||
var friendshipId = Guid.NewGuid();
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.AcceptAsync(friendshipId, _userId))
|
||||
.ThrowsAsync(new UnauthorizedAccessException("userId claim is missing or invalid"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.AcceptRequest(friendshipId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Unauthorized));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("userId claim is missing or invalid"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task AcceptRequest_ShouldReturnError_WhenSomeExceptionOccurs()
|
||||
{
|
||||
// Arrange
|
||||
var friendshipId = Guid.NewGuid();
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.AcceptAsync(friendshipId, _userId))
|
||||
.ThrowsAsync(new Exception("error"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.AcceptRequest(friendshipId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("Unexpected error! Please try later!"));
|
||||
}
|
||||
|
||||
// Test for RejectRequest action
|
||||
[Test]
|
||||
public async Task RejectRequest_ShouldReturnOk_WhenSuccess()
|
||||
{
|
||||
// Arrange
|
||||
var friendship = _fixture.Build<Friendship>()
|
||||
.With(f => f.Status, FriendshipStatus.Pending)
|
||||
.Create();
|
||||
var dto = new FriendshipDto()
|
||||
{
|
||||
Id = friendship.Id,
|
||||
Status = FriendshipStatus.Accepted,
|
||||
AddresseeId = friendship.AddresseeId,
|
||||
RequesterId = friendship.RequesterId
|
||||
};
|
||||
|
||||
_mapperMock.Setup(f => f.Map<FriendshipDto>(friendship))
|
||||
.Returns(dto);
|
||||
|
||||
_friendRequestServiceMock.Setup(f => f.RejectAsync(friendship.Id, _userId))
|
||||
.ReturnsAsync(friendship);
|
||||
|
||||
// Act
|
||||
var result = await _hub.RejectRequest(friendship.Id);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Success));
|
||||
_friendRequestServiceMock.Verify(s => s.RejectAsync(friendship.Id, _userId), Times.Once);
|
||||
|
||||
_clientProxyMock.Verify(c => c.SendCoreAsync(
|
||||
"FriendRequestRejected",
|
||||
It.Is<object[]>(o => o[0]!.Equals(dto)),
|
||||
default), Times.Once);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task RejectRequest_ShouldReturnBadRequest_InvalidOperation()
|
||||
{
|
||||
// Arrange
|
||||
var friendshipId = Guid.NewGuid();
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.RejectAsync(friendshipId, _userId))
|
||||
.ThrowsAsync(new InvalidOperationException("Invalid"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.RejectRequest(friendshipId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.BadRequest));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("Invalid"));
|
||||
}
|
||||
|
||||
|
||||
[Test]
|
||||
public async Task RejectRequest_ShouldReturnUnauthorized_UnauthorizedAccess()
|
||||
{
|
||||
// Arrange
|
||||
var friendshipId = Guid.NewGuid();
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.RejectAsync(friendshipId, _userId))
|
||||
.ThrowsAsync(new UnauthorizedAccessException("userId claim is missing or invalid"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.RejectRequest(friendshipId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Unauthorized));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("userId claim is missing or invalid"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task RejectRequest_ShouldReturnError_WhenSomeExceptionOccurs()
|
||||
{
|
||||
// Arrange
|
||||
var friendshipId = Guid.NewGuid();
|
||||
_friendRequestServiceMock
|
||||
.Setup(s => s.RejectAsync(friendshipId, _userId))
|
||||
.ThrowsAsync(new Exception("error"));
|
||||
|
||||
// Act
|
||||
var result = await _hub.RejectRequest(friendshipId);
|
||||
|
||||
// Assert
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError));
|
||||
Assert.That(result.ErrorMessage, Is.EqualTo("Unexpected error! Please try later!"));
|
||||
}
|
||||
|
||||
[TearDown]
|
||||
public void TearDown()
|
||||
{
|
||||
_hub?.Dispose();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,113 @@
|
||||
using System.Security.Claims;
|
||||
using Govor.API.Common.SignalR.Helpers;
|
||||
using Microsoft.AspNetCore.SignalR;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Moq;
|
||||
|
||||
namespace Govor.API.Tests.Common.SignalR.Helpers;
|
||||
|
||||
[TestFixture]
|
||||
[TestOf(typeof(HubUserAccessor))]
|
||||
public class HubUserAccessorTests
|
||||
{
|
||||
private HubUserAccessor _accessor = null!;
|
||||
private Mock<ILogger<HubUserAccessor>> _loggerMock = null!;
|
||||
[SetUp]
|
||||
public void SetUp()
|
||||
{
|
||||
_loggerMock = new Mock<ILogger<HubUserAccessor>>();
|
||||
_accessor = new HubUserAccessor(_loggerMock.Object);
|
||||
}
|
||||
|
||||
private HubCallerContext CreateContextWithClaims(params Claim[] claims)
|
||||
{
|
||||
var principal = new ClaimsPrincipal(new ClaimsIdentity(claims));
|
||||
var contextMock = new Mock<HubCallerContext>();
|
||||
contextMock.Setup(c => c.User).Returns(principal);
|
||||
return contextMock.Object;
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void GetUserId_ValidClaim_ReturnsGuid()
|
||||
{
|
||||
// Arrange
|
||||
var expectedGuid = Guid.NewGuid();
|
||||
var context = CreateContextWithClaims(new Claim("userId", expectedGuid.ToString()));
|
||||
|
||||
// Act
|
||||
var result = _accessor.GetUserId(context);
|
||||
|
||||
// Assert
|
||||
Assert.That(expectedGuid, Is.EqualTo(result));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void GetUserId_InvalidClaim_ThrowsException_WhenNotSuppressed()
|
||||
{
|
||||
// Arrange
|
||||
var context = CreateContextWithClaims(new Claim("userId", "not-a-guid"));
|
||||
|
||||
// Act & Assert
|
||||
Assert.Throws<UnauthorizedAccessException>(() => _accessor.GetUserId(context, suppressException: false));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void GetUserId_InvalidClaim_ReturnsEmptyGuid_WhenSuppressed()
|
||||
{
|
||||
// Arrange
|
||||
var context = CreateContextWithClaims(new Claim("userId", "not-a-guid"));
|
||||
|
||||
// Act
|
||||
var result = _accessor.GetUserId(context, suppressException: true);
|
||||
|
||||
// Assert
|
||||
Assert.That(Guid.Empty, Is.EqualTo(result));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void GetUserId_NoClaim_ThrowsException_WhenNotSuppressed()
|
||||
{
|
||||
// Arrange
|
||||
var context = CreateContextWithClaims();
|
||||
|
||||
// Act & Assert
|
||||
Assert.Throws<UnauthorizedAccessException>(() => _accessor.GetUserId(context, suppressException: false));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void GetUserId_NoClaim_ReturnsEmptyGuid_WhenSuppressed()
|
||||
{
|
||||
// Arrange
|
||||
var context = CreateContextWithClaims();
|
||||
|
||||
// Act
|
||||
var result = _accessor.GetUserId(context, suppressException: true);
|
||||
|
||||
// Assert
|
||||
Assert.That(Guid.Empty, Is.EqualTo(result));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void GetUserId_UserIsNull_ReturnsEmptyGuid_WhenSuppressed()
|
||||
{
|
||||
// Arrange
|
||||
var contextMock = new Mock<HubCallerContext>();
|
||||
contextMock.Setup(c => c.User).Returns((ClaimsPrincipal?)null);
|
||||
|
||||
// Act
|
||||
var result = _accessor.GetUserId(contextMock.Object, suppressException: true);
|
||||
|
||||
// Assert
|
||||
Assert.That(Guid.Empty, Is.EqualTo(result));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void GetUserId_UserIsNull_ThrowsException_WhenNotSuppressed()
|
||||
{
|
||||
// Arrange
|
||||
var contextMock = new Mock<HubCallerContext>();
|
||||
contextMock.Setup(c => c.User).Returns((ClaimsPrincipal?)null);
|
||||
// Act & Assert
|
||||
Assert.Throws<UnauthorizedAccessException>(() => _accessor.GetUserId(contextMock.Object, suppressException: false));
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,142 @@
|
||||
using Govor.API.Hubs.Infrastructure;
|
||||
|
||||
namespace Govor.API.Tests.Unit.Hubs.Infrastructure;
|
||||
|
||||
[TestFixture]
|
||||
public class ConnectionStoreTests
|
||||
{
|
||||
private ConnectionStore _store = null!;
|
||||
[SetUp]
|
||||
public void Setup()
|
||||
{
|
||||
_store = new ConnectionStore();
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void AddConnection_AddsConnection()
|
||||
{
|
||||
// Arrange
|
||||
var userId = Guid.NewGuid();
|
||||
var connectionId = "conn1";
|
||||
|
||||
// Act
|
||||
_store.AddConnection(userId, connectionId);
|
||||
|
||||
var connections = _store.GetConnections(userId);
|
||||
|
||||
// Assert
|
||||
Assert.That(connections, Contains.Item(connectionId));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void AddConnection_DoesNotDuplicateConnection()
|
||||
{
|
||||
// Arrange
|
||||
var userId = Guid.NewGuid();
|
||||
var connectionId = "conn1";
|
||||
|
||||
// Act
|
||||
_store.AddConnection(userId, connectionId);
|
||||
_store.AddConnection(userId, connectionId);
|
||||
|
||||
var connections = _store.GetConnections(userId).ToList();
|
||||
|
||||
// Assert
|
||||
Assert.That(connections.Count, Is.EqualTo(1));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void RemoveConnection_RemovesConnection()
|
||||
{
|
||||
// Arrange
|
||||
var userId = Guid.NewGuid();
|
||||
var connectionId = "conn1";
|
||||
|
||||
// Act
|
||||
_store.AddConnection(userId, connectionId);
|
||||
_store.RemoveConnection(userId, connectionId);
|
||||
|
||||
var connections = _store.GetConnections(userId);
|
||||
// Assert
|
||||
Assert.That(connections, Is.Empty);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void RemoveConnection_LastConnection_RemovesUserEntry()
|
||||
{
|
||||
// Arrange
|
||||
var userId = Guid.NewGuid();
|
||||
var connectionId = "conn1";
|
||||
|
||||
// Act
|
||||
_store.AddConnection(userId, connectionId);
|
||||
_store.RemoveConnection(userId, connectionId);
|
||||
|
||||
var connections = _store.GetConnections(userId);
|
||||
|
||||
// Assert
|
||||
Assert.That(connections, Is.Empty);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void RemoveConnection_NonExistingUser_DoesNotThrow()
|
||||
{
|
||||
// Arrange
|
||||
var userId = Guid.NewGuid();
|
||||
|
||||
// Act & Assert
|
||||
Assert.DoesNotThrow(() =>
|
||||
_store.RemoveConnection(userId, "conn1"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void GetConnections_NonExistingUser_ReturnsEmpty()
|
||||
{
|
||||
// Arrange
|
||||
var userId = Guid.NewGuid();
|
||||
|
||||
// Act
|
||||
var connections = _store.GetConnections(userId);
|
||||
|
||||
// Assert
|
||||
Assert.That(connections, Is.Empty);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void MultipleUsers_IsolatedConnections()
|
||||
{
|
||||
// Arrange
|
||||
var userA = Guid.NewGuid();
|
||||
var userB = Guid.NewGuid();
|
||||
|
||||
// Act
|
||||
_store.AddConnection(userA, "A1");
|
||||
_store.AddConnection(userB, "B1");
|
||||
|
||||
var connectionsA = _store.GetConnections(userA);
|
||||
var connectionsB = _store.GetConnections(userB);
|
||||
|
||||
// Assert
|
||||
Assert.That(connectionsA, Contains.Item("A1"));
|
||||
Assert.That(connectionsB, Contains.Item("B1"));
|
||||
Assert.That(connectionsA, Does.Not.Contain("B1"));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void MultipleConnections_ForSameUser_WorkCorrectly()
|
||||
{
|
||||
// Arrange
|
||||
var userId = Guid.NewGuid();
|
||||
|
||||
// Act
|
||||
_store.AddConnection(userId, "conn1");
|
||||
_store.AddConnection(userId, "conn2");
|
||||
|
||||
var connections = _store.GetConnections(userId).ToList();
|
||||
|
||||
// Assert
|
||||
Assert.That(connections.Count, Is.EqualTo(2));
|
||||
Assert.That(connections, Contains.Item("conn1"));
|
||||
Assert.That(connections, Contains.Item("conn2"));
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,153 @@
|
||||
using Govor.API.Hubs;
|
||||
using Govor.API.Hubs.Infrastructure;
|
||||
using Govor.Application.Infrastructure.Extensions;
|
||||
using Govor.Domain.Models;
|
||||
using Microsoft.AspNetCore.SignalR;
|
||||
using Moq;
|
||||
|
||||
namespace Govor.API.Tests.Unit.Hubs.Infrastructure;
|
||||
|
||||
[TestFixture]
|
||||
public class PrivateChatGroupManagerTests
|
||||
{
|
||||
private Mock<IConnectionStore> _connectionStoreMock = null!;
|
||||
private Mock<IHubContext<ChatsHub>> _hubContextMock = null!;
|
||||
private Mock<IGroupManager> _groupsMock = null!;
|
||||
private PrivateChatGroupManager _service = null!;
|
||||
[SetUp]
|
||||
public void Setup()
|
||||
{
|
||||
_connectionStoreMock = new Mock<IConnectionStore>();
|
||||
|
||||
_groupsMock = new Mock<IGroupManager>();
|
||||
|
||||
_hubContextMock = new Mock<IHubContext<ChatsHub>>();
|
||||
_hubContextMock
|
||||
.SetupGet(h => h.Groups)
|
||||
.Returns(_groupsMock.Object);
|
||||
|
||||
_service = new PrivateChatGroupManager(
|
||||
_connectionStoreMock.Object,
|
||||
_hubContextMock.Object);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task AddUsersToPrivateChatGroupAsync_AddsAllConnectionsToGroup()
|
||||
{
|
||||
// Arrange
|
||||
var chat = new PrivateChat
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
UserAId = Guid.NewGuid(),
|
||||
UserBId = Guid.NewGuid()
|
||||
};
|
||||
|
||||
var connectionsA = new List<string> { "connA1", "connA2" };
|
||||
var connectionsB = new List<string> { "connB1" };
|
||||
|
||||
_connectionStoreMock
|
||||
.Setup(s => s.GetConnections(chat.UserAId))
|
||||
.Returns(connectionsA);
|
||||
|
||||
_connectionStoreMock
|
||||
.Setup(s => s.GetConnections(chat.UserBId))
|
||||
.Returns(connectionsB);
|
||||
|
||||
var expectedGroup = ChatHubConstants.GetPrivateChat(chat.Id);
|
||||
|
||||
// Act
|
||||
await _service.AddUsersToPrivateChatGroupAsync(chat);
|
||||
|
||||
// Assert
|
||||
foreach (var conn in connectionsA.Concat(connectionsB))
|
||||
{
|
||||
_groupsMock.Verify(
|
||||
g => g.AddToGroupAsync(conn, expectedGroup, default),
|
||||
Times.Once);
|
||||
}
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task RemoveUsersFromPrivateChatGroupAsync_RemovesAllConnectionsFromGroup()
|
||||
{
|
||||
// Arrange
|
||||
var chat = new PrivateChat
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
UserAId = Guid.NewGuid(),
|
||||
UserBId = Guid.NewGuid()
|
||||
};
|
||||
|
||||
var connectionsA = new List<string> { "connA1" };
|
||||
var connectionsB = new List<string> { "connB1", "connB2" };
|
||||
|
||||
_connectionStoreMock
|
||||
.Setup(s => s.GetConnections(chat.UserAId))
|
||||
.Returns(connectionsA);
|
||||
|
||||
_connectionStoreMock
|
||||
.Setup(s => s.GetConnections(chat.UserBId))
|
||||
.Returns(connectionsB);
|
||||
|
||||
var expectedGroup = ChatHubConstants.GetPrivateChat(chat.Id);
|
||||
|
||||
// Act
|
||||
await _service.RemoveUsersFromPrivateChatGroupAsync(chat);
|
||||
|
||||
// Assert
|
||||
foreach (var conn in connectionsA.Concat(connectionsB))
|
||||
{
|
||||
_groupsMock.Verify(
|
||||
g => g.RemoveFromGroupAsync(conn, expectedGroup, default),
|
||||
Times.Once);
|
||||
}
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task AddUsersToPrivateChatGroupAsync_NoConnections_DoesNothing()
|
||||
{
|
||||
// Arrange
|
||||
var chat = new PrivateChat
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
UserAId = Guid.NewGuid(),
|
||||
UserBId = Guid.NewGuid()
|
||||
};
|
||||
|
||||
_connectionStoreMock
|
||||
.Setup(s => s.GetConnections(It.IsAny<Guid>()))
|
||||
.Returns(new List<string>());
|
||||
|
||||
// Act
|
||||
await _service.AddUsersToPrivateChatGroupAsync(chat);
|
||||
|
||||
// Assert
|
||||
_groupsMock.Verify(
|
||||
g => g.AddToGroupAsync(It.IsAny<string>(), It.IsAny<string>(), default),
|
||||
Times.Never);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task RemoveUsersFromPrivateChatGroupAsync_NoConnections_DoesNothing()
|
||||
{
|
||||
// Arrange
|
||||
var chat = new PrivateChat
|
||||
{
|
||||
Id = Guid.NewGuid(),
|
||||
UserAId = Guid.NewGuid(),
|
||||
UserBId = Guid.NewGuid()
|
||||
};
|
||||
|
||||
_connectionStoreMock
|
||||
.Setup(s => s.GetConnections(It.IsAny<Guid>()))
|
||||
.Returns(new List<string>());
|
||||
|
||||
// Act
|
||||
await _service.RemoveUsersFromPrivateChatGroupAsync(chat);
|
||||
|
||||
// Assert
|
||||
_groupsMock.Verify(
|
||||
g => g.RemoveFromGroupAsync(It.IsAny<string>(), It.IsAny<string>(), default),
|
||||
Times.Never);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,153 @@
|
||||
using Govor.API.Common.SignalR.Helpers;
|
||||
using Govor.API.Hubs;
|
||||
using Govor.Application.Friends;
|
||||
using Govor.Application.Medias;
|
||||
using Govor.Application.Profiles;
|
||||
using Govor.Application.Synching;
|
||||
using Govor.Application.Users.UserOnlineStatus;
|
||||
using Govor.Contracts.Responses.SignalR;
|
||||
using Govor.Domain.Common;
|
||||
using Govor.Domain.Models.Users;
|
||||
using Microsoft.AspNetCore.SignalR;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Moq;
|
||||
using SmartRes;
|
||||
|
||||
namespace Govor.API.Tests.Unit.Hubs;
|
||||
|
||||
[TestFixture]
|
||||
public class ProfileHubTests
|
||||
{
|
||||
private readonly Guid _user = Guid.NewGuid(), _friend = Guid.NewGuid();
|
||||
private Mock<IFriendshipService> _friends = null!;
|
||||
private Mock<IProfileService> _profiles = null!;
|
||||
private Mock<IMediaService> _media = null!;
|
||||
private Mock<IClientProxy> _proxy = null!;
|
||||
private Mock<IHubCallerClients> _clients = null!;
|
||||
private Mock<IGroupManager> _groups = null!;
|
||||
private ProfileHub _hub = null!;
|
||||
private List<string> _recipients = null!;
|
||||
|
||||
[SetUp]
|
||||
public void Setup()
|
||||
{
|
||||
_friends = new(); _profiles = new(); _media = new(); _proxy = new(); _clients = new(); _groups = new(); _recipients = [];
|
||||
var accessor = new Mock<IHubUserAccessor>(); accessor.Setup(x => x.GetUserId(It.IsAny<HubCallerContext>(), It.IsAny<bool>())).Returns(_user);
|
||||
var sync = new Mock<ISynchingService>(); sync.Setup(x => x.NormalizeNewlines(It.IsAny<string>())).Returns((string s) => s.Replace("\r\n", "\n"));
|
||||
_clients.Setup(x => x.Groups(It.IsAny<IReadOnlyList<string>>())).Callback<IReadOnlyList<string>>(ids => _recipients.AddRange(ids)).Returns(_proxy.Object);
|
||||
var context = new Mock<HubCallerContext>(); context.SetupGet(x => x.ConnectionId).Returns("connection");
|
||||
_friends.Setup(x => x.GetFriendsAsync(_user)).ReturnsAsync([new() {Id = _friend}, new() {Id = Guid.Empty}]);
|
||||
_friends.Setup(x => x.GetPotentialFriendsAsync(_user)).ReturnsAsync([new() {Id = _friend}, new() {Id = Guid.Empty}]);
|
||||
_profiles.Setup(x => x.SetDescription(It.IsAny<string>(), _user)).ReturnsAsync(SmartRes.Unit.Value);
|
||||
_profiles.Setup(x => x.SetNewIcon(_user, It.IsAny<Guid>())).ReturnsAsync(SmartRes.Unit.Value);
|
||||
_media.Setup(x => x.HasMediaAsync(It.IsAny<Guid>())).ReturnsAsync(true);
|
||||
_hub = new(_friends.Object, _profiles.Object, accessor.Object, sync.Object, _media.Object, NullLogger<ProfileHub>.Instance) { Clients = _clients.Object, Context = context.Object, Groups = _groups.Object };
|
||||
}
|
||||
[TearDown] public void TearDown() => _hub.Dispose();
|
||||
|
||||
[TestCase(null)] [TestCase("")]
|
||||
public async Task DescriptionNullIsRejectedAndEmptyIsAllowed(string? description)
|
||||
{
|
||||
var result = await _hub.SetDescription(description);
|
||||
Assert.That(result.Status, Is.EqualTo(description is null ? HubResultStatus.BadRequest : HubResultStatus.Success));
|
||||
if (description is null) _profiles.VerifyNoOtherCalls();
|
||||
}
|
||||
[TestCase(500, HubResultStatus.Success)] [TestCase(501, HubResultStatus.BadRequest)]
|
||||
public async Task DescriptionLengthBoundary(int size, HubResultStatus expected) => Assert.That((await _hub.SetDescription(new string('a',size))).Status, Is.EqualTo(expected));
|
||||
|
||||
[Test]
|
||||
public async Task DescriptionNormalizesAndNotifiesDistinctNonemptyRecipients()
|
||||
{
|
||||
var result = await _hub.SetDescription("one\r\ntwo");
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Success));
|
||||
_profiles.Verify(x => x.SetDescription("one\ntwo", _user), Times.Once);
|
||||
Assert.That(_recipients, Is.EquivalentTo(new[] {$"user:{_user}", $"user:{_friend}"}));
|
||||
_proxy.Verify(x => x.SendCoreAsync("DescriptionUpdated", It.Is<object?[]>(args => args.Length == 1), default), Times.Once);
|
||||
}
|
||||
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task ProfileServiceFailuresDoNotNotify(bool avatar)
|
||||
{
|
||||
_profiles.Setup(x => x.SetDescription(It.IsAny<string>(), _user)).ReturnsAsync(Result.Failure<SmartRes.Unit>(Error.Forbidden("denied", "denied")));
|
||||
_profiles.Setup(x => x.SetNewIcon(_user, It.IsAny<Guid>())).ReturnsAsync(Result.Failure<SmartRes.Unit>(Error.Forbidden("denied", "denied")));
|
||||
var result = avatar ? await _hub.SetAvatar(Guid.NewGuid()) : await _hub.SetDescription("hello");
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.Forbidden)); _proxy.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task ProfileServiceExceptionsReturnServerError(bool avatar)
|
||||
{
|
||||
_profiles.Setup(x => x.SetDescription(It.IsAny<string>(), _user)).ThrowsAsync(new Exception("failure"));
|
||||
_profiles.Setup(x => x.SetNewIcon(_user, It.IsAny<Guid>())).ThrowsAsync(new Exception("failure"));
|
||||
var result = avatar ? await _hub.SetAvatar(Guid.NewGuid()) : await _hub.SetDescription("hello");
|
||||
Assert.That(result.Status, Is.EqualTo(HubResultStatus.ServerError)); _proxy.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[TestCase(true)] [TestCase(false)]
|
||||
public async Task InvalidAvatarNeverChangesProfile(bool empty)
|
||||
{
|
||||
_media.Setup(x => x.HasMediaAsync(It.IsAny<Guid>())).ReturnsAsync(false);
|
||||
Assert.That((await _hub.SetAvatar(empty ? Guid.Empty : Guid.NewGuid())).Status, Is.EqualTo(HubResultStatus.BadRequest));
|
||||
_profiles.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task AvatarPersistsAndNotifies()
|
||||
{
|
||||
var icon = Guid.NewGuid();
|
||||
Assert.That((await _hub.SetAvatar(icon)).Status, Is.EqualTo(HubResultStatus.Success));
|
||||
_profiles.Verify(x => x.SetNewIcon(_user, icon), Times.Once);
|
||||
_proxy.Verify(x => x.SendCoreAsync("AvatarUpdated", It.IsAny<object?[]>(), default), Times.Once);
|
||||
}
|
||||
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task NotificationFailuresDoNotUndoPersistedProfile(bool deliveryFailure)
|
||||
{
|
||||
if (deliveryFailure) _proxy.Setup(x => x.SendCoreAsync(It.IsAny<string>(), It.IsAny<object?[]>(), default)).ThrowsAsync(new Exception("transport"));
|
||||
else {
|
||||
_friends.Setup(x => x.GetFriendsAsync(_user)).ThrowsAsync(new Exception("friends"));
|
||||
_friends.Setup(x => x.GetPotentialFriendsAsync(_user)).ThrowsAsync(new Exception("potential"));
|
||||
}
|
||||
Assert.That((await _hub.SetDescription("hello")).Status, Is.EqualTo(HubResultStatus.Success));
|
||||
if (!deliveryFailure) Assert.That(_recipients, Is.EqualTo(new[] { $"user:{_user}" }));
|
||||
}
|
||||
|
||||
[TestCase(false)] [TestCase(true)]
|
||||
public async Task LifecycleMaintainsUserGroup(bool error)
|
||||
{
|
||||
await _hub.OnConnectedAsync(); await _hub.OnDisconnectedAsync(error ? new Exception("disconnect") : null);
|
||||
_groups.Verify(x => x.AddToGroupAsync("connection", $"user:{_user}", default), Times.Once);
|
||||
_groups.Verify(x => x.RemoveFromGroupAsync("connection", $"user:{_user}", default), Times.Once);
|
||||
}
|
||||
}
|
||||
|
||||
[TestFixture]
|
||||
public class PresenceHubTests
|
||||
{
|
||||
[TestCase(true, true)] [TestCase(true, false)] [TestCase(false, true)] [TestCase(false, false)]
|
||||
public async Task OnlyFirstConnectionAndLastDisconnectionBroadcast(bool first, bool last)
|
||||
{
|
||||
var user = Guid.NewGuid(); var friend = Guid.NewGuid();
|
||||
var accessor = new Mock<IHubUserAccessor>(); accessor.Setup(x => x.GetUserId(It.IsAny<HubCallerContext>(), It.IsAny<bool>())).Returns(user);
|
||||
var store = new Mock<IOnlineUserStore>(); store.Setup(x => x.AddConnection(user,"connection")).Returns(first); store.Setup(x => x.RemoveConnection(user,"connection")).Returns(last);
|
||||
var scope = new Mock<IUserNotificationScopeService>(); scope.Setup(x => x.GetNotifiedUsers(user)).ReturnsAsync([friend]);
|
||||
var proxy = new Mock<IClientProxy>(); var clients = new Mock<IHubCallerClients>(); clients.Setup(x => x.Groups(It.Is<IReadOnlyList<string>>(ids => ids.SequenceEqual(new[] {friend.ToString()})))).Returns(proxy.Object);
|
||||
var groups = new Mock<IGroupManager>(); var context = new Mock<HubCallerContext>(); context.SetupGet(x => x.ConnectionId).Returns("connection");
|
||||
using var hub = new PresenceHub(NullLogger<PresenceHub>.Instance,scope.Object,store.Object,accessor.Object) { Context = context.Object, Clients = clients.Object, Groups = groups.Object };
|
||||
await hub.OnConnectedAsync(); await hub.OnDisconnectedAsync(null!);
|
||||
proxy.Verify(x => x.SendCoreAsync("UserOnline",It.Is<object?[]>(args => Equals(args[0],user)),default),first ? Times.Once() : Times.Never());
|
||||
proxy.Verify(x => x.SendCoreAsync("UserOffline",It.Is<object?[]>(args => Equals(args[0],user)),default),last ? Times.Once() : Times.Never());
|
||||
groups.Verify(x => x.AddToGroupAsync("connection",user.ToString(),default),Times.Once);
|
||||
groups.Verify(x => x.RemoveFromGroupAsync("connection",user.ToString(),default),Times.Once);
|
||||
}
|
||||
[Test]
|
||||
public async Task InvalidUserAbortsWithoutStoreOrNotifications()
|
||||
{
|
||||
var accessor = new Mock<IHubUserAccessor>(); var context = new Mock<HubCallerContext>();
|
||||
var store = new Mock<IOnlineUserStore>(MockBehavior.Strict); var scope = new Mock<IUserNotificationScopeService>(MockBehavior.Strict);
|
||||
using var hub = new PresenceHub(NullLogger<PresenceHub>.Instance,scope.Object,store.Object,accessor.Object) {Context=context.Object};
|
||||
await hub.OnConnectedAsync(); await hub.OnDisconnectedAsync(null!);
|
||||
context.Verify(x => x.Abort(),Times.Once); store.VerifyNoOtherCalls(); scope.VerifyNoOtherCalls();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user