mirror of
https://github.com/Govor-team/Govor.git
synced 2026-11-18 13:24:59 +00:00
Expand server tests and enforce coverage
Consolidate server tests under tests/, upgrade them to .NET 10, and add CI coverage thresholds and reports. Expand API and application boundary coverage while fixing related issues in media handling, friend blocking, session crypto, presence, username validation, and local storage.
This commit is contained in:
@@ -0,0 +1,102 @@
|
||||
using Govor.Application.Authentication;
|
||||
using Govor.Application.Infrastructure.Common;
|
||||
using Govor.Application.Infrastructure.Validators;
|
||||
using Govor.Application.Users;
|
||||
using Govor.Domain.Common;
|
||||
using Microsoft.EntityFrameworkCore;
|
||||
using Moq;
|
||||
|
||||
namespace Govor.Application.Tests.Authentication;
|
||||
|
||||
[TestFixture]
|
||||
public class AuthServiceTests
|
||||
{
|
||||
private TestDatabase _db = null!;
|
||||
private AuthService _service = null!;
|
||||
private Mock<IPasswordHasher> _hasher = null!;
|
||||
private readonly DateTime _now = new(2026, 10, 24, 0, 0, 0, DateTimeKind.Utc);
|
||||
|
||||
[SetUp]
|
||||
public void SetUp()
|
||||
{
|
||||
_db = new TestDatabase();
|
||||
_hasher = new Mock<IPasswordHasher>();
|
||||
_hasher.Setup(h => h.Hash(It.IsAny<string>())).Returns("hashed-password");
|
||||
_hasher.Setup(h => h.Verify("correct", It.IsAny<string>())).Returns(true);
|
||||
var validator = new Mock<IUsernameValidator>();
|
||||
validator.Setup(v => v.Validate(It.IsAny<string>())).Returns(Result.Success());
|
||||
var clock = new Mock<INowDateTimeProvider>();
|
||||
clock.SetupGet(c => c.Now).Returns(_now);
|
||||
_service = new AuthService(_db.Context, new UserNameExistValidator(_db.Context),
|
||||
_hasher.Object, validator.Object, clock.Object);
|
||||
}
|
||||
|
||||
[TearDown] public void TearDown() => _db.Dispose();
|
||||
|
||||
[TestCase(false)]
|
||||
[TestCase(true)]
|
||||
public async Task RegistrationPersistsAccountReservesInvitationAndAssignsRole(bool admin)
|
||||
{
|
||||
var invite = await _db.Context.Invitations.SingleAsync();
|
||||
invite.IsAdmin = admin;
|
||||
await _db.Context.SaveChangesAsync();
|
||||
var result = await _service.RegistrationAsync("Новый", "secret", invite);
|
||||
Assert.That(result.IsSuccess, Is.True);
|
||||
_db.Context.ChangeTracker.Clear();
|
||||
var user = await _db.Context.Users.SingleAsync(u => u.Id == result.Value.Id);
|
||||
Assert.Multiple(() =>
|
||||
{
|
||||
Assert.That(user.Username, Is.EqualTo("Новый"));
|
||||
Assert.That(user.PasswordHash, Is.EqualTo("hashed-password"));
|
||||
Assert.That(user.CreatedOn, Is.EqualTo(DateOnly.FromDateTime(_now)));
|
||||
Assert.That(user.InviteId, Is.EqualTo(invite.Id));
|
||||
});
|
||||
Assert.That(await _db.Context.Admins.AnyAsync(a => a.UserId == user.Id), Is.EqualTo(admin));
|
||||
Assert.That((await _db.Context.Invitations.SingleAsync()).Participants, Is.EqualTo(1));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task ExistingUsernameReturnsConflictWithoutConsumingInvitation()
|
||||
{
|
||||
var user = await _db.Context.Users.FirstAsync();
|
||||
var invite = await _db.Context.Invitations.SingleAsync();
|
||||
var result = await _service.RegistrationAsync(user.Username, "secret", invite);
|
||||
Assert.That(result.Error.Type, Is.EqualTo(ErrorType.Conflict));
|
||||
Assert.That((await _db.Context.Invitations.AsNoTracking().SingleAsync()).Participants, Is.Zero);
|
||||
_hasher.Verify(h => h.Hash(It.IsAny<string>()), Times.Never);
|
||||
}
|
||||
|
||||
[TestCase("expired")]
|
||||
[TestCase("full")]
|
||||
[TestCase("inactive")]
|
||||
public async Task UnavailableInvitationDoesNotCreateAccount(string reason)
|
||||
{
|
||||
var invite = await _db.Context.Invitations.SingleAsync();
|
||||
if (reason == "expired") invite.EndDate = _now;
|
||||
if (reason == "full") invite.MaxParticipants = 3;
|
||||
if (reason == "inactive") invite.IsActive = false;
|
||||
await _db.Context.SaveChangesAsync();
|
||||
var result = await _service.RegistrationAsync("Новый", "secret", invite);
|
||||
Assert.That(result.Error.Code, Is.EqualTo("Auth.InvitationUnavailable"));
|
||||
Assert.That(await _db.Context.Users.CountAsync(), Is.EqualTo(3));
|
||||
}
|
||||
|
||||
[TestCase("correct", true)]
|
||||
[TestCase("wrong", false)]
|
||||
public async Task LoginVerifiesStoredPassword(string password, bool success)
|
||||
{
|
||||
var user = await _db.Context.Users.FirstAsync();
|
||||
var result = await _service.LoginAsync(user.Username, password);
|
||||
Assert.That(result.IsSuccess, Is.EqualTo(success));
|
||||
_hasher.Verify(h => h.Verify(password, user.PasswordHash), Times.Once);
|
||||
if (success) Assert.That(result.Value.Id, Is.EqualTo(user.Id));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task MissingUserReturnsNotFound()
|
||||
{
|
||||
var result = await _service.LoginAsync("missing", "secret");
|
||||
Assert.That(result.Error.Type, Is.EqualTo(ErrorType.NotFound));
|
||||
_hasher.Verify(h => h.Verify(It.IsAny<string>(), It.IsAny<string>()), Times.Never);
|
||||
}
|
||||
}
|
||||
+49
@@ -0,0 +1,49 @@
|
||||
using Govor.Application.Infrastructure.Common;
|
||||
using Govor.Application.Users;
|
||||
using Govor.Domain.Common;
|
||||
using Govor.Domain.Models;
|
||||
using Microsoft.EntityFrameworkCore;
|
||||
using Moq;
|
||||
|
||||
namespace Govor.Application.Tests.Integration.Authentication;
|
||||
|
||||
[TestFixture]
|
||||
public class AuthenticationFailureTests
|
||||
{
|
||||
[Test]
|
||||
public async Task InvalidUsernameStopsRegistrationBeforePasswordHashOrDatabaseWrite()
|
||||
{
|
||||
using var db = new TestDatabase();
|
||||
var error = Error.Validation("Username.Invalid", "invalid username");
|
||||
var validator = new Mock<IUsernameValidator>();
|
||||
validator.Setup(v => v.Validate("bad")).Returns(Result.Failure(error));
|
||||
var hasher = new Mock<IPasswordHasher>(MockBehavior.Strict);
|
||||
var exists = new Mock<IUserNameExistValidator>(MockBehavior.Strict);
|
||||
var service = new AuthService(db.Context, exists.Object, hasher.Object, validator.Object, Mock.Of<INowDateTimeProvider>());
|
||||
var result = await service.RegistrationAsync("bad", "password", await db.Context.Invitations.SingleAsync());
|
||||
Assert.That(result.Error, Is.SameAs(error));
|
||||
Assert.That(await db.Context.Users.CountAsync(), Is.EqualTo(3));
|
||||
hasher.VerifyNoOtherCalls();
|
||||
exists.VerifyNoOtherCalls();
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task NonChannelRequiredGroupRejectsRegistrationWithoutConsumingInvitation()
|
||||
{
|
||||
using var db = new TestDatabase();
|
||||
var group = new ChatGroup { Id = Guid.NewGuid(), Name = "not a channel", Description = "" };
|
||||
db.Context.ChatGroups.Add(group);
|
||||
(await db.Context.ServerCommunitySettings.SingleAsync()).RequiredChannelId = group.Id;
|
||||
await db.Context.SaveChangesAsync();
|
||||
var validator = Mock.Of<IUsernameValidator>(v => v.Validate("Новый") == Result.Success());
|
||||
var hasher = Mock.Of<IPasswordHasher>(h => h.Hash("password") == "hash");
|
||||
var service = new AuthService(db.Context, new UserNameExistValidator(db.Context), hasher, validator,
|
||||
Mock.Of<INowDateTimeProvider>(c => c.Now == DateTime.UtcNow.Date));
|
||||
var invitation = await db.Context.Invitations.SingleAsync();
|
||||
var result = await service.RegistrationAsync("Новый", "password", invitation);
|
||||
Assert.That(result.Error.Code, Is.EqualTo("Auth.RequiredChannelUnavailable"));
|
||||
Assert.That(await db.Context.Users.CountAsync(), Is.EqualTo(3));
|
||||
Assert.That((await db.Context.Invitations.AsNoTracking().SingleAsync()).Participants, Is.Zero);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user