Expand server tests and enforce coverage

Consolidate server tests under tests/, upgrade them to .NET 10, and add CI coverage thresholds and reports. Expand API and application boundary coverage while fixing related issues in media handling, friend blocking, session crypto, presence, username validation, and local storage.
This commit is contained in:
Artemy
2026-10-24 15:30:32 +07:00
parent 33550d4fc9
commit 2d99c57a3b
161 changed files with 5515 additions and 8419 deletions
@@ -0,0 +1,70 @@
using Govor.Application.Medias;
using Govor.Domain.Models;
using Govor.Domain.Models.Messages;
using Microsoft.EntityFrameworkCore;
namespace Govor.Application.Tests.Medias;
[TestFixture]
public class MediaAccessTests
{
private TestDatabase _db = null!;
private AccesserToDownloadMediaService _service = null!;
[SetUp] public void SetUp() { _db = new TestDatabase(); _service = new(_db.Context); }
[TearDown] public void TearDown() => _db.Dispose();
private async Task<MediaFile> AddMedia(MediaOwnerType type, Guid? owner = null)
{
var media = new MediaFile { Id = Guid.NewGuid(), UploaderId = _db.Alice, Url = "test.bin",
MineType = "application/octet-stream", OwnerType = type, OwnerId = owner, DateCreated = DateTime.UtcNow };
_db.Context.MediaFiles.Add(media);
await _db.Context.SaveChangesAsync();
return media;
}
[Test]
public async Task MessageAttachmentIsAvailableOnlyToChatParticipants()
{
var message = _db.AddMessage();
var media = await AddMedia(MediaOwnerType.Message, message.Id);
_db.Context.MediaAttachments.Add(new MediaAttachments { Id = Guid.NewGuid(), MessageId = message.Id, MediaFileId = media.Id });
await _db.Context.SaveChangesAsync();
Assert.That(await _service.HasAccessAsync(media.Id, _db.Alice), Is.True);
Assert.That(await _service.HasAccessAsync(media.Id, _db.Bob), Is.True);
Assert.That(await _service.HasAccessAsync(media.Id, _db.Outsider), Is.False);
}
[TestCase(MediaOwnerType.Avatar)]
[TestCase(MediaOwnerType.System)]
public async Task PublicMediaCanBeDownloaded(MediaOwnerType type) =>
Assert.That(await _service.HasAccessAsync((await AddMedia(type)).Id, _db.Outsider), Is.True);
[TestCase(MediaOwnerType.Message)]
[TestCase(MediaOwnerType.Reaction)]
[TestCase((MediaOwnerType)99)]
public async Task UnattachedMediaCannotBeDownloaded(MediaOwnerType type) =>
Assert.That(await _service.HasAccessAsync((await AddMedia(type)).Id, _db.Alice), Is.False);
[Test]
public async Task UnknownMediaCannotBeDownloaded() =>
Assert.That(await _service.HasAccessAsync(Guid.NewGuid(), _db.Alice), Is.False);
[TestCase(false)]
[TestCase(true)]
public async Task GroupAvatarRequiresMembershipForPrivateGroupAndRejectsBannedMembers(bool isPrivate)
{
var group = new ChatGroup { Id = Guid.NewGuid(), Name = "group", Description = "", IsPrivate = isPrivate };
_db.Context.ChatGroups.Add(group);
var member = new GroupMembership { Id = Guid.NewGuid(), GroupId = group.Id, UserId = _db.Bob };
_db.Context.GroupMemberships.Add(member);
await _db.Context.SaveChangesAsync();
var media = await AddMedia(MediaOwnerType.GroupAvatar, group.Id);
group.ImageId = media.Id;
await _db.Context.SaveChangesAsync();
Assert.That(await _service.HasAccessAsync(media.Id, _db.Bob), Is.True);
Assert.That(await _service.HasAccessAsync(media.Id, _db.Outsider), Is.EqualTo(!isPrivate));
member.IsBanned = true;
await _db.Context.SaveChangesAsync();
Assert.That(await _service.HasAccessAsync(media.Id, _db.Bob), Is.False);
}
}
@@ -0,0 +1,110 @@
using Govor.Domain.Common;
using Govor.Domain.Models;
using Govor.Domain.Models.Messages;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Logging.Abstractions;
using Moq;
namespace Govor.Application.Tests.Integration.Medias;
[TestFixture]
public class MediaServiceTests
{
private TestDatabase _db = null!;
private Mock<IStorageService> _storage = null!;
private MediaService _service = null!;
[SetUp]
public void SetUp()
{
_db = new TestDatabase();
_storage = new Mock<IStorageService>();
_storage.Setup(s => s.SaveAsync(It.IsAny<byte[]>(), It.IsAny<string>())).ReturnsAsync("folder/test.bin");
_storage.Setup(s => s.LoadAsync("folder/test.bin")).ReturnsAsync(() => new MemoryStream(new byte[] { 1, 2, 3 }));
_service = new(_storage.Object, _db.Context, NullLogger<MediaService>.Instance);
}
[TearDown] public void TearDown() => _db.Dispose();
private Task<SmartRes.Result<MediaUploadResult, Error>> Upload(MediaOwnerType type = MediaOwnerType.Message) =>
_service.UploadMediaAsync(new Media(_db.Alice, DateTime.UtcNow, "test.bin", new byte[] { 1, 2, 3 },
MediaType.File, "application/octet-stream", "", type, null));
[Test]
public async Task UploadReadByIdAndUrlAndDeleteRoundTrip()
{
var uploaded = (await Upload()).Value;
_db.Context.ChangeTracker.Clear();
Assert.That(await _service.HasMediaAsync(uploaded.MediaId), Is.True);
Assert.That(await _service.HasMediaByUrlAsync(uploaded.Url), Is.True);
foreach (var media in new[] { (await _service.GetMediaByIdAsync(uploaded.MediaId)).Value,
(await _service.GetMediaByUrlAsync(uploaded.Url)).Value })
{
Assert.That(media.Data, Is.EqualTo(new byte[] { 1, 2, 3 }));
Assert.That(media.UploaderId, Is.EqualTo(_db.Alice));
Assert.That(media.FileName, Is.EqualTo("test.bin"));
Assert.That(media.MimeType, Is.EqualTo("application/octet-stream"));
Assert.That(media.EncryptedKey, Is.Empty);
}
Assert.That((await _service.DeleteMediaAsync(uploaded.MediaId)).IsSuccess, Is.True);
Assert.That(await _service.HasMediaAsync(uploaded.MediaId), Is.False);
Assert.That(await _service.HasMediaByUrlAsync(uploaded.Url), Is.False);
_storage.Verify(s => s.RemoveAsync(uploaded.Url), Times.Once);
}
[Test]
public async Task UnknownMediaOperationsReturnNotFoundAndNeverReadStorage()
{
Assert.That((await _service.GetMediaByIdAsync(Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound));
Assert.That((await _service.GetMediaByUrlAsync("unknown")).Error.Type, Is.EqualTo(ErrorType.NotFound));
Assert.That((await _service.DeleteMediaAsync(Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound));
Assert.That((await _service.AttachToMessageAsync(Guid.NewGuid(), Guid.NewGuid())).Error.Type, Is.EqualTo(ErrorType.NotFound));
_storage.VerifyNoOtherCalls();
}
[TestCase("")]
[TestCase(" ")]
[TestCase(null)]
public async Task BlankUrlReturnsValidationError(string? url) =>
Assert.That((await _service.GetMediaByUrlAsync(url!)).Error.Type, Is.EqualTo(ErrorType.Validation));
[Test]
public async Task InvalidUploadReturnsFailureWithoutMetadata()
{
_storage.Setup(s => s.SaveAsync(It.IsAny<byte[]>(), It.IsAny<string>())).ThrowsAsync(new ArgumentException("bad data"));
Assert.That((await Upload()).IsFailure, Is.True);
Assert.That(await _db.Context.MediaFiles.CountAsync(), Is.Zero);
}
[TestCase(false)]
[TestCase(true)]
public async Task MissingStorageFileReturnsServerError(bool byUrl)
{
var uploaded = (await Upload()).Value;
_storage.Setup(s => s.LoadAsync(uploaded.Url)).ThrowsAsync(new FileNotFoundException());
var result = byUrl ? await _service.GetMediaByUrlAsync(uploaded.Url) : await _service.GetMediaByIdAsync(uploaded.MediaId);
Assert.That(result.Error.Type, Is.EqualTo(ErrorType.ServerError));
Assert.That(await _service.HasMediaAsync(uploaded.MediaId), Is.True);
}
[Test]
public async Task FailedStorageDeletePreservesMetadata()
{
var uploaded = (await Upload()).Value;
_storage.Setup(s => s.RemoveAsync(uploaded.Url)).ThrowsAsync(new IOException("disk failure"));
Assert.ThrowsAsync<IOException>(() => _service.DeleteMediaAsync(uploaded.MediaId));
Assert.That(await _service.HasMediaAsync(uploaded.MediaId), Is.True);
}
[Test]
public async Task MessageMediaCanBeAssignedButAvatarCannot()
{
var messageMedia = (await Upload()).Value;
var avatar = (await Upload(MediaOwnerType.Avatar)).Value;
var message = _db.AddMessage();
Assert.That((await _service.AttachToMessageAsync(messageMedia.MediaId, message.Id)).IsSuccess, Is.True);
Assert.That((await _service.AttachToMessageAsync(avatar.MediaId, message.Id)).IsFailure, Is.True);
_db.Context.ChangeTracker.Clear();
Assert.That((await _db.Context.MediaFiles.SingleAsync(m => m.Id == messageMedia.MediaId)).OwnerId, Is.EqualTo(message.Id));
Assert.That((await _db.Context.MediaFiles.SingleAsync(m => m.Id == avatar.MediaId)).OwnerType, Is.EqualTo(MediaOwnerType.Avatar));
}
}